The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
The goal here is to leave creation stuff mostly for JS, so we can
convert it entirely over to a non-threadsafe cycle-collected version
without breaking any existing C++ users.
I didn't do this for a remaining use in nsGlobalWindow.h to avoid
including nsVariant.h all over the place.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
PSmsRequest.ipdl:
- Update ReplyGetSmscAddress to include extra parameters.
SmsChild:
- Update Recv__delete__ to reflect the change of PSmsRequest.
SmsParent:
- Update NotifyGetSmscAddress to reflect the change of PSmsRequest.
nsIMobileMessageCallback.idl
- Update the signature of NotifyGetSmscAddress and uuid.
MobileMessageCallback.cpp:
- Update NotifyGetSmscAddress to reflect the signature change and to
adapt Promise.
- Update NotifyGetSmscAddressFailed to adapt Promise.
nsISmsService.idl:
- Update the comment to emphasize NUMBER_PLAN_IDENTIFICATION constants
reflects enumeration values.
SmsService.js:
- Update the invocation of notifySmscAddress as the signature changes.
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
Ensure deletedInfo object is converted by subject.QueryInterface()
when "sms-deleted" topic observed.
--HG--
extra : rebase_source : 95351459bb2739d7e5786155934741a7641c0b2f
Birunthan Mohanathas
Tooru Fujisawa
Makoto Kato
Carsten "Tomcat" Book
Nathan Froyd
Bevis Tseng
Reuben Morais
Wes Kocher
Sebastian Hengst
Shu-yu Guo
Jeff Walden
Andrew McCreight
Nicholas Nethercote
Aryeh Gregor
younghwan.ji
Jessica Jong
Samael Wang
Ryan VanderMeulen
Jesse Ruderman
Juan Gomez
Jan de Mooij