This makes the changes necessary to use TestRunnerActivity when geckoview
is installed and requested, but we do not yet attempt to run any such
test tasks in automation.
Per spec, assinging an empty string to textContent or innerHTML should not
trigger any mutation observers, and therefore should not trigger a stylesheet
reparse, when the element is already empty.
Since we need to apply some special handling to innerHTML and textContent
assignments to <style> nodes, and therefore re-parse directly in the setter
rather than in response to mutation observers, we need to special-case this
scenario.
MozReview-Commit-ID: KdOYFs8ayT7
--HG--
extra : rebase_source : 67b85174d08028c5200964800b657950aa2bffa2
I missed a couple of references in cleanup code. This wouldn't have caused any
failures but might result in addons not being cleaned up properly.
MozReview-Commit-ID: BX0oX2GRGWT
--HG--
extra : rebase_source : 2193adb4e96b8e70faa6ffb1afd6db698b10ad2d
Removes the following deprecated WebDriver commands from marionette
client: Element.size, Element.location, set_script_timeout,
set_search_timeout, and set_page_load_timeout.
It doesn't touch get_window_position, set_window_position,
window_size, and set_window_size because those are covered
by bug 1348145.
MozReview-Commit-ID: 9b74toO1Rzm
--HG--
extra : rebase_source : a9a73cf8cc36ed3d428ce1c7c54b83b9f0f4a63c
All chrome context related commands have to use the "Marionette"
prefix. For those commands which accidentally have been put under
the "WebDriver" prefix a fallback to the old command is needed
in the Marionette client.
Also update related comments about possible removal dates.
MozReview-Commit-ID: IZLL6pineSO
--HG--
extra : rebase_source : 7e4cbe604d1f0b35cce01173a438b898658018b3
To be consistent with the spec the command should be named
"WebDriver:AcceptAlert".
MozReview-Commit-ID: HGB9hJPAvcU
--HG--
extra : rebase_source : bbf3d657901784e1ab6e096edf1b20a5c43b0176
Before we can deploy bug 1400233 which removes the JSON Object field
"ELEMENT" from Marionette, we need to make geckodriver recognise
"chromeelement-9fc5-4b51-a3c8-01716eedeb04".
Technically a chrome element is not a web element, but geckodriver
treats it as such. This is in line with previous behaviour but should at
some point be changed when WebDriver supports these types of extensions.
This patch does not drop support for the legacy web element identifier
(ELEMENT) since it would entail dropping support for Firefox 55
and later. The new element identifiers were introduced in Firefox 58.
MozReview-Commit-ID: GiBHcOcvGbh
--HG--
extra : rebase_source : aa459613024e46c88fe3754e96bbfe9cc78ddc19
For messages that have a test field (like testStart/testStatus/testEnd/etc),
the StructuredLog.jsm module converts the field to a string if it was an Array
(as used by reftest). It looks like the assertionCount message accidentally got
left out.
I don't believe this conversion should be happening in StructuredLog.jsm. It
should either happen in the formatters, or in reftest.jsm. But for now it's
better to be consistent. Another bug for another time.
MozReview-Commit-ID: DjdoEqxoujT
--HG--
extra : rebase_source : 4303eb9024835884fcf60c334f4d206db0ee6e3f
Using get_url() to wait for a page load to be done doesn't work because
it already returns when the location bar gets updated. Instead wait for
a known element of the page.
MozReview-Commit-ID: CdYux8sTAiP
--HG--
extra : rebase_source : 72d3313c3f3022d94487aa1fedc8538e5c2d8fbb
In the section of the response body parser that just skips over the
answer section, the code wrongly assumed there could only be a pointer
at the start, while in fact every label can be made as a pointer. Just
turned out to not be used very often.
MozReview-Commit-ID: 8ZYtlq8HDPw
--HG--
extra : rebase_source : cc790caf36b4d4e77b113f89ed427ee537a539d8
Both Blink and WebKit pass the added tests. But of course all this stuff was
untested initially, and my initial naive implementation would fail them.
MozReview-Commit-ID: KayYNfTXb5h
We don’t currently log what the script timeout was when throwing
ScriptTimeoutError. It would provide more value to the user to
include the timeout duration than to record "Timed out" as we do
currently.
MozReview-Commit-ID: 3DM1Xer3Qbz
--HG--
extra : rebase_source : 1c4dfc96957dd9b64562e8354526da1b7350e6cf
The Display trait implementation for ExitStatus returns "exit code:
0", leading to a convoluted sentence such as "Browser process
stopped with exit status exit code: 0".
MozReview-Commit-ID: 2D1JsFIhF7d
--HG--
extra : rebase_source : 044d1961485073a11aefc978eff3e382c59db4cc
The code was trying to assert that we had frames constructed for all the nodes
in the parent chain, but we don't bail out in the
!GetContentInsertionFrameFor(aContainer) in the case that it's a children
element, because they actually have no insertion frame, though their children
do.
Move the LazyFC check after the insertion point check. That makes the previous
check work on the insertion point of the child, which makes it sound.
This also fixes bug 1410020, and with it a Shadow DOM test-case that was failing
because we had two sibling assigned to two different <slot>s, and the second one
wasn't getting properly flagged, and thus the second sibling never got a frame.
The other two test failures in this test are an event dispatch failure, where
the position of the target is not what the test expects (we don't account for
margin and padding). Filed that as bug 1450027.
Also, added a test for which we have wrong layout without these patches, and
that crashes with "Called Servo_Element_IsDisplayNone" with the first patch of
this bug applied but not this one, due to the bogus check mentioned above.
MozReview-Commit-ID: 6OeaVrZhTDv