Automatic update from web-platform-testsFix Selection API idlharness.js test
It was entirely broken because SVGElement was unknown.
Drive-by: split out the IDL into selection-api.idl. Like with
webrtc-pc.idl, match the spec shortname and not the wpt dir.
wpt-commits: 6fbbcf8242c40b8ec0dc4ab7ebec9c7a2ae55a34
wpt-pr: 9024
wpt-commits: 6fbbcf8242c40b8ec0dc4ab7ebec9c7a2ae55a34
wpt-pr: 9024
Automatic update from web-platform-testsRemove myself from the interfaces/ owners
These notifications are not useful...
wpt-commits: c73b03f0cdd69d1a27fe339c0890aa344affabd2
wpt-pr: 9788
wpt-commits: c73b03f0cdd69d1a27fe339c0890aa344affabd2
wpt-pr: 9788
Automatic update from web-platform-testsSwitch external_host to host_ip. (#9258)
When running tests in Firefox we don't require that the hostname is
actually resolvable since we set up some internal DNS overrides. This
means that we don't actually need to have web-platform.test defined in
/etc/hosts. As a consequence when we check the server is responding,
the check will typically fail for Firefox developers if we try to
access by hostname. Previously we made use of a special dance in which
external_host held the ip at the point of the check and was later
replaced by host to actually run tests. But that changed, and instead
we relied on the fact that we (accidentially) didn't actually fail in
the case the servers couldn't be reached by host name. However in some
cases things still failed because local DNS resolved web-patform.test
to some ip address, causing hangs or other badness.
In this patch we simply add a host_ip property to the config, and
connect to that to test the servers are repopnsing rather than the
hostname. We also actually fil if we didn't manage to connect to all
the servers.
--
Run the firefox infrastructure tests without custom /etc/hosts
wpt-commits: ee314b534530038d511661148251a6351d66e7e1, 26cd868a17844c1588d473c527179d41954768c7
wpt-pr: 9651
wpt-commits: ee314b534530038d511661148251a6351d66e7e1, 26cd868a17844c1588d473c527179d41954768c7
wpt-pr: 9651
Automatic update from web-platform-testsImplement :focus-visible pseudo class.
Spec: https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-wN72ESFsyo
Adds :focus-visible to the list of known CSS pseudo classes. This change also adds a flag,
WasFocusedByMouse(), to UserActionElementSet which is exposed as Node.WasFocusedByMouse().
SelectorChecker will use this flag to check if a node matching :focus should also match
:focus-visible. By default, any node focused by mouse will NOT match :focus-visible. Any
node focused by keyboard will match :focus-visible.
Bug: 817199
R=aboxhall@chromium.org
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1a0aadc8ea653afc964865a277b2d4d2ccabe540
Reviewed-on: https://chromium-review.googlesource.com/897002
Commit-Queue: Rob Dodson <robdodson@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540537}
wpt-commits: 8444227eae2567780c6e9eb0dfbc13718814dc5d
wpt-pr: 9722
wpt-commits: 8444227eae2567780c6e9eb0dfbc13718814dc5d
wpt-pr: 9722
Automatic update from web-platform-testsRun all applicable tox envs
i.e., given a TOXENV of py27, we'll run py27 and py27-foo
--
Add test for loading the various products
--
Fix loading servo/servodriver products with installed wptrunner
wpt-commits: effe40a422f55b236d97861a31a9f7d1a4d927ab, 8eddb6c3d5675344a394aec143e58fbe8f79fa25, 00c4e79cbbd6789535d304a584a2b1737abadb97
wpt-pr: 9496
wpt-commits: effe40a422f55b236d97861a31a9f7d1a4d927ab, 8eddb6c3d5675344a394aec143e58fbe8f79fa25, 00c4e79cbbd6789535d304a584a2b1737abadb97
wpt-pr: 9496
Automatic update from web-platform-testsAdd default list value to extra-property argument. (#9746)
wpt-commits: 59d21c5f036e7016b2689fd79364ef27b844481a
wpt-pr: 9746
wpt-commits: 59d21c5f036e7016b2689fd79364ef27b844481a
wpt-pr: 9746
Automatic update from web-platform-testsAdd a test for a cross-origin redirect to a same-origin video
It's not clear to me if the expected result here is well-defined. Chrome and
my in-progress WebKit implementation pass; Gecko fails.
wpt-commits: 18ea986f738515e876e6870cd2f531a2ab1cbe0c
wpt-pr: 9314
wpt-commits: 18ea986f738515e876e6870cd2f531a2ab1cbe0c
wpt-pr: 9314
Automatic update from web-platform-testsChange navigation preload initiatorType to "navigation"
As discussed at https://github.com/w3c/resource-timing/issues/110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the `initiatorType`
for it should be "navigation", rather than other.
This CL implements that change.
Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W3InszDnV2k/AuJg4aAMDQAJ
Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
Reviewed-on: https://chromium-review.googlesource.com/941342
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540483}
wpt-commits: 34c346b8485a2c77e14d4c6d188773fc5465b5b0
wpt-pr: 9717
wpt-commits: 34c346b8485a2c77e14d4c6d188773fc5465b5b0
wpt-pr: 9717
Automatic update from web-platform-testsTests for PaymentCurrencyAmount's currencySystem (#9728)
This test is to prove that no one supports this feature - thus can be dropped from the spec.
Related issues:
* https://github.com/w3c/payment-request/issues/686
* https://github.com/w3c/payment-request/issues/617
wpt-commits: 866783a3fffaa8bdd3c29e4aec3b2f2626797c93
wpt-pr: 9728
wpt-commits: 866783a3fffaa8bdd3c29e4aec3b2f2626797c93
wpt-pr: 9728
Automatic update from web-platform-tests[css-typed-om] Whitelist supported properties.
This patch whitelists all our supported properties. Any property that
is not supported will return a base CSSStyleValue. This ensures that
we don't accidentally produce unexpected results for properties that
we haven't tested it.
We also add a few new properties to support, bringing the total number
of property tests to 50. We also remove support for 'z-index' because
it uses <integers> which we don't support yet.
transition-duration is failing tests because we currently convert
ms to seconds when we compute, which is incorrect.
Some paint/layout tests depend on properties that are not whitelisted,
so we've changed them:
- border-radius -> margin-left
- align-items -> empty-cell
Bug: 816402
Change-Id: I84d2fd8a15df92624122f0c1ecf4f7c42f928928
Reviewed-on: https://chromium-review.googlesource.com/942651
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540397}
wpt-commits: 12e0354d971ce3f705991a4f68837d24947865df
wpt-pr: 9738
wpt-commits: 12e0354d971ce3f705991a4f68837d24947865df
wpt-pr: 9738
Automatic update from web-platform-tests[css-typed-om] Fix computed value of an interpolated transform.
Previously we did not handle the case of computing the value of an
interpolated transform, which occurs when we interpolate between
two different transform types containing percentages.
The correct result is currently not spec'd [1], so this patch fixes this
by just returning "none" in this case.
[1] https://github.com/w3c/css-houdini-drafts/issues/425
Bug: 816803
Change-Id: I97c8f6b71f651a8d547fb4cb307121eba7dabdb6
Reviewed-on: https://chromium-review.googlesource.com/942595
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540258}
wpt-commits: a77669c83cc75fcec4df6e46f6a07edf8c20d1a4
wpt-pr: 9731
wpt-commits: a77669c83cc75fcec4df6e46f6a07edf8c20d1a4
wpt-pr: 9731
Automatic update from web-platform-testsbluetooth: web: test: Simulate advertisements
This change adds a SimulateAdvertisementReceived function to the
FakeCentral interface. The design for this class is detailed in the
following document:
https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg
BUG=719826
Change-Id: I618dc68c967e6d9942f99f1807da6fb1985cd676
Reviewed-on: https://chromium-review.googlesource.com/916554
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540236}
wpt-commits: 5635bba261e91a9c619a789c5f482e15f60c68cb
wpt-pr: 9506
wpt-commits: 5635bba261e91a9c619a789c5f482e15f60c68cb
wpt-pr: 9506
Automatic update from web-platform-testsscrollTo and scrollBy should land on snap points.
According to spec,
https://drafts.csswg.org/css-scroll-snap-1/#scroll-types,
programmatically scrolling such as scrollTo and scrollBy should land on
snap points.
Bug: 803606
Change-Id: I1e70d88f31a2b2f93c92cc063adf653ed923adeb
Reviewed-on: https://chromium-review.googlesource.com/889936
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540166}
wpt-commits: 0f3fa6c1e32c9d6454569eb443c104ca10dd96b9
wpt-pr: 9678
wpt-commits: 0f3fa6c1e32c9d6454569eb443c104ca10dd96b9
wpt-pr: 9678
Automatic update from web-platform-testsUpdate reftest graph when node changes to support (#9732)
Modified conditional in manifest.py to check for a reftest node changing
to another type.
Wrote a test in test_manifest.py for the same
wpt-commits: 2560d71e083b5798154038589205f75f54442601
wpt-pr: 9732
wpt-commits: 2560d71e083b5798154038589205f75f54442601
wpt-pr: 9732
Automatic update from web-platform-tests[css-layout-api] Populate children, and pass into layout() function
This introduces the LayoutChild API surface, (which only has a styleMap
accessor currently).
Each LayoutBox which is a child of a LayoutCustom will hold onto a
LayoutChild object, acting as the script interface for the web
developer.
Bug: 726125
Change-Id: Iecdb01a38c0712dcda063b485c4207bde59f3995
Reviewed-on: https://chromium-review.googlesource.com/933092
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539928}
wpt-commits: 41ab079dfcde76aebbde5660fe3e417447e61f80
wpt-pr: 9680
wpt-commits: 41ab079dfcde76aebbde5660fe3e417447e61f80
wpt-pr: 9680
Automatic update from web-platform-testsMerge pull request #9716 from mrego/css-text-viewport
[css-text] Modify reference tests so they fit in the viewport
wpt-commits: 0d843d4cf1a8424884d43ead98c2528f9c6110c5
wpt-pr: 9716
wpt-commits: 0d843d4cf1a8424884d43ead98c2528f9c6110c5
wpt-pr: 9716
Automatic update from web-platform-tests[css-typed-om] Ensure properties works with css-wide keywords / var refs
There are two things that should always be supported with any property:
- css-wide keywords like 'initial'
- var refs like 'var(--A)'
This patch adds tests to ensure that this works for all the different
types of properties. Unfortunately, supporting this in shorthands
is quite difficult (we get shorthands as strings, so to reify them
we have to parse, but we can't parse in reification) so we'll leave
that for the future.
Bug: 816722
Change-Id: I1d344b73d011db81cfc3880be54823302534fd36
Reviewed-on: https://chromium-review.googlesource.com/942121
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540055}
wpt-commits: 9c3df0ea37661b7dbb9d19a7e7384c05483a2fd9
wpt-pr: 9730
wpt-commits: 9c3df0ea37661b7dbb9d19a7e7384c05483a2fd9
wpt-pr: 9730
Automatic update from web-platform-tests[css-typed-om] Implement correct ordering for StylePropertyMaps.
The correct ordering of properties depends on the type of style map:
- Computed: css properties first, then vendor prefixed ones, then
custom properties. Within each category, sort by code point.
- Inline: same order as the CSSStyleDeclaration.
- Declared: same order as the CSSRule.
Spec: https://drafts.css-houdini.org/css-typed-om-1/#stylepropertymapreadonly
Bug: 545318
Change-Id: I34fe8f0741bdcc2188926b37635672a4dda32625
Reviewed-on: https://chromium-review.googlesource.com/940381
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540066}
wpt-commits: 66ffd921b533a3da766797aad016820ee90ca465
wpt-pr: 9729
wpt-commits: 66ffd921b533a3da766797aad016820ee90ca465
wpt-pr: 9729
Automatic update from web-platform-testsMake clipboard events composed.
This corresponds to the upstream spec change on
https://github.com/w3c/clipboard-apis/pull/62
Note that synthetic events are not affected by the change.
To generate copy/cut/paste events, document.execCommand() is
used for Blink, but cannot be used for web platform tests.
Bug: 802009
Change-Id: I00df77269708458b9a6820323a1f511b7c75e513
Reviewed-on: https://chromium-review.googlesource.com/923671
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540046}
wpt-commits: 8dbff770ac61468d23313ad7ccb00ba6e2880064
wpt-pr: 9710
wpt-commits: 8dbff770ac61468d23313ad7ccb00ba6e2880064
wpt-pr: 9710
Automatic update from web-platform-tests[css-typed-om] Implement serialization for CSSUnsupportedStyleValues.
This patch implements serialization for CSSUnsupportedStyleValue.
The spec requires that:
- CSSStyleValues that are parsed from string should serialize to the
given string.
- CSSStyleValues that are obtained from CSSOM should serialize according
to [1] (although this is mostly the same as CSSOM serialization).
To implement both, we put a String on CSSStyleValue (the base class)
to store its serialization. This is only used by the subclass
CSSUnsupportedStyleValue. When we create a CSSUnsupportedStyleValue,
we set the serialization correctly depending on if it's from a string
or CSSOM. CSSUnsupportedStyleValue.toString() just outputs the stored
string.
It turns out that the string on CSSStyleValue can completely replace
its CSSValue. Instead of wrapping a CSSValue, which is fragile when
passed around arbitrarily, we simply parse the stored string whenever
we need to convert to a CSSValue. This actually was the original
design, but we changed it because we thought styleMap.set cannot
invoke parsing. Since we resolved to not expose styleMap.set to
worklets, we are allowed to parse and this is a much more robust
solution.
Serialization for shorthands requires different logic depending on
if it's a computed shorthand or a specified shorthand. This meant
that we had to create a new method for getting the serialization
and override it for different property maps.
We don't need CSSUnsupportedShorthandValue anymore, since we can
can just use CSSUnsupportedStyleValue.
[1] https://drafts.css-houdini.org/css-typed-om-1/#cssom-serialization
Bug: 816722
Change-Id: Ia236f72467e414a2eb380f00ddb196db06f8d8b6
Reviewed-on: https://chromium-review.googlesource.com/940283
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540039}
wpt-commits: a78e2a33854504792ed5692084f8d8afc45c5585
wpt-pr: 9720
wpt-commits: a78e2a33854504792ed5692084f8d8afc45c5585
wpt-pr: 9720
Automatic update from web-platform-testsSupport wpt run safari (Safari 11 and Technology Preview) (#8979)
Based on unfinished support for Safari 10:
https://github.com/w3c/wptrunner/pull/225
Tested with Safari 11 and Technology Preview, but whether this still
works with Safari 10 has not been tested. It probably doesn't work.
Also improve the debug logging around WebDriver start and document the
manual setup required to make `wpt run safari` work.
wpt-commits: 10d9c8de236f1a332dfdd54d04496c272406a3d1
wpt-pr: 8979
wpt-commits: 10d9c8de236f1a332dfdd54d04496c272406a3d1
wpt-pr: 8979
Automatic update from web-platform-tests[css-typed-om] Implement shorthands for StylePropertyMap.set/delete.
This patch implements shorthands for stylemap.set/delete. When we
receive an UnsupportedShorthandProperty, we should get the CSSValues
out of them and set them on the style map.
We leave parsing of shorthand values for a future patch.
Bug: 816722
Change-Id: Iebd0b33f89b1d8872bea5d3f80d1dde71d72bc45
Reviewed-on: https://chromium-review.googlesource.com/938684
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539992}
wpt-commits: d2058869b7fcb86a0ed4bfa9c4cb00a07ec3dc4c
wpt-pr: 9682
wpt-commits: d2058869b7fcb86a0ed4bfa9c4cb00a07ec3dc4c
wpt-pr: 9682
Automatic update from web-platform-testsEnable separating the metadata and manifest paths.
The current wptrunner setup assumes that the MANIFEST.json file is
always at the root of the metadata path. But there are scenarios in
which this need not be true e.g. if the metadata is in-tree and the
manifest is not. So we separate these out by porviding an extra
command line argument for the manifest path, and corresponding key in
the config file. If this is not supplied the old value is assumed as a
default.
--
Allow supplying extra properties to use when updating metadata.
The properties are read from a run_info.json and may be used to
distinguish runs. Default properties are set on a per-product
basis, but in some scenarios we want additional properties to be
considered for the metadata e.g. when updaating multi-browser metadata
we want to consider the full product name.
It may be better in the long run to simply allow overriding the full
list of properties and always having the user (or context-specific
caller) supply this list rather than having any hardcoded defaults.
--
Add a wpt command for updating expectation metadata.
The |wpt update-expectations| command takes a list of raw log files,
and updates the expectation data located in the directory supplied
thorugh the --metadata keyword argument. This metadata is used by
subsequent test runs to determine the expected test results.
By default the "product" property is used as a possible conditional on
the data; this means that if multiple logs are passed in
simultaneously then different results will be distinguished by "if
product==foo" conditions in the metadata.
--
Add a wptrunner_infrastructure job to CI.
This runs all the tests under infrastructure/ every time that the
tools/ directory changes, as a smoketest to ensure that nothing is
badly broken.
--
Add metadata for infrastructure tests
wpt-commits: 952022a07f809f917912bbc552d77ac5b9062e49, 1a17d9f7a6bb849aaa6cdf4ad8499074945d7da4, dbde4106fd461486f2e4ae2c84dcf644e854a6af, e542c4abf945a612e726a80d5efc46d98b0e59f2, b73c5d44e35f6510e200aad2242b2f4e70c607c1
wpt-pr: 9676
wpt-commits: 952022a07f809f917912bbc552d77ac5b9062e49, 1a17d9f7a6bb849aaa6cdf4ad8499074945d7da4, dbde4106fd461486f2e4ae2c84dcf644e854a6af, e542c4abf945a612e726a80d5efc46d98b0e59f2, b73c5d44e35f6510e200aad2242b2f4e70c607c1
wpt-pr: 9676
Automatic update from web-platform-tests[css-tables] Test that tables have box-sizing:border-box by default
Legacy layout erroneously sets box-sizing:border-box on non-table
elements that have display:table when the element has a specified %
height. Only <table> elements should have box-sizing:border-box.
Bug: 598134
Change-Id: I66a4a6380ca60a88516a63d3df84faabd709d4c0
Reviewed-on: https://chromium-review.googlesource.com/940561
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539916}
wpt-commits: 508c74e4cfeff84d005166adeb80f89237a70b71
wpt-pr: 9699
wpt-commits: 508c74e4cfeff84d005166adeb80f89237a70b71
wpt-pr: 9699
Automatic update from web-platform-tests[Code Health] Fix ABC wpt.browser.Browser
* Make sure methods in subclasses have the same interface as the
abstract methods in the base class.
* Move docstrings to the base class.
* Declare two more abstract methods: find_binary & find_webdriver,
because multiple (though not all) subclasses already defined these
methods, and the two methods are called externally (by wpt.run). They
fall into the same category as version().
wpt-commits: 3370b65896f68174e3092b7fbcc46aba98c47544
wpt-pr: 9349
wpt-commits: 3370b65896f68174e3092b7fbcc46aba98c47544
wpt-pr: 9349
Automatic update from web-platform-testsReporting: Use new format for Report-To header
The format of the Report-To header recently changed so that endpoint
groups are the top-level element, instead of individual endpoints.
Bug: 704259
Change-Id: I7534c46abbbb86c367931ffc060972ac36b1084b
Reviewed-on: https://chromium-review.googlesource.com/914687
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539876}
wpt-commits: fe9700afafd37617d877b36f0657cc3d9c666af0
wpt-pr: 9714
wpt-commits: fe9700afafd37617d877b36f0657cc3d9c666af0
wpt-pr: 9714
Automatic update from web-platform-testsRevert "Revert "webauthn: support the appid extension.""
This reverts commit 7df8cfae4fb4949f4949d7c3ad9411fbb50b0175. Originally
it broke because r539572 landed between the trybot runs and commit and
broke it. Original commit message:
webauthn: support the appid extension.
This extension allows credentials that were registered with U2F to be
used with webauthn. See https://w3c.github.io/webauthn/#sctn-appid-extension.
The change does not include support for echoing the extension in the
CollectedClientData[1], nor does it implement
getClientExtensionResults[2]. It's fully usable without that logic and
I have several questions about that part of the spec[3] that I would
like to understand first.
I did consider avoiding having a alternative app_param value in
//device/u2f but a) the spec says that the given appid should be tried
after the first one and b) this allows sites not to have to worry about
which protocol they registered credentials with. Instead, they can just
set this extension during the transition.
[1] https://w3c.github.io/webauthn/#sec-client-data
[2] https://w3c.github.io/webauthn/#iface-pkcredential
[3] https://github.com/w3c/webauthn/issues/803
Bug: none
Change-Id: Ie68e349af9b00de4fc986bfb1516e9650c61ef0b
Reviewed-on: https://chromium-review.googlesource.com/940524
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539858}
wpt-commits: fa2653332d898cd75ae4c38d3aa514adca791bf5
wpt-pr: 9700
wpt-commits: fa2653332d898cd75ae4c38d3aa514adca791bf5
wpt-pr: 9700
Automatic update from web-platform-tests[MIX]: Improve Safari support. (#8015)
Safari doesn't generate events in quite the same way as Firefox and Chrome, but
those events also aren't relevant to the MIX tests. It also doesn't like an
explicit 'type=video/ogg' declaration in '<source>' elements. This patch shifts
to a timeout model to ensure that even if events aren't triggered, we still
check whether or not the resource was loaded from the server.
wpt-commits: 5cddbd4919d12781dfc46e928547132fa7402d1c
wpt-pr: 8015
wpt-commits: 5cddbd4919d12781dfc46e928547132fa7402d1c
wpt-pr: 8015
Automatic update from web-platform-testsUse the print function in some scripts.
--
Use Python3-compatible except syntax.
--
Prepare mathml/tools/utils/misc.py for python3.
wpt-commits: f1536eed16c7b743acbf9188150041f049b646b9, b762b7fa54e2e830b6e400fc5d8c369c95c53e82, 911d525247327484c66ef851d6219a9ef555b0ac
wpt-pr: 8839
wpt-commits: f1536eed16c7b743acbf9188150041f049b646b9, b762b7fa54e2e830b6e400fc5d8c369c95c53e82, 911d525247327484c66ef851d6219a9ef555b0ac
wpt-pr: 8839
Automatic update from web-platform-testsEnsure testharnessreport.js is loaded as utf8
MozReview-Commit-ID: C5E7to91rFU
--
Ensure that static assets are cached.
Give them a max-age of 1 hour and ensure that the cache-control header
is also applied with the StaticHandler used in wptrunner.
wpt-commits: 0f77a132dd2682d6c79b759aaaad3315f8fa652e, fa24b4a4b454ddde0bc511b1858786da647b3d34
wpt-pr: 9393
wpt-commits: 0f77a132dd2682d6c79b759aaaad3315f8fa652e, fa24b4a4b454ddde0bc511b1858786da647b3d34
wpt-pr: 9393
Automatic update from web-platform-testsWebDriver: don't send a request body for HTTP GET requests
Due to the fact that Python's None is serializable as JSON,
the transport was always sending the string "null" as the body
for all requests which did not specify some other body. This
leads to HTTP GET requests with a non-zero Content-Length,
which is bad.
Fix this by only trying to encode the payload if the body
parameter has a non-default value. I don't think there is
a valid use case where a request payload is a top-level 'null'.
wpt-commits: c2c395d1ebc7fe9ed4d13745e700f08078893978
wpt-pr: 9465
wpt-commits: c2c395d1ebc7fe9ed4d13745e700f08078893978
wpt-pr: 9465
Automatic update from web-platform-testsRemove the "sound" property from the Notification interface
The property will be removed from the standard per the following PR:
https://github.com/whatwg/notifications/pull/127.
wpt-commits: 58777966260d8f1a6c5347bc7a531596543e6e80
wpt-pr: 9713
wpt-commits: 58777966260d8f1a6c5347bc7a531596543e6e80
wpt-pr: 9713
Automatic update from web-platform-tests[css-ui] Use "Ahem" instead of "ahem" in tests
"ahem" is causing flakiness on Windows, so this patch
just replaces "ahem" by "Ahem" on css-ui WPT tests.
BUG=724392,796733
Change-Id: I956e939790319ec956164f34af8c72f109c528ef
Reviewed-on: https://chromium-review.googlesource.com/940133
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#539797}
wpt-commits: 98f6f9bde502771ce9939d24f27ca823351adb33
wpt-pr: 9712
wpt-commits: 98f6f9bde502771ce9939d24f27ca823351adb33
wpt-pr: 9712
Automatic update from web-platform-tests[css-typed-om] Return transform components for computed transform.
ComputedStylePropertyMap should return computed values. For 'transform',
that's "as specified, but relative lengths converted to absolute" [1].
This means we need to return the individual transform components like
'translate3d'.
Currently there's no code to do this, so we have to roll our own.
[1] https://drafts.csswg.org/css-transforms-1/#propdef-transform
Bug: 816803
Change-Id: I64305512fa0d0ce32ba86ea2b14595b551ff1c8d
Reviewed-on: https://chromium-review.googlesource.com/938885
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539783}
wpt-commits: c56fcfd2726fbfaf495843bed3d1d4423ce72b7a
wpt-pr: 9685
wpt-commits: c56fcfd2726fbfaf495843bed3d1d4423ce72b7a
wpt-pr: 9685
Automatic update from web-platform-tests[css-multicol] Use "Ahem" instead of "ahem" in tests
"ahem" is causing flakiness on Windows, so this patch
just replaces "ahem" by "Ahem" on WPT tests.
BUG=724392,794136
Change-Id: I55ce2ee7ed36b2708da571f52256716e97a072cb
Reviewed-on: https://chromium-review.googlesource.com/940921
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#539780}
wpt-commits: a5e5a3d683d787be4a608d8bcd385f902c6ef2c2
wpt-pr: 9711
wpt-commits: a5e5a3d683d787be4a608d8bcd385f902c6ef2c2
wpt-pr: 9711
Automatic update from web-platform-testsgetCapabilities() should not have range properties without valid values
This CL ensures that MediaStreamTrack.getCapabilities() does not have
range properties if they don't have a valid range.
Bug: 293292
Change-Id: I6f85086fb4af7e17faca069f76299a0256f1872d
Reviewed-on: https://chromium-review.googlesource.com/938983
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539778}
wpt-commits: ca3bede481b3c4e1510e19e0c816128307ef7dcb
wpt-pr: 9688
wpt-commits: ca3bede481b3c4e1510e19e0c816128307ef7dcb
wpt-pr: 9688
Automatic update from web-platform-testsFix a bug of <fieldset disabled> detection logic.
HTMLFormControlElement::UpdateAncestorDisabledState() checked if the
highest <legend> is the first <legend> child of the highest disabled
<fieldset>. It should check <lengend> child of every disabled fieldset
ancestors.
Bug: 817181
Change-Id: I8f7dedd8089757d9eae726de359b0efe47cf9f44
Reviewed-on: https://chromium-review.googlesource.com/940644
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539776}
wpt-commits: 51071878ed91e88ba8bcf59b0180beb3dd5211a8
wpt-pr: 9709
wpt-commits: 51071878ed91e88ba8bcf59b0180beb3dd5211a8
wpt-pr: 9709
Automatic update from web-platform-tests[css-text] Use "Ahem" instead of "ahem" for fonts in tests
Using the lowercase version causes flakiness on Windows
(see crbug.com/724392).
BUG=817030
Change-Id: Ic4bdea7d40f0c2e96d6669430b3cce7a296e8d55
Reviewed-on: https://chromium-review.googlesource.com/940123
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#539748}
wpt-commits: cc52c7e80c940a475adc28142285082f2c973ed6
wpt-pr: 9707
wpt-commits: cc52c7e80c940a475adc28142285082f2c973ed6
wpt-pr: 9707
Automatic update from web-platform-testsAdd test to check that StylePropertyMap sorts in increasing code-point order
Change-Id: I86933692bff974d3a640cef4ea47b602c88e92a1
Reviewed-on: https://chromium-review.googlesource.com/940723
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539708}
wpt-commits: 8c4cf0026a8c041c8e9efb8d0f5553a2a0eff008
wpt-pr: 9704
wpt-commits: 8c4cf0026a8c041c8e9efb8d0f5553a2a0eff008
wpt-pr: 9704
Automatic update from web-platform-tests[css-typed-om] Implement shorthands for .get/.getAll/.has.
This patch implements shorthands for stylemap.get/getAll/has. Shorthands
are implemented as a base CSSStyleValue. They are different to other
properties because they cannot be converted to a single CSSValue.
Instead, we need to store the CSSValues of their longhands so that
they can be set again on the same property.
Patches to come:
- styleMap.set/update
- Serialization of these values.
Bug: 816722
Change-Id: Ia2c3f694809c219566b965ebfae40bc38d74f4c5
Reviewed-on: https://chromium-review.googlesource.com/938881
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539594}
wpt-commits: 1d8bc90c101290f6c826467ca329220a210df1ad
wpt-pr: 9681
wpt-commits: 1d8bc90c101290f6c826467ca329220a210df1ad
wpt-pr: 9681
Automatic update from web-platform-testswebauthn: support the appid extension.
This extension allows credentials that were registered with U2F to be
used with webauthn. See https://w3c.github.io/webauthn/#sctn-appid-extension.
The change does not include support for echoing the extension in the
CollectedClientData[1], nor does it implement
getClientExtensionResults[2]. It's fully usable without that logic and
I have several questions about that part of the spec[3] that I would
like to understand first.
I did consider avoiding having a alternative app_param value in
//device/u2f but a) the spec says that the given appid should be tried
after the first one and b) this allows sites not to have to worry about
which protocol they registered credentials with. Instead, they can just
set this extension during the transition.
[1] https://w3c.github.io/webauthn/#sec-client-data
[2] https://w3c.github.io/webauthn/#iface-pkcredential
[3] https://github.com/w3c/webauthn/issues/803
Bug: none
Change-Id: I22819adda99fbef9f10d38e797d08691dab7545d
Reviewed-on: https://chromium-review.googlesource.com/920659
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539584}
wpt-commits: a200a0fb41dba43d82e3810e884a838ee835aa98
wpt-pr: 9613
wpt-commits: a200a0fb41dba43d82e3810e884a838ee835aa98
wpt-pr: 9613
Automatic update from web-platform-tests[css-typed-om] remove duplicate test.
there are duplicate tests. so remove one of them.
Bug: 774887
Change-Id: I040ac68b8d2752ea7f952a0ff615f5352cb23b0e
Reviewed-on: https://chromium-review.googlesource.com/939881
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539568}
wpt-commits: bdee13ee73cbb7036363462c456355e461d5262f
wpt-pr: 9695
wpt-commits: bdee13ee73cbb7036363462c456355e461d5262f
wpt-pr: 9695
Automatic update from web-platform-testsRun script directly and don't source it
--
Fix paths when building CSS testsuite
--
Recommend `git submodule` instead of hg for w3ctestlib/apiclient
--
Fix passing arguments to ./build-css-testsuites.sh
--
Update w3ctestlib submodule
--
Update CSS build system requirements
--
Make it possible to set RUN_JOB globally
wpt-commits: e00868e2cc32b51bcc597400ef4ec1ca0fd5e4a7, 009fd7558acd69310568df2adf4292b9f10914af, 5241f45421bb3455b6b3bc362fa63293eb58ce48, fc544d570321a72c7418d45031db456db37c98be, 6b044b942db61b0f91454f254b1b1847c2d36e29, 11da4202dd2541e2dc2d36a4a3b2e265b4fcc6cc, 1305210bed8f4e3ef811998b219f220511d9a27d
wpt-pr: 9602
wpt-commits: e00868e2cc32b51bcc597400ef4ec1ca0fd5e4a7, 009fd7558acd69310568df2adf4292b9f10914af, 5241f45421bb3455b6b3bc362fa63293eb58ce48, fc544d570321a72c7418d45031db456db37c98be, 6b044b942db61b0f91454f254b1b1847c2d36e29, 11da4202dd2541e2dc2d36a4a3b2e265b4fcc6cc, 1305210bed8f4e3ef811998b219f220511d9a27d
wpt-pr: 9602
Automatic update from web-platform-testsMake the data-url-shared.html test a bit prettier/simpler
This has looked odd since
https://github.com/w3c/web-platform-tests/pull/5075 and can be
simplified anyway.
wpt-commits: e28a4f29f2394547dfbcc82df5f96c5436edb837
wpt-pr: 9691
wpt-commits: e28a4f29f2394547dfbcc82df5f96c5436edb837
wpt-pr: 9691
Automatic update from web-platform-testsCheck if git is a batch file on Windows
In the steps for manifest generation, if git is contained in a batch file, subprocess will not be able to find git and will throw a WindowsError. This change makes it so that if a WindowsError is thrown, it will check if using git.bat works.
wpt-commits: 0503e45c79168576d5672532901a7df0545b05fd
wpt-pr: 9652
wpt-commits: 0503e45c79168576d5672532901a7df0545b05fd
wpt-pr: 9652
Automatic update from web-platform-testsReadableStream piping: Add tests for shutting down when readable becomes errored with preventAbort = true (#9591)
For closing, we had 4 tests for the shutdown behavior, but for erroring we only had two.
Rework the forward error propagation tests, so we now have similar variants:
* Errors must be propagated forward: shutdown must not occur until the final write completes
* Errors must be propagated forward: shutdown must not occur until the final write completes; preventAbort = true
* Errors must be propagated forward: shutdown must not occur until the final write completes; becomes errored after first write
* Errors must be propagated forward: shutdown must not occur until the final write completes; becomes errored after first write; preventAbort = true
wpt-commits: 5154532d4152e2cb8b75cbfbcf1c9e6bb4fe651c
wpt-pr: 9591
wpt-commits: 5154532d4152e2cb8b75cbfbcf1c9e6bb4fe651c
wpt-pr: 9591
Automatic update from web-platform-tests[css-typed-om] Add more property tests.
Add more property tests. Most test failures are because our Blink
implementation for these properties are lagging behind spec. The only
weird one is line-height, which seems to return 'normal' for negative
values even though the spec doesn't say that anywhere.
Bug: 774887
Change-Id: I9d4a6918b5e9b5772230999b18c6eec4934bcf19
Reviewed-on: https://chromium-review.googlesource.com/936821
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539222}
wpt-commits: 9659a35d816ff1b32835a2eccf3e0117dea4e5ce
wpt-pr: 9659
wpt-commits: 9659a35d816ff1b32835a2eccf3e0117dea4e5ce
wpt-pr: 9659
Automatic update from web-platform-testsHTMLMediaElement: set `muted_` when cloning element with muted attribute.
This CL works around the fact that cloning does not call the parser
callbacks and the HTML specifications require the attribute to only
have an effect when the element was created. There is unfortunately
no notification that the element creation from `cloneNode()` happens
so we instead rely on a callback meant for something slightly different.
Bug: 811743
Change-Id: Ib7ac55088b9eaad23f9bce0cfc8366fec6fc5b0d
Reviewed-on: https://chromium-review.googlesource.com/937504
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539207}
wpt-commits: 82efd0226a261a41be569357efa2a65596f1fb75
wpt-pr: 9675
wpt-commits: 82efd0226a261a41be569357efa2a65596f1fb75
wpt-pr: 9675
Automatic update from web-platform-testsMove more chrome webaudio layout tests to WPT
Move the DelayNode, DynamicsCompressorNode, and GainNode tests to
WPT.
Manually verified that Firefox passes these texts, except for the
no-dezipper tests which use suspend() on an offline context.
The tests that weren't moved are Chrome-specific.
Bug: 745778
Change-Id: Iea2d31fd556d51ddcd63e9d139e53f05732261fe
Reviewed-on: https://chromium-review.googlesource.com/922544
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539200}
wpt-commits: 1dd2953e47d12905513d7a295370c3e74bdc6948
wpt-pr: 9654
wpt-commits: 1dd2953e47d12905513d7a295370c3e74bdc6948
wpt-pr: 9654
Automatic update from web-platform-tests[LayoutNG] Need to lay out legacy objects to figure out their inline size.
NG cannot always calculate the correct size of objects that are laid out
by the legacy engine, so just lay them out if we need to know their
size.
The computed CSS width on a table may not end up as its used value, for
instance.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iaa327ad21055d6c1af96241b5403193c8b4b5ba3
Reviewed-on: https://chromium-review.googlesource.com/937261
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539201}
wpt-commits: c3e1a513c1d09c2b4544ad05ea3f03ba8483af27
wpt-pr: 9673
wpt-commits: c3e1a513c1d09c2b4544ad05ea3f03ba8483af27
wpt-pr: 9673
Automatic update from web-platform-testsUpdate assumptions test to match HTML spec (#9674)
wpt-commits: 9ff5d62fc664214b86ec8ef4b07aaa8097f7ebed
wpt-pr: 9674
wpt-commits: 9ff5d62fc664214b86ec8ef4b07aaa8097f7ebed
wpt-pr: 9674
Automatic update from web-platform-tests[css-typed-om] Add tests for images related properties.
This patch adds tests for properties taking an <image>. There are some
failing tests due to keywords not implemented in Blink yet.
Bug: 774887
Change-Id: Ie5fa1fa15a16440273517afdd62b078449e615e4
Reviewed-on: https://chromium-review.googlesource.com/928056
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539118}
wpt-commits: eb5edccf4ccdd623f4230bab13805106f9a32fc1
wpt-pr: 9615
wpt-commits: eb5edccf4ccdd623f4230bab13805106f9a32fc1
wpt-pr: 9615
Automatic update from web-platform-tests[css-typed-om] Add property test for font-weight.
font-weight is clamped to [0, 1000], so we have to change the out of
range code to handle upperbounds too.
Test failure because we seem to be rounding the font weight, but the
spec doesn't say we should.
Bug: 774887
Change-Id: I75d283dc32d37e04633133fe420817d02953d4e3
Reviewed-on: https://chromium-review.googlesource.com/936722
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539117}
wpt-commits: 2ddb23d97ca301c2a91d63539bcc1eaa448e5d2c
wpt-pr: 9658
wpt-commits: 2ddb23d97ca301c2a91d63539bcc1eaa448e5d2c
wpt-pr: 9658
Automatic update from web-platform-testsRemove dead code prepare_environment in browser.py (#9653)
This isn't called from anywhere. The DBUS_SESSION_BUS_ADDRESS bits were
added in https://github.com/w3c/web-platform-tests/pull/5893 but was
unused even then. Since then it's been copied around a lot.
wpt-commits: c58e51bef6e114539375fa89e094b20c2056ebe9
wpt-pr: 9653
wpt-commits: c58e51bef6e114539375fa89e094b20c2056ebe9
wpt-pr: 9653
Automatic update from web-platform-tests[USVString] Add a rough test case for navigator.registerProtocolHandler
Although r525634 updated the URL type of registerProtocolHandler from DOMString
to USVString, it didn't add a test case because it was a bit complex. Though
it's still hard to add a test case for it, this CL adds a rough test case for now.
Bug: 790860
Change-Id: Ia688494293274ab2c0aa62f9e33a588ca80d2a82
Reviewed-on: https://chromium-review.googlesource.com/933668
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#539114}
wpt-commits: afe0178832b87e03398804b0b99952049b5cc61e
wpt-pr: 9643
wpt-commits: afe0178832b87e03398804b0b99952049b5cc61e
wpt-pr: 9643
Automatic update from web-platform-testsCross-link more of the documentation on writing tests
Fixes https://github.com/w3c/web-platform-tests/issues/4923.
wpt-commits: 58f325b2319ba8e868afff49c61dc8516443fde1
wpt-pr: 9669
wpt-commits: 58f325b2319ba8e868afff49c61dc8516443fde1
wpt-pr: 9669
Automatic update from web-platform-testsAdd tests for the use and lack of the .https file name flag
In https://github.com/w3c/web-platform-tests/pull/8979 it became obvious
that it's easy to have things mostly working without .https working as
intended, and having infrastructure tests for this seems helpful. (I
tried to run all the infrastructure tests first.)
wpt-commits: 0db78b1aec61fff44bb825d43364bd5d7dc9df29
wpt-pr: 9668
wpt-commits: 0db78b1aec61fff44bb825d43364bd5d7dc9df29
wpt-pr: 9668
Automatic update from web-platform-tests[USVString] Apply USVString into Document.origin
The latest spec changed DOMString type of Document.origin with USVString.
- https://dom.spec.whatwg.org/#document
This CL applies USVString type into the Document.origin in order to meet the change.
Bug: 790860
Change-Id: Ibd1fafa28a6e999f7d3085aa7bb4cca0f92d8b2b
Reviewed-on: https://chromium-review.googlesource.com/928005
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539096}
wpt-commits: f63598ecdbe3a6220fc21d6f5d2378b9e1602d47
wpt-pr: 9624
wpt-commits: f63598ecdbe3a6220fc21d6f5d2378b9e1602d47
wpt-pr: 9624
Automatic update from web-platform-testscreateElement()/createElementNS() dictionary argument can be a string
Helps with https://github.com/whatwg/dom/pull/572.
wpt-commits: 2a181b39ebedeb3b2d826fb5f320a7871e0eff08
wpt-pr: 9586
wpt-commits: 2a181b39ebedeb3b2d826fb5f320a7871e0eff08
wpt-pr: 9586
Automatic update from web-platform-tests[css-typed-om] Rejig CSSResourceValue hierarchy.
We implement the new CSSImageValue, which is an opaque object with no
constructor. We also had to change the testsuite.js a bit to test it.
Bug: 545318
Change-Id: I0ae719c5380e01ff9423e0ff0684afe547de1bb0
Reviewed-on: https://chromium-review.googlesource.com/934001
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538730}
wpt-commits: 5ca972e15cfa80277964645d9ee5ccd87a661337
wpt-pr: 9641
wpt-commits: 5ca972e15cfa80277964645d9ee5ccd87a661337
wpt-pr: 9641
Automatic update from web-platform-tests[LayoutNG] The padding box needs to exclude both borders and scrollbars.
We forgot to subtract space taken up by scrollbars. Now that we do, we
also need NGBlockNode::GetScrollbarSizes() to add the horizontal
scrollbar on the correct side. Need to check with the layout object, not
directly with computed style. This matters e.g. if the object in
question is the LayoutView, which always places it on the right hand
side, even if document direction is RTL.
Also fix static block offset in flipped blocks writing mode. We got it
wrong, because we flipped an offset relative to the border edge around
the padding box. That's a regression from
https://chromium-review.googlesource.com/926004
Since I managed to break stuff without any tests regressing, I added a
few to wpt/css/css-flexbox/ (it doesn't really matter which layout model
to test with, as long as the containing block is in legacy layout, so
I just picked flexbox).
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I9527e8bb013b792a6b8ef58b370efe02b071c8bf
Reviewed-on: https://chromium-review.googlesource.com/931502
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538871}
wpt-commits: 0fe9f012a8ee5503b728a379705a6c5286ba1e96
wpt-pr: 9646
wpt-commits: 0fe9f012a8ee5503b728a379705a6c5286ba1e96
wpt-pr: 9646
Automatic update from web-platform-testsUpdate Web Platform Tests for storage APIs in 'data:' contexts
Per https://github.com/w3c/web-platform-tests/pull/4832 remove
WebSQL cases from WPT's workers/data-url*.html since it's not
otherwise tested in WPT, and the test "passes" even if the API is
not present. Also add an addition assertion that indexedDB is
present before blithely checking that using it throws.
WebSQL is not exposed to Workers in Chrome so we don't lose
coverage here - we only "passed" because the API was not present
in these contexts. The webexposed/ tests cover this.
Change-Id: I0aa05ff9e674351a2a49ba0bae8e5a9938b2cf34
Reviewed-on: https://chromium-review.googlesource.com/929602
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538833}
wpt-commits: d116ec3d76ee417df0982c4dde13c1baa846cf42
wpt-pr: 9609
wpt-commits: d116ec3d76ee417df0982c4dde13c1baa846cf42
wpt-pr: 9609
Automatic update from web-platform-testsMake the browser.py documentation more truthful
Not very useful, though...
wpt-commits: 4fda93528ee4eaa1f9164bc99da9cc59e3e33432
wpt-pr: 9649
wpt-commits: 4fda93528ee4eaa1f9164bc99da9cc59e3e33432
wpt-pr: 9649
Automatic update from web-platform-testsUpdate style before computing current animations
This allows CSS animations to be in a proper state for the call.
Bug: 813908
Change-Id: Ibd3870432b0c6fc8cc1766fe5c8abec3263db879
Reviewed-on: https://chromium-review.googlesource.com/927322
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538799}
wpt-commits: 96bff4707999fe178331a9a6818f14703a9ae217
wpt-pr: 9611
wpt-commits: 96bff4707999fe178331a9a6818f14703a9ae217
wpt-pr: 9611
Automatic update from web-platform-testsSwitch external_host to host_ip. (#9258)
When running tests in Firefox we don't require that the hostname is
actually resolvable since we set up some internal DNS overrides. This
means that we don't actually need to have web-platform.test defined in
/etc/hosts. As a consequence when we check the server is responding,
the check will typically fail for Firefox developers if we try to
access by hostname. Previously we made use of a special dance in which
external_host held the ip at the point of the check and was later
replaced by host to actually run tests. But that changed, and instead
we relied on the fact that we (accidentially) didn't actually fail in
the case the servers couldn't be reached by host name. However in some
cases things still failed because local DNS resolved web-patform.test
to some ip address, causing hangs or other badness.
In this patch we simply add a host_ip property to the config, and
connect to that to test the servers are repopnsing rather than the
hostname. We also actually fil if we didn't manage to connect to all
the servers.
wpt-commits: 1ccd3325cc17d53d037cc94335dd20d8d2e54c92
wpt-pr: 9258
wpt-commits: 1ccd3325cc17d53d037cc94335dd20d8d2e54c92
wpt-pr: 9258
Automatic update from web-platform-testsUpdate requests from 2.14.2 to 2.18.4
--
Pin requests to latest version 2.18.4
--
Add pyup configuration file.
We want to only allow updates to specified requirements files, rather than touching
everything under third_party, etc.
wpt-commits: 0989f18782090f10b8861590a0b8089dfb28052a, 1cdf3e435da54d5766bf365ea08c5838525b1d97, 28ceecaaa6f0ff2cae0c586c54a923a1246393c3
wpt-pr: 9588
wpt-commits: 0989f18782090f10b8861590a0b8089dfb28052a, 1cdf3e435da54d5766bf365ea08c5838525b1d97, 28ceecaaa6f0ff2cae0c586c54a923a1246393c3
wpt-pr: 9588
Automatic update from web-platform-testsAdd the "dtmf" attribute on RTCRTPSender
This brings the API into conformance with the spec:
https://w3c.github.io/webrtc-pc/#dom-rtcdtmfsender
The CL also exposes the RTCDTMFToneChange event, which
was previously marked [ NoInterface ].
Bug: 812587
Change-Id: I4122d1e4e336b811de234ed492f0de02dcc7a714
Reviewed-on: https://chromium-review.googlesource.com/926181
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538782}
wpt-commits: 580021b740830fcbdb881da8820c5e147967b1d3
wpt-pr: 9583
wpt-commits: 580021b740830fcbdb881da8820c5e147967b1d3
wpt-pr: 9583
Automatic update from web-platform-testsImplemented cascading of the RequiredCSP through nested contexts
An iframe that is inside another iframe that has as RequiredCSP should
respect that RequiredCSP.
Spec: https://w3c.github.io/webappsec-csp/embedded/#required-csp
Bug: 779031
Change-Id: I9042d63a6d14f48fd3cf1caaccf22c5cd1aa6d7a
Reviewed-on: https://chromium-review.googlesource.com/924064
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538760}
wpt-commits: aa7041bbd31b1a67759161e52ec680e200140e22
wpt-pr: 9557
wpt-commits: aa7041bbd31b1a67759161e52ec680e200140e22
wpt-pr: 9557
Automatic update from web-platform-testsUpdate move-to-fullscreen-iframe-manual.html to match the spec
This test is from https://chromium-review.googlesource.com/776599 and
the explanation seemed to make sense spec-wise. But when matching the
spec more closely this begins to fail, and it seems that per spec
this updated behavior is what would happen.
wpt-commits: db1a703c3785094e38bbf29497157ff4652e04df
wpt-pr: 9299
wpt-commits: db1a703c3785094e38bbf29497157ff4652e04df
wpt-pr: 9299
Automatic update from web-platform-testscustom-elements: An element created with 0-length 'is' should be 'undefined' state.
createElement() should accept 0-length 'is' string though
window.customElements.define() doesn't accept it and web authors
can't define such custom elements.
createElement() never finds custom element definition for 0-length 'is'.
So the state of the created elements should be 'undefined'.
https://dom.spec.whatwg.org/#dom-document-createelement
> 3. Let is be the value of the is member of options, or null if no such
> member exists.
https://dom.spec.whatwg.org/#concept-create-element
> 7.3. If namespace is the HTML namespace, and either localName is a
> valid custom element name or is is non-null, then set result’s custom
> element state to "undefined".
The code before this CL incorrectly rejected 0-length 'is' value, and
made the element state 'uncustomized'.
IsEmpty() checks for "is" values should be IsNull().
Bug: 814644
Change-Id: I273f4aa07dd029e483365a9b31586297862a7140
Reviewed-on: https://chromium-review.googlesource.com/930941
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538692}
wpt-commits: 8ec6c8a8bea25fcefbbc176534ad274ff67a3eef
wpt-pr: 9640
wpt-commits: 8ec6c8a8bea25fcefbbc176534ad274ff67a3eef
wpt-pr: 9640
Automatic update from web-platform-testsbluetooth: Migrate remaining tests
This change will migrate the remaining tests that have been converted
to the Web Bluetooth Test API at the moment.
BUG=509038
Change-Id: I6b38a9dd413f99caccbc9861d492eec0a25b1b91
Reviewed-on: https://chromium-review.googlesource.com/891653
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538680}
wpt-commits: 99ea9dc824968a32965cf5552069148b60d93d4d
wpt-pr: 9323
wpt-commits: 99ea9dc824968a32965cf5552069148b60d93d4d
wpt-pr: 9323
Automatic update from web-platform-tests[css-typed-om] Add unsupported tests for color properties.
For color properties, we support 'currentcolor' as a CSSKeywordValue,
but any other value (including identifiers like 'red') are not supported
and are converted to base CSSStyleValues.
We add tests for most color related properties. We are failing the
text-emphasis-color one because we haven't unprefixed it yet.
We change the code to make this work.
Bug: 774887
Change-Id: Ide5463b9f67b63568ff32bd34e977faf16964bc1
Reviewed-on: https://chromium-review.googlesource.com/927943
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538668}
wpt-commits: 5496784a17bae2872a9c29a2f7948533218e9d00
wpt-pr: 9614
wpt-commits: 5496784a17bae2872a9c29a2f7948533218e9d00
wpt-pr: 9614
Automatic update from web-platform-testsservice worker: Update WPT test for resource timing
Before this CL, the test assumed that there should be a
PerformanceResourceTiming for fetching 'resources/missing.jpg'.
As the spec says [1], this assumption is not guaranteed. In fact,
Chromium doesn't add PerformanceResourceTiming for resouces which
failed to load. This CL updates the test to check there is a
corresponding PerformanceResourceTiming entry before doing
verifications.
[1] https://w3c.github.io/resource-timing/#resources-included-in-the-performanceresourcetiming-interface
Bug: 782958
Change-Id: I85e75a8dade9f6620d22a54eaf97468f00360023
Reviewed-on: https://chromium-review.googlesource.com/930109
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538648}
wpt-commits: 30c0131604f63247d98aced8f71e756189da7eb2
wpt-pr: 9627
wpt-commits: 30c0131604f63247d98aced8f71e756189da7eb2
wpt-pr: 9627
Automatic update from web-platform-tests[css-typed-om] Give default value for CSSVariableReferenceValue.fallback
The spec gave a default value for CSSVariableReferenceValue.fallback:
372f85caa4
No observable changes to behaviour.
Bug: 814487
Change-Id: Id33f16167c8b8d9eac3fb70ce7e817de659c7465
Reviewed-on: https://chromium-review.googlesource.com/932921
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538623}
wpt-commits: 7bfbc0fa30aad867faa1c6cc748884be76635a08
wpt-pr: 9639
wpt-commits: 7bfbc0fa30aad867faa1c6cc748884be76635a08
wpt-pr: 9639
Automatic update from web-platform-testsAdd 1x1-green.png to WPT media.
This patch adds the 1x1-green.png test image to wpt/media. It seems to
be used quite a lot by other tests too so maybe this is a good place
for it?
Change-Id: Id8a8c0e0c3b0471db273ad2695155addb2cc11fc
Reviewed-on: https://chromium-review.googlesource.com/917441
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538536}
wpt-commits: 54ffc5cc68ba05a3c26379bd51f2390de7bd454f
wpt-pr: 9504
wpt-commits: 54ffc5cc68ba05a3c26379bd51f2390de7bd454f
wpt-pr: 9504
--HG--
rename : testing/web-platform/tests/css/css-typed-om/resources/1x1-green.png => testing/web-platform/tests/media/1x1-green.png
Automatic update from web-platform-tests[SPv175] Don't crash on circular filter reference containing foreignObject or svg-in-svg
This is a workaround for the crash bugs. The root cause is tracked
in crbug.com/814815.
Bug: 813446, 813411, 814815
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ied370eb2b1f0ffd4424c9c397ea1c899914bdbb0
Reviewed-on: https://chromium-review.googlesource.com/931922
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538527}
wpt-commits: 7ed02d443a806ab9fd27fbb15138cab57410c651
wpt-pr: 9637
wpt-commits: 7ed02d443a806ab9fd27fbb15138cab57410c651
wpt-pr: 9637
Automatic update from web-platform-testsMoved and .name return the address of the document (#9559)
wpt-commits: a83f934cf3c350cac147029659806f5acdc76f2f
wpt-pr: 9559
wpt-commits: a83f934cf3c350cac147029659806f5acdc76f2f
wpt-pr: 9559
Automatic update from web-platform-tests[css-typed-om] Update WPT IDL test and clean up implementation IDL.
This patch updates the WPT IDL test to the current spec.
We also clean up the implementation IDL to match the spec.
Bug: 812915
Change-Id: Id2ca308832344e824b0e7b7eaa6198dc6d7c7e03
Reviewed-on: https://chromium-review.googlesource.com/930502
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538371}
wpt-commits: 7e6dcfb79fc94b2093ae45ed54167b7b106b7f43
wpt-pr: 9622
wpt-commits: 7e6dcfb79fc94b2093ae45ed54167b7b106b7f43
wpt-pr: 9622
Automatic update from web-platform-tests[css-typed-om] Make sure implementation IDL matches spec IDL.
This patch updates our IDL to match that of the spec. We found two
issues in the process:
- StylePropertyMap.get should return (undefined or CSSStyleValue),
but IDL doesn't provide that yet. The spec uses "any" as a workaround
but we'll return (null or CSSStyleValue) for now (null vs undefined).
We'll change the code once IDL gives us something for this.
- Iteration should always return a sequence of CSSStyleValue, whereas
they used to return either CSSStyleValue or sequence of CSSStyleValues
depending on whether the property was list valued or not.
We change the code to fix this.
We deleted the inlineStylePropertyMap_iteration.html LayoutTest
as it is already covered by WPT.
We also update the WPT test expectations to match the spec.
Bug: 812915
Change-Id: Id2f9fbba4398c9ecfd63ea3f8e1aad0b3a0b499f
Reviewed-on: https://chromium-review.googlesource.com/925981
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538367}
wpt-commits: 53a527f9fe52a3707b93a4458e2fb7205ee19683
wpt-pr: 9581
wpt-commits: 53a527f9fe52a3707b93a4458e2fb7205ee19683
wpt-pr: 9581
Automatic update from web-platform-testsAdd srcset/imgsizes support for <link rel=preload> in LinkLoader
This patch teaches LinkLoader to recognize srcset / imgsizes attributes
when preloading images.
This feature is behind the Experimental Web Platform feature flag. Also
note that the attribute name is temporary and may change as the spec
discussion progresses.
Bug: 813452
Change-Id: I82770edd7a99ec328c3748f192f98cf9df0af274
Reviewed-on: https://chromium-review.googlesource.com/927930
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538365}
wpt-commits: fc9b65044ce69f4edb7ded4cf9be83ac2d71fb24
wpt-pr: 9595
wpt-commits: fc9b65044ce69f4edb7ded4cf9be83ac2d71fb24
wpt-pr: 9595
Automatic update from web-platform-testsRevert "Port another set of sticky tests to JS rather than reftests"
This reverts commit 913109149534a732bdb5461d0ba2759f5d2f50f4.
Reason for revert:
Multiple failures on Linux, for example:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/39500https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/9251
Original change's description:
> Port another set of sticky tests to JS rather than reftests
>
> Change-Id: Idf6dd882d2d50b1ec349f245d76717553ee266b3
> Reviewed-on: https://chromium-review.googlesource.com/882002
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532966}
TBR=flackr@chromium.org,smcgruer@chromium.org
Change-Id: I7a773131066157e0d4216d7fa7c228bd8bff2021
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/893536
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533000}
wpt-commits: bfe08e0b1b1cb016e78d41cdf792db33b7f58070
wpt-pr: 9625
wpt-commits: bfe08e0b1b1cb016e78d41cdf792db33b7f58070
wpt-pr: 9625
Automatic update from web-platform-tests[LayoutNG] The available space on a line may be affected by text-indent.
Corrected a DCHECK and added a test that used to crash (but otherwise
pass).
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I139fda3ce912c9138fc055ca7d55d568d5017092
Reviewed-on: https://chromium-review.googlesource.com/928653
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538346}
wpt-commits: 48a72dd95fcf0352f30297cd5d8293331aabed7e
wpt-pr: 9607
wpt-commits: 48a72dd95fcf0352f30297cd5d8293331aabed7e
wpt-pr: 9607
Automatic update from web-platform-testsUse red images for service worker multipart-image wpt
external/wpt/service-workers/service-worker/multipart-image.https.html
checks the image data of multipart image when loading succeeds. The
check was flaky because we used different colors for each part
(green and red) and the content of the image data depends on which
part of the multipart image is currently shown. Since it's difficult
to detect which part is currently shown, we use the same color (red)
for each part to avoid the flakiness.
Bug: 813775
Change-Id: Iaafb4c02b2b72831951b5f6c244eea0b62153cd5
Reviewed-on: https://chromium-review.googlesource.com/930062
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538339}
wpt-commits: 6fea5b1b40cf678fdbca7e9cf3a132256fe9f8fd
wpt-pr: 9620
wpt-commits: 6fea5b1b40cf678fdbca7e9cf3a132256fe9f8fd
wpt-pr: 9620
Automatic update from web-platform-testsbluetooth: Migrate service is removed tests
This change moves the service is removed tests into wpt/.
BUG=509038
Change-Id: I3472ee5dca6ea3706b4f8383790fa3a1f2a81c76
Reviewed-on: https://chromium-review.googlesource.com/904730
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538284}
wpt-commits: 981f9153417351495150354d81676bfab5cd7ac5
wpt-pr: 9464
wpt-commits: 981f9153417351495150354d81676bfab5cd7ac5
wpt-pr: 9464
Automatic update from web-platform-tests[css-typed-om] Add per-property test for 'opacity'.
This patch adds tests for opacity, which only takes a <number> and whose
computed value is clamped to [0, 1]. This is the <number> property so
we had to add to the test harness.
Bug: 545318
Change-Id: I5689843188811c8c14c062a60deb0a8c580de3d9
Reviewed-on: https://chromium-review.googlesource.com/927745
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538269}
wpt-commits: 9b97da2b2f50e97d7809f56002fade93358fd41c
wpt-pr: 9594
wpt-commits: 9b97da2b2f50e97d7809f56002fade93358fd41c
wpt-pr: 9594
Automatic update from web-platform-tests[css-layout-api] Populate styleMap and give to layout function.
This adds both style-invalidation for the LayoutCustom object, as well
as giving the populated StylePropertyMapReadOnly to the layout()
function.
ComputedStyle::DiffNeedsFullLayout now needs a Document in order to look
up the DocumentLayoutDefinition, to see which properties need to checked
for change.
Bug: 726125
Change-Id: Ie462cb624ba413c796131433ea4eae9bb9f3ec13
Reviewed-on: https://chromium-review.googlesource.com/926906
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538268}
wpt-commits: 6aeb9ea2a3874d39418e7ea15778a719ec0d482d
wpt-pr: 9590
wpt-commits: 6aeb9ea2a3874d39418e7ea15778a719ec0d482d
wpt-pr: 9590
Automatic update from web-platform-testswebdriver: make test_handle_prompt_accept consistent with other similar tests (#9612)
Other webdriver tests that test the same thing for other commands all test
for accepting a `prompt()` dialog to look for either the empty string ("")
or undefined as the value returned by the method. This makes the
fullscreen tests consistent with those others.
wpt-commits: e92532746b7615dcccdfa060937a87664816b1db
wpt-pr: 9612
wpt-commits: e92532746b7615dcccdfa060937a87664816b1db
wpt-pr: 9612
Automatic update from web-platform-testswebdriver: remove ES6 constructs from pages (#9600)
Internet Explorer doesn't support ES6 constructs like fat arrow functions.
So that the WebDriver tests can be executed against IE, the pages loaded
in the browser by the tests shouldn't include such constructs.
wpt-commits: d6dc97a217ddb16ed70a57326f7c6236faef13a0
wpt-pr: 9600
wpt-commits: d6dc97a217ddb16ed70a57326f7c6236faef13a0
wpt-pr: 9600
Automatic update from web-platform-testswebdriver: add property name for self-referential array object (#9603)
To create a full object for use with Internet Explorer, the object literal
should contain a property name for the self-referential array object
added as a property value.
wpt-commits: 0d68b017755cc6e8890391f213f4376e0a52502c
wpt-pr: 9603
wpt-commits: 0d68b017755cc6e8890391f213f4376e0a52502c
wpt-pr: 9603
Automatic update from web-platform-testswebdriver: add additional enabled <option> element in test page (#9601)
Clicking on a disabled <option> element should not allow it to become
selected. However, if the disabled <option> is the only child element of
the <select> element, it may be marked as selected by the user agent. This
commit allows the test to attempt to call elementClick on a disabled
<option> without it being selected.
wpt-commits: cf1569d41abb8dd17fcb70cdff37ea4486a2b281
wpt-pr: 9601
wpt-commits: cf1569d41abb8dd17fcb70cdff37ea4486a2b281
wpt-pr: 9601
Automatic update from web-platform-testswebdriver: fix some issues in fullscreen tests (#9575)
The test test_handle_prompt_accept seems to think that the
Fullscreen Window command returns the window title, which is
not the case. Remove wrong assertions. The return payload is
checked by a different test case.
The test test_handle_prompt_missing_value has a typo in a
global variable lookup. This throws a JS exception at runtime.
Tests that use is_fullscreen fail when run in WebKit because
WebKit does not yet conform to the Fullscreen API and its existing
properties and methods are prefixed. Add a fallback and a note
with the WebKit bug that blocks removing this fallback.
wpt-commits: a98c69d9778bdf736cfc1665fd22bc31df76248c
wpt-pr: 9575
wpt-commits: a98c69d9778bdf736cfc1665fd22bc31df76248c
wpt-pr: 9575
Automatic update from web-platform-testsPort another set of sticky tests to JS rather than reftests
Change-Id: Idf6dd882d2d50b1ec349f245d76717553ee266b3
Reviewed-on: https://chromium-review.googlesource.com/882002
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532966}
wpt-commits: c67d9e1d65aaf3e852dcd9b00b5feb40e80f36b7
wpt-pr: 9523
wpt-commits: c67d9e1d65aaf3e852dcd9b00b5feb40e80f36b7
wpt-pr: 9523
Automatic update from web-platform-testsEnsure we always run against the latest version of Firefox. (#9537)
Previously we were downloading a version by looking for the first
match of the supplied regexp on the download page. That doesn't work
well in general and we need to look through the listings for the
version with the highest number.
wpt-commits: 9d8895d75af32e8f3a3a558d0dede40881705c78
wpt-pr: 9537
wpt-commits: 9d8895d75af32e8f3a3a558d0dede40881705c78
wpt-pr: 9537
Automatic update from web-platform-testsUpdate reftests in manifest when reftests become non-reftests (#9598)
In https://github.com/w3c/web-platform-tests/pull/9523 some tests were
converted from reftests to testharness, but the incremental manifest
update mechanism doesn't handle this case. This appears to be the cause
of the mysterious Travis failures on that PR.
The added test failed without the code changes.
wpt-commits: 86195076e37a960ff44fa86edc54699455f3a4aa
wpt-pr: 9598
wpt-commits: 86195076e37a960ff44fa86edc54699455f3a4aa
wpt-pr: 9598
Automatic update from web-platform-testscc Add https://streams.spec.whatwg.org/demos tests
When JavaScript-syntax checking for `script`-element contents was
recently added to the HTML checker, it broke the build of the Streams
spec due to some documents in https://streams.spec.whatwg.org/demos/
using some newer JavaScript syntax that the Rhino parser (which the HTML
checker relies on) doesn’t understand yet.
So to ensure those cases get handled correctly, some refinements were
made to the HTML checker and the Rhino fork it uses. The documents are
added here to ensure no regressions occur.
wpt-commits: 46c5f2bbb079c919f47e5842ab01e4da1a23b0da
wpt-pr: 9596
wpt-commits: 46c5f2bbb079c919f47e5842ab01e4da1a23b0da
wpt-pr: 9596
Automatic update from web-platform-tests[css-typed-om] Remove StylePropertyMap.getProperties().
This patch removes StylePropertyMap.getProperties() as it
is the same as StylePropertyMap.keys().
Bug: 545318
Change-Id: Ib31c70478306f415c4c184e1b2148f35759f58c4
Reviewed-on: https://chromium-review.googlesource.com/925883
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538033}
wpt-commits: eb5d88a3f712661c75c0f1ba051c06e97d43de1a
wpt-pr: 9580
wpt-commits: eb5d88a3f712661c75c0f1ba051c06e97d43de1a
wpt-pr: 9580
Automatic update from web-platform-tests[LayoutNG] Use containing block size correctly for abspos.
UpdateOutOfFlowBlockLayout() needs to deal with both the actual
containing block size, as specified by CSS (i.e. the padding box size),
and the border-box size of the object that is the containing block of an
absolutely positioned descendant.
Some light cleanup. We always need the border sizes, so just calculate
them once, unconditionally. Also, there seems no need for a special path
for grid/flex, so I removed it.
Some tests start to pass. All but one are still expected to fail in legacy.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I85462d76aa9fa3d0105bf079e59f7c2a7a70f117
Reviewed-on: https://chromium-review.googlesource.com/926004
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537918}
wpt-commits: 58462b6f92aab3eea03ad1ea70923855889ed1e2
wpt-pr: 9589
wpt-commits: 58462b6f92aab3eea03ad1ea70923855889ed1e2
wpt-pr: 9589
Automatic update from web-platform-testsFix WebAudio WPT tests that timeout.
- AudioParam IDL test:
Actually add the IDL to the test. Also removed unused helpers.js.
- MediaElementAudioSourceNode
Fix error because the expected result is mono, so only has one channel.
However, this still fails on bots because there's no audio hardware to
drive the online context.
Bug: 626703
Test: the-audioparam-interface/idl-test.html
Change-Id: I987ad1219da1b6b6ef677f2923416634fa281d5f
Reviewed-on: https://chromium-review.googlesource.com/920261
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537856}
wpt-commits: 0d5ca044187f3e1122661048e84a54e736296198
wpt-pr: 9548
wpt-commits: 0d5ca044187f3e1122661048e84a54e736296198
wpt-pr: 9548
Automatic update from web-platform-testsReadableStream: test piping and queued writes
When the readable stream becomes closed after the first write,
all queued writes should complete before the pipe operation
becomes completed.
This tests the fix for this behavior in the Streams reference
implementation in whatwg/streams#884.
wpt-commits: 4c74a92846442ebb277342c3afe663a2c89955d4
wpt-pr: 9573
wpt-commits: 4c74a92846442ebb277342c3afe663a2c89955d4
wpt-pr: 9573
Automatic update from web-platform-testsUpdate supported font format specifiers
While we do support variations, our format specifier support was not
updated yet. Move all of that to FontCustomPlatformData and add a WPT
test to cover common supported format specifiers.
Test: external/wpt/css/css-fonts/format-specifiers-variations.html
Bug: 804466
Change-Id: I06d7af65cf74e13cec49dc279efb8ffc2b56dda9
Reviewed-on: https://chromium-review.googlesource.com/926007
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537799}
wpt-commits: ee2e2949929d0d371404ec5a3a7bb2873f44b34c
wpt-pr: 9585
wpt-commits: ee2e2949929d0d371404ec5a3a7bb2873f44b34c
wpt-pr: 9585
Automatic update from web-platform-testsFix #8954: update wptrunner requirements
Note this just uses the current stable release of all dependencies
rather than trying to find what the minimum required actually is.
--
Pin wptrunner dependencies
Given it's an application, we should just define the environment we
expect it to run in. This should stop #8954 from regressing, given it
also means we'll be testing against the only possible set of versions
of our dependencies.
wpt-commits: 25f040e64a77219f8e5bde319adc8561d5750823, d936893f3ce7e2530994f8df62799d17cbd56dfb
wpt-pr: 9587
wpt-commits: 25f040e64a77219f8e5bde319adc8561d5750823, d936893f3ce7e2530994f8df62799d17cbd56dfb
wpt-pr: 9587
Automatic update from web-platform-testsOOR-CORS: Port WebCORSPreflightResultCacheItem to network service
This patch reimplements WebCORSPreflightResultCacheItem equivalent
in network service, and share the implementation between the network
service and Blink. The next patch will replace whole
WebCORSPreflightResultCache, and this is the preparation to make
the next patch small.
Bug: 803766
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifa06967830465236dbe198908062e1952095e55b
Reviewed-on: https://chromium-review.googlesource.com/915543
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537769}
wpt-commits: de9d5d19b70d2d8b39a9e6f9006d0a2fb4f93f53
wpt-pr: 9539
wpt-commits: de9d5d19b70d2d8b39a9e6f9006d0a2fb4f93f53
wpt-pr: 9539
Automatic update from web-platform-testsDelete StylePropertyMap.update()
This is as there is a bug on the spec highlighting the lack of
usefulness of the function: https://github.com/w3c/css-houdini-drafts/issues/656
Bug: 812912
Change-Id: If0b47a4bfa268f55f63e5c80168971164dc63199
Reviewed-on: https://chromium-review.googlesource.com/923501
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537697}
wpt-commits: 8f3f3d57d537c956eed62f78172325e97f093025
wpt-pr: 9554
wpt-commits: 8f3f3d57d537c956eed62f78172325e97f093025
wpt-pr: 9554
Automatic update from web-platform-tests[css-typed-om] Fix crash involving negative length perspectives.
We were crashing because converting CSSPerspective(-1px) to a CSSValue
returns nullptr. The correct behaviour should be to convert it as
CSSPerspective(calc(-1px)).
Bug: 812620
Change-Id: I5ee70d4fb5eed064bcdad67391c3eb84531144d6
Reviewed-on: https://chromium-review.googlesource.com/924742
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537690}
wpt-commits: 969ae697f67e35fb93c18fa36a57ff605a47256d
wpt-pr: 9567
wpt-commits: 969ae697f67e35fb93c18fa36a57ff605a47256d
wpt-pr: 9567
Automatic update from web-platform-tests[css-typed-om] Handle out-of-range values correctly.
Currently, when we set width to something like -1, we would get an
invalid value for width. According to the spec [1], we should be
wrapping the invalid value in a calc.
This patch wraps invalid values in calc, and changes the test harness
to allow us to test this.
Bug: 545318
Change-Id: I71769e1bc69164c9b7dcf0d2c54ca06b623b5d9e
Reviewed-on: https://chromium-review.googlesource.com/923603
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537685}
wpt-commits: ca39b1ed0fa70e60bfbcbfe5be7e305b0e5c2d20
wpt-pr: 9568
wpt-commits: ca39b1ed0fa70e60bfbcbfe5be7e305b0e5c2d20
wpt-pr: 9568
Automatic update from web-platform-testsFix #7142: Change manifest update process
Earlier, interrupting the manifest-update could end up
causing errors due to the non-atomicity of the process.
Used tempfile to ensure that the file is written correctly.
wpt-commits: 38612167f54c475836c122013756e92b9a8859cc
wpt-pr: 9564
wpt-commits: 38612167f54c475836c122013756e92b9a8859cc
wpt-pr: 9564
Automatic update from web-platform-testsFix wpt/beacon/headers/header-content-type.html slowness
This CL uses ResourceTiming API to speed up the test cases while
avoiding flakiness.
Bug: 779965
Change-Id: I40dc2fae470df296c87c12e432fc7fc7644cc40a
Reviewed-on: https://chromium-review.googlesource.com/923625
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537664}
wpt-commits: b20bddda8e47b046fc6ffccda4897cb81df14102
wpt-pr: 9569
wpt-commits: b20bddda8e47b046fc6ffccda4897cb81df14102
wpt-pr: 9569
Automatic update from web-platform-testsStreams: Tests for abuse of RSBYOBRequest (#9558)
In https://github.com/whatwg/streams/pull/870 it was made impossible to
directly construct a ReadableStreamBYOBRequest. Prior to that it was
possible to violate the state invariants of ReadableByteStreamController
by constructing then using a BYOBRequest directly. Add tests that verify
that it is not possible to construct a ReadableStreamBYOBRequest
directly.
Also add tests that it isn't possible to violate the invariants of
ReadableByteStreamController by re-using a BYOBRequest object.
Also add a test that it isn't possible to keep a BYOBRequest object
valid while releasing the reader lock, as this would also be a way to
violate ReadableByteStreamController's invariants.
Fixeswhatwg/streams#870
wpt-commits: abcd6e9aeb4267511740c45bf8e484b5ca1d95db
wpt-pr: 9558
wpt-commits: abcd6e9aeb4267511740c45bf8e484b5ca1d95db
wpt-pr: 9558
Automatic update from web-platform-testsRefactor tests for sandbox iframes controlled by service worker
This patch is to split sandboxed-iframe-fetch-event.https.html into small
chunks. Each promise_test has smaller number of assertions, so that now we can
see the results for each situation.
Bug: 771815
Change-Id: I75cdd67f92bbb07d6b538b209e1f0819752c3bc8
Reviewed-on: https://chromium-review.googlesource.com/923901
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537606}
wpt-commits: 63a5a6d7c789f004f09e5cbb801b49cfb4426989
wpt-pr: 9556
wpt-commits: 63a5a6d7c789f004f09e5cbb801b49cfb4426989
wpt-pr: 9556
Automatic update from web-platform-testsStop reusing MemoryCache entries for requests with a different source origin.
ResourceFetcher/ResourceLoader now saves the result of the CORS check on
the Resource object. Though the result of the CORS check varies
depending on the source origin, reusing an existing resource fetched by
a different source origin is allowed by mistake.
This patch introduces a logic to prevent MemoryCache entries from being
reused for requests with a different source (requestor) origin by saving
the source origin on the Resource object and comparing that with the new
source origin in Resource::CanReuse(), so that the result of the CORS
check is reused only when the source origin is the same.
An alternative possibly-better approach is to isolate MemoryCache for
different origins by changing the cache identifier to take into account
the source origin of requests. However, to keep the patch small and fix
the issue quickly, this patch just prevents reuse.
Bug: 799477, 809350
Change-Id: Ib96c9e728abe969a53f3d80519118a83392067b4
Reviewed-on: https://chromium-review.googlesource.com/897040
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537580}
wpt-commits: e6bda363d5bc9722b326631c36333d41101c0cb3
wpt-pr: 9536
wpt-commits: e6bda363d5bc9722b326631c36333d41101c0cb3
wpt-pr: 9536
Automatic update from web-platform-testsSet WasFetchedViaServiceWorker for multipart image response
When creating a ResourceResponse from another ResourceResponse,
we need to copy WasFetchedViaServiceWorker and
ResponseTypeViaServiceWorker.
Bug: 737648
Change-Id: I9405738221ef5232e235f9fc400f204b7b558596
Reviewed-on: https://chromium-review.googlesource.com/907012
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537579}
wpt-commits: 75c962d7c542f3a6c6e43bcf18a4bf67a16f86cf
wpt-pr: 9492
wpt-commits: 75c962d7c542f3a6c6e43bcf18a4bf67a16f86cf
wpt-pr: 9492
Automatic update from web-platform-testsReadableStream: Add a test that all queued writes complete on error (#5636)
When a pipe is errored, all currently queued writes should complete
before abort() is called on the underlying sink.
The tests the fix to this behaviour in the Streams reference
implementation in whatwg/streams#884.
wpt-commits: ee7ca4fb8371000d2429a99002d1ad71275d5cde
wpt-pr: 5636
wpt-commits: ee7ca4fb8371000d2429a99002d1ad71275d5cde
wpt-pr: 5636
Automatic update from web-platform-testsFix selection{Start,End} test
Likely due to a copy and paste error, one of the tests that was
meant to cover both selectionStart and selectionEnd only covered
the former. Fix so that it covers both, as it should have from the
start.
wpt-commits: 08dd5d8de9c165badabf9f18b5be21a561d8213a
wpt-pr: 9563
wpt-commits: 08dd5d8de9c165badabf9f18b5be21a561d8213a
wpt-pr: 9563
Automatic update from web-platform-tests[css-layout-api] Implement the guts of the javascript layout runner.
This implements the hooks from the LayoutCustom object into a web
developer defined layout class.
See: https://drafts.css-houdini.org/css-layout-api/#invoke-a-layout-callback
Currently the only useful thing this does to allow the web developer to
return an "auto" block-size, e.g.
registerLayout('foo', class {
*intrinsicSizes() {}
*layout() {
return { autoBlockSize: Math.random() * 100; } // FUN!
}
});
The engine calculates the inline-size, and adjusts the block-size for the
web developer. This is a simplification on the current API as spec'd but
we'll see what the HoudiniTF thinks of this approach.
The other large behaviour change is appropriate "fallback" handling when
something goes wrong. See "fallback" tests.
Bug: 726125
Change-Id: I08cd2e439f4321bd534a4e3f7222fbdb898e1785
Reviewed-on: https://chromium-review.googlesource.com/917423
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537371}
wpt-commits: 1a2e430c6fd35c111ead0d5a0e9afbe874e7c1a2
wpt-pr: 9509
wpt-commits: 1a2e430c6fd35c111ead0d5a0e9afbe874e7c1a2
wpt-pr: 9509
Automatic update from web-platform-testsCorrect integration with Sauce Labs service (#9484)
A recently merged patch centralized configuration values which defined
the domain names available during test execution [1]. That patch was
based on a mistaken assumption regarding the location of that value and
the stage of the test execution at which it would be available.
(Specifically: the value is not present in the environment configuration
object when the "environment extras" are initialized.) This interfered
with the initialization of the "environment" for the Sauce Labs service,
making it impossible to run the tests there.
Defer the retrieval of the environment configuration object to the time
that object's context manager is activated. Update the call sites to
provide the environment configuration at this moment. Also update the
signature of the context manager for the `FontInstaller` "environment
extra" to accept this second parameter.
[1] https://github.com/w3c/web-platform-tests/pull/8614
wpt-commits: e56563d2b1e8bd225bf4c8b4682cbd12beeae1a7
wpt-pr: 9484
wpt-commits: e56563d2b1e8bd225bf4c8b4682cbd12beeae1a7
wpt-pr: 9484
Automatic update from web-platform-testswptrunner: Fix regression in config, interpreter (#9480)
Prior to the application of this patch, the configuration property named
`host` was required to expand the templated JSON file maintained within
the WPT CLI. By removing the property from some browser definitions
without updating that template, commit 1b4f253 introduced failures when
using the `run` sub-command with the effected browsers.
Refactor the logic for generating the configuration to use an in-memory
representation (instead of a file-based template) and conditionally
extend this object with the `host` option for browsers which specify it.
Document the rationale for the browser which requires this
functionality.
wpt-commits: cb2d75fd13182ab3bdd7189dafe2ff7bbf4acd56
wpt-pr: 9480
wpt-commits: cb2d75fd13182ab3bdd7189dafe2ff7bbf4acd56
wpt-pr: 9480
Automatic update from web-platform-testsFix timeouts in WPT AudioParam tests
Replace the tests that are using ScriptProcessor and online contexts
with an offline context and verify all the output values instead of
just one.
This change exposed a couple of issues:
- setTargetAtTime wasn't actually testing setTargetAtTime because a
linearRampToValueAtTime event was called at the same time,
effectively replacing the setTargetAtTime event
- linearRampToValue and exponentialRampToValue tests expose bugs in
Chrome's implementation of these when the event is scheduled in
the past, and there is no preceding event.
Bug: 812285, 626703
Change-Id: Iad3f54dd4373411431c019de44d4c3bad07587ff
Reviewed-on: https://chromium-review.googlesource.com/919151
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537311}
wpt-commits: 81ada4212ece1e2f5c6cc560d6b2f45593679e93
wpt-pr: 9524
wpt-commits: 81ada4212ece1e2f5c6cc560d6b2f45593679e93
wpt-pr: 9524
Automatic update from web-platform-tests[LayoutNG] Don't add zero-width floats to the exclusion space.
The only thing such floats should affect is the block position of
subsequent floats (float rule §5 [1] and clearance). They should not
affect the inline position or inline size of subsequent floats or new
formatting contexts.
The spec isn't actually clear here, although the browsers agree on the
above. Submitted https://github.com/w3c/csswg-drafts/issues/2312
[1] https://www.w3.org/TR/CSS22/visuren.html#float-position
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia9e724c8a58fcb017f86f26bdf90394f09414f4e
Reviewed-on: https://chromium-review.googlesource.com/919065
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537274}
wpt-commits: ae06fa4ce5d170f7f34e979b014315e318344ec4
wpt-pr: 9538
wpt-commits: ae06fa4ce5d170f7f34e979b014315e318344ec4
wpt-pr: 9538
Automatic update from web-platform-testsservice worker: Disallow interception for EMBED and OBJECT requests.
This matches the service worker specification and Firefox.
This change itself is probably not enough to skip all EMBED/OBJECT
requests, as some requests get initiated by PepperURLLoaderHost or
MimeHandlerViewContainer.
In implementor concerns:
https://w3c.github.io/ServiceWorker/#implementer-concerns
"Plug-ins should not load via service workers. As plug-ins may get their
security origins from their own urls, the embedding service worker cannot
handle it. For this reason, the Handle Fetch algorithm makes the
potential-navigation-or-subresource request (whose context is either <embed> or
<object>) immediately fallback to the network without dispatching fetch event."
In Handle Fetch:
https://w3c.github.io/ServiceWorker/#handle-fetch
"If request is a potential-navigation-or-subresource request, then:
Return null."
R=kinuko, yhirano
Bug: 771933
Change-Id: Ia04ae8dec8c968de6a73dca088aa88a67b21718a
Reviewed-on: https://chromium-review.googlesource.com/923445
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537245}
wpt-commits: e7607dad61b547e88d1f06a67b1514a3242600ec
wpt-pr: 9555
wpt-commits: e7607dad61b547e88d1f06a67b1514a3242600ec
wpt-pr: 9555
Automatic update from web-platform-tests[css-typed-om] Make StylePropertyMap.set work with calcs.
Currently StylePropertyMap.set doesn't actually work with calcs.
The current way to check if something is, say, a <length> is to
check its CSSStyleValue::Type. However, this doesn't return
the right value for CSSMathValues, whose types may be quite
complicated.
The correct way is to use the CSSNumericValue matching algorthms:
CSSNumericValue::MatchesLength, which also takes into account
CSSMathValues and percent hints.
This patch changes the following to make this work:
- Removed base types from CSSStyleValue::StyleValueType. A base type
like "length" is not really a CSSStyleValue type.
- Removed unused StyleValueTypeToString.
- Changed "Percent" to "Percentage" in CSSProperties.json5 as that's
the correct term.
- Changed make_cssom_types to use the matching algorithms from
CSSNumericValue.
Bug: 545318
Change-Id: I16aa71a4873e9992749f0f52ba641671d109170e
Reviewed-on: https://chromium-review.googlesource.com/901002
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537206}
wpt-commits: b52a7a29208647f209f06ac2e6321987023c196c
wpt-pr: 9535
wpt-commits: b52a7a29208647f209f06ac2e6321987023c196c
wpt-pr: 9535
Automatic update from web-platform-testsAdd initial test set for Accessible Name and Description Computation 1.1 (#9540)
Note that many of the tests are currently named with a number. Those
tests were taken from the original (1.0) test suite created by the
PFWG, and the file names are being preserved to facilitate comparison
of results.
wpt-commits: 2b4cdad36bd267e39565ebaab5982b9b4c482e53
wpt-pr: 9540
wpt-commits: 2b4cdad36bd267e39565ebaab5982b9b4c482e53
wpt-pr: 9540
Automatic update from web-platform-testsAdd tests for the breaking of a multicolumn across columns, including backgrounds and column rules. (#9527)
The *-nobackground-* tests pass in Firefox and Chrome, and the others
pass in Chrome and fail in Firefox due to what I (as a Gecko
implementor) consider to be a Firefox bug. I haven't yet tested other
engines. (Though -nobackground-003 fails in Firefox due to a different
bug, and multicol-breaking-002 doesn't trigger the background-related
Firefox bug.)
Given the level of ambiguity in the multicol spec, I suspect these tests
probably test some things that aren't formally specified. However, I
think that's probably OK for now. One issue that I know of that they
depend on the spec for is w3c/csswg-drafts#2309.
wpt-commits: d04c0d50dbbf7752c27957005a5a659701b781ad
wpt-pr: 9527
wpt-commits: d04c0d50dbbf7752c27957005a5a659701b781ad
wpt-pr: 9527
Automatic update from web-platform-testsReftest for handling important when there is an animation.
This tests https://drafts.csswg.org/css-cascade/#importance
wpt-commits: 5ee47da05ffc366a887788ccdc3f7a0673c35953
wpt-pr: 8689
wpt-commits: 5ee47da05ffc366a887788ccdc3f7a0673c35953
wpt-pr: 8689
Automatic update from web-platform-tests[USVString] Apply USVString into RTCDataChannel.send
Latest spec changed DOMString type of send with USVString.
- https://w3c.github.io/webrtc-pc/#dom-rtcdatachannel
This CL applies USVString type into the RTCDataCchannel.send according to the spec.
Bug: 790860
Change-Id: I3d2e3fef8e6a8cc8ca94a8ae18c2ccb7dcc48016
Reviewed-on: https://chromium-review.googlesource.com/917741
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537015}
wpt-commits: 1a3951e267e61077ca566e9872c9abeb229d5751
wpt-pr: 9530
wpt-commits: 1a3951e267e61077ca566e9872c9abeb229d5751
wpt-pr: 9530
Automatic update from web-platform-tests[LayoutNG] Allow zero-width layout opportunities.
Zero-width floats or in-flow block-level objects that establish a new formatting
context may fit beside preceding floats even if there's zero inline space left.
With this change, a couple of tests start passing, but coverage seems a
bit low, so I added a few new ones.
Had to rebaseline fast/text/word-break.html because a zero-width line
may now fit beside a float that takes up all available inline
space. There was a <br clear=all> in the test that used to insert the
line below such a float. We're now compatible with the others (and our
old selves).
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iaf394b7039545eea235b2841457f1662e5890ba9
Reviewed-on: https://chromium-review.googlesource.com/916262
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537000}
wpt-commits: e2b2513a9ab764bcec7ccf616a35835d13020e32
wpt-pr: 9503
wpt-commits: e2b2513a9ab764bcec7ccf616a35835d13020e32
wpt-pr: 9503
Automatic update from web-platform-testsUpdating Server creation for localhost (#9202)
In my last change, I missed this line of code. Adding the host parameter and removing the base_path param.
wpt-commits: 09ca41d71aab5d5640804b34e5165f291259f112
wpt-pr: 9202
wpt-commits: 09ca41d71aab5d5640804b34e5165f291259f112
wpt-pr: 9202
Automatic update from web-platform-testsMake WPT webrtc/simplecall.html pass
The test was failing because passing a null ("end of candidates")
candidate to addIceCandidate is not permitted.
Spec link:
https://www.w3.org/TR/webrtc/#dom-rtcpeerconnection-addicecandidatehttps://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addicecandidate
Bug: none
Change-Id: I1f22d27393a482a882ebe9735488d8cb723b6e75
Reviewed-on: https://chromium-review.googlesource.com/918662
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536977}
wpt-commits: 49d8cd27466bcd293f86a5758f21fcd23a97f196
wpt-pr: 9516
wpt-commits: 49d8cd27466bcd293f86a5758f21fcd23a97f196
wpt-pr: 9516
Automatic update from web-platform-tests[css-typed-om] Move inline style map layout tests to WPT.
We used to have some inline style map layout tests for a subset of
properties. This patch moves them to WPT using the new test harness.
Properties added:
- white-space
- vertical-align
- visibility
- z-index
Bug: 774887
Change-Id: Icce056c4d7f56eed3da05834b1c561fddec53a15
Reviewed-on: https://chromium-review.googlesource.com/918203
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536966}
wpt-commits: e4730a5e002aadca9605485aec9ccb4c122f15de
wpt-pr: 9514
wpt-commits: e4730a5e002aadca9605485aec9ccb4c122f15de
wpt-pr: 9514
Automatic update from web-platform-testsCSS2 tests were only correct if the default font has two weights. (#9533)
font-weight-rule 005 and 007 both made the incorrect
assumption that there were no weights lighter than 400
or greater than 700 in the default font. Added new
references for them which don't depend on that.
wpt-commits: 30c492f9078d50bff86b4459e78d31cc0d7bf47b
wpt-pr: 9533
wpt-commits: 30c492f9078d50bff86b4459e78d31cc0d7bf47b
wpt-pr: 9533
Automatic update from web-platform-testsAdd test for wrappable content that has flex:none (#9518)
Add test for wrappable content that has flex:none
See https://bugzilla.mozilla.org/show_bug.cgi?id=1374540; per spec, the
flex:none content should be allowed its full content width. This
currently works in Chrome, Edge, Safari, and Opera.
wpt-commits: a02389e2cc84576b8aa35bff9658f6db39003ed8
wpt-pr: 9518
wpt-commits: a02389e2cc84576b8aa35bff9658f6db39003ed8
wpt-pr: 9518
Automatic update from web-platform-testsMerge pull request #9397 from faceless2/bfo-css-fonts-3-fontfeature
Added new testcases to test font-variant precedence rules
wpt-commits: 840362217deb3f9b82fe18a619d0bf21ddc55781
wpt-pr: 9397
wpt-commits: 840362217deb3f9b82fe18a619d0bf21ddc55781
wpt-pr: 9397
Automatic update from web-platform-testsCheck that fetch request signal following works correctly
This test already tests integration, so this is just an extra check.
Follows https://github.com/whatwg/fetch/pull/670.
wpt-commits: e151f898bfde2bfb518206008a911577be8a5a68
wpt-pr: 9515
wpt-commits: e151f898bfde2bfb518206008a911577be8a5a68
wpt-pr: 9515
Automatic update from web-platform-tests[css-typed-om] Move inline style map layout tests to WPT.
We used to have some inline style map layout tests for a subset of
properties. This patch moves them to WPT using the new test harness.
Properties added:
- position
- padding-{top,bottom,left,right}
- text-align
- text-decoration-style
Bug: 774887
Change-Id: I9fc9d6d425b1a5ce0c71f8d918bc5893c74c4e89
Reviewed-on: https://chromium-review.googlesource.com/917927
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536698}
wpt-commits: 9e98749811573be88146eaeac56732d445f769fd
wpt-pr: 9513
wpt-commits: 9e98749811573be88146eaeac56732d445f769fd
wpt-pr: 9513
Automatic update from web-platform-testsSetting "" as <track> 'src' should fail the first time
When setting a track .src to "", we would resolve the URL to a null URL,
which matched the default initialized HTMLTrackElement::url_, meaning
that readyState was not advanced and no 'error' event fired in this
case.
Extend the "url == url_" check with a check for readyState differing from
'none'. Also rewrite HTMLTrackElement::getReadyState to avoid using
EnsureTrack().
Bug: 811713
Change-Id: Icd190492639c53e09a7e018202b69ac6e919a94c
Reviewed-on: https://chromium-review.googlesource.com/916004
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#536685}
wpt-commits: 7bdac4aedb60223226e5941b7cc8ebadfcc9885b
wpt-pr: 9498
wpt-commits: 7bdac4aedb60223226e5941b7cc8ebadfcc9885b
wpt-pr: 9498
Automatic update from web-platform-tests[css-typed-om] Move inline style map layout tests to WPT.
We used to have some inline style map layout tests for a subset of
properties. This patch moves them to WPT using the new test harness.
Fixed some bugs involving properties not given the correct metadata
(e.g. border-style should not take an <image>).
Transform is failing tests because it should compute to as specified
but it's computing to 'none' (will fix this later).
TODO in follow up patches:
- Test list-valued properties properly.
- Add more test examples to <position> and <image>.
Bug: 774887
Change-Id: I93f20a457e2220329b661787c7d557ee28b1f62d
Reviewed-on: https://chromium-review.googlesource.com/917921
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536658}
wpt-commits: 783faf5a3f8803a1a1f4f30345f67de333a6d72c
wpt-pr: 9511
wpt-commits: 783faf5a3f8803a1a1f4f30345f67de333a6d72c
wpt-pr: 9511
Automatic update from web-platform-testsFetch API: Don't DCHECK on a 302 response with a Location header with empty value.
Blink was failing a DCHECK when it expected a redirect to be taken because
the request mode was 'follow' and the response had a redirect status code
and Location header. However, Chrome's //net considers a Location header
with an empty value to be the same as no Location header at all. See the
comments on bug 810288 about net::HttpResponseHeaders::IsRedirect().
WPT tests are added. The spec is unclear (https://github.com/whatwg/url/issues/373)
but seems to either say to fail with network error or enter a loop of self-redirects
that will eventually hit the redirect limit and fail with network error.
Chrome currently fails this test because it treats the Location as
as non-existent, i.e., not a redirect response.
Bug: 810288,707185
Change-Id: Iaca93976aaa697380b1542ab45d63c318f5050b0
Reviewed-on: https://chromium-review.googlesource.com/910753
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536644}
wpt-commits: e75788501733a0801eec374c19f8cdfbccd9c09d
wpt-pr: 9453
wpt-commits: e75788501733a0801eec374c19f8cdfbccd9c09d
wpt-pr: 9453
Automatic update from web-platform-tests[custom-elements] Add HTML serialization tests
This is for https://github.com/whatwg/html/pull/3444
wpt-commits: d0114efdde520f9aa003ce42c85ef134f01ad691
wpt-pr: 9508
wpt-commits: d0114efdde520f9aa003ce42c85ef134f01ad691
wpt-pr: 9508
Automatic update from web-platform-tests[css-typed-om] Refactor the per-property test harness.
This patch refactors the per-property test harness quite
a bit to deal with property specific behaviour:
- We allow tests to override the expectation/asserts
for specified and computed values. So it means that a
property might compute 'auto' to '0px' and we can easily
assert that by passing a callback to 'computed'.
- We moved margin-top to margin and test all the margin
properties (except the margin shorthand).
- We made margin properties work by setting the correct
metadata in the CSSProperties.json5.
- We removed unitless zero tests. They don't seem to
be required by the spec.
Bug: 774887
Change-Id: I08605ac6af01576ff9f6c878c2ca9e280c9948e1
Reviewed-on: https://chromium-review.googlesource.com/915884
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536603}
wpt-commits: 5479ebec26b46fa4ecf02698863c3ea1d64c3126
wpt-pr: 9507
wpt-commits: 5479ebec26b46fa4ecf02698863c3ea1d64c3126
wpt-pr: 9507
Automatic update from web-platform-tests[custom-elements] Some fixes for "is" attribute behavior changes
This is for https://github.com/whatwg/dom/pull/566.
- document.createElement() and createElementNS() don't add "is" content
attribute.
- cloneNode() should clone custom elements even if they have no "is"
content attributes or have "is" content attribute inconsistent with
"is value."
wpt-commits: 1e4fe87a7f01c0b5c614c8f601ffa68b4a00662a
wpt-pr: 9505
wpt-commits: 1e4fe87a7f01c0b5c614c8f601ffa68b4a00662a
wpt-pr: 9505
Automatic update from web-platform-tests[Picture-in-Picture] Add PictureInPictureWindow width and height stubs
This introduces PictureInPictureWindow interface with |width| and
|height| attributes. |onresize| event will follow in an upcoming CL.
|width| and |height| simply return fake values, respectively 500 and
300, for now as we don't have any resize events coming from the backend
yet. They are reset to 0 though when PictureInPictureWindow state is
closed.
Bug: 806249
Change-Id: I5e0f0875a53b7f659bc3469e562d3db5e075f31d
Reviewed-on: https://chromium-review.googlesource.com/899347
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536520}
wpt-commits: e9ffe0be14f695ad5fb0aa104bbddbcc88712f56
wpt-pr: 9370
wpt-commits: e9ffe0be14f695ad5fb0aa104bbddbcc88712f56
wpt-pr: 9370
Automatic update from web-platform-testsCorrect serialization of background-color (#9499)
According to https://drafts.csswg.org/css-color/#resolving-color-values, transparent should serialize to "rgba(0, 0, 0, 0)", and named colors should serialize to their equivalent value in rgb notation. Change the expectations for 3 background tests in order to match this part of the spec.
wpt-commits: 43deb07215d283d63e2bdca51d6268eba43bbe81
wpt-pr: 9499
wpt-commits: 43deb07215d283d63e2bdca51d6268eba43bbe81
wpt-pr: 9499
Automatic update from web-platform-testsHandle ::slotted in ComputeLinkMatchType.
We skipped the selector list for ::slotted looking for :visited and
:link pseudo classes and ended up applying such rules with both :visited
and :link style.
Bug: 808392
Change-Id: I85956902f3ca9cea01c96ef5c56ccf7f0ee23671
Reviewed-on: https://chromium-review.googlesource.com/904903
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536328}
wpt-commits: c6b11a5cbcd934c4394f7451529dc18269400ff1
wpt-pr: 9413
wpt-commits: c6b11a5cbcd934c4394f7451529dc18269400ff1
wpt-pr: 9413
Automatic update from web-platform-testscustom-elements: document.importNode() for customized built-in elements should work
importNode() implementation should pass "is" value to "create an
element" algorithm.
WPT: Add a new test for importNode().
Bug: 807871
Change-Id: Id60c5577b5899aeac66b819986c34a28978e24d9
Reviewed-on: https://chromium-review.googlesource.com/915744
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536311}
wpt-commits: 79f402f76e5b78f0fae93dbff7c4ddc5cd382e04
wpt-pr: 9494
wpt-commits: 79f402f76e5b78f0fae93dbff7c4ddc5cd382e04
wpt-pr: 9494
Automatic update from web-platform-testscustom-elements: Support cloneNode() for customized built-in elements
Element::CloneElementWithoutAttributesAndChildren() should use "create
an element" algorithm with |is| value.
Note that a change in SVGScriptElement.cpp isn't necessary because
Custom Elements V1 doesn't support SVG elements. This CL updates
SVGScriptElement.cpp for consistency and clean code.
WPT: Add cloneNode() tests to custom-elements/builtin-coverage.html.
Bug: 807871
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iaa7d2781b916e2459ee244540d619cfffcf42427
Reviewed-on: https://chromium-review.googlesource.com/915401
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536297}
wpt-commits: 57780dfd0c0e917a9196974e2d528ac1c705136b
wpt-pr: 9491
wpt-commits: 57780dfd0c0e917a9196974e2d528ac1c705136b
wpt-pr: 9491