So that LTO doesn't eliminate it, leaving the assembly from RR_objc_msgSend
unable to find it.
--HG--
extra : rebase_source : 457c2f4612fd3485d4e099b51e324a6e085016e6
Changes:
Pretty much all files contain changes to the order of events and properties... these are to stop subtle issues with events not being logged because not all properties were sent and some events were sent in the wrong order.
-devtools/client/framework/test/browser_devtools_api.js
- Renamed test-tool-1 and 2 because we need to include the panel names in Events.yaml and "-" is not allowed.
- devtools/client/framework/toolbox.js
- Removed unneeded const REGEX_PANEL.
- Generally shifted things around to ensure we send events from all codepaths.
- toolkit/components/telemetry/Events.yaml
- Changed telemetry event `"devtools.main", "enter"` to include all built-in panel names including "other."
MozReview-Commit-ID: 2G3Z9pzj1QC
--HG--
extra : rebase_source : bc691ae42b521e3a58c1a4aa9dbd455a3aa258a0
The language parameter of mozIPersonalDictionary is unused, so we should remove
this from parameter. Then, no one uses mLanguage member of mozHunspell now.
Differential Revision: https://phabricator.services.mozilla.com/D2349
--HG--
extra : moz-landing-system : lando
This adds a test with an extension signed by autorgraph with cose and pk7.
Differential Revision: https://phabricator.services.mozilla.com/D1855
--HG--
extra : moz-landing-system : lando
The tagging API is moving to the bookmarking API, this is part of it.
This will break the tags root open glyph in the Library, for now we don't have
an alternative, we'll re-evaluate in the future in bug 1477934.
Differential Revision: https://phabricator.services.mozilla.com/D2318
--HG--
extra : moz-landing-system : lando
__wrap_dlerror uses a single pointer for all threads, which means one
thread could get the dlerror result from another thread. Normally this
wouldn't cause crashes. However, because dlerror results come from a
per-thread buffer, if a thread exits and our saved dlerror result came
from that thread, the saved pointer could then refer to invalid memory.
The proper way to fix this is to use TLS and have a per-thread pointer
for __wrap_dlerror. However, instead of using up a TLS slot, this patch
keeps the single pointer for custom messages, and fallback to per-thread
dlerror call for system messages. While the race condition still exists,
I think the risk is acceptable. Even when races occur, they should no
longer cause crashes.
MozReview-Commit-ID: 4hGksidjiVz
--HG--
extra : rebase_source : 373000686c426b81ffd7cee88264e89b7a733957
In this patch, implement following basic things of 'ThisFirefox' page for new
about:debugging.
* Add a pref devtools.aboutdebbugging.enabled-new to enable new about:debbugging.
* Add a function which switches new/old about:debugging page by the pref.
* Add devtools/client/aboutdebugging-new directory for new about:debugging.
* Add basic html, css, JavaScript and React component.
MozReview-Commit-ID: 5DtV7rRcS0S
--HG--
extra : rebase_source : 26496ef8273c03b78a7b8d00f44beac5f18d09ef
This introduces an event-telemetry middleware that we'll
be able to re-use for other events.
A test is added to make sure we do log those events as intended.
The telemetry mock for mocha test is modified to include
recordEvent so the test still run.
MozReview-Commit-ID: 1SHnVIRGdDz
--HG--
extra : rebase_source : 7a7d6c7ff3fdbe1da6a16bc47017dbf5d90582db
The problem was because on API >=26 the JobIntentServices used for the updater
functionality will be used by JobScheduler by binding to them.
But because they were set to run in a different process the binding was not
possible.
MozReview-Commit-ID: I8rbcoLyhyJ
--HG--
extra : rebase_source : 1bc423f6012aff6c9b0d960b046af04f32b8bd7b
PromptService will be informed when the screen is rotated and in turn it will
ask every Prompt shown to reset it's current layout.
For this, every Prompt will
- save it's current input value in PromptInput's mValue or similar field
already used for storing the default PromptInput value.
- create a new widget to be used in the new AlertDialog, with a new appropriate
layout for portrait / landscape. This is when the mValue field will be used
to initialize the new widget with the previous input.
MozReview-Commit-ID: L6eHyGNDt3d
--HG--
extra : rebase_source : ada913a8e6ada99a7d49eb47d1c64831a8f698da
This then can be used directly in the console, or passed to reps
and ObjectInspector so it can be called from there.
MozReview-Commit-ID: uQOiGuYbJK
--HG--
extra : rebase_source : a8a84b558dea69b7c2793b9e2d67a44a0809eb43
This saves about 37 KiB of memory across the UA style sheets.
MozReview-Commit-ID: EoZnlmyWwxX
--HG--
extra : rebase_source : 471fc63e521a4332bb92b4a73cd31a4bbe0b2dfe
Use adoptFd and detachFd so we don't duplicate FDs unnecessarily. Also
fix a bug where we didn't close the pref FDs.
MozReview-Commit-ID: Gugcyi4cj7V
--HG--
extra : rebase_source : 035f62d8ba4d1ec964d5b7f7556bae7164ab78b3
Unfortunately, EditorBase::SetFlags() is virtual call even though
AutoRestoreEditorState always works only with TextEditor (the method is
overridden only by HTMLEditor). And AutoRestoreEditorState is a hot path
when <input>.value or <textarea>.value is set a lot.
Fortunately, EditorBase::Flags() can be an inline method. So, we can make
both constructor and destructor of the class check if it'll change flags
actually.
Additionally, this patch fixes nsTextEditorState::PrepareEditor() too.
MozReview-Commit-ID: 7S4hLRRrbfB
--HG--
extra : rebase_source : 3c3e7438cd7e6c9853e5cf876277d7459b86c343
This is easier to understand as we don't have to round-trip the whole success and error states to the privileged wrapper which could potentially lead to stale state changes.
This is also much simpler for the basic-card-form as it doesn't need a lot of the complexity of the previous implementation.
* Move selectedStateKey from page to address-page since it doesn't apply to basic-card-page
MozReview-Commit-ID: B4kiZNWElGI
--HG--
extra : rebase_source : 183a3bd44ed33566fccdc024eabdccef83554d50
* Provide an cc-exp-year option to match cc-exp-month
* Make cc-number and cc-name required in the basic-card-form
* Disable the basic-card-page save button when the form is invalid.
MozReview-Commit-ID: LjzsnAKJp6R
--HG--
extra : rebase_source : 467fa09ea07c0234e1839b6dfd7e53375c118104
This should prevent introducing further delay when opening DevTools.
MozReview-Commit-ID: D9XDieFoU8a
--HG--
extra : rebase_source : f7a5309ed2f64ec358fee13068efd6da8acfbdd2
This is to avoid rendering for a frame or two without the menu item icons being
visible which causes flicker, particularly on lower-end machines.
MozReview-Commit-ID: Aq7AOkPwu9V
--HG--
extra : rebase_source : ee371cf848dcf39ec9f3cd9689268c3e9ef41c54
This is so that we can hook into the componentDidMount method.
MozReview-Commit-ID: 5NCDgvDPbe1
--HG--
extra : rebase_source : 3768f50b20d208f5d9bb5724194fcdc2927a873c
Mark Banner
Julian Descottes
Narcis Beleuzu
Mike Hommey
Michael Ratcliffe
Makoto Kato
Delphine Lebédel
Belén Albeza
Franziskus Kiefer
Marco Bonardo
Jim Chen
Dão Gottwald
Daisuke Akatsuka
Nicolas Chevobbe
Petru Lingurar
Mark Hammond
Brian Birtles
prathiksha
Cosmin Sabou
Cameron McCormack
Masayuki Nakano
Matthew Noorenberghe