f935ddc4b3
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
37ff4fc7cc
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
a07223d699
Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout
2017-04-14 23:39:22 +02:00
738d097aae
Backed out changeset 55f3df15eaa6 (bug 1356569)
2017-04-14 23:39:17 +02:00
3c564a2b02
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
95d4d20c17
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
bd625e4e9f
Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
...
MozReview-Commit-ID: LH0CQOPfoe6
--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
b8f991e41b
Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame
...
MozReview-Commit-ID: 5GEnL7Kihpj
--HG--
extra : rebase_source : 413d880035b49da82db0530379425d31ac31a82e
2017-02-07 12:52:03 -08:00
a9ce32d9a5
Backed out 2 changesets (bug 1335983) for build bustage a=backout
...
Backed out changeset 5a9559ded976 (bug 1335983)
Backed out changeset de2b0d90e2da (bug 1335983)
MozReview-Commit-ID: 377KQDU1QqJ
2017-02-07 12:34:30 -08:00
6d98bad59d
Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame
...
MozReview-Commit-ID: bJVrVj2dAS
--HG--
extra : rebase_source : f3a28e003415f0c58462a73b5fd987455e102fc5
2017-02-06 14:57:09 -08:00
16e6d381ac
Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
...
MozReview-Commit-ID: 62Hp5ISxowJ
--HG--
extra : rebase_source : daa8efb3409031fea553f4fd0c9d0746e38dc308
extra : histedit_source : b4c23aacf678ba0d0ac9c09191a7c494ead11a08
2017-01-18 10:30:39 +00:00
43bac26d30
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
...
MozReview-Commit-ID: 6tv0Z06CO4a
--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
692210bd80
Bug 1323100 - Assign names to all remaining threads that are created through NS_NewThread and create them using NS_NewNamedThread instead. r=froydnj
...
MozReview-Commit-ID: 7W1dt2BBKJZ
--HG--
extra : rebase_source : c7e335dac2e0f02782f0eb229a7181c8d01317a2
2016-12-21 11:43:50 +01:00
80afb72ae6
Bug 1328851 - Enable eslint rule no-undef for storage/. r=mak
...
MozReview-Commit-ID: AemgF8H2ySH
--HG--
extra : rebase_source : dcbc2210fcfc9abf0e96b38b9306fd158f9dcfed
2017-01-05 11:54:49 +00:00
9141469edf
Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
...
MozReview-Commit-ID: FuVu8skcqOe
--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
26a1ba5c14
Backed out 27 changesets (bug 1323100) for clipboard leaktest failures a=backout
...
Backed out changeset 84fb749698ab (bug 1323100)
Backed out changeset d6d25e8bd001 (bug 1323100)
Backed out changeset 1b0855bb0c38 (bug 1323100)
Backed out changeset b6953e3f5739 (bug 1323100)
Backed out changeset 5572f3b63215 (bug 1323100)
Backed out changeset 12fb4c533659 (bug 1323100)
Backed out changeset c36524e4e919 (bug 1323100)
Backed out changeset 1e3b3eddbe26 (bug 1323100)
Backed out changeset 061110f1ae12 (bug 1323100)
Backed out changeset 413dbd31725b (bug 1323100)
Backed out changeset 06550f7eca62 (bug 1323100)
Backed out changeset 940933b13b36 (bug 1323100)
Backed out changeset a6d75c1cd724 (bug 1323100)
Backed out changeset 681cacbbaa3b (bug 1323100)
Backed out changeset 3d53787293f6 (bug 1323100)
Backed out changeset c0340dfe4766 (bug 1323100)
Backed out changeset 9f554991549d (bug 1323100)
Backed out changeset 757539e7039a (bug 1323100)
Backed out changeset a3c9b45aa917 (bug 1323100)
Backed out changeset 23d69df98a66 (bug 1323100)
Backed out changeset 1297ded6a01d (bug 1323100)
Backed out changeset f4235b97257f (bug 1323100)
Backed out changeset 93419cb4f29f (bug 1323100)
Backed out changeset 865d1b81c804 (bug 1323100)
Backed out changeset 54acf4ef8e84 (bug 1323100)
Backed out changeset 88d17bcd8205 (bug 1323100)
Backed out changeset 0c466e5e8933 (bug 1323100)
2016-12-29 16:28:36 -08:00
1b72f37c98
Bug 1323100 - Assign names to all remaining threads that are created through NS_NewThread and create them using NS_NewNamedThread instead. r=froydnj
...
MozReview-Commit-ID: 7W1dt2BBKJZ
--HG--
extra : rebase_source : ad47978ef81d048a90b9803803201eee32974024
2016-12-21 11:43:50 +01:00
ecab54a7c9
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 7E7LPorrEje
--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
0dfb7c2b5c
Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
...
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
7255df4e9a
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 8WoGr8i6oCR
--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
4f94e4bd68
Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop
...
MozReview-Commit-ID: CiIsUjQzp4D
--HG--
extra : rebase_source : 1b98e88673625a52ef82c1fad5d56aec3e2e8e80
2016-11-09 22:06:32 +00:00
348bfffc19
Bug 1296189 - Replace NS_RUNTIMEABORT("some string literal message") with MOZ_CRASH(). r=froydnj
2016-12-02 13:46:53 -08:00
feef954874
Merge m-i to m-c, a=merge
...
MozReview-Commit-ID: EDVoIcyWOhi
--HG--
rename : storage/test/test_AsXXX_helpers.cpp => storage/test/gtest/test_AsXXX_helpers.cpp
rename : storage/test/test_binding_params.cpp => storage/test/gtest/test_binding_params.cpp
rename : storage/test/test_mutex.cpp => storage/test/gtest/test_mutex.cpp
2016-11-22 20:03:03 -08:00
7e1a8cf56c
Bug 1315138 - gtestify storage/test/*.cpp. r=mak,erahm.
...
This change is mostly straightforward, except for the following.
- It removes all the printing from the do_check_* macros because gtest macros
do appropriate printing.
- test_StatementCache.cpp needs some special gtest magic for the type
parameterization.
- It merges the four tests in test_unlock_notify.cpp because they rely on being
executed in order, and so aren't independent.
- storage_test_harness_tail.h is no longer necessary because gtest provides the
test looping functionality.
- It uses #include and the preprocessor to remove the duplication between
test_deadlock_detector.cpp and xpcom/tests/DeadlockDetector.cpp.
- It makes the test in test_service_init_background_thread.cpp a death test to
force it to be the first storage gtest, because it fails otherwise.
- It adds code to undo the SQLite mutex hooking as necessary, so that tests
don't interfere with each other.
- It de-virtualizes Spinner's destructor (as identified in bug 1318282).
--HG--
rename : storage/test/storage_test_harness.h => storage/test/gtest/storage_test_harness.h
rename : storage/test/test_AsXXX_helpers.cpp => storage/test/gtest/test_AsXXX_helpers.cpp
rename : storage/test/test_StatementCache.cpp => storage/test/gtest/test_StatementCache.cpp
rename : storage/test/test_asyncStatementExecution_transaction.cpp => storage/test/gtest/test_asyncStatementExecution_transaction.cpp
rename : storage/test/test_async_callbacks_with_spun_event_loops.cpp => storage/test/gtest/test_async_callbacks_with_spun_event_loops.cpp
rename : storage/test/test_binding_params.cpp => storage/test/gtest/test_binding_params.cpp
rename : storage/test/test_deadlock_detector.cpp => storage/test/gtest/test_deadlock_detector.cpp
rename : storage/test/test_file_perms.cpp => storage/test/gtest/test_file_perms.cpp
rename : storage/test/test_mutex.cpp => storage/test/gtest/test_mutex.cpp
rename : storage/test/test_service_init_background_thread.cpp => storage/test/gtest/test_service_init_background_thread.cpp
rename : storage/test/test_statement_scoper.cpp => storage/test/gtest/test_statement_scoper.cpp
rename : storage/test/test_transaction_helper.cpp => storage/test/gtest/test_transaction_helper.cpp
rename : storage/test/test_true_async.cpp => storage/test/gtest/test_true_async.cpp
rename : storage/test/test_unlock_notify.cpp => storage/test/gtest/test_unlock_notify.cpp
extra : rebase_source : dbb695c112564efa1945116be1a8435988982e74
2016-11-11 09:59:23 +11:00
64312a6104
Bug 1318282 - Use C++11's override and remove virtual where applicable in storage/. r=mak
...
MozReview-Commit-ID: AXchuOpF65X
--HG--
extra : rebase_source : 47536d5918bdb66cd467a1c31ca6545817e922d3
2016-11-17 12:36:25 +02:00
7f5f07c638
Bug 1318282 - Replace string literals containing escaped characters with raw string literals in storage/. r=mak
...
MozReview-Commit-ID: 7iVr1Ug0Oot
--HG--
extra : rebase_source : 7590b2f78454d2497dcc7f9c4275e463a2fe6c81
2016-11-17 12:35:02 +02:00
e874c4bda7
Bug 1318282 - Replace default bodies of special member functions with = default; in storage/. r=mak
...
MozReview-Commit-ID: DLgi8Oa7X2b
--HG--
extra : rebase_source : b18f05c361469d5d276c8a80b371aa001ec58cd4
2016-11-17 12:34:23 +02:00
a71b3f4e14
Bug 1318282 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in storage/. r=mak
...
MozReview-Commit-ID: HuudUDUcQYu
--HG--
extra : rebase_source : 2b7591b118fea1e0a1b42ae929106191e2b2e1f6
2016-11-17 12:33:18 +02:00
8de07a19a0
Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
...
MozReview-Commit-ID: 2ZvTiZDHchz
--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
f8c9d72cfd
Bug 1310297 - Remove test annotations using b2g, mulet or gonk: storage. r=RyanVM
...
MozReview-Commit-ID: D3QcehYvTpx
--HG--
extra : rebase_source : 842c9bd007676e1d760eaca67e3eb30cb751d5de
2016-11-05 11:29:21 +01:00
100acd6188
Bug 1313309 - Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE. r=asuth
...
MozReview-Commit-ID: 2QR8P7ylg9m
--HG--
extra : rebase_source : 37ed75d0cf724a6c373df6d12df1f36fddc0a646
2016-11-03 21:04:00 +01:00
87b2d4c295
Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
...
MozReview-Commit-ID: HIUTSdkXxbY
--HG--
extra : rebase_source : 2f05e2f275ac7f293f9c650bdec8943189e3ce01
2016-11-03 14:42:06 -04:00
792726a2c3
Bug 1310152 - AsyncClone may try to reuse a freed Critical Section in Sqlite. r=asuth
...
MozReview-Commit-ID: LW0esWlNfQQ
--HG--
extra : rebase_source : 59e2510a9d4c2343dcde91a572a3d354a15c162f
2016-11-03 15:31:31 +01:00
5040f17e00
Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
...
MozReview-Commit-ID: 7Gx90a5y8t6
--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
ae4301ef96
Bug 1285041 - ignore locking when trying to read chrome DB file, r=mak
...
MozReview-Commit-ID: 89f0YCxxgC8
--HG--
extra : rebase_source : 53efa0f0258728df54fc17a773cbf74c712b51e4
2016-07-18 16:46:45 +01:00
e7f10a07fd
Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
...
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.
As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
2016-08-08 12:18:10 +10:00
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
67abb05afa
Bug 1287739: Always set 'len' variable in storage test, r=mak
...
MozReview-Commit-ID: 8EpGeakICWY
2016-07-20 16:12:31 +02:00
949197fdb7
Bug 1283083 - Cloning a connection should re-attach databases to the clone. r=asuth
...
MozReview-Commit-ID: CSZqvJNWthB
--HG--
extra : rebase_source : 9213a9e73052e7d87cf12c64af2ad1a15496ace1
2016-06-29 17:33:15 +02:00
477adfcd7e
Bug 1271514: clean up threads in test_unlock_notify r=froydnj
...
MozReview-Commit-ID: EbCnWFzLMca
2016-05-11 00:09:53 -04:00
c73656947b
Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj
2016-04-25 17:23:21 -07:00
f139fb05d8
Bug 1230685 - Replace function declarations with add_task statements in test_storage_value_array.js and test_unicode.js. r=mak
...
--HG--
extra : commitid : GaYkxxYU4Yj
2016-02-10 15:30:34 +01:00
1a2bff1271
Bug 1230683 - Replace try/catch with Assert.throws in test_storage_connection.js. r=mak
...
--HG--
extra : commitid : CevJdrYql4m
2016-02-10 15:30:28 +01:00
0a6414b898
Bug 1245649: Turn on no-trailing-spaces. r=Gijs
...
--HG--
extra : commitid : F2OWKTvXUO4
extra : rebase_source : ec68631342e0edc59d77b6bab1cdc975ad175327
2016-02-03 14:22:33 -08:00
c601fe0a05
Bug 555087 - Add check for exception when passing undefined parameter. r=adw
2016-01-20 16:37:00 +01:00
9b1de02e15
Bug 1239354: Replace old-style generator function with star functions. r=asuth
...
--HG--
extra : rebase_source : e932378aaf2d08a1ff3b096cdb5770c139c93979
2016-01-13 08:58:15 -08:00
debfaf45f7
Bug 1237601 - Perform storage close synchronously if async thread cannot be started. r=bkelly
...
Also factors asyncClose tests out into their own file.
2016-01-07 11:18:00 -05:00
896d9d7315
Bug 1237601 - Centralize storage xpcshell promise helpers (support patch). r=bkelly
2016-01-12 17:27:33 -05:00
1006b4755f
Bug 1230549 - Storage should pass more eslint rules. r=yoric
...
--HG--
extra : commitid : 9FE8bR3AhsJ
extra : rebase_source : 1d65cc419e9375facb1dc7265e05ee84195153e7
2015-12-04 17:00:03 +01:00
4190a83115
Bug 1230549 - Make Storage pass basic eslint. r=yoric
...
--HG--
rename : browser/.eslintrc => storage/.eslintrc
extra : commitid : 5RiWGmPFkg2
extra : rebase_source : 54b8a2e9680c37d88c0a501d85422163f4e04fea
2015-12-04 15:52:43 +01:00
Florian Queze
Sebastian Hengst
Mark Banner
Zibi Braniecki
Wes Kocher
Jared Wein
Markus Stange
Tomislav Jurin
Phil Ringnalda
Nicholas Nethercote
Andi-Bogdan Postelnicu
Dave Townsend
Marco Bonardo
Gijs Kruitbosch
Tom Tromey
Thomas Zimmermann
Randell Jesup
Kyle Huey
Jeffrey Tran
Andrew Sutherland