Граф коммитов

228 Коммитов

Автор SHA1 Сообщение Дата
David Parks 90be6e1a12 Bug 1675349: Update tests under dom/plugins/test for the removal of plugins. r=jmathies
ADDED/UPDATED
-------
dom/plugins/test/mochitest/browser_blockallplugins.js
Make sure that all plugin elements use the fallback for removed plugins.

dom/plugins/test/mochitest/test_mixed_case_mime.html
Bug 206659
Test MIME-type case sensitivity using "application/x-Second-Test"
Change to test "image/png".

dom/plugins/test/mochitest/test_plugin_fallback_focus.html
Test that (denying) object/embed focus and focusability are properly maintained when those elements change type to/from plugins.

REMOVED
-------
dom/plugins/test/unit/test_nice_plugin_name.js
bug 838290
Plugin permission string is "nicely" based on plugin lib name.

dom/plugins/test/unit/test_bug471245.js
bug 471245
Something to do with disabled plugins being enabled under some weird condition.

dom/plugins/test/unit/test_bug813245.js
bug 813245
Plugin registry file doesn't cause crash or incorrectly represent real plugin.

dom/plugins/test/unit/test_bug854467.js
bug 854467
PluginTag correctly controls click-to-play behavior.

dom/plugins/test/unit/test_plugin_default_state.js
bug 866390
Click-to-play abides plugin.default.state setting.

dom/plugins/test/unit/test_persist_in_prefs.js
Bug 830267
CTP state is maintained in settings (not pluginreg.dat) and persists regardless of plugin removal

dom/plugins/test/mochitest/test_NPNVdocumentOrigin.html
Bug 622199
Test NPNV connection to DOM properly handles documentOrigin.

dom/plugins/test/mochitest/test_NPPVpluginWantsAllNetworkStreams.html
Test NPPV connection to JS when plugin requests all HTTP stream <body>s (including failed requests)

dom/plugins/test/mochitest/test_bug1028200-*.html
Properly handle fullscreen wrt plugins doing things (like crashing)

dom/plugins/test/unit/test_bug471245.js
Bug 471245
Extensions should not enable inadvertently enable plugins when they consult PluginHost.

dom/plugins/test/unit/test_bug813245.js
Bug 813245
Do not crash when we read a corrupt pluginreg.dat

dom/plugins/test/unit/test_bug854467.js
Bug 854467
Should be able to unset CTP setting in chrome JS.

dom/plugins/test/unit/test_nice_plugin_name.js
Bug 838290
Permission string names for plugins should be pretty and not just based on plugin filename.

dom/plugins/test/unit/test_persist_in_prefs.js
Bug 830267
Persist plugin prefs in user prefs, not pluginreg.dat

dom/plugins/test/unit/test_plugin_default_state.js
Bug 866390
Plugins that use default CTP state should follow changes to the default.  Others should not be affected by changes.

dom/plugins/test/mochitest/test_bug1092842.html
bug 1092842
Plugin clipping around specific HTML element attributes.

dom/plugins/test/mochitest/test_bug1165981.html
bug 1165981
Test non-Flash plugins are blocked

dom/plugins/test/mochitest/test_bug1245545.html
bug 1245545
Test unloading plugins based on `dom.ipc.plugins.unloadTimeoutSecs`

dom/plugins/test/mochitest/test_bug1307694.html
bug 1307694
Test scale and salign attributes musst be processed in an order dependent way.  But salign is no longer supported.  The test uses special testplugin behavior.

dom/plugins/test/mochitest/test_bug532208.html
bug 532208
Test that plugins can handle large streams, using special testplugin behavior.

dom/plugins/test/mochitest/test_bug539565-1.html
dom/plugins/test/mochitest/test_bug539565-2.html
bug 539565
Plugins should get proper mouse coords in the face of CSS transformations

dom/plugins/test/mochitest/test_bug771202.html
bug 771202
Use JS-exported plugin functions after plugin is moved to a subdocument.

dom/plugins/test/mochitest/test_bug777098.html
bug 777098
Test that plugin is properly deleted and a JS exception is thrown when an invalid NPObject (from a dead instance) is passed to a plugin.

dom/plugins/test/mochitest/test_bug784131.html
bug 784131
Plugins should properly stop when they lose their frames (via e.g. `display:none`)

dom/plugins/test/mochitest/test_bug813906.html
bug 813906
Make sure plugins can't access chrome-privileged pages

dom/plugins/test/mochitest/test_bug852315.html
bug 852315
Tests a specific case where JS code that added an element in response to an <embed> event handler would alter a hash table in the midst of iteration, causing a crash.

dom/plugins/test/mochitest/test_bug854082.html
bug 854082
Tests that destroying the plugin's frame inside NPP_New does not cause a crash

dom/plugins/test/mochitest/test_bug863792.htm
bug 863792
Do not leak when a plugin removes itself from the document and inactivates the document in its NPP_New

dom/plugins/test/mochitest/test_bug967694.html
bug 967694
CTP dialog should not spawn plugin inside CTP dialog event.

dom/plugins/test/mochitest/test_bug985859.html
bug 985859
navigator.mimetypes should work as case-insensitive hashmap (there don't seem to be any legal mimetypes left now).

dom/plugins/test/mochitest/test_bug986930.html
bug 986930
Properly handle plugin with non-ASCII mime type.

dom/plugins/test/mochitest/test_copyText.html
Plugins should be able to use the clipboard.

dom/plugins/test/mochitest/test_crash_nested_loop.html
Plugins resulting in a call to PluginCrashed while still on the stack causing a browser crash (non-oop plugins).  So this is ancient (11 years).

dom/plugins/test/mochitest/test_crashing.html
Bug 560213
Test that plugin crashes generate exceptions and do not lead to heap corruption when using JS to call methods on the crashed plugin.

dom/plugins/test/mochitest/test_CrashService_crash.html
dom/plugins/test/mochitest/test_CrashService_hang.html
dom/plugins/test/mochitest/test_x11_error_crash.html
Bug 983313 and bug 1331320
Check that CrashService (which is currently only used by plugin tests) properly detects plugin crash, hang and crashes from X11 errors.

dom/plugins/test/mochitest/test_crashing2.html
Reloading should restore crashed plugin.  Test was already completely disabled.

dom/plugins/test/mochitest/test_defaultValue.html
Bug 679509
Make NPObjects ok to use as a primitve [[DefaultValue]], instead of calling valueOf on the NPObject itself.

dom/plugins/test/mochitest/test_bug751809.html
Bug 751809
Plugin CTP broke plugin input (ancient).

dom/plugins/test/mochitest/browser_bug1335475.js
bug 1335475
Test that plugins aren't available in chrome-privilege, null-principal, and file:// content but are available to http:// and about:blank content

dom/plugins/test/mochitest/browser_data_url_plugin.js
Bug 1381755
Test that data URIs inside iframes can't use plugins

dom/plugins/test/mochitest/browser_bug1196539.js
Test that plugin repaints when it should (and not more than that, modulo OS repaints)

dom/plugins/test/mochitest/test_hidden_plugin.html
Test navigator.plugins, including that disabling plugins removes them from navigator.plugins

dom/plugins/test/mochitest/test_enumerate.html
Test PluginHost's ability to expose plugin's JS API (looks for TestPlugin's SetColor)

dom/plugins/test/mochitest/test_clear_site_data.html
Directly test PluginHost's clearSiteData API.

dom/plugins/test/mochitest/test_instance_re-parent.html
Bug 90268
Test that reparenting plugin instance in DOM before spinning event loop does not destroy or restart it.

dom/plugins/test/mochitest/test_instance_unparent1.html
dom/plugins/test/mochitest/test_instance_unparent2.html
dom/plugins/test/mochitest/test_instance_unparent3.html
Bug 90268
Test that removing plugin from DOM destroys it (1) normally, (2) if reparented and removed in the same event cycle and (3) when its parent is the element that gets removed.

dom/plugins/test/mochitest/test_instantiation.html
Create that plugin is loaded when element is programmatically created (using createElement).

dom/plugins/test/mochitest/test_multipleinstanceobjects.html
Test NPObject access from multiple plugin instances

dom/plugins/test/mochitest/test_newstreamondestroy.html
Test calling NPN_GetURL from NPP_Destroy

dom/plugins/test/mochitest/test_npn_timers.html
Test NPN_Timer

dom/plugins/test/mochitest/test_npobject_getters.html
Test `pluginFoundElement` and `pluginFoundWindow` JS properties set on plugin instance by `NPP_New`.

dom/plugins/test/mochitest/test_npruntime_construct.html
Test that NP plugin JS method `constructObject` properly configures prototype chain

dom/plugins/test/mochitest/test_npruntime_identifiers.html
Test various ways the plugin JS reflection method can convert "identifiers" to JS values.

dom/plugins/test/mochitest/test_npruntime_npnevaluate.html
Test NPN_Evaluate (i.e. plugin executing JS code)

dom/plugins/test/mochitest/test_npruntime_npninvoke.html
Test NPN_Invoke (i.e. plugin calling JS method)

dom/plugins/test/mochitest/test_npruntime_npninvokedefault.html
Test NPN_InvokeDefault (i.e. plugin calling default JS method)

dom/plugins/test/mochitest/test_painting.html
Test invalidation and repaint requests for clipped plugins.

dom/plugins/test/mochitest/test_pluginstream_err.html
Bug 517078
Test that plugin streaming error reporting works

dom/plugins/test/mochitest/test_pluginstream_post.html
dom/plugins/test/mochitest/test_pluginstream_poststream.html
Test NPN_PostURL responds (1) by inserting response into given element or (2) by sending response to plugin with NPN_NewStream.

dom/plugins/test/mochitest/test_bug479979.xhtml
Bug 479979
NPN_SetValue should return error for unknown variables.

dom/plugins/test/mochitest/test_crash_notify.xhtml
dom/plugins/test/mochitest/test_crash_notify_no_report.xhtml
Check event data, crash report/minidump (or not using MOZ_CRASHREPORTER_NO_REPORT), etc for `plugin-crash` event.

dom/plugins/test/mochitest/test_crash_submit.xhtml
dom/plugins/test/mochitest/test_hang_submit.xhtml
Test plugin crash/hang report submission using mock server from toolkit.

dom/plugins/test/mochitest/test_pluginstream_referer.html
Bugs 410904 and 724465
Test NPN_PostURLNotify and NPN_GetURLNotify.

dom/plugins/test/mochitest/test_pluginstream_src.html
Test NPP_NewStream and NPP_DestroyStream using embed tag streammode/streamchunksize parameters.

dom/plugins/test/mochitest/test_pluginstream_src_dynamic.html
Bug 90268
Like test_pluginstream_src.html but using dynamic HTML elements.

dom/plugins/test/mochitest/test_pluginstream_src_referer.html
Bug 737433
Make sure plugin stream data includes the correct referrer (taken from its content)

dom/plugins/test/mochitest/test_propertyAndMethod.html
Test NPObject with property and method with the same name

dom/plugins/test/mochitest/test_queryCSSZoomFactor.htm
Bug 1171182
Test CSS zoom with plugins (handled with NPNVcontentsScaleFactor)

dom/plugins/test/mochitest/test_redirect_handling.html
Test NPN_PostURLNotify and NPN_GetURLNotify URL redirect support.

dom/plugins/test/mochitest/test_secondPlugin.html
Bug 749257
Test navigator.plugins and navigator.mimeTypes (via index and iteration) for proper behavior WRT active, CTP and disabled plugins.

dom/plugins/test/mochitest/test_src_url_change.html
Bug 726734
Changing embed src tag should destroy/restart plugin.

dom/plugins/test/mochitest/test_streamNotify.html
Test that plugin streams properly handle all URLs, including proper errors for malformed URLs.

dom/plugins/test/mochitest/test_streamatclose.html
Any open streams should be notified before NPP_Destroy.

dom/plugins/test/mochitest/test_stringHandling.html
Bug 1106552
Properly handle 0 bytes in strings passed to plugins as NPVariants.

dom/plugins/test/mochitest/test_visibility.html
Make sure plugins respect visibility attribute and issue the correct number of paints.

dom/plugins/test/mochitest/test_zero_opacity.html
Windowed plugins should use clip rect to avoid drawing opacity:0 displays.

dom/plugins/test/mochitest/test_cocoa_window_focus.htm
Test that NPCocoaEventWindowFocusChanged is properly sent for plugin's window

dom/plugins/test/mochitest/test_cocoa_focus.htm
Test that NPCocoaEventFocusChanged is properly sent for plugin's element

dom/plugins/test/mochitest/test_windowed_invalidate.html
Test NPN_Invalidate for windowed plugins

dom/plugins/test/mochitest/test_windowless_flash.htm
Make sure Flash always runs in windowless mode

dom/plugins/test/mochitest/test_windowless_ime.html
Test (windowless) plugins with IME

dom/plugins/test/mochitest/test_busy_hang.xhtml
dom/plugins/test/mochitest/test_idle_hang.xhtml
Test plugin busy/idle detection observers and events

dom/plugins/test/mochitest/test_object.html
Bug 783059
Test plugin "instantiation", mostly by stressing behavior when the plugin's element tags are programmatically updated.

dom/plugins/test/mochitest/test_convertpoint.xhtml
Test coordinate space transformations via NPN_ConvertPoint.

dom/plugins/test/mochitest/test_hangui.xhtml
Test the _plugin hung_ UI.

dom/plugins/test/mochitest/test_npruntime.xhtml
Simple test that npruntime (the JS/plugin bridge) works.

dom/plugins/test/mochitest/test_plugin_tag_clicktoplay.html
Make sure nsIPluginTags click-to-play state properly matches enabledState of plugin (in chrome code)

dom/plugins/test/mochitest/test_privatemode_perwindowpb.xhtml
Check that plugins can properly determine when run in private mode with NPNVprivateModeBool.

dom/plugins/test/mochitest/test_wmode.xhtml
Bad test that ends up checking the constant boolean in testplugin returned by pluginSupportsWindowMode() and "confirming" that mac and Linux don't support windowed mode but Windows does.

dom/plugins/test/mochitest/test_xulbrowser_plugin_visibility.xhtml
Tests that plugins properly get visibility and invalidate messages when in the current or not-current tab.

Differential Revision: https://phabricator.services.mozilla.com/D95910
2020-11-18 15:58:15 +00:00
Bogdan Tara 56346a0425 Backed out 19 changesets (bug 1675349) for lint failures on browser_ext_browsingData_pluginData and test_archive CLOSED TREE
Backed out changeset 244e0f2b410c (bug 1675349)
Backed out changeset ba5724069dd4 (bug 1675349)
Backed out changeset 37fca259c7e9 (bug 1675349)
Backed out changeset f2b16caca1fc (bug 1675349)
Backed out changeset 28835d4935be (bug 1675349)
Backed out changeset eb913f58953a (bug 1675349)
Backed out changeset 19e3cb80f469 (bug 1675349)
Backed out changeset d9723f3a3a7e (bug 1675349)
Backed out changeset c888dfcdf70e (bug 1675349)
Backed out changeset 48f153341af6 (bug 1675349)
Backed out changeset 7fc67a9b2932 (bug 1675349)
Backed out changeset 1cee4d97f801 (bug 1675349)
Backed out changeset 59a0cb79c7c1 (bug 1675349)
Backed out changeset 43d349fa37b1 (bug 1675349)
Backed out changeset c84bfb6eae59 (bug 1675349)
Backed out changeset 38e9af69ae57 (bug 1675349)
Backed out changeset 3255c1ab3059 (bug 1675349)
Backed out changeset 2f3eaf9c342c (bug 1675349)
Backed out changeset 769e5c0db4c2 (bug 1675349)
2020-11-18 06:06:36 +02:00
David Parks 22d4a17ff8 Bug 1675349: Update tests under dom/plugins/test for the removal of plugins. r=jmathies
ADDED/UPDATED
-------
dom/plugins/test/mochitest/browser_blockallplugins.js
Make sure that all plugin elements use the fallback for removed plugins.

dom/plugins/test/mochitest/test_mixed_case_mime.html
Bug 206659
Test MIME-type case sensitivity using "application/x-Second-Test"
Change to test "image/png".

dom/plugins/test/mochitest/test_plugin_fallback_focus.html
Test that (denying) object/embed focus and focusability are properly maintained when those elements change type to/from plugins.

REMOVED
-------
dom/plugins/test/unit/test_nice_plugin_name.js
bug 838290
Plugin permission string is "nicely" based on plugin lib name.

dom/plugins/test/unit/test_bug471245.js
bug 471245
Something to do with disabled plugins being enabled under some weird condition.

dom/plugins/test/unit/test_bug813245.js
bug 813245
Plugin registry file doesn't cause crash or incorrectly represent real plugin.

dom/plugins/test/unit/test_bug854467.js
bug 854467
PluginTag correctly controls click-to-play behavior.

dom/plugins/test/unit/test_plugin_default_state.js
bug 866390
Click-to-play abides plugin.default.state setting.

dom/plugins/test/unit/test_persist_in_prefs.js
Bug 830267
CTP state is maintained in settings (not pluginreg.dat) and persists regardless of plugin removal

dom/plugins/test/mochitest/test_NPNVdocumentOrigin.html
Bug 622199
Test NPNV connection to DOM properly handles documentOrigin.

dom/plugins/test/mochitest/test_NPPVpluginWantsAllNetworkStreams.html
Test NPPV connection to JS when plugin requests all HTTP stream <body>s (including failed requests)

dom/plugins/test/mochitest/test_bug1028200-*.html
Properly handle fullscreen wrt plugins doing things (like crashing)

dom/plugins/test/unit/test_bug471245.js
Bug 471245
Extensions should not enable inadvertently enable plugins when they consult PluginHost.

dom/plugins/test/unit/test_bug813245.js
Bug 813245
Do not crash when we read a corrupt pluginreg.dat

dom/plugins/test/unit/test_bug854467.js
Bug 854467
Should be able to unset CTP setting in chrome JS.

dom/plugins/test/unit/test_nice_plugin_name.js
Bug 838290
Permission string names for plugins should be pretty and not just based on plugin filename.

dom/plugins/test/unit/test_persist_in_prefs.js
Bug 830267
Persist plugin prefs in user prefs, not pluginreg.dat

dom/plugins/test/unit/test_plugin_default_state.js
Bug 866390
Plugins that use default CTP state should follow changes to the default.  Others should not be affected by changes.

dom/plugins/test/mochitest/test_bug1092842.html
bug 1092842
Plugin clipping around specific HTML element attributes.

dom/plugins/test/mochitest/test_bug1165981.html
bug 1165981
Test non-Flash plugins are blocked

dom/plugins/test/mochitest/test_bug1245545.html
bug 1245545
Test unloading plugins based on `dom.ipc.plugins.unloadTimeoutSecs`

dom/plugins/test/mochitest/test_bug1307694.html
bug 1307694
Test scale and salign attributes musst be processed in an order dependent way.  But salign is no longer supported.  The test uses special testplugin behavior.

dom/plugins/test/mochitest/test_bug532208.html
bug 532208
Test that plugins can handle large streams, using special testplugin behavior.

dom/plugins/test/mochitest/test_bug539565-1.html
dom/plugins/test/mochitest/test_bug539565-2.html
bug 539565
Plugins should get proper mouse coords in the face of CSS transformations

dom/plugins/test/mochitest/test_bug771202.html
bug 771202
Use JS-exported plugin functions after plugin is moved to a subdocument.

dom/plugins/test/mochitest/test_bug777098.html
bug 777098
Test that plugin is properly deleted and a JS exception is thrown when an invalid NPObject (from a dead instance) is passed to a plugin.

dom/plugins/test/mochitest/test_bug784131.html
bug 784131
Plugins should properly stop when they lose their frames (via e.g. `display:none`)

dom/plugins/test/mochitest/test_bug813906.html
bug 813906
Make sure plugins can't access chrome-privileged pages

dom/plugins/test/mochitest/test_bug852315.html
bug 852315
Tests a specific case where JS code that added an element in response to an <embed> event handler would alter a hash table in the midst of iteration, causing a crash.

dom/plugins/test/mochitest/test_bug854082.html
bug 854082
Tests that destroying the plugin's frame inside NPP_New does not cause a crash

dom/plugins/test/mochitest/test_bug863792.htm
bug 863792
Do not leak when a plugin removes itself from the document and inactivates the document in its NPP_New

dom/plugins/test/mochitest/test_bug967694.html
bug 967694
CTP dialog should not spawn plugin inside CTP dialog event.

dom/plugins/test/mochitest/test_bug985859.html
bug 985859
navigator.mimetypes should work as case-insensitive hashmap (there don't seem to be any legal mimetypes left now).

dom/plugins/test/mochitest/test_bug986930.html
bug 986930
Properly handle plugin with non-ASCII mime type.

dom/plugins/test/mochitest/test_copyText.html
Plugins should be able to use the clipboard.

dom/plugins/test/mochitest/test_crash_nested_loop.html
Plugins resulting in a call to PluginCrashed while still on the stack causing a browser crash (non-oop plugins).  So this is ancient (11 years).

dom/plugins/test/mochitest/test_crashing.html
Bug 560213
Test that plugin crashes generate exceptions and do not lead to heap corruption when using JS to call methods on the crashed plugin.

dom/plugins/test/mochitest/test_CrashService_crash.html
dom/plugins/test/mochitest/test_CrashService_hang.html
dom/plugins/test/mochitest/test_x11_error_crash.html
Bug 983313 and bug 1331320
Check that CrashService (which is currently only used by plugin tests) properly detects plugin crash, hang and crashes from X11 errors.

dom/plugins/test/mochitest/test_crashing2.html
Reloading should restore crashed plugin.  Test was already completely disabled.

dom/plugins/test/mochitest/test_defaultValue.html
Bug 679509
Make NPObjects ok to use as a primitve [[DefaultValue]], instead of calling valueOf on the NPObject itself.

dom/plugins/test/mochitest/test_bug751809.html
Bug 751809
Plugin CTP broke plugin input (ancient).

dom/plugins/test/mochitest/browser_bug1335475.js
bug 1335475
Test that plugins aren't available in chrome-privilege, null-principal, and file:// content but are available to http:// and about:blank content

dom/plugins/test/mochitest/browser_data_url_plugin.js
Bug 1381755
Test that data URIs inside iframes can't use plugins

dom/plugins/test/mochitest/browser_bug1196539.js
Test that plugin repaints when it should (and not more than that, modulo OS repaints)

dom/plugins/test/mochitest/test_hidden_plugin.html
Test navigator.plugins, including that disabling plugins removes them from navigator.plugins

dom/plugins/test/mochitest/test_enumerate.html
Test PluginHost's ability to expose plugin's JS API (looks for TestPlugin's SetColor)

dom/plugins/test/mochitest/test_clear_site_data.html
Directly test PluginHost's clearSiteData API.

dom/plugins/test/mochitest/test_instance_re-parent.html
Bug 90268
Test that reparenting plugin instance in DOM before spinning event loop does not destroy or restart it.

dom/plugins/test/mochitest/test_instance_unparent1.html
dom/plugins/test/mochitest/test_instance_unparent2.html
dom/plugins/test/mochitest/test_instance_unparent3.html
Bug 90268
Test that removing plugin from DOM destroys it (1) normally, (2) if reparented and removed in the same event cycle and (3) when its parent is the element that gets removed.

dom/plugins/test/mochitest/test_instantiation.html
Create that plugin is loaded when element is programmatically created (using createElement).

dom/plugins/test/mochitest/test_multipleinstanceobjects.html
Test NPObject access from multiple plugin instances

dom/plugins/test/mochitest/test_newstreamondestroy.html
Test calling NPN_GetURL from NPP_Destroy

dom/plugins/test/mochitest/test_npn_timers.html
Test NPN_Timer

dom/plugins/test/mochitest/test_npobject_getters.html
Test `pluginFoundElement` and `pluginFoundWindow` JS properties set on plugin instance by `NPP_New`.

dom/plugins/test/mochitest/test_npruntime_construct.html
Test that NP plugin JS method `constructObject` properly configures prototype chain

dom/plugins/test/mochitest/test_npruntime_identifiers.html
Test various ways the plugin JS reflection method can convert "identifiers" to JS values.

dom/plugins/test/mochitest/test_npruntime_npnevaluate.html
Test NPN_Evaluate (i.e. plugin executing JS code)

dom/plugins/test/mochitest/test_npruntime_npninvoke.html
Test NPN_Invoke (i.e. plugin calling JS method)

dom/plugins/test/mochitest/test_npruntime_npninvokedefault.html
Test NPN_InvokeDefault (i.e. plugin calling default JS method)

dom/plugins/test/mochitest/test_painting.html
Test invalidation and repaint requests for clipped plugins.

dom/plugins/test/mochitest/test_pluginstream_err.html
Bug 517078
Test that plugin streaming error reporting works

dom/plugins/test/mochitest/test_pluginstream_post.html
dom/plugins/test/mochitest/test_pluginstream_poststream.html
Test NPN_PostURL responds (1) by inserting response into given element or (2) by sending response to plugin with NPN_NewStream.

dom/plugins/test/mochitest/test_bug479979.xhtml
Bug 479979
NPN_SetValue should return error for unknown variables.

dom/plugins/test/mochitest/test_crash_notify.xhtml
dom/plugins/test/mochitest/test_crash_notify_no_report.xhtml
Check event data, crash report/minidump (or not using MOZ_CRASHREPORTER_NO_REPORT), etc for `plugin-crash` event.

dom/plugins/test/mochitest/test_crash_submit.xhtml
dom/plugins/test/mochitest/test_hang_submit.xhtml
Test plugin crash/hang report submission using mock server from toolkit.

dom/plugins/test/mochitest/test_pluginstream_referer.html
Bugs 410904 and 724465
Test NPN_PostURLNotify and NPN_GetURLNotify.

dom/plugins/test/mochitest/test_pluginstream_src.html
Test NPP_NewStream and NPP_DestroyStream using embed tag streammode/streamchunksize parameters.

dom/plugins/test/mochitest/test_pluginstream_src_dynamic.html
Bug 90268
Like test_pluginstream_src.html but using dynamic HTML elements.

dom/plugins/test/mochitest/test_pluginstream_src_referer.html
Bug 737433
Make sure plugin stream data includes the correct referrer (taken from its content)

dom/plugins/test/mochitest/test_propertyAndMethod.html
Test NPObject with property and method with the same name

dom/plugins/test/mochitest/test_queryCSSZoomFactor.htm
Bug 1171182
Test CSS zoom with plugins (handled with NPNVcontentsScaleFactor)

dom/plugins/test/mochitest/test_redirect_handling.html
Test NPN_PostURLNotify and NPN_GetURLNotify URL redirect support.

dom/plugins/test/mochitest/test_secondPlugin.html
Bug 749257
Test navigator.plugins and navigator.mimeTypes (via index and iteration) for proper behavior WRT active, CTP and disabled plugins.

dom/plugins/test/mochitest/test_src_url_change.html
Bug 726734
Changing embed src tag should destroy/restart plugin.

dom/plugins/test/mochitest/test_streamNotify.html
Test that plugin streams properly handle all URLs, including proper errors for malformed URLs.

dom/plugins/test/mochitest/test_streamatclose.html
Any open streams should be notified before NPP_Destroy.

dom/plugins/test/mochitest/test_stringHandling.html
Bug 1106552
Properly handle 0 bytes in strings passed to plugins as NPVariants.

dom/plugins/test/mochitest/test_visibility.html
Make sure plugins respect visibility attribute and issue the correct number of paints.

dom/plugins/test/mochitest/test_zero_opacity.html
Windowed plugins should use clip rect to avoid drawing opacity:0 displays.

dom/plugins/test/mochitest/test_cocoa_window_focus.htm
Test that NPCocoaEventWindowFocusChanged is properly sent for plugin's window

dom/plugins/test/mochitest/test_cocoa_focus.htm
Test that NPCocoaEventFocusChanged is properly sent for plugin's element

dom/plugins/test/mochitest/test_windowed_invalidate.html
Test NPN_Invalidate for windowed plugins

dom/plugins/test/mochitest/test_windowless_flash.htm
Make sure Flash always runs in windowless mode

dom/plugins/test/mochitest/test_windowless_ime.html
Test (windowless) plugins with IME

dom/plugins/test/mochitest/test_busy_hang.xhtml
dom/plugins/test/mochitest/test_idle_hang.xhtml
Test plugin busy/idle detection observers and events

dom/plugins/test/mochitest/test_object.html
Bug 783059
Test plugin "instantiation", mostly by stressing behavior when the plugin's element tags are programmatically updated.

dom/plugins/test/mochitest/test_convertpoint.xhtml
Test coordinate space transformations via NPN_ConvertPoint.

dom/plugins/test/mochitest/test_hangui.xhtml
Test the _plugin hung_ UI.

dom/plugins/test/mochitest/test_npruntime.xhtml
Simple test that npruntime (the JS/plugin bridge) works.

dom/plugins/test/mochitest/test_plugin_tag_clicktoplay.html
Make sure nsIPluginTags click-to-play state properly matches enabledState of plugin (in chrome code)

dom/plugins/test/mochitest/test_privatemode_perwindowpb.xhtml
Check that plugins can properly determine when run in private mode with NPNVprivateModeBool.

dom/plugins/test/mochitest/test_wmode.xhtml
Bad test that ends up checking the constant boolean in testplugin returned by pluginSupportsWindowMode() and "confirming" that mac and Linux don't support windowed mode but Windows does.

dom/plugins/test/mochitest/test_xulbrowser_plugin_visibility.xhtml
Tests that plugins properly get visibility and invalidate messages when in the current or not-current tab.

Differential Revision: https://phabricator.services.mozilla.com/D95910
2020-11-18 02:45:23 +00:00
Sonia Singla f7195cd8ae Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D86485
2020-10-26 17:37:26 +00:00
Mark Banner 77e1109e9e Bug 699844 - Remove the live bookmark migrator as it is not needed now. r=mak,markh
Differential Revision: https://phabricator.services.mozilla.com/D93314
2020-10-26 12:32:52 +00:00
Michael Froman 5a2b0cb207 Bug 1665713 - pt3 - fix js lint issues resulting from moving mochitest directory. r=ng
This was originally excepted under dom/media/tests/** here:
https://searchfox.org/mozilla-central/rev/89d33e1c3b0a57a9377b4815c2f4b58d933b7c32/.eslintrc.js#235

I'm adding the exception for dom/media/webrtc/tests/** for the moved files.

Differential Revision: https://phabricator.services.mozilla.com/D91344
2020-10-02 16:29:35 +00:00
Razvan Maries 887634a649 Backed out 3 changesets (bug 1665713) for perma failures on test_peerConnection_capturedVideo.html. CLOSED TREE
Backed out changeset 296d5facd7bd (bug 1665713)
Backed out changeset 770d63754715 (bug 1665713)
Backed out changeset 433d8f92b482 (bug 1665713)
2020-09-25 02:58:57 +03:00
Michael Froman 1c10dfca58 Bug 1665713 - pt3 - fix js lint issues resulting from moving mochitest directory. r=ng
This was originally excepted under dom/media/tests/** here:
https://searchfox.org/mozilla-central/rev/89d33e1c3b0a57a9377b4815c2f4b58d933b7c32/.eslintrc.js#235

I'm adding the exception for dom/media/webrtc/tests/** for the moved files.

Depends on D90630

Differential Revision: https://phabricator.services.mozilla.com/D91344
2020-09-24 21:12:51 +00:00
Sonia Singla 6a17dca89f Bug 1656291 - Enable all ESLint rules for remaining xhtml files in toolkit/content/tests/chrome/. r=Standard8
Depends on D87183

Differential Revision: https://phabricator.services.mozilla.com/D87961
2020-09-07 12:57:10 +00:00
Sonia Singla d4ff3ccf97 Bug 1656291 - Enable all ESLint rules for some more xhtml files in toolkit/content/tests/chrome/. r=Standard8
Depends on D86483

Differential Revision: https://phabricator.services.mozilla.com/D87183
2020-09-04 06:25:01 +00:00
Sonia Singla a550a75686 Bug 1656291 - Enable all ESLint rules for some files in toolkit/content/tests/chrome/. r=Standard8
Depends on D85627

Differential Revision: https://phabricator.services.mozilla.com/D86483
2020-09-04 06:23:27 +00:00
Sonia Singla 6a38c5acb6 Bug 1656291 - Enable all ESLint rules on xhtml test files in toolkit/components/{ctypes|osfile|places|workerloader} r=Standard8
Depends on D85626

Differential Revision: https://phabricator.services.mozilla.com/D85627
2020-09-04 06:22:43 +00:00
Sonia Singla 04bedaa42d Bug 1656291 - Enable all ESLint rules for toolkit/components/aboutmemory/tests/*.xhtml. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D85626
2020-09-04 06:22:20 +00:00
Sonia Singla 3c29de9496 Bug 1656294 - Enable all ESLint rules on accessible/tests/mochitest/*.xhtml files. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D85459
2020-08-27 09:36:18 +00:00
Sonia Singla 34ac1b2de3 Bug 1656292 - Enable remaining ESLint rules on editor/libeditor/tests/*.xhtml files. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D85450
2020-07-31 23:58:46 +00:00
Sonia Singla 541bda618d Bug 1656011 - Enable remaining ESLint rules on browser/base/content/test/*.xhtml and browser/components/places/*.xhtml r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D85388
2020-07-31 13:27:52 +00:00
Sonia Singla 66fbd11f99 Bug 1655400 - Enable ESLint rule no-setter-return for all of places. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D85021
2020-07-29 11:19:09 +00:00
Mark Banner 94e847592c Bug 1620537 - Disable no-setter-return where it is failing pending future re-enabling. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D84815
2020-07-24 20:39:30 +00:00
Nihanth Subramanya 9021fa1467 Bug 1603779 - Part 6: Remove now-obsolete exceptions from .eslintrc.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D83116
2020-07-10 15:16:06 +00:00
Nihanth Subramanya 5ab95662ca Bug 1644444 - Update NextDNS endpoint URL and migrate pref values. r=valentin,prathiksha
Differential Revision: https://phabricator.services.mozilla.com/D79627
2020-06-18 08:18:58 +00:00
Kenrick 08f36c530a Bug 1596160: Re-enable eslint rules within layout and address eslint failures in testcases r=dholbert
This patch was largely automated. It was generated by manually
editing .eslintrc.js and then running mach eslint layout --fix.

Additionally, this includes manual changes to test_bug533845.xhtml
and test_bug467442.xhtml that were necessary to appease eslint.

Differential Revision: https://phabricator.services.mozilla.com/D78615
2020-06-09 15:27:37 +00:00
Timothy Nikkel 779fc72cff Bug 1632268. Add browser chrome test for select dropdown position with pinch (apz) zooming. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D78025
2020-06-08 05:45:34 +00:00
Rob Wu 41cc31b26c Bug 1633466 - Move common test logic to test/xpcshell/rs-blocklist/head.js r=Gijs
And introduce a helper to get the ExtensionBlocklistMBLF global without
using a deprecated API, and remove the exception from eslintrc

Differential Revision: https://phabricator.services.mozilla.com/D76712
2020-05-25 17:16:53 +00:00
Mark Hammond 6e4d1af4af Bug 1623245 - A new browser.storage.sync local storage implementation, pref'd off. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D67273
2020-05-15 01:29:56 +00:00
Rob Wu 07cadc8026 Bug 1620621 - Unit tests for MLBF-based blocklist r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72631
2020-04-30 10:02:37 +00:00
Razvan Maries c92da124b3 Backed out 8 changesets (bug 1620621) for build bustages. CLOSED TREE
Backed out changeset 14a57e32c414 (bug 1620621)
Backed out changeset 56b2b19a9bc1 (bug 1620621)
Backed out changeset 6df42b7528ec (bug 1620621)
Backed out changeset c23703684254 (bug 1620621)
Backed out changeset 206ad824e1bc (bug 1620621)
Backed out changeset e0f3e057b311 (bug 1620621)
Backed out changeset 12817823a3c9 (bug 1620621)
Backed out changeset 80dcb089ce8e (bug 1620621)
2020-04-30 12:29:30 +03:00
Rob Wu 34e22a3202 Bug 1620621 - Unit tests for MLBF-based blocklist r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72631
2020-04-30 08:28:11 +00:00
Dorel Luca 58186c88dc Backed out 8 changesets (bug 1620621) for XPCshell failures in xpcshell/rs-blocklist/test_blocklist_mlbf_fetch.js
Backed out changeset 06fccc75c09e (bug 1620621)
Backed out changeset 8b4e286967c0 (bug 1620621)
Backed out changeset cfde27a748fd (bug 1620621)
Backed out changeset 7abf836343be (bug 1620621)
Backed out changeset 1a28d1de8f76 (bug 1620621)
Backed out changeset 90c08438be0a (bug 1620621)
Backed out changeset 723a3b4e7bbf (bug 1620621)
Backed out changeset bbc991f09d5d (bug 1620621)
2020-04-30 05:44:28 +03:00
Rob Wu c264c29f1e Bug 1620621 - Unit tests for MLBF-based blocklist r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D72631
2020-04-29 23:08:18 +00:00
Michael Kaply 59de6dc9a6 Bug 1557754 - Don't allow locked preferences to be enabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D59945
2020-04-24 16:50:37 +00:00
Cosmin Sabou 65d407b03b Backed out changeset 4bd5a347ff43 (bug 1557754) for causing build bustages. 2020-04-24 19:20:37 +03:00
Michael Kaply e8984aee47 Bug 1557754 - Don't allow locked preferences to be enabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D59945
2020-04-24 15:58:08 +00:00
Tim Nguyen efcd5a4bff Bug 1201243 - Make browser/components/preferences/in-content top-level and move dialogs to a subdirectory. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D72038
2020-04-22 23:35:08 +00:00
Gijs Kruitbosch c58b8f6ff2 Bug 1631358 - remove CPOW support in the message manager, r=mccr8
This commit:

- removes sendRpcMessage, which was unused;
- removes the CPOW argument to sendAsyncMessage, broadcastAsyncMessage, and
  sendSyncMessage;
- removes the aIsSync argument used internally to distinguish sendRpcMessage
  and sendSyncMessage;
- removes CPOW tests;
- updates the few remaining callsites that use more than 2 arguments in
  sendAsyncMessage for the removal of the cpows argument.

Differential Revision: https://phabricator.services.mozilla.com/D71514
2020-04-21 14:07:57 +00:00
MahakBansal ee093cd087 Bug 1582666 - Enable more ESLint rules for netwerk/. r=Standard8,valentin
Differential Revision: https://phabricator.services.mozilla.com/D69257

--HG--
extra : moz-landing-system : lando
2020-04-07 16:00:03 +00:00
Sylvestre Ledru c33ca7fb02 Bug 1622328 - .eslintrc.js: Add the license r=Standard8
Leave message empty to abort commit. HG: -- HG: user: Sylvestre Ledru
<sledru@mozilla.com> HG: branch 'default' HG: changed .eslintrc.js

Depends on D66801

Differential Revision: https://phabricator.services.mozilla.com/D66802

--HG--
extra : moz-landing-system : lando
2020-03-18 09:27:54 +00:00
JulianWels e5c3036681 Bug 1620242 - Basic implementation for HTTPS Only Mode. r=ckerschb,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D62590

--HG--
rename : dom/security/test/csp/file_redirect_report.sjs => dom/security/test/https-only/file_redirect.sjs
rename : dom/security/test/csp/file_upgrade_insecure.html => dom/security/test/https-only/file_upgrade_insecure.html
rename : dom/security/test/csp/file_upgrade_insecure_server.sjs => dom/security/test/https-only/file_upgrade_insecure_server.sjs
rename : dom/security/test/csp/file_upgrade_insecure_wsh.py => dom/security/test/https-only/file_upgrade_insecure_wsh.py
extra : moz-landing-system : lando
2020-03-17 19:24:31 +00:00
Noemi Erli f10f67e74c Backed out changeset 21f62488a5b5 (bug 1620242) for causing bustages in nsMixedContentBlocker.cpp CLOSED TREE 2020-03-16 23:11:00 +02:00
JulianWels c2c4e65115 Bug 1620242 - Basic implementation for HTTPS Only Mode. r=ckerschb,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D62590

--HG--
rename : dom/security/test/csp/file_redirect_report.sjs => dom/security/test/https-only/file_redirect.sjs
rename : dom/security/test/csp/file_upgrade_insecure.html => dom/security/test/https-only/file_upgrade_insecure.html
rename : dom/security/test/csp/file_upgrade_insecure_server.sjs => dom/security/test/https-only/file_upgrade_insecure_server.sjs
rename : dom/security/test/csp/file_upgrade_insecure_wsh.py => dom/security/test/https-only/file_upgrade_insecure_wsh.py
extra : moz-landing-system : lando
2020-03-16 16:47:54 +00:00
Dave Townsend 8aefbf2bdc Bug 1617959: Switch to the babel-eslint parser and turn on support for optional chaining and nullish coalescing operator syntaxes. r=Standard8
The babel-eslint parser defaults to assuming all scripts are modules. Although
we're moving in that direction it seems reasonable to set the default as regular
scripts for now. All the places that were previously overriding the parser are
already specifying the sourceType in their eslint configs.

I chose to put the babel config in a file that babel itself won't look to avoid
the risk of this config impacting the use of babel elsewhere in the tree.

Differential Revision: https://phabricator.services.mozilla.com/D66127

--HG--
extra : moz-landing-system : lando
2020-03-13 19:15:11 +00:00
Mihai Alexandru Michis 75355611d1 Backed out changeset 46dfbb4de902 (bug 1620242) for causing failures in test_x-frame-options.html
CLOSED TREE
2020-03-13 18:24:03 +02:00
JulianWels d5b073f588 Bug 1620242 - Basic implementation for HTTPS Only Mode. r=ckerschb,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D62590

--HG--
rename : dom/security/test/csp/file_redirect_report.sjs => dom/security/test/https-only/file_redirect.sjs
rename : dom/security/test/csp/file_upgrade_insecure.html => dom/security/test/https-only/file_upgrade_insecure.html
rename : dom/security/test/csp/file_upgrade_insecure_server.sjs => dom/security/test/https-only/file_upgrade_insecure_server.sjs
rename : dom/security/test/csp/file_upgrade_insecure_wsh.py => dom/security/test/https-only/file_upgrade_insecure_wsh.py
extra : moz-landing-system : lando
2020-03-13 14:25:08 +00:00
Harry Twyford 17deed86df Bug 1620274 - Move tests in urlbar/tests/browser/tips to urlbar/tests/browser-tips. r=mak,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D65577

--HG--
rename : browser/components/urlbar/tests/browser/tips/browser.ini => browser/components/urlbar/tests/browser-tips/browser.ini
rename : browser/components/urlbar/tests/browser/tips/browser_interventions.js => browser/components/urlbar/tests/browser-tips/browser_interventions.js
rename : browser/components/urlbar/tests/browser/tips/browser_picks.js => browser/components/urlbar/tests/browser-tips/browser_picks.js
rename : browser/components/urlbar/tests/browser/tips/browser_searchTips.js => browser/components/urlbar/tests/browser-tips/browser_searchTips.js
rename : browser/components/urlbar/tests/browser/tips/browser_searchTips_interaction.js => browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js
rename : browser/components/urlbar/tests/browser/tips/browser_selection.js => browser/components/urlbar/tests/browser-tips/browser_selection.js
rename : browser/components/urlbar/tests/browser/tips/browser_updateAsk.js => browser/components/urlbar/tests/browser-tips/browser_updateAsk.js
rename : browser/components/urlbar/tests/browser/tips/browser_updateRefresh.js => browser/components/urlbar/tests/browser-tips/browser_updateRefresh.js
rename : browser/components/urlbar/tests/browser/tips/browser_updateRestart.js => browser/components/urlbar/tests/browser-tips/browser_updateRestart.js
rename : browser/components/urlbar/tests/browser/tips/browser_updateWeb.js => browser/components/urlbar/tests/browser-tips/browser_updateWeb.js
rename : browser/components/urlbar/tests/browser/tips/head.js => browser/components/urlbar/tests/browser-tips/head.js
extra : moz-landing-system : lando
2020-03-12 02:35:24 +00:00
Gijs Kruitbosch f1a04bd343 Bug 1618188 - remove XML backend for plugin and add-on blocklisting, r=mconley,perftest-reviewers,whimboo
This removes the obsolete backend. Notes on some of the less obvious changes
made as part of this patch:

- some of the gFoo style getters in Blocklist.jsm were only used by the XML
  version of the blocklist; I've removed them and tried to remove spurious
  settings of those properties in the remaining tests.
- some utility methods (e.g. distribution information getters) were also only
  used for the XML version (for the update URL).
- it's no longer necessary to test switching implementations.
- in browser/base/content/test/plugins/, we ran some tests from two manifests
  in order to run them with both blocklist backends. The simplest way of
  reducing this back down to one was to remove the remote-settings one. If I'd
  been more future-oriented when I created the duplication, perhaps I would
  have moved the XML version out into a different manifest instead, but I
  didn't, so now it looks like we're removing the modern one, whereas really
  we're going to be running the modern one as part of the "normal" tests and
  we're no longer running the "old" tests.
- removed all mentions I could see of extensions.blocklist.url which is no
  longer used for anything.
- per https://bugzilla.mozilla.org/show_bug.cgi?id=1016555#c23, updated
  references for the OneCRL timing and how it relates to blocklist updates.

Differential Revision: https://phabricator.services.mozilla.com/D64933

--HG--
extra : moz-landing-system : lando
2020-03-09 12:02:17 +00:00
Mark Banner b2df945d37 Bug 1620542 - Turn on linting of .eslintrc.js files. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D65704

--HG--
extra : moz-landing-system : lando
2020-03-07 09:30:44 +00:00
Mark Banner 15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Mark Banner 556504ff93 Bug 1614822 - Enable ESLint for testing/mochitest/tests/Harness_sanity/. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D62512

--HG--
extra : moz-landing-system : lando
2020-02-12 19:38:40 +00:00
JulianWels f214413b6c Bug 1583215 - Moved referrer-policy tests to dom/security folder. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D61999

--HG--
rename : dom/base/test/img_referrer_testserver.sjs => dom/security/test/referrer-policy/img_referrer_testserver.sjs
rename : dom/base/test/referrer_header.sjs => dom/security/test/referrer-policy/referrer_header.sjs
rename : dom/base/test/referrer_header_current_document_iframe.html => dom/security/test/referrer-policy/referrer_header_current_document_iframe.html
rename : dom/base/test/referrer_helper.js => dom/security/test/referrer-policy/referrer_helper.js
rename : dom/base/test/referrer_testserver.sjs => dom/security/test/referrer-policy/referrer_testserver.sjs
rename : dom/base/test/test_img_referrer.html => dom/security/test/referrer-policy/test_img_referrer.html
rename : dom/base/test/test_referrer_header_current_document.html => dom/security/test/referrer-policy/test_referrer_header_current_document.html
rename : dom/base/test/test_referrer_redirect.html => dom/security/test/referrer-policy/test_referrer_redirect.html
extra : moz-landing-system : lando
2020-02-12 08:52:21 +00:00
Mark Banner 053da90c15 Bug 1613111 - Enable ESLint on testing/mochitest/tests/SimpleTest/ (manual changes). r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D61864

--HG--
extra : moz-landing-system : lando
2020-02-11 17:33:15 +00:00
Julian Descottes 6d77dc5271 Bug 1611229 - Add linting rule to prevent using ChromeUtils.import(..., null) r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D60891

--HG--
extra : moz-landing-system : lando
2020-01-29 13:15:54 +00:00