Chris Peterson
9169f6d9ef
Bug 1215902 - Fix clang's -Wimplicit-fallthrough warnings in extensions/cookie. r=jdm
...
extensions/cookie/nsCookiePermission.cpp:207:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:933:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:952:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:979:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1061:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1255:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1353:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1377:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
2015-10-17 22:12:38 -07:00
Nathan Froyd
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
Yoshi Huang
fb57af4ae6
Bug 1191653 - Listen to clear-origin-data in nsPermissionManager. r=bholley
2015-10-13 10:27:42 +08:00
Carsten "Tomcat" Book
0ecf764867
merge mozilla-inbound to mozilla-central a=merge
2015-10-14 12:46:09 +02:00
Daniel Holbert
225fa78d5c
Bug 1181313: Remove some unnecessary logging statements for success conditions, in nsPermissionManager.cpp. r=bsmedberg
2015-10-13 17:19:06 -07:00
M Hamdy
67d215f8de
Bug 606655 - delete cookies UI option AskMeEveryTime and its related comments and tests. r=mak
...
--HG--
extra : rebase_source : 242a074db54395e4b285110286e7692f26b57daa
2015-10-08 09:13:00 +02:00
Michael Layzell
430ced132c
Bug 1211591 - Part 2: Tests for nsPermissionManager::RemovePermissionsForApp, r=jdm
2015-10-08 08:42:40 -04:00
Michael Layzell
4e925c38c8
Bug 1211591 - Part 1: Remove incorrect sql statement from nsPermissionManager::RemovePermissionsForApp, r=jdm
...
This initial query to clear the database was initially removed because of the removal of the appId column, and replaced with the following logic which parses the origin strings to obtain the appId property, and then removes those entries using `AddInternal`. Unfortunately, during a rebase, it appears as though the code crept back into the codebase.
I'm not sure why this codepath wasn't ever tested before bkelly noticed it, but we should probably add a test of some form which actually runs the RemovePermissionsForApp codepath, to ensure that it actually works.
2015-10-08 08:42:38 -04:00
Carsten "Tomcat" Book
08997000eb
Backed out 2 changesets (bug 1202902
) to recking bug 1202902
to be able to reopen inbound on a CLOSED TREE
...
Backed out changeset 647025383676 (bug 1202902
)
Backed out changeset d70c7fe532c6 (bug 1202902
)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
e7ef778c9d
Backed out 1 changesets (bug 1202902
) for causing merge conflicts to mozilla-central
...
Backed out changeset cfc1820361f5 (bug 1202902
)
--HG--
extra : rebase_source : 5d3db72337754bc7ab0ed0c30b2896100411ff92
2015-10-07 12:13:45 +02:00
Shu-yu Guo
d06b6030f6
Bug 1202902
- Scripted fix the world.
2015-10-06 14:00:31 -07:00
Ethan Tseng
bb095c04f4
Bug 1165267 - Part 1: Replace appId and inBrowser by originAttributes v2. r=honzab
2015-09-03 18:22:51 +08:00
Michael Layzell
2070870d99
Bug 1195492 - Remove the backup moz_hosts table and the moz_hosts_is_backup marker table, r=ehsan
2015-10-03 14:30:52 -04:00
Yoshi Huang
836f7732eb
Bug 1210459: Add originAttributes for tests that implement nsILoadContext. r=bholley
2015-09-30 18:14:12 -07:00
Christoph Kerschbaumer
11958f19c8
Bug 1205151 - Use channel->Open2() in extensions/cookie/nsPermissionManager.cpp (r=sicking)
2015-09-15 19:47:27 -07:00
Shu-yu Guo
64db2267cf
Bug 1202902
- Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff)
2015-09-15 11:19:45 -07:00
Nicholas Nethercote
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Yoshi Huang
e6070e9062
Bug 1165272 - Part 2: replace getNoAppCodebasePrincipal. r=bholley
2015-08-18 15:01:42 +08:00
Yoshi Huang
4347bb2318
Bug 1165272 - Part 1: remove getAppCodebasePrincipal. r=bholley
2015-08-17 17:03:19 +08:00
Bobby Holley
edfe287f26
Backed out 3 changesets (bug 1165272) for b2g sanity blocker.
2015-08-25 11:16:21 -07:00
Yoshi Huang
de47f4b89f
Bug 1165272 - Part 2: Replace getNoAppCodebasePrincipal. r=bholley
2015-08-24 01:18:00 -04:00
Yoshi Huang
12efacfa8c
Bug 1165272 - Part 1: Remove getAppCodebasePrincipal. r=bholley
2015-08-24 01:31:00 -04:00
Ehsan Akhgari
10a0e4dd34
Bug 1194319 - Correctly deal with all possible ways that initializing the permission manager DB connection can fail; r=mystor
2015-08-18 18:52:00 -04:00
Ehsan Akhgari
ef2bd61403
Bug 1195983 - Remove some dead code from the permission manager; r=mystor
2015-08-18 18:51:59 -04:00
Michael Layzell
7022197117
Bug 1189070 - Don't discard localhost or IP address entries from the permissions database when migrating, r=ehsan
2015-08-11 15:09:52 -04:00
Ryan VanderMeulen
eca62c99b5
Bug 863738 - Skip test_cookies_persistence.js for frequent failures. r=tanvi
...
CLOSED TREE
2015-08-07 12:16:47 -04:00
Michael Layzell
6c34c15ee2
Bug 1185239 - Test migration logic in the non-presence of a nsINavHistoryService
2015-07-23 17:57:51 -04:00
Michael Layzell
97694630c4
Bug 1186034 - Part 2: Tests for new permission manager migration pathways
...
--HG--
rename : extensions/cookie/test/unit/test_permmanager_migrate_4-5.js => extensions/cookie/test/unit/test_permmanager_migrate_4-7.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_5-6.js => extensions/cookie/test/unit/test_permmanager_migrate_5-7a.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_4-5.js => extensions/cookie/test/unit/test_permmanager_migrate_5-7b.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_4-5.js => extensions/cookie/test/unit/test_permmanager_migrate_6-7a.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_4-5.js => extensions/cookie/test/unit/test_permmanager_migrate_6-7b.js
2015-07-23 17:57:47 -04:00
Michael Layzell
835e532032
Bug 1186034 - Part 1: Re-migrate users with permissions-database versions 5/6 to prevent dataloss
2015-07-23 17:57:43 -04:00
Michael Layzell
9d189a192f
Bug 1186909 - Use eTLD+1 rather than host for the history query lookup for nsIPermissionManager migrations
2015-07-23 17:57:39 -04:00
Michael Layzell
25ed3b884f
Bug 1186946 - Warn on history service call failure in nsPermissionManager migrations
2015-07-23 17:57:35 -04:00
Carsten "Tomcat" Book
468e64bc33
Backed out changeset 89fbd9f70cf8 (bug 1186034) for xpcshell failures in test_permmanager_migrate_4-7.js
2015-07-23 11:50:42 +02:00
Carsten "Tomcat" Book
61079c977d
Backed out changeset 45f326aa8cd6 (bug 1186034)
...
--HG--
rename : extensions/cookie/test/unit/test_permmanager_migrate_4-7.js => extensions/cookie/test/unit/test_permmanager_migrate_4-5.js
2015-07-23 11:50:03 +02:00
Michael Layzell
017f9a9077
Bug 1186034 - Part 2: Tests for new permission manager migration pathways. r=ehsan
...
--HG--
rename : extensions/cookie/test/unit/test_permmanager_migrate_4-5.js => extensions/cookie/test/unit/test_permmanager_migrate_4-7.js
2015-07-22 12:52:00 +02:00
Michael Layzell
cab40a9f9c
Bug 1186034 - Part 1: Re-migrate users with permissions-database versions 5/6 to prevent dataloss. r=ehsan
2015-07-22 13:43:00 +02:00
Wes Kocher
2dfd2a2881
Merge inbound to central, a=merge
2015-07-21 15:49:23 -07:00
Michael Layzell
a5a383b50b
Bug 1185343 - Part 2: Test for migration from schema 5->6 for permission manager. r=ehsan
2015-07-21 08:54:00 -04:00
Michael Layzell
fa53b28865
Bug 1185343 - Part 1: Use new table moz_perms for permissions, and leave unmigrated permission data in moz_hosts for back-compat. r=ehsan
2015-07-21 10:23:00 -04:00
Michael Layzell
f2b2c890cd
Bug 1185340 - Greatly improve efficiency of permissions.sqlite migration on large permissions databases. r=ehsan
2015-07-20 10:58:00 -04:00
Ehsan Akhgari
37ef28c23d
Bug 1185986 - Don't hold the observer service alive from nsPermissionManager; r=jdm
...
In order to fully ensure that leaking the permission manager service
will not leak the observer service, let's kill this reference completely.
This patch also moves the registration of the observers to after the
IsChildProcess() check, since the profile observer notifications do not fire
in the child process.
2015-07-21 13:40:34 -04:00
Michael Layzell
f53ae1b46e
Bug 1185239 - Feature-check for the Places API in nsPermissionManager migration code; r=ehsan
2015-07-18 17:05:12 -04:00
Ehsan Akhgari
1a7515c6f8
Bug 1184397 - Release the observer service when the permission manager shuts down; r=jdm
2015-07-17 15:57:26 -04:00
Wes Kocher
801de8e6d3
Backed out changeset 7b3074ad5644 (bug 1184397) to hopefully fix the xpcshell bustage
2015-07-16 16:35:08 -07:00
Michael Layzell
017f50b6d7
Bug 1172080 - Part 2: Use ^ instead of ! to delimit originAttributes from the URI in nsIPrincipal.origin, r=bholley
2015-07-16 14:50:07 -04:00
Michael Layzell
f182adf1c4
Bug 1165263 - Part 2: Update unit tests for nsPermissionManager to reflect new internals, r=ehsan
2015-07-16 14:49:53 -04:00
Michael Layzell
0d0c859546
Bug 1165263 - Part 1: Update nsPermissionManager to use origins instead of hosts internally, r=ehsan
2015-07-16 14:49:51 -04:00
Michael Layzell
278d558546
Bug 817007 - Part 1: Remove <file> hack from the permission manager, r=ehsan
2015-07-16 14:49:46 -04:00
Michael Layzell
ec7f71eae3
Bug 1173523 - Part 10: Update nsIPermission and nsIPermissionManager tests to use new API for nsIPermission, r=ehsan
2015-07-16 14:49:39 -04:00
Michael Layzell
e757604c6f
Bug 1173523 - Part 2: Tests for new methods nsIPrincipal::MatchesURI and nsIPrincipal::Matches, r=ehsan
2015-07-16 14:49:24 -04:00
Michael Layzell
9d564ec2dd
Bug 1173523 - Part 1: Expose an nsIPrincipal from nsIPermission rather than a host string, appId, and isInBrowserElement, r=ehsan
2015-07-16 14:49:22 -04:00