The code was written to hide the geometry highlighter when:
- the nodepicker was selected
- another node was selected in the markup view
- a node was hovered in the markup view
but this wasn't working as intended, as the line setting
the first of the event listeners was throwing, and we
don't have tests for this.
This patch fixes the faulty line and adds a test to check
that the geometry highlighter does hide on those actions.
We take this opportunity to use an AbortController to handle
the removal of the event listeners added when starting the
geometry highlighter.
Differential Revision: https://phabricator.services.mozilla.com/D126885
The default handler and character-data handler callbacks are identical
and some Windows compilers just reconciled them into a single function.
This, unfortunately, resulted in a RLBox runtime error: the same
callback was registered twice. This patch removes the duplicate handler
implementation and just sets the character-data handler callback as the
default handler.
Depends on D104658
Differential Revision: https://phabricator.services.mozilla.com/D126369
Using requestedIndex on the child side is hard, because there are race conditions when a session history load is triggered
and at the same time a non-session history load commits a new active entry.
Differential Revision: https://phabricator.services.mozilla.com/D126619
There's an existing algorithm to check if a virtualenv's installed
packages are up-to-date with its requirements. This patch
extracts that logic so that, in cases where we can't automatically
download needed pip packages, we can at least assert that the ones
installed to the system Python are sufficient to meet our requirements.
The current only case in which this system-checking logic is applied
is when starting the Mach virtualenv and the `MOZ_AUTOMATION` or
`MACH_USE_SYSTEM_PYTHON` environment variable is set.
Differential Revision: https://phabricator.services.mozilla.com/D122890
Eventually we should support all of them, but for now they are only used
by native code (unless you enable the color-scheme pref) and these will
be enough.
Differential Revision: https://phabricator.services.mozilla.com/D126737
The issue here is that we don't clear the cached intrinsic size of the
flex item, but this reproduces without flex at all.
The main issue is that we choose whether to clear the intrinsic sizes
from a reflow root (the outer svg in this case) based on whether the
reflow changes size or position:
https://searchfox.org/mozilla-central/rev/3fa5cc437a4937c621ea068ba5dc246f75831633/layout/base/RestyleManager.cpp#1224-1229
This is ~fine, except the nsChangeHint_ReflowChangesSizeOfPosition hint
can be "inherited" (and thus be cleared if already subsumed by a
parent):
https://searchfox.org/mozilla-central/rev/3fa5cc437a4937c621ea068ba5dc246f75831633/layout/base/nsChangeHint.h#465-469
This is ~fine, as we'll already start the reflow further up the tree (so
we don't need to start go past the reflow root), but we still need to
clear the ancestor intrinsics. We still get to StyleChangeReflow with
the ClearAncestorIntrinsics hint. We could pass that information down,
but the information is really already in via the IntrinsicChange.
I think it's just not correct to stop clearing intrinsic sizes if the
target is a reflow root and we get a TreeChange/StyleChange, regardless
of whether it changes size/position. It should also be a few less
instructions, though not that it matters.
Depends on D126812
Differential Revision: https://phabricator.services.mozilla.com/D126813
Automatic update from web-platform-tests
[@scroll-timeline] Effectively pause animations in flaky WPT
The last test in at-scroll-timeline-dynamic.tentative.html expects
*zero* time to have passed between the first and second calls to
'await assert_width(...)', when in reality several frames worth of
time has passed. This causes flakiness on bots.
We don't actually care about exactly where we're at on the document
timeline in this test file, only whether or not we are currently on
that timeline. Hence this CL uses the steps() function to effectively
"stop" document-timeline-attached animations for a full minute.
Fixed: 1248912
Change-Id: I53b0c4319daf306c0e664454b1b48208c384c657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3158007
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#921117}
--
wpt-commits: f0aff7d1bdbe6bff4c059ecf88faae0a387044a3
wpt-pr: 30694
Automatic update from web-platform-tests
Convert NDEFRecord constructor tests to a Javascript file
This is nice because clang-format can reformat it.
Bug: 1243382
Change-Id: I3cab07de17808a18c2084df85fa99726abd98a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152391
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/main@{#921023}
--
wpt-commits: f91aa336c86e79d339177a13937f9409055253a5
wpt-pr: 30488
Automatic update from web-platform-tests
[EyeDropper API] Add optional AbortSignal parameter to EyeDropper.open
Per TAG review[1], this CL adds an optional AbortSignal parameter to
EyeDropper.open to allow authors to dismiss the eyedropper with no
selection in case another high-priority event occurs.
[1]: https://github.com/w3ctag/design-reviews/issues/587#issuecomment-911951900
Bug: 1248286
Change-Id: I15580609ece85f947f019a724b23b5e4898e42f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152761
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#920997}
--
wpt-commits: a1d99ba695a939e001be1d57c9d758bd5e5ce431
wpt-pr: 30696
Automatic update from web-platform-tests
Don't use a non-local address for relative-to-base.html
We don't allow it on automation and thus the test crashes, see:
https://bugzilla.mozilla.org/show_bug.cgi?id=1730229
--
wpt-commits: 33ccde9c65042284284253ad6c078e2b271e0f53
wpt-pr: 30706
Automatic update from web-platform-tests
Removed time range from CSS scroll timeline tests
Also updated test expectations.
Bug: 1216655, 1140602
Change-Id: If8f0979d57651874446dcd3a9ea3777fc7a53684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3155300
Commit-Queue: Jordan Taylor <jortaylo@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#920970}
--
wpt-commits: ba74d4f2e35766ffb1e5ed97db130cccc627a42c
wpt-pr: 30562
Automatic update from web-platform-tests
[LayoutNG] Fieldset overflow clip in multicol
This CL fixes a broken test case where a fieldset in a multicol had
overflow clip set and a max-height. The problem stemmed around the
fact that we should not take fragmentation into account when measuring.
Bug: 1246175
Change-Id: I76539ca5a7511f20a79cc802abf9ac6f787c8394
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141939
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#920960}
--
wpt-commits: ffea51c04534eee9267b0b10792c8295a934c269
wpt-pr: 30342
Automatic update from web-platform-tests
[@layer] Use layer order to resolve @property and @scroll-timeline name conflicts
This patch adds a new class AtRuleCascadeMap, a miniature CascadeMap,
to cascade @property and @scroll-time rules across origins and cascade
layers.
We can't use it to cascade other name-defining at-rules because:
- @font-face rules with the same 'font-family' may co-exist
- @counter-style and @keyframes rules are managed per tree scope, and
allow the "append-only" update in Blink
Bug: 1095765
Change-Id: Iec5dad0b932b1aed6e9c18bca9da1443e2d1fd88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152514
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#920947}
--
wpt-commits: f4f307697d4b11c068dd4ea097e8006970ac7d9d
wpt-pr: 30496
Automatic update from web-platform-tests
[WPT] Check base URLs in worker-interception-redirect.https.html
This CL
- Changes the response URL of a worker top-level script to
`.../subdir/...` when intercepted by a service worker,
to make worker's base URL directory different depending on
whether the response URL or the current request URL is used.
- Makes worker-interception-redirect-webworker.js/py
to `fetch()`/`importScripts()` relative to its
settings object's base URL, not
`/service-workers/service-worker/resources/`, and checks
the URLs intercepted by serviceworkers.
This checks the settings object's base URL of the workers,
and thus exposes that Chromium uses current request URLs
instead of response URLs as base URL, which will be fixed by
https://chromium-review.googlesource.com/c/chromium/src/+/3145772.
Bug: 861564
Change-Id: I32dbb4aae55aebd12c75b26bd4a503ce366b57a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3146235
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Asami Doi <asamidoi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#920944}
--
wpt-commits: 6d20526e144d62699d48aaf59cb3a67070835909
wpt-pr: 30699
Automatic update from web-platform-tests
Removed time range from worklet animation tests and updated expectations
Animation worklets do not yet support progress based timelines and still
rely on timeRange. However, for the sake of moving forward and because
animation worklets are still experimental it was deemed ok to break them
and update the test expectations until a time when they can be changed
to support progress based animations.
Bug: 1234315, 1216655, 1140602
Change-Id: I04e3ecb7c49cd2a93fe15f5c52f0acd2f18bc151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3155427
Commit-Queue: Jordan Taylor <jortaylo@microsoft.com>
Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#920942}
--
wpt-commits: 951c87f36c6dbffa038139a57f3d59f0b6740900
wpt-pr: 30561
Nicolas Chevobbe
Andreas Farre
Deian Stefan
Tom Schuster
criss
Chris H-C
Alexandre Lissy
Frederik Braun
Nicolas Silva
Olli Pettay
Mitchell Hentges
Andi-Bogdan Postelnicu
Emilio Cobos Álvarez
Mike Hommey
Dsmith
Niklas Goegge
Christoph Kerschbaumer
moz-wptsync-bot
Anders Hartvoll Ruud
youennf
Reilly Grant
Ionel Popescu
Ian Kilpatrick
Jordan Taylor
Alison Maher
Xiaocheng Hu
Hiroshige Hayashizaki