89a70c452d
Bug 1283583 - Clean up code style in devtools/server/child.js. r=ochameau
...
MozReview-Commit-ID: GoHv6jvX6M1
2016-07-01 18:35:25 -05:00
7e1c46f37f
Bug 1278823 - fix eslint issues in StyleEditorUI.jsm;r=tromey
...
MozReview-Commit-ID: 7rI0Kw56Vp4
--HG--
extra : rebase_source : d030b22894b646ba2677cc8929b630cae392d151
2016-06-21 12:21:47 +02:00
469cee9bad
Bug 1225254 - split css-logic.js into server and shared files; r=pbro
...
MozReview-Commit-ID: BTFVQJcVI5d
--HG--
extra : transplant_source : n%A3%EF0e%9F%8E%09%FC4%95%F8%60l3%B73%BDS%C7
2016-06-24 08:26:21 -06:00
af5e8f9ef5
Backed out changeset 3518b484f82d (bug 1275637) for errors in browser_se_first-run.js; CLOSED TREE; r=me, a=KWierso
...
MozReview-Commit-ID: HumbpXccwrF
2016-06-22 14:19:19 -06:00
ba0f9d2892
Bug 1275637 - Fix eslint errors in webgl-utils.js. r=jryans
...
MozReview-Commit-ID: 1T2vOPMAj8G
2016-06-20 06:38:39 -06:00
ca7fb511f8
Bug 1193390 - Remove single arg Cu.import from /devtools. r=tromey
...
A few miscellaneous linting issues also addressed near the lines involved.
MozReview-Commit-ID: 9t1RwxdSS2X
2016-06-09 14:10:07 -05:00
07d01350a8
Merge fx-team to central, a=merge
2016-06-08 17:06:18 -07:00
fc24b11e43
Bug 1271734 - Move all eslint related infrastructure to tools/lint, r=miker
...
This commit simply moves 'testing/eslint' to 'tools/lint/eslint' and the eslint related
mach command from 'python/mach_commands.py' to 'tools/lint/mach_commands.py'. It shouldn't
have any functional change on running eslint, either through mach or taskcluster.
This is in preparation for bug 1258341, to make the diffs there a little easier to read.
MozReview-Commit-ID: K03sn9lv9Lv
--HG--
rename : testing/eslint/eslint-plugin-mozilla/LICENSE => tools/lint/eslint/eslint-plugin-mozilla/LICENSE
rename : testing/eslint/eslint-plugin-mozilla/docs/balanced-listeners.rst => tools/lint/eslint/eslint-plugin-mozilla/docs/balanced-listeners.rst
rename : testing/eslint/eslint-plugin-mozilla/docs/import-browserjs-globals.rst => tools/lint/eslint/eslint-plugin-mozilla/docs/import-browserjs-globals.rst
rename : testing/eslint/eslint-plugin-mozilla/docs/import-globals.rst => tools/lint/eslint/eslint-plugin-mozilla/docs/import-globals.rst
rename : testing/eslint/eslint-plugin-mozilla/docs/import-headjs-globals.rst => tools/lint/eslint/eslint-plugin-mozilla/docs/import-headjs-globals.rst
rename : testing/eslint/eslint-plugin-mozilla/docs/index.rst => tools/lint/eslint/eslint-plugin-mozilla/docs/index.rst
rename : testing/eslint/eslint-plugin-mozilla/docs/mark-test-function-used.rst => tools/lint/eslint/eslint-plugin-mozilla/docs/mark-test-function-used.rst
rename : testing/eslint/eslint-plugin-mozilla/docs/no-aArgs.rst => tools/lint/eslint/eslint-plugin-mozilla/docs/no-aArgs.rst
rename : testing/eslint/eslint-plugin-mozilla/docs/no-cpows-in-tests.rst => tools/lint/eslint/eslint-plugin-mozilla/docs/no-cpows-in-tests.rst
rename : testing/eslint/eslint-plugin-mozilla/docs/reject-importGlobalProperties.rst => tools/lint/eslint/eslint-plugin-mozilla/docs/reject-importGlobalProperties.rst
rename : testing/eslint/eslint-plugin-mozilla/docs/var-only-at-top-level.rst => tools/lint/eslint/eslint-plugin-mozilla/docs/var-only-at-top-level.rst
rename : testing/eslint/eslint-plugin-mozilla/lib/globals.js => tools/lint/eslint/eslint-plugin-mozilla/lib/globals.js
rename : testing/eslint/eslint-plugin-mozilla/lib/helpers.js => tools/lint/eslint/eslint-plugin-mozilla/lib/helpers.js
rename : testing/eslint/eslint-plugin-mozilla/lib/index.js => tools/lint/eslint/eslint-plugin-mozilla/lib/index.js
rename : testing/eslint/eslint-plugin-mozilla/lib/processors/xbl-bindings.js => tools/lint/eslint/eslint-plugin-mozilla/lib/processors/xbl-bindings.js
rename : testing/eslint/eslint-plugin-mozilla/lib/rules/.eslintrc => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/.eslintrc
rename : testing/eslint/eslint-plugin-mozilla/lib/rules/balanced-listeners.js => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/balanced-listeners.js
rename : testing/eslint/eslint-plugin-mozilla/lib/rules/import-browserjs-globals.js => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/import-browserjs-globals.js
rename : testing/eslint/eslint-plugin-mozilla/lib/rules/import-globals.js => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/import-globals.js
rename : testing/eslint/eslint-plugin-mozilla/lib/rules/import-headjs-globals.js => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/import-headjs-globals.js
rename : testing/eslint/eslint-plugin-mozilla/lib/rules/mark-test-function-used.js => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/mark-test-function-used.js
rename : testing/eslint/eslint-plugin-mozilla/lib/rules/no-aArgs.js => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/no-aArgs.js
rename : testing/eslint/eslint-plugin-mozilla/lib/rules/no-cpows-in-tests.js => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/no-cpows-in-tests.js
rename : testing/eslint/eslint-plugin-mozilla/lib/rules/reject-importGlobalProperties.js => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/reject-importGlobalProperties.js
rename : testing/eslint/eslint-plugin-mozilla/lib/rules/var-only-at-top-level.js => tools/lint/eslint/eslint-plugin-mozilla/lib/rules/var-only-at-top-level.js
rename : testing/eslint/eslint-plugin-mozilla/moz.build => tools/lint/eslint/eslint-plugin-mozilla/moz.build
rename : testing/eslint/eslint-plugin-mozilla/package.json => tools/lint/eslint/eslint-plugin-mozilla/package.json
rename : testing/eslint/manifest.tt => tools/lint/eslint/manifest.tt
rename : testing/eslint/npm-shrinkwrap.json => tools/lint/eslint/npm-shrinkwrap.json
rename : testing/eslint/package.json => tools/lint/eslint/package.json
rename : testing/eslint/update => tools/lint/eslint/update
extra : rebase_source : bb44b6285acf4625079cb6a3aaca7d9ada778c3a
2016-06-02 15:38:36 -04:00
b48b79960b
Bug 1278413 - Clean up code style in worker.js, event-emitter.js. r=tromey
...
MozReview-Commit-ID: LVbo9i0rPqI
2016-06-07 22:32:40 -05:00
e1d147bbfc
Bug 1278357 - Clean up code style in transport.js. r=tromey
...
MozReview-Commit-ID: 3uFu6AhOfbg
2016-06-06 17:39:50 -05:00
01e9c7d987
Bug 1202458 - part2: fix eslint errors in string actor;r=pbro
...
MozReview-Commit-ID: 1nguzarA57L
--HG--
extra : rebase_source : 0e9686790c15cf1e1e0ec6e8fddfe6cd441ef070
extra : source : 49d7963e43d890488ad0ad9b1a592c57bdc2be49
2016-06-02 10:35:03 +02:00
d08f21c9a8
Backed out changeset 49d7963e43d8 (bug 1202458) for test failures in test_inspector-mutations-value.html
...
--HG--
extra : rebase_source : daf55daa5c2f5c0a47babdcf86fb8d81f6ce4b99
2016-06-02 16:30:08 +02:00
cd86158629
Bug 1202458 - part2: fix eslint errors in string actor;r=pbro
...
MozReview-Commit-ID: 1nguzarA57L
--HG--
extra : rebase_source : 4861bf47e31ea6d1d0193663a8c92f16eef12214
extra : histedit_source : 28d396641f0c8f12d9f28bc321a72e0666dd2db8
2016-06-02 10:35:03 +02:00
e27f135b3b
Bug 1277243 - rename promise_defer.js to defer.js; r=jryans
...
MozReview-Commit-ID: 9TSQ0Cw82B
--HG--
rename : devtools/shared/promise_defer.js => devtools/shared/defer.js
rename : devtools/shared/tests/unit/test_promise_defer.js => devtools/shared/tests/unit/test_defer.js
extra : transplant_source : %20Kh%D2%21%E9%F9%D1%17L%BD%AC%E5%29%1A%11%06%A9.%98
2016-05-27 13:08:48 -06:00
9bccc8284f
Bug 1256767 - Fix ESLint errors/warnings in devtools/client/webconsole/console-commands.js; r=linclark
...
MozReview-Commit-ID: A5L5DqtHjGe
--HG--
extra : transplant_source : %C0%A4wAu%23%83%7Fp%BA%2A%C5%0C%F6%3E4%1B%08%07%D4
2016-04-20 18:06:01 +08:00
b0934aa13f
Backed out changeset 75bb440d7525 (bug 1275637) for browser_se_first-run.js failures.
...
CLOSED TREE
2016-05-26 19:51:33 -04:00
c8fa47521b
Bug 1275637 - Fix eslint errors in webgl-utils.js. r=jryans
...
MozReview-Commit-ID: 1T2vOPMAj8G
--HG--
extra : transplant_source : %F0%00%02%AF%1C%C7%C80O%7D%0B%C5%DE%01%80%CF%ED%86%A5%12
2016-05-25 13:39:18 -06:00
fae5df8bb3
Bug 1265885 - Add devtools module to replace promise.defer. r=jryans
...
MozReview-Commit-ID: 1Paf8cfkh5Q
2016-05-25 12:40:00 -04:00
4f864f4ffd
Bug 1274964 - ESLint cleanup of devtools/client/inspector; r=jryans
...
MozReview-Commit-ID: HCRVzU6NdM4
--HG--
extra : rebase_source : 375d55c7688599d57615a04f68ed7230cab856c2
extra : amend_source : a0fa5104ef3fbd7ba98512979cfb2396645c07e9
2016-05-23 10:41:02 +02:00
78f5e4c770
Bug 1270994 - Re-add webgl-utils.js to .eslineignore because I just intentionally re-broke it CLOSED TREE
2016-05-23 14:08:10 -07:00
50ab4ddfdd
Bug 1270994 - Fix ESLint errors in devtools/client/shared/*.js; r=jryans
...
MozReview-Commit-ID: 1od43gBnUq1
2016-05-19 08:35:45 -06:00
0d398a243a
Bug 1265869 - Add task.js and use in devtools. r=jryans
...
MozReview-Commit-ID: G5UuAh2RiZZ
--HG--
rename : toolkit/modules/Task.jsm => devtools/shared/task.js
extra : transplant_source : %B8h%8A%8C%BD%91%8A%81%1D%F4%F5%2Ap%CFv%BC%963u0
2016-05-17 13:07:55 -06:00
cea8e5072a
Bug 1271084 - Explicitly ignore files with specific style. r=tromey
...
MozReview-Commit-ID: DOvplOCJIAl
2016-05-18 12:49:23 -05:00
b13c5a9153
Bug 1271084 - Remove missing files from .eslintignore. r=tromey
...
MozReview-Commit-ID: 5NsTjhMbDe9
2016-05-18 12:49:23 -05:00
54c922ca84
Merge inbound to m-c. a=merge
...
CLOSED TREE
2016-05-18 12:02:42 -04:00
75f63a4458
Bug 1273653 - Fix ESLint errors in devtools/client/shared/(components|redux). r=tromey
...
MozReview-Commit-ID: 5hY0uII6wf8
2016-05-17 23:20:14 +02:00
e4149a2ab9
Bug 1267015 - ESLint cleanup of devtools/client/styleinspector/shared/test; r=bgrins
...
MozReview-Commit-ID: GKnRmlqIBxb
--HG--
extra : rebase_source : 69109deafb0af8113a31832b604208817a224dbb
2016-05-13 10:16:45 +02:00
96dddc3634
Bug 1260630 - ESLint cleanup of devtools/client/inspector/computed/; r=bgrins
...
MozReview-Commit-ID: BreSVf4bPf
--HG--
extra : rebase_source : 5ff6e97ba85c5d3bcd14db42aba10e5ee0a469e9
2016-05-13 13:09:17 +02:00
439e22f050
Bug 1266826 - Turn Templater.jsm into a .js. r=jryans
...
MozReview-Commit-ID: 4T4YiOiU0oZ
--HG--
rename : devtools/shared/gcli/Templater.jsm => devtools/shared/gcli/templater.js
extra : transplant_source : N%7B%B7%E9%91%F7%CC%87%22%D0%1E%7BZ%05%16%ED%A3q%99F
2016-05-12 09:06:38 -06:00
45c01647ea
Bug 1264907 - Don't show the firstChild of the current selection in breadcrumbs; r=jdescottes
...
The breadcrumbs widget used to have a feature where it would show the first
child of the current selection even the DOM tree hadn't been expanded that
far yet.
This was to allow keyboard navigating the DOM through the breadcrumbs.
The breadcrumbs is a very rarely used widget and this code was unnecessarily
making things complex.
It was decided that this feature would be removed.
Instead, the breadcrumbs now act as simple linear elements in a toolbar and
you can keyboard navigate them with LEFT/RIGHT only. TAB/shift-TAB simply go
in/out of the breadcrumbs widget.
MozReview-Commit-ID: BmcaLnVBOBn
--HG--
extra : rebase_source : 1673a6c9da02cf8b3b542e4ce905ccb239250aa7
2016-04-15 12:03:33 +02:00
d448361566
Bug 1271709 - fix eslint-plugin-mozilla .eslintrc; r=pbro
...
testing/eslint-plugin-mozilla/lib/rules/.eslintrc used the obsolete
"keyword-spacing" rule. This patch fixes that and changes the top-level
.eslintignore so that local eslint rules are now checked.
MozReview-Commit-ID: KjVLasvPKh7
--HG--
extra : transplant_source : %AB%A2g%9F%26%E4%892%29%5Bs%7E%11%A67%00v%A2I%CC
2016-05-10 11:03:54 -06:00
7dfb735bf9
Bug 1069829 - 3 - Clean styles.js off of eslint errors; r=me
...
MozReview-Commit-ID: JxEJRM3KUPQ
2016-05-10 13:29:55 +02:00
90210699e7
Bug 1271048 - Fix eslint issues in devtools/bootstrap.js. r=pbro
...
MozReview-Commit-ID: J5BXwB4dXhD
2016-05-10 00:15:03 +02:00
bf4a51cc20
Bug 1270203 - make css-angle eslint-clean; r=nchevobbe
...
MozReview-Commit-ID: IfCMc8ewLDu
--HG--
extra : transplant_source : %3F%DB%40%99I%5B%81%F4%99%9Bo%CC%3F%08%E5d%C8%11x%A7
2016-05-05 12:26:24 -06:00
b266a392fe
Bug 1265787 - Add javascript CSS lexer to devtools. r=pbro
...
MozReview-Commit-ID: BgbACHTTMtX
--HG--
extra : transplant_source : %0B%F5%A3%AE%D8U%AB%5D%DF%D4%8A%90%21%22%0E%C6%BDW%06%88
2016-04-29 11:21:22 -06:00
71073210e9
Bug 1268974 - make css-parsing-utils eslint-clean; r=pbro
...
MozReview-Commit-ID: 4iPN37XMbIy
2016-05-04 07:57:33 -06:00
b64ae72562
Backed out changeset f54c4f5fd0ed (bug 1265787)
2016-05-04 12:27:37 +02:00
3db7c01bb7
Merge mozilla-central to fx-team
2016-05-04 12:01:17 +02:00
ad9214381b
merge mozilla-inbound to mozilla-central a=merge
2016-05-04 11:54:42 +02:00
8a9f366080
Bug 1266842 - replace rgbToColorName, colorToRGBA, isValidCSSColor in devtools; r=pbro
...
MozReview-Commit-ID: G5Zly0HPJuv
--HG--
extra : rebase_source : 85e0afd02cd676a2a7e0855a0b4956b7b9a2ac36
2016-04-28 08:46:19 -06:00
3ab72b1e0f
Bug 1266842 - move css-color.js to devtools/client/shared; r=pbro
...
MozReview-Commit-ID: 9zS1Y4Ape2u
--HG--
rename : devtools/shared/css-color.js => devtools/client/shared/css-color.js
rename : devtools/shared/tests/unit/test_cssColor.js => devtools/client/shared/test/unit/test_cssColor.js
extra : rebase_source : fb9efd824bd025af2208b9d860f44ec67ece3de2
2016-04-28 08:41:40 -06:00
4383c1a8b1
Bug 1265787 - add javascript CSS lexer to devtools; r=pbro
...
MozReview-Commit-ID: BgbACHTTMtX
--HG--
extra : transplant_source : %A3iN%27%23%04g%91%06%2CsB%24%ABA%E9%81%D2%EA%8C
2016-04-29 11:21:22 -06:00
266d684430
Bug 1259743 - Part 2: Make devtools/server/actors/webbrowser.js eslint-clean. r=ochameau
2016-04-28 03:54:00 -04:00
f16c510764
Bug 1267378 - fix eslint errors in css-color.js; r=miker
...
MozReview-Commit-ID: D1MM5Yk9IKv
--HG--
extra : amend_source : 9303a23cc67d4499567557140dacb9b74fa6da5d
2016-04-25 13:56:04 -06:00
6935908bcd
Bug 1256772 - Fix ESLint issues in devtools/client/webconsole/jsterm.js; r=linclark
...
MozReview-Commit-ID: 4fS6PsBGORI
--HG--
extra : transplant_source : eY%E9%C2%E4%D6%D4h%04%F0%EEFbX%8F%06%3C%C8c%7E
2016-04-07 14:43:39 +08:00
348c4c37ff
Bug 1256773 - eslint issues fix for devtools/client/webconsole/panel.js. r=lclark
2016-04-06 15:35:00 +02:00
92b18b36e8
Bug 1257246: Update eslint rules for eslint 2. r=MattN
...
Rename the rules that ESLint 2 no longer supports to the new names. Ignore the
microformat test suite as it is external code.
MozReview-Commit-ID: BgIxFERjHp1
--HG--
extra : rebase_source : 9f02a87f9a843b427b021caa72db9eb766287151
extra : histedit_source : 954abc7e447ac6cdd36290ade7adec626f4fe4fb
2016-04-05 11:33:12 -07:00
88915017a0
Bug 1250104 - Import the "jsesc" library for escaping JavaScript strings. r=rnewman
...
--HG--
extra : rebase_source : 4aa4b917473d8a6d3ca9796c1bbb9d9d59b7b73a
2016-02-24 15:40:55 +01:00
781ed5c343
Bug 1257173 - Make JSON viewer code eslint clean; r=linclark
...
MozReview-Commit-ID: LUzs6Pb4c3z
--HG--
extra : rebase_source : 72554e907dd29bb5ab60ed8b0b4c29facf1d4a85
2016-03-17 22:26:53 -07:00
fbafa60ad1
Bug 1255799 - make devtools/client/webconsole eslint-clean; r=odvarko
...
MozReview-Commit-ID: AnaXFFHlNLM
2016-03-16 08:16:00 +01:00
a80b3e7f67
Merge m-c to fx-team, a=merge
...
MozReview-Commit-ID: FyYG71q4yxf
2016-03-08 16:09:09 -08:00
ac0ad4fb40
Bug 1245649 - ignore readability JS files when running eslint, rs=implied-by-mossop
...
MozReview-Commit-ID: JdD35U8ZKvu
2016-03-08 17:00:47 +00:00
db9a40ca42
Bug 1238079 - remove the desktop web runtime; r=fabrice,mossop,gps,jryans,jmaher,marco
2016-03-07 13:33:12 -08:00
138604079b
Bug 1252099 - Final eslint cleanups in devtools/client/inspector/markup/test; r=miker
...
Many event-bubble tests had max-len issues that would have been really
awkward to fix by wrapping the lines. So I decided to disable eslint for
those lines instead.
This patch fixes the last remaining eslint issues and un-ignores the
directory in .eslintignore.
MozReview-Commit-ID: KQ8qtrFceaf
--HG--
extra : rebase_source : d907de27c9d866af174ac8135f8317520c4d87a2
2016-03-02 16:14:16 +01:00
ffdbd09825
Bug 1245875 - Remove Tilt from tree. r=vporof,jwalker
2016-03-03 02:27:22 -08:00
2ece6215a9
Bug 1235869 - Remove web runtime from android. r=myk
2016-02-29 10:31:00 +01:00
d3e1f74458
Bug 1250046 - Remove Shumway core files. r=till
2016-02-23 18:07:05 -06:00
d34912b8e7
Bug 1251916 - Use standard JavaScript features in toolkit/components/passwordmgr to pass eslint checks: enable eslint. r=MattN
...
MozReview-Commit-ID: F8nvRExCbff
--HG--
extra : rebase_source : 07d5a9136de52a2af8f8591884f564f7c3284299
extra : amend_source : 5762ef9d2ddc1d1023a68a411a2f5584d0ee15e1
2016-02-28 14:12:00 -08:00
979f65c7b2
Bug 1251748 - Remove eslint exclusion of removed pocket directory. r=mixedpuppy
...
MozReview-Commit-ID: HwYV5HYkGYL
2016-02-26 23:22:03 +01:00
5b9b9eda76
Bug 1251720 - Remove Storage Inspector directory from .eslintignore. r=pbro
...
MozReview-Commit-ID: 1J0FJcnF69v
2016-02-26 21:54:09 +01:00
1b22811473
Backed out changeset 26bbd4cee816 (bug 1250104) because the test it added is failing
...
MozReview-Commit-ID: 5RWr4L5CzV2
2016-02-26 09:52:24 -08:00
779b41d21f
Bug 1250104 - Import the "jsesc" library for escaping JavaScript strings. r=rnewman
2016-02-24 15:40:55 +01:00
3e2897155c
Bug 1242898 - Clean devtools/client/animationinspector of eslint errors; r=me
...
MozReview-Commit-ID: 8kRnACID8A6
2016-02-26 12:55:57 +01:00
a31b063cce
Bug 1246677 - 7 - Clean remaining ruleview and tests eslint warnings; r=jdescottes
...
MozReview-Commit-ID: BcyEv4fUWJZ
--HG--
extra : rebase_source : d589e9df51222df10db1e2095f5018d8c44bcb5a
2016-02-23 17:09:01 +01:00
b92db8e975
Backed out 10 changesets (bug 1246677) for causing frequent OSX browser_rules_completion-existing-property_01.js failures (10.6 and 10.10).
...
Backed out changeset a6d3a7a5e4ea (bug 1246677)
Backed out changeset 5dcb51fcef15 (bug 1246677)
Backed out changeset e450c5329a06 (bug 1246677)
Backed out changeset a65e8badc4c4 (bug 1246677)
Backed out changeset 0cdde48161bb (bug 1246677)
Backed out changeset bab3de413d37 (bug 1246677)
Backed out changeset e4f6cc6197cb (bug 1246677)
Backed out changeset 34e6b56e419d (bug 1246677)
Backed out changeset 5067508e5db4 (bug 1246677)
Backed out changeset 913b4129466e (bug 1246677)
2016-02-24 21:04:31 -05:00
e8e084446b
Bug 1246677 - 7 - Clean remaining ruleview and tests eslint warnings; r=jdescottes
...
MozReview-Commit-ID: BcyEv4fUWJZ
--HG--
extra : rebase_source : cb63ed3c966567fe298bf67cafdbf08e36118712
2016-02-23 17:09:01 +01:00
688e1344df
Bug 1245916: Add additional browser window scripts to eslint globals. r=felipe
...
This adds more of the scripts that browser.js relies on and also makes
browser-chrome head files import the browser.js globals.
The MOZ_JSDOWNLOADS block in contentAreaUtils only seems to hide a single
function, I don't see any need to keep hiding that now we're on by default.
MozReview-Commit-ID: 5zvF3JtJrZG
--HG--
extra : rebase_source : 94daff602b51d7ad57a24872d9eba9b304cf2da9
extra : source : b554c7ce41c42f16c2279ae88fd9567da7509bff
2016-02-05 12:16:39 -08:00
9d6c28bf7c
Bug 1245916: XBL bindings should support global declarations in comments. r=miker
...
To properly lint XBL files we need to support things like import-globals-from
and other ESlint comment directives so we have to pass comments through to the
code blocks that ESlint parses. Unfortunately the way the XBL processor works
now is by passing a separate code block for every method/property/etc. in the
XBL and ESlint doesn't retain state across the blocks so we would have to prefix
every block with every comment. Instead this change makes us output just a
single block that roughly looks like this:
<comments>
var bindings = {
"<binding-id>": {
<binding-part-name>: function() { ... }
}
}
This has some interesting bonuses. Defining the same ID twice will cause a lint
failure. Same for the same field in a binding. The line mapping is a little
harder and there are still a few lines that won't map directly back to the
original file but they should be rare cases. The only downside is that since
some bindings have the same binding declared differently for different platforms
we have to exclude those from linting for now.
MozReview-Commit-ID: CAsPt5dtf6T
--HG--
extra : rebase_source : 91a60ef0359ef53093fe197ed63dbc4e1a9f10a5
extra : source : 01675e4828b524c04a9057d68b41e9cc01ca1bb9
2016-02-05 12:13:34 -08:00
9dc941a05d
Backed out 5 changesets (bug 1245916) for browser-chrome and devtools bustages
...
CLOSED TREE
Backed out changeset 70eca07367f4 (bug 1245916)
Backed out changeset 04c1740aa499 (bug 1245916)
Backed out changeset b554c7ce41c4 (bug 1245916)
Backed out changeset 01675e4828b5 (bug 1245916)
Backed out changeset 878db4caf845 (bug 1245916)
2016-02-15 13:58:27 -08:00
8f0976db4f
Bug 1245916: Add additional browser window scripts to eslint globals. r=felipe
...
This adds more of the scripts that browser.js relies on and also makes
browser-chrome head files import the browser.js globals.
The MOZ_JSDOWNLOADS block in contentAreaUtils only seems to hide a single
function, I don't see any need to keep hiding that now we're on by default.
MozReview-Commit-ID: 5zvF3JtJrZG
--HG--
extra : rebase_source : a99f752b053765b621cf03965bda0c586a9eb1cb
2016-02-05 12:16:39 -08:00
5425cecf02
Bug 1245916: XBL bindings should support global declarations in comments. r=miker
...
To properly lint XBL files we need to support things like import-globals-from
and other ESlint comment directives so we have to pass comments through to the
code blocks that ESlint parses. Unfortunately the way the XBL processor works
now is by passing a separate code block for every method/property/etc. in the
XBL and ESlint doesn't retain state across the blocks so we would have to prefix
every block with every comment. Instead this change makes us output just a
single block that roughly looks like this:
<comments>
var bindings = {
"<binding-id>": {
<binding-part-name>: function() { ... }
}
}
This has some interesting bonuses. Defining the same ID twice will cause a lint
failure. Same for the same field in a binding. The line mapping is a little
harder and there are still a few lines that won't map directly back to the
original file but they should be rare cases. The only downside is that since
some bindings have the same binding declared differently for different platforms
we have to exclude those from linting for now.
MozReview-Commit-ID: CAsPt5dtf6T
--HG--
extra : rebase_source : 700db61686d5eac3f05f758ad1ce505bcdb6aa7f
2016-02-05 12:13:34 -08:00
1b8fd05302
Bug 1246591 - fix moz.build file and .eslintignore, r=MattN
...
--HG--
extra : commitid : JDnRUikojj9
extra : rebase_source : 7075c06b2ef03490728d752a8c754c97e5ed75dd
2016-02-08 12:58:28 +00:00
02105f3428
Bug 1244755 - 3 - Remove CPOW usages and eslint warnings from devtools/client/inspector/layout; r=miker
...
--HG--
extra : commitid : C78quZjX7oH
extra : rebase_source : 86d67bf697d50ed162ae9c01d96329db3d87bcae
extra : histedit_source : 97e16f53f0c63e8265e603841cb73d751f74e69e
2016-02-04 20:56:32 +01:00
135346b144
Bug 1245496 - Fix eslint errors in about:debugging. r=janx
2016-02-04 20:10:08 +00:00
9397ebc869
Bug 1242977 - Make services eslintable. r=markh
...
--HG--
extra : rebase_source : 55938ea80a97dc92df10c073cc45c54ff4cb94c7
2016-02-02 10:37:50 +08:00
2c8e61ac71
Bug 1240183 - make styleeditor eslint-clean; r=pbro
2016-01-29 08:25:26 -07:00
6a47f9e3eb
Bug 1090880 - Remove FUEL.r=mak
...
--HG--
extra : commitid : C5SfTW1i0bJ
2016-01-28 16:47:26 +01:00
92b2943e68
Merge mozilla-central to mozilla-inbound
2016-01-27 12:10:56 +01:00
7ccd56ad60
Bug 1242254 - Enable initial set of eslint rules for PSM. r=dkeeler
...
These rules are copied from toolkit/.eslintrc (with non-passing rules excluded and previously commented out and passing rules included).
--HG--
extra : rebase_source : 0afa42350cc961cbb3cf6d985b3978f4dc5d3dcb
2016-01-24 02:35:36 -08:00
985beb4e9c
Bug 1242689 - Fix eslint errors in devtools/client/*.js and un-ignore the files; r=tromey
...
--HG--
extra : commitid : 76W5rnBhXFZ
extra : rebase_source : b8ab20a08648924fe8d508efed76ae46a0d99b1a
extra : histedit_source : 9e56a71166fc5017eaa22ad5aedccaa5d585ad68%2C6dc936e4406a7930ea0419b199c2f71f0fe94911
2016-01-26 10:53:45 +01:00
9f804b7b10
Bug 1242278 - Eslint cleanup of Inspector markup view r=pbro
2016-01-25 15:00:04 -05:00
3f6801477a
Bug 1242137 - Fix eslint errors in /browser/components/customizableui. r=gijs
...
--HG--
extra : commitid : CTMv8KOMjRK
extra : rebase_source : 768fb80e4652c1f0e14eea9e32da8eff795f1659
extra : amend_source : bd695a57c00c8004b048ccd4673465d66bea22c6
extra : histedit_source : ca0c6fcb719d0e7f0895de1bd429fa9804833f65
2016-01-23 14:55:27 -05:00
2dbe57ccdf
Bug 1241993 - Fix eslint errors in nsBrowserGlue.js. r=gijs
...
--HG--
extra : commitid : 5XwsMNzJWOo
extra : rebase_source : 979ff3d416d2e56defbcae2416a33b2662c2d543
extra : amend_source : 8388277586649e30da71f469eab172b647e76265
extra : histedit_source : 39b723f2eeaa1aee216c80bc637994a0a2089881
2016-01-22 15:48:20 -05:00
8bcdb781ff
Bug 1242125 - Fix eslint errors in /browser/components/uitour. r=mattn
...
--HG--
extra : commitid : 9YOFmXUhUj9
2016-01-23 19:46:10 -05:00
ef6c115cda
Bug 1200639 - part 0: fix eslint issues in nsBrowserContentHandler.js, r=jaws
...
--HG--
extra : commitid : KiJuaeKR5Wl
extra : rebase_source : 7b09496e783d3c87b2c602314b3efc52e8e4a852
2016-01-19 22:03:11 +00:00
1f6d47b1c1
Bug 1213651 - Avoid server round-trips when displaying animated dom nodes; r=tromey
...
The main change here is that nodeFronts that have already been displayed
in the timeline are stored in a WeakMap so they can be retrieved from it
next time they're displayed and avoid a server-side round trip which, in
turn, causes the UI to flicker.
The other change is that now, it is possible to tell the animations actor
what is the current walker actor, which allows animation player actors to
directly send the NodeActor ID as part of their forms. Which, in most cases,
completely eliminates the server round-trip, because the corresponding
NodeFronts are already known on the client, so we get them from there.
The last change done here is that AnimationTargetNode now becomes a thin
wrapper on top of the new DomNodePreview component that was extracted so
it can be reused in other places.
--HG--
extra : commitid : EBVS63soQOi
extra : rebase_source : ad57513f53bc9d8d3250deb0e5a3cd3817d5631b
extra : histedit_source : 6319eafeb82f34d5cfeff1f175483c47ff71725b%2C5a2b6464611eada9deb3351bbf3c2711cecf1cff
2016-01-21 13:19:58 +01:00
7eb562e238
Bug 1230471 - Basic eslint fixes in places. r=mconley
...
--HG--
extra : commitid : 3qDaDd3cKSc
extra : rebase_source : 8dc99f1b7dc0bb7bb7b9059ff4d8527685a50291
2015-12-10 06:46:49 -05:00
154be33ae3
Bug 1240091 - Enable linting on more toolkit modules. r=Mossop
2016-01-15 19:20:44 +01:00
c7a6910039
Bug 1232707 - Build changes to support Loop imported as an add-on. r=mikedeboer,r=glandium
2016-01-14 17:53:32 +00:00
f27556ce7d
Bug 1231956: Add devtools to .eslintignore. r=pbrosset
...
Devtools has a lot of eslint failures right now that would block us from turning
on compile time eslint checks in bug 1229588. For now I'd like to just ignore
the directory and then you can work to clean up the warnings and re-enable
checks at whatever pace you like.
--HG--
extra : rebase_source : fa20216cecf457081fc6fc65a974a73b358d1ae2
2016-01-11 14:28:54 -08:00
a1dcc24776
Bug 1238781: Add pre-processed pref file to .eslintignore. r=felipe
...
--HG--
extra : commitid : FulAh3Xj577
extra : rebase_source : 11cf6c7805968ae95428759148414211300c72c3
2016-01-11 15:35:50 -08:00
99e46fd0e0
Bug 1237340: Fix browser and toolkit eslint failures. r=Felipe
...
--HG--
extra : rebase_source : 3e1098fe6d387bed1edcad365e318c484e8989ea
2016-01-06 10:10:35 -08:00
8d948cbdfc
Bug 1230776: Support scripts from HTML files in eslint. r=gps
...
Also removes related unused variables in mach_commands.py.
--HG--
extra : commitid : IiDVMuEZtA5
extra : rebase_source : 575a51dd0ad5450323b4da5f441f8e5d721e41d6
2015-12-05 13:17:49 -08:00
c652fdb86e
Bug 1233492 - make browser/experiments eslintable, r=felipe
...
--HG--
extra : commitid : AlqcGlqXwrj
extra : rebase_source : 2daaa302b04cef72b173265dccdba55a538e58eb
2015-12-17 19:42:24 +00:00
2a29a25860
Bug 1233470 - make browser/modules eslintable, r=Mossop
...
--HG--
extra : commitid : IZkQYhmLl9V
extra : rebase_source : 82bd0ac1e9f3b3267d60d127758fa5771a5e9fc9
extra : amend_source : aa17ba3c05cd56840df3c986ba04221beeac2026
2015-12-17 18:31:08 +00:00
92dfb90a5f
Back out the videocontrols piece of bug 1231828 due to b2g breakage and add to the ignore list. r=backout
...
--HG--
extra : commitid : 82kdyIUHBLg
extra : rebase_source : 0fb71c46271e8616473c751d19845e13df5e7eea
2015-12-16 12:45:58 -08:00
b9206ee742
Bug 1229859 - Massively reduce the number of eslint errors in devtools by ignoring lib files, adding missing .eslintrc files and making some rules be warnings; r=Mossop
...
--HG--
extra : commitid : F4M9s89to3Y
extra : rebase_source : 768a99038b43f548d8e0f88248d1be1fe7e5c579
extra : histedit_source : 619e1e7f909a09a7f5731ad8cef9e9a714d76b5e%2Ca78d84e263764af29e9e9e42f419f8189b223d8c
2015-12-10 15:46:32 -05:00
865238c5a1
Bug 1230861 - remove add-ons manager from ESLint ignore file. r=mossop
...
--HG--
extra : transplant_source : B%C5/%B6%0E5H%89n%B2%CA%5E%9F%F7%0A%40_%11%C8%7C
2015-12-06 17:59:36 -08:00
1006b4755f
Bug 1230549 - Storage should pass more eslint rules. r=yoric
...
--HG--
extra : commitid : 9FE8bR3AhsJ
extra : rebase_source : 1d65cc419e9375facb1dc7265e05ee84195153e7
2015-12-04 17:00:03 +01:00
b729a30707
Bug 1229874: Part 3 - Enable ESLint in WebExtension code. r=billm
...
The base .eslintrc is essentially a merge of the root Toolkit .eslintrc and
the devtools .eslintrc, with some minor changes to match our prevalent style.
For the most enforces the coding styles that we've been using most
consistently. There are a couple of significant differences, though:
* The rule for opening brace alignment can only be applied globally, and
doesn't make exceptions for top-level functions. I chose to turn it on, and
change the brace style of existing top-level functions that violated it,
since the rule seemed worth using, and that's the direction most Toolkit JS
code has been headed anyway.
* The rule for switch/case statements requires an added indentation level for
case statements. Most of our switch statements did not use an extra level
of indentation, and I initially wrote the rule to enforce that style, until
I came across case statements that used blocks, and required the extra
indentation level for sanity.
--HG--
rename : devtools/.eslintrc => toolkit/components/extensions/.eslintrc
extra : commitid : 4aDZOi5MNPc
extra : rebase_source : f34ba43aeb8046a0c971cb76b76410497bd12b42
extra : source : 2a7eb4ef7b375e5fd52d843ca206a071367a6475
2015-12-02 16:58:53 -08:00
J. Ryan Stinnett
Julian Descottes
Tom Tromey
Wes Kocher
Andrew Halberstadt
Carsten "Tomcat" Book
Tom Tromey
gasolin
Ryan VanderMeulen
Jason Laster
Patrick Brosset
Tim Nguyen
Jarda Snajdr
Phil
Dave Townsend
Alexis Métaireau
Jan Odvarko
Gijs Kruitbosch
Myk Melez
Alexandre Poirot
Brendan Dahl
Yury Delendik
Sebastian Hengst
Phil Ringnalda
Joe Whitfield-Seed
Hector Zhao
chaithanya
Cykesiopka
Gabriel Luong
Jared Wein
Marco Bonardo
Georg Fritzsche
Mark Banner
Kris Maglione
Robert Helmer