Canvas only has one context, and that assumption is pretty baked into
the code, so having an API that pretends otherwise is silly.
Differential Revision: https://phabricator.services.mozilla.com/D88990
Implement GLContextEGL::FindVisual() as a EGL counterpart of GLContextGLX::FindVisual() used
by GLX.
We need to make sure that GdkWindow uses the same visual as GL framebuffer we use for it.
That was already implemented for GLX backend (Bug 1478454).
The visual match is implemented by visual parameter at CreateConfig()/CreateConfigScreen() routines and when it's non-zero,
try to find exact match based on visual ID.
Differential Revision: https://phabricator.services.mozilla.com/D87636
When GLX Vsync source is created along EGL contexts, NVIDIA drivers refuse to make any EGL content current.
So disable GLX Vsync source creation when EGL context is used.
Differential Revision: https://phabricator.services.mozilla.com/D87634
appVersion is no longer used with modern config.
Also realised we could remove 'this._metaData' in the search service as it isn't used now.
Tidied up the load*FromCache functions as we don't need to pass the cache to them - just the engines. This makes the cache use clearer.
Also simplified getting the verified attribute when finding the default engine.
Depends on D88277
Differential Revision: https://phabricator.services.mozilla.com/D88462
test_json_cache_broken.js is a nicer test that doesn't need reInit and tests more, so remove the older test_require_engines_in_cache.js.
Differential Revision: https://phabricator.services.mozilla.com/D88275
reInit is unsafe as it completely removes the existing data before reloading. If something interrupts the process that can cause dataloss.
_maybeReloadEngines is safer as it does changes progressively, it also now handles removing engines, which it didn't before.
Depends on D88023
Differential Revision: https://phabricator.services.mozilla.com/D88272
I had written this on one of my attempts to fix the missing text on
reddit when printing, but I think it's worth landing anyways not only
because it's slightly cleaner, but because it avoids the virtual call
and style checks when we're not printing.
This should be an idempotent change.
Differential Revision: https://phabricator.services.mozilla.com/D89171
The browserId is stable across navigations, but the browsing context
itself might not be if we are not preserving the BC across navigations.
It might seem like this change would mean that we'd start getting notified
about events for subframes, but the old code was passing in the BC of the
top level frame anyways, so that's not a change in behavior.
Differential Revision: https://phabricator.services.mozilla.com/D89179
Bug 1659539 caused the unit tests of this class to suddenly start running on Linux; it failed with a type error that suggests this test has never really properly worked, at least not with the version of Mercurial we're using in CI (`unsupported changeid '0' of type <type 'unicode'>`). The class itself isn't used anywhere besides these tests, so just delete the entire class.
Differential Revision: https://phabricator.services.mozilla.com/D89205
The bug here occurs when we:
a) Trial-inline A into B, creating an ICScript owned by B with a pointer to A's JitScript.
b) Perform a compacting GC, discarding the JitScript for A, but preserving the JitScript for B (because it is on the stack).
c) Create a new JitScript for A.
d) Warp-compile B, without hitting the B->A trial-inlined call IC.
In this case, the `JitScript*` stored in the ICScript created in `a)` is dangling, and does not match the JitScript created in `c)`.
The easy way to fix this is to not store a `JitScript*` here in the first place. We only use `ICScript::jitScript_` to:
a) Tell whether the ICScript is inlined, which can be done more easily by looking at the depth.
b) Find the `FallbackICStubSpace` for non-inlined ICScripts.
If we use the depth to tell when an ICScript is inlined, then we don't need a pointer to find the owning JitScript (and therefore its stub space) for non-inlined ICScripts. Non-inlined ICScripts are embedded inside a JitScript, so we can compute the offset directly.
Differential Revision: https://phabricator.services.mozilla.com/D88690
Ting-Yu Lin
Ryan VanderMeulen
Mark Hammond
Emma Malysz
Erik Nordin
Mihai Alexandru Michis
Mark Striemer
Emily McDonough
Emilio Cobos Álvarez
Kagami Sascha Rosylight
Noemi Erli
Gijs Kruitbosch
Martin Stransky
Daniel Holbert
Tom Ritter
Jeff Gilbert
Mark Banner
Karl Tomlinson
Agi Sferro
Geoff Brown
owlishDeveloper
Andrew McCreight
Ricky Stewart
James Willcox
Iain Ireland
Anny Gakhokidze