Граф коммитов

725341 Коммитов

Автор SHA1 Сообщение Дата
Rouslan Solomakhin 1ba1f0f372 Bug 1662543 [wpt PR 25338] - [Web Payment] Very long instrumentId string test., a=testonly
Automatic update from web-platform-tests
[Web Payment] Very long instrumentId string test.

This patch adds a test for JSON serialization of a very long string
being passed into PaymentRequest API.

Bug: 1110324, 1115091
Change-Id: Ia6690b2f41ff99190afed4431854515b167056b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348411
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Nick Burris <nburris@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#797165}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359155
Cr-Commit-Position: refs/heads/master@{#803617}

--

wpt-commits: a7831be8db72dd936070f2c221a7f9f3c5a0c73b
wpt-pr: 25338
2020-09-08 10:31:27 +00:00
Butkovits Atila eaa0d5b024 Backed out changeset b5d39e472f05 (bug 1658881) for failures at test_docwrite_meta.html. CLOSED TREE 2020-09-08 12:35:30 +03:00
Timothy Nikkel 47eb2ac8d0 Bug 1663537. Use overlay scrollbars in a few reftests. r=kats
All of these reftests end up using a minimum scale with layout/classic scrollbars. (They hit the assert from the patch in bug 1663534.)

Some of them are only written with overlay scrollbars in mind (for example overflow-hidden-region-with-negative-left-positioned-element.html which I looked at in detail).

The change that causes them to fail is the code in nsHTMLScrollFrame::TryLayout that decides if we need scrollbars. Before desktop zooming scrollbars we compared the visual viewport size and the scrolled rect size. With desktop zooming scrollbars we compare the (layout) scrollport and the scrolled rect to determine if we need regular scrollbars and then compare the visual viewport size to the (layout) scrollport to determine if we need scrollbars to scroll the visual viewport inside the scrollport. Then can get different results.

Differential Revision: https://phabricator.services.mozilla.com/D89407
2020-09-08 08:27:30 +00:00
Timothy Nikkel a7adf2b1c8 Bug 1663532. Support setting/clearing prefs that don't have a default value in the reftest harness. r=kats
In order to fix bug 1657822 we need to run some reftests with the pref ui.useOverlayScrollbars. This preference doesn't have a default value (it is not set by anything on desktop, it appears only in mobile/android/app/mobile.js and when we set the pref for some mochitests, the look and feel code looks at this pref, which is how we almost (?) always query for overlay scrollbars.). The reftest harness doesn't currently handle this because it gets the current value first and doesn't expect the pref to not exist.

Differential Revision: https://phabricator.services.mozilla.com/D89399
2020-09-08 08:45:56 +00:00
Jonathan Kew e7ed767ca6 Bug 1663230 - Ensure MergeCharactersInTextRun clears the old glyph record before storing new details; also prefer simple glyph storage where possible. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D89380
2020-09-08 08:47:40 +00:00
Timothy Nikkel 41900951e9 Bug 1663535. Handle scroll snapping with desktop zooming scrollbars. r=kats
If we need to snap we just don't use the desktop zooming scrollbar path.

A quick look into the scroll snapping code looks like it uses layout only aware things. This should be good enough for now, we can look into supporting scroll snap + pinch zoom later if we need to.

Differential Revision: https://phabricator.services.mozilla.com/D89400
2020-09-08 08:08:32 +00:00
Emilio Cobos Álvarez 992e6196f4 Bug 1658881 - When failing to create a channel and an image request, make sure to set the image blocking status appropriately. r=tnikkel
This is the same status as we do for known no-data protocols here:

  https://searchfox.org/mozilla-central/rev/ac142717cc067d875e83e4b1316f004f6e063a46/dom/base/nsNoDataProtocolContentPolicy.cpp#59

This ensures we treat these two cases the same.

Differential Revision: https://phabricator.services.mozilla.com/D89382
2020-09-07 23:04:41 +00:00
Timothy Nikkel 39905f40a3 Bug 1663537. Fix layout/base/tests/test_scroll_event_ordering.html to work with desktop zooming scrollbars. r=kats
sendKey uses our new relative scroll path that does the scroll by the apz. But we don't have any scroll event ordering expectations when apz is doing the scroll. We trade lossing those expectations for smoother apz scrolling.

So change the test to use a method that doesn't use our new relative apz scroll path and goes back to main thread scrolling.

Differential Revision: https://phabricator.services.mozilla.com/D89402
2020-09-08 08:12:25 +00:00
Simon Giesecke ec62d45a35 Bug 1660751 - Use bare const char* in HandleError signature to reduce size of calling code. r=dom-workers-and-storage-reviewers,janv
Not that this is deliberately de-optimizing performance: Now, the HandleError
functions need to use the nsDependentCString constructor to determine the
length of the literals at run-time, since that's lost. While passing that
in addition would reduce the binary size wins again, and is not necessary,
since this code is only called in error situations, which are not
performance-critical.

Differential Revision: https://phabricator.services.mozilla.com/D89148
2020-09-08 07:40:30 +00:00
Simon Giesecke ffb37d08c1 Bug 1660751 - Make HandleError function MOZ_NEVER_INLINE. r=janv,dom-workers-and-storage-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D89147
2020-09-02 15:03:06 +00:00
Jan Varga ebcfb83228 Bug 1660751 - QM: Log failures in the browser console; r=dom-workers-and-storage-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D88004
2020-09-08 07:40:46 +00:00
Marco Bonardo 19a5cf747e Bug 1661949 - Can't search from the Address Bar with ? if keyword.enabled = false. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D89143
2020-09-07 22:07:28 +00:00
Christoph Kerschbaumer b2716c233e Bug 1663396: Test HTTPS-Only-Mode top-level background request not leaking sensitive info r=JulianWels
Differential Revision: https://phabricator.services.mozilla.com/D89386
2020-09-08 06:41:08 +00:00
Sylvestre Ledru ba8d39bfb3 Bug 1617369 - Reformat recent rust changes with rustfmt r=emilio
# ignore-this-changeset

Depends on D89392

Differential Revision: https://phabricator.services.mozilla.com/D89393
2020-09-07 19:57:24 +00:00
Sylvestre Ledru c320561565 Bug 1519636 - Reformat recent changes to the Google coding style r=andi
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D89392
2020-09-08 04:32:00 +00:00
Brad Werth fc3cb8fd99 Bug 1661283 Part 6: Add a test of NodeActor.isScrollable on various elements. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D88683
2020-08-31 17:56:24 +00:00
Brad Werth 8ca8fd6962 Bug 1661283 Part 5: Add a test of GetOverflowingChildrenOfElement on the body element. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D88682
2020-09-04 13:15:08 +00:00
Brad Werth ccf873b003 Bug 1661283 Part 4: Make NodeActor.initialize respect overflow debugging pref. r=gl
This also reuses a cached result of isScrollable, to avoid a second call.

Differential Revision: https://phabricator.services.mozilla.com/D88507
2020-09-02 23:52:37 +00:00
Brad Werth 75102cef12 Bug 1661283 Part 3: Make NodeActor.isScrollable use the new Element.hasVisibleScrollbars method. r=gl
This removes the need for the document/dom walk.

Differential Revision: https://phabricator.services.mozilla.com/D88506
2020-08-28 22:18:34 +00:00
Brad Werth fa457d1e59 Bug 1661283 Part 2: Make InspectorUtils::GetOverflowingChildrenOfElement correctly handle the body element. r=emilio
This requires using the same Element::GetScrollFrame logic used in the new
Element::HasVisibleScrollbars method. This also makes GetScrollFrame public,
so that InspectorUtils can use it.

Differential Revision: https://phabricator.services.mozilla.com/D88505
2020-09-04 13:15:36 +00:00
Brad Werth 42d0bcb4ee Bug 1661283 Part 1: Add a ChromeOnly method to Element for getting scrollbar visibility. r=emilio
This will be used to support the display of "scroll" badges in devtools.

Differential Revision: https://phabricator.services.mozilla.com/D88504
2020-08-28 22:17:56 +00:00
Jan Varga d3df072168 Bug 1662087 - Replace explicit error handling involving `mozilla::Result::isErr` with IDB_TRY/IDB_TRY_VAR in ActorsChild.cpp; r=dom-workers-and-storage-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D88831
2020-09-07 15:52:52 +00:00
Jan Varga 30a12fc766 Bug 1662087 - Replace explicit error handling involving `mozilla::Result::isErr` with IDB_TRY/IDB_TRY_VAR in IDBObjectStore.cpp; r=dom-workers-and-storage-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D88830
2020-09-07 15:52:39 +00:00
Jan Varga 87245d7d42 Bug 1662087 - Replace explicit error handling involving `mozilla::Result::isErr` with IDB_TRY/IDB_TRY_VAR in IDBDatabase.cpp; r=dom-workers-and-storage-reviewers,sg,ttung
Differential Revision: https://phabricator.services.mozilla.com/D88829
2020-09-07 15:52:27 +00:00
Jan Varga 2620d5fb0d Bug 1662087 - Replace explicit error handling involving `mozilla::Result::isErr` with IDB_TRY/IDB_TRY_VAR in IndexedDatabaseManager.cpp; r=dom-workers-and-storage-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D88824
2020-09-07 15:52:19 +00:00
Andrew Osmond c45c3ac881 Bug 1662836 - Expose detailed initialization failure reason for WebRender. r=kvark
We don't know why we see initialization failures in the telemetry which
makes it hard to investigate why users aren't getting WebRender and
instead fallback to basic. Let's expose the detailed error message
WebRender already generates and puts in the critical log.

Differential Revision: https://phabricator.services.mozilla.com/D89185
2020-09-08 02:03:26 +00:00
Jan Varga 0acd64c691 Bug 1662119 - Replace MOZ_TRY with IDB_TRY; r=dom-workers-and-storage-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D88832
2020-09-07 12:24:50 +00:00
Ryan Kelly 8d21f4598d Bug 1663541 - don't try to write `uid` to storage in `updateUserAccountData`. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D89405
2020-09-08 01:19:56 +00:00
Daisuke Akatsuka 8216959c5d Bug 1661622: See newState instead of old state. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D89359
2020-09-08 01:07:51 +00:00
Jan Varga e5ee46c338 Bug 1662097 - QM_TRY/QM_TRY_VAR cleanup functions should have access to tryTempResult; r=dom-workers-and-storage-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D88807
2020-09-07 12:24:33 +00:00
Mike Hommey aa86bba7ac Bug 1662601 - Remove fileid. r=gsvelto
The last thing that was using fileid was fix-stacks, which, as of bug
1662037, doesn't anymore.

Differential Revision: https://phabricator.services.mozilla.com/D89076
2020-09-05 05:31:28 +00:00
Gerald Squelart 5507ddc4c5 Bug 1660458 - Improve TLS initialization and usage, remove inline-able function-static init - r=canaltinova
The profiler should guarantee that TLS initializations are done only once (from `profiler_init()`), so there is no need to potentially do it at every TLS access.
Instead, the initialization functions set the TLS states once (to `Initialized` or `Unavailable`, depending on the underlying TLS initialization success), and later accesses to this effectively-read-only flag can be done without thread synchronization.
This reduces the generated code size.

There are also DEBUG-build checks that no accesses are done before initialization; this is theoretically racy, but it's only used to detect too-early accesses in DEBUG builds, which should never happen anyway.

Differential Revision: https://phabricator.services.mozilla.com/D89338
2020-09-07 23:07:38 +00:00
Nicholas Nethercote 5abadeda43 Bug 1662646 - Remove `RendererOptions::texture_cache_{eviction_threshold_bytes,max_evictions_per_frame}`. r=gw
They're never set to anything other than the default, so we can hardwire them
as constants.

Depends on D89103

Differential Revision: https://phabricator.services.mozilla.com/D89104
2020-09-07 00:22:44 +00:00
Nicholas Nethercote 2bdcfc19ce Bug 1662646 - Remove `RendererOptions::max_instance_buffer_size`. r=gw
It's never set to anything other than the default, so we can hardwire it as a
constant.

Depends on D89102

Differential Revision: https://phabricator.services.mozilla.com/D89103
2020-09-07 00:22:31 +00:00
Nicholas Nethercote 716038f375 Bug 1662646 - Remove `RendererOptions::max_glyph_cache_size`. r=gw
It's never set to anything other than the default, so we can hardwire it as a
constant.

`GlyphCache::max_bytes_used` is also removed.

Depends on D89101

Differential Revision: https://phabricator.services.mozilla.com/D89102
2020-09-07 00:22:18 +00:00
Nicholas Nethercote f6d6d8f69c Bug 1662646 - Remove `RendererOptions::batch_lookback_count`. r=gw
It's never set to anything other than the default, so we can hardwire it as a
constant.

Depends on D89100

Differential Revision: https://phabricator.services.mozilla.com/D89101
2020-09-07 00:22:06 +00:00
Nicholas Nethercote 3885472850 Bug 1662646 - Remove the `NamedTag` trait. r=gw
It has a single impl, `GpuProfileTag`, so it's unnecessary generalisation.

This also removes type parameter from `GpuTimer`, `GpuSampler`,
`GpuFrameProfile`, and `GpuProfiler`.

Depends on D89099

Differential Revision: https://phabricator.services.mozilla.com/D89100
2020-09-07 00:21:58 +00:00
Jonathan Watt d8f2270d2a Bug 1663538. Register the new print preview UI telemetry probes for the correct process. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D89401
2020-09-07 22:59:23 +00:00
Alexandre Poirot 8dd8e4b254 Bug 1660268 - Pass list of resources instead of unique resource from ResourceWatcher. r=nchevobbe
Here, I've tried to be especially careful about replacing `return` by `continue` in the added for..loops.

Differential Revision: https://phabricator.services.mozilla.com/D87768
2020-09-07 21:13:02 +00:00
Alexandre Poirot e61c347424 Bug 1660268 - Read targetFront from resource instead of onResource*** functions. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D87767
2020-09-07 20:58:14 +00:00
Alexandre Poirot 0b62c083a6 Bug 1660268 - Read resourceType from resource instead of onResource*** functions. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D87766
2020-09-07 20:58:12 +00:00
Daisuke Akatsuka 5ee0f8ed93 Bug 1661625: Get stylesheets traits if needed. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D89339
2020-09-07 21:05:41 +00:00
Csoregi Natalia 7d48c81098 Backed out changeset ed6c3abb15c2 (bug 1652513) for node failures. CLOSED TREE 2020-09-07 23:00:52 +03:00
Gabriele Svelto d3e714d29a Bug 1659185 - Use child process crash annotations when generating hang reports; r=dmajor,froydnj
When generating a hang report we need to force a hung child process to return
its annotation via the pipe that connects it to the main process. Since the
child is not responding to regular IPC messages we force it to using
platform-specific code:

* On Windows we launch a new thread using CreateRemoteThread() that will
  invoke the code used to send the crash annotations. The Windows-specific
  code also has another slight modification: it stored the pipe used to send
  the annotations in Breakpad's minidump callback context. This patch moves it
  into the `gChildCrashAnnotationReportFd` global which is what all the other
  platforms use.
* On Linux/macOS we use a signal handler for the SIGTERM signal. It would be
  simpler to use SIGUSR1 or another signal that doesn't have special meanings,
  but those are all already in use in Gecko (either by jprof or the gcov
  machinery). We don't install SIGTERM handlers for anything else but
  obvioulsy its semantics get in the way since it's used to politely kill a
  process, and Chromium IPC also uses it for that purpose. So to tell apart
  our use of SIGTERM from a "regular" terminating SIGTERM we send a magic
  value along using sigqueue(). Our signal handler will look for it and only
  send annotations when it is set. If the magic number isn't there it will
  re-install the default SIGTERM handler and raise the signal once more which
  will lead to the process being terminated as it should be.

The patch refactors some of the code so that the PIDs and process/file handles
use platform-independent types to cut down on the amount of duplication we
have there.

Differential Revision: https://phabricator.services.mozilla.com/D87759
2020-09-07 16:02:26 +00:00
Olli Pettay f50042da80 Bug 1663216 - Have a pref to control unthrottled timers in background tabs, r=farre
Differential Revision: https://phabricator.services.mozilla.com/D89295
2020-09-07 13:23:34 +00:00
Jan Varga 7e31de8547 Bug 1662004 - Add support for nested QM_TRY/QM_TRY_VAR macros; r=dom-workers-and-storage-reviewers,sg,ttung
Differential Revision: https://phabricator.services.mozilla.com/D88764
2020-09-07 18:00:00 +00:00
Emilio Cobos Álvarez 5b825e4543 Bug 1661720 - Move monochrome detection to nsIPrinter. r=bobowen
This moves the special cases to the printing platform code instead
(where it belongs).

The SupportsMonochrome() implementation is the only thing that I found
to work for the "Microsoft Print to PDF" driver, but other similar
drivers like XPS still claim to support monochrome (even though it's not
true). This should avoid the UI getting in a bad state as described in
the bug though, so may be better?

Depends on D89306

Differential Revision: https://phabricator.services.mozilla.com/D89312
2020-09-07 18:58:48 +00:00
Henrik Skupin 3880aa3e82 Bug 1663429 - [marionette] Only throw NoSuchWindow error in "WebDriver:SwitchToWindow". r=marionette-reviewers,jgraham
There is a race condition in the "WebDriver:SwitchToWindow" command
that would throw an UnknownError instead of NoSuchWindowError when
the window gets closed at the same time as the command gets called.

Differential Revision: https://phabricator.services.mozilla.com/D89377
2020-09-07 15:29:42 +00:00
Henrik Skupin 13f06a6d95 Bug 1661390 - [remote] Use a UUID as session id for targets. r=remote-protocol-reviewers,jgraham
A session is defined as string in CDP but target specific commands
and events currently return a number based on the last used index.
This also makes it very easy to discover active sessions.

Differential Revision: https://phabricator.services.mozilla.com/D89352
2020-09-07 15:31:27 +00:00
Andrei Oprea 96d74f4b7c Bug 1652513 - Use Remote Settings groups configuration to control message lifetime and frequency r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D85136
2020-09-01 12:04:25 +00:00