6eed7c9735
Bug 1736522 - Hide titlebar button container on fullscreen on macOS. r=desktop-theme-reviewers,dao
...
This used to be done by:
9785ceff3f (l2.13)9785ceff3f (l7.12)https://phabricator.services.mozilla.com/D129173
2021-10-22 13:03:58 +00:00
972c0c1053
Bug 1701929 - Define positioning required for Mac fullscreen slide in CSS to avoid frame reconstruction. r=mstange,Gijs
...
Baseline profile: https://share.firefox.dev/3p5PgDn (jank)
Profile with just setting pinned tab position to absolute: https://share.firefox.dev/30jKR5p (jank)
Profile with just moving relative positioning to CSS: https://share.firefox.dev/3p6c5a7 (jank)
Profile with this patch: https://share.firefox.dev/3FRLmnK (no jank)
Markus said setting abspos pinned tabs would be safe as long as there were no relative-positioned ancestors in the tab overflow scrollbox. The only notable ancestor of a pinned tab is the tab arrowscrollbox itself, so there aren't any surprise ancestors here. Manual testing indicates things work fine.
I also confirmed that this patch fixes bug 1725151.
Differential Revision: https://phabricator.services.mozilla.com/D121403
2021-10-20 13:59:23 +00:00
756c14b26a
Bug 1735318 - Unify "native" vs. "fullscreen" window controls. r=desktop-theme-reviewers,dao
...
I've tested this (both with and without titlebar) in Linux, Win10,
Win11, Win7 and macOS.
* On macOS behavior doesn't change at all (since on fullscreen we didn't
show the buttons to begin with).
* Linux now shows "native" buttons on fullscreen (which is also an
improvement).
* On Windows 10/11 the sizing of the buttons is now the same when
fullscreen vs. not (which is an improvement).
* On Windows 7 we now use regular native-looking buttons (like on
windows 10) instead of the custom windowControls.png. That could be
considered a slight regression I guess, but is consistent with win10.
Differential Revision: https://phabricator.services.mozilla.com/D128196
2021-10-12 13:20:13 +00:00
87f63ab1b8
Bug 1633860: Place window control buttons on the right side on macOS when using an RTL system locale, regardless of the Firefox locale. r=mstange,emilio,harry
...
Differential Revision: https://phabricator.services.mozilla.com/D116921
2021-09-22 18:51:20 +00:00
f9a33ec80c
Bug 1730237 - Split --urlbar-box-focus-bgcolor out from --urlbar-box-bgcolor. r=desktop-theme-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D125256
2021-09-12 23:24:44 +00:00
8b10d3a89d
Bug 1693222 - Implement SelectedItem and SelectedItemText system colors. r=mstange
...
Since Highlight / HighlightText are now equivalent to the text selection
ones, remove those too.
Differential Revision: https://phabricator.services.mozilla.com/D123964
2021-09-02 11:38:01 +00:00
92fc260af2
Backed out changeset 28a0487d0291 (bug 1693222) for reftest failure on themed-widget.html. CLOSED TREE
2021-09-02 02:26:12 +03:00
c3eb845bbf
Bug 1693222 - Implement SelectedItem and SelectedItemText system colors. r=mstange
...
Since Highlight / HighlightText are now equivalent to the text selection
ones, remove those too.
Differential Revision: https://phabricator.services.mozilla.com/D123964
2021-09-01 18:21:57 +00:00
2d4da45cce
Bug 1698814 - Part 1 - Consolidate toolbar-field background color variables. r=desktop-theme-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D117028
2021-08-04 18:01:09 +00:00
4dda7bc3cd
Bug 1708428 - Apply Proton styling to the edit bookmark panel's New Folder button. r=desktop-theme-reviewers,harry
...
These styles were copied from the popupnotification's `.panel-footer > button`
CSS, with a couple of adjustments which have comments here, and skipping over
the disabled styles because this button is never disabled.
Differential Revision: https://phabricator.services.mozilla.com/D119338
2021-07-21 22:03:45 +00:00
4431dfd334
Bug 1703914 - Removed --toolbarbutton-icon-fill-opacity CSS var r=mconley,desktop-theme-reviewers,dao
...
All uses of --toolbarbutton-icon-fill-opacity have been removed.
Differential Revision: https://phabricator.services.mozilla.com/D120352
2021-07-21 20:07:56 +00:00
d63bd760de
Bug 1711261 - Increase toolbar contrast in Mac HCM. r=mstange,desktop-theme-reviewers,dao
...
This patch draws a 1px black line around the Urlbar in macOS HCM, which resembles other high contrast macOS apps. This patch only supports Light HCM mode. Since we apply the Firefox Dark lwttheme when in Dark mode, and we do not support lightweight themes in high contrast mode, significantly more work is required to implement basic support for dark HCM on Mac.
Differential Revision: https://phabricator.services.mozilla.com/D116406
2021-07-21 15:41:50 +00:00
b683e4147a
Bug 1703051, apply proton panel styling to other bookmarks dropdown and overflow menu in bookmarks toolbar r=desktop-theme-reviewers,mconley,jaws,harry
...
Differential Revision: https://phabricator.services.mozilla.com/D113200
2021-07-13 05:10:19 +00:00
7658ff3191
Backed out changeset fce7b9d54faf (bug 1703051) for failures on browser_parsable_css.js. CLOSED TREE
2021-07-12 19:56:45 +03:00
533aa0b841
Bug 1703051, apply proton panel styling to other bookmarks dropdown and overflow menu in bookmarks toolbar r=desktop-theme-reviewers,mconley,jaws,harry
...
Differential Revision: https://phabricator.services.mozilla.com/D113200
2021-07-12 15:04:05 +00:00
21cd59e32c
Bug 1719592 - Back out bug 1699419 for causing multiple tab bar background regressions. r=harry,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D119464
2021-07-09 14:19:47 +00:00
08389c68f4
Bug 1700124 - de-duplicate add (+) icons r=thecount,harry,desktop-theme-reviewers
...
* Rename toolkit's add.svg to plus.svg, use it for the zoom-in buttons and about:newtab's add icon
Differential Revision: https://phabricator.services.mozilla.com/D118627
2021-07-08 18:52:40 +00:00
201dd0ca83
Bug 1714462 - Part 3: Remove CSS rules from browser/themes using "not (-proton)" r=Gijs,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D119287
2021-07-07 20:59:03 +00:00
c0c9d4dab5
Bug 1699419 - Consolidate browser toolbar background handling. r=desktop-theme-reviewers,harry
...
This patch moves code that sets the background of the browser toolbars into
one place. It also removes some non-Proton Windows-only code rather than
updating it for this.
Differential Revision: https://phabricator.services.mozilla.com/D118658
2021-07-07 16:11:23 +00:00
ebf7203b8e
Bug 1714351 - Remove and reconcile -moz-proton-doorhangers media queries r=emalysz
...
Differential Revision: https://phabricator.services.mozilla.com/D116910
2021-06-07 20:34:33 +00:00
acba349677
Backed out changeset 03a717a6815e (bug 1714351) for causing bc failures in browser_all_files_referenced.js. CLOSED TREE
2021-06-05 03:18:11 +03:00
25ebda4edf
Bug 1714351 - Remove and reconcile -moz-proton-doorhangers media queries r=emalysz
...
Differential Revision: https://phabricator.services.mozilla.com/D116910
2021-06-04 22:39:50 +00:00
cd50b177a7
Bug 1711523 - remove private proton tracking flags in frontend modules, r=mak,emalysz,desktop-theme-reviewers,harry
...
Differential Revision: https://phabricator.services.mozilla.com/D116009
2021-05-28 19:33:38 +00:00
908ae47f34
Bug 1708334, specify toolbar-non-lwt-bgcolor for macos r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D114374
2021-05-06 19:44:02 +00:00
d6c350a859
Bug 1709335 - Stop overriding --panel-disabled-color for the address and search bars on macOS. r=harry
...
Differential Revision: https://phabricator.services.mozilla.com/D114228
2021-05-04 16:35:43 +00:00
a76b78d543
Backed out changeset e01ec8694924 (bug 1700957) as requested. CLOSED TREE
2021-04-28 18:09:01 +03:00
ce84c86379
Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D110135
2021-04-28 03:17:56 +00:00
9597a30fbb
Backed out changeset 1c362512f27b (bug 1700957) for causing failures at test_chrome_only_media_queries.html. CLOSED TREE
2021-04-28 05:55:14 +03:00
a344c0fa4c
Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D110135
2021-04-28 00:29:45 +00:00
533273efcd
Bug 1706415 - Revert Proton font-size changes for panels and modals from bug 1701920. r=Gijs
...
This also necessarily reverts some em unit changes that were introduced in bug 1706259 and
bug 1705386 to use static pixel values instead.
Differential Revision: https://phabricator.services.mozilla.com/D113382
2021-04-27 15:08:52 +00:00
3b703af54d
Bug 1703957 - Colors for dark/light/system/system-dark audited and confirmed consistent. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D113137
2021-04-26 18:50:14 +00:00
fc218d9a6f
Backed out changeset 15e19c4203af (bug 1703957) for causing issues with addressbar suggestions (Bug 1707257). a=backout
2021-04-23 22:57:45 +03:00
89a49577fc
Bug 1703957 - Colors for dark/light/system/system-dark audited and confirmed consistent. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D113137
2021-04-22 21:02:24 +00:00
d7fbf79bf9
Bug 1702144, ensure recently closed tabs button is disabled when there are none r=Gijs
...
Removes macos rule that overrides disabled css rules
Removes early return to ensure the menu is created correctly
Differential Revision: https://phabricator.services.mozilla.com/D111919
2021-04-14 21:01:46 +00:00
dc1aa9a26f
Bug 1704414 - Unfocused urlbar chiclet should look the same as Dark theme when default theme is in dark mode. r=harry,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D111920
2021-04-14 13:56:09 +00:00
4672f874be
Bug 1701920 - Assign the same font size multiplier that we use on the URL bar to all panels and subdialogs when Proton is enabled. r=Gijs
...
This also makes it so that padding in the panels and subdialogs uses em units.
Differential Revision: https://phabricator.services.mozilla.com/D111451
2021-04-13 22:53:34 +00:00
5e33449e21
Bug 1701990 - Remove Drag Space r=desktop-theme-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D111011
2021-04-11 11:42:57 +00:00
5cdffcf176
Backed out changeset 2ee25a7f42f2 (bug 1701990) for causing failures at browser_970511_undo_restore_default.js. CLOSED TREE
2021-04-10 10:50:31 +03:00
2b31de8ac1
Bug 1701990 - Remove Drag Space r=desktop-theme-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D111011
2021-04-10 06:10:15 +00:00
46a4d18412
Bug 1695702, correctly position appMenu and panels when proton enabled r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D110867
2021-04-10 00:30:34 +00:00
2c982d3c01
Bug 1703274 - Enable Proton Urlbar. r=jaws,extension-reviewers,zombie,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D110998
2021-04-09 18:20:21 +00:00
13826a4c50
Backed out changeset bd396182f84a (bug 1703274) for causing wpt failures on shape-outside-shape-arguments-000.html. CLOSED TREE
2021-04-09 17:51:48 +03:00
af19ef5dc4
Bug 1703274 - Enable Proton Urlbar. r=jaws,extension-reviewers,zombie,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D110998
2021-04-09 11:05:17 +00:00
efe5cc9385
Bug 1703651 - Proton toolbar icons should have no fill opacity by default. r=harry,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D111176
2021-04-08 20:09:06 +00:00
5ddee7313f
Bug 1698132 - Convert proton pref checks from @supports rules to media features. r=Gijs
...
This means that dynamic changes will be handled correctly, we can use
StaticPrefs, etc.
Differential Revision: https://phabricator.services.mozilla.com/D110816
2021-04-05 20:48:05 +00:00
d1a3d50480
Bug 1700622 - Move --toolbar-field-non-lwt-bgcolor to browser-custom-colors.inc.css. r=ntim
...
This causes the search bar on the Customize page to fall back to Field, which will be themed correctly. Note that if the system is in Dark mode and Firefox is in light mode, the search bar will be dark. That should be fixed by bug 1700371.
Differential Revision: https://phabricator.services.mozilla.com/D110312
2021-03-31 15:33:41 +00:00
66d4138e63
Bug 1697507 - Restyle bookmarks panel for Proton. r=desktop-theme-reviewers,harry
...
This updates the styling of the Bookmarks Panel for Proton, and also:
* Fixes menulist sizes on macOS to be 32px tall for size="large", per spec
* Makes text input elements in panels be 32px tall, per spec
Depends on D109376
Differential Revision: https://phabricator.services.mozilla.com/D109638
2021-03-30 17:51:58 +00:00
e5438a0497
Backed out 2 changesets (bug 1697507, bug 1697491) for Browser-chrome in browser/components/places/tests/browser/browser_bookmark_remove_tags.js. CLOSED TREE
...
Backed out changeset 83a561e6c1d0 (bug 1697507)
Backed out changeset 319022b89093 (bug 1697491)
2021-03-30 20:17:13 +03:00
9b813d73b9
Bug 1697507 - Restyle bookmarks panel for Proton. r=desktop-theme-reviewers,harry
...
This updates the styling of the Bookmarks Panel for Proton, and also:
* Fixes menulist sizes on macOS to be 32px tall for size="large", per spec
* Makes text input elements in panels be 32px tall, per spec
Differential Revision: https://phabricator.services.mozilla.com/D109638
2021-03-30 16:40:32 +00:00
bf9bf52bb8
Bug 1701003 - Move proton tabs to the proton general pref. r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D109764
2021-03-26 22:55:21 +00:00
Emilio Cobos Álvarez
Harry Twyford
Stephen A Pohl
Narcis Beleuzu
Molly Howell
Bernard Igiri
Emma Malysz
Csoregi Natalia
Sam Foster
Michelle Goossens
Brindusan Cristian
Gijs Kruitbosch
Dão Gottwald
Butkovits Atila
Mike Conley
Jared Wein
Alexandru Michis
Marco Bonardo
Michael Kohler
Cosmin Sabou
Dorel Luca