When a page doesn't have a non-empty media session metadata, we would use its title as a default metadata, which would display as an artist name on the virtual control interface.
Therefore, when a page changes its title, we should also notify media controller (if it's been created) in order to update the default metadata as well.
Differential Revision: https://phabricator.services.mozilla.com/D93670
This variable was used in a MOZ_DIAGNOSTIC_ASSERT, but that kind of ASSERT is a
no-op outside of Nightly, DevEdition and debug builds.
Differential Revision: https://phabricator.services.mozilla.com/D94323
In the bug, Gijs suggests checking `AppConstants.MOZ_UPDATER`, but the stack
shows that `Cc[aContract]` isn't defined, so it seems better to check for that
instead.
I'm not sure how or whether it's even possible to write a test where there's no
updater, so I haven't added one, and in the case where there is an updater,
that's covered by our existing tests of course.
Differential Revision: https://phabricator.services.mozilla.com/D94257
Current page load telemetry probes are insufficient in performance RUM testing. FX_PAGE_LOAD_MS_2 will stop the timer when the user switches tabs or navigates off the page, while the current navigation probes include all content including about:blank, about:newtab, moz-extension, etc. This patch adds support for the following probes which do not suffer from those limitations:
PERF_PAGE_LOAD_TIME_MS
PERF_PAGE_LOAD_TIME_FROM_RESPONSESTART_MS
PERF_DOM_CONTENT_LOADED_TIME_MS
PERF_DOM_CONTENT_LOADED_TIME_FROM_RESPONSESTART_MS
PERF_FIRST_CONTENTFUL_PAINT_MS
PERF_FIRST_CONTENTFUL_PAINT_FROM_RESPONSESTART_MS
PERF_REQUEST_ANIMATION_CALLBACK_PAGELOAD_MS
PERF_REQUEST_ANIMATION_CALLBACK_NON_PAGELOAD_MS
Differential Revision: https://phabricator.services.mozilla.com/D94004
Fail parsing if line number (including initial offset) overflows the uint32_t
line number. Source length is capped at 4B characters so this change only
affects cases of inline-scripts with billions of lines which is not a
realistic case, even for generated code.
Differential Revision: https://phabricator.services.mozilla.com/D94115
With the `CompileOptions::column` offset and uint32_t source length, we can
end up with column positions that are not representable in various parts of
the engine. Rather than throwing an error on overflow, this patch simply
makes it saturate. This avoids checks throughout the tokenizer. These column
numbers are used primarily for SpiderMonkey-developer logging and for error
stacks in devtools. The existing behaviour would lose sync of SrcNotes so
this saturation change is at least more consistent.
Differential Revision: https://phabricator.services.mozilla.com/D94114
The regression was caused because it incorrectly started treating user
stylesheets as "system" sheets, which can't be modified.
Fix the regression by properly using SharedCssLogic.isAgentStylesheet
instead.
Also fix the check for whether chrome rules apply to handle user
stylesheets and inline style attributes in chrome documents correctly,
see the comment.
Differential Revision: https://phabricator.services.mozilla.com/D93088
We weren't waiting for assertion function to be evaluated in the console.
This can later lead to ok/is functions being undefined when calling Toolbox.spawn.
Differential Revision: https://phabricator.services.mozilla.com/D94279
This is a follow up from bug 1668377. It changes
some function names, comments and removes the factory
method.
The WrapAndRecord target is still used by the global recording
stuff so I've kept it for now.
Differential Revision: https://phabricator.services.mozilla.com/D92777
NOTE: Depends on D92634
This patch adds:
- A simple test for `localStorage` working on Fission
- Adapts `openTab` and `finishTests` helpers on `head.js`, that are used by all the storage mochitests.
However, by enabling the `openTab` helper to work on Fission, some tests that were previously failing early that were marked with `fail-if = fission` were finishing their setup, but _not_ their cleanup, which messed with following tests, since some of the HTML pages are shared a lot. In order to fix that, I've modified the problematic HTML pages so before doing their setup, they run their cleanup just in case. We can probably remove this once Fission is fully working.
Differential Revision: https://phabricator.services.mozilla.com/D93808
It's not 100% clear how long this command will live, but it doesn't look
immediately removable, and it was easy to add python3 support.
Differential Revision: https://phabricator.services.mozilla.com/D94179
This command appears to work just fine under python3 already -- I removed it from the py2 list and ran it with various options, and they all worked fine.
Differential Revision: https://phabricator.services.mozilla.com/D94174
Jim Blandy
Florian Quèze
Steve Fink
Henrik Skupin
Timothy Nikkel
alwu
Paul Adenot
Scott
Christian Holler
Ben Hearsum
Mats Palmgren
Alexis Beingessner
Nicolas B. Pierron
Mike Conley
Drew Willcoxon
Anny Gakhokidze
Boris Chiou
Denis Palmeiro
Olli Pettay
Jeff Muizelaar
Kershaw Chang
Ted Campbell
Bogdan Tara
Emilio Cobos Álvarez
Alexandre Poirot
Jon Coppeard
Jason Orendorff
smolnar
Belén Albeza