This reverts the commit:
git: d640ab64b993431099cd9205297bfff464d76927
hg: 9f6327c0d8298ec58a6c9f8d51526872d01d765e
Differential Revision: https://phabricator.services.mozilla.com/D58503
--HG--
extra : moz-landing-system : lando
The remote agent is an implementation of a subset of
the Chromium Remote Debugging Protocol (CDP) for Gecko.
For similar reasons as Marionette it needs the ability to call
nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData().
It calls this method from remote/domains/parent/Security.jsm which
implements the Security.setIgnoreCertificateErrors protocol method.
The remote agent is slated to replace Marionette, but there is
currently no timeline for this.
Differential Revision: https://phabricator.services.mozilla.com/D58435
--HG--
extra : moz-landing-system : lando
It must only be possible to call
nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData()
when Marionette is actually active, but the MOZ_MARIONETTE environment
variable can in theory be set by any user.
MOZ_MARIONETTE was introduced to support in-application restarts
so that the forked main process knows to re-initialise Marionette.
This makes it approximately equivalent to passing the --marionette flag.
Because Marionette can be started and stopped at runtime through
modifying the marionette.enabled preference, and Marionette never
resets MOZ_MARIONETTE, this makes it theoretically possible that
a future caller could circumvent this security check.
This is however not a security problem at present because the
method is only ever called from within testing/marionette/cert.js,
which itself is never called unless Marionette indeed is active.
Still, it would be safer for this to use nsIMarionette.running()
which returns true whenever the Marionette server is listening for
connections, and false when the Marionette automation protocol is
not enabled.
Differential Revision: https://phabricator.services.mozilla.com/D58434
--HG--
extra : moz-landing-system : lando
For test browser_net_prefs-reload.js, I am not sure about this change firstValue/currentValue seems to be different types numbers, strings, objects.
toString is maybe not the best way to compare those values.
Differential Revision: https://phabricator.services.mozilla.com/D58313
--HG--
extra : moz-landing-system : lando
This reverts the commit:
git: d640ab64b993431099cd9205297bfff464d76927
hg: 9f6327c0d8298ec58a6c9f8d51526872d01d765e
Differential Revision: https://phabricator.services.mozilla.com/D58503
--HG--
extra : moz-landing-system : lando
The remote agent is an implementation of a subset of
the Chromium Remote Debugging Protocol (CDP) for Gecko.
For similar reasons as Marionette it needs the ability to call
nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData().
It calls this method from remote/domains/parent/Security.jsm which
implements the Security.setIgnoreCertificateErrors protocol method.
The remote agent is slated to replace Marionette, but there is
currently no timeline for this.
Differential Revision: https://phabricator.services.mozilla.com/D58435
--HG--
extra : moz-landing-system : lando
It must only be possible to call
nsCertOverrideService::SetDisableAllSecurityChecksAndLetAttackersInterceptMyData()
when Marionette is actually active, but the MOZ_MARIONETTE environment
variable can in theory be set by any user.
MOZ_MARIONETTE was introduced to support in-application restarts
so that the forked main process knows to re-initialise Marionette.
This makes it approximately equivalent to passing the --marionette flag.
Because Marionette can be started and stopped at runtime through
modifying the marionette.enabled preference, and Marionette never
resets MOZ_MARIONETTE, this makes it theoretically possible that
a future caller could circumvent this security check.
This is however not a security problem at present because the
method is only ever called from within testing/marionette/cert.js,
which itself is never called unless Marionette indeed is active.
Still, it would be safer for this to use nsIMarionette.running()
which returns true whenever the Marionette server is listening for
connections, and false when the Marionette automation protocol is
not enabled.
Differential Revision: https://phabricator.services.mozilla.com/D58434
--HG--
extra : moz-landing-system : lando
It seems that the recommended Prettier extension for VSCode automatically formats CSS.
I guess this is also true for any editor extension that formats on save.
However ./mach lint is not checking CSS formatting issues, and we have not auto-formatted CSS files in the tree.
This can lead to unexpected formatting changes for developers using VSCode.
Differential Revision: https://phabricator.services.mozilla.com/D58593
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
Replace call to dict.iteritems by six.iteritems
--
wpt-commits: 878422d33b13cf46ec0d4f4201536426137ecc62
wpt-pr: 20920
Automatic update from web-platform-tests
Add content-aspect-ratio and update the description in canvas-aspect-ratio (#20943)
* Update the description in canvas-aspect-ratio. And add a test for content style image, make sure the width and height attributes won't infer its aspect-ratio.
--
wpt-commits: 453b3f32d5ee5a855780f9c43adc4c77996ab128
wpt-pr: 20943
Automatic update from web-platform-tests
html: Fix <input type=time> stepUp()-stops-at-border test (#20961)
Currently, this test is the only one failed by all three major browsers
in the file. Discovered by Kevin Raynel <kevinr@theodo.fr>.
--
wpt-commits: 53266c3b093c765918b37c7bd76b166d3b86d1f4
wpt-pr: 20961
Automatic update from web-platform-tests
XPath: Do not accept whitespace characters other than #x20, #x9, #xD, and #xA
Specification: https://www.w3.org/TR/1999/REC-xpath-19991116/#NT-ExprWhitespace
Bug: 1036767
Change-Id: I337ec70fefe8259d50bcf89a67b6e73c68fa585f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980251
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727844}
--
wpt-commits: e08790c4a97eb7d4ad8a13b1f917bfae3b08d334
wpt-pr: 20906
Automatic update from web-platform-tests
Disallow recursive custom element constructions
With this CL, recursive custom element constructions are no
longer allowed. I.e. this will now only run the constructor once:
class extends HTMLElement {
constructor() {
super();
customElements.upgrade(this);
}
}
Previously, the code and spec had a bug which caused the above
code snippet to infinitely recurse. In [1] the spec has changed,
to set the custom element state to "failed" before the constructor
is called. With this change in place, recursive calls will
early-out at step #2 (of [2]), and avoid the recursion.
[1] https://github.com/whatwg/html/pull/5126
[2] https://html.spec.whatwg.org/multipage/custom-elements.html#upgrades
Bug: 966472
Change-Id: I76e88c0b70132eee2482c304ef9e727ae1fe8fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931644
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727841}
--
wpt-commits: 4f24cabbe1f503f3daf8cf0834f4fb1a032f31bc
wpt-pr: 20465
Automatic update from web-platform-tests
[web-animations] Fix test in setting-the-playbackrate-of-an-animation.html (#20905)
This test assumes that currentTime will not change after waiting for
ready but the spec does not require that so this patch inverts these two
lines.
--
wpt-commits: c328e2ae1924a40d07dc552c4587ecc649eef0fd
wpt-pr: 20905
Automatic update from web-platform-tests
[LayoutInstability] Fix flaky tests
In this CL, some 'await waitForAnimationFrames(2)' are added to wait for
the initial render of the test page before introducing the observer.
This removes flakiness of these tests in WPT.fyi. Other cleanups are
done in the test files.
Bug: 1036013
Change-Id: Ic2631faf03ad00c8e32013c100c3b4ab867be2b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982708
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727639}
--
wpt-commits: 11f1a592c17fb4a7bb5c3081493ebb6a04a0aa39
wpt-pr: 20924
Automatic update from web-platform-tests
[LayoutInstability] Cleanup test observe-layout-shift.html
Currently, the test contains two async_tests, which is not good because
they run in parallel so the tests can affect each other. The first test
is redundant with buffer-layout-shift.html. The second test uses a
helper function from EventTiming, so we import the script instead of
copy-paste and we rename the test.
Change-Id: Ibe6d200441a07c603bccf0858406cf2c4f1d37a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982710
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727640}
--
wpt-commits: a3f46a8e90c9bf8e0c860525cce7ae5f10654234
wpt-pr: 20926
Automatic update from web-platform-tests
[webnfc] Correct error type
Per spec:
If languageLength cannot be stored in 6 bit (languageLength > 63),
throw a SyntaxError.
But current implementation throws a TypeError, this CL fixs the error type.
Bug: 520391
Change-Id: I6ff64d87b387a07fff926ada80e5ee5d73b716b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981199
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Leon Han <leon.han@intel.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#727414}
--
wpt-commits: 36507c8b6fe2d51971da07c913589ef1621f1651
wpt-pr: 20915
Automatic update from web-platform-tests
LazyLoad: Timeout when moving image elements between documents
This CL adds WPT test for moving image elements between documents
as well as removing image elements.
Bug: 1001968
Change-Id: I725b60bfaf2406d7fdeabe8d4422d0618dc29478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967084
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#727350}
--
wpt-commits: 7ed322c3132993bcb5734702b40621448670fc76
wpt-pr: 20774
Automatic update from web-platform-tests
Add support for running crashtest tests with webkitgtk (#20914)
* This adds support in the webkitgtk_minibrowser, webkit and epiphany
product runners for running crashtest tests.
--
wpt-commits: e936890351047304cdc98d31d555f6d6a068097e
wpt-pr: 20914
Daniel Varga
Coroiu Cristina
Yoshi Cheng-Hao Huang
Andreas Tolfsen
Tetsuharu OHZEKI
Dorel Luca
Tom Schuster
Michael Hoffmann
Julian Descottes
Ksenia Berezina
moz-wptsync-bot
marmeladema
cathiechen
Leon Han
Timothy Gu
Kent Tamura
Mason Freed
haozhe
Brian Birtles
autofoolip
Nicolás Peña Moreno
L. David Baron
Rob Buis
Wanming Lin
Carlos Alberto Lopez Perez