nimbus-shared 2.3.0 includes the new locales field as `locales?: string[]`,
which does not include null. Experimenter is going to produce recipes with
`locales: null` when [this pull request][1] lands, which would make Firefox
reject these recipes due to schema validation errors.
[1]: https://github.com/mozilla/experimenter/pull/8820
Differential Revision: https://phabricator.services.mozilla.com/D179545
This is effectively a backout of the following patches from Bug 1274959 except
we add comments and test coverage:
- Part 1 which made the DirectoryListingTask include symlinks in the results
as exposed by Directory.getFilesAndDirectories.
https://hg.mozilla.org/mozilla-central/rev/3f1e16d3bfb2
- Part 3 which made GetFilesHelper include symlinks in the results.
https://hg.mozilla.org/mozilla-central/rev/e28c3a696524
Test coverage for getFilesAndDirectories is provided by
dom/filesystem/tests/test_basic.html by way of changes to its included file
dom/filesystem/tests/filesystem_commons.js and changes to the createTreeFile
helper in dom/filesystem/tests/script_fileList.js.
Test coverage for GetFilesHelper is provided by
dom/filesystem/tests/test_webkitdirectory.html and changes to the
createTestFile helper in dom/filesystem/tests/script_fileList.js.
Commenting out either of the `isLink` test in the relevant C++ code will cause
the given tests to fail on non-windows platforms.
Differential Revision: https://phabricator.services.mozilla.com/D178894
OS print drivers/devices know nothing about page dimensions unless we tell
them. Previously, the physical page dimensions (including orientation) have
always been the same, so communicating their dimensions once at the start of
a print has been enough. In preparation for supporting different "physical"
page dimensions (in the immediate future only different page orientations) when
we save to PDF, we need to have the infrastructure to pass dimensions through
on a page-by-page basis. This patch adds that.
None of the PrintTarget subclasses do anything with this extra information yet,
but in a follow-up patch PrintTargetPDF will use this information to create
PDFs with mixed page orientations.
Depends on D179395
Differential Revision: https://phabricator.services.mozilla.com/D179423
`IMEContentObserver` can observe the value changes only while the text control
has anonymous `<div>` element because it observers the DOM mutation. The
anonymous `<div>` is alive (connected) only while the text control element
has a frame (recreated at each reframe). Therefore, `IMEContentObserver`
cannot observe the value changed during reframing.
This patch makes `TextControlState` notify `IMEContentObserver` of setting
new value directly only when it does not have `mBoundFrame`.
Differential Revision: https://phabricator.services.mozilla.com/D179358
Renames InitialHeap because it's not just used for the initial heap now. Also
makes it into an enum class.
This patch is almost entirely search and replace.
Depends on D179471
Differential Revision: https://phabricator.services.mozilla.com/D179472
Add min heap to tenured state the zone and use it to combine the heap checks.
I'm open to a better name for this.
Depends on D179470
Differential Revision: https://phabricator.services.mozilla.com/D179471
This removes some vestiges of nursery canaries that were missed from the
previous bug. Also moves some uncommonly moved method definitions out of line.
Differential Revision: https://phabricator.services.mozilla.com/D179470
Previously, we were making the screen coordinates relative to the window rect.
However, the window rect includes the non-client area of the window, which includes the title bar.
SetCaretPos expects client coordinates.
In Firefox, this normally doesn't matter because the title bar is disabled, so there is no non-client area.
However, when the title bar is disabled, the coordinates were previously incorrect.
Differential Revision: https://phabricator.services.mozilla.com/D176620
I don't quite know which part of this was breaking, but the coordinates were quite wrong in the parent process.
They were wrong enough that when we adjusted for the character height, we ended up with a negative height in the resulting rect.
This code is now more similar to how we do this in LocalAccessible::BoundsInAppUnits.
This should also take CSS transforms into account in most cases where we weren't previously, though perhaps not for some iframe transforms.
Differential Revision: https://phabricator.services.mozilla.com/D176619
Julian Descottes
Barret Rennie
Valentin Gosu
Andrew Sutherland
Kershaw Chang
Mirko Brodesser
James Teow
Edgar Chen
Paul Adenot
Iulian Moraru
Natalia Csoregi
Jonathan Watt
Andrew Creskey
Masayuki Nakano
Otto Länd
Jon Coppeard
Artur Iunusov
Gregory Pappas
Saira Abdulla
Jan-Niklas Jaeschke
James Teh
Malte Juergens
stransky
Emilio Cobos Álvarez
Jonathan Kew
Tom Schuster