Bug 1444301 moved the noautohide button to the meatball menu so we no longer to
worry about filtering it out in browser_toolbox_options_disable_buttons.js.
MozReview-Commit-ID: 5fp4FDxbc6o
--HG--
extra : rebase_source : bbc030bd3743e9c3fc8d8d2c32a6b89da4b87765
Changes:
1. The change in telemetry.js avoids an issue with overwriting pending properties.
2. The test in telemetry.md has been updated now that we have a working test.
3. Added the actual toolbox.close telemetry event and test.
MozReview-Commit-ID: 9fOCkwCCwDx
--HG--
extra : rebase_source : 55028edf836af62c25ae603675de0b3f5189f43e
The Punycode-encoded international domain names and URI-encoded filenames are
human-unreadable, so they should be displayed as human-readable Unicode text.
This commit decodes this kind of names in the Developer Toolbox's frame menu.
MozReview-Commit-ID: LGzw31z05OD
--HG--
extra : rebase_source : fba5cd9a4e78c9e6206c15fc3d858845b3d3c007
This also updates the link behavior to use the less privileged openWebLink.
MozReview-Commit-ID: HHDQKAQz6hQ
--HG--
extra : rebase_source : d57670983073893be6c67fe0c3dc991cbe1e5eb2
A few years ago in bug 1126274, we added RDP events to the DevTools transport so
that the add-on RDP Inspector could display packets as they flow by.
The add-on no longer works as it is not a WebExtension. Maybe someday we'll
revisit this, but for now this removes some dead code.
MozReview-Commit-ID: AvgQhYWwBUA
--HG--
extra : rebase_source : 45a295cb8b06729a0e3f74a90ce1094633f0f121
Currently, browser_toolbox_options check only toolbox's tab.
If tool tabs is bigger than toolbox width, this mechanism will not work
correctly. So this patch will check target tool tab from toolbox tabs and
tools menu (in chevron).
MozReview-Commit-ID: D3kaOwHvHni
--HG--
extra : rebase_source : c5abd11f138935f84b3d5c3fc4c21148295966ee
This patch will:
* change detecting overflow to using resize event.
* make chevron menu and tab menu to be exclusive.
* use photon design chevron menu.
* modify the related tests.
In this patch, the toolbox will create the cache of the displayed tool tab width
after rendering an element since each width of toolbox tab is not fixed size.
(i.e. each toolbox tab size is different from another size)
MozReview-Commit-ID: EQ0nU6WzCg1
--HG--
extra : rebase_source : ee01fbb5789769c4a75056e7eba41ad8ba232798
Disable rules with many failures for now, in a way that mentored bugs can easily pick them up.
Fix other minor issues raised by various rules.
MozReview-Commit-ID: 71OQI7jLihe
--HG--
extra : rebase_source : 7eac06299e6bbc6ae84e21b263c105555a06e757
This number is being used for the sibling of the toolbox itself, and over large sizes can
cause around a pixel or so of discrepancy, so go ahead and update to the bigger number
while we are here.
Also, support flex=10000 in flexbox emulation
MozReview-Commit-ID: 6BEo7XAkZrs
--HG--
extra : rebase_source : 32a797a57a515964c492c27eecb01c241acac2ae
By setting flex=10000 on the siblings of the toolbox and flex=1 on the toolbox iframe
we ensure that free space gets allocated to the browser contents and that the devtools
toolbox can shrink when the window needs to resize.
MozReview-Commit-ID: oel3kRw9m6
--HG--
extra : rebase_source : b87d6c024d8e57085115550bdc1b9169d3d70983
A command button like ruler has keydown event handler, this patch will
add same event handler to tab button.
--HG--
extra : rebase_source : eef8467b15bb99b8e8a22798e83c8a968ac24f7f
Both reason and isSlotted arguments of setNodeFront are optional, switching to an
object argument avoids weird calls such as setNodeFront(front, null, true) in favor
of a more explicit setNodeFront(front, { isSlotted: true });
MozReview-Commit-ID: A6nziH3QQYe
--HG--
extra : rebase_source : e5bde9e74369e1b0fb2e1d1a0a2b31a0131caacd
With shadow dom support, a node front can be represented twice in the
markup view, once as a "slotted" version inserted in a <slot> element
and once a regular element.
We should be able to know if the selection was made on the regular or
on the slotted version.
MozReview-Commit-ID: CUpREkL0TzL
--HG--
extra : rebase_source : 95259e33e084038d7a71e89b90affb60c38894a3
When inspecting a node with the toolbox focused on an inner frame, we need to
adjust the selectors used to remove hidden parent frames.
MozReview-Commit-ID: CXwb3FmnJFO
--HG--
extra : rebase_source : df8b01286fe8ebe38cb93cfe05bbd24e7f97d40d
Reverse the array of node inspection selectors, so that are a bit more naturally
human-readable by starting from the root document and moving inwards.
MozReview-Commit-ID: BYXryJg7iR9
--HG--
extra : rebase_source : b88b1289aaa768a7a852b433cd07ed4cf167c51c
Move and rename the server's frame script that starts DevTools in remote frames
from `child.js` to `startup/frame.js`. `connectToChild` also becomes the more
generic `connectToFrame`. A few b2g-isms like "app" are also removed.
These code paths will likely change more as Site Isolation work continues, but
for now, we have this light cleanup to gather startup-related paths together.
MozReview-Commit-ID: El8a0OE99gZ
--HG--
rename : devtools/server/child.js => devtools/server/startup/frame.js
rename : devtools/server/tests/mochitest/test_connectToChild.html => devtools/server/tests/mochitest/test_connectToFrame.html
extra : rebase_source : 2735c53587257b215d720204cf7c4581088eba42
devtools/shared/system is a complex module retrieving details device/platform
information. Modules that only need to get AppConstants should not pull down
such a complex dependency.
MozReview-Commit-ID: 2FmCO8nBSpP
--HG--
rename : devtools/client/shared/webpack/shims/system-stub.js => devtools/client/shared/webpack/shims/app-constants-stub.js
extra : rebase_source : 0ec5e4d320c8b1543d5fe579d8adf51c5fa4286d
This isn't needed since Console is an interface and not an object
MozReview-Commit-ID: ZoIo2TS9QL
--HG--
extra : rebase_source : 7ccb86dd4290e5d7ac829cab6dcf2f9548d89f11
By moving only the rejections that actually still apply into each test and out
of the shared head file, we are much more likely to notice new instances and
catch them when writing and editing tests in the future.
Bug 1018184 can be used to actually resolve these issues.
MozReview-Commit-ID: Qb71PsuutB
--HG--
extra : rebase_source : 7056bbf9fcd76ffe00015119d811db0bd788aa59
Move frame-script-utils.js into shared/test since it is a test only file. In
addition, it's removed from jar.mn so it won't be part the file we ship. Test
manifests can use the absolute path syntax to make it accessible in new
directories.
MozReview-Commit-ID: 5sKYvv2rsJs
--HG--
rename : devtools/client/shared/frame-script-utils.js => devtools/client/shared/test/frame-script-utils.js
extra : rebase_source : 8c4d77c37cacdae36d17102b4dbf1222ec1fbd8a
Use `loadFrameScriptUtils` from shared-head as a central utility for loading the
frame script utils helper. This means less stray references to the utils file's
path across our tests.
As part of this, I went ahead and converted Canvas Debugger, Shader Editor, and
Web Audio Editor to shared-head, as that seemed like the best path to reduce
duplication.
(I left one extra path reference in profiler-mm-utils.js as-is, since it's a
module, so shared-head is not easily usable there.)
MozReview-Commit-ID: AKbZt8Jo0GM
--HG--
extra : rebase_source : e70b29153ef8d96d7026bc3abd0fb0d2306849bc
Move frame-script-utils.js into shared/test since it is a test only file. In
addition, it's removed from jar.mn so it won't be part the file we ship. Test
manifests can use the absolute path syntax to make it accessible in new
directories.
MozReview-Commit-ID: 5sKYvv2rsJs
--HG--
rename : devtools/client/shared/frame-script-utils.js => devtools/client/shared/test/frame-script-utils.js
extra : rebase_source : cb18b88016df8bc7fba1620534beed473ebb406a
Use `loadFrameScriptUtils` from shared-head as a central utility for loading the
frame script utils helper. This means less stray references to the utils file's
path across our tests.
As part of this, I went ahead and converted Canvas Debugger, Shader Editor, and
Web Audio Editor to shared-head, as that seemed like the best path to reduce
duplication.
(I left one extra path reference in profiler-mm-utils.js as-is, since it's a
module, so shared-head is not easily usable there.)
MozReview-Commit-ID: AKbZt8Jo0GM
--HG--
extra : rebase_source : d00f578d7c9078088be8c33ad80eb30a59d6a6e8
Usage was removed from devtools/client/framework/sidebar as well since it emits
events with the parent component.
MozReview-Commit-ID: 24LLmnSZ89I
--HG--
extra : rebase_source : 3ede287d862c80817fe4767e8d029dda26cbb58b
The overlay elements with children of editMenuOverlay.xul are moved into
include files (editMenuCommands.inc.xul and editMenuKeys.inc.xul). For
the other single elements in the overlay, the attributes are inlined
wherever they are used.
MozReview-Commit-ID: 792cuzUvQxT
--HG--
extra : rebase_source : 58e4c05bde16cee873d37c6198de102d048499c2
Importing this object is unnecessary after the updates to the WebIDL console from Bug 1425574
and the follow-ups blocking Bug 1430810. There are still callers that access Console.jsm
to create custom ConsoleAPI objects, but those will be handled separately.
MozReview-Commit-ID: 9ojFxtkpPId
--HG--
extra : rebase_source : 971bf99f709b8d2afe300f3693665724f747aa5e
The onclick handler of the toolbox close button looked like this... spot the deliberate mistake:
```
onClick: () => {
closeToolbox();
focusButton(closeButtonId);
},
```
So we were closing the toolbox and then trying to focus the toolbox's close button.
There is also an obvious race condition with setState inside the toolbox controller not using a callback even though the next line calls a function that uses this.state, which could cause intermittent issues.
MozReview-Commit-ID: 9VRcZw4RvE5
--HG--
extra : rebase_source : 17c21aafe5a72042c23472342c53fd730784a5ae
I believe this fixes all warnings except for one. This warning appears the first time the memory panel is selected:
"Warning: Failed prop type: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them. Read more at http://fb.me/use-check-prop-types
in MemoryApp (created by Connect(MemoryApp))
in Connect(MemoryApp) (created by bound createElementWithValidation)
in bound createElementWithValidation
in Provider"
This appears to be an issue with `devtools/client/memory/app.js` but I will log a new bug for this.
MozReview-Commit-ID: 341zdQyfgrN
--HG--
extra : rebase_source : ce25569407b89a7547e4db688373b202d17d2475
To accomplish this, the added aria-pressed attribute turns the buttons into toggle buttons, and the one that is visually selected, gets the "true" attribute value, others are "false". That way, the screen reader and other assistive technologies will indicate that this is the selected or pressed button.
MozReview-Commit-ID: L2lcw2wOyYw
--HG--
extra : rebase_source : 1c0ad241319f50c34c120ce05b85e795e9a5b080
Track connection status at various points during Browser Toolbox startup. If
connecting takes a long time or triggers an error, the status panel is revealed
with the most recent message displayed.
MozReview-Commit-ID: H8240rv3KRe
--HG--
extra : rebase_source : 7c2c10c710095ede7d1b9c1ac87ca21bd3deb969
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.
MozReview-Commit-ID: De4enbjux3T
--HG--
extra : rebase_source : 2296b84bff8e22f01eeb48cd8614fac5db11136a
Brian Birtles
Yura Zenevich
Andreea Pavel
Michael Ratcliffe
Brian Grinstead
Zhang Junzhi
Alexandre Poirot
J. Ryan Stinnett
Mantaroh Yoshinaga
Julian Descottes
Gurzau Raul
Luca Greco
Mark Banner
Tiberius Oros
ui.manish
Nicolas Chevobbe
Jan Odvarko
Ryan VanderMeulen
Jason Laster
shindli
Sebastian Hengst
Dorel Luca
Coroiu Cristina
Cosmin Sabou
yulia
Florian Quèze
Brendan Dahl
Marco Zehe
Kris Maglione
Mike de Boer
Masayuki Nakano
Timothy Guan-tin Chien