Move and rename the server's frame script that starts DevTools in remote frames
from `child.js` to `startup/frame.js`. `connectToChild` also becomes the more
generic `connectToFrame`. A few b2g-isms like "app" are also removed.
These code paths will likely change more as Site Isolation work continues, but
for now, we have this light cleanup to gather startup-related paths together.
MozReview-Commit-ID: El8a0OE99gZ
--HG--
rename : devtools/server/child.js => devtools/server/startup/frame.js
rename : devtools/server/tests/mochitest/test_connectToChild.html => devtools/server/tests/mochitest/test_connectToFrame.html
extra : rebase_source : 2735c53587257b215d720204cf7c4581088eba42
devtools/shared/system is a complex module retrieving details device/platform
information. Modules that only need to get AppConstants should not pull down
such a complex dependency.
MozReview-Commit-ID: 2FmCO8nBSpP
--HG--
rename : devtools/client/shared/webpack/shims/system-stub.js => devtools/client/shared/webpack/shims/app-constants-stub.js
extra : rebase_source : 0ec5e4d320c8b1543d5fe579d8adf51c5fa4286d
This isn't needed since Console is an interface and not an object
MozReview-Commit-ID: ZoIo2TS9QL
--HG--
extra : rebase_source : 7ccb86dd4290e5d7ac829cab6dcf2f9548d89f11
By moving only the rejections that actually still apply into each test and out
of the shared head file, we are much more likely to notice new instances and
catch them when writing and editing tests in the future.
Bug 1018184 can be used to actually resolve these issues.
MozReview-Commit-ID: Qb71PsuutB
--HG--
extra : rebase_source : 7056bbf9fcd76ffe00015119d811db0bd788aa59
Move frame-script-utils.js into shared/test since it is a test only file. In
addition, it's removed from jar.mn so it won't be part the file we ship. Test
manifests can use the absolute path syntax to make it accessible in new
directories.
MozReview-Commit-ID: 5sKYvv2rsJs
--HG--
rename : devtools/client/shared/frame-script-utils.js => devtools/client/shared/test/frame-script-utils.js
extra : rebase_source : 8c4d77c37cacdae36d17102b4dbf1222ec1fbd8a
Use `loadFrameScriptUtils` from shared-head as a central utility for loading the
frame script utils helper. This means less stray references to the utils file's
path across our tests.
As part of this, I went ahead and converted Canvas Debugger, Shader Editor, and
Web Audio Editor to shared-head, as that seemed like the best path to reduce
duplication.
(I left one extra path reference in profiler-mm-utils.js as-is, since it's a
module, so shared-head is not easily usable there.)
MozReview-Commit-ID: AKbZt8Jo0GM
--HG--
extra : rebase_source : e70b29153ef8d96d7026bc3abd0fb0d2306849bc
Move frame-script-utils.js into shared/test since it is a test only file. In
addition, it's removed from jar.mn so it won't be part the file we ship. Test
manifests can use the absolute path syntax to make it accessible in new
directories.
MozReview-Commit-ID: 5sKYvv2rsJs
--HG--
rename : devtools/client/shared/frame-script-utils.js => devtools/client/shared/test/frame-script-utils.js
extra : rebase_source : cb18b88016df8bc7fba1620534beed473ebb406a
Use `loadFrameScriptUtils` from shared-head as a central utility for loading the
frame script utils helper. This means less stray references to the utils file's
path across our tests.
As part of this, I went ahead and converted Canvas Debugger, Shader Editor, and
Web Audio Editor to shared-head, as that seemed like the best path to reduce
duplication.
(I left one extra path reference in profiler-mm-utils.js as-is, since it's a
module, so shared-head is not easily usable there.)
MozReview-Commit-ID: AKbZt8Jo0GM
--HG--
extra : rebase_source : d00f578d7c9078088be8c33ad80eb30a59d6a6e8
Usage was removed from devtools/client/framework/sidebar as well since it emits
events with the parent component.
MozReview-Commit-ID: 24LLmnSZ89I
--HG--
extra : rebase_source : 3ede287d862c80817fe4767e8d029dda26cbb58b
The overlay elements with children of editMenuOverlay.xul are moved into
include files (editMenuCommands.inc.xul and editMenuKeys.inc.xul). For
the other single elements in the overlay, the attributes are inlined
wherever they are used.
MozReview-Commit-ID: 792cuzUvQxT
--HG--
extra : rebase_source : 58e4c05bde16cee873d37c6198de102d048499c2
Importing this object is unnecessary after the updates to the WebIDL console from Bug 1425574
and the follow-ups blocking Bug 1430810. There are still callers that access Console.jsm
to create custom ConsoleAPI objects, but those will be handled separately.
MozReview-Commit-ID: 9ojFxtkpPId
--HG--
extra : rebase_source : 971bf99f709b8d2afe300f3693665724f747aa5e
The onclick handler of the toolbox close button looked like this... spot the deliberate mistake:
```
onClick: () => {
closeToolbox();
focusButton(closeButtonId);
},
```
So we were closing the toolbox and then trying to focus the toolbox's close button.
There is also an obvious race condition with setState inside the toolbox controller not using a callback even though the next line calls a function that uses this.state, which could cause intermittent issues.
MozReview-Commit-ID: 9VRcZw4RvE5
--HG--
extra : rebase_source : 17c21aafe5a72042c23472342c53fd730784a5ae
I believe this fixes all warnings except for one. This warning appears the first time the memory panel is selected:
"Warning: Failed prop type: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them. Read more at http://fb.me/use-check-prop-types
in MemoryApp (created by Connect(MemoryApp))
in Connect(MemoryApp) (created by bound createElementWithValidation)
in bound createElementWithValidation
in Provider"
This appears to be an issue with `devtools/client/memory/app.js` but I will log a new bug for this.
MozReview-Commit-ID: 341zdQyfgrN
--HG--
extra : rebase_source : ce25569407b89a7547e4db688373b202d17d2475
To accomplish this, the added aria-pressed attribute turns the buttons into toggle buttons, and the one that is visually selected, gets the "true" attribute value, others are "false". That way, the screen reader and other assistive technologies will indicate that this is the selected or pressed button.
MozReview-Commit-ID: L2lcw2wOyYw
--HG--
extra : rebase_source : 1c0ad241319f50c34c120ce05b85e795e9a5b080
Track connection status at various points during Browser Toolbox startup. If
connecting takes a long time or triggers an error, the status panel is revealed
with the most recent message displayed.
MozReview-Commit-ID: H8240rv3KRe
--HG--
extra : rebase_source : 7c2c10c710095ede7d1b9c1ac87ca21bd3deb969
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.
MozReview-Commit-ID: De4enbjux3T
--HG--
extra : rebase_source : 2296b84bff8e22f01eeb48cd8614fac5db11136a
The sandbox used in this test isn't immediately destroyed when the test finishes.
So use a unique file name to always refer to the expected sandbox/file in this debugger test.
MozReview-Commit-ID: FJYXPN0RQS2
--HG--
extra : rebase_source : 438ae8cf97bfef8bc11e86e7850b3d6d8e8f1ccc
The breakpoint is set in a function called every second.
We have to unregister it before test finishes, otherwise it gets randomly called during test shutdown.
MozReview-Commit-ID: IEHxnVjk1xW
--HG--
extra : rebase_source : be6cdad0d700e24f80c9e520be49ec5c9d02375b
Since gBrowser is going to become a plain JS object instead of a DOM node,
we don't want any callers directly referring to the DOM node to get ahold of it.
MozReview-Commit-ID: KbE5dlTWmS
--HG--
extra : rebase_source : ef4caea778db406205b58b9f007846dabb062978
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <
J. Ryan Stinnett
Julian Descottes
Jason Laster
Nicolas Chevobbe
shindli
Andreea Pavel
Brian Grinstead
Sebastian Hengst
Michael Ratcliffe
Dorel Luca
Coroiu Cristina
Alexandre Poirot
Luca Greco
Cosmin Sabou
yulia
Florian Quèze
Brendan Dahl
Marco Zehe
Gurzau Raul
Kris Maglione
Mike de Boer
Jan Odvarko
Masayuki Nakano
Mark Banner
Timothy Guan-tin Chien
Yura Zenevich
Andrew McCreight
Brindusan Cristian
Margareta Eliza Balazs
Bill McCloskey
Greg Tatum
Tiberius Oros
Eitan Isaacson
Joel Maher
Tom Tromey
Wes Kocher
Dan Epstein
Gabriel Luong
Ian Moody