Ed Morley
2b7f8b2978
Bug 684327 - toolkit-makefiles.sh adjustments for js/src/xpconnect/tests/components/ changes; rs=build
2011-09-25 16:15:30 +01:00
Bobby Holley
aa1965160b
Bug 683802 - Pass useAllocator=false only for wrappedjs dipper params. Everything else can allocate. r=mrbkap
...
We only have one good reason for the useAllocator distinction: when C++ calls JS with a dipper parameter (ie, a string), the caller has already created the relevant nsAString or nsCString, so we shouldn't allocate another one. All other uses are superfluous or irrelevant, so we can get rid of them.
2011-09-25 15:38:02 +01:00
Bobby Holley
1d473af0de
Bug 683802 - Force allocation for sized PWSTRINGs in XPCWrappedNative argument conversion. r=mrbkap
...
This is the last remaining place where we might pass a non-dipper with useAllocator==false to XPCConvert *and, as a consequence*, do something different within XPCConvert. This paves the way for the elimination of useAllocator for non-dipper types.
2011-09-25 15:38:01 +01:00
Bobby Holley
0ef52222c1
Bug 683802 - Remove XPC_JSArgumentFormatter and friends. r=mrbkap
...
XPC_JSArgumentFormatter adds 3 special format string tokens to spidermonkey: %ip, %iv, and %is. These were unused outside of testing according to a free-text MXR search, and don't appear to be well-documented anywhere either. They also happen to be quite dangerous and easy to use improperly: we pass untyped variadic parameters to XPCConvert::JSData2Native with useAllocator==false. This causes JSData2Native to blindly cast the values to concrete class pointers (like nsAString*) and call methods on them.
2011-09-25 15:38:01 +01:00
Bobby Holley
d9a517269b
Bug 683802 - Eliminate questionable support for [shared] parameters. r=mrbkap
...
AFAICT we'd crash if we hit these cases anyway. bsmedberg and khuey requested that I assert against this case within XPConnect, and file a bug to make XPIDL enforce that [shared] parameters exist only in [noscript] methods. Filed bug 685281 for this.
2011-09-25 15:38:01 +01:00
Bobby Holley
3f12803681
Bug 683802 - Coalesce type-specific cleanup indicators. r=mrbkap
2011-09-25 15:38:01 +01:00
Bobby Holley
85a6b92ebd
Bug 683802 - Add jsval to the XPTCMiniVariant union for type safety. r=mrbkap
2011-09-25 15:38:01 +01:00
Bobby Holley
4764ad32ea
Bug 683802 - Use an explicit indicator for direct vs indirect calling semantics. r=mrbkap
2011-09-25 15:38:01 +01:00
Bobby Holley
05a47898e5
Bug 683802 - Define and restrict the semantics of PTR_IS_DATA. r=mrbkap
2011-09-25 15:38:01 +01:00
Bobby Holley
32b99c391c
Bug 683802 - Always store jsvals directly within the val union (fixes bug 655878). r=mrbkap
2011-09-25 15:38:00 +01:00
Bobby Holley
6eb6ef3dba
Bug 683802 - Factor dipper handling out into a helper method. r=mrbkap
2011-09-25 15:38:00 +01:00
Bobby Holley
3c6c5e3a02
Bug 683802 - Separate reindentation from previous patch for easier review. No other changes. r=mrbkap
2011-09-25 15:38:00 +01:00
Bobby Holley
655481c1ac
Bug 683802 - Move the loop contents of ConvertIndependentParams into a separate method (without re-indentation). r=mrbkap
2011-09-25 15:38:00 +01:00
Bobby Holley
06b0d11298
Bug 683802 - Remove mAutoString micro-optimization. r=mrbkap
2011-09-25 15:38:00 +01:00
Bobby Holley
7d32af0621
Bug 684327 - Package the typelib along with the components so that it's accessible from the test harness. r=khuey
2011-09-25 15:38:00 +01:00
Bobby Holley
c2fad28573
Bug 684327 - Test parameter passing. r=khuey
2011-09-25 15:38:00 +01:00
Bobby Holley
82d89ea7b4
Bug 684327 - Generalize test_readwriteattributes.js into test_attributes.js. r=khuey
...
--HG--
rename : js/src/xpconnect/tests/unit/test_readwriteattributes.js => js/src/xpconnect/tests/unit/test_attributes.js
2011-09-25 15:38:00 +01:00
Bobby Holley
ef44402842
Bug 684327 - Add an xpcshell test that exercises both the native and js components. r=khuey
2011-09-25 15:37:59 +01:00
Bobby Holley
a8f0c05399
Bug 684327 - Introduce js-implemented test component. r=khuey
2011-09-25 15:37:59 +01:00
Bobby Holley
9055a80409
Bug 684327 - Move the C++ implementation of the test component into its own subdirectory. r=khuey
...
--HG--
rename : js/src/xpconnect/tests/components/Makefile.in => js/src/xpconnect/tests/components/native/Makefile.in
rename : js/src/xpconnect/tests/components/xpctest.manifest => js/src/xpconnect/tests/components/native/xpctest.manifest
rename : js/src/xpconnect/tests/components/xpctest_attributes.cpp => js/src/xpconnect/tests/components/native/xpctest_attributes.cpp
rename : js/src/xpconnect/tests/components/xpctest_module.cpp => js/src/xpconnect/tests/components/native/xpctest_module.cpp
rename : js/src/xpconnect/tests/components/xpctest_private.h => js/src/xpconnect/tests/components/native/xpctest_private.h
2011-09-25 15:37:59 +01:00
Bobby Holley
cb36277b94
Bug 684327 - Misc fixes to xpctest_attributes. r=khuey
...
This patch is best reviewed while listening to http://www.youtube.com/watch?v=MK6TXMsvgQg
NB - The code here would make a great "find the bugs in this code" interview screen question.
2011-09-25 15:37:59 +01:00
Bobby Holley
232e6d4229
Bug 684327 - Start building a small subset of the xpconnect test component again, kill the rest. r=khuey
...
Thanks to Mook for the initial patch!
2011-09-25 15:37:59 +01:00
Bobby Holley
836ad39fe6
Bug 684327 - Remove TestXPC.cpp, which currently printfs that it's failing various things and then segfaults. r=khuey
2011-09-25 15:37:58 +01:00
Mook
f57c44d7ed
Bug 652571 - xptstubs on unix x86_64 does not pass float correctly. r=espindola
2011-09-25 15:37:58 +01:00
Ed Morley
27cc5cc8df
Merge tips of mozilla-central and mozilla-inbound
2011-09-25 13:58:53 +01:00
Martin Stransky
4cbb00125a
Bug 627699 - Port GTK2 to GTK3: Build fix for startup notification. r=karlt
2011-09-25 01:01:35 +01:00
Brian Hackett
5d2e46b208
Sync state on all exit paths in CALLPROP PICs when allowing getter stubs, bug 688478. r=dvander
2011-09-24 14:15:38 -07:00
Benoit Jacob
60e32d2ae0
Bug 662258 - GCC warning about BasicThebesLayerBuffer::CreateBuffer getting hidden by ShadowThebesLayerBuffer::CreateBuffer. r=roc
2011-09-24 21:01:18 +02:00
Neil Rashbrook
e0fc97dd2d
Bug 684825 Fix for ASSERTION: QueryInterface needed r=jmuizelaar
2011-09-24 18:20:12 +01:00
Neil Rashbrook
312bca329e
Bug 685457 Don't set attributes until after accessing the box object r=bienvenu
...
NPTODB DONTBUILD
2011-09-24 18:15:47 +01:00
Matt Brubeck
7dcbac81b9
Back out 0ec8974f0917 (bug 686992) because of crashes
2011-09-24 08:51:46 -07:00
Jeff Muizelaar
c039ef0e76
Bug 688902. 2d: Document Color as being non-premultiplied. r=bas
2011-09-24 11:51:29 -04:00
Matt Brubeck
a071ce05c4
Merge last green changeset of mozilla-inbound to mozilla-central
2011-09-24 08:18:28 -07:00
Matt Brubeck
f6eaa5b173
Merge mozilla-central to mozilla-inbound
2011-09-24 08:13:45 -07:00
Marco Castelluccio
4536508307
Bug 679352 - Remove libreg. r=khuey
2011-09-24 16:28:21 +02:00
Marco Castelluccio
df8ae70db2
Bug 679352 - Remove libreg (Part 1: Clean nsProfileMigrator). r=bsmedberg
2011-09-24 16:25:20 +02:00
Steffen Wilberg
72d3a7d2e0
Bug 678600: Don't add print frames options to Windows print dialog when they would be disabled anyway because there are no frames. r=roc, ui-review=faaborg
2011-09-24 14:05:29 +02:00
Dão Gottwald
953532161e
Bug 684450 - Addressing review comment
2011-09-24 13:04:07 +02:00
Stephen Horlander
2907f6bb2b
Bug 684450 - Remove stop/go/reload button affordance and streamline other location bar icons. r=dao
2011-09-24 13:03:09 +02:00
Matheus Kerschbaum
6a1e69506a
Bug 669829 - Remove check for atlbase.h and oleacc.idl from configure. r=ted
2011-09-24 12:53:07 +02:00
Gian-Carlo Pascutto
83268e3abc
Bug 688692 - Fennec is not sending crash reports. r=ted
2011-09-24 11:32:54 +01:00
Dão Gottwald
424f8c244a
merge backout
2011-09-24 12:27:14 +02:00
Dão Gottwald
28b18e8b1f
Backed out changeset 7e53a3cf73b5
2011-09-24 12:26:38 +02:00
Dão Gottwald
3dfcbfe370
merge backout
2011-09-24 12:24:30 +02:00
Dão Gottwald
5e0e04c4bf
Backed out changeset ce51db254f18
2011-09-24 12:23:58 +02:00
Dão Gottwald
d219382f28
merge backout
2011-09-24 12:23:22 +02:00
Dão Gottwald
828b754804
Backed out changeset f1409901573a
2011-09-24 12:22:48 +02:00
Dão Gottwald
dd7a18b63d
merge backout
2011-09-24 12:22:08 +02:00
Dão Gottwald
114be64ed3
Backed out changeset 121518f3df44
2011-09-24 12:20:19 +02:00
Dão Gottwald
a5fdc7e4f6
merge backout
2011-09-24 12:19:40 +02:00