Add `MacroAssembler::branchIfObjectNotExtensible()` in preparation for the next
part. Also allows to remove the `CacheIRCompiler` friend declaration in
`JSObject`.
Differential Revision: https://phabricator.services.mozilla.com/D95489
The normalize function was putting the current container/offset past the end boundary. This caused overruns with getting the text for the range of the input object, and some unexpected invalid ranges.
Differential Revision: https://phabricator.services.mozilla.com/D98236
The test tweak is needed because user interaction isn't registered by a
single mouseup, but the test is still valid with that tweak IMO.
Depends on D98021
Differential Revision: https://phabricator.services.mozilla.com/D98022
Release the two kinds of listeners that view source channel has
if AsyncOpen fails, or in OnStop. This matches the behavior of
HttpChannelChild. The former change fixes a leak when view source
channels are blocked by enterprise policies.
It looks like clang-format deleted the double include of
nsViewSourceChannel.h.
Differential Revision: https://phabricator.services.mozilla.com/D98223
As the use case we know it was needed for should be covered by the previous
patch as well.
This is also process-global, which is a bit odd, given whether a popup-opening
operation succeeds ends up depending on other tabs' activity.
Depends on D98020
Differential Revision: https://phabricator.services.mozilla.com/D98021
I think this allows us to remove TryUsePopupOpeningToken (which is a similar
concept to consuming user activation), and also the ad-hoc <iframe> timing
thing we have from bug 1514547, which should be covered by the user activation
timeout.
Depends on D97640
Differential Revision: https://phabricator.services.mozilla.com/D98020
Automatic update from web-platform-tests
[LargestContentfulPaint] Fix invisible image tracking
In this CL we change |invisible_images_| to track not just LayoutObject
but also the ImageResourceContent, which is in line with how it is
tracked in |visible_images_| and is necessary to correctly track
background images as well as image source changes that do not impact
the LayoutObject used.
Bug: 1152846
Change-Id: I2bfa02ef0a6795b7036abecf8f1e342f39e6ea3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561270
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831333}
--
wpt-commits: 35e691574b44ae6ff6251af68e619f5ddebfb07e
wpt-pr: 26648
Automatic update from web-platform-tests
Fieldset NG: block-size of the anonymous content box should not be
larger than the max-block-size of the FIELDSET
If the intrinsic block size of the anonymous content box is larger than
the max-block-size, the block size should be shrunk to the
max-block-size.
Bug: 1151858
Change-Id: I3132d16d835dffc4ca0ab732ca1b5b3c566013e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556877
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831327}
--
wpt-commits: 096343c501df79c190278a0bf06e94d34a27806f
wpt-pr: 26632
Automatic update from web-platform-tests
COOP: emit report whenever there is another window in the bcg
This CL changes reporting of browsing context group switches for COOP.
Prior to this CL, a report would only be generated if the frame had an
opener at the start of navigation. Following this CL, the report is
generated whenever there is another window in the browsing context
group which is in line with the spec.
Bug: 1148709
Change-Id: If2bf80365896a50692b4c02338a3fedf27348df7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544504
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831309}
--
wpt-commits: 44e4706e277d1d4eedb4f90e928240a24181a404
wpt-pr: 26638
Automatic update from web-platform-tests
Simulate user inputs in css/selectors/focus-visible-012.html
Use testdriver Action API to simulate key actions in
css/selectors/focus-visible-012.html.
Bug: 1145677
Change-Id: I14a5362801ac407ad6129d02feb7003960485cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551229
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831148}
--
wpt-commits: 7726454dad3c91effded7b894ce5b1f62a2fced2
wpt-pr: 26621
Automatic update from web-platform-tests
Update url/resources/percent-encoding.py to work on Python 3 (#26643)
--
wpt-commits: 1783c9bccf48c426ec1017f36e1ccfcf90a8af47
wpt-pr: 26643
Automatic update from web-platform-tests
webrtc wpt: add test for valid rtp payload types
when used together with rtcp-mux
Change-Id: I87e07d8dc74d58e69463a3a24a95c7b291b21804
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546684
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831108}
--
wpt-commits: 651219c6de1909c4196281c5f4ccc92123456807
wpt-pr: 26608
Automatic update from web-platform-tests
Simulate user inputs in css/selectors/focus-visible-001.html
Use testdriver Action API to simulate key actions in
css/selectors/focus-visible-001.html.
Bug: 1145677
Change-Id: I5f39a03b41624e2a12c523dc9b1a0a509925621a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546602
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831103}
--
wpt-commits: 2777a9e1fd1a6612959b1b41c45f010164a8b358
wpt-pr: 26565
Automatic update from web-platform-tests
Fix a crash by PaintWorklet + custom property animation
https://chromium-review.googlesource.com/c/chromium/src/+/2359370
The above CL made a custom property animation always composited if
it is used by paint worklet, even if the element does not have
"will-change: transform". The approach is that we give a special
ElementId which is uint64_t::max() to the paint worklet element,
and then on the CC side, once we see that element id, we know that
it is an animation associated with paint worklet and we will always
tick that animation.
The problem comes when there are two paint worklet elements.
The short version of the problem is:
CC's animation system doesn't allow two layers with the same
ElementId.
Longer version:
Then these two layers would have the same ElementId when
we try to attach a composited layer with that animation. As a
result, in the AnimationHost::RegisterAnimationForElement(), we
will have two Animation with the same ElementId. Then, the actual
crash happens at ElementAnimations::GetPropertyToElementIdMap(),
at the first DCHECK.
So the solution in this CL is to not DCHECK in certain cases.
The DCHECK actually doesn't make sense in this case where
there is no composited layer. In fact, the callers of the
ElementAnimations::GetPropertyToElementIdMap gives the result
to MutatorHostClient::ElementIsAnimatingChanged, and in there
it only cares about 4 properties. So for the other properties
that it doesn't care, we should not put it in the map.
Bug: 1151755
Change-Id: I5479ccae80f3c89db98d27518ef013dded527ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553691
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831090}
--
wpt-commits: 8225f7456566a3e7c20135917113e1bde15c5d37
wpt-pr: 26611
Automatic update from web-platform-tests
Add a WPT test to verify the mouse click count in infrastructure/
We should have a WPT test to verify the mouse click count, such as
double click and triple click. For the click count is greater than 3, we
should increase it when the OS is Windows and Mac, reset to 1 otherwise.
Also reset the mouse click count, if the mouse moves to a different
locations.
Bug: 1119679
Change-Id: I755c1f49a470598391440802e2ad62817a958777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515882
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830279}
--
Expect Firefox and Safari to fail mouseClickCount.html
--
wpt-commits: e8d10087aaa3c6ff5379e380bc6bfe0c43a4c829, 63e3b675a4deb7ac9d0298f6a1f6c7439f901503
wpt-pr: 26480
Automatic update from web-platform-tests
[CLS] Don't count layout shifts due to content-visibility:auto unskipping
content-visibility:auto elements have different sizing behavior when
near the viewport vs not. This sizing behavior is an intentional part
of the platform, and should not be considered a layout shift for the
the first time the elements' subtrees become unskipped (*).
There are two cases of "first time":
* The very first paint when a content-visiblity:auto element is in the
DOM, and in which the element is found in that frame to be near the
viewport.
* The first paint *after* a content-visiblity:auto element has been
found to be near the viewport, but was was found for at least one
frame previously not to be near it.
These two cases are handled in somewhat different ways in Blink - the
former is a synchronous relayout, whereas the second is async.
In both cases, CLS should not be impacted.
In the future, we could consider in the future whether layout shifts
for subsequent unskips should also not count for CLS.
Bug: 1151526
(*) https://drafts.csswg.org/css-contain-2/#skips-its-contents
Change-Id: I9421452430dd572ed87bb20b0bd20e9a7e3501a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556211
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830774}
--
wpt-commits: 92d9bd4ddb7ffe622e8cd4887fd2b405736b891e
wpt-pr: 26639
Automatic update from web-platform-tests
Fix echo-content-escaped.py again (#26645)
The fix in #26615 only works in Py3.
This time we make it compatible with Py2 & Py3.
--
wpt-commits: c52e4b0d420bd914d95e746cc95fd4e4625e29db
wpt-pr: 26645
Automatic update from web-platform-tests
Remove annotated-spec-related functionality from canvas tests (#26619)
* Remove more canvas annotated spec helpers
The functionality to generate an annotated canvas spec was removed in
commit dadd0856c672d47dabcbbea23d58d028a99285b1, but remnants of it
have been lingering in the codebase, confusing anyone who tries to make
sense of the canvas tests. This removes those remnants.
* Remove 'previously' from canvas spec.yaml
This was used for disambiguation when generating an annotated spec that
is no longer generated.
* Remove <^> and <eol> from canvas spec.yaml
This is where links to the generated tests would be inserted in the
annotated spec, which is no longer generated.
--
wpt-commits: cfcd8ebdd75c693a9e4e5dd6ff1472abe0db5cc4
wpt-pr: 26619
Automatic update from web-platform-tests
webrtc: check for allowed payload types in createOffer
this will intentionally break when adding new codecs and we can not
add new codecs anymore because we do not have enough payload types.
BUG=webrtc:12194
Change-Id: Ic1dff5f479377280111729f6443fc60a7d2e2658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550806
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830996}
--
wpt-commits: a44c4c2bbe76aae7991113a1ea3f5fd8ae849dbd
wpt-pr: 26636
Automatic update from web-platform-tests
[merchant-validation] Rename an incorrectly named test
--
wpt-commits: b1d491ef64e96c824a03285460bf0406997d45f1
wpt-pr: 26644
Automatic update from web-platform-tests
Improve error messages of generate-test-{sxgs,wbns}.sh
`go get` installs commands in $GOPATH/bin (or ~/go/bin if $GOPATH is not
set), which may not be listed in the user's PATH environment variable.
crrev.com/c/2556739 updated third_party/blink/web_tests/http/tests/
loading/sxg/resources/generate-test-sxgs.sh, and this updates the
remaining scripts and READMEs.
Bug: 1151384
Change-Id: I2719fad30d3bb1141fb7abbecb8a2cf1b638a51d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557159
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830883}
--
wpt-commits: 93b6866ff28c52876dce145702c42511150c04bc
wpt-pr: 26633
Automatic update from web-platform-tests
Fixes: unload-a-document tests do not respect wss variant
tests in
third_party/blink/web_tests/external/wpt/websockets/unload-a-document/
have wss variant. But when opening a popup, they don't pass the
location.search parameter to their children. So for example,
001.html?wss will 001-1.html. And since 001-1.html has no knowledge of
the wss param, it will (incorrectly) open an insecure sockets.
Because of that, tests in websockets/unload-a-document always run the
insecure variant.
This patch fixes the issue.
Bug: 801564
Change-Id: Ib88aa1c12dc6f8a390f650b164cd4cd203939a43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552078
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Arnaud Renevier <arenevier@fb.com>
Cr-Commit-Position: refs/heads/master@{#830853}
--
wpt-commits: 03f5a82a30479affb636c7de2f03faf2d3fca441
wpt-pr: 26586
Automatic update from web-platform-tests
Rewrite /wpt/cookies/http-state/attribute.html tests
This is the first of a handful of CLs rewriting the legacy
tests in the ported wpt http-state tests. The plan is to continue
to refine and refactor and eventually rewrite (or delete) them all.
Bug: 1145300
Change-Id: I8a50939f4e2c95c1293ba5423577693ab2a10d9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550362
Commit-Queue: Mike Taylor <miketaylr@chromium.org>
Auto-Submit: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830803}
--
wpt-commits: 20b20fa3c84321b27afdc56890015ddb14f3ecd2
wpt-pr: 26578
Automatic update from web-platform-tests
Fieldset NG: Do not miss to paint a LEGEND with position:relative and
overflow:hidden
In PaintLayerPainter, a layer bounding rectangle for a such LEGEND was
incorrect, and nothing was painted if the anonymous fieldset content
box has a layer.
This CL fixes the issue by handling a rendered LEGEND in
PaintLayer::ContainingLayer().
Bug: 1151295
Change-Id: If133d9179d8ab4c70d9b958aef61cedf547f704f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556626
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830799}
--
wpt-commits: 8eac1e9d426d161539af0bafc926040fa1fdefff
wpt-pr: 26634
Automatic update from web-platform-tests
Python3: Use http.client.HTTPMessage.raw_items() to get header fields (#26391)
This probably is more direct than using .as_string().
--
wpt-commits: 05216524cd3222b50f5d055f97f8fc004a351a8c
wpt-pr: 26391
Automatic update from web-platform-tests
Remove ResponseWriter.flush() and explicit_flush (#26500)
The reliable way to detect aliveness of a socket is to check
wfile.write(). flush() is either not necessary (in Python 2)
or non-functional (in Python 3), and should be removed for clarity.
Fixes#24719 (see more context there)
--
wpt-commits: 388b29a2ed68dfceb87a97673b70660c28f183b0
wpt-pr: 26500
Automatic update from web-platform-tests
Triage border radius clip tests.
Fixed a test/reference mismatch, but after that the failure in Blink is
a subpixel rendering issues.
Bug: 1151922, 997202
Change-Id: Ibed68359944ace2ee75fd810a0ef3afc0364acc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556640
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830640}
--
wpt-commits: 953775938ed1c8630bcf6b0005e396aef9715414
wpt-pr: 26637
Automatic update from web-platform-tests
Gate performance.measureMemory behind self.crossOriginIsolated
This also brings IDL definitions in sync with the spec. To make the
transition simpler, the CL temporarily disables the support for
workers and cross-origin iframes. It will be re-enabled once the
implementation switches fully to PerformanceManager.
Bug: 1085129
Change-Id: I23a36f76bea69f2d4685b0a847909190e1ba0036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552393
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830538}
--
wpt-commits: d17de8939189f21964a7621c65e3800dda8991c8
wpt-pr: 26612
André Bargull
James Graham
Emilio Cobos Álvarez
Eitan Isaacson
Andrei Oprea
Andrew McCreight
prathiksha
moz-wptsync-bot
Nicolás Peña Moreno
Kent Tamura
autofoolip
Camille Lamy
Lan Wei
Andreu Botella
Philipp Hancke
Xida Chen
Chris Harrelson
Robert Ma
adroitwhiz
Stephen McGruer
Kunihiko Sakamoto
Arno Renevier
Mike Taylor
Adithya Srinivasan
ziransun
Rune Lillesveen
Harald Alvestrand
Ulan Degenbaev