The old output had a single value: "atoms-table". The new output looks like
this:
> 649,904 B (00.39%) -- atoms
> ├──350,256 B (00.21%) -- dynamic
> │ ├──235,056 B (00.14%) ── unshared-buffers
> │ └──115,200 B (00.07%) ── atom-objects
> ├──212,992 B (00.13%) ── table
> └───86,656 B (00.05%) ── static/atom-objects
MozReview-Commit-ID: 924vUmxHAlh
--HG--
extra : rebase_source : 6c977546a69eeee62ebc87e335982e8278217484
Switch the order of the IPC FD argument and the crash FD argument in
e10s calls, because the IPC FD is the primary FD, and the crash FD
should be grouped with the crash annotation FD.
MozReview-Commit-ID: CAVyYAIIBPm
--HG--
extra : rebase_source : 02bf7337fa9a6d1194809c224acb4a2690fd87a3
This also changes a few MOZ_LOG() messages to use the error name
instead of the raw numerical nsresult value.
MozReview-Commit-ID: Jcngd0S9j2z
--HG--
extra : rebase_source : f6e974569d8845211e0b25dabef2c41dda2ca1b6
xpt.py only generates constants for a couple of the cases that
XPTConstValue supports. Eliminating the unused cases reduces the size
of this data structure from 64-bit to 32-bit, which reduces the memory
usage of xpti-working set by about 0.02MB.
MozReview-Commit-ID: 1yQkK28fPkR
--HG--
extra : rebase_source : 9d5ce81cfa213cba203ee9c72d2f7dcc8652bd31
num_additional_types is a uint8_t, so its max value is 255. 1 + 255 is
not greater than 256, so the check will pass, but then
num_additional_types += 1 will overflow in the next line.
What I think happened is that bug 1249174 part 6 introduced a bounds
check on an index (which is ok), but then part 8 repurposed this as a
bounds check on the length.
I noticed this because while writing the next patch I ended up with
if (id->num_additional_types > 255)
and then the compiler warned that the check would never fail.
MozReview-Commit-ID: KqiaOyBjj7v
--HG--
extra : rebase_source : 47b20ad2f5e39b05f467cc5b10041070db7fa774
Various strings, like nsISupports, appear many times in XPT data. This
patch adds a cache so we don't write the same string multiple times.
MozReview-Commit-ID: 6buBrXwHqQz
--HG--
extra : rebase_source : 54dea83a9134710c5600828ab68ef3f935f46afd
The name of this class is wrong, but my next patch will make it
actually cache. This patch should not change the behavior.
MozReview-Commit-ID: CMf6Chkeex1
--HG--
extra : rebase_source : a6d5688124b75aef8ed35f811003cf49b8b4e136
The intention is a little more clear with static_assert, as well as
failing sooner. (The code is probably the same, since the compiler will
optimize out the checks as dead code, but meh.)
Reading nsIIDs to binary streams requires 1 + 1 + 1 + 8 calls to Read
for the underlying stream. With the assumption that reading to the
underlying stream for a binary stream is relatively expensive, we should
be able to do better by reading the byte array in an nsIID in a single
Read() request. The same logic applies to writing nsIIDs. Performing a
single operation here should not change the actual bytes read or
written. Performing a single operation also has the virtue of
performing fewer error checks and whatnot.
These are C++ files now. This makes it so the highlighting works if
you use classes, etc.
Also, add Vim modelines.
MozReview-Commit-ID: 6fIkiTDnemt
--HG--
extra : rebase_source : 6232f6bbcf7e19763bbb6ac2cc03290eddb5e608
Without this patch, it's impossible for clients to move a reference into an
nsInterfaceHashtable. That causes at least one extra addref/release pair when
they otherwise could. With this patch, a client can do `hashTable.Put(key,
comptr.forget());` to avoid the additional refcounting.
MozReview-Commit-ID: Ghm7n41ziZp
--HG--
extra : rebase_source : a3e842bf9dfe202134c58e447ecf4fa79851c076
This adds some assertions to make the intended usage of LogModuleManager::Init
more clear.
--HG--
extra : rebase_source : c61e1736cedfbeaa96951ba40cdc954bbc0094d5
These methods will be used in subsequent patches.
MozReview-Commit-ID: EqCpRbn2Y5Y
--HG--
extra : rebase_source : 4b6c2388acb31490a981ca08ba34d4e69c09eddf
The change to RootAccessible.cpp fixes an obvious bug introduced in bug 741707.
The visibility changes in gfx/thebes are because NS_DECL_ISUPPORTS has a
trailing "public:" that those classes were relying on to have public
constructors.
MozReview-Commit-ID: IeB8KIJCGhU
This macro is identical to NS_INTERFACE_MAP_END and encourages the
reader to think that there's something extra-special threadsafe about QI
implementations that use the macro, when in reality there's nothing of
the sort.
Now that this file is all C++, we don't need to duplicate it.
MozReview-Commit-ID: 8nlcGLMnuzV
--HG--
extra : rebase_source : 3fcc2ccd05547de4388f917588d81135b6eb57a8
These are nominally in C, but I don't see any reason for that, given
that we no longer have external consumers. I got rid of "typedef
struct Foo Foo" at the same time.
Also replace a tab I noticed in the definnition of XPT_ANN_LAST.
MozReview-Commit-ID: CFgfiWmuo6r
--HG--
extra : rebase_source : 0bd79ef3055fe1b68a2ec6eaa6eebd0f7e52f730
We don't export these any more, so I don't think there's a reason to
mark them extern.
MozReview-Commit-ID: GbkF7HdRUT6
--HG--
extra : rebase_source : 52e4b72d14bc14d5cfeca110ed4842f2facf356e
These macros haven't done anything since 2006, so get rid of them.
MozReview-Commit-ID: GOakDBIt1Mf
--HG--
extra : rebase_source : 9b0ba6ce42e75aab63c5f63681b37cafe15a367f
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <
Sylvestre Ledru
Olli Pettay
Nicholas Nethercote
Eric Rahm
Eugen Sawin
Gurzau Raul
Jim Chen
Francois Marier
Jason Orendorff
Paul Bone
Tim Taubert
Dorel Luca
Adrian Wielgosik
Masatoshi Kimura
Andrew McCreight
Jeff Walden
Nathan Froyd
Chris Peterson
Peter Van der Beken
Thomas Wisniewski
Blake Kaplan
Kyle Machulis
Kirk Steuber
Nils Ohlmeier [:drno]
Andreea Pavel
Andrea Marchesini
Boris Zbarsky
Ciure Andrei
Kim Moir
Markus Stange
Bogdan Tara
Sebastian Hengst
Josh Matthews
Brindusan Cristian
Xidorn Quan
Cameron McCormack
Coroiu Cristina
Alex Gaynor
Henri Sivonen
Florian Quèze
Gian-Carlo Pascutto
David Major
Cosmin Sabou
Andreas Pehrson
arthur.iakab
Nika Layzell
Kris Maglione
Margareta Eliza Balazs
Daniel Holbert
David Parks
Byron Campen [:bwc]
Ehsan Akhgari
Christian Holler
David Keeler
Simon Fraser