We want to introduce a new pref to block trackers that try to workaround our
heuristic. The pref is called:
privacy.restrict3rdpartystorage.userInteractionRequiredForHosts
The overlap between debug flags and debug commands is a bit of a mess,
and this patch does not entirely clean it up. But this at least means
that the RenderBackend can react to pref changes in Firefox.
Differential Revision: https://phabricator.services.mozilla.com/D11958
This adds the app.update.checkInstallTime pref with a value of false in all tests that have the app.update.disabledForTesting pref except for geckodriver which is covered by bug 1508283.
We only use its value in one place, and said value is easily computable
from readily available information. This change makes iterators
slightly smaller.
Automatic update from web-platform-tests[css-properties-values-api] Support fallbacks.
According to css-variables-1, any custom property that participates in a
cycle is invalid. This also applies to registered custom properties.
In the current implementation, however, registered custom properties
with an initial value can not become invalid; they compute to their initial
value instead, as provided by registerProperty. A consequence of this, is
that fallbacks (specified by var()-references) are never triggered if the
referenced property is a registered property with an initial value defined.
The value for any unregistered custom property, if no other value is
specified, is the invalid initial value described by css-variables-1.
This means we can just avoid storing the variable on ComputedStyle, to
signify the invalid initial value.
However, the value for any registered custom property, if no other value is
specified, can be the initial value specified by registerProperty. When
there is no value explicitly stored on ComputedStyle, we check
StyleInitialData and fetch the initial value from there. Hence, we can not
use the absence of a value to signify an invalid registered variable, as
we already use this state to mean "initial value from registerProperty".
This means that we must explicitly store a value for registered properties
that participate in a cycle. This CL adds CSSInvalidVariableValue to do
this.
* When resolving a registered custom property, if a cycle is detected, set
the registered value to CSSInvalidVariableValue.
* When looking up a registered custom property, if we already have the
value CSSInvalidVariableValue, return nullptr instead of initial data.
This triggers fallbacks.
* The code that set the cycle_detected flag was weird; a cycle could be
marked as detected, even though ResolveTokenRange succeeded. This meant
that any custom property which referenced a property in a cycle would
also be treated as part of the cycle, which is wrong. Fixed by only
setting the cycle_detected flag when we have cycle start points.
* CSSInterpolationType did not initialize its cycle_detected variable,
which led to undefined behavior.
R=futhark@chromium.org
Bug: 641877
Change-Id: I2c518b176de26f7b2f05b36b568041a228fcb0ea
Reviewed-on: https://chromium-review.googlesource.com/c/1333758
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608014}
--
wpt-commits: f082fd63300fec7b6201cf5e0eaf0944ee7ccb6e
wpt-pr: 14039
Automatic update from web-platform-testsFix background image painting of very small images
The background image fast path painting rounds the image src rect
to integer sizes assuming sprite maps and/or reasonably large images.
When a very small image is used scaled up to a large size (such as
constant color images scaled up to form progress bars by animating
background size) the src rect may be 1 x [small number] which gets
rounded to zero size.
This patch changes the code to detect this situation and not round
in such cases.
It's worth recording that an alternate approach is to detect when
the rounding results in a significant change in src rect and always
switch to unrounded in that case. But it would be more expensive for
a relatively uncommon case.
R=fmalita
BUG=904042
Change-Id: I24657a5d087c0dda0fd8a5e3c3d08e1e4eb02473
Reviewed-on: https://chromium-review.googlesource.com/c/1334291
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607901}
--
wpt-commits: e1a59fb1af26d892ffee739205d1ab536d0d2819
wpt-pr: 14042
Automatic update from web-platform-tests[Picture-in-Picture] Fix shadow dom crash when exiting PiP.
This CL fixes a tab crash that occurs when calling document.exitPictureInPicture()
if a video in a shadow DOM is already in Picture-in-Picture.
Bug: 904828
Change-Id: I6aed0fa43dd0af1406d4349509101d423f622d96
Reviewed-on: https://chromium-review.googlesource.com/c/1333769
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#607658}
--
wpt-commits: ef5a7d3d1423bcd7a009c7b1b804b928d284289d
wpt-pr: 14035
Automatic update from web-platform-testsFixes and tweaks to wpt/css/filter-effects/
filter-contrast-003.html
Adjust the color from #400000 to #3f0000, since (0x40 / 255) is just
over 0.25 and can after filtering and rounding end up above 0.
(0x3f / 255) on the other hand is just below 0.25 and the result will
be clamped to zero.
filter-external-001-test.html
filter-external-002-test.html
Change the hue-rotate parameter in the external file from 120 to 150.
Move the file to support/ and remove lint entry.
Make both filters operate in sRGB to make computing the reference
easier. Use rgb(...) notation with percentage values in reference.
fecolormatrix-type.html
Add color-interpolation-filters=sRGB to the filter to make it easier
to reason about what the result should be. Use rgba(...) notation in
the ref using percentage notation.
filters-test-brightness-003.html
Add 'filter: brightness(0)' before 'filter: brightness()' to properly
test if the "no argument" notation is considered valid by the parser.
filter-grayscale-001.html
filter-grayscale-002.html
filter-grayscale-003.html
filter-grayscale-004.html
filter-grayscale-005.html
Remove the " (and not blue)" text from the reference and update the
001,004 and 005 tests accordingly.
css-filters-animation-saturate.html
Interpolate the argument from 4900% rather than 5000% to end at the
ref's 2500% (25).
css-filters-animation-hue-rotate.html
Sample the animation at .5 to match the expectation.
css-filters-animation-drop-shadow.html
Use explicit rgba(...) in the ref rather than the keyword 'gray'.
We're interpolating the color of the drop-shadow from 'black'
(rgba(0, 0, 0, 1)) to 'transparent' (rgba(0, 0, 0, 0)) here, so it's
better and more accurate to describe the color as "semi-transparent
black" (rgba(0, 0, 0, 0.5)).
css-filters-animation-combined-001.html
Initial value for animation for 'opacity(...)' is '1' - not zero.
Change test to interpolate from 0 -> 1 (rather than 1 -> 1)
Bug: 903383
Change-Id: I4d0113989414616494b98c22fbac817f007cd762
Reviewed-on: https://chromium-review.googlesource.com/c/1333816
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#607628}
--
wpt-commits: 4cf6f845d427b856b1d7557aeaf02c199e6e1d81
wpt-pr: 14038
Automatic update from web-platform-testsFetch: Access-Control-Expose-Headers parsing
See https://github.com/whatwg/fetch/issues/814 for context.
--
wpt-commits: 645c0e8a5c028a613e7ad1732834100dbe946fc7
wpt-pr: 13849
Automatic update from web-platform-testsAdd redirected cases to CSP/import tests in wpt/worklets
Also this CL replaces some of empty-worklet-script.js usage
in CSP tests with empty-worklet-script-with-cors-header.js
to make sure worklets are rejected due to CSP, not CORS.
Change-Id: Ie463d206254c4c6728a79dae0ad79e4f7e333b92
Reviewed-on: https://chromium-review.googlesource.com/c/1312146
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606846}
--
wpt-commits: d49968742cb5af8ed3e93fb1073f2a8249245e58
wpt-pr: 13864
Philip Chimento
Gabriel Luong
Magnus Melin
Ciure Andrei
Marco Castelluccio
Robert Strong
Ting-Yu Lin
Luke Wagner
Jonathan Kew
Andrew Osmond
chandranvishwaak@gmail.com
Jason Laster
Andrea Marchesini
Daniel Varga
Bobby Holley
Nathan Froyd
Geoff Brown
Ryan VanderMeulen
Luke Schwalfenberg
Sylvestre Ledru
James Graham
moz-wptsync-bot
Anders Hartvoll Ruud
Youenn Fablet
Stephen Chenney
François Beaufort
Steve Anton
Fredrik Söderquist
Anne van Kesteren
Ms2ger
Hiroshige Hayashizaki