This patch draws a 1px black line around the Urlbar in macOS HCM, which resembles other high contrast macOS apps. This patch only supports Light HCM mode. Since we apply the Firefox Dark lwttheme when in Dark mode, and we do not support lightweight themes in high contrast mode, significantly more work is required to implement basic support for dark HCM on Mac.
Differential Revision: https://phabricator.services.mozilla.com/D116406
It seems like this test occasionally goes over our time budget not because it
falls off of some cliff and hangs somewhere for a chunk of time, but just
because it's big. Accordingly, this patch just splits it up.
Differential Revision: https://phabricator.services.mozilla.com/D120017
The functions were only called from RDM ui `updateTouchSimulation`, before
the call to updateConfiguration for touch simulation, based on the touch simulation value.
This means we can directly set the proper flag on the docShell in
BrowsingContextTargetActor#updateTargetConfiguration before handling touch simulation.
The devtools.responsive.metaViewport.enabled pref is removed, as it was set to
true by default, and wasn't exposed in any UI.
Differential Revision: https://phabricator.services.mozilla.com/D120456
If one closes the last tab with the session restore enabled, it will re-open after restart.
Fix that by closing completely the tabs before the stop of the browser.
Differential Revision: https://phabricator.services.mozilla.com/D118270
This patch also addresses bug 1645293. It essentially reverts parts 1 and 3 of bug 1616700 for users with searching disabled. Since we had to introduce branching behaviour, there are some new constructs like a shouldHandOffToSearchMode multi-pref in UrlbarPrefs.
Differential Revision: https://phabricator.services.mozilla.com/D118606
The Netmonitor used to call the WebConsoleFront `getString` method to get the full
text of a long string. This could make some test to fail with Fission and target
switching.
Since the webconsole actor is not even involved in the webconsole method, there's
no reason to keep using it. A similar function is added into a util file; the only
difference is that it doesn't cache the front it creates, which does not matter
as the netmonitor only calls this once and then put the full text in its redux
store.
This allows us to re-enable `browser_ext_devtools_network.js` with Fission.
Differential Revision: https://phabricator.services.mozilla.com/D120333
The helper is already calling `gDevTools.closeToolboxForTab`, which does take care
of destroying its associated descriptor.
This makes some extension test to pass with server side target switching enabled.
Differential Revision: https://phabricator.services.mozilla.com/D120332
If one closes the last tab with the session restore enabled, it will re-open after restart.
Fix that by closing completely the tabs before the stop of the browser.
Differential Revision: https://phabricator.services.mozilla.com/D118270
Unify shared declarations, and avoid unneeded [placespopup=true], since
there's no element that matches:
:is(#BMB_bookmarksPopup, #PlacesToolbar) menupopup:not([placespopup])
Depends on D120080
Differential Revision: https://phabricator.services.mozilla.com/D120197
With the system theme otherwise we show square corners.
Also remove a margin rule which other menupopups don't have and which feels a
bit ugly, but let me know if you want that one back (without the :-moz-lwtheme
selector).
Differential Revision: https://phabricator.services.mozilla.com/D120080
This avoids starting autoscroll on SVG links, and on HTML links that
contain SVG, by sharing the code that browser's ClickHandlerChild uses
to detect links into BrowserUtils, and using that from AutoScrollChild
to determine if the click happened on top of a link. It also adds a
test so we avoid regressing this in future.
When running the test, I noticed an error from ClickHandlerParent
when the browser for which we receive a click has gone away, and
fixed it by adding a nullcheck and early return.
Differential Revision: https://phabricator.services.mozilla.com/D120024
Butkovits Atila
Bernard Igiri
Dan Mosedale
Kajal Sah
Harry Twyford
Thomas Wisniewski
Mathew Hodson
Andrei Oprea
Doug Thayer
Gijs Kruitbosch
Luz De La Rosa
Nicolas Chevobbe
Antonin LOUBIERE
Emma Malysz
Cosmin Sabou
Michael Cooper
Stefan Zabka
Neil Deakin
Emily McMinn
Sandor Molnar
Alexandru Michis
Brindusan Cristian
Emilio Cobos Álvarez
Dave Townsend
Marian-Vasile Laza
Nan Jiang
Barret Rennie
Daisuke Akatsuka
Csoregi Natalia
Sam Foster
Andre Natal