-Wshadow warnings are not enabled globally, so these -Wno-shadow suppressions have no effect. I had intended to enable -Wshadow globally along with these suppressions in some directories (in bug 1272513), but that was blocked by other issues.
There are too many -Wshadow warnings (now over 2000) to realistically fix them all. We should remove all these unnecessary -Wno-shadow flags cluttering many moz.build files.
Differential Revision: https://phabricator.services.mozilla.com/D132289
Patch suggested by Jan Alexander Steffens <jan.steffens@gmail.com>
From the spec (https://w3c.github.io/pointerlock/):
> this specification defines the movement deltas to be taken from how
> the system mouse cursor moves, which incorporates operating system
> filtering and acceleration of the mouse movement data
Also directly convert to `int` to avoid `narrowing conversion from 'double' to 'int'`
warnings.
Differential Revision: https://phabricator.services.mozilla.com/D132475
It's only meaningfully read in two places:
* WebRender fallback code.
* Some widget DEBUG-only code, which on Linux is ifdef'd and on Windows does
some rather sketchy things like sleeping for 30ms
So I think it should be ok to remove, since WR fallback has its own flashing
pref as well, IIUC.
Differential Revision: https://phabricator.services.mozilla.com/D132313
When we use OP_OVER for the final blit in WindowSurfaceX11Image::Commit,
this causes Cairo to hit a compositing fallback that uses XGetImage on
the window to get the pixel data, blends to it, then XPutImage's the
result back. We want to avoid this both because XGetImage may cause
errors and it is slow to read back from the window server.
If we use CopySurface/OP_SOURCE instead we avoid the readback via
XGetImage and so bypass both problems.
Differential Revision: https://phabricator.services.mozilla.com/D132319
This is based off work by smurfd. But this patch doesn't support buttons
both at the left and right, which simplifies a lot the implementation.
Also, clean-up the existing env variables while at it.
Co-authored-by: Nicklas Boman <smurfd@gmail.com>
Differential Revision: https://phabricator.services.mozilla.com/D132073
`470.82` is the first version that supports `EGL_NV_robustness_video_memory_purge`
which is required so we don't run into bug 1731172. The first stable release of
the `495` series also supports that extension, previous beta versions don't need
to be considered.
Differential Revision: https://phabricator.services.mozilla.com/D132101
The previous patches mean that VA-API shouldn't cause sandbox violations
in the RDD process, so there's no need to lock it out.
This patch does **not** change the prefs to enable it
(`media.rdd-ffmpeg.enabled` and `media.ffmpeg.vaapi.enabled`), but now
those prefs will be honored if they are flipped, to allow testing.
Differential Revision: https://phabricator.services.mozilla.com/D131681
- Make mCompositorState atomic to avoid thread race conditions.
- Remove !mIsDestroyed check from IsWaitingForCompositorResume() and keep only mCompositorState == COMPOSITOR_PAUSED_FLICKERING there.
We already set mCompositorState = COMPOSITOR_PAUSED_MISSING_WINDOW on Destroy().
Differential Revision: https://phabricator.services.mozilla.com/D131593
We can create DMABufSurface objects via deserialization without ever
setting a GL context. We must ensure we close the file handle even if we
don't have one.
Differential Revision: https://phabricator.services.mozilla.com/D131561
When application/x-moz-file-promise MIME content is adverised, save the file to /tmp/dnd_file-*/ directory and
offer it as text/uri-list MIME type.
Based on patch by Tobias Koenig.
Differential Revision: https://phabricator.services.mozilla.com/D130767
I don't know whether all this style provider business is still
necessary looking at bug 1461307, but this should help by avoiding
initializing LookAndFeel too early in any case.
Differential Revision: https://phabricator.services.mozilla.com/D130633
With some care, applying the margin to the anchor rather than as a fixed
margin to the popup makes it work correctly when flipping.
Differential Revision: https://phabricator.services.mozilla.com/D130384
`gdk` takes `touch-move` and `touch-end` events when dragging the window.
As a result, the touch-start event was propagated, but not touch-end. As a result, all additional touches were considered part of the same gesture as the touch that started moving the window! This affected some Linux distros with the environment variable MOZ_USE_XINPUT2 set to 1.
This patch fixes that by sending a TouchCancel event just before we transfer the touch gesture to GDK.
Differential Revision: https://phabricator.services.mozilla.com/D129349
These are only used for frameset painting and the non-e10s <select>
dropdown focus codepath. We have other more appropriate standard
colors for this.
Differential Revision: https://phabricator.services.mozilla.com/D129992
Chris Peterson
Robert Mader
Emilio Cobos Álvarez
stransky
Lee Salzman
elfarto
Jed Davis
Andrew Osmond
sotaro
Stephen A Pohl
Andi-Bogdan Postelnicu
criss
Henry Heino
ssummar
Cristian Tuns