js/xpconnect/src/ExportHelpers.cpp(59,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'xpc::StackScopedCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_REFLECTOR) {
~~~~ ^ ~~~~~~~~~~~~~~~
js/xpconnect/src/ExportHelpers.cpp(79,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'xpc::StackScopedCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_FUNCTION) {
~~~~ ^ ~~~~~~~~~~~~~~
js/xpconnect/src/ExportHelpers.cpp(98,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'xpc::StackScopedCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_BLOB) {
~~~~ ^ ~~~~~~~~~~
toolkit/components/extensions/webidl-api/ExtensionAPIRequestForwarder.cpp(250,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == dom::SCTAG_DOM_CLONED_ERROR_OBJECT) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(132,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_BLOB) {
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(140,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_FILE_WITHOUT_LASTMODIFIEDDATE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(435,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_EXPANDED_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(434,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_CONTENT_PRINCIPAL ||
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(433,48): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_NULL_PRINCIPAL || aTag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(433,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_NULL_PRINCIPAL || aTag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(741,15): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (tag == SCTAG_DOM_BLOB) {
~~~ ^ ~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(763,22): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
} else if (tag == SCTAG_DOM_DIRECTORY) {
~~~ ^ ~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(957,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_BLOB) {
~~~~ ^ ~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(961,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_DIRECTORY) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(965,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_FILELIST) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(969,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_FORMDATA) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(973,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_IMAGEBITMAP &&
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(986,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_STRUCTURED_CLONE_HOLDER) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(990,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_WASM_MODULE &&
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(996,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_INPUTSTREAM) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1000,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_BROWSING_CONTEXT) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1004,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_CLONED_ERROR_OBJECT) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1124,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_MAP_MESSAGEPORT) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1152,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_CANVAS &&
~~~~ ^ ~~~~~~~~~~~~~~~~
dom/base/StructuredCloneHolder.cpp(1171,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_IMAGEBITMAP &&
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,45): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(378,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_FILE_WITHOUT_LASTMODIFIEDDATE ||
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(383,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(416,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_MUTABLEFILE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,45): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(379,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(378,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_FILE_WITHOUT_LASTMODIFIEDDATE ||
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(383,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(416,14): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_MUTABLEFILE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(220,19): error: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aData.tag == SCTAG_DOM_BLOB) {
~~~~~~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(220,19): error: comparison of integers of different signs: 'const uint32_t' (aka 'const unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aData.tag == SCTAG_DOM_BLOB) {
~~~~~~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IndexedDatabase.cpp(380,45): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE || aTag == SCTAG_DOM_WASM_MODULE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(118,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
tag == SCTAG_DOM_WORKER_PRINCIPAL)) {
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(117,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
tag == SCTAG_DOM_EXPANDED_PRINCIPAL ||
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(116,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
tag == SCTAG_DOM_CONTENT_PRINCIPAL ||
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(115,48): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (!(tag == SCTAG_DOM_NULL_PRINCIPAL || tag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(115,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (!(tag == SCTAG_DOM_NULL_PRINCIPAL || tag == SCTAG_DOM_SYSTEM_PRINCIPAL ||
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(206,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_SYSTEM_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(208,19): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
} else if (aTag == SCTAG_DOM_NULL_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(217,19): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
} else if (aTag == SCTAG_DOM_EXPANDED_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(239,19): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
} else if (aTag == SCTAG_DOM_CONTENT_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
caps/nsJSPrincipals.cpp(299,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_WORKER_PRINCIPAL) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
js/xpconnect/src/XPCCallContext.cpp(90,12): error: comparison of integers of different signs: 'unsigned int' and 'XPCCallContext::(unnamed enum at js/xpconnect/src/xpcprivate.h:671:3)' [-Werror,-Wsign-compare]
if (argc != NO_ARGS) {
~~~~ ^ ~~~~~~~
dom/indexedDB/IDBObjectStore.cpp(406,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
aTag == SCTAG_DOM_MUTABLEFILE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
dom/indexedDB/IDBObjectStore.cpp(405,38): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/indexedDB/IDBObjectStore.cpp(405,12): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::StructuredCloneTags' [-Werror,-Wsign-compare]
if (aTag == SCTAG_DOM_BLOB || aTag == SCTAG_DOM_FILE ||
~~~~ ^ ~~~~~~~~~~~~~~
dom/base/Document.cpp(14003,39): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::FullscreenRoots::(unnamed enum at dom/base/Document.cpp:13965:3)' [-Werror,-Wsign-compare]
return FullscreenRoots::Find(aRoot) != NotFound;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~
dom/base/Document.cpp(14040,13): error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'mozilla::dom::FullscreenRoots::(unnamed enum at dom/base/Document.cpp:13965:3)' [-Werror,-Wsign-compare]
if (index == NotFound || !sInstance) {
~~~~~ ^ ~~~~~~~~
Differential Revision: https://phabricator.services.mozilla.com/D144689
dom/media/ipc/RDDProcessManager.cpp(320,21): error: comparison of integers of different signs: 'base::ProcessId' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
gpuProcessPid != -1 ? gpuProcessPid : base::GetCurrentProcId();
~~~~~~~~~~~~~ ^ ~~
dom/media/ipc/RDDProcessManager.cpp(332,21): error: comparison of integers of different signs: 'base::ProcessId' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
if (gpuProcessPid != -1) {
~~~~~~~~~~~~~ ^ ~~
gfx/layers/ipc/SharedSurfacesParent.cpp(360,38): error: comparison of integers of different signs: 'base::ProcessId' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
if (!gpm || gpm->GPUProcessPid() != -1) {
~~~~~~~~~~~~~~~~~~~~ ^ ~~
ipc/glue/MessageChannel.cpp(2145,13): error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'const base::ProcessId' (aka 'const unsigned long') [-Werror,-Wsign-compare]
if (pid != base::kInvalidProcessId &&
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~
Differential Revision: https://phabricator.services.mozilla.com/D144688
There are some mediaqueries-5 features that we still don't support and
explain the remaining failures in at-container-{parsing,serialization}.
Differential Revision: https://phabricator.services.mozilla.com/D144446
dom/system/PathUtils.cpp(77,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return false;
^~~~~
ipc/chromium/src/chrome/common/ipc_channel_win.cc(479,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return true;
^~~~
mozglue/misc/PreXULSkeletonUI.cpp(1263,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return 0;
^
mozglue/tests/TestPEExportSection.cpp(348,12): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return 0;
^
security/manager/ssl/OSReauthenticator.cpp(428,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return NS_OK;
^~~~~
toolkit/components/maintenanceservice/maintenanceservice.cpp(214,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return 0;
^
widget/windows/WindowsUIUtils.cpp(383,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return false;
^~~~~
Differential Revision: https://phabricator.services.mozilla.com/D144661
js/src/jit/x86-shared/Architecture-x86-shared.h(326,9): error: signed bit-field 'reg_' needs an extra bit to represent the largest positive enumerators of 'XMMRegisterID' [-Werror,-Wbitfield-enum-conversion]
: reg_(Codes::Encoding(r)), type_(k), isInvalid_(false) {}
^
js/src/jit/x86-shared/Architecture-x86-shared.h(310,3): note: consider making the bitfield type unsigned
Codes::Encoding reg_ : 5;
^~~~~~~~~~~~~~~
(...)
js/src/jit/RangeAnalysis.h(378,28): error: signed bit-field 'canHaveFractionalPart_' needs an extra bit to represent the largest positive enumerators of 'FractionalPartFlag' [-Werror,-Wbitfield-enum-conversion]
canHaveFractionalPart_ = canHaveFractionalPart;
^
js/src/jit/RangeAnalysis.h(227,25): note: consider making the bitfield type unsigned
MOZ_INIT_OUTSIDE_CTOR FractionalPartFlag canHaveFractionalPart_ : 1;
^~~~~~~~~~~~~~~~~~
(...)
js/src/jit/RangeAnalysis.h(379,24): error: signed bit-field 'canBeNegativeZero_' needs an extra bit to represent the largest positive enumerators of 'NegativeZeroFlag' [-Werror,-Wbitfield-enum-conversion]
canBeNegativeZero_ = canBeNegativeZero;
^
js/src/jit/RangeAnalysis.h(228,25): note: consider making the bitfield type unsigned
MOZ_INIT_OUTSIDE_CTOR NegativeZeroFlag canBeNegativeZero_ : 1;
^~~~~~~~~~~~~~~~
Differential Revision: https://phabricator.services.mozilla.com/D144664
The upstream OpenH264 encoder has been doing this since:
"Use QualityScaler for OpenH264 encoder.": 6d3e0c22c31bab111be833d598eea6118dfe0e83
This is needed for the quality scaler to work properly when using H264.
Differential Revision: https://phabricator.services.mozilla.com/D144717
Basically, the transferred min & max sizes shouldn't override the min &
max sizing properties, so applying it earlier than these properties
should be identical. This just makes the flex base size and main size be
more correct at the beginning (and so other adjustments of sizes
in flex algorithm can override the transferred min/max sizes), for
non-replaced elements.
Note:
In Chromium code, it clamps the flex items' base size by transferred min &
max sizes, but the computation of items' used min & used max sizes doesn't
include the transferred min & max sizes.
So in this patch, I'm trying to make this patch simple: we let minimum &
maximum sizes only taken into account for flex base size and only for
non-replaced elements for now. So the behavior should be similar to other
browsers.
And we may have to update this tentative solution once these spec words get
updated.
Differential Revision: https://phabricator.services.mozilla.com/D144499
This test tests for a bug I discovered in my code that would crash the browser
if certain User Timing APIs were called on the dying iframe global.
I created a new test, rather than using test_performance_user_timing.html,
because it seemed like the code I added to set up the iframe did not easily fit
into the testing model of test_performance_user_timing.
Differential Revision: https://phabricator.services.mozilla.com/D143214
In the existing code, these tests will pass if detail is a nonsense value, like
undefined, e.g. since undefined does not equal the original value. The code I
added makes sure the values are accurate too. This pattern already existed in
the first test in the file.
Differential Revision: https://phabricator.services.mozilla.com/D142627
To follow the spec more closely, some functionality moved from
`performance.mark` to the PerformanceMark constructor.
I verified the new fingerprinting protection behavior with :tjr: they said it's
okay to return a PerformanceMark as long as it uses the same reduced precision
of `performance.now`.
Differential Revision: https://phabricator.services.mozilla.com/D142625
The web standard linked from MessagePort.webidl doesn't make it quickly clear
what StructuredSerializeOptions is used for so I added a brief summary to make
it quicker to figure out. Note: I don't have much experience with this class so
my description may be incomplete.
Differential Revision: https://phabricator.services.mozilla.com/D142624
It is believed that loading this COM interface is causing crashes by bringing in shell extension DLLS. This patch retrieves it through alternate means (the same way that ShellExecuteByExplorer does already).
It also fixes BSTR handling and does some general cleanup that was requested (and needed).
Differential Revision: https://phabricator.services.mozilla.com/D143776
Mark Banner
Julian Descottes
Edgar Chen
Mike Hommey
Emilio Cobos Álvarez
Henri Sivonen
Florian Quèze
Henrik Skupin
Molnar Sandor
Masayuki Nakano
Gerald Squelart
Tomislav Jovanovic
Eitan Isaacson
James Teh
Jonathan Watt
Nika Layzell
Dan Mosedale
Tim Giles
Jeff Muizelaar
Steve Fink
Norisz Fay
Boris Chiou
Michael Comella
Byron Campen
Ben Hearsum
Gabriele Svelto
Meg Viar