Automatic update from web-platform-testsFix box-shadow clipping for opaque-background <body>
In the presence of an opaque background,
BoxPainterBase::PaintNormalBoxShadow() insets the shadow clip by one
unit (in order to mitigate seaming artifacs), effectively expanding the
shadow inwards, and relies on the opaque background overdrawing this
inset.
But <body> doesn't paint its own background -- it gets transferred to
the view and painted in a different context => the shadow inset remains
visible.
To address this, pass background-skip information to
PaintNormalBoxShadow(), and disable the inset logic when the background
is not being drawn.
Bug: 899342
Change-Id: I5e04a1c17c2be324bf4c6767d2159372f546cc24
Reviewed-on: https://chromium-review.googlesource.com/c/1336495
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#609014}
--
wpt-commits: 44a54b7ededf2dc68fe9b3d2d6f2dca4f1f8372d
wpt-pr: 14067
Automatic update from web-platform-testsViolation reports for 'layout-animations'
This CL adds support for generating violation reports for 'layout-animations'
feature policy. The new implementation triggers a report when:
1- CSS Parser finds usage of @keyframes for one of the banned styles.
2- element.animate() changes a banned style.
Bug: 902836,867471
Change-Id: I79900603eb0166514d7986dc189ec914bd95f899
Reviewed-on: https://chromium-review.googlesource.com/c/1324138
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608984}
--
wpt-commits: b8ac03b76dc36f29c66bef25bc69c322b85dc57c
wpt-pr: 13972
Automatic update from web-platform-testsFix a typo in css/css-text/writing-system/ already fixed in ref (#14097)
The typo in the ref was fixed in
https://github.com/web-platform-tests/wpt/pull/13430, but the test
itself was not updated. That's bad.
--
wpt-commits: 0601d669f54ea46df0c1b08b9927ad6933a06fd3
wpt-pr: 14097
Automatic update from web-platform-testsSVG Geometry: computed value of properties (#14075)
cx cy r rx ry x y computed values are lengths or percentages.
https://svgwg.org/svg2-draft/geometry.html
--
wpt-commits: 39c2331ea623e23849d2f6fc99f804e5e2d374d2
wpt-pr: 14075
Automatic update from web-platform-tests[css-logical] Fix logical values according to the spec
Spec: https://drafts.csswg.org/css-logical/#directional-keywords
Currently logical values compute to the corresponding physical value,
and the mapping is with respect to the element itself. This patch
makes them compute as specified and changes the mapping to be with
respect to the containing block.
BUG=901409
TEST=external/wpt/css/css-logical/logical-values-float-clear.html
TEST=external/wpt/css/css-logical/logical-values-float-clear-reftest.html
TEST=external/wpt/css/css-logical/logical-values-resize.html
TEST=webexposed/nonstable-css-properties.html
Change-Id: Ie0acaacde813c5343ec3bb8de712c4af03639475
Reviewed-on: https://chromium-review.googlesource.com/c/1315989
Commit-Queue: Manuel Rego <rego@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608730}
--
wpt-commits: 68eabe4d5bf5bed82dcdcc33e8b9e54a45d55307
wpt-pr: 13928
Automatic update from web-platform-tests[css-grid] Some fixes on grid-container-scrollbar-* tests
* Use Ahem font to avoid weird small pixel differences on iOS.
* Fix some typos reported by @fred-wang at https://bugs.webkit.org/show_bug.cgi?id=191656#c14
--
Merge pull request #14092 from mrego/grid-container-scrollbars
[css-grid] Some fixes on grid-container-scrollbar-* tests
--
wpt-commits: ef7824a8ff88c95d36b31b377fe252f7c56d2da0, 1b543a1083f48c13b25f23a5f23d14f6ade958d4
wpt-pr: 14092
Automatic update from web-platform-testsFetch: test no-cors Headers API better
For https://github.com/whatwg/fetch/pull/833.
--
wpt-commits: ccb1c202a4ad83d88fe9bc133e2816b86e4bcfd2
wpt-pr: 14079
Automatic update from web-platform-testsservice worker: Let register('data://blah') throw a TypeError
register('data://blah') should throw a TypeError instead of SecurityError.
If scopeURL’s scheme is not one of "http" and "https", reject promise
with a TypeError and abort these steps.[1]
[1]: https://w3c.github.io/ServiceWorker/#start-register-algorithm
Bug: 877138
Change-Id: Ic1e8cae52ec9393152044aa37da389eb499165bb
Reviewed-on: https://chromium-review.googlesource.com/c/1189688
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608635}
--
wpt-commits: 64ee30dc4f4c7cd5016ffcfbbb6e1012b978ed66
wpt-pr: 14048
Automatic update from web-platform-testsFix serialization of computed style for 'paint-order'
We were always serializing as the completed (all keywords present) form,
which is not the shortest canonical form.
https://svgwg.org/svg2-draft/painting.html#PaintOrder
Fold the ComputedStyleUtils helper into the PaintOrder CSSProperty
class, since this is very specific to this property.
Matches WebKit and almost Gecko (which seems to handle some "two
keyword" cases differently.)
Bug: 904898
Change-Id: Ib796a111e601485e339fdf2739a587fb5f893b8a
Reviewed-on: https://chromium-review.googlesource.com/c/1335579
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608623}
--
wpt-commits: 8ffe6b78eb915feefba921914f47c40b6f1880e6
wpt-pr: 14077
Automatic update from web-platform-testsCheck including the error message from Error constructor as required
--
wpt-commits: b4c61af0f410976b96279df7f75715091619057d
wpt-pr: 14036
Automatic update from web-platform-tests[UserTimingL3] Fix meature, mark API feature detection
UserTimingL3 uses returned value for feature detection. If measure and mark
API returns null, the APIs are L2 API; If the APIs return an entry, the APIs are
L3 API. However, in the current implementation, when L3 API is enabled, the
APIs do not always return the created entry.
This CL is to fix this bug, and add layout tests to verify it.
Change-Id: I9854f0abd0d64a3334701e09d6ce0fc245fcca3e
Reviewed-on: https://chromium-review.googlesource.com/c/1338225
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608552}
--
wpt-commits: a4efb68eb4bb30453a6c958ad58f8c2540dc967e
wpt-pr: 14084
Automatic update from web-platform-testsAdding more layout/WPT tests for backdrop-filter
These should reproduce (at least) these issues:
- https://crbug.com/622128 - dark areas brought in from edges
- https://crbug.com/632979 - dark areas brought in from edges
- https://crbug.com/659501 - menus cause too much filtering
- https://crbug.com/767997 - menus cause too much filtering
- https://crbug.com/813796 - incorrect border used for filter
- https://crbug.com/593307 - incorrect border used for filter
Bug: 497522,622128,632979,659501,767997,813796,593307
Change-Id: Iafea2fc8fffba950f74d27f21170df647dc62e29
Reviewed-on: https://chromium-review.googlesource.com/c/1330888
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608537}
--
wpt-commits: a2fb878b4b9e4164437357f2bfba4c28e8c0e1ea
wpt-pr: 14026
Automatic update from web-platform-testsKeep animations running going to/from fullscreen.
LazyReattachIfAttached() nukes the computed styles synchronously so that
we are not able to keep animations alive for the next lifecycle update.
Add a bit on Node to say that we need a forced layout tree reattach and
trigger the re-attach from style recalc instead.
Bug: 900162
Change-Id: I22f51f5e091932fc8a63213af88903c7866abbb4
Reviewed-on: https://chromium-review.googlesource.com/c/1333809
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608530}
--
wpt-commits: 9fcbfa0a6c02e373780f897dcf5282907180e49a
wpt-pr: 14034
Automatic update from web-platform-testsAdd report-only mode to Feature Policy
This change adds a "report-only" policy to each security context, which
is local to that context (not replicated across processes) and is used
to determine whether a report should be sent even if a feature is
enabled, when the feature is used.
Reports are now augmented with a "disposition" field, which is either
"enforce", if the feature usage was actually blocked, or "report", if
it was not.
Feature policy directives are placed in the report-only policy if the
feature name is suffixed with "-report-only", otherwise, they affect
the regular (enforcing) policy.
Explainer at
https://github.com/WICG/feature-policy/blob/master/reporting.md
Existing tests are updated, and new tests for report-only mode are
added to ensure that reports are sent even when the feature is used
successfully.
Bug: 904878
Change-Id: I27bc42729c5ab5560160f3d993431e606a8a3a47
Reviewed-on: https://chromium-review.googlesource.com/c/1178811
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608004}
--
wpt-commits: b39f5e0d0e0872cdd9b7592f0b9ff0b5c11bcef3
wpt-pr: 13984
Automatic update from web-platform-tests[LongTasks] Change TaskAttributionTiming name to 'unknown'
At TPAC, we agreed that 'script' is confusing because it implies that
longtasks only measure script work. Thus, we decided to change the name
to 'unknown'. Also see https://github.com/w3c/longtasks/issues/47.
Change-Id: I5a0666d0fa078bfeac8ab6e8397b9b51aca3e833
Reviewed-on: https://chromium-review.googlesource.com/c/1336367
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608479}
--
wpt-commits: 4309ceb7b165a42534514ca9933846cc0912bdae
wpt-pr: 14063
Automatic update from web-platform-testsImprove robustness of wpt animation interpolation tests.
This patch fixes the problem where subtle changes to numerical values in matrix interpolation cause mismatches in the expected results.
To address the issue:
* Styles are checked to see if they are of the form matrix(...) or matrix3d(...).
* If the style is a matrix, then arguments are rounded and the style is reconstructed.
Bug: 797472
Change-Id: I44d6e0ed13e24dc2ecfeeacbcd4809d6dcdb6465
Reviewed-on: https://chromium-review.googlesource.com/c/1337640
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608466}
--
wpt-commits: 794b7ee9292f09802cd41e41a04be420b1d7bec3
wpt-pr: 14080
Automatic update from web-platform-tests[css-flex] align-content should apply even when there's just a single line
In Jan 2015 the spec changed in
https://drafts.csswg.org/css-flexbox/#change-201409-align-content-wrapping
Change our code accordingly. This effectively reverts commit
crrev.com/290823003 and relands crrev.com/2191683003
align-content-wrap-004 is a test for bug 641789, which was a regression
from the previous attempt at landing this patch.
Bug: 599828
Change-Id: I8de127c19203854922eb23a626cee4de9a772f22
Reviewed-on: https://chromium-review.googlesource.com/c/1323906
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608449}
--
wpt-commits: 34ecd56f063821c113fd20bcb05b80aafd82d787
wpt-pr: 14062
Automatic update from web-platform-testsFloats in a next fragmentainer may push lines down.
We cannot assume that when we push a line to the next fragmentainer
(because it doesn't fit in the current one), the line is going to fit
there. If the next fragmentainer has a float that nothing fits beside
and the float is too tall to fit the line below it, we need to jump to
yet another fragmentainer in order to find room for the line.
Bug: 902762
Change-Id: Ied14694ed1ad4fc25d28527edd1ca7389f00664c
Reviewed-on: https://chromium-review.googlesource.com/c/1335580
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608414}
--
wpt-commits: a218e2f1678badf75722fd444524d98cd5996b3f
wpt-pr: 14058
Automatic update from web-platform-tests[css-properties-values-api] Validate var() fallbacks.
According to a recent spec edit, any fallback in a var()-reference must
match the syntax of the referenced property, otherwise the var()-reference
is invalid. This applies even if the fallback is not used.
To implement this, ResolveFallback now returns kNone/kFail/kSuccess instead
of a bool. This is necessary, because the kNone case may be both an error
state and a success state, depending on whether the fallback is being
used or not, hence a plain bool is not sufficient.
R=futhark@chromium.org
Bug: 641877
Change-Id: I951eef6335bf1cd4064d59959d73ec4fa39c9ee0
Reviewed-on: https://chromium-review.googlesource.com/c/1335576
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608365}
--
wpt-commits: 4bf9cbfa246859a47e46507154760526e48f8af0
wpt-pr: 14055
Automatic update from web-platform-testsRevert "Update infrastructure/metadata/ to match Chrome and Firefox results"
This reverts commit c2bf7c6ed9e3ab9d42000b712d3793f6b58c33cd.
--
Revert "Add action_sequence in testdriver"
This reverts commit 3287351b606c4588e397632e2ab04641dc91094d.
--
wpt-commits: 9e10da29c88d1268b65bac176df3c6ab2ee6a3d5, 02dccc6b5ad45352ae5c3bdf23fcbd9b0deea071
wpt-pr: 14076
Automatic update from web-platform-testsRemove timeout in async_test for IndexedDB tests
Remove all the timeout parameters in async_test for IndexedDB tests.
Affected tests: 44, Pass: 44, Failed: 0
Related: #11120
--
wpt-commits: c7c8c373d49baba4721e7800525b1699bf67ac7e
wpt-pr: 14068
Automatic update from web-platform-tests[testharness.js] Honor test config in workers (#14061)
Ensure that uncaught exceptions originating from workers do not
influence harness status when the `allow_uncaught_exception` setting has
been enabled.
--
wpt-commits: 0ddb31913184805fa3725e22e5b88046e961996b
wpt-pr: 14061
Automatic update from web-platform-testsReplace direct use of offerToReceiveAudio by generateAudioReceiveOnlyOffer.
This allows to use non legacy APIs by default if supported.
--
Merge pull request #14040 from youennf/remove-offerToReceiveAudio-use-outside-legacy
Replace direct use of offerToReceiveAudio by generateAudioReceiveOnlyOffer
--
wpt-commits: 27e0acb4312abf064d6491ff29db3852a958dff8, 42abd6cc7ebd7c0b0513639e1a8c1bd958638fed
wpt-pr: 14040
Automatic update from web-platform-testsFix wpt: service-worker/navigation-redirect.https.html
As preparation for adding FetchEvent#resultingClientId, this CL fixes
the test to make it pass once resultingClientId is impelmeneted.
Bug: 778497
Change-Id: I6309a13d4315e6a99149275a6d7889f14ce0d757
Reviewed-on: https://chromium-review.googlesource.com/c/1335055
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608167}
--
wpt-commits: 6856483bcc86322198f10e0c42385a7f9127eb66
wpt-pr: 14050
Automatic update from web-platform-tests[css-grid] Consider scrollbars in PopulateGridPositionsForDirection()
We never care about scrollbars
in LayoutGrid::PopulateGridPositionsForDirection(),
that's fine if the scrollbars are at the end
(e.g. on the right in horizontal writing mode and LTR direction)
but it causes problems when they're at the beginning
(e.g. on the left in horizontal writing mode and RTL direction).
The patch modifies the method so it takes into account scrollbar size
in order to compute the position of the columns/rows
depending on the direction and the writing mode.
BUG=904438
TEST=external/wpt/css/css-grid/grid-model/grid-container-scrollbar-001.html
TEST=external/wpt/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html
TEST=external/wpt/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html
Change-Id: I9c8307638647e449f6975cacf99f89e29d4fa655
Reviewed-on: https://chromium-review.googlesource.com/c/1334370
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#608154}
--
wpt-commits: ca8728e002fdfcdde1ee2efd39ebaccc823bf9b2
wpt-pr: 14052
Automatic update from web-platform-testsWorklet: Modernize service worker interception tests for worklets using async/await
This is just a cleanup CL, and there're no functional changes.
Bug: n/a
Change-Id: I60820045469eed4a0903b37af9e4f8927bcc884d
Reviewed-on: https://chromium-review.googlesource.com/c/1335047
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607892}
--
wpt-commits: d16eb1ce23500e7234f58df86a59d5c00d222118
wpt-pr: 14045
Automatic update from web-platform-tests[wptserve] Eliminate race condition (#14024)
This race condition was expressed during testing sessions where the
first test to use the Stash feature issued did so with multiple requests
made in parallel.
--
wpt-commits: cbb25e2c99696956ed2a36e7bcdbdee1dca71705
wpt-pr: 14024
WebRender takes longer than OMTP to release its hold on the current
frame. This is because it is in a separate process and holds onto the
surface in between rendering frames, rather than getting a reference for
each repaint. This patch makes us less aggressive about taking the most
recent surface placed in the recycling queue out to avoid blocking on
waiting for the surface to be released.
Differential Revision: https://phabricator.services.mozilla.com/D10903
Here we make use of the parts added in parts 1 and 2 to hold onto
recycled surfaces for as long as necessary to prevent the animated image
decoder from reusing them until WebRender is done with them.
Differential Revision: https://phabricator.services.mozilla.com/D10902