d0cb2170bb
Fix crash on loading files with no extension. Followup to bug 235502, patch by
...
biesi, r+sr=darin
2004-04-17 04:45:25 +00:00
9ae1052a56
landing patch for bug 24867 "UI for FTP upload" r=biesi,neil sr=bryner
2004-04-17 00:58:23 +00:00
f028ea412d
bug 239604. make uriloader more doxygen friendly, and remove unused "command"
...
parameter from nsIContentHandler::handleContent, and change the type of
aWindowContext to nsIInterfaceRequestor.
r=bzbarsky sr=darin
2004-04-16 21:06:07 +00:00
91a4cf7af2
this time, a correct fix...
2004-04-15 21:58:51 +00:00
04be82342f
fixing osx bustage
2004-04-15 21:32:11 +00:00
14177dedcb
Bug 235502 nsIMIMEService, nsIMIMEInfo should use nsACString/nsAString instead of string/wstring
...
r=bzbarsky sr=darin
2004-04-15 20:56:37 +00:00
6da5a56402
Bug 237947 Mozilla Freezes when handling filetypes with an entry in .mailcap that does not exist
...
o) also return from GetFileTokenForPath when the base class implementation failed
with NS_ERROR_FILE_NOT_FOUND.
o) Do not return NS_ERROR_FILE_NOT_FOUND from the
base class impl if the file path is both relative and does not exist in the
mozilla directory.
o) Make sure to break out of the loop in the unix GetFileTokenForPath even if
ApendRelativePath fails
r+sr=bzbarsky a=asa
2004-03-31 19:32:26 +00:00
4ca8093ad9
229636 search for helper apps in mozilla directory before $PATH
...
r=bzbarsky sr=darin
2004-03-08 20:15:09 +00:00
e88d56e95a
...and now, the correctly merged version, that even compiles
2004-03-06 19:43:40 +00:00
d0fdabc0c9
Bug 124307, respect umask for downloaded files.
...
r=bzbarsky sr=darin
2004-03-06 19:37:22 +00:00
7ea034fb6b
bug 78919, last part. r=bzbarsky sr=darin.
...
This adds a new method launchWithFile on nsIMIMEInfo which takes care of opening
the selected (preferred or default) application on the mime info with a
specified document. defaultDescription is now readonly, and defaultApplication
no longer available.
This also removes the clone method which was unused in the entire tree.
2004-02-23 22:49:28 +00:00
d74e41dd81
Bug 233145 stop implementing nsIURIContentListener in nsExternalAppHandler
...
r=bzbarsky sr=darin
2004-02-07 19:52:16 +00:00
6084008627
fixing bustage
2004-02-06 23:05:40 +00:00
9382bd3029
Bug 233169 [windows] It's impossible to set helper applications for executables
...
r=bzbarsky sr=darin
2004-02-06 22:32:29 +00:00
822a291d22
Bug 231886 Allow extensions to add extension->type mappings by adding an entry
...
in the "ext-to-type-mapping" category, where the name is the extension and the
value the mime type.
r=bzbarsky sr=darin
2004-02-06 18:43:27 +00:00
255a2deda5
Bug 232784, verify that opening the file works, and show an error message if it doesn't
...
r=pinkerton sr=bzbarsky
2004-02-05 10:53:11 +00:00
90431d8022
Fixing bug 232503. Start using Empty[C]String() to save a bit on code-size. r+sr=peterv@propagandism.org
2004-01-29 22:04:45 +00:00
be132f3456
Bug 152224
...
Leak in nsExternalAppHandler, due to reference cycle between the nsIDownload implementation,
the helper app service, and the helper app dialog.
now, the reference cycle with the helper app dialog is broken in Cancel/CreateProgressListener,
and the cycle with the nsIDownload will be broken in Cancel/CloseProgressWindow/OnStopRequest
r=bzbarsky sr=darin
2004-01-28 22:05:25 +00:00
741e690801
fix bustage
2004-01-17 13:41:23 +00:00
73f0845c24
bug 55690 Spool file should be moved once the user picks a filename
...
r=bzbarsky sr=darin
2004-01-17 13:18:12 +00:00
330498be5a
230970
...
nsExternalAppHandler needs no virtual functions
also, w/o bug: nsExternalHelperAppService doesn't require threadsafe addref/release
r=bzbarsky sr=darin
2004-01-16 18:22:55 +00:00
6ccc20cdbe
Work around misconfiguration in default Apache installs that makes it claim all
...
sorts of stuff as text/plain. Bug 220807, r=biesi, sr=darin
2004-01-08 03:56:02 +00:00
94dbdd84e4
bug 229785 also allow "Content-Disposition: name=foo" headers, in addition to filename=foo
...
r=bzbarsky sr=darin
2004-01-07 20:23:46 +00:00
287e80bb2e
bug 229684. application/octet-stream should not have "Binary Executable" as description
...
also fixes: If the OS has info for a type, but prefs contain neither info via type nor via
ext, we would get the mimeinfo from extras.
r+sr=bzbarsky
2003-12-30 10:45:12 +00:00
2148700a5c
Bug 227029 nsExternalAppHandler dynamically allocates buffer for no reason
...
r+sr=bzbarsky
2003-12-19 15:18:59 +00:00
d6ad711ccb
Bug #227711 wrong mime type shown when helper app entry present
...
fix this by always setting the real mime type on a mime info got from prefs.
r=bzbarsky sr=darin a=asa
2003-12-12 09:42:54 +00:00
7559c5d60e
226919 SendStatusChange should check for NS_ERROR_FILE_TARGET_DOES_NOT_EXIST
...
This gives a useful error message if a helper app could not be found (for another error code)
r=bzbarsky sr=darin a=asa
2003-12-03 22:21:39 +00:00
18d8f4d786
fixes bug 226071 "xremote: openURL doesn't work well when multiple apps with different capabilities are present" r=bz,blizzard sr=bryner a=asa
2003-11-21 00:09:50 +00:00
66f6e13a40
225972 GetMIMEInfoForExtensionFromDS returns success even if nothing was found
...
also fixes: GetMIMEInfoForExtensionFromExtras does not set a mime type on the mime info
r+sr=bzbarsky; this addresses the problem that the information in extras is never used
2003-11-17 21:31:11 +00:00
e92cc5ddfd
78919 part 2. always return a nsIMIMEInfo from the OS HelperAppServices, and don't
...
create MIMEInfos outside of them directly.
r=bzbarsky sr=darin
2003-11-15 15:01:39 +00:00
86a6cb09ce
bug 223990. Should have a getPrimaryExtensionForType function
...
r=bzbarsky sr=darin
also changes nsIMIMEService functions to start with a lowercase letter (only affects JS Callers)
2003-11-13 23:00:55 +00:00
e65411d7fc
Extension comparisons should be case-insensitive. Bug 223055, r=biesi, sr=darin
2003-10-30 02:20:23 +00:00
7adc775b7a
Fix bug 164816. Patch by biesi, r=bzbarsky, sr=darin
2003-10-22 06:46:52 +00:00
e5077348df
bug 220832. Make sure that we don't use the extension from the URL when the server sent a Content-Disposition header with a filename.
...
r=bzbarsky sr=darin
2003-10-10 13:43:15 +00:00
cf0e81ce47
Gunzip things with content-encoding:gzip whose file extension is .zip when
...
saving or running helpers. The idea here is to decompress unless the encoding
and extension match up. If they do, then don't decompress. Bug 152275,
r=biesi, sr=darin
2003-10-09 02:10:25 +00:00
1a9547ca4e
Add PNG to hardcoded extensions / mime type list (bug 221243). r=bzbarsky, sr=tor.
2003-10-06 18:48:17 +00:00
78719c7388
220463 use more error codes in nsExternalAppHandler::SendStatusChange
...
r=bzbarsky sr=darin
We now show a useful dialog for NS_ERROR_OUT_OF_MEMORY, and we treat
NS_ERROR_FILE_UNRECOGNIZED_PATH like FILE_NOT_FOUND.
2003-10-03 20:56:52 +00:00
915b893dac
Bug 220363 use doxygen-style comments in nsExternalHelperAppService.h
...
this is mostly converting //-style comments to /**-style ones and using @param
r=bzbarsky sr=darin
2003-09-26 19:49:23 +00:00
b5206035a9
bug 218817. replace GetDownloadInfo with attributes on nsIExternalHelperAppService -
...
this means 2 new attributes:
readonly attribute nsIFile targetFile;
readonly attribute PRTime timeDownloadStarted;
(no caller of GetDownloadInfo needed all three pieces of information that it provided)
r=bzbarsky sr=darin
2003-09-25 13:07:24 +00:00
8f369f59f4
Bug 220198
...
helperappservice qi's to httpchannel when it wants encodedchannel
r=bzbarsky sr=darin
2003-09-25 12:51:45 +00:00
a67ce6b555
143570 r=bzbarsky sr=darin
...
Allow assigning helper apps to mailnews attachments by extension.
do this by only getting the query off the uri for HTTP/HTTPS urls - mailnews
uris always have a query string, and if there is a query string the file
extension is ignored because a CGI script is assumed, which has no useful
extension.
2003-09-24 20:21:09 +00:00
98f3008774
219681 r=bzbarsky sr=darin
...
log save/launch errors to nspr log
This converts a printf inside #ifdef DEBUG_law to use nspr logging (module HelperAppService)
2003-09-23 19:27:07 +00:00
2feccd7112
219608 r=bzbarsky sr=darin compile warning in helperappservice (size/unsigned mismatch)
2003-09-23 19:24:26 +00:00
1f6b877479
Bug 218820
...
remove useless nsIExternalHelperAppService::canHandleContent
mozilla never calls this function; and it always returns PR_FALSE
r=bz sr=darin
2003-09-17 12:31:39 +00:00
cbddc9a5fb
per clarification via email from bz (reviewer of previous checkin to this file, for Bug 216417), using .xht, not .xhtm in the defaultMimeEntries array (matches the XHTML entry in the extraMimeEntries array)
2003-09-14 15:54:57 +00:00
9effbc9a16
Bug 216417
...
about: page has major errors
r+sr=bz
fix this by mapping all .xhtm and .xhtml files to application/xhtml+xml, not overridable by user or os
2003-09-14 11:41:22 +00:00
46b4508e80
Bug 120045
...
Multi-character character constants in nsExternalHelperAppService.cpp
r=bz sr=darin
2003-09-11 20:44:25 +00:00
f9a15025a5
fix off-by-one error
2003-09-11 16:14:58 +00:00
7204f246e1
Bug 65827
...
File extension (.php) determined from Content-Type header (or url extension) overrides filename in Content-Disposition header.
r=bz sr=darin
2003-09-11 13:27:06 +00:00
28f386412d
The Mother Of All Download Landings, Phase I
...
http://bugzilla.mozilla.org/show_bug.cgi?id=214259
Firebird Download System Upgrades.
exthandler/nsExternalHelperAppService.cpp
- update EHAS to use updated version of PromptForSaveToFile
- make the EHAS not set the MIME Info object's alwaysAskBeforeHandling flag
to false to make the UCT dialog's show behaviour consistent
bug 214985, r= sr=hyatt
2003-08-04 22:31:14 +00:00
29cbc4d6a3
Fix build bustage
2003-07-30 18:56:12 +00:00
197b0af015
Reverse some backwards assumptions to make things a little safer for users.
...
Bug 213921, r=biesi, sr=darin
2003-07-30 17:47:26 +00:00
2ac5385322
fixing windows bustage
2003-07-26 22:09:37 +00:00
0a7a152685
213882 r=bzbarsky sr=darin consider making aFileExt the primary extension if it is an extension
2003-07-26 21:01:08 +00:00
bb37693039
147679 GetFromMIMEType on Windows only gets one extension and needs rethinking r=bzbarsky sr=darin
...
this merges nsIMIMEService::GetFromType and GetFromExtension
2003-07-25 16:48:00 +00:00
a1b49091f7
162249 r=bzbarsky sr=darin Running external program - lack of decent error messages
...
This adds a useful error message in case the specified helper application does not exist
2003-07-22 17:25:02 +00:00
83c571e877
Bug 25886: Get rid of a bunch of unused NS_DEFINE_IID, NS_DEFINE_CID. r=caillon, sr=dbaron
2003-07-20 07:47:59 +00:00
c8d988bce3
Fix firebird and thunderbird bustage by unforking contents of nsIGlobalHistory (which was frozen) and by tweaking the root Makefile.in. b=212509 r=mscott
2003-07-19 21:19:12 +00:00
ebe19365ed
212468 r=bzbarsky sr=darin rethink the hashtable usage in helperappservice
2003-07-14 22:30:52 +00:00
ebd1eb4d26
212110 r=bzbarsky sr=darin misc cleanup of externalhelperappservice
2003-07-14 21:09:11 +00:00
7d10504897
78919 part 1. r=bzbarsky, sr=darin. This adds an |hasDefaultHandler| attribute
...
to nsIMIMEInfo that should be used to check if a default application is available
for this mimeinfo.
2003-07-08 13:52:46 +00:00
473175175e
no bug, r+sr=bzbarsky; remove MNG and JNG types from defaultMimeEntries array so
...
that users can have a helper app for MNG/JNG images
2003-07-07 19:27:48 +00:00
805bd84854
193698 r=bzbarsky sr=darin "attachment" content shows a checkbox for "don't ask"
...
This checkin makes it so that we grey out the "Always ask me" checkbox for files sent
with content-disposition:attachment, and show another text indicating that the server
asked to not display the file.
2003-07-03 13:55:17 +00:00
ff56070f4a
random array cleanup. Bug 211193, r=biesi, sr=alecf
2003-07-02 00:29:26 +00:00
c4641b8725
188058 r=bzbarsky sr=darin When saving a .zip file "as...," Moz appends a .x after the .zip extension.
2003-07-01 14:16:06 +00:00
4c96aae9a9
73757 r=bzbarsky sr=darin Local files not handled by moz should not be copied to temp directory
2003-06-30 22:33:36 +00:00
4d36cb7adf
Fix MOZ_PHOENIX bustage.
2003-06-30 20:29:59 +00:00
dd0fc2d465
124014 r=bzbarsky sr=darin URL handled by helper app never marked visited
2003-06-30 19:00:46 +00:00
bc9eb3ea37
bug 209513 : be generous to broken servers emiitng 'filename=...' without
...
specifying the dispositin type spec in Content-Disposition header.
(r/sr=bzbarsky)
2003-06-18 09:07:58 +00:00
f43f8eebe9
fix for bug 205895 - make nsIMIMEInfo.getFileExtensions use a string enumerator, to avoid excess allocation at startup
...
r=bz, sr=darin
2003-06-17 17:00:40 +00:00
c1c5164316
wrapping up bug 162765 : r=cbiesinger, sr=bz : Make the disposition method
...
comparison use EqualsIgnoreCase without the 2nd argument (length) when
parsing Content-Disposition header in http
2003-06-13 21:46:07 +00:00
eb93104d96
bug 167265 : add to necko Content-Disposition header handling per RFC 2231 (with
...
fallbacks to RFC 2047 and raw 8bit chars in |aOriginCharset| ) necessary for
i18nized filename support (when downloading files via http) :
r=cbiesinger, sr=alecf
2003-06-12 21:57:49 +00:00
f874fa8926
140301 patch by egnor@ofb.net r=biesi sr=bz tgz files get silently unzipped
2003-06-02 14:03:55 +00:00
a58b5ef4fa
Fix for 202355. Turn on apple single/double code for MacOSX. r=ccarlen, sr=sfraser.
2003-04-25 21:18:10 +00:00
ae709df785
Fixing comment
2003-04-22 02:44:21 +00:00
7c6ac50920
Fix nsExternalAppHandler::SaveToDisk when aNewFileLocation is non-null, for Camino. Bug 197745. r=sdagley, sr=bz
2003-03-17 23:39:13 +00:00
0d2808c511
Create a new xpcom obsolete library (and component library).
...
Moved nsFileSpec and related classes into this obsolete library.
Moved nsRegistry and related libreg functionality into the obsolete library.
Updated many callers using the obsolete nsFile spec to use nsIFile and Necko to do file IO.
Combined the following DLLs (source -> dest)
uriloader -> docshell
shistory -> docshell
jsurl -> jsdom
gkview -> gklayout
Moved nsAdapterEnumerator out of xpcom/ds and into mailnews, since they're the only consumer
Modifed the xpt_link tool so that you can specify a �only include� cid list that can mask CID�s that you are not interested in.
Added build options:
Prevent the building of xpinstall (--disable-xpinstall)
Prevent the building js component loader (--disable-jsloader)
A build option to only build a single profile (--enable-single-profile)
A build flag to only built the required xpfe components (--disable-xpfe-components).
Removal or hiding of unused functions and classes including nsEscape*, nsDequeIterator, nsRecyclingAllocatorImpl, nsDiscriminatedUnion, nsOpaqueKey, nsCRT::strlen, NS_NewCommandLineService
Bug 194240, r/sr = darin, alec.
2003-03-15 01:04:32 +00:00
d1b6c0d64d
Fixing the DOM navigator.mimeType array to be able to test for installed helper applications, bug 58811, patch by bzbarsky@mit.edu r=peter, sr=jst
2003-02-26 23:54:55 +00:00
9405eda256
190020 r=timeless sr=alecf GetResource should take AUTF8String
2003-02-25 19:02:00 +00:00
68df4a7747
Bug 188724 - clicking cancel in filepicker, then clicking file again leads to filepicker
...
r=cbiesinger@web.de , sr=bzbarsky@mit.edu , a=asa@mozilla.org
2003-02-03 20:36:12 +00:00
8423ead416
Don't try to uncompress .Z files when saving them. Bug 162271, patch by harm
...
ten Napel <harm.ten.napel@oracle.com> and Smaug <smaug@jippii.fi>, r=dwitte,
sr=bzbarsky, a=dbaron
2003-01-25 21:00:28 +00:00
9f04591a8c
Bug 180384 nsExternalHelperAppService should observe profile changes
...
r=ccarlen sr=dmose
2003-01-22 06:57:15 +00:00
d27a72563e
Back out part of patch from bug 172693 until we can do it better. Bug 189602,
...
r=timeless, sr=heikki
2003-01-21 18:32:20 +00:00
685a7af468
modifications for bug 176919 "async streams" r=dougt,gordon sr=sspitzer a=valeski,asa
2003-01-18 02:15:14 +00:00
8368c5f241
Ignore file extensions for urls to obvious CGI scripts. Bug 172693, patch by
...
law@netscape.com (Bill Law), r=bzbarsky, sr=heikki
2003-01-14 22:12:10 +00:00
4d2505d4e4
Fix bug 86640 -- change helper app dialog to properly remember the selected
...
course of action, move the "neverAsk" information from prefs back to
mimeTypes.rdf, remove the "Reset" button from helper app prefs, set up a way to
select "use default OS helper" for a given type. Patch by Bill Law
<law@netscape.com> and Philip K. Warren <pkw@us.ibm.com>, r=biesi, sr=bzbarsky,
what passes for moa in helper apps=bzbarsky.
2003-01-12 01:14:35 +00:00
b9083989bb
Bug 178643: Remove uses of NS_INIT_ISUPPORTS, since it is no longer needed. r=timeless sr=jag
2003-01-08 23:19:20 +00:00
e3273e17d0
Any disposition that's not "inline" should be treated as "attachment".
...
Bug 172003, r=bbaetz, sr=rpotts
2002-11-13 21:17:40 +00:00
1a0f253e45
fix off-by-one error in parsing out extension
...
change by bz
2002-11-06 23:59:36 +00:00
74a9b1ed3e
Prioritize data-sniffing over extension-sniffing for ftp and http. Bug
...
177026, r=rpotts, sr=darin
2002-11-06 22:29:17 +00:00
308f24e14a
Landing changes from Chimera bug #151047 on trunk for mach-o build. Addresses issues of DL'd files going into /tmp rather
...
than user specified DL folder and deletion of files passed to helper apps which is the wrong thing to do on Mac. Original
patch sr=sfraser, r=gordon on this checkin
CVS: ----------------------------------------------------------------------
2002-10-09 01:16:38 +00:00
7f1956b180
fixes bug 157135 "nsIFileURL need to be frozen" r=dougt sr=bzbarsky
2002-10-06 02:20:35 +00:00
1566417aaf
move contentEncodings and applyConversion to a new interface. r=neeti@netscape.com, sr=darin@netscape.com, b=157133
2002-09-27 19:23:21 +00:00
98dea7435c
Honor content-disposition: attachment even when it's set on content we
...
can handle internally. Bug 98360, r=law,rpotts, sr=darin. Correct
whitespace this time.
2002-09-03 22:00:22 +00:00
a8e1beb0d2
doh. Wrong patch version (-w). backing it out and fixing the whitespace...
2002-09-03 21:47:44 +00:00
371890dd60
Honor content-disposition: attachment even when it's set on content we
...
can handle internally. Bug 98360, r=law,rpotts, sr=darin
2002-09-03 21:46:25 +00:00
c06d90d976
For filename download, ignore http header's filename if it contains 8bit characters,
...
bug 161174, r=ftang, sr=bzbarsky.
2002-08-15 01:15:58 +00:00
e0457e3491
Added unescape function which takes a charset to uconv,
...
changed uriloader to use the uconv unescape to handle unescape non Ascii URI correctly.
bug 155569, r=ftang, sr=bzbarsky.
2002-08-12 19:23:22 +00:00
edb971f5e2
wallpaper for a bit of bug 120327; this should keep us from appending
...
".exe" all the time to things on Windows. patch by me and
jruderman@hmc.edu , r=law, sr=jag, a=asa
2002-07-24 00:42:12 +00:00
12af864742
Fix bug 154346 the right way. r=law, sr=jag
2002-07-01 23:14:07 +00:00
bzbarsky%mit.edu
darin%meer.net
cbiesinger%web.de
jst%mozilla.jstenback.com
bryner%brianryner.com
ben%bengoodger.com
jaggernaut%netscape.com
dbaron%dbaron.org
jshin%mailaps.org
alecf%flett.org
cavin%netscape.com
mkaply%us.ibm.com
sfraser%netscape.com
dougt%netscape.com
peterlubczynski%netscape.com
pkw%us.ibm.com
timeless%mozdev.org
darin%netscape.com
sdagley%netscape.com
nhotta%netscape.com