d06b6030f6
Bug 1202902 - Scripted fix the world.
2015-10-06 14:00:31 -07:00
7373ebaca0
Bug 1209919 - Improving naming and comments in StructuredCloneHelper, r=smaug
...
--HG--
rename : dom/base/StructuredCloneHelper.cpp => dom/base/StructuredCloneHolder.cpp
rename : dom/base/StructuredCloneHelper.h => dom/base/StructuredCloneHolder.h
2015-09-30 13:22:08 +01:00
79699c0eed
Back out the null-check workaround for bug 1182197 on trunk, so we can see what the stacks look like after all via crash-stats data on nightly and dev channel.
2015-09-18 13:38:42 -04:00
138287abda
Bug 1182197 workaround. Add a null-check for mGlobal for now. r=nsm
2015-09-11 21:59:43 -04:00
379988acc8
Bug 1203289 - PromiseCallback subclasses should unmark gray JS they run. r=bz
2015-09-10 11:34:10 -07:00
c9f137eef4
Bug 1182197 investigation patch. Log the stack at promise fulfillment on a CCed promise into the crash reporter data. r=dmajor,nsm
2015-09-08 21:23:55 -04:00
893e3bb469
Bug 1198814 - Use StructuredCloneHelper in PromiseWorkerProxy, r=smaug
2015-09-05 12:22:13 +03:00
548809dc68
Bug 1197421 - Fix promise worker proxy cleanup and update callers. r=catalinb
...
Get rid of having users dispatch control runnables. It was error prone and
required too much reasoning. It was also possible to end up in a state where
callers would dispatch a WorkerRunnable, which would succeed, so they would not
dispatch a WorkerControlRunnable. Then the worker would stop Running,
canceling and releasing the runnable leading to releasing the proxy in an
unclean state. Instead, we AddRef() and add the feature and remove the feature
and Release() on Notify(). If callers successfully run a WorkerRunnable they
clean the proxy. If not, the proxy stays alive until the worker switches to
Canceling state.
--HG--
extra : commitid : BnnijSibVYe
extra : rebase_source : 15f6810dfbd0c88a983196de401c55e782b1d1d8
2015-09-02 10:07:26 -07:00
efd3b25c78
Bug 1198795 - ipc/StructuredCloneUtils should be merged with StructuredCloneHelper, r=smaug
...
--HG--
rename : dom/ipc/StructuredCloneUtils.cpp => dom/ipc/StructuredCloneIPCHelper.cpp
rename : dom/ipc/StructuredCloneUtils.h => dom/ipc/StructuredCloneIPCHelper.h
2015-09-02 17:20:30 +01:00
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
88eb19683a
Bug 1162333 - Fix windows bustage. a=bustage CLOSED TREE
...
--HG--
extra : commitid : JQslbB96EhG
extra : rebase_source : 9893be5fadeab5c26ead032cbca24acf3f6049c7
2015-08-18 10:00:35 -07:00
f67a04e158
Bug 1162333 - Add stronger assertions to PromiseWorkerProxy in debug builds. r=catalinb
...
--HG--
extra : commitid : 2jVPtywuF92
extra : rebase_source : 85d8854a7f3eec8c1fd31ed0e57f33d3b83a2d04
2015-06-11 00:35:18 +02:00
b44082538c
Bug 1086627 - Rename Promise constructs to more closely match the specification. r=nsm,jst
...
--HG--
extra : commitid : 86J3tVySqhI
extra : rebase_source : cccb777a893cc44c2edece078e5861aa25f3f52b
extra : amend_source : 02c64f4e5ba42d2aa77776826af80927bd231f00
2015-08-06 17:18:30 +02:00
09f58572fa
Bug 1086627 - Rename ThenableResolverTask to PromiseResolveThenableJob to more closely match Promise spec. r=nsm
...
--HG--
extra : commitid : 70Le0IGETaD
extra : rebase_source : ef42276c4125f91d69c271cb19319c9d995f1826
2015-08-03 18:48:34 +02:00
76e3009ab8
Bug 1179909: Refactor stable state handling. r=smaug
...
This is motivated by three separate but related problems:
1. Our concept of recursion depth is broken for things that run from AfterProcessNextEvent observers (e.g. Promises). We decrement the recursionDepth counter before firing observers, so a Promise callback running at the lowest event loop depth has a recursion depth of 0 (whereas a regular nsIRunnable would be 1). This is a problem because it's impossible to distinguish a Promise running after a sync XHR's onreadystatechange handler from a top-level event (since the former runs with depth 2 - 1 = 1, and the latter runs with just 1).
2. The nsIThreadObserver mechanism that is used by a lot of code to run "after" the current event is a poor fit for anything that runs script. First, the order the observers fire in is the order they were added, not anything fixed by spec. Additionally, running script can cause the event loop to spin, which is a big source of pain here (bholley has some nasty bug caused by this).
3. We run Promises from different points in the code for workers and main thread. The latter runs from XPConnect's nsIThreadObserver callbacks, while the former runs from a hardcoded call to run Promises in the worker event loop. What workers do is particularly problematic because it means we can't get the right recursion depth no matter what we do to nsThread.
The solve this, this patch does the following:
1. Consolidate some handling of microtasks and all handling of stable state from appshell and WorkerPrivate into CycleCollectedJSRuntime.
2. Make the recursionDepth counter only available to CycleCollectedJSRuntime (and its consumers) and remove it from the nsIThreadInternal and nsIThreadObserver APIs.
3. Adjust the recursionDepth counter so that microtasks run with the recursionDepth of the task they are associated with.
4. Introduce the concept of metastable state to replace appshell's RunBeforeNextEvent. Metastable state is reached after every microtask or task is completed. This provides the semantics that bent and I want for IndexedDB, where transactions autocommit at the end of a microtask and do not "spill" from one microtask into a subsequent microtask. This differs from appshell's RunBeforeNextEvent in two ways:
a) It fires between microtasks, which was the motivation for starting this.
b) It no longer ensures that we're at the same event loop depth in the native event queue. bent decided we don't care about this.
5. Reorder stable state to happen after microtasks such as Promises, per HTML. Right now we call the regular thread observers, including appshell, before the main thread observer (XPConnect), so stable state tasks happen before microtasks.
2015-08-11 06:10:46 -07:00
2311382621
Bug 1191305 - Alphabetize some includes; r=froydnj
2015-08-06 15:45:21 +03:00
80ea0a3e53
Bug 1190823 - Move OwningNonNull.h to xpcom/base/; r=froydnj
...
--HG--
rename : dom/bindings/OwningNonNull.h => xpcom/base/OwningNonNull.h
2015-08-05 15:28:27 +03:00
57621e1167
Bug 1135961. Implement subclassing of DOM objects. r=peterv
2015-07-31 13:30:55 -04:00
39455891a5
Bug 1178665 - Part 1: Make Promise::DispatchToMicroTask public. r=khuey
2015-07-14 21:44:00 +02:00
2f40ed3c09
Bug 975246 - Part3 - Using nsRefPtr->* operator. r=nfroyd
2015-07-28 23:08:00 +02:00
97b9240b34
Bug 1188696 - Hoist nsRefPtr.h into MFBT. r=froydnj
2015-07-29 10:44:59 -07:00
a37b7fa928
Bug 1148593 - Pass JSContext to CallbackObject constructor. r=bz
...
--HG--
extra : rebase_source : 5c4c1b8dc646fc76bda37a8c6e35a6494d0800b8
2015-07-24 07:00:00 -04:00
b171b787bd
Backed out changesets fa9fe193778f and 3eaf867930dd (bug 1148593) for test_async_setTimeout_stack.html and test_async_setTimeout_stack_across_globals.html failures.
2015-07-17 12:37:24 -04:00
2bbc02624b
Bug 1148593 - Pass JSContext to CallbackObject constructor. r=bz
2015-07-17 07:47:00 -04:00
c8a46b6965
Bug 1114554 - Patch 5 - getNotifications() on worker thread. r=wchen
...
--HG--
extra : rebase_source : 7d42bf40e9228d3729e0a269d66fa427db3eb38f
2015-06-25 18:50:25 -07:00
a8939590de
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
562c0a00bc
Bug 1181321 - Eliminate duplicate mRefCnt members in PromiseNativeHandler subclasses. r=baku
...
--HG--
extra : rebase_source : 64348ca27d2f70dc116856dd4f9271e1fb63a467
2015-07-09 08:56:00 +02:00
238677c2c0
Bug 1155059: Patch 3&7 - fix leaks in Promise, ConsoleService and JS Finalize r=froydnj
2015-07-09 23:21:46 -04:00
c87c478f4f
Bug 1155059: Patch 1&2 - Convert Dispatch() and friends to already_AddRefed<> r=froydnj
...
Modify Dispatch IDL and code to deal with MSVC issues with overloaded templates r=froydnj
2015-07-09 23:21:46 -04:00
9cea8f483b
Bug 1167597 - Mark PromiseReportRejectFeature::mPromise as MOZ_NON_OWNING_REF. r=ehsan
2015-05-22 07:17:00 +02:00
258ad59e3f
Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj
2015-07-03 18:29:00 -07:00
84d140a54b
Backed out 11 changesets (bug 916893, bug 1114554) for various mochitest and Gij failures.
...
Backed out changeset 247ca4bf258e (bug 1114554)
Backed out changeset 5578d5c280a6 (bug 1114554)
Backed out changeset 404830c1ecf7 (bug 1114554)
Backed out changeset 15bdf9c78e6e (bug 1114554)
Backed out changeset f92abe5ec784 (bug 1114554)
Backed out changeset 75324b6862a8 (bug 1114554)
Backed out changeset ce8a768782f2 (bug 1114554)
Backed out changeset 0d860fd12534 (bug 1114554)
Backed out changeset 7dc2448065a9 (bug 916893)
Backed out changeset c3b07f0d1a60 (bug 916893)
Backed out changeset 61c3f24cc908 (bug 916893)
CLOSED TREE
2015-06-25 19:52:40 -04:00
5f5c327690
Backed out changeset 8b4e4083639e (bug 1171931) for B2G debug emulator bustage.
2015-06-25 19:48:42 -04:00
811edc788a
Bug 1114554 - Patch 5 - getNotifications() on worker thread. r=wchen
...
--HG--
extra : rebase_source : b3f68e725be5cbfedc2995c9b20450e4bcaa1aae
2015-05-04 09:04:25 -04:00
702a59d135
Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj
...
--HG--
extra : rebase_source : 2ecbe6c1dd8a7ad8dc529b53349ad431cf1116c9
2015-06-24 14:11:00 -04:00
d0bfa9bf80
Bug 1160445 - Add detailed logging for EME promise failures - r=cpearce,bholley
2015-06-03 13:42:50 +12:00
8da3b34de1
Bug 1157714 - Move browser_monitorUncaught to a xpcshell test. r=self
...
--HG--
rename : dom/promise/tests/browser_monitorUncaught.js => dom/promise/tests/unit/test_monitor_uncaught.js
extra : transplant_source : jb%BC%D9b%F70%2B%60h%AE%AC%13%87%84%BEG%FA%BE%23
2015-05-19 12:21:28 +02:00
161a4c26ba
Bug 1164602 - Replace js::NullPtr and JS::NullPtr with nullptr_t; r=sfink
2015-05-13 14:07:34 -07:00
1a03395848
Bug 1154275 - Remove ise() in favor of is(); r=Ms2ger
2015-05-13 14:31:58 -04:00
59ea7eac31
Bug 1162013. Process the Promise queue between adjacent setTimeout callback invocations when we're going through the callback list without returning to the event loop. r=smaug
2015-05-07 14:49:31 -04:00
f15282bf26
Backed out changeset 57f0b16030e9 (bug 1162013) for m-oth and m-dt3 bustage CLOSED TREE
2015-05-07 13:37:27 -07:00
0c6597b3e0
Bug 1162013. Process the Promise queue between adjacent setTimeout callback invocations when we're going through the callback list without returning to the event loop. r=smaug
2015-05-07 14:49:31 -04:00
9e8f4b219e
Bug 1152551, part 2 - Fix mode lines in dom/. r=jst
2015-05-03 15:32:37 -04:00
b8ba520783
Bug 1087330. Make the data structure we use for our promise microtask queue have O(1) first element removal, not O(N). r=khuey
2015-05-01 22:33:01 -04:00
f062a9c6ca
Bug 1120501 P1 Make it easier to use Promise::All() from C++ code. r=nsm
2015-04-29 08:59:43 -07:00
828e83e703
Bug 1058695 - Add member to nsIGlobalObject to detect it is going away. Make promises use it. r=bholley
...
--HG--
extra : rebase_source : 001f43d9e08768111f8ece44f79ae3ab689e2fb6
extra : amend_source : 8b89c86ded224c90aa428cdfb24d25959c87b32b
2015-04-27 12:00:41 -07:00
cb4391caa6
Backed out changeset c839f283bf28 (bug 1058695) for bustage.
...
CLOSED TREE
2015-04-27 14:04:24 -04:00
6e7fc932d3
Bug 1058695 - Add member to nsIGlobalObject to detect it is going away. Make promises use it. r=bholley
...
--HG--
extra : rebase_source : 3b3909b843efa2150edfcd79a6399535a12bd5aa
2015-04-22 16:34:21 -07:00
0c176ddcff
Bug 1062479 - Use static strings for WeakReference type names. r=ehsan
2015-04-24 09:43:01 -07:00
d1232d5041
Backed out changeset cb59db723d15 (Bug 1058695) for bustage on CLOSED TREE
...
--HG--
extra : amend_source : 273b62b6c171f65718e8c59e833ba30f6ea96a05
2015-04-23 09:46:52 -07:00
8bec017e97
Bug 1058695 - Add member to nsIGlobalObject to detect it is going away. Make promises use it. r=bholley
2015-04-22 16:34:21 -07:00
75b0dfb4c7
Backed out changeset 527cd70f241f (Bug 1058695) for bustage
2015-04-23 09:07:16 -07:00
e653803d27
Bug 1058695 - Add member to nsIGlobalObject to detect it is going away. Make promises use it. r=bholley
...
--HG--
extra : transplant_source : %86%8A%E1%E1%98c%E9w%81%3DS%84%B1%3A%02bU%8D%7B%C7
2015-04-22 16:34:21 -07:00
f785c39c1e
Bug 1152902 part 2. Add a fast path for the case when a Promise is resolved with another Promise. r=nsm
2015-04-17 22:01:02 -04:00
11411ee0a4
Back out 2 changesets (bug 1152902) for Gu bustage
...
CLOSED TREE
Backed out changeset 462f2f668259 (bug 1152902)
Backed out changeset 1c5ed66652c3 (bug 1152902)
2015-04-18 15:30:17 -07:00
e5d918e74e
Bug 1152902 part 2. Add a fast path for the case when a Promise is resolved with another Promise. r=nsm
2015-04-17 22:01:02 -04:00
ebd83c9a61
Bug 1152577: Add 'aReason' argument to AutoEntryScript constructor, and provide plausible names for its instantiations. r=bholley
...
--HG--
extra : rebase_source : 8ab7a3628a5b4d94b957f24e23e4c5c7871db97c
2015-04-08 21:23:48 -04:00
b08ce98d2a
Bug 1083361 - Exposing a PromiseDebugging API to monitor uncaught DOM Promise. r=bz
...
--HG--
extra : rebase_source : cba2fc37d263d431c3008739a89a4fe47d10b7da
2015-04-10 17:27:57 +02:00
8d978700de
Bug 1130686 - Refactor PromiseHolder in the service worker clients code. r=nsm
2015-04-07 16:25:08 +03:00
43962cb694
Bug 1038238 - Part 1: Make Error instances use SavedFrame objects for their
...
stacks; r=jorendorff
2015-03-27 13:08:46 -07:00
04d1520cc7
No bug: fix typo. DONTBUILD
2015-03-21 10:43:15 -07:00
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
dc24477d79
Bug 1117172 part 3. Change the wrappercached WrapObject methods to allow passing in aGivenProto. r=peterv
...
The only manual changes here are to BindingUtils.h, BindingUtils.cpp,
Codegen.py, Element.cpp, IDBFileRequest.cpp, IDBObjectStore.cpp,
dom/workers/Navigator.cpp, WorkerPrivate.cpp, DeviceStorageRequestChild.cpp,
Notification.cpp, nsGlobalWindow.cpp, MessagePort.cpp, nsJSEnvironment.cpp,
Sandbox.cpp, XPCConvert.cpp, ExportHelpers.cpp, and DataStoreService.cpp. The
rest of this diff was generated by running the following commands:
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObject\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(Binding(?:_workers)?::Wrap\((?:aCx|cx|aContext|aCtx|js), [^,)]+)\)/\1, aGivenProto)/g'
2015-03-19 10:13:33 -04:00
082fd9cd7f
Bug 1142841: Convert all nsRefPtr<nsIRunnable> to nsCOMPtr<nsIRunnable>. r=ehsan
...
This patch was generated by a script. Here's the source of the script for
future reference:
find . \( -iname "*.cpp" -o -iname "*.h" \) | \
xargs -n 1 sed -i "s/nsRefPtr<nsIRunnable>/nsCOMPtr<nsIRunnable>/g"
2015-03-17 09:29:17 -07:00
92143814c0
Bug 1110487 P1 Fix some non-unified bustage before adding new code. r=ehsan
2015-03-16 07:10:36 -07:00
d1c61bc9b6
Bug 1116187 - Disable failing mochitest-chrome tests for B2G, r=gbrown
2015-02-06 16:30:37 -08:00
8e389f1730
Merge inbound to m-c a=merge CLOSED TREE
2015-03-09 18:27:28 -07:00
cc3b42e52a
Bug 1140573 part 3. Drop the parent argument from js::NewFunctionWithReserved. r=waldo
2015-03-09 12:50:07 -04:00
e5306bdeb5
Bug 1140472 - Set an async stack when invoking promise handlers. r=bz
2015-03-09 12:36:29 +00:00
e0532c037e
Bug 1122238 part 3. Drop all the DOMException-cloning and sanitization gunk we added in bug 1107592 and bug 1107953 and bug 1117242 . r=bholley
2015-03-06 01:08:06 -05:00
ed036ca142
Bug 1136357 - Make Promise skippable, r=mccr8
...
--HG--
extra : rebase_source : e9679e163117aeabb69e3d919a1eaaba5b02b28c
2015-02-25 00:24:45 +02:00
6a93d5c443
Bug 1107953 part 5. Add tests for promise rejections with content-side DOMExceptions, and fix the promise code so those tests actually pass. r=bholley
2015-01-15 17:39:02 -05:00
24431c3a52
Bug 1107953 part 3. Make Promise pass in their object compartment when calling their various callbacks. r=bholley
...
--HG--
rename : dom/bindings/test/test_exception_options_from_jsimplemented.html => dom/bindings/test/test_promise_rejections_from_jsimplemented.html
2015-01-15 17:39:02 -05:00
b83d21c58c
Bug 914067 - Remove JSVAL_VOID from dom/; r=jst
2015-01-14 08:59:06 +01:00
9e129add69
Bug 1120235. Various promise resolve/reject functions should actually return undefined instead of ending up accidentally returning their callee. r=nsm
2015-01-12 22:35:33 -05:00
10ca187446
Bug 1112471 - Part 2: DOM Changes for getting icc service state API. r=smaug
2014-12-26 10:11:20 +08:00
3ca715b071
Bug 1118612 - Mark virtual overridden functions as MOZ_OVERRIDE in dom/promise; r=baku
2015-01-07 11:51:28 -05:00
8e36934a09
Bug 1057994 - DataStore should not dispatch runnables in a worker when it is shutting down, r=bent
...
--HG--
rename : dom/datastore/tests/file_basic_worker.html => dom/datastore/tests/file_worker_close.html
rename : dom/datastore/tests/test_basic_worker.html => dom/datastore/tests/test_worker_close.html
2014-12-17 14:49:36 +00:00
8bacfeb968
Bug 1054671 - Constify static callback arrays r=ehsan
2014-12-16 16:30:39 -08:00
b91168c141
Backed out changeset 6a3a0e3bfaf6 (bug 1054671) for B2G emulator build bustage on CLOSED TREE
2014-12-16 11:24:15 +05:30
d791adb2b0
Bug 1054671 - Constify static callback arrays r=ehsan
2014-12-15 20:53:58 -08:00
09a262787c
Bug 649012 - Fail mochitest-plains which use flaky timeouts (setTimeout(x) for x > 0); r=ted
...
We are white-listing the existing set of tests that use setTimeout
like this. Hopefully these tests will be investigated and fixed
in the future, so that we can narrow down the white-list.
This check is only turned on for mochitest-plain for now.
2014-12-11 13:34:40 -05:00
8ec9d58716
Bug 1087851 part 1. Rename WrapNewBindingObject to GetOrCreateDOMReflector to make it clearer what it does. r=peterv for the idea; patch itself is just search-and-replace
2014-11-26 14:25:20 -05:00
b742ef4f34
Backed out changeset 73c4111cab17 (bug 1083361) for bustage
2014-11-20 09:51:03 +01:00
b71d04be6e
Bug 1083361 - Exposing a PromiseDebugging API to monitor uncaught DOM Promise. r=bz
2014-11-19 14:31:06 +01:00
cde18cdd55
Bug 1084065 - Part 2: Make DOM Promise call the JS::dbg::onPromiseSettled hook; r=bz
2014-11-17 10:44:00 +01:00
8100009108
Bug 1083210 - Part 2: Make DOM Promise call the JS::dbg::onNewPromise hook. r=bz
2014-11-17 10:42:00 +01:00
6ff08403e2
Bug 1095443 - Ensure processNextEvent never blocks after processing a Promise microtask. r=bz
2014-11-11 13:47:28 +00:00
600ab9bfb9
Bug 1091091: Support ErrorResult in Promise::MaybeReject(). r=bz
2014-10-30 11:12:09 -04:00
9a214e3d2f
Bug 1033885 - add mediaDevices.getUserMedia with promises. r=bz, r=jesup
2014-09-20 02:20:41 -04:00
e1e4b620e8
Bug 1013625 - Process Promise resolution runnables outside of main event queue. r=bz,khuey
2014-10-28 12:08:19 +00:00
63d57bf61d
Bug 1083783 - Move Promise.cpp to a model where settlement immediately queues the invocation of "then" callbacks. r=bz
2014-10-28 12:08:19 +00:00
36db9eff13
Bug 1039846 - Patch 4: FetchDriver with about:, blob: and data: fetching. r=baku
...
--HG--
extra : transplant_source : o%29%0E%5D%90%11%FA%1ExO%26%7E%9D_%F2%E7%0B%FE%21%B2
2014-10-06 11:01:20 -07:00
ec85f9090b
Bug 1084030. Store the promise creation and settlement timestamps and expose that information via PromiseDebugging. r=nsm
2014-10-20 13:02:21 -04:00
fdaecfb699
Bug 1083950. Add a way to get the promises that depend on a given promise via PromiseDebugging. r=nsm
2014-10-19 22:27:36 -04:00
ea1a6ff5e4
Bug 1083851 part 4. Expose promise stacks on PromiseDebugging.
2014-10-19 22:27:12 -04:00
37b389182b
Bug 1083851 part 3. Capture stacks at promise fulfillment time. r=nsm
2014-10-19 22:27:12 -04:00
3f89b93b91
Bug 1083851 part 2. Capture stacks at promise rejection time. r=nsm
2014-10-19 22:27:12 -04:00
f7f99c8c9b
Bug 1083851 part 1. Capture allocation stacks at promise creation time. r=nsm
2014-10-19 22:27:12 -04:00
bf9324688d
Bug 1069694 - Remove OldDebugAPI from the browser. r=shu
2014-10-12 19:37:41 +02:00
dcda2ba9bb
Bug 1078744 - Replace SetIsDOMBinding with SetIsNonDOMBinding, remove nsWrapperCache::SetIsDOMBinding. r=bz.
...
--HG--
extra : rebase_source : 89c476cd9436530b2df5acc903909e34188417a0
2014-10-07 11:44:49 +02:00
94bd419133
Bug 1070842 - Remove ambiguous globals from xpc::ErrorReporter and make meanings explicit. r=bz
2014-09-29 15:34:20 +02:00
8864b64406
Bug 1062323 - Chained promises should resolve asynchronously. r=bz
...
--HG--
extra : transplant_source : %0C%E0%D2%0FEI/%D8s%E2%D07%8B%DE%25g%96%85%22r
2014-09-23 22:00:58 -07:00
db168e5cde
Bug 1065811 - Expose isCallable()/isConstructor() in JS_PUBLIC_API. r=billm
2014-09-25 13:13:28 +02:00
16e1505ea9
Backed out changeset ebd8df8e8631 (bug 1062323) for Gaia unit test failures.
2014-09-24 17:08:28 -04:00
95c8c96ad5
Bug 1062323 - Chained promises should resolve asynchronously. r=bz
2014-09-22 16:37:40 -07:00
e3eca2660e
Bug 1070696 - Rename xpc::GetNativeForGlobal to xpc::NativeGlobal and make it accept non-global JSObjects. r=smaug
...
The method is infallible, and making the callers invoke
js::GetGlobalForObjectCrossCompartment manually is dumb.
2014-09-21 21:31:53 +02:00
8908aea348
Bug 1068020 - Fix more bad implicit constructors in DOM; r=baku
2014-09-17 17:53:42 -04:00
fcfee0071f
Bug 1035060 - Implement AbortablePromise. r=bz
2014-09-12 10:18:49 +08:00
e85bd78d5d
Bug 1062077 - Introduce xpc::ErrorReport. r=bz
...
I've got it! Let's just wrap the JS thing in an XPCOM thing that duplicates
its fields with a different ownership model! We totally need another one of
those, right? And we could even stick it in XPConnect! </sarcasm>
In seriousness - the code to own, format, and display error reports is
currently spread between the JS engine, JSErrorReporters, an async Runnable
abstraction, and elsewhere. We need to condense it somewhere to start chipping
away at this mess.
2014-09-08 16:30:10 -07:00
1b1d6ffebf
Bug 1061023 - Fix more bad implicit constructors in DOM; r=baku
...
--HG--
extra : rebase_source : c80c5f9d7ae28286513cdb52ad76b46c240bdd5d
2014-09-01 18:26:43 -04:00
0653303071
Bug 1060987 - Fix more bad implicit constructors in DOM; r=baku
...
--HG--
extra : rebase_source : 01709017e97fdc96d1d53eb881efc1792118edc4
2014-09-01 20:49:25 -04:00
117bb1a341
Backed out 6 changesets (bug 1060982, bug 1061058, bug 1060987, bug 1061060, bug 1060930) for build bustage
...
CLOSED TREE
Backed out changeset c23b8418e6be (bug 1060987)
Backed out changeset a8cddc6bdffc (bug 1061060)
Backed out changeset b5af5cbdac3f (bug 1060982
2014-09-01 16:48:51 -07:00
6c932dea6c
Bug 1060987 - Fix more bad implicit constructors in DOM; r=baku
2014-09-01 18:00:53 -04:00
6fda146273
Bug 1055925 - Refactor promise to merge main thread and worker thread tasks into a single task. r=nsm
2014-08-19 18:39:56 +08:00
60e99f3cd4
Bug 1047398 - ServiceWorker should use WeakRef instead nsTWeakRef, r=smaug
2014-08-01 17:42:19 +01:00
3fa82c9346
Bug 1045436 - Fix more bad implicit constructors in XPCOM; r=froydnj
2014-07-29 20:43:56 -04:00
d8c0b17d7d
Bug 1043963 - Collapse test-only moz.build files under dom/ into ancestor moz.build files; r=ted
...
There is very little benefit to having another layer of moz.build files, and
removing them will speed up the build a minimal amount. It also paves the way
for removing TEST_DIRS, which could simplify the build system somewhat.
2014-07-26 08:17:24 +02:00
bc5d6801bb
Bug 1041860 - Avoid setting FINAL_LIBRARY to libraries that further use a FINAL_LIBRARY. r=mshal
2014-07-23 08:37:51 +09:00
161ca62afd
Bug 1023547 - Fix intermittent dom/workers/test/test_promise.html failure. r=bz
...
--HG--
extra : transplant_source : %F5%A9%DER%BA%11%E3%2C%E3R%C8%40%F3%5E%D5%C3%A6%FE%9D%90
2014-07-18 18:13:47 -07:00
712ba6cabb
Backed out changeset 38bfa2af2bd8 (bug 1023547) for making test_promise.html perma-fail.
2014-07-20 15:39:04 -04:00
c152f140c3
Bug 1023547 - Fix intermittent dom/workers/test/test_promise.html failure. r=bz
2014-07-18 18:13:47 -07:00
0106bd027b
Bug 966452 part 2. Report all unhandled Promise rejections. r=nsm,bholley
2014-07-04 01:24:59 -04:00
92fb7dde3a
Bug 1040263. Eagerly create and preserve Promise reflectors so we always have them available during unlink. r=nsm,bholley.
2014-07-18 21:31:11 -04:00
1465e09a99
Bug 1037691 - Fix instances where refcounted classes expose a public destructor. r=ehsan,bent,mayhemer,jrmuizel
2014-07-15 11:37:45 -04:00
18c3e0073a
Bug 1035394 - Fix dangerous public destructors in dom - r=ehsan
2014-07-08 17:23:17 -04:00
673c436cdb
Backed out changeset 42f348168125 (bug 966452)
2014-07-04 08:23:38 +02:00
2a36000fa7
Bug 966452 part 2. Report all unhandled Promise rejections. r=nsm
2014-07-04 01:24:59 -04:00
a58ac47144
Bug 984048 - Patch 4 - Handle parse and uncaught errors. r=khuey
...
--HG--
extra : rebase_source : 463146233c874c2f2c63c018f2a43a66ca9ea49a
2014-07-02 17:48:35 -07:00
e6f74ae48b
Bug 966471. Add some facilities for examining the state of a promise via a PromiseDebugging utility namespace. r=nsm,peterv
2014-07-02 00:19:48 -04:00
40b922a6e4
Backed out 3 changesets (bug 984048) for breaking hazard builds.
...
Backed out changeset 2d0c34b7045f (bug 984048)
Backed out changeset c18211a2afa1 (bug 984048)
Backed out changeset 30fa36882d57 (bug 984048)
2014-07-01 20:29:08 -07:00
01ba86a01d
Bug 965644 - Fix intermittent oranges on promise tests. r=bz
2014-07-01 17:33:00 -07:00
9fdd7f0e9a
Bug 984048 - Promise::MaybeReject ErrorEvent overload no longer needed. Fix compile error. r=bustage
...
--HG--
extra : amend_source : 5fcbc1c3912503e98f36fce514ddc2433da31a3e
2014-07-01 17:07:47 -07:00
80b377d13a
Bug 984048 - Patch 4 - Handle parse and uncaught errors. r=khuey
2014-07-01 16:43:13 -07:00
a510b05849
Backed out changesets bacfdc83424a and 7d12b5d7446f (bug 984048) for crashes.
2014-06-30 17:22:47 -04:00
f66104b587
Bug 984048 - Patch 4 - Handle parse and uncaught errors. r=khuey
...
--HG--
extra : rebase_source : 9cc36dea950be96fba079877c2d67b76f8383635
2014-06-30 13:31:02 -07:00
ec742680c8
Bug 1028588 - Fix dangerous public destructors in the rest of dom/ - r=ehsan
2014-06-23 15:56:07 -04:00
2d027024a6
Bug 1023033: Remove unnecessary MOZ_COUNT_CTOR/DTOR from promise code. r=mccr8
2014-06-17 09:39:16 -07:00
85647df24b
Bug 1025973 - Part 2: Do not pass JSContext to static webidl methods in non-worker case. r=bz
2014-06-16 12:52:00 -04:00
8bf2933ed2
Bug 1025973 - Part 1: Rename GlobalObject::GetContext() to Context(). r=bz
2014-06-16 14:08:00 -04:00
bc1e511e33
Bug 1009675 part 2. Return WebIDL 'any' values as handles. r=peterv
2014-06-11 16:26:52 -04:00
ef0746d5f8
Bug 1020226 - Fix unhandled Promise rejection handling in workers. r=khuey
...
* * *
Bug 1020226 - Test case to crash browser when using Promises on workers. r=khuey
2014-06-05 12:21:56 -07:00
a0760577c7
Bug 1016560. Remove the footgun of rejecting promises with arbitrary objects. r=khuey
2014-06-03 11:38:38 -04:00
24cbfd735d
Backed out changesets 6d1c36585219 and bd403a727849 (bug 1016560) for mochitest-other failures.
...
CLOSED TREE
2014-06-03 13:48:49 -04:00
0a69a27027
Bug 1016560. Remove the footgun of rejecting promises with arbitrary objects. r=khuey
2014-06-03 11:38:38 -04:00
b1296fcdbf
Bug 1008467 - Callbacks to then() resolve Promise asynchronously. r=bz
2014-05-20 14:55:36 -07:00
9f97d383b6
Bug 1009569 - Promise then() must be called on a clean stack. r=bz
2014-05-20 14:21:13 -07:00
c49e263d0f
Bug 998002 - Rename nsContentUtils::Get{Subject,Object}Principal to nsContentUtils::{Subject,Object}Principal. r=bholley
2014-05-13 11:58:00 +02:00
da0155c439
Bug 949325 - C++ wrapper to support DataStore API on the worker (part 2-1, provide a proxy to resolve/reject Promise on workers). r=baku,nsm,khuey
2014-02-24 21:56:54 +08:00
1216544376
Bug 959787 - Handlify remaining JS APIs r=terrence r=bz r=bholley
2014-04-30 10:10:33 +01:00
fc5fc8f292
Bug 995163 - wrap the Promise value in NativePromiseCallback, r=bz
2014-04-29 22:12:14 +01:00
7ac92ae5ea
Bug 900903 - Part 2: Change uses of numbered macros in nsCycleCollectionParticipant.h to the variadic variants. r=smaug
2014-04-25 12:49:00 -04:00
d05a92fd80
Bug 996831. Add a ToJSValue overload for nsresult, to allow rejecting promises from C++ more easily. r=bholley
2014-04-16 15:13:41 -04:00
565416fed7
Backed out 3 changesets (bug 996474, bug 996831) for B2G bustage on a CLOSED TREE.
...
Backed out changeset 8f98a4c2257f (bug 996831)
Backed out changeset 7acce569bd84 (bug 996831)
Backed out changeset 1845b09c7578 (bug 996474)
2014-04-16 19:31:41 -04:00
9523850626
Bug 996831. Add a ToJSValue overload for nsresult, to allow rejecting promises from C++ more easily. r=bholley
2014-04-16 15:13:41 -04:00
173bd25321
Bug 993413 - Remove use of JS_Add/Remove*Root in favour of JS::PersistentRooted where possible r=terrence r=bz r=bholley
2014-04-16 09:47:53 +01:00
4ad64a690c
Bug 994453 part 1. Factor out the to-JS conversions from Promise.h into mozilla::dom::ToJSValue methods. r=bholley
...
Apart from moving the methods, I made the following changes:
1) Renamed them to ToJSValue.
2) Inlined the boolean overload.
3) Added overloads that take integer types.
4) Changed the order of the aCx and aArgument arguments so aCx comes first.
5) Renamed "abv" to "obj" in the typed array overload.
2014-04-10 14:57:07 -04:00
7eca30f98c
Bug 991080. Add an overload of Promise::ArgumentToJSValue that lets callers pass in an nsTArray to MaybeResolve() a promise with a JS array. r=khuey
2014-04-10 00:58:43 -04:00
a0bb95a823
Bug 993889 part 1. Remove "scope" argument from nsContentUtils::WrapNative. r=bholley
2014-04-10 00:58:41 -04:00
2029b0f60f
Bug 974893 - Remove EnterCompartment and keep the global with the value in Promise, r=bz
2014-04-09 09:30:24 +01:00
937b351273
Backed out changeset 7fa9564a2486 (bug 974893) for build failures
2014-04-09 09:08:39 +01:00
726b941dd1
Bug 974893 - Remove EnterCompartment and keep the global with the value in Promise, r=bz
2014-04-09 08:32:46 +01:00
33e4783558
Bug 991742 part 10. Remove the "aScope" argument from the Promise ArgumentToJSValue() methods. r=bholley
2014-04-08 18:27:19 -04:00
feebd363fb
Bug 991742 part 9. Remove the "scope" argument of WrapNewBindingObject. r=bholley
2014-04-08 18:27:19 -04:00
79dab91ff6
Bug 991742 part 8. Remove the "aScope" argument of WebIDL/nsWrapperCache WrapObject() methods. r=bholley
...
This patch was mostly generated with the following command:
find . -name "*.h" -o -name "*.cpp" | xargs sed -e '/WrapObject(JSContext/ {; N; s/\(WrapObject(JSContext *\* *a\{0,1\}[Cc]x\),\n\{0,1\} *JS::Handle<JSObject\*> a\{0,1\}[sS]cope/\1/ ; }' -i ""
and then reverting the changes that made to
dom/bindings/BindingUtils.h, since those WrapObject methods are not
the ones we're trying to change here, plus a bunch of manual fixups
for cases that this command did not catch (including all the callsites
of WrapObject()).
2014-04-08 18:27:18 -04:00
d4bd64ee2c
Bug 991742 part 6. Remove the "aScope" argument of binding Wrap() methods. r=bholley
...
This patch was mostly generated with this command:
find . -name "*.h" -o -name "*.cpp" | xargs sed -e 's/Binding::Wrap(aCx, aScope, this/Binding::Wrap(aCx, this/' -e 's/Binding_workers::Wrap(aCx, aScope, this/Binding_workers::Wrap(aCx, this/' -e 's/Binding::Wrap(cx, scope, this/Binding::Wrap(cx, this/' -i ""
plus a few manual fixes to dom/bindings/Codegen.py, js/xpconnect/src/event_impl_gen.py, and a few C++ files that were not caught in the search-and-replace above.
2014-04-08 18:27:17 -04:00
0dc016d79f
Bug 991753. Make sure we're in the right compartment before we try wrapping our Promise in Promise::GetOrCreateWrapper. r=bholley
2014-04-03 23:32:11 -04:00
dc2aceddef
Bug 990242. Remove some dead Promise code. r=nsm
2014-04-01 01:58:28 -04:00
7300c8e659
Bug 956197 - Tests to check Promises can accept iterators. r=bz
...
--HG--
extra : amend_source : 7989612b44c67393de7f74fdd0054587722cc79a
2014-03-28 08:17:53 -07:00
d9264c3059
Bug 934368 - Extend Promise#MaybeResolve to receive boolean value. r=smaug
2014-02-26 16:18:34 +08:00
9d543fd864
Bug 910412 - Implement |getRoot|, |createDirectory| and |get| for Directory. r=dhylands, r=smaug
2014-03-05 11:25:40 +08:00
1b94bf3a95
Bug 967005 - Report rejected promises when worker stops running. r=bent
...
--HG--
extra : rebase_source : 3f569387061151b1afb5f09a8d1ca04e85e376e1
2014-03-12 07:31:03 -07:00
7bce447ef8
Backed out changeset 716ba77a9d0a (bug 967005) for ASAN m-4 failures
2014-03-11 17:23:35 -07:00
d2b78e0431
Bug 967005 - Report rejected promises when worker stops running. r=bent
2014-03-11 16:10:41 -07:00
a154cec3e0
Backed out 5 changesets (bug 910412) for intermittent crash whack-a-mole.
...
Backed out changeset e3eb9463b3e1 (bug 910412)
Backed out changeset d5863d302bde (bug 910412)
Backed out changeset 422b66d4b1ca (bug 910412)
Backed out changeset 3431d59d752e (bug 910412)
Backed out changeset b1c0310cdac1 (bug 910412)
2014-03-11 12:17:03 -04:00
6de821884f
Bug 978435 - Add ArgumentToJSVal overload for typed arrays. r=bz
2014-03-10 08:55:46 -04:00
d0efc292f4
Bug 910412 - Implement |getRoot|, |createDirectory| and |get| for Directory. r=dhylands, r=smaug
2014-03-05 11:25:40 +08:00
d67119e27c
Bug 977340 - Clean up cx usage in Promises. r=bz
...
None of these are hazards, because we already make sure to push the JSContext
in the cases where we do anything meaningful in JSAPI. But the current setup
trips the new assertions, and is ugly to boot. Let's fix it.
2014-03-04 10:05:08 -08:00
e3573fb7b1
Bug 976763 - Change DescribeStack not to return JSScripts or JSFunctions (r=bz)
...
--HG--
extra : rebase_source : d9a784df61c00421c9a1e360f92ffc763bf49858
2014-02-25 09:43:14 -06:00
006d532a8a
Bug 974120: Add helpers for using Promse::MaybeResolve/MaybeReject from C++. r=bz
...
Using JSAPI is tedious and error-prone. It's much better to handle that once in the Promise code and allow callers to pass C++ objects.
2014-02-25 13:34:55 -08:00
6062bcb8be
Bug 973988 - DOM Promise constructor should call the executor with "undefined" as thisArg. r=bz
2014-02-19 10:59:23 -08:00
7ee245a69d
Bug 970764. Remove support for non-optional "any" arguments values, since "any" needs to be able to include undefined anyway. Have "any" arguments and dictionary entries default to undefined unless the IDL explicitly says "= null". r=khuey
2014-02-19 10:13:38 -05:00
7d5050a3db
Bug 966384 - Promises on workers use correct busy count. r=khuey
2014-02-17 12:24:36 +05:30
6f465934ec
Backout 3011b2b7f82f (bug 966384) for unused variable failures. r=backout
...
CLOSED TREE
--HG--
extra : amend_source : dfb81e133bca73ba3c5ad959593c5d3d444f8506
2014-02-17 11:06:03 +05:30
1998801252
Bug 966384 - Promises on workers use correct busy count. r=khuey
...
--HG--
extra : rebase_source : 23ad7b8682a8ed6d0062dd9234ee28a18a92a54b
2014-02-17 10:19:15 +05:30
d0e56d0b88
Bug 969812 - Convert JS_NewArrayObject to use HandleValueArray r=terrence r=bz
2014-02-12 10:50:46 +00:00
a1c134c1cb
Bug 966348 - Rename Promise.cast to Promise.resolve. r=bz
2014-02-10 09:27:02 -08:00
16a3c5ed8b
Bug 918806 - Enable DOM Promises. sr=bz
...
--HG--
extra : rebase_source : dbc7ef836fe7c2a71f38fedda004d7f988361a85
2014-01-30 13:14:00 -08:00
aa8ede1cff
Backed out changesets 6db8b08a3aea and 1d7c2025bb56 (bug 918806) for B2G mochitest failures.
2014-01-30 14:46:36 -05:00
bbd4ae9d07
Bug 918806 - Enable DOM Promises. sr=bz
2014-01-30 09:41:43 -08:00
7166faea0a
Bug 872273 - Remove non-cx variant of ErrorFromException, and make it take a HandleObject. r=Waldo
...
We're going to need to start doing more work in js_ErrorFromException, which
will require a |cx| and may GC.
2014-01-30 09:30:29 -08:00
2c39f323ee
Bug 945766 - DOM Promise should pass Promise/A+ tests. r=bz
...
--HG--
extra : rebase_source : efd56968e490fcde3ede6535002864104511a1d1
2014-01-28 10:14:57 -08:00
d5f6f72d7b
Bug 939332 - Implement Promise.all, Promise.cast, Promise.race. r=bz
...
--HG--
extra : rebase_source : 72c1a87a6352005765442ea8903cfa16da8608fd
extra : amend_source : 71b6af7c8446cd501bc337d50a345f24814f20db
2013-11-19 13:53:00 -08:00
af8e8bebc9
Bug 879245 - Implement thenables for Promises. r=bz
...
--HG--
extra : rebase_source : cde27792ae58b13c88367df7a99fc8981097eedd
2014-01-23 10:47:29 -08:00
e345f14d73
Bug 959375 - Add Promise Resolve/Reject overloads accepting a window. r=baku
2014-01-13 14:36:03 -08:00
97292b87fc
Bug 958684 - Fix AsyncErrorReporter leak in Promises. r=mccr8
2014-01-10 14:07:46 -08:00
fe4a7a2ab1
Bug 951352 - Disallow XPIDL_MODULE if XPIDL_SOURCES isn't defined; r=glandium
...
Once upon a time XPIDL_MODULE and MODULE were kind of the same and
MODULE got mass-converted into XPIDL_MODULE with the removal of MODULE
in bug 939044. Unfortunately, we forgot to add a check for XPIDL_MODULE
being defined if XPIDL_SOURCES isn't (a build config that makes no sense
and only results in cargo culting).
This patch corrects that oversight.
--HG--
extra : rebase_source : d609e2baa8d16df97c944bc9def26ad05527d937
2013-12-17 12:45:56 -08:00
357b12898a
Bug 914762 - Switch Workers to use a normal nsThread event loop, r=mrbkap.
...
--HG--
extra : transplant_source : /%93%60%CC%3A%16%B16%A1%5Bmx%9F%FA%7B%10JD%F0%E7
2013-10-23 06:16:49 -07:00
e8f2e2d695
Bug 936700 - Worker Preferences cache. r=bent
2013-11-24 11:27:15 -08:00
c78157de46
Bug 915233 - DOM Promises on Workers. r=baku,bent,smaug,bz sr=sicking
2013-11-24 11:26:07 -08:00
Shu-yu Guo
Andrea Marchesini
Boris Zbarsky
Andrew McCreight
Nikhil Marathe
Nicholas Nethercote
Jinank Jain
Alpha A.
Kyle Huey
Aryeh Gregor
Hiroyuki Ikezoe
James Cheng
Bobby Holley
Tom Tromey
Ryan VanderMeulen
Birunthan Mohanathas
Michael Layzell
Randell Jesup
Juan Gomez
Edwin Flores
David Rajchenbach-Teller
Terrence Cole
Ehsan Akhgari
Wes Kocher
Ben Kelly
Phil Ringnalda
Jim Blandy
Catalin Badea
Nick Fitzgerald
Daniel Holbert
Jonathan Griffin
Paolo Amadini
Olli Pettay
Ms2ger
Edgar Chen
Dan Gohman
Nigel Babu
Carsten "Tomcat" Book
Jan-Ivar Bruaroey
Tom Schuster
Peter Van der Beken
Yuan Xulei
Mike Hommey
Benoit Girard
Benoit Jacob
Nick Lebedev
Gene Lian
Jon Coppeard
Ed Morley
Richard Barnes
Luke Wagner
William Chen
Gregory Szorc
Ben Turner