We kept this class around so that we could toggle back and forth between the
Photon-era footer button style, and the Proton-era menuitem style for footer
buttons.
Now that v89 has shipped, we can remove that class and switch the markup and
styling over completely to the Proton styling.
Differential Revision: https://phabricator.services.mozilla.com/D117553
Fixes a case where at the end of a pinch-zoom on the Draw compositor
the tiles would be drawn incorrectly (due to the transforms not
being quite right for the local-to-surface case here, which was
affecting the occlusion calculations).
Differential Revision: https://phabricator.services.mozilla.com/D118559
This lines up all the columns and makes most of the fields 6 characters wide.
String fields are left aligned, numbers right aligned. This makes it a little
less unreadable.
Differential Revision: https://phabricator.services.mozilla.com/D118508
Most of the time when I use these I'm only interested in the main runtime, so
this makes printing the information on workers optional. It also commons up the
logic involved.
Differential Revision: https://phabricator.services.mozilla.com/D118506
We have been doing this on Windows for a very very long time, to
increase perceived performance.
Given the default scroll speed on Linux matches windows without the
override, it makes sense doing it on Linux as well, for the same
reasons.
Differential Revision: https://phabricator.services.mozilla.com/D117286
This doesn't change behavior on GNOME because we already set
"gtk-application-prefer-dark-theme" to dark, and the fallback theme is
Adwaita, but on KDE we get the wrong close icons if we don't do this.
Differential Revision: https://phabricator.services.mozilla.com/D117724
While testing the above patch on a variety of gtk themes, I noticed that
selection colors were inconsistent (as in, from the old theme) when
switching gtk themes, and tracked that down to this call.
Since we only need to restore the theme when actually overridden, track
that instead.
Differential Revision: https://phabricator.services.mozilla.com/D118311
CLOSED TREE
Ensure we only remove the DoH config update observer once in the connection dialog code.
await resetPrefs when cleaning up in the dialog test - it's an async function.
Don't forget to reset the regional pref in browser_remoteSettings_newProfile.js
Use the new default provider pref in test_trr_confirmation.js
We can still get multiple nightly graphs off the same revision, if
the 2nd cron task runs before the 1st one finishes. However, once
the 1st finishes, we will prevent a 2nd nightly graph. (This has the
side effect of not being able to trigger a 2nd nightly graph off the
same revision, even if the first nightly graph failed, but I think
that's still an improvement. We can work around this with a new push,
or triggering the platform-specific nightly graphs.)
Differential Revision: https://phabricator.services.mozilla.com/D118543
In bug 1717519 we're seeing access violations when writing
to the destination with SWGL. This does some early writes
to try to catch the problem earlier.
Differential Revision: https://phabricator.services.mozilla.com/D118556
It's better to change the input parameter's type of
`AppendAndConsumeChunk` from `AudioChunk*` to `AudioChunk&&` since the
`AudioChunk` will be consumed once it's fed to this function.
One benefit for doing so is to prevent the consumed `AudioChunk` from
being used again after it's moved/consumed. Gecko has a clang-tidy
check, bugprone-use-after-move [1], to avoid this kind of error. We
should utilize this check instead of catching used-after-move error by
human eyes.
[1]: https://searchfox.org/mozilla-central/rev/f351e19360729b351bfc7c1386d6e4ca4ea676e2/tools/clang-tidy/config.yaml#70
Differential Revision: https://phabricator.services.mozilla.com/D117714
As there are some things to solve first for the sysroot, we don't enable
the sysroot bootstrap unless --enable-bootstrap is given explicitly. The
default will still bootstrap everything else when building on central.
Differential Revision: https://phabricator.services.mozilla.com/D118450
gfxUtils::ConvertBGRAtoRGBA() could be removed. BGRA->RBGA conversion could be done by DrawTargetSkia::CopySurface() in RenderCompositorSWGL::CommitMappedBuffer(). Though DrawTargetCairo::CopySurface() does not do the conversion.
On Android, RenderCompositorSWGL is not expected to be used on release. It is only for testing for now.
Differential Revision: https://phabricator.services.mozilla.com/D118449
For OOP iframes, a doc load complete event on the embedder document doesn't necessarily mean the iframe document has finished loading yet.
We already checked for the busy state on the nested iframe doc and waited for a doc load complete event in that case.
However, depending on timing, it might be possible there is no document at all (even a busy one), so we should wait for doc load complete in that case too.
This is a speculative fix; I wasn't able to reproduce this myself.
Differential Revision: https://phabricator.services.mozilla.com/D118123
Jan Varga
Mike Conley
Andrew Osmond
Miko Mynttinen
Alexandre Poirot
Julian Descottes
Iulian Moraru
Christoph Kerschbaumer
Tomislav Jovanovic
Glenn Watson
Kagami Sascha Rosylight
Jon Coppeard
Dmitry Bezhetskov
Dale Harvey
Emilio Cobos Álvarez
mhoye
Jan de Mooij
Tooru Fujisawa
Cosmin Sabou
Nihanth Subramanya
Mats Palmgren
Aki Sasaki
Jeff Muizelaar
Nika Layzell
Michelle Goossens
Chun-Min Chang
Brindusan Cristian
Mike Hommey
sotaro
James Teh
Sam Foster