6666ac0af8
Bug 1696180 - Update Clang based static analysis to clang 12. r=firefox-build-system-reviewers,mhentges
...
Differential Revision: https://phabricator.services.mozilla.com/D113330
2021-04-28 09:56:13 +00:00
85bbcbfa5e
Bug 1602143 - Use ShortStatementLines=1 for readability-braces-around-statements. r=andi
...
This will reduce the false-positive rate that sometimes causes devs to
ignore other important warnings because they expect to see these
warnings because of module/legacy code styles.
```
if (foo) return; // no longer warns
if (bar)
return; // still warns
```
clang-format will sometimes turn long-line versions of the former into
the latter, and this warning will pick those as readability warnings.
NB: This is Chromium style for same-line conditional statements.
Another test result json has its EOL-newline removed too, since that's
what the script does and I'm just committing its results.
Differential Revision: https://phabricator.services.mozilla.com/D105497
2021-02-18 08:26:11 +00:00
180d35da9f
Bug 1685335 - Update to clang 11.0.1 r=firefox-build-system-reviewers,static-analysis-reviewers,andi,mhentges,sylvestre
...
In addition to the usual dot-release type of fixes, this also lets us drop a good amount of code that we had patched into our clang 11.
Differential Revision: https://phabricator.services.mozilla.com/D100959
2021-01-07 13:53:53 +00:00
7ae6aea145
Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D100484
2021-01-07 08:53:08 +00:00
2978aa00a3
Backed out changeset dbed1cdf588f (bug 1684173) for mochitest plain and devtools failures. a=backout DONTBUILD
2020-12-28 00:43:51 +02:00
775cdec032
Bug 1684173 - Add newline character at end of files when missing r=sylvestre
...
Depends on D100443
Differential Revision: https://phabricator.services.mozilla.com/D100484
2020-12-27 11:43:41 +00:00
20512e8f40
Bug 1674633 - clang-tidy: disable WarnOnConditionVariables for readability-else-after-return r=static-analysis-reviewers,andi DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D100085
2020-12-18 08:29:08 +00:00
f7ffcd09fb
Bug 1679758 - Remove trailing empty lines r=sylvestre,marionette-reviewers,jgraham
...
Differential Revision: https://phabricator.services.mozilla.com/D99595
2020-12-15 10:34:54 +00:00
7320ae982a
Backed out changeset f3aaf04fce3b (bug 1679758) for Devtool failures in browser_styleeditor_syncAddProperty.js. CLOSED TREE
2020-12-13 16:38:21 +02:00
caf549c200
Bug 1679758 - Remove trailing empty lines r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D99595
2020-12-13 13:28:30 +00:00
e9fbba867c
Bug 1666550 - Update `clang-tools` to `clang-11`. r=dmajor
...
Differential Revision: https://phabricator.services.mozilla.com/D97137
2020-11-17 15:04:14 +00:00
8731a55350
Bug 1612274 - Add checker `readability-qualified-auto` for `clang-tidy` static-analysis. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D70481
--HG--
extra : moz-landing-system : lando
2020-04-10 07:06:09 +00:00
56a9802f89
Bug 1625884 - move `clang-tidy` and `clang-format` to `clang-10`. r=nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D70065
--HG--
extra : moz-landing-system : lando
2020-04-09 14:16:44 +00:00
60934f9072
Backed out 3 changesets (bug 1625884) as requested by ANdi for causing build bustages. a=backout
...
Backed out changeset a35cfda6e271 (bug 1625884)
Backed out changeset 412c8c401196 (bug 1625884)
Backed out changeset 927ff250bc4b (bug 1625884)
2020-04-09 16:14:06 +03:00
ffe0a6a754
Bug 1625884 - move `clang-tidy` and `clang-format` to `clang-10`. r=nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D70065
--HG--
extra : moz-landing-system : lando
2020-04-09 05:28:34 +00:00
205bea23c3
Bug 1617528 - Enable modernize-use-using at review phase r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D63819
--HG--
extra : moz-landing-system : lando
2020-02-24 10:05:16 +00:00
f9328d2021
Bug 1613526 - Create a code quality documentation and move the appropriate docs r=ahal
...
This for a few reasons:
* The summary becomes the landing page for code quality:
https://firefox-source-docs.mozilla.org/tools/static-analysis/summary.html
* I don't think we need a full code quality category
* Closer to the source-code-doc
* All the files at the same place
Differential Revision: https://phabricator.services.mozilla.com/D61767
--HG--
rename : tools/lint/docs/coding-style/coding_style_java.rst => docs/code-quality/coding-style/coding_style_java.rst
rename : tools/lint/docs/coding-style/coding_style_other.rst => docs/code-quality/coding-style/coding_style_other.rst
rename : tools/lint/docs/coding-style/coding_style_python.rst => docs/code-quality/coding-style/coding_style_python.rst
rename : tools/lint/docs/coding-style/format_cpp_code_with_clang-format.rst => docs/code-quality/coding-style/format_cpp_code_with_clang-format.rst
rename : tools/clang-tidy/docs/summary.rst => docs/code-quality/index.rst
rename : tools/lint/docs/create.rst => docs/code-quality/lint/create.rst
rename : tools/lint/docs/index.rst => docs/code-quality/lint/index.rst
rename : tools/lint/docs/index.rst => docs/code-quality/lint/lint.rst
rename : tools/lint/docs/linters/codespell.rst => docs/code-quality/lint/linters/codespell.rst
rename : tools/lint/docs/linters/cpp-virtual-final.rst => docs/code-quality/lint/linters/cpp-virtual-final.rst
rename : tools/lint/docs/linters/eslint-plugin-mozilla.rst => docs/code-quality/lint/linters/eslint-plugin-mozilla.rst
rename : tools/lint/docs/linters/eslint-plugin-spidermonkey-js.rst => docs/code-quality/lint/linters/eslint-plugin-spidermonkey-js.rst
rename : tools/lint/docs/linters/eslint.rst => docs/code-quality/lint/linters/eslint.rst
rename : tools/lint/docs/linters/file-perm.rst => docs/code-quality/lint/linters/file-perm.rst
rename : tools/lint/docs/linters/file-whitespace.rst => docs/code-quality/lint/linters/file-whitespace.rst
rename : tools/lint/docs/linters/flake8.rst => docs/code-quality/lint/linters/flake8.rst
rename : tools/lint/docs/linters/l10n.rst => docs/code-quality/lint/linters/l10n.rst
rename : tools/lint/docs/linters/license.rst => docs/code-quality/lint/linters/license.rst
rename : tools/lint/docs/linters/lintpref.rst => docs/code-quality/lint/linters/lintpref.rst
rename : tools/lint/docs/linters/mingw-capitalization.rst => docs/code-quality/lint/linters/mingw-capitalization.rst
rename : tools/lint/docs/linters/perfdocs.rst => docs/code-quality/lint/linters/perfdocs.rst
rename : tools/lint/docs/linters/rstlinter.rst => docs/code-quality/lint/linters/rstlinter.rst
rename : tools/lint/docs/linters/rustfmt.rst => docs/code-quality/lint/linters/rustfmt.rst
rename : tools/lint/docs/usage.rst => docs/code-quality/lint/usage.rst
rename : tools/clang-tidy/docs/index.rst => docs/code-quality/static-analysis.rst
extra : moz-landing-system : lando
2020-02-11 09:11:44 +00:00
8b571b9067
Backed out changeset f65bd225f199 (bug 1609864) as requested. a=backout DONTBUILD
2020-02-03 10:34:00 +02:00
678216c088
Bug 1609864 - For `clang-tidy` disable checker `performance-noexcept-move-constructor`. r=sylvestre
...
Since we don't build use exceptions nor we use STL containers that rely on this when choosing copy
from move ctors, if these are not marked with noexcept, we should disable this checker since
it brings only noise to our analysis.
Differential Revision: https://phabricator.services.mozilla.com/D60218
--HG--
extra : moz-landing-system : lando
2020-01-17 08:49:01 +00:00
43270f5c15
Bug 1606630 - add tests with `if constexpr` for checkers `readability-misleading-indentation` and `readability-braces-around-statements`. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D58936
--HG--
extra : moz-landing-system : lando
2020-01-08 08:39:44 +00:00
25a4df6b51
Bug 1606170 - Create a list of static analyzer/linters r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D58325
--HG--
extra : moz-landing-system : lando
2020-01-02 16:55:33 +00:00
1e63d1f7ca
Bug 1605852 - Disable performance-inefficient-algorithm as the test isn't C++17 ready r=andi CLOSED TREE
...
Differential Revision: https://phabricator.services.mozilla.com//D58529
--HG--
extra : histedit_source : b6e9096717acf79065eb09d661ab11dc8cd8407b
2020-01-02 17:24:07 +02:00
3ff277ca7c
Bug 1605852 - Enable modernize-concat-nested-namespaces r=andi
...
Depends on D58190
Differential Revision: https://phabricator.services.mozilla.com/D58191
--HG--
extra : moz-landing-system : lando
2019-12-26 10:22:23 +00:00
bfaa7ac663
Bug 1606452 - Update the version of clang-format in the configuration r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D58456
--HG--
extra : moz-landing-system : lando
2019-12-31 19:07:01 +00:00
1e61298151
Bug 1601103 - Enable clang-tidy's cppcoreguidelines-pro-type-member-init. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D55745
--HG--
extra : moz-landing-system : lando
2019-12-04 19:57:08 +00:00
19d21ac142
no bug - Add links to the static analysis project in the doc r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D55465
--HG--
extra : moz-landing-system : lando
2019-12-02 17:04:27 +00:00
e8c4cdd941
Bug 1600361 - Improve the static analysis doc r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D55349
--HG--
extra : moz-landing-system : lando
2019-11-30 11:31:48 +00:00
09ed42e0fd
Bug 1600361 - Move the static analysis doc in tree r=andi
...
+ add a thing about coding style
Differential Revision: https://phabricator.services.mozilla.com/D55345
--HG--
extra : moz-landing-system : lando
2019-11-30 10:18:37 +00:00
c85e350b5b
Bug 1599101 - For clang-tidy based analysis add checker `clang-analyzer-cplusplus.Move`. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D54522
--HG--
extra : moz-landing-system : lando
2019-11-25 15:54:58 +00:00
a907930749
Bug 1558359 - clang-tidy - For `performance-move-const-arg` disable detection of trivially copyable types that do not have a move constructor. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D49415
--HG--
extra : moz-landing-system : lando
2019-10-16 12:59:33 +00:00
103a1cbba6
Bug 1573211 - Update to clang 9.0.0 r=glandium
...
Updates all clang 8.0.1 to version 9.0.0, except for the mingw builds
which suffer from bug 1548624 and will be handled separately later.
Differential Revision: https://phabricator.services.mozilla.com/D44160
MANUAL PUSH: Rebuild clang toolchains without stalling autoland
--HG--
rename : build/build-clang/clang-8-android.json => build/build-clang/clang-android.json
rename : build/build-clang/clang-8-linux64-aarch64-cross.json => build/build-clang/clang-linux64-aarch64-cross.json
rename : build/build-clang/clang-8-linux64.json => build/build-clang/clang-linux64.json
rename : build/build-clang/clang-8-macosx64.json => build/build-clang/clang-macosx64.json
rename : taskcluster/scripts/misc/build-clang-8-linux-macosx-cross.sh => taskcluster/scripts/misc/build-clang-linux-macosx-cross.sh
2019-09-21 16:26:53 +02:00
e2348a18ee
Backed out 2 changesets (bug 1573211) as requested by dmajor on irc. CLOSED TREE
...
Backed out changeset 587463567434 (bug 1573211)
Backed out changeset de0fe40466cb (bug 1573211)
--HG--
rename : build/build-clang/clang-android.json => build/build-clang/clang-8-android.json
rename : build/build-clang/clang-linux64-aarch64-cross.json => build/build-clang/clang-8-linux64-aarch64-cross.json
rename : build/build-clang/clang-linux64.json => build/build-clang/clang-8-linux64.json
rename : build/build-clang/clang-macosx64.json => build/build-clang/clang-8-macosx64.json
rename : taskcluster/scripts/misc/build-clang-linux-macosx-cross.sh => taskcluster/scripts/misc/build-clang-8-linux-macosx-cross.sh
extra : histedit_source : 3f9570ab67fd42186265b1dbb6e93c8342bc60e2
2019-09-26 20:12:51 +03:00
5f02cc9b02
MANUAL PUSH: Fix for Bug 1573211 - Re-generate the autotest results for clang-tidy analysis. r=myself.
...
--HG--
extra : rebase_source : d360e92b0da5701e1cfd4e1f49032283bd288ed5
extra : amend_source : edf7899f8bce61f4a5120713bd04cedc83085ea7
2019-09-25 17:30:19 +03:00
9d69f6a5ba
Bug 1573211 - Update to clang 9.0.0 r=glandium
...
Updates all clang 8.0.1 to version 9.0.0, except for the mingw builds
which suffer from bug 1548624 and will be handled separately later.
Differential Revision: https://phabricator.services.mozilla.com/D44160
MANUAL PUSH: Rebuild clang toolchains without stalling autoland
--HG--
rename : build/build-clang/clang-8-android.json => build/build-clang/clang-android.json
rename : build/build-clang/clang-8-linux64-aarch64-cross.json => build/build-clang/clang-linux64-aarch64-cross.json
rename : build/build-clang/clang-8-linux64.json => build/build-clang/clang-linux64.json
rename : build/build-clang/clang-8-macosx64.json => build/build-clang/clang-macosx64.json
rename : taskcluster/scripts/misc/build-clang-8-linux-macosx-cross.sh => taskcluster/scripts/misc/build-clang-linux-macosx-cross.sh
extra : amend_source : 2dc7e91897e869ead501f19fbd7960d59c4b79bd
2019-09-21 16:26:53 +02:00
fa8b298b59
Bug 1577726 - Ride along: Remove third_party from the clang tidy configuration as it isn't used r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D44163
--HG--
extra : moz-landing-system : lando
2019-09-05 13:52:22 +00:00
65d8b0025e
Bug 1564252 - Move to clang 8.0.1 r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com//D42325
--HG--
extra : amend_source : 129ff97f6edc41ad7a2f54520141158416e75b8d
2019-08-20 21:06:24 +02:00
4b22abe3d1
Bug 1558987 - For clang based static-analysis, disable readability-isolate-declaration. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D34818
--HG--
extra : moz-landing-system : lando
2019-06-13 12:32:57 +00:00
ca4a195007
Bug 1551842 - Add new clang-tidy checkers from clang 8.0.0. r=sylvestre,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D31229
--HG--
extra : moz-landing-system : lando
2019-05-22 14:55:45 +00:00
7be18f3d26
Bug 1503453 - re-enable static-analysis autotest on win64 platform after migrating to clang-tidy 8. r=sylvestre
...
Also for checker `modernize-avoid-bind` export the respective reliability index from config.yaml
Differential Revision: https://phabricator.services.mozilla.com/D30904
--HG--
extra : moz-landing-system : lando
2019-05-14 13:00:13 +00:00
88e7b97c2a
Bug 1551083 - Enable bugprone-move-forwarding-reference r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D30816
--HG--
extra : moz-landing-system : lando
2019-05-14 07:12:37 +00:00
32fe00ed34
Bug 1544764 - Add description at review phase about defects found - clang-tidy. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D27669
--HG--
extra : moz-landing-system : lando
2019-04-18 08:49:52 +00:00
feb0789249
Backed out changeset 7cefdbb63711 (bug 1544764) for static-analysis bustage on clang-analyzer-deadcode.DeadStores.cpp. CLOSED TREE
2019-04-18 00:33:29 +03:00
bbedccc1b9
Bug 1544764 - Add description at review phase about defects found - clang-tidy. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D27669
--HG--
extra : moz-landing-system : lando
2019-04-17 16:16:42 +00:00
c9b234eafc
Bug 1543492 - for clang based static-analysis and formating add a package version that represents a baseline if we continue the analysis or prompt for an update. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D27042
--HG--
extra : moz-landing-system : lando
2019-04-11 09:58:59 +00:00
fb86931b20
Bug 1503453 - Fix Perma 'mach static-analysis autotest; caused by Bug 1540769. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D26095
--HG--
extra : moz-landing-system : lando
2019-04-04 11:34:47 +00:00
c52ebc3ea9
Bug 1540769 - Enable readability-redundant-preprocessor r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D25630
--HG--
extra : moz-landing-system : lando
2019-04-02 06:07:39 +00:00
bf99cf9d2e
Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D24175
--HG--
extra : moz-landing-system : lando
2019-04-01 12:24:35 +00:00
8a67ec169a
Backed out 3 changesets (bug 1538060, bug 1539779, bug 1536790) for causing clang-tidy bustages CLOSED TREE
...
Backed out changeset 7d058f3174e5 (bug 1538060)
Backed out changeset 8839622122ed (bug 1539779)
Backed out changeset 9eb7867c1dd4 (bug 1536790)
--HG--
rename : build/build-clang/clang-8-android.json => build/build-clang/clang-7-android.json
rename : build/build-clang/clang-8-linux64.json => build/build-clang/clang-7-linux64.json
rename : build/build-clang/clang-8-macosx64.json => build/build-clang/clang-7-macosx64.json
rename : build/build-clang/clang-8-mingw.json => build/build-clang/clang-trunk-mingw.json
rename : taskcluster/scripts/misc/build-clang-8-android.sh => taskcluster/scripts/misc/build-clang-7-android.sh
rename : taskcluster/scripts/misc/build-clang-8-linux-macosx-cross.sh => taskcluster/scripts/misc/build-clang-7-linux-macosx-cross.sh
rename : taskcluster/scripts/misc/build-clang-8-linux.sh => taskcluster/scripts/misc/build-clang-7-linux.sh
rename : taskcluster/scripts/misc/build-clang-8-mingw.sh => taskcluster/scripts/misc/build-clang-trunk-mingw.sh
2019-03-30 01:52:37 +02:00
878a6926e9
Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
...
Reviewers: andi
Reviewed By: andi
Bug #: 1536790
Differential Revision: https://phabricator.services.mozilla.com/D24175
--HG--
extra : rebase_source : 4916f93d375ba7415a000fd1a4c48f214b300f47
extra : histedit_source : d21ca90bd40c0fe2db99ea69b7d3c98eaf872f49
2019-03-30 01:23:21 +02:00
0bc3e10232
Backed out 2 changesets (bug 1539779, bug 1536790) for toolchain failure. On a CLOSED TREE
...
Backed out changeset 5ecdbfab88b4 (bug 1539779)
Backed out changeset 20d5cdaa08e3 (bug 1536790)
2019-03-29 10:34:45 +02:00
Andi-Bogdan Postelnicu
Jeff Gilbert
David Major
Kartik Gautam
Cosmin Sabou
Sylvestre Ledru
Dorel Luca
Andi-Bogdan Postelnicu
Csoregi Natalia
Brindusan Cristian
Ciure Andrei
Daniel Varga