Matt Woodrow
7adf95e964
Bug 1620679 - Don't fire load event from within Stop(). r=smaug
...
This matches what the spec says, and what blink does.
Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-30 17:19:54 +00:00
Matt Woodrow
38ffa87e05
Bug 1640160 - Serialize mRequestContextId with BrowsingContext's IPCInitializer to ensure that we don't try to create a request context with an id of 0. r=nika
...
This was a bit of pain to track down, because some code was allowing an ID of 0, and creating a request context to match, but other code was treating 0 as invalid.
Differential Revision: https://phabricator.services.mozilla.com/D76652
2020-05-26 21:14:27 +00:00
Butkovits Atila
1d2238af48
Backed out 2 changesets (bug 1620679) for perma Reftest failure. CLOSED TREE
...
Backed out changeset 8190c67514cc (bug 1620679)
Backed out changeset 4ca2912d7421 (bug 1620679)
2020-05-26 10:58:42 +03:00
Matt Woodrow
d347ab0ef5
Bug 1620679 - Don't fire load event from within Stop(). r=smaug
...
This matches what the spec says, and what blink does.
Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-26 03:08:40 +00:00
Matt Woodrow
b7105cc963
Bug 1627533 - Create LoadGroups for docshells using the BrowsingContext's request context id. r=dragana,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D75885
2020-05-21 03:38:37 +00:00
Noemi Erli
3adaaeb800
Backed out 3 changesets (bug 1627533) for causing assertions in RequestContextService.cpp CLOSED TREE
...
Backed out changeset 3b35a1852a60 (bug 1627533)
Backed out changeset 70fa5e075269 (bug 1627533)
Backed out changeset 0d1046670534 (bug 1627533)
2020-05-21 04:16:21 +03:00
Matt Woodrow
f8b14e22ba
Bug 1627533 - Create LoadGroups for docshells using the BrowsingContext's request context id. r=dragana,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D75885
2020-05-20 23:41:36 +00:00
Mihai Alexandru Michis
19a4744fcc
Backed out 2 changesets (bug 1620679) for causing failures in nsDocShell.cpp
...
CLOSED TREE
Backed out changeset 2957142243c5 (bug 1620679)
Backed out changeset 60df74b03f34 (bug 1620679)
2020-05-18 14:47:37 +03:00
Matt Woodrow
2f95a6ac80
Bug 1620679 - Don't fire load event from within Stop(). r=smaug
...
This matches what the spec says, and what blink does.
Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-18 07:30:14 +00:00
Jared Wein
2c619e2a98
Bug 773942 - Create a new init method in nsITransfer that accepts a BrowsingContext and if the download should be handled internally for backwards-compat. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D75186
2020-05-16 06:00:08 +00:00
Jared Wein
3ab25176e5
Bug 773942 - Use the browsingContext to open the new tab with correct userContextId, private-ness, and ownerTab. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D72778
2020-05-16 05:59:53 +00:00
Jared Wein
3074d7ebb9
Bug 773942 - Open PDFs using pdf.js in a new tab when the Preview option is selected from the Unknown Content Type dialog. r=Gijs
...
This is currently preffed off behind the "browser.helperApps.showOpenOptionForPdfJS" pref.
Differential Revision: https://phabricator.services.mozilla.com/D72776
2020-05-16 05:59:43 +00:00
Narcis Beleuzu
35b6e759f7
Backed out 9 changesets (bug 773942) for xpcshell failure on test_getMIMEInfo_pdf.js
...
Backed out changeset 6fb0f25b2f5d (bug 773942)
Backed out changeset 27e9fe03a549 (bug 773942)
Backed out changeset ee0ecad5e90a (bug 773942)
Backed out changeset df062e14287b (bug 773942)
Backed out changeset 7da06239ccfb (bug 773942)
Backed out changeset dfedbeeaec66 (bug 773942)
Backed out changeset 286e1be9dc46 (bug 773942)
Backed out changeset f4df0a553bc0 (bug 773942)
Backed out changeset 97f3b96b6be0 (bug 773942)
2020-05-16 08:37:53 +03:00
Jared Wein
788718620f
Bug 773942 - Create a new init method in nsITransfer that accepts a BrowsingContext and if the download should be handled internally for backwards-compat. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D75186
2020-05-16 04:26:12 +00:00
Jared Wein
58822bff64
Bug 773942 - Use the browsingContext to open the new tab with correct userContextId, private-ness, and ownerTab. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D72778
2020-05-16 04:25:03 +00:00
Jared Wein
3ace9de33d
Bug 773942 - Open PDFs using pdf.js in a new tab when the Preview option is selected from the Unknown Content Type dialog. r=Gijs
...
This is currently preffed off behind the "browser.helperApps.showOpenOptionForPdfJS" pref.
Differential Revision: https://phabricator.services.mozilla.com/D72776
2020-05-16 04:24:56 +00:00
Chris Peterson
4a38e89842
Bug 1628961
- Replace "clang-format off" with semicolon workaround for clang-format bug 1629756. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D71138
2020-04-16 09:49:35 +00:00
Matt Woodrow
a27cfc760b
Bug 1627971 - Add option to MaybeFireEmbedderLoadEvents to also fire the error event to the embedder element. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D70585
--HG--
extra : moz-landing-system : lando
2020-04-15 22:30:13 +00:00
Chris Peterson
72e3388f74
Bug 1628961
- Replace MOZ_MUST_USE with [[nodiscard]] in docshell and uriloader. r=smaug
...
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
I also needed to wrap the nsDocLoader::RemoveChildLoader() function declaration with // clang-format off and // clang-format on. clang-format insists on indenting the function declaration because it is confused by the NS_DECL_ macros without trailing semicolons before the [[nodiscard]] attribute.
Differential Revision: https://phabricator.services.mozilla.com/D70478
--HG--
extra : moz-landing-system : lando
2020-04-14 06:41:42 +00:00
Dylan Roeh
9541273b5d
Bug 1619798 - Move GeckoView onLoadRequest calls to DocumentLoadListener.cpp r=snorp,mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D69594
--HG--
extra : moz-landing-system : lando
2020-04-10 16:38:48 +00:00
Eric Rahm
a45bbf7d67
Bug 1626451 - Remove nsAutoPtr usage from uriloader/. r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D69122
--HG--
extra : moz-landing-system : lando
2020-04-03 21:05:39 +00:00
Emilio Cobos Álvarez
02c5c21c33
Bug 1625792 - Remove nsIURIContentListener.onStartURIOpen. r=mattwoodrow
...
It's only used to check whether the docshell is gone already, and we need to
deal with that in other places anyway. No other useful implementation.
In comm-central there are a couple, but they're useless too.
Differential Revision: https://phabricator.services.mozilla.com/D68731
--HG--
extra : moz-landing-system : lando
2020-03-29 22:10:09 +00:00
sonakshi
b204bf50aa
Bug 1551306 - Remove context parameter from nsIProgressEventSink.onProgress() and nsIProgressEventSink.onStatus() r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D68235
--HG--
extra : moz-landing-system : lando
2020-03-29 19:18:56 +00:00
Cosmin Sabou
79929c6462
Backed out changeset ad4847d17298 (bug 1551306) for causing build bustages. CLOSED TREE
2020-03-27 20:24:17 +02:00
sonakshi
145046fde2
Bug 1551306 - Remove context parameter from nsIProgressEventSink.onProgress() and nsIProgressEventSink.onStatus() r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D68235
--HG--
extra : moz-landing-system : lando
2020-03-27 17:57:10 +00:00
Mihai Alexandru Michis
c1256a18a6
Backed out changeset d91e4acdd63c (bug 1551306) for causing bustages in request::InitBitsRequest
...
CLOSED TREE
2020-03-27 16:12:47 +02:00
sonakshi
b5f7fb3be7
Bug 1551306 - Remove context parameter from nsIProgressEventSink.onProgress() and nsIProgressEventSink.onStatus() r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D68235
--HG--
extra : moz-landing-system : lando
2020-03-27 14:05:02 +00:00
sonakshi
4a48c5d739
Bug 1594432 - Remove aContext from nsIChildChannel.completeRedirectSetup r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D68177
--HG--
extra : moz-landing-system : lando
2020-03-26 11:07:10 +00:00
Matt Woodrow
4731d04c51
Bug 1620875 - Suppress extra onStateChange(STATE_START) notifications from RemoteWebProgress when switching DocumentChannel with a real channel. r=Gijs,nika
...
Note that this also suppresses notifications from the initial about:blank in the new process, and updates the tabbrowser to not expect those.
Differential Revision: https://phabricator.services.mozilla.com/D65923
--HG--
extra : moz-landing-system : lando
2020-03-17 00:50:29 +00:00
Boris Zbarsky
5f4fd391ec
Bug 1440212 part 1. Remove the always-true aIsTrusted argument of FireFrameLoadEvent. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D35599
--HG--
extra : moz-landing-system : lando
2020-03-11 22:29:53 +00:00
Kris Maglione
c31aa68fb4
Bug 1535617: Part 2 - Clear weak references for most cycle collected objects on unlink. r=mccr8
...
This covers most cycle collected objects which support weak references, but
not the ones which inherit from a cycle collected class and don't do any cycle
collection on their own.
Differential Revision: https://phabricator.services.mozilla.com/D63962
--HG--
extra : moz-landing-system : lando
2020-02-25 19:44:39 +00:00
Simon Giesecke
9350e6b741
Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
...
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.
Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.
Differential Revision: https://phabricator.services.mozilla.com/D62604
--HG--
extra : moz-landing-system : lando
2020-02-20 11:40:14 +00:00
Dorel Luca
d5f9df8ee1
Backed out 2 changesets (bug 1613985) for Build bustage on Windows2012. CLOSED TREE
...
Backed out changeset fd177b40b561 (bug 1613985)
Backed out changeset fb6d62b7f28d (bug 1613985)
2020-02-19 22:22:41 +02:00
Simon Giesecke
59b23375c0
Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
...
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.
Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.
Differential Revision: https://phabricator.services.mozilla.com/D62604
--HG--
extra : moz-landing-system : lando
2020-02-19 18:05:38 +00:00
Emilio Cobos Álvarez
6615ff9fad
Bug 1614208 - Stop including AccessibleCaretEventHub and PresShell.h from Selection.h. r=TYLin
...
And fix a bunch of fallout as we now don't include nsDocShell.h everywhere.
Differential Revision: https://phabricator.services.mozilla.com/D62169
--HG--
extra : moz-landing-system : lando
2020-02-11 01:22:29 +00:00
Eugen Sawin
3045e2f46f
Bug 1608985 - [1.0] Veto redirect when loading is denied by the delegate. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D61703
--HG--
extra : moz-landing-system : lando
2020-02-10 14:30:29 +00:00
Dimi Lee
f9ac16c330
Bug 1599046 - P1. Remove ContentBlockingLog from the child r=timhuang,Ehsan
...
At this point, there is no consumer that uses ContentBlockingLog stored
in the child. This patch removes the following code:
1. Removing nsGlobalWindowOuter::NotifyContentBlockingEvent
2. Removing nsDocLoader::OnContentBlockingEvent
3. Removing contentBlockingEvent in nsISecureBrowserUI.idl
4. Removing mContentBlockingLog from Document.cpp and APIs related to it.
Differential Revision: https://phabricator.services.mozilla.com/D56874
--HG--
extra : moz-landing-system : lando
2020-01-27 10:39:41 +00:00
Brindusan Cristian
00b2950b8d
Backed out 4 changesets (bug 1599046) for xpcshell failures at test_ext_cookieBehaviors. CLOSED TREE
...
Backed out changeset 721f54870498 (bug 1599046)
Backed out changeset 2e165c119a4f (bug 1599046)
Backed out changeset 2bc0fa3bbe0e (bug 1599046)
Backed out changeset 805fb67be8a3 (bug 1599046)
2020-01-27 12:36:11 +02:00
Dimi Lee
ffdfd5d51a
Bug 1599046 - P1. Remove ContentBlockingLog from the child r=timhuang,Ehsan
...
At this point, there is no consumer that uses ContentBlockingLog stored
in the child. This patch removes the following code:
1. Removing nsGlobalWindowOuter::NotifyContentBlockingEvent
2. Removing nsDocLoader::OnContentBlockingEvent
3. Removing contentBlockingEvent in nsISecureBrowserUI.idl
4. Removing mContentBlockingLog from Document.cpp and APIs related to it.
Differential Revision: https://phabricator.services.mozilla.com/D56874
--HG--
extra : moz-landing-system : lando
2020-01-27 09:13:12 +00:00
Matt Woodrow
97c7791de6
Bug 1598520 - Don't require nsIChildChannel for process switching, as we don't need this for DocumentChannel either. r=mayhemer,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D57586
--HG--
extra : moz-landing-system : lando
2020-01-06 21:58:48 +00:00
Razvan Maries
188a114962
Backed out 5 changesets (bug 1598520) for perma fails on test_enumerateDevices_navigation.html. CLOSED TREE
...
Backed out changeset 583dac2feebc (bug 1598520)
Backed out changeset c769e733f588 (bug 1598520)
Backed out changeset 45287a2ec476 (bug 1598520)
Backed out changeset 59cff6014447 (bug 1598520)
Backed out changeset ddf722557c33 (bug 1598520)
2019-12-20 01:56:55 +02:00
Matt Woodrow
d67e6c24b8
Bug 1598520 - Don't require nsIChildChannel for process switching, as we don't need this for DocumentChannel either. r=mayhemer,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D57586
--HG--
extra : source : 4a5d10759bf3ad6cb392c7d83cc163e262314eb1
2019-12-19 21:47:10 +00:00
Razvan Maries
bfe0632450
Backed out 5 changesets (bug 1598520) for Linting failure. CLOSED TREE
...
Backed out changeset b4f71abf75fe (bug 1598520)
Backed out changeset 8e3b650d9313 (bug 1598520)
Backed out changeset 73c37ad27d18 (bug 1598520)
Backed out changeset 10ad2e4d27c3 (bug 1598520)
Backed out changeset 4a5d10759bf3 (bug 1598520)
2019-12-20 00:38:32 +02:00
Matt Woodrow
eb5ca8b399
Bug 1598520 - Don't require nsIChildChannel for process switching, as we don't need this for DocumentChannel either. r=mayhemer,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D57586
--HG--
extra : moz-landing-system : lando
2019-12-19 21:47:10 +00:00
Matt Woodrow
6b7506aff6
Bug 1574372 - Add support to nsDocumentOpenInfo for overriding some functionality that we want to modify in the parent. r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D56136
--HG--
extra : moz-landing-system : lando
2019-12-17 03:02:15 +00:00
Matt Woodrow
af461a2c9d
Bug 1574372 - Move nsDocumentOpenInfo into the header. r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D56133
--HG--
extra : moz-landing-system : lando
2019-12-17 03:01:50 +00:00
Matt Woodrow
f2a23a9c75
Bug 1574372 - Remove pref to force disabling of downloads from background apps, since its unused. r=bzbarsky
...
This was added for b2g, and hasn't been used since.
Differential Revision: https://phabricator.services.mozilla.com/D56131
--HG--
extra : moz-landing-system : lando
2019-12-17 03:01:25 +00:00
Oana Pop Rus
5545e5a016
Backed out 9 changesets (bug 1574372) for bustage and wpt failures. on a CLOSED TREE
...
Backed out changeset b0183a606fec (bug 1574372)
Backed out changeset b7c96254826e (bug 1574372)
Backed out changeset 196d61adc272 (bug 1574372)
Backed out changeset 419b94b1210e (bug 1574372)
Backed out changeset c192e499eb47 (bug 1574372)
Backed out changeset 4e57038c3518 (bug 1574372)
Backed out changeset 6ec2aa542b59 (bug 1574372)
Backed out changeset d71b4c0aac1a (bug 1574372)
Backed out changeset a05c3b113ac1 (bug 1574372)
2019-12-17 03:26:38 +02:00
Matt Woodrow
3f6ef264a3
Bug 1574372 - Add support to nsDocumentOpenInfo for overriding some functionality that we want to modify in the parent. r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D56136
--HG--
extra : moz-landing-system : lando
2019-12-16 21:39:55 +00:00
Matt Woodrow
9beb54445d
Bug 1574372 - Move nsDocumentOpenInfo into the header. r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D56133
--HG--
extra : moz-landing-system : lando
2019-12-16 21:25:24 +00:00