With RTX and transport-cc enabled, it is possible to send padding packets prior
to any media being sent (see comments in RTPSender::SendPadData). But padding
bytes are counted separate from payload bytes and so do not show up in
bytesSent, which means that is possible that we've sent packets, but not bytes,
as far as the stats are concerned. This leads to frequent intermittent failures
while running tests on Android hardware.
Depends on D77815
Differential Revision: https://phabricator.services.mozilla.com/D78287
`numUnbindFailures` can never be non-zero (since any unbind failures throw), so
we should just eliminate this variable.
Differential Revision: https://phabricator.services.mozilla.com/D78362
The fickle, ever-changing whims of unified builds shuffled code around enough that the place where we are printing this value inlined this function and complained about the unique_ptr being null. We continue to not care about this output, so instead of messing around with copying the characters we just return an empty string.
Differential Revision: https://phabricator.services.mozilla.com/D78548
RegExpNativeMacroAssembler.cpp has a list of `using js::jit::X` statements to keep the code readable. Depending on the config options and the whims of the unified build, `using js::jit::Address` can appear in imported V8 files where we actually want `v8::Address`.
The easy fix is to build RegExpNativeMacroAssembler separately.
Differential Revision: https://phabricator.services.mozilla.com/D78519
We didn't talk specifically about private browsing in the meeting today, but we
did say we want to treat form history like remote suggestions, so this patch
checks `queryContext.allowSearchSuggestions` and `queryContext.isPrivate` in
addition to the `browser.urlbar.suggest.searches` and
`browser.search.suggest.enabled` prefs.
Differential Revision: https://phabricator.services.mozilla.com/D78445
Rather than waiting until parsing another id (successfully or
unsuccessfully).
If we error before we even get to PropertyId::parse, we'd incorrectly
associate the error with the wrong property, incorrectly omitting it
sometimes.
Differential Revision: https://phabricator.services.mozilla.com/D78260
The enforcement is only important when users are able to resize the windows. Otherwise,
we let Gecko set the window dimensions to whatever dimensions they'd like.
Differential Revision: https://phabricator.services.mozilla.com/D78538
On Windows, the IDL files were being read with the "charmap" codec, but quotes like “ were causing errors.
By specifying "utf8" instead, the read() succeeds.
Differential Revision: https://phabricator.services.mozilla.com/D77971
`BLOCK_WIN8_ONLY` was introduced by bug 1268470 to block klsihk64.dll only on
Win8. However, a new blocklist (bug 1445025) does wrong comparison on the OS
version, thus `BLOCK_WIN8_ONLY` has blocked modules on all platforms older than
Win10 including Win7 and Win8.1.
This patch corrects OS comparison and changes the flag to `BLOCK_WIN8_AND_OLDER`
to make it more handy. We also remove `BLOCK_WIN8PLUS_ONLY` which is never used.
Differential Revision: https://phabricator.services.mozilla.com/D78411
The Backstop optimization doesn't take any arguments, yet the schema for 'push-optimization-*'
requires a 'schedules-component' that goes ignored. Fix this.
Differential Revision: https://phabricator.services.mozilla.com/D77058
This patch moves all existing reference browser pageload tests from raptor-webext to browsertime. We also delete all raptor-webext reference browser tests.
Differential Revision: https://phabricator.services.mozilla.com/D77474
The other patches in this stack made it so that alwaysontop windows don't focus by
default when they open. We do, however, want the Picture-in-Picture player window to
take focus after it opens.
Differential Revision: https://phabricator.services.mozilla.com/D78523
Dan Minor
Aaron Klotz
Adam Roach [:abr]
Dave Townsend
Ethan Tseng
Bogdan Tara
Justin Wood
Jared Wein
Yoshi Cheng-Hao Huang
Iain Ireland
Maja Frydrychowicz
Kenny Levinsen
Sylvestre Ledru
Drew Willcoxon
Emilio Cobos Álvarez
Ted Campbell
Eugen Sawin
Kagami Sascha Rosylight
Mike Conley
Mitchell Hentges
emcminn
Toshihito Kikuchi
alwu
Itiel
prathiksha
Masatoshi Kimura
Matthew Gaudet
Francesco Lodolo (:flod)
Narcis Beleuzu
Andrew Halberstadt
Mark Banner
Geoff Brown
Olli Pettay
Dão Gottwald
Gregory Mierzwinski