Automatic update from web-platform-tests
[LayoutNG] Include negative margin beyond the right edge
This patch changes the line breaking behavior so that a
negative inline margin beyond the right edge can be included
in the line. Before this change, negative margins could move
the position back only when it's within the available width.
Legacy and WebKit don't do this, while Edge and Gecko do.
However, LayoutNG cannot render a page legacy and WebKit
render the same as other browser due to a bug in min-content.
Instead of copying the min-content bug in LayoutNG, this
patch fixes the page by matching to Edge and Gecko.
Bug: 979894
Change-Id: I07eedbb75f5c3b43e48b826bef18d95f1af872c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684243
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674177}
--
wpt-commits: 9aacd72c9f396544fc93a1419fa8c9bfe02c015a
wpt-pr: 17612
Automatic update from web-platform-tests
Add manual test for print()
For https://github.com/whatwg/html/pull/4690.
--
wpt-commits: 8e53d2a89fe610b2ce480877c60bca88c949cf60
wpt-pr: 17439
Automatic update from web-platform-tests
[LayoutNG] Fix Google Docs font picker menu.
LayoutNG lacks a mechanism that's present in the legacy engine, that
handles situations where a descendant adds a scrollbar, which affects
the inline-size of an ancestor (fit-content sizing).
This CL only fixes the issue when this happens to an out-of-flow
positioned ancestor, which is enough to fix the Google Docs issue.
Bug: 978979
Change-Id: Ib60bbe244d8ee2cd80f3209b3322a097738841d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685388
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674123}
--
wpt-commits: 4a9bf4d17af6f7527af4558369bcb4b709ee280c
wpt-pr: 17611
Automatic update from web-platform-tests
Don't consider fieldsets as replaced content.
They should be treated as regular block containers, as far as sizing is
concerned. The LayoutNG out-of-flow positioning machinery treated
fieldsets as replaced (since it was told to), and ended up with an
incorrect inline-size.
A "side-effect" of this fix is that now that fieldsets are no longer
treated as replaced content, they can can also fragment inside multicol
containers or paged media - just like any other block-level container.
This is good. There should be no reason to prohibit fragmentainer
breaks inside fieldsets. Added a test for it, to assert the new
behavior.
Bug: 979523
Change-Id: I2fd73f8324d3207c5d12c500b5632f631468ab34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685096
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674096}
--
wpt-commits: 727763fa27f9d8d36c1c337dc2ac52ac092c61f0
wpt-pr: 17602
Automatic update from web-platform-tests
[LargestContentfulPaint] Add attributes and checks
This CL adds checks so that we do not expose rendering timestamp of
images which do not pass the Timing Allow Origin check. It also adds
attributes found in:
https://wicg.github.io/largest-contentful-paint/#sec-performance-largest-contentful-paint-candidate
The ImagePaintTimingDetector did not plumb the ImageResourceContent to
the ImageRecord, so this is fixed to allow LCP Calculator to make use of
it.
Bug: 965505
Change-Id: I019658dc6d130c8cea336f1ca70de6a32beebbb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674588
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674085}
--
wpt-commits: f7dbdc0bb7a3566b1b28e1cb49178ba9d71b1bc6
wpt-pr: 17500
Automatic update from web-platform-tests
Revert "Reland "Fix first line style caching issues""
This reverts commit 3bce815a57b12cd5be22ecd0ba838c417f6179fd.
Reason for revert: crbug.com/980421
Original change's description:
> Reland "Fix first line style caching issues"
>
> This is a reland of 228ee33446fc20cef8fcc94503a91c16bbcfc6fb
>
> Compared to the original CL, this relanded CL removes the lazy update
> of first line image observers which was not needed and didn't work
> (causing reentrancy of UpdateFirstLineImageObservers).
>
> Original change's description:
> > Fix first line style caching issues
> >
> > 1. Cache conflict issue:
> >
> > Previously calls to Element:: Element::CachedStyleForPseudoElement()
> > with different second parameters caused cache conflict. The second
> > call to it might get unwanted result that was cached with a different
> > second parameter.
> >
> > Now remove the second parameter, and the function gets and caches the
> > pseudo style only based on its own computed style. If a caller wants
> > a pseudo style based on another style, the caller should call
> > Element::UncachedStyleForPseudoElement() and manage cache by itself.
> >
> > 2. Under-invalidation on change
> >
> > Cached first line style needs invalidation in two cases:
> > a) when the ::first-line style changes, we should invalidate all
> > cached first line styles affected.
> > b) when style of an inline element (which inherits ::first-line
> > style) changes, as the inline element's style has higher priority
> > than the inherited ::first-line style, even if the style doesn't
> > change, we need to invalidate the cached
> > kPseudoIdFirstLineInherited style if the new style is different
> > from the inherited ::first-line style.
> >
> > Bug: 979054
> >
> > Change-Id: Icffe68d5136349d12cce6e92d1d3bf153c28903a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678878
> > Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#673574}
>
> Bug: 979054
> Change-Id: Ic0c05a4a3d36401f7ae18c41cad81e7613bb3cbc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682283
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Fredrik Söderquist <fs@opera.com>
> Cr-Commit-Position: refs/heads/master@{#673756}
TBR=wangxianzhu@chromium.org,fs@opera.com,futhark@chromium.org
Change-Id: I59fe9947deba7267e69f5b76c9ff6b3c0251b8c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 979054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685415
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674074}
--
wpt-commits: fef95ecd2b3d59504eb4b5405db5c2995ab32710
wpt-pr: 17609
Automatic update from web-platform-tests
[Trusted Types] Support Trusted Types on eval.
Modify V8's eval callback to take both CSP and Trusted Types into
account. This should not modify Blink's behaviour in case TT is not present.
Bug: 940927, 980127
Change-Id: Ic11956cd455d352f2ba9d3fd9e4a00bb12e8d852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591274
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674038}
--
wpt-commits: 4ed0465b108be61f184a896b7cb9e2c9356fd1d9
wpt-pr: 17525
Automatic update from web-platform-tests
[LayoutNG] Keep trucated fragments for `text-overflow: ellipsis`
This patch keeps truncated fragments for `text-overflow:
ellipsis` as "hidden for paint", but still uses them for
when querying layout information such as `offsetWidth` or
editing.
Bug: 947593, 978392
Change-Id: Ic9d6888728339dc3ea37672b1ba004cddd295216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678915
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673777}
--
wpt-commits: 424e3bce2245105a515ba8f5d97e6852bb69e973
wpt-pr: 17588
Automatic update from web-platform-tests
Reland "Fix first line style caching issues"
This is a reland of 228ee33446fc20cef8fcc94503a91c16bbcfc6fb
Compared to the original CL, this relanded CL removes the lazy update
of first line image observers which was not needed and didn't work
(causing reentrancy of UpdateFirstLineImageObservers).
Original change's description:
> Fix first line style caching issues
>
> 1. Cache conflict issue:
>
> Previously calls to Element:: Element::CachedStyleForPseudoElement()
> with different second parameters caused cache conflict. The second
> call to it might get unwanted result that was cached with a different
> second parameter.
>
> Now remove the second parameter, and the function gets and caches the
> pseudo style only based on its own computed style. If a caller wants
> a pseudo style based on another style, the caller should call
> Element::UncachedStyleForPseudoElement() and manage cache by itself.
>
> 2. Under-invalidation on change
>
> Cached first line style needs invalidation in two cases:
> a) when the ::first-line style changes, we should invalidate all
> cached first line styles affected.
> b) when style of an inline element (which inherits ::first-line
> style) changes, as the inline element's style has higher priority
> than the inherited ::first-line style, even if the style doesn't
> change, we need to invalidate the cached
> kPseudoIdFirstLineInherited style if the new style is different
> from the inherited ::first-line style.
>
> Bug: 979054
>
> Change-Id: Icffe68d5136349d12cce6e92d1d3bf153c28903a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678878
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#673574}
Bug: 979054
Change-Id: Ic0c05a4a3d36401f7ae18c41cad81e7613bb3cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682283
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#673756}
--
wpt-commits: f05fad8e3fee427059ab8040badee942c2ac8555
wpt-pr: 17582
Automatic update from web-platform-tests
[LayoutNG] Resolve auto inline margins on root.
The root HTML element is in a unique situation in LayoutNG, in that its
parent is a regular block container that is laid out by the legacy
engine. In legacy, block container layout expects the children to set
their own margin. Make sure that we do this.
Bug: 978702
Change-Id: I84b8e36bd706e3c01096cd9bd75a0747ddf265ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683973
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673733}
--
wpt-commits: 16680001ee64a84651c44311a605cc7b2bcc18bf
wpt-pr: 17587
Automatic update from web-platform-tests
CSS math-script-level and math-style: Update meta help links. (#17604)
--
wpt-commits: eda082d3fb516a0bf522cbc4198999a605d7a438
wpt-pr: 17604
Automatic update from web-platform-tests
- Update help meta tags. (#17601)
- Minor markup and documentation tweaks.
--
wpt-commits: ec636b58e82b466c201fb89ea7265092e9f05284
wpt-pr: 17601
Automatic update from web-platform-tests
[css-text] Correct inconsistencies between text and assertion in line-break:anywhere tests (#17597)
--
wpt-commits: 708c7910e71c408d2ff7a1093a2b82bd3415449e
wpt-pr: 17597
Automatic update from web-platform-tests
[cssom] Add tests for CSSGroupingRule
These tests are somewhat contentious due an inconsistency in the CSS
specification:
https://github.com/w3c/csswg-drafts/issues/3528
--
wpt-commits: 814db842c492f8c480749b671e6bc31c83c68645
wpt-pr: 17276
Automatic update from web-platform-tests
[docs] Relocate instruction for reviewers
This information is not relevant for first-time contributors. Including
it in the same document as the instructions for new contributors risks
confusing or intimidating the less experienced audience.
Relocate the instructions to a dedicated document that can be discovered
by those who specifically wish to learn about reviewing submissions.
--
wpt-commits: 53bf566b00aa0efd9b80496d5d488a338b16ec1c
wpt-pr: 17371
Automatic update from web-platform-tests
Revert "Fix first line style caching issues"
This reverts commit 228ee33446fc20cef8fcc94503a91c16bbcfc6fb.
Reason for revert: Clusterfuzz found several bugs caused by the CL.
Original change's description:
> Fix first line style caching issues
>
> 1. Cache conflict issue:
>
> Previously calls to Element:: Element::CachedStyleForPseudoElement()
> with different second parameters caused cache conflict. The second
> call to it might get unwanted result that was cached with a different
> second parameter.
>
> Now remove the second parameter, and the function gets and caches the
> pseudo style only based on its own computed style. If a caller wants
> a pseudo style based on another style, the caller should call
> Element::UncachedStyleForPseudoElement() and manage cache by itself.
>
> 2. Under-invalidation on change
>
> Cached first line style needs invalidation in two cases:
> a) when the ::first-line style changes, we should invalidate all
> cached first line styles affected.
> b) when style of an inline element (which inherits ::first-line
> style) changes, as the inline element's style has higher priority
> than the inherited ::first-line style, even if the style doesn't
> change, we need to invalidate the cached
> kPseudoIdFirstLineInherited style if the new style is different
> from the inherited ::first-line style.
>
> Bug: 979054
>
> Change-Id: Icffe68d5136349d12cce6e92d1d3bf153c28903a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678878
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#673574}
TBR=wangxianzhu@chromium.org,fs@opera.com,futhark@chromium.org
Change-Id: Ief1eb5749624f877e04d7bff19f42c6f94844b70
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 979054, 979961, 979942, 979940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682282
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673594}
--
wpt-commits: ff6212c69e2519a94fd62d6f1e06dd0dac6152d3
wpt-pr: 17581
Automatic update from web-platform-tests
Fix first line style caching issues
1. Cache conflict issue:
Previously calls to Element:: Element::CachedStyleForPseudoElement()
with different second parameters caused cache conflict. The second
call to it might get unwanted result that was cached with a different
second parameter.
Now remove the second parameter, and the function gets and caches the
pseudo style only based on its own computed style. If a caller wants
a pseudo style based on another style, the caller should call
Element::UncachedStyleForPseudoElement() and manage cache by itself.
2. Under-invalidation on change
Cached first line style needs invalidation in two cases:
a) when the ::first-line style changes, we should invalidate all
cached first line styles affected.
b) when style of an inline element (which inherits ::first-line
style) changes, as the inline element's style has higher priority
than the inherited ::first-line style, even if the style doesn't
change, we need to invalidate the cached
kPseudoIdFirstLineInherited style if the new style is different
from the inherited ::first-line style.
Bug: 979054
Change-Id: Icffe68d5136349d12cce6e92d1d3bf153c28903a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678878
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673574}
--
wpt-commits: c0a3e93389bdcc9e8ad12d3988e4568d48b78c9d
wpt-pr: 17561
Automatic update from web-platform-tests
test correct exception when attempting to draw a closed ImageBitmap to a canvas. (#17211)
* add test for drawImage of closed canvas
* make consistent with existing imageBitmap tests
--
wpt-commits: f0ed5874274b40b1fbe14f8ab6a072ef3df12a6e
wpt-pr: 17211
Automatic update from web-platform-tests
Ship `referer` header length limitation. (#17204)
This patch adds web platform tests to verify the behavior of the
referrer header and `document.referrer` after flipping the length
limitiation flag to on-by-default.
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/lckJ5OAkUNo/ooVNdvhLAgAJ
Bug: 959757
Change-Id: I385f8f12f20109c50ededb9018a08cd665cb6868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646784
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667039}
--
wpt-commits: 9e059910c901218756454b7979c6f95a6f306854
wpt-pr: 17204
Automatic update from web-platform-tests
HTML: applet no longer exists
For HTML purposes that's "worse" than obsolete.
In the same directory there's historical.html to ensure it won't be added again.
Fixes#17559.
--
wpt-commits: c30f7af7ebc3269ba6790122272692c12c920f02
wpt-pr: 17570
Automatic update from web-platform-tests
Fix crash when setting invalid @font-face descriptors via CSSOM.
When @font-face rules are parsed normally (as part of a stylesheet),
the descriptors are parsed with CSSParserToken::ParseAsAtRuleDescriptorID,
which is allowed to return kInvalid.
However, when using CSSOM, the parsing takes a different path that first
creates a CSSPropertyID, then converts it to a AtRuleDescriptorID using
CSSPropertyIDAsAtRuleDescriptor, which *isn't* allowed to return kInvalid.
Fix by allowing kInvalid, and gracefully handling this in
CSSPropertyParser::ParseFontFaceDescriptor.
Note that this is the only callsite for CSSPropertyIDAsAtRuleDescriptor.
BUG=977953
Change-Id: I42081dd4bae3c828843be3ca994ff4f48d06a7f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676629
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673262}
--
wpt-commits: 3487a399f3a1603d97388a5452530a89c10e47e1
wpt-pr: 17543
Automatic update from web-platform-tests
Cleanup types in vr_service.mojom
This changes various vectors in the vr_service mojom to use the correct
gfx.mojom.geometry type. It's largely mechanical, but the change from
array<float, 16> to gfx::Transform did introduce the need to transpose
the transforms being passed across that boundary.
For WMR, this resulted in a consistent way to convert from Matrix4x4 to
gfx::Transform, so some manual usages were consolidated to use a helper
function.
Bug: 732403
Change-Id: I1eefaa90c7b7d5ea6fa03c01522422bd37f7290a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669891
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673193}
--
wpt-commits: c48a7037e8059f9a331d311ba711de2da4abf625
wpt-pr: 17477
Automatic update from web-platform-tests
Added a link to spec in 6 CSS2/values tests (#17514)
--
wpt-commits: a3f623801e5fef0bb8a806fbc8119c32d57240d1
wpt-pr: 17514
Automatic update from web-platform-tests
Added a link to spec in 13 CSS2/values tests (#17513)
--
wpt-commits: 4c26654f77551d686bbc255cee95089b12aa6907
wpt-pr: 17513
Automatic update from web-platform-tests
Added a link to spec to numbers-units-00[5-6] tests (#17512)
--
wpt-commits: 95a1d50e544d1894110449e207f8e8cc92324dc8
wpt-pr: 17512
Automatic update from web-platform-tests
Added a link to spec to numbers-units-00[2-3] tests (#17510)
--
wpt-commits: 78f9cce31d3a905598773b0486f9567e8a4e6193
wpt-pr: 17510
Automatic update from web-platform-tests
Added a link to spec to numbers-units-004 test (#17508)
--
wpt-commits: 288514517e5012ad4459c63e8b37e6dcff3fd561
wpt-pr: 17508
Automatic update from web-platform-tests
Added another link to spec to anumbers-units-001 test (#17507)
--
wpt-commits: 73f28194f388630a856827e63e286883e6c42a12
wpt-pr: 17507
Automatic update from web-platform-tests
[LayoutNG] Fix for incorrect Legacy containing block oof removal
When containing block changes from being an OOF container
to not being one, it needs to remove the positioned descendants
from its list of positioned objects.
If an OOF object remains in the positioned objects list,
it will cause NGOutOfLayoutPart::SweepLegacyDescendants
to go into an infinite loop and run out of memory. This
was fixed to just trigger a DCHECK in a recent CL.
LayoutInline::StyleDidChange did not perform OOF descendant
removal correctly. LayoutInline OOF descendants are stored in
first non-anonymous block on parent chain, (container's container)
which is not the same as ContainingBlock().
Added a method that computes container's container to
LayoutObject, and made LayoutInline call it.
This fix also works for fixed, because
fixed containers are always absolute containers.
Bug: 977930
Change-Id: I9f88fe676ec67d9d6751f3502507d773ed978dc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680123
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673156}
--
wpt-commits: a8405825541d608fd26f28b0af36e6b5c42fd70a
wpt-pr: 17542
Koji Ishii
Timothy Gu
moz-wptsync-bot
Morten Stenshorne
Nicolás Peña Moreno
Xianzhu Wang
Daniel Vogelheim
Suman Nelson Kancherla
Alice Boxhall
Frédéric Wang
autofoolip
Florian Rivoal
Oliver Dunk
Mike Pennisi
Alexey Shvayka
aardgoose
L. David Baron
Blink WPT Bot
Anne van Kesteren
Anders Hartvoll Ruud
Alex Cooper
Gérard Talbot
Aleks Totic