Граф коммитов

12378 Коммитов

Автор SHA1 Сообщение Дата
Julien Wajsberg f74fc26e96 Bug 1494337 - Move the 'tool not supported' label to the right place r=ochameau
Depends on D6922

Differential Revision: https://phabricator.services.mozilla.com/D6923

--HG--
extra : moz-landing-system : lando
2018-09-27 14:33:39 +00:00
Julien Wajsberg b29f25d7b3 Bug 1494337 - Insert the settings for nightly before the 'reloads the page' indication r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D6922

--HG--
extra : moz-landing-system : lando
2018-09-27 14:33:38 +00:00
StefanYohansson 41d490dca9 Bug 1172314 - Print arguments passed into console.trace. r=bgrins.
Added trace extra parameters to be printed alongside console.trace() output.

Differential Revision: https://phabricator.services.mozilla.com/D7051

--HG--
extra : moz-landing-system : lando
2018-09-27 13:27:57 +00:00
Nicolas Chevobbe 89eca29ba9 Bug 1492827 - Remove unused listeners and handlers from webconsole-connection-proxy; r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D7073

--HG--
extra : moz-landing-system : lando
2018-09-27 11:46:26 +00:00
yulia 72f9e83eb1 Bug 1473513 - move ActorRegistry module to server/actors/utils; r=ochameau
Summary: Depends on D6477

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6479

--HG--
rename : devtools/server/actor-registry.js => devtools/server/actors/utils/actor-registry.js
extra : rebase_source : ae52db7b028b4d866d8a363eae9ae7c124714458
2018-09-26 10:09:15 +02:00
yulia 29af71d6af Bug 1473513 - resolve memory leak
Summary: Depends on D6476

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6477

--HG--
extra : rebase_source : 61ccae905e3136ad3c293db692551786e83075c7
2018-09-26 10:08:43 +02:00
yulia c6dbe43c8e Bug 1473513 - reduce number of poolFor calls; r=ochameau
Summary:
MozReview-Commit-ID: 9VqKPauAP9j

Depends on D6475

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6476

--HG--
extra : rebase_source : 1bebc34bf805dfcf7bce0b5d8f3a2a13bab11173
2018-09-26 10:08:10 +02:00
yulia dd29e366ea Bug 1473513 - refactor main.js to use protocol.js pools; r=ochameau
Summary:
MozReview-Commit-ID: FNMK4f553yI

Depends on D6474

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6475

--HG--
extra : rebase_source : c61d394da0a20991def49968f01ee563fea9afde
2018-09-26 10:07:27 +02:00
yulia 9c120b705d Bug 1473513 - separate registerModule behavior from DebuggerServer; r=ochameau
Summary:
MozReview-Commit-ID: 3GsXRxcIKfx

Depends on D6473

Reviewers: ochameau

Reviewed By: ochameau

Subscribers: reviewbot

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6474

--HG--
rename : devtools/server/main.js => devtools/server/actor-registry.js
extra : rebase_source : 3ea4edd91ca8b09ad5e25ae01df885c587bee7b1
2018-09-26 10:06:43 +02:00
yulia 0c9522358e Bug 1473513 - Ensure that actorPools in root are destroyed on destroy; r=ochameau
Summary: Depends on D6472

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6473

--HG--
extra : rebase_source : 075dd9b2128adf04f0bbf6fc7f0708ca532a49aa
2018-09-26 10:06:00 +02:00
yulia e1c0e43fff Bug 1473513 - remove other instances of ActorPool from browsingContext and root; r=ochameau
Summary:
MozReview-Commit-ID: GxkLzvxJgdY

Depends on D6471

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6472

--HG--
extra : rebase_source : 8877be9e01d379375a167c58c61d94efd4997e19
2018-09-26 10:05:31 +02:00
yulia 99bb10079e Bug 1473513 - make log function safer so that tests do not time out; r=ochameau
Summary:
MozReview-Commit-ID: BIk5pWzxJcx

Depends on D6470

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6471

--HG--
extra : rebase_source : 0284679e1a6d33ed915ebf69cf56557847bceb66
2018-09-26 10:04:57 +02:00
yulia 4a8f74eb3e Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
Summary:
create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor;

Depends on D6468

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6470

--HG--
rename : devtools/server/actors/common.js => devtools/shared/protocol/lazy-pool.js
extra : rebase_source : 09a1c8eac3cbb5856a5e3e61a1c0540efe32e5bd
2018-09-26 10:03:33 +02:00
yulia 7caf289dbe Bug 1473513 - use Protocol.js pools for workerTargetActorPool in Target Actors; r=ochameau
Summary: MozReview-Commit-ID: 5uIWwOR7CHp

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6468

--HG--
extra : rebase_source : b5f560e404727a168c5b35924961a49c51b849df
2018-09-26 10:02:54 +02:00
Michael Ratcliffe 4e3c6d2b5f Bug 1491879 - Fix telemetry support for multiple tabs / windows r=nchevobbe
- Various telemetry methods now need an object to be passed in in order to keep them seperate e.g. if the inspector is opened in tab 1 a timer is started. If an inspector is opened in tab 2 the same timer is restarted. Closing tab 2 would then erase the timing event invalidating the timer in tab 1.
- We no longer need to preface telemetry calls with category "devtools.main" because this is the only category we will be using.
- There are some changes to `devtools/client/debugger/new/dist/vendors.js` and `devtools/client/debugger/new/src/utils/telemetry.js` that need to be ported to the debugger at the same time as landing this.

Differential Revision: https://phabricator.services.mozilla.com/D6137

--HG--
extra : moz-landing-system : lando
2018-09-25 12:57:13 +00:00
Alexandre Poirot 0df7ab9a73 Bug 1494317 - Remove "newScript" event leftovers r=yulia
MozReview-Commit-ID: 3lc5XXdBWgS

Depends on D6941

Differential Revision: https://phabricator.services.mozilla.com/D6942

--HG--
extra : moz-landing-system : lando
2018-09-26 18:11:55 +00:00
Alexandre Poirot 06ff174025 Bug 1494319 - Remove unused "newGlobal" event r=yulia
MozReview-Commit-ID: 4bQyjXYuN18

Depends on D6940

Differential Revision: https://phabricator.services.mozilla.com/D6941

--HG--
extra : moz-landing-system : lando
2018-09-26 18:09:54 +00:00
Alexandre Poirot 340ed44d31 Bug 1494322 - Remove unused UnsolicitedNotifications r=yulia
MozReview-Commit-ID: Fc2upXImxP2

Differential Revision: https://phabricator.services.mozilla.com/D6940

--HG--
extra : moz-landing-system : lando
2018-09-27 08:50:13 +00:00
Alexandre Poirot c4e18d3974 Bug 1494305 - Refactor all tabClient usages to use promise API instead of callback style r=yulia
MozReview-Commit-ID: DZVG1X45sQV

Differential Revision: https://phabricator.services.mozilla.com/D6908

--HG--
extra : moz-landing-system : lando
2018-09-26 18:02:45 +00:00
Alexandre Poirot 3ad83b9241 Bug 1492856 - Remove compatiblity code to guard against miss of RootActor.getRoot r=jdescottes
MozReview-Commit-ID: L5kkG9r7Rtv

Differential Revision: https://phabricator.services.mozilla.com/D6755

--HG--
extra : moz-landing-system : lando
2018-09-26 21:12:16 +00:00
Alexandre Poirot 4c1bb0403e Bug 1397020 - Remove useless calls to TabTarget.attach r=yulia
TabTarget.attach is being called from the toolbox, before opening the tools,
so we do not have to call it from panel's open functions, nor code that is opening
a toolbox right after.

MozReview-Commit-ID: 77TZFbvOaFt

Differential Revision: https://phabricator.services.mozilla.com/D6668

--HG--
extra : moz-landing-system : lando
2018-09-26 21:11:51 +00:00
Mantaroh Yoshinaga 495837c33c Bug 1472942 - Part 2. Add setContentSize() instead of setContent() in HTMLTooltip. r=birtles
This patch will remove setContest(), and change the following things instead of this:

 * Use HTMLTooltip.panel.appendChild() instead of HTMLTooltip.setContent().
 * Add HTMLTooltip.setContetnSize() to specify the panel size if need this.

Differential Revision: https://phabricator.services.mozilla.com/D7044

--HG--
extra : moz-landing-system : lando
2018-09-27 07:14:55 +00:00
Mantaroh Yoshinaga adb9bb2f7a Bug 1472942 - Part 1. Remove unused paramter of HTMLTooltip.show from SwatchBaseEditorTooltip. r=jdescottes
SwatchBaseEditorTooltip specify the "topcentor bototmleft" to second parameter
of HTMLTooltip.show(). However, this parameter will ignore since show() function
require the second parameter as the object, not the string.

Bug 1307481 comment 42 has pointed out this parameter.

Differential Revision: https://phabricator.services.mozilla.com/D7043

--HG--
extra : moz-landing-system : lando
2018-09-27 07:15:18 +00:00
Julian Descottes d03effab3f Bug 1493968 - Wait for initial targets in aboutdebugging navigate test to avoid race condition;r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D6975

--HG--
extra : moz-landing-system : lando
2018-09-27 05:48:45 +00:00
Daisuke Akatsuka a5baf7ae30 Bug 1493883: Add 'name' field to network runtime for consistency. r=jdescottes
Depends on D6878

Differential Revision: https://phabricator.services.mozilla.com/D6885

--HG--
extra : moz-landing-system : lando
2018-09-27 04:46:38 +00:00
Daisuke Akatsuka e2089c90e6 Bug 1493883: Extract USB runtime data needed. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D6878

--HG--
extra : moz-landing-system : lando
2018-09-26 11:55:17 +00:00
Xidorn Quan cb87cec282 Bug 1494501 - Rename pref "layout.css.scrollbar-colors.enabled" to "layout.css.scrollbar-color.enabled". r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D7030

--HG--
extra : moz-landing-system : lando
2018-09-27 00:38:16 +00:00
shindli a8d55dae12 Merge inbound to mozilla-central. a=merge 2018-09-27 00:52:12 +03:00
Logan F Smyth c14f7c8aff Bug 1473996 - Expose fn.apply in the devtools server. r=nchevobbe
Depends on D6722

Differential Revision: https://phabricator.services.mozilla.com/D6723

--HG--
extra : moz-landing-system : lando
2018-09-26 16:23:25 +00:00
Logan F Smyth 11febfa688 Bug 1473996 - Expose getPropertyValue in devtools server to fully evaluate an object property. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D6722

--HG--
extra : moz-landing-system : lando
2018-09-26 16:12:56 +00:00
Julian Descottes 778d5e8d33 Bug 1489220 - Add mochitest for empty message in debug target pane;r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D6495

--HG--
extra : moz-landing-system : lando
2018-09-26 08:58:15 +00:00
Nicolas Chevobbe 14ff2e3235 Bug 1476656 - Trigger autocomplete on bracket; r=Honza.
This patch adds the ability to open the autocomplete popup when
typing an opening bracket (i.e. `[`]) in the console input.
This impacts a significant amount of function where we assumed
that the only way to get a completion was to use a dot.
We uses the rename `anylyzeInputString` function to get the
completion part from an input, as well as if the user is performing
an element access (i.e., using the bracket).
We then send that information to the webconsole actor, which send
it to the client.
This allows us to rely on a single parse of the input and gives us
access to this information everywhere we need to, be it on the client
or on the server.

We allow the user to type property name without quotes, and we add
them when the user accept an autocompletion.
We also automatically add a closing bracket (i.e. `]`), when it's needed.

Some test are added. On the server side to make sure the actor's autocomplete
function returns what's expected.
We take that as an opportunity to add test for commands.
On the client side, tests are added to ensure the different behavior works
as expected (check the completion text and the input  after accepting
the completion when the user entered some letters, or not, with or without
quotes, with different quotes, hitting the autocomplete cache, …).

A test which accesses the autocomplete cache was modified since the shape
of the cache changed to include the last matchProp as well as the
isElementAccess boolean.

Differential Revision: https://phabricator.services.mozilla.com/D6128

--HG--
extra : moz-landing-system : lando
2018-09-26 13:54:35 +00:00
arthur.iakab e1e94e3d20 Merge mozilla-central to autoland 2018-09-26 15:57:12 +03:00
arthur.iakab ec46826255 Merge inbound to mozilla-central. a=merge 2018-09-26 15:54:41 +03:00
sreeise 847b33d284 Bug 1423201 - Changed uses of defer to new Promise in devtools/server/tests/mochitest r=nchevobbe
Functions using 'defer' for promises are being switched to the 'new Promise' syntax. This is for changes in devtools/server/tests/mochitest.

Differential Revision: https://phabricator.services.mozilla.com/D6618

--HG--
extra : moz-landing-system : lando
2018-09-26 02:44:56 +00:00
Xidorn Quan c46ef183e2 Bug 1492012 - Enable scrollbar-color and scrollbar-width by default. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D6872

--HG--
extra : moz-landing-system : lando
2018-09-26 03:30:32 +00:00
Ciure Andrei ce57be88b8 Merge inbound to mozilla-central. a=merge 2018-09-26 00:49:06 +03:00
Amy Chan 5c903b5d23 Bug 1479421 - Making the response panel visible; r=Honza
Making the response panel visible

Differential Revision: https://phabricator.services.mozilla.com/D4636

--HG--
extra : moz-landing-system : lando
2018-09-26 07:14:33 +00:00
Noemi Erli 86a5ba6453 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-10-09 00:57:11 +03:00
Jason Laster 716f4ecb2b Bug 923975 - Teach step out to leave the current frame. r=jlast 2018-10-03 09:50:44 -04:00
Alexandre Poirot 816dd96825 Bug 1490927 - Stop sharing maps in NetworkMonitor between all instances. r=Honza
When opening a web console and a browser console, we instantiate two NetworkMonitor
instances in the same process and they need independant states.

Differential Revision: https://phabricator.services.mozilla.com/D6054

--HG--
extra : moz-landing-system : lando
2018-09-19 23:26:05 +00:00
Julian Descottes 17903b38b8 Bug 1492863 - Fix react warnings in aboutdebugging-new;r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D6400

--HG--
extra : moz-landing-system : lando
2018-09-25 11:04:58 +00:00
Alexandre Poirot e008acf411 Bug 1473513 - Backed out changeset 0e431edddacd for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: 1BlQk4H0c1w

Depends on D6812

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6813
2018-09-25 19:35:14 +03:00
Alexandre Poirot 18a737b18d Bug 1473513 - Backed out changeset 27419719402e for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: 43tUMmC1Je0

Depends on D6811

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6812
2018-09-25 19:35:00 +03:00
Alexandre Poirot 3695cdf575 Bug 1473513 - Backed out changeset 6fc241b06e0b for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: 6dCPXvBYhsJ

Depends on D6810

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6811
2018-09-25 19:34:52 +03:00
Alexandre Poirot 67f96eff34 Bug 1473513 - Backed out changeset e56c70bd2f9a for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: 9FIL35Nq726

Depends on D6809

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6810
2018-09-25 19:34:43 +03:00
Alexandre Poirot bb3ecc7ca4 Bug 1473513 - Backed out changeset c690d2383ca4 for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: KSgxXnGdsJk

Depends on D6808

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6809
2018-09-25 19:34:35 +03:00
Alexandre Poirot 1255c658b2 Bug 1473513 - Backed out changeset d72f6ff37ca6 for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: LKPmFrhaQ5q

Depends on D6807

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6808
2018-09-25 19:34:26 +03:00
Alexandre Poirot 40272ff560 Bug 1473513 - Backed out changeset f9f12b44a3ab for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: 8POm9seFrAk

Depends on D6806

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6807
2018-09-25 19:34:18 +03:00
Alexandre Poirot 58167747ab Bug 1473513 - Backed out changeset db43912632fb for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: DbUwQ0NQZcE

Depends on D6805

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6806
2018-09-25 19:34:09 +03:00
Alexandre Poirot e73ec8adf4 Bug 1473513 - Backed out changeset 80c51a6e896e for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: 3TCiKetO6fn

Depends on D6804

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6805
2018-09-25 19:34:01 +03:00
Alexandre Poirot a3c7499a55 Bug 1473513 - Backed out changeset 174fe98999ea for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary:
MozReview-Commit-ID: GfSX2wYfLrN

Depends on D6803

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6804

--HG--
rename : devtools/server/actors/utils/actor-registry.js => devtools/server/actor-registry.js
2018-09-25 19:33:52 +03:00
Alexandre Poirot 8dac98409f Bug 1473513 - Backed out changeset 950ce58bfb24 for failures on mobile/android/tests/browser/chrome/test_debugger_server.html CLOSED TREE
Summary: MozReview-Commit-ID: 1HAisV9S6ls

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6803
2018-09-25 19:33:43 +03:00
Alexandre Poirot 62fca91459 Bug 1473513 - Fix merge conflict between bug 1473513 and 1485676 against this test. CLOSED TREE
Summary: MozReview-Commit-ID: KyizI0V5pt5

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6778
2018-09-25 17:24:00 +03:00
Alexandre Poirot e490a53de2 Bug 1492826 - Better document TabTarget.attach as well as DebuggerClient.attachTarget and attachConsole. r=jdescottes
Depends On D6162

Differential Revision: https://phabricator.services.mozilla.com/D6388

--HG--
extra : moz-landing-system : lando
2018-09-24 16:24:07 +00:00
Margareta Eliza Balazs 5ad86cabda Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-25 12:50:02 +03:00
Margareta Eliza Balazs ffe6eaf2f0 Merge inbound to mozilla-central. a=merge 2018-09-25 12:42:09 +03:00
yulia 04d870f203 Bug 1473513 - move ActorRegistry module to server/actors/utils; r=ochameau
Depends on D6477

Differential Revision: https://phabricator.services.mozilla.com/D6479

--HG--
rename : devtools/server/actor-registry.js => devtools/server/actors/utils/actor-registry.js
extra : moz-landing-system : lando
2018-09-25 08:47:10 +00:00
yulia 19b4e8fbe6 Bug 1473513 - resolve memory leak r=ochameau
Depends on D6476

Differential Revision: https://phabricator.services.mozilla.com/D6477

--HG--
extra : moz-landing-system : lando
2018-09-25 08:06:25 +00:00
yulia a0882d24f7 Bug 1473513 - reduce number of poolFor calls; r=ochameau
MozReview-Commit-ID: 9VqKPauAP9j

Depends on D6475

Differential Revision: https://phabricator.services.mozilla.com/D6476

--HG--
extra : moz-landing-system : lando
2018-09-25 08:06:17 +00:00
yulia 1ad50b5afe Bug 1473513 - refactor main.js to use protocol.js pools; r=ochameau
MozReview-Commit-ID: FNMK4f553yI

Depends on D6474

Differential Revision: https://phabricator.services.mozilla.com/D6475

--HG--
extra : moz-landing-system : lando
2018-09-25 08:05:47 +00:00
yulia e857119004 Bug 1473513 - separate registerModule behavior from DebuggerServer; r=ochameau
MozReview-Commit-ID: 3GsXRxcIKfx

Depends on D6473

Differential Revision: https://phabricator.services.mozilla.com/D6474

--HG--
rename : devtools/server/main.js => devtools/server/actor-registry.js
extra : moz-landing-system : lando
2018-09-25 08:05:29 +00:00
yulia 08c887b837 Bug 1473513 - Ensure that actorPools in root are destroyed on destroy; r=ochameau
Depends on D6472

Differential Revision: https://phabricator.services.mozilla.com/D6473

--HG--
extra : moz-landing-system : lando
2018-09-25 08:04:59 +00:00
yulia 54d3f62aa0 Bug 1473513 - remove other instances of ActorPool from browsingContext and root; r=ochameau
MozReview-Commit-ID: GxkLzvxJgdY

Depends on D6471

Differential Revision: https://phabricator.services.mozilla.com/D6472

--HG--
extra : moz-landing-system : lando
2018-09-25 08:04:41 +00:00
yulia de5a5707d6 Bug 1473513 - make log function safer so that tests do not time out; r=ochameau
MozReview-Commit-ID: BIk5pWzxJcx

Depends on D6470

Differential Revision: https://phabricator.services.mozilla.com/D6471

--HG--
extra : moz-landing-system : lando
2018-09-25 08:04:22 +00:00
yulia 1cea42cdd7 Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor;

Depends on D6468

Differential Revision: https://phabricator.services.mozilla.com/D6470

--HG--
rename : devtools/server/actors/common.js => devtools/shared/protocol/lazy-pool.js
extra : moz-landing-system : lando
2018-09-25 08:03:42 +00:00
yulia 56e91adaa1 Bug 1473513 - use Protocol.js pools for workerTargetActorPool in Target Actors; r=ochameau
MozReview-Commit-ID: 5uIWwOR7CHp

Differential Revision: https://phabricator.services.mozilla.com/D6468

--HG--
extra : moz-landing-system : lando
2018-09-25 08:02:11 +00:00
Gabriel Luong 697b700c0f Bug 1317102 - Part 3: Disable grid highlighter toggles in the markup when the max highlighter is reached. r=jdescottes
--HG--
rename : devtools/client/inspector/markup/test/browser_markup_grid_display_badge.js => devtools/client/inspector/markup/test/browser_markup_grid_display_badge_01.js
2018-09-24 20:38:11 -04:00
Julian Descottes 26887111d9 Bug 1489434 - Add i18n for DeviceSidebarItemAction component;r=birtles
Depends on D6614

Differential Revision: https://phabricator.services.mozilla.com/D6615

--HG--
extra : moz-landing-system : lando
2018-09-25 06:38:52 +00:00
Julian Descottes b246d48d96 Bug 1489434 - Add i18n for ConnectPage component;r=birtles
Depends on D6613

Differential Revision: https://phabricator.services.mozilla.com/D6614

--HG--
extra : moz-landing-system : lando
2018-09-25 06:38:13 +00:00
Julian Descottes 641123a0a4 Bug 1489434 - Add i18n for NetworkLocationsForm component;r=birtles
Depends on D6612

Differential Revision: https://phabricator.services.mozilla.com/D6613

--HG--
extra : moz-landing-system : lando
2018-09-25 06:37:19 +00:00
Julian Descottes e22e59e285 Bug 1489434 - Add i18n for NetworkLocationsList component;r=birtles
Depends on D6611

Differential Revision: https://phabricator.services.mozilla.com/D6612

--HG--
extra : moz-landing-system : lando
2018-09-25 06:35:23 +00:00
Julian Descottes 8b8f412ae2 Bug 1489427 - Add i18n for WorkerDetail component;r=birtles
Depends on D6610

Differential Revision: https://phabricator.services.mozilla.com/D6611

--HG--
extra : moz-landing-system : lando
2018-09-25 06:09:09 +00:00
Gurzau Raul 79c1eec12d Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-09-25 01:10:22 +03:00
Alexandre Poirot 4be011069c Bug 1485676 - Fix missing await on TargetFactory.forTab in console tests after rebase. (hotfix) r=me
MozReview-Commit-ID: 9S2SGGFE9xw
2018-09-24 11:31:37 -07:00
Gabriel Luong 08a1d10fb1 Bug 1317102 - Part 2: Refactor the highlighter event handlers into ElementEditor and prevent flickering of the display badge when toggled from a click. r=jdescottes
- Refactor the highlighter shown/hidden event handlers from MarkupElementContainer in ElementEditor.
We do this because we want to be a bit more lazy when we set these on/off highlighters to only when
there is only a display badge and appropriate display type.
- This fixes a flickering bug cause by the event handlers when you click on the display badges in the markup view.
STR:
1. Have 2 grids shown on the markup view.
2. Toggle on one of them
3. Toggle the other one.
4. See that the active state toggles on, off and on.
We want to toggle the active state manually instead of waiting for the highlighter event handler
to toggle its active state when we click on the display badge. This is because waiting for
the highlight event handler to toggle the active state will cause a brief delay from showing
the active state when the user clicked on the display badge. To fix this, we added a way
to start/stop the highlighter event handlers.
2018-09-24 13:45:13 -04:00
Gabriel Luong 3a26040bed Bug 1248619 - Part 1: Refactor and restore the reload condition settings in RDM. r=rcaliman 2018-09-24 13:04:03 -04:00
Alexandre Poirot c7a9923fc3 Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
Summary:
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6162

MozReview-Commit-ID: Exz5fWyWyfN
2018-09-24 09:52:59 -07:00
Alexandre Poirot fc8714580a Bug 1485676 - Rename TabTarget.makeRemote to TabTarget.attach. r=jdescottes
Summary:
Now that all the "remoting" of this method has been moved to TargetFactory.createTargetForTab,
we should rename this method to what it does now. It mostly call attach requests
of the target actor and its child console actor.
It also "connect" the webextension target actor, but I would like to eventually move that
outside of TabTarget.attach, like makeRemote.

Depends On D4078

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6161

MozReview-Commit-ID: KmFi1LIUBga
2018-09-24 09:52:57 -07:00
Alexandre Poirot 082e20e693 Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4078

MozReview-Commit-ID: JAwiySsBZBu
2018-09-24 09:52:55 -07:00
Alexandre Poirot d31ef570b8 Bug 1485676 - Adapt gDevTools API to new async forTab and also adapt its callsites. r=yulia
Summary:
When switching to async, it is important to catch exception or register a rejection handler
so that errors keep being logged.
So in this patch I'm catching exception in a couple of important codepath.

Depends On D4541

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4542

MozReview-Commit-ID: IDPJVkAPbTs
2018-09-24 09:52:54 -07:00
Alexandre Poirot 1322b8f8a4 Bug 1485676 - Prevent exceptions in the emulation actor when trying to use it while it is already destroyed. r=yulia
Summary: Depends On D4540

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4541

MozReview-Commit-ID: 2fTZ4WRq9je
2018-09-24 09:52:52 -07:00
Alexandre Poirot 5af3a78471 Bug 1485676 - Tweak RDM manage to support new async forTab. r=yulia
Summary:
Fetching any target is now asynchronous. But RDM setup/destroy codepath is very fragile
and introduce many low level exception when trying to restore the original browser element
if any timing changes.
So this patch prevents trying to fetch the target object if a toolbox isn't already opened.
The target object is being used only for Telemetry purpose for now.

Depends On D4538

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4540

MozReview-Commit-ID: 2QDUNqentMP
2018-09-24 09:52:51 -07:00
Alexandre Poirot f421baa62a Bug 1485676 - Adapt gDevTools.createTargetForTab to new TabTarget class. r=yulia
Summary: Depends On D4536

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4537

MozReview-Commit-ID: E3AIMyFgL5m
2018-09-24 09:52:50 -07:00
Alexandre Poirot dff4dedc72 Bug 1485676 - Convert TargetFactory.forTab call to forRemoteTab in debugger mochitest. r=yulia
Summary:
We are not passing a tab here. It only works by chance!

Depends On D4535

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4536

MozReview-Commit-ID: K0ztxPM2N6A
2018-09-24 09:52:48 -07:00
Alexandre Poirot dc5f0efff6 Bug 1485676 - Refactor gDevTools.getTargetForTab callsites to assume getTargetForTab is async. r=yulia
Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4535

MozReview-Commit-ID: FyERWaYipZo
2018-09-24 09:52:47 -07:00
shindli 2060f92f7d Merge inbound to mozilla-central. a=merge 2018-09-24 19:46:04 +03:00
shindli 824c0797e2 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-24 19:48:37 +03:00
Gabriel Luong 4e0c260292 Bug 1478397 - Part 18: Refactor the logic to get the flex items for a given flex container. r=pbro 2018-09-24 09:22:50 -04:00
shindli 51a3c01ced Backed out 9 changesets (bug 1485676) for failures in browser/tools/mozscreenshots/devtools/browser_devtools.js CLOSED TREE
Backed out changeset d358feec4ca1 (bug 1485676)
Backed out changeset ed554dbb062f (bug 1485676)
Backed out changeset 6e78058df94d (bug 1485676)
Backed out changeset 3a6f1b0e71f4 (bug 1485676)
Backed out changeset 16d2403aa787 (bug 1485676)
Backed out changeset 454eddf52157 (bug 1485676)
Backed out changeset 926f725f2183 (bug 1485676)
Backed out changeset fb03f174bd5f (bug 1485676)
Backed out changeset ceb93dd1799a (bug 1485676)
2018-09-24 15:27:27 +03:00
Coroiu Cristina 68a73ded70 Merge mozilla-central to inbound a=merge on a CLOSED TREE 2018-09-24 12:53:39 +03:00
Andrea Marchesini 61a7f9a598 Bug 1260399 - Remove deprecated messages in nsICookieManager methods - part 1 - nsICookieManager.add(), r=ehsan 2018-09-24 11:37:56 +02:00
Alexandre Poirot d2897f66aa Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
Summary:
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6162

MozReview-Commit-ID: Exz5fWyWyfN
2018-09-24 01:25:03 -07:00
Alexandre Poirot 796f22b354 Bug 1485676 - Rename TabTarget.makeRemote to TabTarget.attach. r=jdescottes
Summary:
Now that all the "remoting" of this method has been moved to TargetFactory.createTargetForTab,
we should rename this method to what it does now. It mostly call attach requests
of the target actor and its child console actor.
It also "connect" the webextension target actor, but I would like to eventually move that
outside of TabTarget.attach, like makeRemote.

Depends On D4078

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6161

MozReview-Commit-ID: KmFi1LIUBga
2018-09-24 01:25:02 -07:00
Alexandre Poirot 631e7bfdf9 Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4078

MozReview-Commit-ID: JAwiySsBZBu
2018-09-24 01:25:01 -07:00
Alexandre Poirot fe30914ea1 Bug 1485676 - Adapt gDevTools API to new async forTab and also adapt its callsites. r=yulia
Summary:
When switching to async, it is important to catch exception or register a rejection handler
so that errors keep being logged.
So in this patch I'm catching exception in a couple of important codepath.

Depends On D4541

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4542

MozReview-Commit-ID: IDPJVkAPbTs
2018-09-24 01:25:00 -07:00
Alexandre Poirot 81c6eab1f0 Bug 1485676 - Prevent exceptions in the emulation actor when trying to use it while it is already destroyed. r=yulia
Summary: Depends On D4540

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4541

MozReview-Commit-ID: 2fTZ4WRq9je
2018-09-24 01:25:00 -07:00
Alexandre Poirot 57c47d0e7a Bug 1485676 - Tweak RDM manage to support new async forTab. r=yulia
Summary:
Fetching any target is now asynchronous. But RDM setup/destroy codepath is very fragile
and introduce many low level exception when trying to restore the original browser element
if any timing changes.
So this patch prevents trying to fetch the target object if a toolbox isn't already opened.
The target object is being used only for Telemetry purpose for now.

Depends On D4538

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4540

MozReview-Commit-ID: 2QDUNqentMP
2018-09-24 01:24:59 -07:00
Alexandre Poirot 7b7f2b7ebd Bug 1485676 - Adapt gDevTools.createTargetForTab to new TabTarget class. r=yulia
Summary: Depends On D4536

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4537

MozReview-Commit-ID: E3AIMyFgL5m
2018-09-24 01:24:59 -07:00
Alexandre Poirot 36471d8e5c Bug 1485676 - Convert TargetFactory.forTab call to forRemoteTab in debugger mochitest. r=yulia
Summary:
We are not passing a tab here. It only works by chance!

Depends On D4535

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4536

MozReview-Commit-ID: K0ztxPM2N6A
2018-09-24 01:24:58 -07:00
Alexandre Poirot 35bc2e7546 Bug 1485676 - Refactor gDevTools.getTargetForTab callsites to assume getTargetForTab is async. r=yulia
Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4535

MozReview-Commit-ID: FyERWaYipZo
2018-09-24 01:24:58 -07:00
Julian Descottes cd7c5f04a6 Bug 1489421 - Add i18n for ExtensionDetail component;
Depends on D6609

Differential Revision: https://phabricator.services.mozilla.com/D6610

--HG--
extra : moz-landing-system : lando
2018-09-24 12:48:41 +00:00
Julian Descottes 5fa076dfc7 Bug 1489423 - Add i18n for InspectAction component;
Depends on D6608

Differential Revision: https://phabricator.services.mozilla.com/D6609

--HG--
extra : moz-landing-system : lando
2018-09-24 09:30:46 +00:00
Julian Descottes 400f74639c Bug 1489424 - Add i18n for ServiceWorkerAction component;
Depends on D6607

Differential Revision: https://phabricator.services.mozilla.com/D6608

--HG--
extra : moz-landing-system : lando
2018-09-24 09:28:03 +00:00
Julian Descottes 56fb105866 Bug 1489419 - Add i18n for DebugTargetList component;
Depends on D6606

Differential Revision: https://phabricator.services.mozilla.com/D6607

--HG--
extra : moz-landing-system : lando
2018-09-24 09:44:48 +00:00
Julian Descottes 54e21e5141 Bug 1489425 - Add i18n for TemporaryExtensionAction components;
Depends on D6605

Differential Revision: https://phabricator.services.mozilla.com/D6606

--HG--
extra : moz-landing-system : lando
2018-09-24 09:44:17 +00:00
Julian Descottes 79420d3af8 Bug 1489426 - Add i18n for TemporaryExtensionInstaller component;
Differential Revision: https://phabricator.services.mozilla.com/D6605

--HG--
extra : moz-landing-system : lando
2018-09-24 09:43:54 +00:00
erickstm87 4ff4ac533b Bug 1492510 - Deleting obsolete reference from eslintrc. r=sole
Differential Revision: https://phabricator.services.mozilla.com/D6407

--HG--
extra : moz-landing-system : lando
2018-09-24 12:34:12 +00:00
Nicolas Chevobbe d9eff244dc Bug 1491354 - Extends top-level await mapping from debugger to toolbox; r=bgrins,jlast.
This patch makes the parser-worker available at the toolbox level.
This way, the console does not have to rely on the debugger being
open to map top-level await expression.
In order to make the worker works in the toolbox, some changes
are required (passing a window object, checking inToolbox differently).

We take this as an opportunity to *not* display the async iife result,
a promise, in the console. This is made by checking if the input was
mapped, and if so, ignoring the result we get from the server.

A couple tests are added to ensure the basic usage works as expected.

This patch should be considered as a v0 for top-level await evaluation
as there are things that are not perfect here. Since we rely on console.log
the result are treated differently from other evaluation results:
- the style is different
- the result gets added to the log cache (when restarting the console,
the results will still be displayed, but not the commands).
- the results can be filtered, although evaluation results should not
- `$_` after a top-level await evaluation returns the Promise created
by the async iife, not the result that was displayed in the console.

All those should be addressed in Bug 1410820.

Differential Revision: https://phabricator.services.mozilla.com/D6038

--HG--
extra : moz-landing-system : lando
2018-09-24 08:17:30 +00:00
Preeti Mukherjee 23778fba25 Bug 1366534-convert uses of 'defer' to 'new Promise' in client/shadereditor;r=nchevobbe
convert uses of "defer" to "new Promise" in client/shadereditor

Differential Revision: https://phabricator.services.mozilla.com/D6220

--HG--
extra : moz-landing-system : lando
2018-09-24 07:38:25 +00:00
shindli 957b91ec70 Backed out changeset 2defd19a1467 (bug 1491946) for ES lint failure 2018-09-24 10:37:54 +03:00
Julien Wajsberg fa3590f449 Bug 1493680 - use the new getFront API and properly wait for the promise fullfilment r=gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D6671

--HG--
extra : moz-landing-system : lando
2018-09-24 15:50:35 +00:00
Anshul Malik efdb07ca38 Bug 832983 - Basic support for adding xhr breakpoints r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D5662

--HG--
extra : moz-landing-system : lando
2018-09-21 22:20:37 +00:00
Brian Grinstead 22f06659d2 Bug 1492967 - Merge together remote-browser and browser bindings;r=ochameau,mconley
Differential Revision: https://phabricator.services.mozilla.com/D6462

--HG--
extra : moz-landing-system : lando
2018-09-24 16:24:04 +00:00
Jim Blandy 5c185b4f8f Bug 1491946: Save devtools heap snapshots with the extension '.fxsnapshot.gz'. r=fitzgen 2018-09-17 11:57:42 -07:00
David Walsh aa73feb253 Bug 1314057 - Remove old debugger's breakpoints-button, parser, and scripts-switching tests r=jlast
--HG--
extra : histedit_source : d927c35523b12aa490be9ae44c7555d1b82f4499
2018-09-25 13:48:44 -05:00
David Walsh d59a8d5878 Bug 1314057 - Remove pretty-print and blackboxing tests no longer relevant to new debugger r=jlast
--HG--
extra : histedit_source : ff9c32b7e6fd8b0260d0d5d0d951d64a7fa4eb01
2018-09-25 09:13:00 -05:00
Ciure Andrei 6760739b90 Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-09-26 00:53:40 +03:00
Jason Laster 73902a3b9a Bug 1493151 - Update Debugger Frontend v89. r=dwalsh 2018-09-25 17:46:05 -04:00
Jim Blandy 4634133ae0 Bug 1491946: Save devtools heap snapshots with the extension '.fxsnapshot.gz'. r=fitzgen 2018-09-17 11:57:42 -07:00
Gabriel Luong 99d7d4bb33 Bug 1494162 - Part 54: Stop loading codemirror.bundle.js in the markup. r=jdescottes 2018-10-04 09:25:20 -04:00
Gabriel Luong a1c8903e6c Bug 1494162 - Part 45: Lazy load Menu and MenuItem in TabBar. r=pbro 2018-10-04 09:19:30 -04:00
Gabriel Luong 498ddbcb2a Bug 1494162 - Part 55: Remove traits for getCssPath and getXPath. r=rcaliman 2018-10-04 08:52:56 -04:00
Gabriel Luong c07636d479 Bug 1494162 - Part 52: Don't show the empty message in the CssRuleView constructor. r=pbro
We will eventually call showEmpty() when an element is selected if there are no rules.
This improves the perceive performance of the rules view because it doesn't have
a flicker of the empty text to the css rules.
2018-10-04 08:52:52 -04:00
Gabriel Luong 110b41a47f Bug 1494162 - Part 48: Lazy load getUnicodeUrl in ToolboxToolbar. r=pbro 2018-10-04 08:52:44 -04:00
Dao Gottwald ab68e55ad5 Bug 1493412 - "Remove warning-64.png on Windows" r=ntim 2018-09-22 06:29:00 +03:00
Gurzau Raul ad28ad0169 Backed out 9 changesets (bug 1485676) for failing at damp inspector/cold-open.js on a CLOSED TREE
Backed out changeset 4de2e71debfe (bug 1485676)
Backed out changeset e63025150c7a (bug 1485676)
Backed out changeset f9ef30ae3f7f (bug 1485676)
Backed out changeset a83636fab16a (bug 1485676)
Backed out changeset b1fd24929e09 (bug 1485676)
Backed out changeset acb27b915742 (bug 1485676)
Backed out changeset ba2157632772 (bug 1485676)
Backed out changeset d1d6b9bc2372 (bug 1485676)
Backed out changeset d7646ea8640b (bug 1485676)
2018-09-22 19:42:04 +03:00
Alexandre Poirot f98d0997fe Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
Summary:
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6162

MozReview-Commit-ID: Exz5fWyWyfN
2018-09-22 08:34:21 -07:00
Alexandre Poirot 8724260e30 Bug 1485676 - Rename TabTarget.makeRemote to TabTarget.attach. r=jdescottes
Summary:
Now that all the "remoting" of this method has been moved to TargetFactory.createTargetForTab,
we should rename this method to what it does now. It mostly call attach requests
of the target actor and its child console actor.
It also "connect" the webextension target actor, but I would like to eventually move that
outside of TabTarget.attach, like makeRemote.

Depends On D4078

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6161

MozReview-Commit-ID: KmFi1LIUBga
2018-09-22 08:34:21 -07:00
Alexandre Poirot 48f5790c9b Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4078

MozReview-Commit-ID: JAwiySsBZBu
2018-09-22 08:34:20 -07:00
Alexandre Poirot b553b3b567 Bug 1485676 - Adapt gDevTools API to new async forTab and also adapt its callsites. r=yulia
Summary:
When switching to async, it is important to catch exception or register a rejection handler
so that errors keep being logged.
So in this patch I'm catching exception in a couple of important codepath.

Depends On D4541

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4542

MozReview-Commit-ID: IDPJVkAPbTs
2018-09-22 08:34:20 -07:00
Alexandre Poirot 036625ce21 Bug 1485676 - Prevent exceptions in the emulation actor when trying to use it while it is already destroyed. r=yulia
Summary: Depends On D4540

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4541

MozReview-Commit-ID: 2fTZ4WRq9je
2018-09-22 08:34:20 -07:00
Alexandre Poirot 8cd354df9d Bug 1485676 - Tweak RDM manage to support new async forTab. r=yulia
Summary:
Fetching any target is now asynchronous. But RDM setup/destroy codepath is very fragile
and introduce many low level exception when trying to restore the original browser element
if any timing changes.
So this patch prevents trying to fetch the target object if a toolbox isn't already opened.
The target object is being used only for Telemetry purpose for now.

Depends On D4538

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4540

MozReview-Commit-ID: 2QDUNqentMP
2018-09-22 08:34:19 -07:00
Alexandre Poirot 5cd419ffca Bug 1485676 - Adapt gDevTools.createTargetForTab to new TabTarget class. r=yulia
Summary: Depends On D4536

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4537

MozReview-Commit-ID: E3AIMyFgL5m
2018-09-22 08:34:19 -07:00
Alexandre Poirot 1e7e1b1c81 Bug 1485676 - Convert TargetFactory.forTab call to forRemoteTab in debugger mochitest. r=yulia
Summary:
We are not passing a tab here. It only works by chance!

Depends On D4535

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4536

MozReview-Commit-ID: K0ztxPM2N6A
2018-09-22 08:34:18 -07:00
Alexandre Poirot e2590d206d Bug 1485676 - Refactor gDevTools.getTargetForTab callsites to assume getTargetForTab is async. r=yulia
Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4535

MozReview-Commit-ID: FyERWaYipZo
2018-09-22 08:34:18 -07:00
Brindusan Cristian 4c389d3514 Backed out changeset 70d1a0c0270c (bug 832983) for devtools failures on /test/browser_inspector_pseudoclass-lock.js. CLOSED TREE 2018-09-21 23:23:59 +03:00
Anshul Malik 0aaccab5d7 Bug 832983 - Basic support for adding xhr breakpoints r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D5662

--HG--
extra : moz-landing-system : lando
2018-09-21 19:12:17 +00:00
Julien Wajsberg 8dccd09804 Bug 1492893 - [Devtools Performance-new] Remove the unused toolbox object from the redux store r=gregtatum
MozReview-Commit-ID: 1LJ6HypOYbM

Differential Revision: https://phabricator.services.mozilla.com/D6469

--HG--
extra : moz-landing-system : lando
2018-09-21 15:57:05 +00:00
arthur.iakab fb9c5e11eb Backed out 2 changesets (bug 1489224)
Backed out changeset d414a44d8119 (bug 1489224)
Backed out changeset 6300cdbc0e04 (bug 1489224)
2018-09-21 19:28:04 +03:00
Zibi Braniecki 83ea94f5ba Bug 1491394 - Update callsites to use new mozILocaleService API. r=jfkthame
Depends on D5924

Differential Revision: https://phabricator.services.mozilla.com/D6339

--HG--
extra : moz-landing-system : lando
2018-09-21 15:30:37 +00:00
Julian Descottes f0fe1b2410 Bug 1490301 - Always use relative paths in new about:debugging;r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D6398

--HG--
extra : moz-landing-system : lando
2018-09-21 11:31:07 +00:00
Julian Descottes 672c02580e Bug 1489224 - Add mochitest to check runtimes section of aboudebugging sidebar;r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D6402

--HG--
extra : moz-landing-system : lando
2018-09-21 14:38:16 +00:00
Julian Descottes 151130d992 Bug 1489224 - Fix order of tests in aboutdebugging-new;r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D6403

--HG--
extra : moz-landing-system : lando
2018-09-21 12:31:16 +00:00
Daisuke Akatsuka edb0efe097 Bug 1405235 - Part 3: Remove extra extensions defining for test. r=jdescottes
Depends on D5648

Differential Revision: https://phabricator.services.mozilla.com/D6483

--HG--
extra : moz-landing-system : lando
2018-09-21 12:17:26 +00:00
Daisuke Akatsuka 2b352eba33 Bug 1405235 - Part 2: Show USB devices using SidebarItem. r=jdescottes
Depends on D5647

Differential Revision: https://phabricator.services.mozilla.com/D5648

--HG--
extra : moz-landing-system : lando
2018-09-20 03:27:05 +00:00
Daisuke Akatsuka 9d7105adee Bug 1405235 - Part 1: Implement a mechanism to show USB devices. r=jdescottes
Depends on D5386

Differential Revision: https://phabricator.services.mozilla.com/D5647

--HG--
extra : moz-landing-system : lando
2018-09-21 11:24:18 +00:00
Tim Nguyen 3d54c50b09 Bug 1491609 - Update common.inc.css checkbox and radio styling. r=jaws,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D5983

--HG--
rename : toolkit/themes/shared/in-content/check-partial.svg => toolkit/themes/shared/icons/check-partial.svg
rename : browser/themes/shared/icons/check.svg => toolkit/themes/shared/icons/check.svg
extra : moz-landing-system : lando
2018-09-21 10:23:21 +00:00
arthur.iakab 6877b6a75c Backed out 9 changesets (bug 1485676)for perma failures in devtools/client/canvasdebugger/test/browser_canvas-actor-test-01.js CLOSED TREE
Backed out changeset 9f5ec2aa7109 (bug 1485676)
Backed out changeset 0d530c1316a4 (bug 1485676)
Backed out changeset 03278e6fe685 (bug 1485676)
Backed out changeset 275463260056 (bug 1485676)
Backed out changeset 4c5a956b33f7 (bug 1485676)
Backed out changeset d8fe80bb0e3c (bug 1485676)
Backed out changeset 56240996921f (bug 1485676)
Backed out changeset ec0a322f5cc9 (bug 1485676)
Backed out changeset f0f4f9407970 (bug 1485676)
2018-09-21 12:48:48 +03:00
Hiroyuki Ikezoe 7ea3b5e685 Bug 1492724 - Add ADBScanner once after the extension is installed or is ready. r=jdescottes
And remove the ADBScanner once the extension is uninstalled.

When RuntimeScanners.add is called for ADBScanner, RuntimeScanner calls
ADBScanner.enable(), thus ADB.start() is called.  Meanwhile WebIDE installs the
devtools adb extension if the extension hasn't installed yet.  So if the
ADB.start() is called before the installation finishes, ADB.start() fails.

Differential Revision: https://phabricator.services.mozilla.com/D6466

--HG--
extra : moz-landing-system : lando
2018-09-21 08:17:15 +00:00
Alexandre Poirot cffaacada5 Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Differential Revision: https://phabricator.services.mozilla.com/D6162

--HG--
extra : moz-landing-system : lando
2018-09-21 08:08:24 +00:00
Alexandre Poirot c023333832 Bug 1485676 - Rename TabTarget.makeRemote to TabTarget.attach. r=jdescottes
Now that all the "remoting" of this method has been moved to TargetFactory.createTargetForTab,
we should rename this method to what it does now. It mostly call attach requests
of the target actor and its child console actor.
It also "connect" the webextension target actor, but I would like to eventually move that
outside of TabTarget.attach, like makeRemote.

Depends On D4078

Differential Revision: https://phabricator.services.mozilla.com/D6161

--HG--
extra : moz-landing-system : lando
2018-09-21 08:08:11 +00:00
Alexandre Poirot 196d295b46 Bug 1485676 - Connect to local server from TargetFactory.forTab and make TabTarget always remote-like. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D4078

--HG--
extra : moz-landing-system : lando
2018-09-21 08:07:48 +00:00
Alexandre Poirot 71f3e5e9f8 Bug 1485676 - Adapt gDevTools API to new async forTab and also adapt its callsites. r=yulia
When switching to async, it is important to catch exception or register a rejection handler
so that errors keep being logged.
So in this patch I'm catching exception in a couple of important codepath.

Depends On D4541

Differential Revision: https://phabricator.services.mozilla.com/D4542

--HG--
extra : moz-landing-system : lando
2018-09-21 08:07:25 +00:00
Alexandre Poirot 71aa1002dd Bug 1485676 - Prevent exceptions in the emulation actor when trying to use it while it is already destroyed. r=yulia
Depends On D4540

Differential Revision: https://phabricator.services.mozilla.com/D4541

--HG--
extra : moz-landing-system : lando
2018-09-21 08:07:12 +00:00
Alexandre Poirot acb1662577 Bug 1485676 - Tweak RDM manage to support new async forTab. r=yulia
Fetching any target is now asynchronous. But RDM setup/destroy codepath is very fragile
and introduce many low level exception when trying to restore the original browser element
if any timing changes.
So this patch prevents trying to fetch the target object if a toolbox isn't already opened.
The target object is being used only for Telemetry purpose for now.

Depends On D4538

Differential Revision: https://phabricator.services.mozilla.com/D4540

--HG--
extra : moz-landing-system : lando
2018-09-21 08:11:48 +00:00
Alexandre Poirot 2ec27d0a50 Bug 1485676 - Adapt gDevTools.createTargetForTab to new TabTarget class. r=yulia
Depends On D4536

Differential Revision: https://phabricator.services.mozilla.com/D4537

--HG--
extra : moz-landing-system : lando
2018-09-21 08:11:53 +00:00
Alexandre Poirot 55c356daea Bug 1485676 - Convert TargetFactory.forTab call to forRemoteTab in debugger mochitest. r=yulia
We are not passing a tab here. It only works by chance!

Depends On D4535

Differential Revision: https://phabricator.services.mozilla.com/D4536

--HG--
extra : moz-landing-system : lando
2018-09-21 08:06:34 +00:00
Alexandre Poirot 3d286eae18 Bug 1485676 - Refactor gDevTools.getTargetForTab callsites to assume getTargetForTab is async. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D4535

--HG--
extra : moz-landing-system : lando
2018-09-21 08:06:16 +00:00
arthur.iakab f47edab318 Backed out changeset 45f7b6097f9b (bug 1491609)for browser chrome failures on static/browser_parsable_css.js
--HG--
rename : toolkit/themes/shared/icons/check.svg => browser/themes/shared/icons/check.svg
rename : toolkit/themes/shared/icons/check-partial.svg => toolkit/themes/shared/in-content/check-partial.svg
extra : rebase_source : 2eed09bef57a3b2a28dd4d6a738e2e9c14781125
2018-09-21 10:15:46 +03:00
Tim Nguyen 53a8a142a5 Bug 1491609 - Update common.inc.css checkbox and radio styling. r=jaws,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D5983

--HG--
rename : toolkit/themes/shared/in-content/check-partial.svg => toolkit/themes/shared/icons/check-partial.svg
rename : browser/themes/shared/icons/check.svg => toolkit/themes/shared/icons/check.svg
extra : moz-landing-system : lando
2018-09-20 21:34:14 +00:00
Mantaroh Yoshinaga 892caaf501 Bug 1476549 - Part 5. Modify the tests which is realted to frames button. r=birtles
Differential Revision: https://phabricator.services.mozilla.com/D4633

--HG--
extra : moz-landing-system : lando
2018-09-20 08:03:21 +00:00
Mantaroh Yoshinaga 993f83b2af Bug 1476549 - Part 4. Make the frame button to MenuButton. r=birtles
Differential Revision: https://phabricator.services.mozilla.com/D6353

--HG--
extra : moz-landing-system : lando
2018-09-20 06:54:39 +00:00
Mantaroh Yoshinaga 6bc54906ce Bug 1476549 - Part 3. Support the children of function type on the MenuButton. r=birtles
This patch will:
 - Call the children as function when rendering if MenuButton's children property is the function.
 - Add the callback which is called when the focused item changed.

Differential Revision: https://phabricator.services.mozilla.com/D6352

--HG--
extra : moz-landing-system : lando
2018-09-20 06:28:00 +00:00
Mantaroh Yoshinaga 0a1ca8ae92 Bug 1476549 - Part 2. Change the several functions to the local function of ToolboxToolbar. r=jdescottes
This patch will move the global functions of ToolboxToolbar to its local
function. As a result of this changes, each function can refer 'props' from
'this' scope.

Differential Revision: https://phabricator.services.mozilla.com/D4631

--HG--
extra : moz-landing-system : lando
2018-09-20 03:57:43 +00:00
Mantaroh Yoshinaga c71dc7f54f Bug 1476549 - Part 1. Rename toolbox.onHightlightFrame to toolbox.onHighlightFrame. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D4630

--HG--
extra : moz-landing-system : lando
2018-09-14 05:54:47 +00:00
Gurzau Raul 4fc41e9a2f Backed out changeset ce4f180d81e4 (bug 832983) for failing at /test/browser_net_leak_on_tab_close.js on a CLOSED TREE 2018-09-21 02:37:30 +03:00
Anshul Malik c4a1f5d364 Bug 832983 - Basic support for adding xhr breakpoints r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D5662

--HG--
extra : moz-landing-system : lando
2018-09-20 21:52:52 +00:00
Andreea Pavel f5f6c0b588 Merge mozilla-inbound to mozilla-central. a=merge 2018-09-21 00:54:47 +03:00
Gabriel Luong 239c817459 Bug 1478397 - Part 17: Replace %s with %S for flexbox.flexItemOf string in layout.properties. r=pbro 2018-09-20 11:58:56 -04:00
Gabriel Luong e53bf4a2e8 Bug 1478397 - Part 16: Cache the custom host colors and the overlay color for the current host to avoid unnecessary fetching. r=pbro 2018-09-20 11:58:52 -04:00
Margareta Eliza Balazs 92be42b8f3 Merge inbound to mozilla-central. a=merge 2018-09-20 16:24:21 +03:00
Gabriel Luong 36d471de5b Bug 1494162 - Part 29: Avoid calling toolsidebar show with an id when the default tab is already selected. r=Honza 2018-09-28 16:43:03 -04:00
Gabriel Luong 56b8221535 Bug 1494162 - Part 19: Backed out changeset 6297b63aa220. r=me 2018-09-28 16:14:32 -04:00
Gabriel Luong a567ea6096 Bug 1494162 - Part 19: Backed out changeset 5fd32a2fbc66. r=me 2018-09-28 16:19:30 -04:00
Gabriel Luong 20822612a3 Bug 1494162 - Part 19 Follow up: Fix test failures in test_css-logic-getCssPath.html. r=me 2018-09-28 16:12:47 -04:00
Gabriel Luong 731fa92589 Bug 1494162 - Part 19: Directly import getCssPath, getXpath and findCssSelector. r=pbro 2018-09-28 13:14:34 -04:00
Gabriel Luong 0e3a983790 Bug 1494162 - Part 17: Lazy load the redux middlewares in create-store. r=pbro 2018-09-28 13:14:34 -04:00
Gabriel Luong 5ba9ee79df Bug 1494162 - Part 16: Lazy load the TimeScale module in the animation reducer. r=pbro 2018-09-28 13:14:33 -04:00
Gabriel Luong 43eacf60be Bug 1494162 - Part 15: Use the cached css properties in the rules view. r=pbro 2018-09-28 13:14:33 -04:00
Gabriel Luong 63a0a8f89d Bug 1494162 - Part 14: Lazy load parseNamedDeclarations in Rule. r=pbro 2018-09-28 12:49:02 -04:00
Gabriel Luong 893438469a Bug 1494162 - Part 13: Lazy load modules in the TextPropertyEditor. r=pbro 2018-09-28 12:48:50 -04:00
Gabriel Luong c75eb16fc7 Bug 1494162 - Part 12: Lazy load modules in RuleEditor. r=pbro 2018-09-28 12:48:28 -04:00
Gabriel Luong 38f1733efb Bug 1494162 - Part 11: Lazy load promiseWarn in the rules model. r=pbro 2018-09-28 12:48:06 -04:00
Gabriel Luong 7a4d354866 Bug 1494162 - Part 10: Lazy initialize the event details and image tooltip in the markup view. r=pbro 2018-09-28 12:45:16 -04:00
Gabriel Luong b3daa0abdb Bug 1494162 - Part 7: Lazy load modules in the shared inspector utils. r=pbro 2018-09-28 12:43:37 -04:00
Gabriel Luong bbe39d87b7 Bug 1494162 - Part 6: Lazy load the modules in the ElementContainer. r=pbro 2018-09-28 12:43:08 -04:00
Gabriel Luong 90be821092 Bug 1494162 - Part 5: Lazy load modules in ElementEditor. r=pbro 2018-09-28 12:42:16 -04:00
Gabriel Luong 67dba9eced Bug 1494162 - Part 4: Lazy load the modules in the TextEditor. r=pbro 2018-09-28 12:42:09 -04:00
Gabriel Luong f02c127be2 Bug 1464192 - Part 18: Lazy load modules in the css-logic. r=pbro
--HG--
extra : source : 973fbb5bbadcafcb1b49fe82b452eff4da5b2838
2018-09-28 13:14:34 -04:00
Noemi Erli 8e345b1180 Backed out 16 changesets (bug 1494162, bug 1464192) for failures in test_css-logic-getCssPath.html CLOSED TREE
Backed out changeset 0d5a593adfda (bug 1494162)
Backed out changeset ea5d67d3c2ae (bug 1494162)
Backed out changeset 98c531e6f8d4 (bug 1494162)
Backed out changeset 973fbb5bbadc (bug 1464192)
Backed out changeset bbbf97a5802e (bug 1494162)
Backed out changeset c1dac4bffc06 (bug 1494162)
Backed out changeset c90d929f87f2 (bug 1494162)
Backed out changeset f90da1a0201b (bug 1494162)
Backed out changeset ee129a8c5e00 (bug 1494162)
Backed out changeset 10143ae649e5 (bug 1494162)
Backed out changeset f700e44ea63f (bug 1494162)
Backed out changeset cb2b02dc4b47 (bug 1494162)
Backed out changeset 4880d9571aa7 (bug 1494162)
Backed out changeset b9e187182a0f (bug 1494162)
Backed out changeset f077ffe76ca5 (bug 1494162)
Backed out changeset ef609de4cd5c (bug 1494162)
2018-09-28 21:57:12 +03:00
Gabriel Luong 1f1665c9f1 Bug 1464192 - Part 21: Lazy initialize KeyShortcuts on focus of the HTMLBreadcrumbs. r=pbro 2018-09-28 13:51:10 -04:00
Gabriel Luong b487d0bddb Bug 1494162 - Part 15 Followup followup: Lazy require isCssVariable. r=me CLOSED TREE 2018-09-28 13:45:07 -04:00
Gabriel Luong 96721a5bdc Bug 1494162 - Part 15 Followup: Fix eslint error. r=me CLOSED TREE 2018-09-28 13:38:41 -04:00
Gabriel Luong dbc0e64446 Bug 1494162 - Part 19: Directly import getCssPath, getXpath and findCssSelector. r=pbro 2018-09-28 13:14:34 -04:00
Gabriel Luong f37977f646 Bug 1464192 - Part 18: Lazy load modules in the css-logic. r=pbro 2018-09-28 13:14:34 -04:00
Gabriel Luong 5525c2ed7a Bug 1494162 - Part 17: Lazy load the redux middlewares in create-store. r=pbro 2018-09-28 13:14:34 -04:00
Gabriel Luong a97b421f89 Bug 1494162 - Part 16: Lazy load the TimeScale module in the animation reducer. r=pbro 2018-09-28 13:14:33 -04:00
Gabriel Luong b5b5192fad Bug 1494162 - Part 15: Use the cached css properties in the rules view. r=pbro 2018-09-28 13:14:33 -04:00
Gabriel Luong 6b354c946b Bug 1494162 - Part 14: Lazy load parseNamedDeclarations in Rule. r=pbro 2018-09-28 12:49:02 -04:00
Gabriel Luong a42fe83d7e Bug 1494162 - Part 13: Lazy load modules in the TextPropertyEditor. r=pbro 2018-09-28 12:48:50 -04:00
Gabriel Luong 4b1627ebd3 Bug 1494162 - Part 12: Lazy load modules in RuleEditor. r=pbro 2018-09-28 12:48:28 -04:00
Gabriel Luong ff332d9128 Bug 1494162 - Part 11: Lazy load promiseWarn in the rules model. r=pbro 2018-09-28 12:48:06 -04:00
Gabriel Luong 8b22be6019 Bug 1494162 - Part 10: Lazy initialize the event details and image tooltip in the markup view. r=pbro 2018-09-28 12:45:16 -04:00
Gabriel Luong 5e8106b3ca Bug 1494162 - Part 7: Lazy load modules in the shared inspector utils. r=pbro 2018-09-28 12:43:37 -04:00
Gabriel Luong 7d2c7aa8b6 Bug 1494162 - Part 6: Lazy load the modules in the ElementContainer. r=pbro 2018-09-28 12:43:08 -04:00
Gabriel Luong b29d5f4b24 Bug 1494162 - Part 5: Lazy load modules in ElementEditor. r=pbro 2018-09-28 12:42:16 -04:00
Gabriel Luong 3c7d990b5c Bug 1494162 - Part 4: Lazy load the modules in the TextEditor. r=pbro 2018-09-28 12:42:09 -04:00
Gabriel Luong 97b3aca03a Bug 1494162 - Part 3: Lazy load the SlottedNodeContainer in the markup view. r=pbro
The assumption is that there aren't many webpages that are currently using web
components yet so we may want to take advantage of lazily loading the
SlottedNodeContainer.
2018-09-28 12:33:17 -04:00
Gabriel Luong 79b9377e12 Bug 1494162 - Part 2: Lazy load the UndoStack in the markup view. r=pbro 2018-09-28 12:32:12 -04:00
Tiberius Oros 3e2d191873 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-09-28 18:42:23 +03:00
Gabriel Luong 4ac81fe9aa Bug 1494162 - Part 22: Remove onUnderflow call in ArrowScrollBox init. r=pbro 2018-09-28 11:33:32 -04:00
Gabriel Luong ea6fc10e6e Bug 1494162 - Part 31: Lazy load the Reps in the layout panel. r=Honza 2018-09-28 11:30:53 -04:00
Gabriel Luong d77be1c308 Bug 1494162 - Part 26: Lazy load accessibility utils. r=yzen 2018-09-28 11:27:37 -04:00
yulia 825e041cf6 Bug 1485378 - Replace CallWatcher actor with helper; r=jdescottes
creates a CallWatcherActor only for tests and migrates other functionality to the helper

Differential Revision: https://phabricator.services.mozilla.com/D5534

--HG--
rename : devtools/server/actors/call-watcher.js => devtools/client/canvasdebugger/test/call-watcher-actor.js
rename : devtools/shared/fronts/call-watcher.js => devtools/client/canvasdebugger/test/call-watcher-front.js
rename : devtools/shared/specs/call-watcher.js => devtools/client/canvasdebugger/test/call-watcher-spec.js
rename : devtools/server/actors/call-watcher.js => devtools/server/actors/utils/call-watcher.js
rename : devtools/server/actors/call-watcher.js => devtools/server/actors/utils/function-call.js
rename : devtools/shared/fronts/call-watcher.js => devtools/shared/fronts/function-call.js
rename : devtools/shared/specs/call-watcher.js => devtools/shared/specs/function-call.js
extra : moz-landing-system : lando
2018-09-20 13:41:26 +00:00
Julian Descottes 4f0efc181d Bug 1492373 - Wait for media-list-changed events to settle in browser_styleeditor_media_sidebar_links.js;r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D6283

--HG--
extra : moz-landing-system : lando
2018-09-20 07:14:27 +00:00
Margareta Eliza Balazs 5f3eea312b Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-20 16:30:08 +03:00
Alexandre Poirot 8d5356574c Bug 1485605 - Remove usages of TabTarget.window. r=yulia
This code only works on non-e10s and appear to no longer be used.

Differential Revision: https://phabricator.services.mozilla.com/D6270

--HG--
extra : moz-landing-system : lando
2018-09-20 12:16:51 +00:00
Alexandre Poirot 162cf2b6ee Bug 1487337 - Bump devtools compatibility threshold up to 62 (current release version) r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D6252

--HG--
extra : moz-landing-system : lando
2018-09-20 09:11:26 +00:00
Michael Ratcliffe 7cfa3eab78 Bug 1488206 - TelemetryStopwatch: error requesting elapsed time for nonexisting stopwatch r=Honza
Because firefox can be closed with the toolbox in a half initialized state telemetry can throw if it expects a tool to be closing when no tools are fully initialized although this is completely expected. Here we simply choose not to report those errors because this is expected behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D4869

--HG--
extra : moz-landing-system : lando
2018-09-20 11:06:58 +00:00
Noemi Erli a3c54cc616 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-10-01 19:29:22 +03:00
Gabriel Luong 2afda0eeae Bug 1494162 - Part 28: Lazy initialize TooltipToggle in HTMLTooltip. r=jdescottes 2018-10-01 11:24:41 -04:00
Gabriel Luong c430c4700b Bug 1494162 - Part 25: Lazy load the modules in HTMLTooltip. r=jdescottes 2018-10-01 11:24:21 -04:00
Gabriel Luong 8c0f63c4b2 Bug 1494162- Part 24: Lazily get the preview tooltip to avoid loading HTMLTooltip. r=pbro 2018-10-01 11:23:38 -04:00
Gabriel Luong 4d4d2e1fa9 Bug 1494162 - Part 23: Lazy load the redux middleware modules. r=pbro 2018-10-01 11:23:24 -04:00
Dorel Luca c1a2ab3088 Backed out changeset 6a4032171aaf (bug 1485605) for Eslint failure on builds/worker/checkouts/gecko/devtools/client/framework/target.js. CLOSED TREE 2018-09-20 12:42:40 +03:00
Alexandre Poirot 75c671c299 Bug 1485605 - Remove usages of TabTarget.window. r=yulia
This code only works on non-e10s and appear to no longer be used.

Differential Revision: https://phabricator.services.mozilla.com/D6270

--HG--
extra : moz-landing-system : lando
2018-09-20 08:35:03 +00:00
Alexandre Poirot f12c00cd13 Bug 1485671 - Expose and use TabClient.listFrames and switchToFrame. r=yulia
Depends On D6272

Differential Revision: https://phabricator.services.mozilla.com/D6273

--HG--
extra : moz-landing-system : lando
2018-09-20 08:30:32 +00:00
Alexandre Poirot 036563e90b Bug 1485671 - Expose and use TabClient.logInPage instead of sending request manually. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D6272

--HG--
extra : moz-landing-system : lando
2018-09-20 07:50:54 +00:00
erickstm d5553ea879 Bug 1491768 - Increase input history limit; r=nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D6254

--HG--
extra : moz-landing-system : lando
2018-09-19 15:24:15 +00:00
Daisuke Akatsuka d4208803a0 Bug 1489221: Add tests for collapsibilities of DebugTargetPane. r=jdescottes
Depends on D6227

Differential Revision: https://phabricator.services.mozilla.com/D6228

--HG--
extra : moz-landing-system : lando
2018-09-20 02:01:29 +00:00
Emilio Cobos Álvarez e39bf77494 Bug 1492567 - Back out bug 1481866. r=dbaron
Summary:
The behavior the WG proposed is way more subtle than what that bug implements,
including:

 * Implementing two logical overflow longhands.
 * Expanding the overflow shorthand to different longhands depending on the
   syntax of that.

Meanwhile, Blink hasn't done the swap and will ship the same behavior that we
shipped in Firefox 61 (bug 1453148), that is, overflow-x, then overflow-y.

So I think lacking a clear way forward we should revert this change and preserve
our shipped behavior.

Reviewers: dbaron!

Tags: #secure-revision

Bug #: 1492567

Differential Revision: https://phabricator.services.mozilla.com/D6317
2018-09-20 01:27:55 +02:00
Daisuke Akatsuka 5f86775660 Bug 1490950: Define aboutdebugging in script tag on html. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D6227

--HG--
extra : moz-landing-system : lando
2018-09-19 22:07:01 +00:00
Bogdan Tara e7c653959c Merge inbound to mozilla-central. a=merge 2018-09-20 00:58:18 +03:00
Daisuke Akatsuka 0485028f23 Bug 1492101: Store a preference which includes extension existence after drag and drap instead of when closing toolbox. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D6225

--HG--
extra : moz-landing-system : lando
2018-09-19 08:24:25 +00:00
Jim Blandy 46b1fcfb0f Bug 1491914 - Include a binding for `ChromeUtils` in the browser content toolbox. r=bgrins
--HG--
extra : rebase_source : dc2a99d7bd8b700b4abeccab4ee14af8ba225df8
2018-09-17 11:06:58 -07:00
Julian Descottes 5f4566daa5 Bug 1492516 - Delete badge properties when removing badge element from the DOM;r=gl 2018-09-19 18:52:04 +02:00
Daisuke Akatsuka e00f05a482 Bug 1490981: Disable browser_animation_keyframes-progress-bar test on win ccov. r=sparky
Differential Revision: https://phabricator.services.mozilla.com/D6229

--HG--
extra : moz-landing-system : lando
2018-09-19 11:46:03 +00:00
Jan Odvarko d48833fbbc Bug 1491749 - Stop using xul:keyset and xul:key in toolbox-window.xul; r=bgrins,flod
Differential Revision: https://phabricator.services.mozilla.com/D6015

--HG--
extra : moz-landing-system : lando
2018-09-19 09:58:08 +00:00
Nicolas Chevobbe 4064742f1a Bug 1491776 - Do not use markText to show the completion text; r=bgrins.
Differential Revision: https://phabricator.services.mozilla.com/D6020

--HG--
extra : moz-landing-system : lando
2018-09-18 19:22:01 +00:00
Xidorn Quan 8396cd75c7 Bug 1483075 - Merge the two scrollbar color properties into scrollbar-color. r=heycam,hiro
Differential Revision: https://phabricator.services.mozilla.com/D6115

--HG--
extra : moz-landing-system : lando
2018-09-19 05:33:12 +00:00
Daisuke Akatsuka b3891b0f8f Bug 1490583: Remove actor related code that no longer used. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D5842

--HG--
extra : moz-landing-system : lando
2018-09-19 02:03:49 +00:00
arthur.iakab 1ee75a928a Merge inbound to mozilla-central a=merge 2018-09-19 05:18:50 +03:00
Jason Laster 8d08b34677 Bug 1491983 - Update Debugger Frontend v88. r=dwalsh 2018-09-18 17:57:03 -04:00
Gabriel Luong 0a0c1deadd Bug 1478397 - Part 14: Selecting a flex item in the flex item selector should select that element in the markup view. r=rcaliman 2018-09-18 09:46:02 -04:00
Gabriel Luong f22fa6beef Bug 1478397 - Part 13: Show the flex item sizing properties of the currently selected element in the markup view. r=rcaliman 2018-09-18 09:46:02 -04:00
Gabriel Luong b9eaf11d5d Bug 1478397 - Part 12: Don't render the flex item list if there are no flex items. r=rcaliman 2018-09-18 09:46:02 -04:00
Gabriel Luong b045aa35a7 Bug 1478397 - Part 11: Add a prev button to navigate from the flex item sizing view to flex container view. r=rcaliman 2018-09-18 09:46:02 -04:00
Gabriel Luong c4de83b6c4 Bug 1478397 - Part 10: Adjust the flexbox header to match the design spec. r=rcaliman 2018-09-18 09:46:01 -04:00
Noemi Erli 63025fbf18 Backed out changeset 44c69e043cf7 (bug 1490583) for failures in browser_animation_reconstructState.js 2018-09-18 21:44:19 +03:00