6fb72d4a3f
Bug 1754579 - Don't keep so much alive when returning DOMRects & co. r=smaug
...
We keep the parent alive for wrapping. It's unnecessary to keep alive
the individual element / range / etc. Pass the relevant global /
document.
Differential Revision: https://phabricator.services.mozilla.com/D138357
2022-02-10 00:38:45 +00:00
dc4988bbd0
Bug 1729805 - Make async OpenMenu simpler/sound. r=NeilDeakin,mstange
...
There's only one caller of it and it's not sound: The runnable captures a
raw frame pointer etc. Instead, just do a dispatch to the main thread
and call OpenMenu there. This simplifies the following patch.
Differential Revision: https://phabricator.services.mozilla.com/D131082
2022-01-25 21:40:22 +00:00
d95d7abddc
Bug 1735076 - Use ProgrammaticFocusFlags from nsXULCommandDispatcher. r=smaug
...
Relevant calls are here:
https://searchfox.org/mozilla-central/rev/21a9b72545da06681db97c4b3a2a6be761f4aae5/toolkit/content/widgets/button.js#42-68
This makes sure to set the FLAG_BYKEY properly if needed, instead of passing
down raw flags to nsFocusManager. Clean up a bit while at it.
Let me know if you want a test for this, but we have tests for programmatic
focus and :focus-visible already, so my gut feeling is that testing this
particular XUL-specific change is not super-worth-it...
Differential Revision: https://phabricator.services.mozilla.com/D133690
2021-12-23 18:34:05 +00:00
ba04f10435
Bug 1539884 - Part 22: Mark nsXULElement::ClickWithInputSource as CAN_RUN_SCRIPT r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D134354
2021-12-23 16:27:20 +00:00
429a324f31
Bug 1539884 - Part 21: Mark nsIDOMXULCommandDispatcher::updateCommands as can_run_script r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D134353
2021-12-23 16:27:20 +00:00
70d14084ab
Backed out changeset 93b9da069dde (bug 1735076) for causing failures in browser_searchbar_openpopup.js CLOSED TREE
2021-12-21 21:53:42 +02:00
4a513d4585
Bug 1735076 - Use ProgrammaticFocusFlags from nsXULCommandDispatcher. r=smaug
...
Relevant calls are here:
https://searchfox.org/mozilla-central/rev/21a9b72545da06681db97c4b3a2a6be761f4aae5/toolkit/content/widgets/button.js#42-68
This makes sure to set the FLAG_BYKEY properly if needed, instead of passing
down raw flags to nsFocusManager. Clean up a bit while at it.
Let me know if you want a test for this, but we have tests for programmatic
focus and :focus-visible already, so my gut feeling is that testing this
particular XUL-specific change is not super-worth-it...
Differential Revision: https://phabricator.services.mozilla.com/D133690
2021-12-21 18:22:30 +00:00
d99a294a3b
Bug 1539884 - Part 20: Mark XULBroadcastManager::ExecuteOnBroadcastHandlerFor as CAN_RUN_SCRIPT r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D134111
2021-12-17 13:27:53 +00:00
b2c1e9bbef
Backed out changeset de1608e5f69b (bug 1735076) for causing failures at browser_searchbar_openpopup.js. CLOSED TREE
2021-12-14 07:29:46 +02:00
d3e3f44322
Bug 1735076 - Use ProgrammaticFocusFlags from nsXULCommandDispatcher. r=smaug
...
Relevant calls are here:
https://searchfox.org/mozilla-central/rev/21a9b72545da06681db97c4b3a2a6be761f4aae5/toolkit/content/widgets/button.js#42-68
This makes sure to set the FLAG_BYKEY properly if needed, instead of passing
down raw flags to nsFocusManager. Clean up a bit while at it.
Let me know if you want a test for this, but we have tests for programmatic
focus and :focus-visible already, so my gut feeling is that testing this
particular XUL-specific change is not super-worth-it...
Differential Revision: https://phabricator.services.mozilla.com/D133690
2021-12-14 00:24:22 +00:00
aa2665dace
Bug 1734098 - Part 1: Use consistent function name for off-thread stencil API. r=nbp
...
Make the stencil-based off-thread API names follow the convention:
* ...OffThread
* Finish...OffThread
* Cancel...OffThread
This patch stack adds more functions for module/decode, with the above naming
convention.
Differential Revision: https://phabricator.services.mozilla.com/D133042
2021-12-10 04:28:25 +00:00
777ce42897
Backed out 17 changesets (bug 1744178, bug 1734098) for causing leaks. CLOSED TREE
...
Backed out changeset 08070838c7d2 (bug 1734098)
Backed out changeset cfdf7ed9a5a2 (bug 1734098)
Backed out changeset 02d7ca7fc45c (bug 1734098)
Backed out changeset 7b7c59fc644b (bug 1734098)
Backed out changeset 630055366dac (bug 1734098)
Backed out changeset da83b4571cf2 (bug 1734098)
Backed out changeset 323af9d3e0e1 (bug 1734098)
Backed out changeset cf458ad5345a (bug 1734098)
Backed out changeset a85846f79eb5 (bug 1734098)
Backed out changeset 0d07931e6bc8 (bug 1734098)
Backed out changeset ffd72fa3fc59 (bug 1734098)
Backed out changeset 3174f1ecfd03 (bug 1734098)
Backed out changeset cfb19671fd4e (bug 1734098)
Backed out changeset c3b9c8221059 (bug 1734098)
Backed out changeset 532328aedaaa (bug 1734098)
Backed out changeset 48aa5ca15135 (bug 1734098)
Backed out changeset 6ca5bceb693c (bug 1744178)
2021-12-09 23:36:34 +02:00
1b6fc2f4b0
Bug 1734098 - Part 1: Use consistent function name for off-thread stencil API. r=nbp
...
Make the stencil-based off-thread API names follow the convention:
* ...OffThread
* Finish...OffThread
* Cancel...OffThread
This patch stack adds more functions for module/decode, with the above naming
convention.
Differential Revision: https://phabricator.services.mozilla.com/D133042
2021-12-09 18:21:09 +00:00
8e411675ac
Bug 1744877 - Remove --disable-xul. r=Gijs
...
Building with --disable-xul has been busted since _at least_ bug
1082579, for more than 7 years (I didn't try to track that down
further). It's time to recognize that the option serves no purpose.
Differential Revision: https://phabricator.services.mozilla.com/D133161
2021-12-08 21:37:11 +00:00
f6fdbf028a
Bug 1738401 - Remove -Wno-shadow warning suppressions. r=firefox-build-system-reviewers,glandium
...
-Wshadow warnings are not enabled globally, so these -Wno-shadow suppressions have no effect. I had intended to enable -Wshadow globally along with these suppressions in some directories (in bug 1272513), but that was blocked by other issues.
There are too many -Wshadow warnings (now over 2000) to realistically fix them all. We should remove all these unnecessary -Wno-shadow flags cluttering many moz.build files.
Differential Revision: https://phabricator.services.mozilla.com/D132289
2021-12-01 06:40:04 +00:00
d68f0e9684
Backed out changeset 5c921d8e51bd (bug 1741089) for causing mochitest failures on test_bug557987.xhtml . CLOSED TREE
2021-11-16 18:27:45 +02:00
3cf56f8e1f
Bug 1741089 - Make async OpenMenu simpler/sound. r=mstange
...
There's only one caller of it and it's not sound: The runnable captures a
raw frame pointer etc. Instead, just do a dispatch to the main thread
and call OpenMenu there. This simplifies the following patch.
Differential Revision: https://phabricator.services.mozilla.com/D131082
2021-11-16 15:43:38 +00:00
98b05fd89a
Bug 1586014- Factor out RecompileScriptEventListeners r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D129974
2021-11-04 18:24:58 +00:00
4341d6fb0c
Bug 1455514 - part 1: Add accessors and static helper methods to retrieve `nsINode` or its concrete classes from `EventTarget` r=smaug
...
Currently, checking whether an `EventTarget` is `nsINode` (or its concrete
classes) or not requires a QI, but it's expensive and used a lot while we
handle each event. Therefore, it'd be nicer for creating a virtual method,
`EventTarget::IsNode()` and use it for the check.
If trying to convert `EventTarget` to a concrete class, it may require two
virtual method calls. I'm not sure whether it's cheaper than a QI, but at
least, it won't depend on the UUID check order of `QueryInterface()` when
multiple interfaces are implemented.
Differential Revision: https://phabricator.services.mozilla.com/D129781
2021-11-02 13:03:43 +00:00
c30ad11d7f
Bug 1726498 - Add JS::DecodeOptions. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D128345
2021-10-21 21:48:48 +00:00
342914cc80
Bug 1732923 - Part 1: Remove options parameter from JS::EncodeStencil. r=tcampbell
...
Depends on D120201
Differential Revision: https://phabricator.services.mozilla.com/D128342
2021-10-21 00:14:21 +00:00
caecc321f6
Bug 1728953 - Remove unused flag from nsXULPrototypeCache. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D126321
2021-10-19 02:46:50 +00:00
0792d1689a
Bug 1720619 - Part 2: Add JS::InstantiateOptions. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D120201
2021-10-18 17:08:06 +00:00
9fbc18ca4c
Bug 1733384 - Make inert not modify the computed style. r=sefeng,layout-reviewers,jfkthame
...
Differential Revision: https://phabricator.services.mozilla.com/D127422
2021-10-07 17:00:36 +00:00
4d927c1fb4
Backed out 4 changesets (bug 1733384) for causing failures at browser_windowPrompt.js. CLOSED TREE
...
Backed out changeset fa609fadac26 (bug 1733384)
Backed out changeset dd1936d9fe17 (bug 1733384)
Backed out changeset 1a073e40ab1a (bug 1733384)
Backed out changeset 65708a4c708f (bug 1733384)
2021-10-07 17:52:51 +03:00
73805fe284
Bug 1734325 - Make the disable_xul_cache pref prevent chrome resources from getting cached. r=smaug
...
Do some drive-by clean-up, and remove telemetry for this since add-ons
can no longer tweak this pref.
Differential Revision: https://phabricator.services.mozilla.com/D127812
2021-10-07 13:29:00 +00:00
bfdd0fcc77
Bug 1733384 - Make inert not modify the computed style. r=sefeng,layout-reviewers,jfkthame
...
Differential Revision: https://phabricator.services.mozilla.com/D127422
2021-10-07 11:47:34 +00:00
aec5c5347b
Bug 1733034 - Fix unused*-variable warnings due to missing ifdefs. r=andi
...
dom/base/EventSource.cpp:59:22: error: unused variable 'gEventSourceLog' [-Werror,-Wunused-variable]
static LazyLogModule gEventSourceLog("EventSource");
^
dom/xul/nsXULCommandDispatcher.cpp:35:22: error: unused variable 'gCommandLog' [-Werror,-Wunused-variable]
static LazyLogModule gCommandLog("nsXULCommandDispatcher");
^
layout/generic/ScrollAnchorContainer.cpp:23:31: error: unused variable 'sAnchorLog' [-Werror,-Wunused-variable]
static mozilla::LazyLogModule sAnchorLog("scrollanchor");
^
memory/replace/phc/PHC.cpp:308:15: error: unused variable 'kAllocJunk' [-Werror,-Wunused-const-variable]
const uint8_t kAllocJunk = 0xe4;
^
Differential Revision: https://phabricator.services.mozilla.com/D126866
2021-09-29 21:44:49 +00:00
f263a1ae81
Bug 1718481 - Use stencil in nsXULPrototypeCache. r=tcampbell,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D121254
2021-09-21 03:18:02 +00:00
8957144a0f
Backed out 3 changesets (bug 1718194, bug 1718623, bug 1718481) for causing leaks. CLOSED TREE
...
Backed out changeset 1cd8bdf1fc92 (bug 1718481)
Backed out changeset aa56fe2c069d (bug 1718194)
Backed out changeset f7cb7313d1c7 (bug 1718623)
2021-09-18 15:47:45 +03:00
58155ebcca
Bug 1718481 - Use stencil in nsXULPrototypeCache. r=tcampbell,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D121254
2021-09-18 11:16:46 +00:00
ba00bd23b7
Bug 1729477 - Remove nsXULPrototypeCache::mStyleSheetTable. r=smaug
...
With a very simple tweak to SheetLoadDataHashKey::KeyEquals we should
get the same kind of caching but in a much simpler way.
Depends on D125450
Differential Revision: https://phabricator.services.mozilla.com/D124807
2021-09-14 10:43:49 +00:00
870ff4f480
Backed out 3 changesets (bug 1729477) for causing devtools failures in browser_webconsole_sidebar_object_expand_when_message_pruned. CLOSED TREE
...
Backed out changeset 8cbf3101ed8a (bug 1729477)
Backed out changeset 7457834fb7d0 (bug 1729477)
Backed out changeset 1259d2d1f247 (bug 1729477)
2021-09-09 03:55:31 +03:00
2b47e33bec
Bug 1729477 - Remove nsXULPrototypeCache::mStyleSheetTable. r=smaug
...
With a very simple tweak to SheetLoadDataHashKey::KeyEquals we should
get the same kind of caching but in a much simpler way.
Differential Revision: https://phabricator.services.mozilla.com/D124807
2021-09-08 21:03:02 +00:00
597b7bc37d
Bug 1729330 - Add a simple CSSLayerRule implementation. r=smaug
...
The specifics of how this is going to work are still getting spec'd /
discussed in https://github.com/w3c/csswg-drafts/issues/6576 , but this
allows DevTools to work fine and the feature to be complete enough for
Nightly experimentation (with the other in-flight patches).
Otherwise devtools crashes when trying to inspect pages that use them.
Differential Revision: https://phabricator.services.mozilla.com/D124656
2021-09-08 11:18:32 +00:00
957f603c7e
Bug 1708709 Use appunits for mScreenRect to avoid rounding errors, r=emilio
...
We have to use wayland to position popup windows and we need to propagate the modified
position (if happens) back to nsView. The mScreenRect in the nsMenuPopupFrame is in the CSS units
and that produce rounding error when font scale factor is not 1. To fix that we will use appunits
for the mScreenRect.
Differential Revision: https://phabricator.services.mozilla.com/D114577
2021-09-01 13:02:51 +00:00
250fa0d795
Bug 1725145 - header files fixes in the hybrid build env. r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D122343
2021-08-22 10:21:55 +00:00
0c022ef22d
Bug 1723010 - Part 2: Stop iterating to find next element for an accesskey once the accesskey has been processed; r=masayuki
...
even if the focus isn't changed.
Depends on D122787
Differential Revision: https://phabricator.services.mozilla.com/D122349
2021-08-20 19:32:43 +00:00
d90c0bb57f
Bug 1724718 - skip some XUL-y tests on android, r=emilio,agi
...
Depends on D122663
Differential Revision: https://phabricator.services.mozilla.com/D122664
2021-08-19 12:13:01 +00:00
121a8c8434
Backed out 2 changesets (bug 1723010) for causing mochitest failures on test_bug226361.xhtml. CLOSED TREE
...
Backed out changeset 62facfd599d0 (bug 1723010)
Backed out changeset 94c9836864cf (bug 1723010)
2021-08-18 16:10:07 +03:00
0ffb333fc3
Bug 1723010 - Part 2: Stop iterating to find next element for an accesskey once the accesskey has been processed; r=masayuki
...
even if the focus isn't changed.
Depends on D122787
Differential Revision: https://phabricator.services.mozilla.com/D122349
2021-08-18 09:12:51 +00:00
26533165c0
Bug 1719550 - Unify collator in nsXULSortService and nsXULContentUtils; r=platform-i18n-reviewers,nordzilla
...
Differential Revision: https://phabricator.services.mozilla.com/D121429
2021-08-10 16:01:17 +00:00
daed5248e2
Backed out 12 changesets (bug 1719550) for bustages on TestCollator.cpp . CLOSED TREE
...
Backed out changeset 3b2735a29138 (bug 1719550)
Backed out changeset 5e2019335244 (bug 1719550)
Backed out changeset 105676dd2d6f (bug 1719550)
Backed out changeset b4b0d58778e9 (bug 1719550)
Backed out changeset 3ef5792020bb (bug 1719550)
Backed out changeset 389a77da6ddc (bug 1719550)
Backed out changeset 48f39b5ef77f (bug 1719550)
Backed out changeset bd125cc5b9b4 (bug 1719550)
Backed out changeset a8b778ca2375 (bug 1719550)
Backed out changeset b14702168fb9 (bug 1719550)
Backed out changeset 7b46b5cc7424 (bug 1719550)
Backed out changeset 6b04162618a1 (bug 1719550)
2021-08-10 17:46:34 +03:00
0638fcc46b
Bug 1719550 - Unify collator in nsXULSortService and nsXULContentUtils; r=platform-i18n-reviewers,nordzilla
...
Differential Revision: https://phabricator.services.mozilla.com/D121429
2021-08-10 11:46:36 +00:00
ac80a98f45
Bug 1723050 - Part 36: Replace typedef by using in dom/xul/ r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D121334
2021-08-09 13:37:32 +00:00
de54c4e1fc
Bug 1718755 - Fix the SpecialPowers pref code to deal with ui / font prefs correctly after the previous change. r=kmag
...
This allows us to remove the timeout (which was there for these prefs)
and makes the code a bit more explicit.
Unconditionally making all tests wait for rAF causes some timing changes
which cause some tests to time out / fail, see:
https://treeherder.mozilla.org/jobs?repo=try&revision=3aef4c168c6ab7d762dd360f49d4f56dff686c03
So this only does it when changing the prefs that care about it. Fix
some tests that were relying on the timeout to get this green.
Differential Revision: https://phabricator.services.mozilla.com/D119040
2021-07-20 14:10:58 +00:00
433d514141
Backed out 4 changesets (bug 1718755) for causing Reftest failures. CLOSED TREE
...
Backed out changeset f2cc4fb3caa8 (bug 1718755)
Backed out changeset babc4fdcd08c (bug 1718755)
Backed out changeset 4566477a7075 (bug 1718755)
Backed out changeset 3cc5fcf9aeb6 (bug 1718755)
2021-07-14 18:36:32 +03:00
0d448eff03
Bug 1718755 - Fix the SpecialPowers pref code to deal with ui / font prefs correctly after the previous change. r=kmag
...
This allows us to remove the timeout (which was there for these prefs)
and makes the code a bit more explicit.
Unconditionally making all tests wait for rAF causes some timing changes
which cause some tests to time out / fail, see:
https://treeherder.mozilla.org/jobs?repo=try&revision=3aef4c168c6ab7d762dd360f49d4f56dff686c03
So this only does it when changing the prefs that care about it. Fix
some tests that were relying on the timeout to get this green.
Differential Revision: https://phabricator.services.mozilla.com/D119040
2021-07-14 11:29:25 +00:00
29ef20bdea
Bug 1717680, remove places where document.popupNode and document.tooltipNode are checked within tests, as these checks are no longer needed, r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D118518
2021-07-09 11:51:12 +00:00
320d01b1d8
Backed out 2 changesets (bug 1718755) for causing build bustages. CLOSED TREE DONTBUILD
...
Backed out changeset eae7bcfd58c9 (bug 1718755)
Backed out changeset 6ad9e60bc38e (bug 1718755)
2021-07-08 12:55:09 +03:00
Emilio Cobos Álvarez
Kagami Sascha Rosylight
Noemi Erli
Butkovits Atila
Tooru Fujisawa
Iulian Moraru
Mike Hommey
Chris Peterson
criss
somdatta
Masayuki Nakano
Sandor Molnar
stransky
Andi-Bogdan Postelnicu
Edgar Chen
Gijs Kruitbosch
Greg Tatum
Narcis Beleuzu
Neil Deakin