Automatic update from web-platform-tests
[text-spacing-trim] Remove redundant copying of variants to links
As a minor follow to crrev.com/c/4886653, it turned out that
wpt variants automatically adds the variants to ref links as
well, so copying to href links isn't necessary. This patch
removes that.
crbug.com/1486901 has some info from the investigation.
This patch has no behavior changes.
Bug: 1463891
Change-Id: Ie60fc6343491e751faa833dfcf5e07cefdd0155d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4891235
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201933}
--
wpt-commits: d779550315973f57967a8bb019722934adde82d5
wpt-pr: 42195
Automatic update from web-platform-tests
Never break before a float resumed after a break.
Always process all incoming inline break tokens that establish a
parallel flow for a fragmented float or overflowed block-in-inline.
The orphans implementation works so that if we run out of space in a
fragmentainer, we'll still keep on laying out a few more lines, to
figure out if we should break further up (rather than exactly where we
run out of space), in order to honor widows. We count the number of
lines laid out. The fix is to make sure that inline break tokens that
just contain a resumed float or block-in-inline (in a parallel flow)
leave this counter alone. Otherwise we risk breaking before even getting
around to resuming the block node inside, which means that it wouldn't
be added to the fragment tree at all.
Add DCHECKs after layout of a block to make sure that we don't break at
a location where we'll be unable to resume correctly. This also includes
DCHECKing block break tokens, not just inline break tokens. There are no
known issues for block layout ending up in this state, but it would be
equally bad if it happens.
This also fixes a correctness issue that was introduced by CL:4874801.
Counting resumed floats as line boxes for orphans / widows consideration
caused us to break prematurely in some cases. If this premature break is
before an actual line box, we get a correctness issue (breaking too
soon). If this premature break is before a resumed float, the fragment
tree would be in a bad state, which could lead to crashes.
Add a test for both a crash and the correctness issue.
Bug: 1486252
Change-Id: I764c12e01540f7ceb437fb4aca787c9424ddfa48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4891832
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201849}
--
wpt-commits: af15aec4a7076fbd08c08c989a27d690faa5a4d5
wpt-pr: 42189
Automatic update from web-platform-tests
Inherit -webkit-user-modify when the element assigned slot but without the contenteditable attribute specified
If an element is assigned slot element and when it is editable
but the parent element is non-editable,
-webkit-user-modify will change to kReadOnly.
It changed the element to non-editable.
For example, consider this test case:
<details>
<div contenteditable="true">editable</div>
</details>
The element without the contenteditable attribute specified
should inherit -webkit-user-modify.
Bug: 1484447
Change-Id: Ieb4ff23d8819e8ddef03b11775127f070fdd8cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4885769
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201843}
--
wpt-commits: 05fc184cc9607d866464e950aee6d17e6227eb97
wpt-pr: 42113
Automatic update from web-platform-tests
Enable block until head for eager prefetches by default.
This CL enables the block_until_head_eager_prefetch param by default and
sets the default value of block_until_head_timeout_eager_prefetch to
1000 milliseconds.
Bug: 1464011
Change-Id: I77cc7d6d8ed3229aeb8b5b79a619d898c47796f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4892508
Commit-Queue: Max Curran <curranmax@chromium.org>
Reviewed-by: Liviu Tinta <liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201756}
--
wpt-commits: ad393edbd0e26eb3e73643d04e127ac84e466181
wpt-pr: 42188
Automatic update from web-platform-tests
[text-spacing-trim] Add tests for vertical flow and `chws` fonts
This patch adds wpt variants for:
* Fonts with `halt` only and fonts with `chws` and `halt`.
* Horizontal flow and vertical flow.
Removes `text-spacing-trim-chws-001.html` as it is now
covered by the `class=chws` variant.
Note, ref tests having wpt variants had an issue but now
crbug.com/1485860 was fixed.
This patch has no behavior changes.
Bug: 1463891
Change-Id: I6c66c9fef7f0a3d557e06f315da909ef6ab7b349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4886653
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201639}
--
wpt-commits: d64f55daffaf7ad0e8cd041ddcfecffb8c7afaaf
wpt-pr: 42178
Automatic update from web-platform-tests
Deflake overscroll-delta test
This test is flaking with failures because the max overscroll delta seen
is less than the (arbitrarily chosen) expected value.
This could be because we only wait for the first overscroll event seen
(overscroll events report a running total of the delta) before
continuing with the test.
Instead we can ensure that we wait for an overscroll event with a
sufficiently large accumulated overscroll delta.
Bug: 1430215
Change-Id: Iacf5b59018aecab966a6d48a00e0cba984cfe2a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4892667
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: David Awogbemila <awogbemila@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201565}
--
wpt-commits: ca555d3b2d50a43eedc85d8f5866ac1de4072caa
wpt-pr: 42162
Automatic update from web-platform-tests
[text-spacing-trim] Parse the CSS `text-spacing-trim` property
This patch implements the CSS parser for the CSS
`text-spacing-trim` property.
This initial implementation supports a subset of values
defined in the spec[1]:
```
text-spacing-trim: space-first | space-all
```
This patch has no behavior changes as all changes are under a
runtime flag.
[1] https://drafts.csswg.org/css-text-4/#text-spacing-trim-property
Bug: 1463891
Change-Id: Ib516614a0759616ac763dc8a23ce86339e57e94b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4891290
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201506}
--
wpt-commits: 447096fe20486b9d02dae8f117111039b00887a3
wpt-pr: 42163
Automatic update from web-platform-tests
[css-properties-values-api] Make empty universal custom props valid
In CustomProperty::ApplyValue, we parse the specified token sequence
(in this case an empty sequence), against the registered grammar
(in this case the universal syntax), and ultimately we call
CSSVariableParser::ParseVariableReferenceValue, to "parse" this
empty token sequence. ParseVariableReferenceValue had an incorrect
check on empty ranges - likely a remnant of the old spec, which did
not allow empty values.
Fixed: 1485804
Change-Id: I13ba8d9196c50a5a74c5991e2fec4c961b6a0c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4890262
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201429}
--
wpt-commits: b956706efa6bc6a637b4de8bbc001da4fe9fef9c
wpt-pr: 42159
Automatic update from web-platform-tests
Implement form-sizing behavior for <select>
* Drop down:
The width depends on the selected OPTION label, instead of the maximum
width of all OPTION labels.
* List box:
The height depends on the total height of OPTION labels, instead of
the 'size' attribute value.
They have zero content height if there are no OPTIONs.
Bug: 1447058
Change-Id: I16cfb423a8caa776e2c6df1b0bd1bf82413c1447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4893426
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201354}
--
wpt-commits: 04bf14e2cbd9eb6b060fa3aa552a6136ece25e46
wpt-pr: 42176
Automatic update from web-platform-tests
[WebCodecs] Improve spec compliance for configure() handling.
Per spec we need to transition into the configured state before
we handle unsupported config checking. In order to make a configure
followed by flush() consistent with respect to NotSupportedError
handling, we now always post when the config isn't supported.
R=sandersd
Bug: 1412203
Change-Id: I9d408c5984222bf7211b3a4ed516e3f309ed2c9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4887543
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201261}
--
wpt-commits: d84f1a300c18c2021f8bb7c888c2389ddaab3298
wpt-pr: 42127
Automatic update from web-platform-tests
Add fuzzy-match for some css/selectors/dir-style-*.html test
Some wpt/css/selectors/dir-style-*.html tests are flaky due to small
pixel differences [1].
Tests dir-style-01a.html and dir-style-01b.html have:
- maxDifference: 64
- totalPixels: 24
Test dir-style-04.html have (due to two text mismatch on the same line):
- maxDifference: 64
- totalPixels: 174
[1] https://wpt.fyi/results/css/selectors?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=dir-style%20chrome%3Afail
Change-Id: I0c7d4203c1cb1baaad7958fcb8b521a44e246970
Bug: 576815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4887408
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201213}
--
wpt-commits: 957d32b7214eace6a8ae012d818529ead6033924
wpt-pr: 42128
Automatic update from web-platform-tests
May break before float, but still fit subsequent in-flow content.
It is possible for a float to be pushed to the next fragmentainer, while
still fitting subsequent in-flow content in the current fragmentainer.
Therefore, keep looking for content inside a culled inline, even if
we've found a float that belongs in a later fragmentainer.
This is similar to how a float may be pushed below the current line if
it doesn't fit beside it, while still laying out items that come after
it DOM-tree-wise, on the same line. A float may be pushed to the next
fragmentainer if it doesn't fit in the current one. But there may still
be room for plenty of in-flow lines in the current fragmentainer.
Bug: 1486411
Change-Id: Ic935dc9655d628ce33d2c5a0f20369ef5eba590f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4891619
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201198}
--
wpt-commits: f6b30e57b0af46515a6b2988873b1d30ec25eaee
wpt-pr: 42164
Automatic update from web-platform-tests
Switch RuleMap to a custom hash table.
A significant part of style (~6%) is doing lookups in RuleMaps,
specifically in AtomicString-indexed hash tables. These currently
use WTF::HashTable, but we can do better with a custom
hash table implementation. Thus, we implement RobinHoodMap,
a lookup-optimized variant with higher load factor and thus
tighter memory footprint.
One direct consequence of this is less RAM usage; e.g. Social1
reports ~460 kB less PartitionAlloc memory allocated (most subtests
have smaller hash tables, though, since they have fewer rules).
But we also get less cache pressure. The exact result depends
on the CPU; smaller/slower caches give more gains, less sophisticated
branch predictors give less gains. In general, most seem to be
around neutral, but Intel CPUs give a fairly good gain. Inserts
are slightly slower and lookups are faster, so repeated style
application should get larger gains. Of course, in the style
perftest, we have the cache all to ourselves, so it will tend to
underestimate these effects somewhat.
Style perftest (Alder Lake P-cores, LTO but no PGO):
Initial style (µs) Before After Perf 95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce 4491 4484 +0.1% [ -0.6%, +0.8%]
Encyclopedia 40679 39868 +2.0% [ +1.1%, +2.9%]
Extension 53970 53971 -0.0% [ -0.8%, +0.7%]
News 19728 19325 +2.1% [ +0.9%, +3.2%]
Search 6316 6176 +2.3% [ +1.1%, +3.4%]
Social1 11547 11753 -1.8% [ -2.8%, -0.7%]
Social2 7383 7281 +1.4% [ +0.4%, +2.3%]
Sports 20644 20580 +0.3% [ -0.8%, +1.4%]
Video 16020 16064 -0.3% [ -1.1%, +0.5%]
Geometric mean +0.7% [ +0.1%, +1.2%]
Recalc style (µs) Before After Perf 95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce 5011 4958 +1.1% [ +0.3%, +1.8%]
Encyclopedia 32407 31336 +3.4% [ +2.6%, +4.3%]
Extension 49217 48970 +0.5% [ -0.3%, +1.2%]
News 15065 14569 +3.4% [ +2.3%, +4.4%]
Search 2911 2771 +5.0% [ +4.3%, +5.9%]
Social1 7417 7271 +2.0% [ +0.8%, +3.0%]
Social2 5634 5548 +1.5% [ +0.6%, +2.4%]
Sports 11345 11040 +2.8% [ +1.9%, +3.6%]
Video 10659 10381 +2.7% [ +1.8%, +3.6%]
Geometric mean +2.5% [ +1.9%, +3.0%]
Change-Id: I3b25f24d0595b21ad5d5e354e2c03a390bddc5aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4866725
Commit-Queue: Steinar H Gunderson <sesse@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200933}
--
wpt-commits: 5e3b0aa36d05e39f840e2725fe9d9e9bc654c578
wpt-pr: 42158
Automatic update from web-platform-tests
Don't store nullptrs for custom highlight styles
A recent change for @container-dependent highlight styles assumed the
stored ComputedStyle for a custom highlight was non-null. Make sure we
erase entries instead of add nullptrs to the hash map.
Bug: 1486352
Change-Id: I367f5478a0199e36b078783f41d391e473f07459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4886524
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200904}
--
wpt-commits: 2bfefba96c77956d1f5297bf2322fffbb2676949
wpt-pr: 42155
Automatic update from web-platform-tests
Test more CSS properties in all-prop-revert-layer.html
Turns out that baseline-source is broken on Blink
--
wpt-commits: d98e3d3206922941b5c647d8c0999b77bf381948
wpt-pr: 42130
Automatic update from web-platform-tests
[text-spacing-trim] Use `HarfBuzzShaper` to get glyph IDs
This patch changes `EastAsianSpacing` to use `HarfBuzzShaper`
when getting glyph IDs.
Some fonts, such as "Noto CJK", supports multiple locales by a
single font file. When different glyphs are needed by
different locale, they use encoding (`cmap`) and/or OpenType
features such as `calt` to substitute glyphs.
Finding the correct glyph IDs for such fonts requires shaping,
which is not possible with `GlyphForCharacter`.
This patch has no behavior changes as all changes are under a
runtime flag.
Bug: 1463891
Change-Id: Ib459a9d937adb14179aea6b3ab821445c10760d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4885939
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200817}
--
wpt-commits: 20151fb1d83737eb1b41edd4909917a8b693f273
wpt-pr: 42143
Automatic update from web-platform-tests
gardening: Reduce flakiness of observe-animated-image-webp
Increase the allowable time delay in order to reduce the flakiness
due to time out.
Change-Id: Ieb0168307d6b574ec57b0c2e307492a45f93b345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4886038
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Auto-Submit: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200806}
--
wpt-commits: 73d687d129ddee03fcf6680298269cc8747fcc36
wpt-pr: 42145
Automatic update from web-platform-tests
Deflake LoAf test: protect from spurious pointer events
Instead of failing test when UI event timing is wrong,
treat it as a non-matching entry so that the test can
be retried.
Bug: 1469164
Change-Id: I270efd34d9f27d8dafe36353e00e9b56f4446bd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4889915
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200805}
--
wpt-commits: 179c6c0821944a20a9097950852a132d3ce1fe5d
wpt-pr: 42140
Automatic update from web-platform-tests
LoAF test: reduce time to wait for "no LoAF"
Some tests abort because the timeout is too long,
so reduce it.
Bug: 1462683
Change-Id: Id071f6eb66f002cc60ebacc5eaa9c1fd8b21275c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4890255
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200804}
--
wpt-commits: dd5314313a8f3cadb11ceadeabd2280546fce970
wpt-pr: 42141
Automatic update from web-platform-tests
[text-spacing-trim] Move Noto CJK to `/wpt/fonts`
This patch moves Noto CJK fonts for testing to `/wpt/fonts`
so that they can be used by other tests.
This allows Chromium unit tests to use these fonts too.
Bug: 1463891
Change-Id: Ibc38a65335643c8fa61b71819b61728f28d5aeb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4886656
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200768}
--
wpt-commits: c2504f4062db9bed36540e28c49caae3e4fd873c
wpt-pr: 42134
Automatic update from web-platform-tests
Update fuzzy data for mask-image-3h.html (#42135)
--
wpt-commits: c21bb1fd1a7793e2e684225d7c0ade42bdba9bdf
wpt-pr: 42135
Automatic update from web-platform-tests
Tweak more css-masking fuzzy data (#42133)
--
wpt-commits: f74bbb3cd736b68504cb5a2fe98e512ecf14b3d3
wpt-pr: 42133
Automatic update from web-platform-tests
Add fuzzy data for mask-image-2.html (#42132)
--
wpt-commits: 6af37d2cde5d88232346ed98c9c6167f35e1ebe0
wpt-pr: 42132
Automatic update from web-platform-tests
Adjust fuzzy data for css-masking tests for Safari (#42131)
--
wpt-commits: 31e482d2d9fd4ee12d6f8edc7212a226252e276c
wpt-pr: 42131
Automatic update from web-platform-tests
[Clipboard API] Removing substring of unsanitized HTML payload
Previously, for unsanitized HTML, we returned the payload between the start and end fragment tags, using the `fragment_start` and `fragment_end` values. However, other applications can have important information that directly affects the payload outside of the fragment tags, so in this CL the substring is removed from the original payload read from the clipboard.
Bug: 1469425
Change-Id: Id75848739c9ed9d2e00de29ef8d8161f8b5731ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4779949
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1200494}
--
wpt-commits: 8891ea83bc7383fb0fd5bf916b565b050c0368b1
wpt-pr: 42114
Automatic update from web-platform-tests
Fix <source> version of the media-src-7_2_2.sub.html test.
<source> elements can't be changed retroactively like the test was
doing. The media element would sometimes start the load and fail
since the source had no content. Instead add the <source> node in
one go.
Fixed: 1484341
Change-Id: I0e2c53fedcee121d59563d140d4d82793fcba5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4883970
Reviewed-by: Jonathan Hao <phao@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200339}
--
wpt-commits: f3b2a3dbd7052b19a8bed15eea85e4b768364cee
wpt-pr: 42106
Automatic update from web-platform-tests
WebKit export: [user-activation] User activation should be triggered on certain events (#42118)
https://bugs.webkit.org/show_bug.cgi?id=259028
--
wpt-commits: 3207ea2010d8bc98e917615d5466e904eb0bcb03
wpt-pr: 42118
Automatic update from web-platform-tests
Add more content-visibility animation tests (#42124)
From https://bugs.webkit.org/show_bug.cgi?id=223930:
- a test for the generic behaviour of content-visibility: auto and animations.
- a reftest testing animations are restarted once a hidden content-visibility: auto subtree is scrolled to.
- a reftest testing animations are restarted once a hidden content-visibility: auto subtree becomes visible.
--
wpt-commits: 998a2102647e79e073c33494ff9903e0dc4c0b5e
wpt-pr: 42124
Automatic update from web-platform-tests
Speculative deflake of animation-inactive-outside-range
When flaking on a Mac, the ref image is wrong suggesting that the
screenshot is being taken too soon.
When flaking on Linux, an indicator light is incorrectly on in the
actual image.
The speculative fix, moves waitForComspoitorReady to the start of the
test and ref image so that all scrolling occurs after the first
contentful paint. The ref test now uses a wait to ensure completion of
the scroll (which happens on the compositor thread in some virtual
test suites.
Zero flakes in 500 runs on Linux. Do not have a Mac for testing.
Bug: 1481709
Change-Id: Ide770de6fe6aeba53339ae068e962159b47d2ea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4873591
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200264}
--
wpt-commits: 25db752041da9c00547f10e1357d617ad44c220e
wpt-pr: 42064
Automatic update from web-platform-tests
Fix animation timelines test
The subtest for ensuring a microtask checkpoint is run had an
incorrect assumption about when the animation would be ready, which
is under UA control. In Chrome, it is ready prior to commit in the
current frame, whereas in Firefox, it appears to be ready in the next
animation frame.
Per spec, the checkpoint is to be run as part of the timeline update
procedure. Fixed by actually queuing up a microtask in the ready
promise and ensuring that it is run in the same animation-frame as the
next timeline update.
Verified fix on Chrome and Firefox with multiple runs.
Bug: 898176
Change-Id: I4f742b9eea3c4e8447fe30f60628cb560f184f15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4879640
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200226}
--
wpt-commits: 7b4d901b13d1a1eeaed983aa921727c1f1320c2b
wpt-pr: 42090
moz-wptsync-bot
Koji Ishii
Andrew Kaster
Morten Stenshorne
zhoupeng
Max Curran
David Awogbemila
Anders Hartvoll Ruud
Kent Tamura
Dale Curtis
Di Zhang
Sam Sneddon
Steinar H. Gunderson
JannisBush
Rune Lillesveen
Oriol Brufau
Noam Rosenthal
Yuki Shiino
Tim Nguyen
Ana SollanoKim
Dan Sanders
Abrar Rahman Protyasha
Rob Buis
Kevin Ellis