Corrected order of wrappers.
Updated container to #absoluteControls, and used a single querySelector for #overlayCaption innerText.
Differential Revision: https://phabricator.services.mozilla.com/D143441
Previously, AsyncImagePipelineManager::UpdateImageKeys did not check bit depth when updating image keys, and WebRenderTextureHost did not correctly wrap GetColorDepth(). This caused the configuration not to correctly update.
Differential Revision: https://phabricator.services.mozilla.com/D143558
GeckoView expects string for "cc-exp-month" and "cc-exp-year", however, the `createNormalizedRecord`
method added in bug 1760834 while submitting a cc form, might change the value from string to number.
Differential Revision: https://phabricator.services.mozilla.com/D143535
D3D9 hardware decoding detection was failing due to a change to provide DXVA2Manager::SupportsConfig with information about the compressed video format. Provide both input and output media types to allow it to correctly determine support.
Changed WMFVideoMFTManager logging to log when DXVA initialization fails for D3D11 but succeeds for D3D9.
Differential Revision: https://phabricator.services.mozilla.com/D143505
The `upload_geneated_sources.py` script needs `boto3`, but was:
* Running in CI with Mach having a site-packages-source of `None`
* Using the `common` site (which inherits Mach's site-packages-source)
* Installing `boto3` outside of the knowledge of the centralized
dependency system.
Make a `upload-generated-sources` site, and move `boto3` to it.
Differential Revision: https://phabricator.services.mozilla.com/D143715
We were importing a module that was previously imported into wpt.run, but isn't
any longer. Directly import the relevant module instead.
Differential Revision: https://phabricator.services.mozilla.com/D143592
We need to clear state at shutdown that we hold for GIFFT mirroring purposes.
However, more data can come in even later (there's nothing stopping it. Plus,
Glean can meaningfully record later given its shutdown happens in a later
phase), so the naive approach of lazy-instantiate and RunOnShutdown-clear
doesn't work.
Since Telemetry is only good to AppShutdownTelemetry, we now fail to mirror to
it after AppShutdownTelemetry and clear state in the immediately-next phase.
Also, data can come in earlier than we have a main thread to dispatch to,
requiring some careful finagling of threads to ensure our cleanup routine
is appropriately registered.
Differential Revision: https://phabricator.services.mozilla.com/D143522
Previously, tuple_with() declared the following pointer to its tuple
argument's elements:
HeapSlotArray t = tuple->getDenseElements();
Because this wasn't rooted, incremental GC could cause t to be used
after freeing. Since t was only used twice, I inlined it to solve this
problem.
Differential Revision: https://phabricator.services.mozilla.com/D143309
Most builtin objects are disallowed nowadays so we don't need to check these
and we can the special cases related to the size of JSFunction.
Depends on D143477
Differential Revision: https://phabricator.services.mozilla.com/D143478
I'm not sure how much this comes up in practice but swapping objects with
dictionary mode slots has been broken since the dictionary mode slot span was
moved to the slots header from the shape. The fix is to use the length of the
values vector in NativeObject::fillInAfterSwap.
Depends on D143476
Differential Revision: https://phabricator.services.mozilla.com/D143477
We can get an assertion failure from the memory tracking code if we try
associate swapped dynamic slots with an object before remving the memory for
its previous dynamic slots. The fix is to remove associations for both objects
first before adding the new ones.
This is only an assertion failure and has no consequence in release builds.
Differential Revision: https://phabricator.services.mozilla.com/D143476
`GetIndexOfArgument()` doesn't yet support `CallFlags::FunCall`, so when we inline
the Array constructor through `Function.prototype.call`, use `CallFlags::Standard`
instead.
This is the only place where `CallFlags::FunCall` can be passed through to
`GetIndexOfArgument()`.
Changing `GetIndexOfArgument()` to support `CallFlags::FunCall` isn't straight
forward, because the argument indices are different depending on whether or not
this is an inlined or non-inlined `Function.prototype.call`.
Differential Revision: https://phabricator.services.mozilla.com/D143712
We use mDragPopup to visualize D&D operation. When previous D&D operation is not finished and new one is started, emulate what internal Gtk routine gtk_drag_remove_icon() does
and remove mDragPopup from the previous D&D context to avoid Gtk confusion.
Differential Revision: https://phabricator.services.mozilla.com/D143595
Add faviconDataUrl and imagePageUrl to each Snapshot Group so the companion can
directly use these instead of a polyfill for faviconImage and url.
Also change favicon service APIs to respect mDefaultIconURIPreferredSize instead
of always returning the largest icon. This allows to use those APIs more easily
from jsm modules without having to pass around window handles.
Differential Revision: https://phabricator.services.mozilla.com/D143462
I wasn't able to retrieve the original STR this condition was preventing, but
removing it and using various highlighters (box model, flex, grid, …) in the browser
toolbox, targetting various documents, I didnt' see any error.
Most importantly, it allowed to show highlighters where it wasn't possible before
(e.g. grid highlighter for webconsole document).
TRY don't show any breakage either.
Differential Revision: https://phabricator.services.mozilla.com/D143571
The MachineState class became pretty large, especially on ARM64 it was about 1 KB due
to the large number of (float) registers.
This patch fixes that by refactoring MachineState to store a pointer to the register
dumps (for bailouts) or the register sets + spill location (for safepoints).
This lets us recover the register address when we want to read/write it.
Differential Revision: https://phabricator.services.mozilla.com/D143588