9c4215a1fb
Bug 1271701 - Make about:cache channels cancelable. r=michal
2016-05-12 10:19:00 -04:00
353ee65255
Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium
2016-05-11 00:00:01 -07:00
a8542b6e9c
Bug 1267195 - Correctly update HTTP cache size in UI only after we actually clear the cache. r=michal
2016-05-12 07:57:00 -04:00
d9981dcb53
Bug 1271019 - Don't call on nsIURI on non-main threads from HTTP cache back end. r=michal
2016-05-12 06:38:00 -04:00
ef6eda1f63
Bug 1267980 - Leak buffers in CacheFileChunk and CacheFileMetadata during shutdown, r=honzab
2016-05-11 11:46:54 +02:00
04256ec318
Bug 1253883 - Do not release mRWBuf until pending read/write operation finishes, r=honzab
2016-05-11 10:48:28 +02:00
08c711b5df
Bug 1263197 - part 1 - use temporary variables in CacheIndex logging; r=michal.novotny
...
Using temporary variables here makes the code a bit clearer by not
repeating the readUint32 call. A temporary variable also avoids the
compiler complaining about not using the result of readUint32 (which is
a MOZ_MUST_USE function) for the upcoming logging disabling patch.
2016-05-06 09:11:17 -04:00
941ab1f522
Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj
2016-05-05 01:45:00 -07:00
4282b4dba0
Bug 1268922 - Limit number of tries to find unused trash directory, r=honzab
2016-05-02 19:58:58 +02:00
5a9074a7ca
Bug 1268922 - Don't insist on removal of cache2/doomed directory, causing cache responsiveness slowdown, r=michal
2016-04-30 14:24:20 +02:00
ba3fe0975c
Backed out changeset 85ce8cb0639a (bug 1268313)
...
--HG--
extra : rebase_source : 56d1cf41a2dc4959b67f834e07192a5c772176a8
2016-04-29 14:21:16 +02:00
2511b2c327
Bug 1267550 (part 2) - Rename MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. r=froydnj.
...
It's an annotation that is used a lot, and should be used even more, so a
shorter name is better.
MozReview-Commit-ID: 1VS4Dney4WX
--HG--
extra : rebase_source : b26919c1b0fcb32e5339adeef5be5becae6032cf
2016-04-27 14:16:50 +10:00
48a594a09e
Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj
2016-04-28 14:08:25 -07:00
c73656947b
Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj
2016-04-25 17:23:21 -07:00
fd7a5d97b5
Bug 1016628 - Add prefetch abilities to the predictor. r=mayhemer
2016-04-21 12:32:30 -07:00
03ed0becb2
Bug 1265243 - Do not initialize CacheObserver in the child process, r=honzab
2016-04-20 11:29:50 +02:00
3e05444c44
Bug 1253040 - Do not write metadata if CacheFile is killed, r=honzab
2016-04-17 16:23:49 +02:00
de75162c69
Bug 1066970 - Show 'calculating' during HTTP cache cleaning process in preferences window, r=michal
2016-04-05 05:59:00 +02:00
36eaa1d10d
Bug 1257611 - Fix wrong CondVar::Wait() and Monitor::Wait() usage in netwerk/cache2, r=honzab
2016-03-21 16:51:58 +01:00
96a413ffed
Bug 1248915 - TSan: data race on global 'mozilla::net::CacheObserver::sDiskCacheCapacity'. r=honzab.moz, n.nethercote.
2016-03-20 10:08:57 +01:00
64e57a04ef
Backed out changeset 1ff643f2c358 (bug 1251130). r=backout
2016-03-11 12:55:15 +01:00
a226a7c588
Bug 1251130 - null out CacheFileIOManager::gInstance in CacheFileIOManager::ShutdownInternal() to prevent doing shutdown procedure multiple times, r=honzab
2016-03-09 16:50:16 +01:00
7000ea35bd
Bug 1253094, part 6 - Stop using DebugOnly for class/struct members in netwerk/. r=mayhemer
...
MozReview-Commit-ID: Ab9bM9WI2uD
2016-02-26 15:52:07 +00:00
2a55d065b7
Bug 1238160 - Rename OriginAttributes.mInBrowser and associated methods. r=bz,mayhemer
...
This change renames OriginAttributes.mInBrowser to mInIsolatedMozBrowser and
nsIPrincipal::GetIsInBrowserElement to GetIsInIsolatedMozBrowserElement. Other
methods that pass these values around also have name changes.
Tokens such as "inBrowser" have previously been serialized into cache keys, used
as DB column names, stored in app registries, etc. No changes are made to any
serialization formats. Only runtime method and variable names are updated.
No behavior changes are made in this patch, so some renamed methods may have
nonsensical implementations. These are corrected in subsequent patches
focused on behavior.
MozReview-Commit-ID: 66HfMlsXFLs
2016-03-02 10:35:56 -06:00
3de845aa19
Bug 1251253 - prevent null pointer dereference of |aContext| in CacheStorageService::DoomStorageEntries. r=mayhemer
...
MozReview-Commit-ID: BmXXg4eW25n
--HG--
extra : rebase_source : 35ca2824ebdd618fef7b6de4858de8214571f466
2016-02-25 20:41:52 +02:00
f6e228e9d3
Bug 1247644 - Don't do any I/O on doomed and unused HTTP cache entries, r=michal
2016-02-12 14:45:00 +01:00
68a7636bf1
Bug 1050613 - Make sure force-valid for HTTP cache entries is removed when entries are removed, r=michal
2016-02-19 11:56:00 +01:00
fd14c17712
Bug 1247432 - Don't do any unnecessary I/O in cache2 after shutdown. r=michal
2016-02-12 09:36:00 -05:00
83b2b79f9d
Bug 1248958 - CacheIndex mRWBuf ownership too fragile, read-after-free, r=honzab
2016-02-18 11:43:20 +01:00
581cd94d0a
Bug 1248003 - Purge from HTTP cache memory pool only in reasonable intervals, r=michal
2016-02-15 11:45:00 +01:00
5546f7149d
Bug 1248389 - Cache index causing CPU loops, r=honzab
2016-02-17 11:47:47 +01:00
913ed1d7ab
Bug 1248558 - "[Static Analysis][Unintentional integer overflow][CacheFile.cpp::PreloadChunk, CacheFile.cpp::GetChunkLocked]". r=michal
...
--HG--
extra : rebase_source : a13923fa1d2618f7a00363b17e3a8f9bf090e89f
2016-02-16 04:29:00 +01:00
6d91654914
Backed out changeset 9d5fa6d7558a (bug 1247432) for being a possible cause of the spike in ASAN test_browserElement_oop_getWebManifest.html failures
...
--HG--
extra : commitid : 1NKaYZHHXip
extra : rebase_source : 4f280016d0e7c767eca959d428a6978397514840
2016-02-16 16:40:43 -08:00
b081be5e55
Bug 1247432 - Don't do any unnecessary I/O in cache2 after shutdown, r=michal
2016-02-12 09:36:00 +01:00
686438c658
Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley
2016-02-10 08:23:00 +01:00
5b358688b7
Backed out changeset c18e29c1b369 (bug 1164581) for cpp unit tests test failures
...
--HG--
extra : rebase_source : fb6fd434c8e3f4b5fa53ea645a54c07cab207894
2016-02-08 11:17:38 +01:00
69cf7e035f
Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley
...
--HG--
extra : rebase_source : 3c6bba6613a14e48239d302bdd0f7fe2e322265d
2016-02-07 10:56:00 +01:00
2f4a4aa980
Bug 1244122 P1 Always support SW intercept even when http cache is disabled. r=mayhemer
2016-02-02 10:03:20 -08:00
5bf2bbbbee
Back out 2 changesets (bug 1244122) for a 50% failure rate in (at least) 10.6 e10s browser_force_refresh.js
...
Backed out changeset d383f170be3f (bug 1244122)
Backed out changeset b1eacad41db4 (bug 1244122)
2016-02-01 19:53:55 -08:00
273bea9bb6
Bug 1244122 P1 Always support SW intercept even when http cache is disabled. r=mayhemer
2016-02-01 12:29:40 -08:00
093d2c50de
Bug 1211941 - Let nsICacheStorage.openTruncate impl return an HTTP cache entry write handle, r=michal
2016-01-12 07:31:00 +01:00
92816b2543
Bug 1154124 - Prevent recursion when calling HTTP cache entry's callbacks. r=michal
2016-01-14 21:16:06 +01:00
d36e6cf36c
Bug 1165256 - Make appcache fully work with OriginAttribues. r=jduell
2016-01-18 20:20:08 +01:00
e3cd93ce31
Bug 1239687 - Leak invalid/doomed file handles immediately after HTTP cache shutdown. r=michal
...
--HG--
extra : rebase_source : fbf0ddf9489b83e60bbfe09f19d9dd2ffdc16629
2016-01-14 08:14:00 +01:00
a170797259
Bug 1220272 - Fix signalling in HTTP cache test code suspender. r=michal
2016-01-14 11:24:00 +01:00
6e283f1e37
Bug 913822 - Shutdown I/O time limit for HTTP cache. r=michal
2016-01-13 16:11:00 -05:00
6bbabfc4b2
Bug 1121672 - Make CacheFile::IsDoomed() protect mHandle with lock, r=michal
2016-01-12 09:24:00 +01:00
7ed406b2be
Bug 1238290 - fix bad necko deps on unified_sources r=valentin.gosu
...
---
netwerk/base/ARefBase.h | 2 ++
netwerk/base/CaptivePortalService.cpp | 1 +
netwerk/base/CaptivePortalService.h | 1 +
netwerk/base/EventTokenBucket.cpp | 4 +++-
netwerk/base/LoadContextInfo.cpp | 3 +++
netwerk/base/LoadInfo.cpp | 3 +++
netwerk/base/MemoryDownloader.cpp | 1 +
netwerk/base/Predictor.cpp | 1 +
netwerk/base/RedirectChannelRegistrar.h | 1 +
netwerk/base/nsBaseChannel.cpp | 1 +
netwerk/base/nsChannelClassifier.cpp | 1 +
netwerk/base/nsDirectoryIndexStream.cpp | 3 ++-
netwerk/base/nsDownloader.cpp | 1 +
netwerk/base/nsIOService.cpp | 1 +
netwerk/base/nsIncrementalDownload.cpp | 3 +++
netwerk/base/nsNetUtil.cpp | 4 ++++
netwerk/base/nsNetUtil.h | 1 +
netwerk/base/nsProtocolProxyService.cpp | 1 +
netwerk/base/nsSecCheckWrapChannel.cpp | 2 ++
netwerk/base/nsUDPSocket.cpp | 4 +++-
netwerk/cache/nsDiskCacheBinding.cpp | 2 +-
netwerk/cache/nsDiskCacheDeviceSQL.cpp | 2 ++
netwerk/cache/nsMemoryCacheDevice.cpp | 2 +-
netwerk/cache2/CacheFileUtils.cpp | 2 ++
netwerk/cache2/CacheStorageService.h | 1 +
netwerk/ipc/NeckoParent.cpp | 1 +
netwerk/ipc/RemoteOpenFileChild.cpp | 1 +
netwerk/protocol/about/nsAboutBloat.cpp | 1 +
netwerk/protocol/about/nsAboutCacheEntry.cpp | 1 +
netwerk/protocol/about/nsAboutProtocolHandler.cpp | 1 +
netwerk/protocol/data/DataChannelParent.cpp | 1 +
netwerk/protocol/file/nsFileProtocolHandler.cpp | 1 +
netwerk/protocol/ftp/FTPChannelParent.cpp | 2 ++
netwerk/protocol/ftp/FTPChannelParent.h | 1 +
netwerk/protocol/ftp/nsFtpConnectionThread.cpp | 1 +
netwerk/protocol/ftp/nsFtpProtocolHandler.h | 1 +
netwerk/protocol/http/Http2Compression.cpp | 1 +
netwerk/protocol/http/Http2Session.cpp | 1 +
netwerk/protocol/http/Http2Stream.h | 2 ++
netwerk/protocol/http/HttpBaseChannel.cpp | 4 ++++
netwerk/protocol/http/HttpBaseChannel.h | 1 +
netwerk/protocol/http/HttpChannelChild.cpp | 25 ++--------------------
netwerk/protocol/http/HttpChannelChild.h | 24 +++++++++++++++++++++
netwerk/protocol/http/HttpChannelParent.cpp | 1 +
netwerk/protocol/http/HttpChannelParent.h | 1 +
.../protocol/http/HttpChannelParentListener.cpp | 1 +
netwerk/protocol/http/HttpChannelParentListener.h | 1 +
netwerk/protocol/http/InterceptedChannel.cpp | 1 +
netwerk/protocol/http/NullHttpChannel.cpp | 1 +
netwerk/protocol/http/NullHttpTransaction.cpp | 1 +
netwerk/protocol/http/PackagedAppService.cpp | 14 ++++++++++--
netwerk/protocol/http/PackagedAppService.h | 4 +++-
netwerk/protocol/http/PackagedAppVerifier.cpp | 1 +
netwerk/protocol/http/nsCORSListenerProxy.cpp | 2 +-
netwerk/protocol/http/nsHttpBasicAuth.cpp | 1 +
netwerk/protocol/http/nsHttpChannel.cpp | 2 ++
netwerk/protocol/http/nsHttpChunkedDecoder.cpp | 1 +
netwerk/protocol/http/nsHttpConnectionInfo.cpp | 2 ++
netwerk/protocol/http/nsHttpConnectionMgr.cpp | 1 +
netwerk/protocol/http/nsHttpDigestAuth.cpp | 1 +
netwerk/protocol/viewsource/nsViewSourceHandler.h | 4 ++++
.../protocol/websocket/BaseWebSocketChannel.cpp | 1 +
.../websocket/WebSocketEventListenerParent.cpp | 1 +
.../protocol/websocket/WebSocketEventService.cpp | 3 +++
netwerk/protocol/websocket/WebSocketFrame.cpp | 2 ++
netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp | 1 +
.../protocol/wyciwyg/nsWyciwygProtocolHandler.cpp | 1 +
netwerk/streamconv/converters/mozTXTToHTMLConv.cpp | 1 +
.../streamconv/converters/nsFTPDirListingConv.cpp | 1 +
.../streamconv/converters/nsHTTPCompressConv.cpp | 2 ++
netwerk/streamconv/converters/nsHTTPCompressConv.h | 1 +
netwerk/streamconv/converters/nsIndexedToHTML.cpp | 1 +
netwerk/streamconv/converters/nsMultiMixedConv.cpp | 2 ++
netwerk/streamconv/converters/nsTXTToHTMLConv.cpp | 2 ++
netwerk/streamconv/converters/nsUnknownDecoder.cpp | 2 ++
75 files changed, 147 insertions(+), 32 deletions(-)
2016-01-08 20:20:50 -05:00
03f5630fd2
Bug 1235298 - Annotate intentional switch fallthroughs to suppress -Wimplicit-fallthrough warnings in netwerk/. r=mcmanus
2015-11-22 21:58:33 -08:00
ec89bbf7f2
Bug 1237151 (part 3) - Remove ignored qualifiers in all remaining code. r=froydnj.
2016-01-05 17:08:45 -08:00
5b430fab1f
Bug 996836 - Merge CLOSE and WRITE priority in cache2 I/O thread. r=michal
...
--HG--
extra : rebase_source : 2d16c6fb54061dfa87b338da22e019295e9c299f
2016-01-05 11:50:00 -05:00
b0926d6bae
Bug 1230939 - check the return of sGlobalEntryTables->Get(aContextKey, &diskEntries). r=mayhemer
2015-12-07 06:38:00 +01:00
59bbf6548a
Bug 1187134 (part 5) - Replace nsBaseHashtable::Enumerate() calls in netwerk/cache{,2}/ with iterators. r=valentin.
...
--HG--
extra : rebase_source : d47d5a91025ce6a06ec63155d68b0969c45e4d29
2015-12-03 14:00:04 -08:00
edfdcd39d9
Bug 1187134 (part 4) - Replace nsBaseHashtable::Enumerate() calls in netwerk/cache{,2}/ with iterators. r=valentin.
...
--HG--
extra : rebase_source : 0d62ad6d5e6cad0d4202cb58ec77890e3213cecf
2015-12-03 14:00:03 -08:00
2e1080a108
Bug 1187134 (part 3) - Replace nsBaseHashtable::Enumerate() calls in netwerk/cache{,2}/ with iterators. r=valentin.
...
--HG--
extra : rebase_source : c7de2d58545b298f362a042788531fe9e13fc52a
2015-12-03 14:00:02 -08:00
abd63ceb7a
Bug 1187134 (part 2) - Replace nsBaseHashtable::Enumerate() calls in netwerk/cache{,2}/ with iterators. r=valentin.
...
--HG--
extra : rebase_source : 1c69a912e8c27cf9789057f0813ec3bbfd30c57c
2015-12-03 13:59:58 -08:00
ce11c393a5
Bug 1223808 - part 2 - use UniquePtr<uint8_t[]> instead of nsAutoArrayPtr<SHA1Sum::Hash> in HandleHashKey; r=michal
2015-11-18 15:56:47 -05:00
5fd362d4cf
Bug 1186783 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin.
2015-11-19 16:46:10 -08:00
9f8635cffa
Bug 1186783 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin.
2015-11-19 16:44:24 -08:00
7123371a1f
Bug 1186783 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin.
2015-11-19 15:31:28 -08:00
4b500464f5
Bug 1209162 - Create OriginAttributes subtypes. IGNORE IDL r=sicking.
2015-11-03 09:50:54 +08:00
a040388dea
Bug 1222782 - TSan: data race netwerk/cache2/CacheIOThread.cpp:148 Target (race on mXPCOMThread), r=jseward
2015-11-13 18:49:29 +01:00
4eff3a14a2
Bug 1190951 - TSan: data race netwerk/cache2/CacheIndex.cpp:1397 CacheIndex::IsUpToDate, r=valentin.gosu
2015-11-12 11:07:48 +01:00
073d4a9803
bug 1219466 - convert netwerk to LazyLogModule r=valentin.gosu
2015-11-02 23:35:29 -05:00
1e445509dc
Bug 1206060 - Show pinning status at about:cache. r=michal
2015-10-30 08:12:00 +01:00
9985829ecc
Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj
2015-11-02 07:53:26 +02:00
8f88fd6cdc
Bug 1032254 - Generic way to pin reasource in the HTTP cache, r=michal
...
* * *
Bug NNNNNNN - message, r=reviewer
--HG--
rename : netwerk/test/unit/test_cache2-28-concurrent_read_resumable_entry_size_zero.js => netwerk/test/unit/test_cache2-29a-concurrent_read_resumable_entry_size_zero.js
rename : netwerk/test/unit/test_cache2-29-concurrent_read_non-resumable_entry_size_zero.js => netwerk/test/unit/test_cache2-29b-concurrent_read_non-resumable_entry_size_zero.js
2015-10-22 12:11:00 +02:00
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
4bd41740d0
Bug 1165269 - Use OriginAttributes in nsILoadContextInfo, r=michal+allstars
2015-10-11 18:13:09 +02:00
3c75804211
Bug 1209351 (part 4) - Optimize nsTHashTable::RemoveEntry() usage in netwerk/. r=michal.novotny.
...
--HG--
extra : rebase_source : f8016c5411f428b60c7bee892eceee33b8951149
2015-09-24 19:10:37 -07:00
8a9abcdd4d
Bug 1156974 - mark CacheFileHandle::mIsDoomed as a release/acquire Atomic variable; r=michal
2015-08-04 00:32:36 -04:00
8dbf443150
Bug 1167809 - Add skip size check flag to cache for use with ServiceWorkers. r=mayhemer
...
For non-e10s Service Worker, we use Cache entries to achieve interception.
While this is a temporary measure, the fact that cache enforces size limits on
cache entries (which make sense for the purpose it was designed) prevents large
files from being served via a Service Worker. This patch adds a skip size check
flag to CacheStorage that is relayed to CacheEntry and CacheFile. It is set to
false by default leading to normal cache behaviour.
The patch also adds nsICacheStorageService.synthesizedCacheStorage() that
retrieves a cache storage with this flag set to true, which is used by
nsHttpChannel in case of possible interception.
2015-09-03 16:05:42 -07:00
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
5ae69d4a1a
Bug 1082735 - Don't use InsertElementSorted in HTTP cache, r=michal
2015-08-17 15:18:59 -07:00
2755fa9a57
Bug 1190086 - Use new String::Contains(char) method more widely r=froydnj
...
--HG--
extra : rebase_source : 81df1495200d3734ea1c4c13818ae764a445f4b3
2015-08-14 00:49:15 +02:00
76e3009ab8
Bug 1179909: Refactor stable state handling. r=smaug
...
This is motivated by three separate but related problems:
1. Our concept of recursion depth is broken for things that run from AfterProcessNextEvent observers (e.g. Promises). We decrement the recursionDepth counter before firing observers, so a Promise callback running at the lowest event loop depth has a recursion depth of 0 (whereas a regular nsIRunnable would be 1). This is a problem because it's impossible to distinguish a Promise running after a sync XHR's onreadystatechange handler from a top-level event (since the former runs with depth 2 - 1 = 1, and the latter runs with just 1).
2. The nsIThreadObserver mechanism that is used by a lot of code to run "after" the current event is a poor fit for anything that runs script. First, the order the observers fire in is the order they were added, not anything fixed by spec. Additionally, running script can cause the event loop to spin, which is a big source of pain here (bholley has some nasty bug caused by this).
3. We run Promises from different points in the code for workers and main thread. The latter runs from XPConnect's nsIThreadObserver callbacks, while the former runs from a hardcoded call to run Promises in the worker event loop. What workers do is particularly problematic because it means we can't get the right recursion depth no matter what we do to nsThread.
The solve this, this patch does the following:
1. Consolidate some handling of microtasks and all handling of stable state from appshell and WorkerPrivate into CycleCollectedJSRuntime.
2. Make the recursionDepth counter only available to CycleCollectedJSRuntime (and its consumers) and remove it from the nsIThreadInternal and nsIThreadObserver APIs.
3. Adjust the recursionDepth counter so that microtasks run with the recursionDepth of the task they are associated with.
4. Introduce the concept of metastable state to replace appshell's RunBeforeNextEvent. Metastable state is reached after every microtask or task is completed. This provides the semantics that bent and I want for IndexedDB, where transactions autocommit at the end of a microtask and do not "spill" from one microtask into a subsequent microtask. This differs from appshell's RunBeforeNextEvent in two ways:
a) It fires between microtasks, which was the motivation for starting this.
b) It no longer ensures that we're at the same event loop depth in the native event queue. bent decided we don't care about this.
5. Reorder stable state to happen after microtasks such as Promises, per HTML. Right now we call the regular thread observers, including appshell, before the main thread observer (XPConnect), so stable state tasks happen before microtasks.
2015-08-11 06:10:46 -07:00
fd1fcf1481
Bug 1182961 (part 2, attempt 2) - Use nsTHashtable::Iterator in CacheIndex. r=michal.
...
--HG--
extra : rebase_source : f1e111eee99e570c4766a55aefb2906dd12362d6
2015-07-26 20:15:36 -07:00
bf4d4d1817
Bug 1182961 (part 1, attempt 2) - Use nsTHashtable::Iterator in CacheIndex. r=michal.
2015-07-28 21:14:39 -07:00
cf3a9d61c8
Bug 1182961 (part 3, attempt 2) - Use nsTHashtable::Iterator in CacheIndex. r=michal.
...
--HG--
extra : rebase_source : 2cb02728091d14c08092325eb7c6da031676e1d7
2015-07-26 20:35:31 -07:00
6eb030ce06
Bug 1182961 (part 4, attempt 2) - Use nsTHashtable::Iterator in CacheFileHandles. r=michal.
2015-07-26 23:31:22 -07:00
daab3fdaf7
Backout bff74cecc67c, ffe0edb2aae7, b60b7c267cef, 6da154b43265, bcf6fd3ab9bb (bug 1182961 parts 1--5) for possible intermittent failures and performance problems.
...
--HG--
extra : rebase_source : 97ab1452e462b1ff24cc77bdadf2a6e82800690d
2015-08-06 16:30:47 -07:00
72530c51ab
Bug 1182961 (part 4) - Use nsTHashtable::Iterator in CacheFileHandles. r=michal.
...
--HG--
extra : rebase_source : 35c5892e4fa4c754fade81846d2d1fcb75ced93d
2015-07-26 23:31:22 -07:00
c9f9c763d3
Bug 1182961 (part 3) - Use nsTHashtable::Iterator in CacheIndex. r=michal.
...
--HG--
extra : rebase_source : b0011c4c261846bf314c867790b1315b6c2ca6d7
2015-07-26 20:35:31 -07:00
68e8f70a14
Bug 1182961 (part 2) - Use nsTHashtable::Iterator in CacheIndex. r=michal.
...
--HG--
extra : rebase_source : d3f035201da0c526da3003f30f8719a2635a9a09
2015-07-26 20:15:36 -07:00
4535e7d710
Bug 1182961 (part 1) - Use nsTHashtable::Iterator in CacheIndex. r=michal.
...
--HG--
extra : rebase_source : cc650176cc87916c6683705ca9aa1954d30d1c0d
2015-07-28 21:14:39 -07:00
d98d14fa1e
Bug 1189156 (part 4) - Don't use enumeration style for nsBaseHashtable::SizeOf{In,Ex}cludingThis(). r=erahm,jfkthame.
...
After this change, we have ShallowSizeOf{In,Ex}cludingThis(), which don't do
anything to measure children. (They can be combined with iteration to measure
children.)
--HG--
extra : rebase_source : f98420176f50990bbc5a25e35788328154cfeb00
2015-07-30 21:19:57 -07:00
9fcb673926
Backed out changeset fb2a27db76bc (bug 1032254) for OS X Static Build Bustage on a CLOSED TREE
...
--HG--
rename : netwerk/test/unit/test_cache2-29a-concurrent_read_resumable_entry_size_zero.js => netwerk/test/unit/test_cache2-28-concurrent_read_resumable_entry_size_zero.js
rename : netwerk/test/unit/test_cache2-29b-concurrent_read_non-resumable_entry_size_zero.js => netwerk/test/unit/test_cache2-29-concurrent_read_non-resumable_entry_size_zero.js
2015-07-31 07:57:50 +02:00
30be843b5b
Bug 1032254 - Provide a way to pin resources in the http cache r=honzab
...
--HG--
rename : netwerk/test/unit/test_cache2-28-concurrent_read_resumable_entry_size_zero.js => netwerk/test/unit/test_cache2-29a-concurrent_read_resumable_entry_size_zero.js
rename : netwerk/test/unit/test_cache2-29-concurrent_read_non-resumable_entry_size_zero.js => netwerk/test/unit/test_cache2-29b-concurrent_read_non-resumable_entry_size_zero.js
2015-07-30 11:40:00 +02:00
87b80f8c66
Bug 1188745 - Rename nsTArray::SizeOfExcludingThis() as ShallowSizeOfExcludingThis(). r=froydnj.
...
This makes it clearer that, unlike how SizeOf*() functions usually work, this
doesn't measure any children hanging off the array.
And do likewise for nsTObserverArray.
--HG--
extra : rebase_source : 6a8c8d8ffb53ad51b5773afea77126cdd767f149
2015-07-28 23:24:24 -07:00
cb267138f2
Bug 1177278 - Large OOMs in CacheFileMetadata::WriteMetadata, r=honzab
2015-07-22 15:23:16 +02:00
a8939590de
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
dbe075d5b8
Bug 1180993 - Part 3: Correct use sites of functions which return already_AddRefed. r=ehsan
2015-07-10 08:36:00 -04:00
3ce10dc57a
Bug 1171724 - Large OOMs in CacheFileMetadata, r=honzab
2015-06-24 06:33:37 +02:00
40bbd6a80c
Bug 1173860: Null check on sGlobalEntryTables. r=mcmanus
2015-06-17 11:23:43 -04:00
075c39f3b9
Bug 1151812 - Add telemetry to find optimal cache entry hash size, r=honzab
2015-06-14 14:13:18 +02:00
518166f0c8
Bug 1165515 - Part 14: Undef PR_LOG macros when using mozilla/Logging.h. r=froydnj
...
Make it harder for users to accidentally reintroduce usage of the PR_LOG macros
when using 'mozilla/Logging.h'. This can still be worked around by directly
including 'prlog.h' (and not 'mozilla/Logging.h') if absolutely necessary.
2015-06-03 15:26:07 -07:00
75c4bebb79
Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
...
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
PR_LOG_ERROR -> LogLevel::Error
PR_LOG_WARNING -> LogLevel::Warning
PR_LOG_WARN -> LogLevel::Warning
PR_LOG_INFO -> LogLevel::Info
PR_LOG_DEBUG -> LogLevel::Debug
PR_LOG_NOTICE -> LogLevel::Debug
PR_LOG_VERBOSE -> LogLevel::Verbose
Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.
Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-03 15:25:57 -07:00
f50b813989
Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj
2015-06-03 15:22:28 -07:00
326b2476af
Bug 1170534 - Remove Visual Event Tracer. r=dougt
2015-06-02 11:44:00 -04:00
5471309381
Backed out 14 changesets (bug 1165515) for linux x64 e10s m2 test failures
...
Backed out changeset d68dcf2ef372 (bug 1165515)
Backed out changeset 7c3b45a47811 (bug 1165515)
Backed out changeset b668b617bef2 (bug 1165515)
Backed out changeset d0916e1283a2 (bug 1165515)
Backed out changeset ac4dc7489942 (bug 1165515)
Backed out changeset e9632ce8bc65 (bug 1165515)
Backed out changeset c16d215cc7e4 (bug 1165515)
Backed out changeset e4d474f3c51a (bug 1165515)
Backed out changeset d87680bf9f7c (bug 1165515)
Backed out changeset b3c0a45ba99e (bug 1165515)
Backed out changeset 9370fa197674 (bug 1165515)
Backed out changeset 50970d668ca1 (bug 1165515)
Backed out changeset ffa4eb6d24b9 (bug 1165515)
Backed out changeset 5fcf1203cc1d (bug 1165515)
--HG--
extra : rebase_source : 6fb850d063cbabe738f97f0380302153e3eae97a
2015-06-02 13:05:56 +02:00
38901afce4
Bug 1165515 - Part 14: Undef PR_LOG macros when using mozilla/Logging.h. r=froydnj
...
Make it harder for users to accidentally reintroduce usage of the PR_LOG macros
when using 'mozilla/Logging.h'. This can still be worked around by directly
including 'prlog.h' (and not 'mozilla/Logging.h') if absolutely necessary.
2015-06-01 22:17:34 -07:00
a9afd68cef
Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
...
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
PR_LOG_ERROR -> LogLevel::Error
PR_LOG_WARNING -> LogLevel::Warning
PR_LOG_WARN -> LogLevel::Warning
PR_LOG_INFO -> LogLevel::Info
PR_LOG_DEBUG -> LogLevel::Debug
PR_LOG_NOTICE -> LogLevel::Debug
PR_LOG_VERBOSE -> LogLevel::Verbose
Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.
Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-01 22:17:33 -07:00
141e0ff4a2
Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj
2015-06-01 22:17:19 -07:00
4e9f80ed2e
Backed out 14 changesets (bug 1165515) for b2g mochitest-6 permafail CLOSED TREE
...
Backed out changeset 9b97e2aa2ed9 (bug 1165515)
Backed out changeset 150606c022a2 (bug 1165515)
Backed out changeset 4e875a488349 (bug 1165515)
Backed out changeset 467e7feeb546 (bug 1165515)
Backed out changeset d6b6cc373197 (bug 1165515)
Backed out changeset 0615265b593c (bug 1165515)
Backed out changeset fafd1dce9f08 (bug 1165515)
Backed out changeset d1df869245f9 (bug 1165515)
Backed out changeset 6876a7c63611 (bug 1165515)
Backed out changeset b7841c94a9a3 (bug 1165515)
Backed out changeset e5e3617f7c73 (bug 1165515)
Backed out changeset 39be3db95978 (bug 1165515)
Backed out changeset 0ec74176f8de (bug 1165515)
Backed out changeset 5b928dd10d71 (bug 1165515)
2015-06-01 17:57:58 -07:00
e8a5eb8d6e
Bug 1165515 - Part 14: Undef PR_LOG macros when using mozilla/Logging.h. r=froydnj
...
Make it harder for users to accidentally reintroduce usage of the PR_LOG macros
when using 'mozilla/Logging.h'. This can still be worked around by directly
including 'prlog.h' (and not 'mozilla/Logging.h') if absolutely necessary.
2015-06-01 14:31:01 -07:00
f82c0e7caf
Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj
...
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
PR_LOG_ERROR -> LogLevel::Error
PR_LOG_WARNING -> LogLevel::Warning
PR_LOG_WARN -> LogLevel::Warning
PR_LOG_INFO -> LogLevel::Info
PR_LOG_DEBUG -> LogLevel::Debug
PR_LOG_NOTICE -> LogLevel::Debug
PR_LOG_VERBOSE -> LogLevel::Verbose
Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.
Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
2015-06-01 14:31:01 -07:00
dc090e3fe5
Bug 1165515 - Part 3: Convert PR_LOG_TEST to MOZ_LOG_TEST. r=froydnj
2015-06-01 14:31:00 -07:00
594c5d9881
Bug 1157322 - TSan: data race netwerk/cache2/CacheIOThread.cpp:315 OnDispatchedEvent, r=honzab
2015-06-01 15:59:17 +02:00
30fb016392
Bug 1122070 - TSan: data race netwerk/cache2/CacheIOThread.cpp:97 DispatchInternal, r=honzab
2015-06-01 15:36:44 +02:00
adddf68b3c
Bug 1122420 - Improve after-shutdown dispatch assertion on CacheIOThread. r=michal
...
--HG--
extra : rebase_source : f4e438e004b4e18e81ce35db5659a6c9cef18ce1
2015-04-13 16:58:00 +02:00
f60380e914
Bug 1159500 - crash in mozilla::net::CacheIndexIterator::GetNextHash(unsigned char (*)[20]), r=honzab
2015-05-23 09:12:43 +02:00
3925a960aa
Bug 1165515 - Part 1: Convert PR_LOG to MOZ_LOG. r=froydnj
2015-05-21 13:22:04 -07:00
4879ae86f4
Bug 1165518 - Part 2: Replace prlog.h with Logging.h. rs=froydnj
2015-05-19 11:15:34 -07:00
cf42e317ab
Bug 1155963 Only allow NS_LITERAL_CSTRING to be used on compile-time literals r=froydnj,ehsan
2015-05-16 09:07:10 +01:00
3c714c42eb
Backed out changeset 17cfad44e12b (bug 1155963) for breaking b2g builds
2015-05-14 16:35:18 -07:00
ae441fafa2
Bug 1155963 Only allow NS_LITERAL_CSTRING to be used on compile-time literals r=froydnj,ehsan
2015-05-15 00:00:33 +01:00
25a263c237
Bug 1162336 - Part 2: Wrap expensive calls in PR_LOG_TEST. r=froydnj
...
Check that logging is enabled before performing potentially expensive
operations.
2015-05-07 12:52:45 -07:00
58dea0dee9
Bug 1162336 - Part 1: Remove instances of #ifdef PR_LOGGING in netwerk. r=froydnj
...
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
2015-05-07 12:52:44 -07:00
28c02e1e6d
Backed out 2 changesets (bug 1162336) for breaking at least windows builds
...
Backed out changeset 8952a7fa4050 (bug 1162336)
Backed out changeset 0170a6c2a5be (bug 1162336)
2015-05-07 11:13:24 -07:00
b9dd7823ea
Bug 1162336 - Part 2: Wrap expensive calls in PR_LOG_TEST. r=froydnj
...
Check that logging is enabled before performing potentially expensive
operations.
2015-05-07 10:35:29 -07:00
ba22eb7fee
Bug 1162336 - Part 1: Remove instances of #ifdef PR_LOGGING in netwerk. r=froydnj
...
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
2015-05-07 10:35:28 -07:00
ebde6b9f4f
Bug 1157835: Remove the MSVC_ENABLE_PGO flag from the build system. r=glandium
...
--HG--
extra : rebase_source : 0c47c99bb8b92f8361a51fd81b20a2cc8647a986
2015-04-27 19:59:27 -04:00
cb54385682
Bug 1156632 - Remove unused forward class declarations - patch 4 - netwerk image and dom, r=ehsan
2015-04-22 08:29:20 +02:00
c39e359c7d
Bug 1138293 - Use malloc/free/realloc/calloc instead of moz_malloc/moz_free/moz_realloc/moz_calloc. r=njn
...
The distinction between moz_malloc/moz_free and malloc/free is not
interesting. We are inconsistent in our use of one or the other, and
I wouldn't be surprised if we are mixing them anyways.
2015-03-31 12:32:49 +09:00
45032afa61
Bug 1147973 - Detailed disk cache hit rate telemetry is wrong, r=honzab
2015-03-30 21:08:52 +02:00
e6f385fb3d
Bug 1148527 - Indentation fix after bug 1145631, r=ehsan
2015-03-27 18:52:19 +00:00
ccf95c783e
Bug 1141555 - HTTP cache v2 generates corrupted entries, r=jduell
2015-03-26 23:05:34 +01:00
1b73f3c25b
Bug 1098422 - Change the HTTP cache half-life experiment values. r=jduell
2015-02-27 10:17:00 -05:00
f1317d5138
Bug 1132172 - Don't access CacheEntry::mFrecency on non-cache threads. r=michal
2015-03-25 14:55:00 -04:00
d5851ef31c
bug 1146027 - more final r=froydnj
2015-03-24 17:51:43 -04:00
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
082fd9cd7f
Bug 1142841: Convert all nsRefPtr<nsIRunnable> to nsCOMPtr<nsIRunnable>. r=ehsan
...
This patch was generated by a script. Here's the source of the script for
future reference:
find . \( -iname "*.cpp" -o -iname "*.h" \) | \
xargs -n 1 sed -i "s/nsRefPtr<nsIRunnable>/nsCOMPtr<nsIRunnable>/g"
2015-03-17 09:29:17 -07:00
b14a828424
Bug 1139924 - Dooming an unloaded HTTP cache entry by its URL may fail. r=michal
2015-03-05 08:42:00 -05:00
009dab9d94
Bug 1139014 - Optimize memory allocations in CacheFileMetadata, r=honzab
2015-03-06 15:49:04 +01:00
c91f45280d
Bug 1136897 - Don't evict expired entries from disk. r=michal
2015-03-03 07:58:00 +01:00
a5ab63a1b9
Bug 1133739 - HTTP cache v2: Add telemetry probes to find out the best initial read size of the metadata (fixed missing initialization of mFirstRead in one constructor), r=jseward
2015-02-25 17:46:51 +01:00
59b700c5ee
Bug 1055369 - Assertion failure: !handle || !handle->IsDoomed(). r=honzab
...
CLOSED TREE DONTBUILD
2015-02-24 11:49:46 -05:00
e6f89f97b9
Backed out changeset 12b059c5afc2 (bug 1055369) for frequent asserts across all test suites.
2015-02-24 11:40:22 -05:00
433ecb9f7d
Bug 1055369 - Assertion failure: !handle || !handle->IsDoomed(), r=honzab
2015-02-24 16:09:17 +01:00
8b7f6eed90
Bug 1076366 - HTTP cache v2: Hand out CacheEntry to read-only callback demanding re-validation, r=michal
...
--HG--
extra : rebase_source : 1b12e0522e4cd5d97d165e8f629894a7221a4bb2
2015-02-20 12:50:00 +01:00
f6b06040ea
Bug 1133739 - HTTP cache v2: Add telemetry probes to find out the best initial read size of the metadata, r=jduell
2015-02-23 16:13:02 +01:00
e0f89ef3f6
Bug 1131600 - Add telemetry probes to get detailed disk cache hit rate, r=mcmanus
2015-02-23 12:26:06 +01:00
6ba1ff0b47
Bug 1128339 - Add telemetry probes to find out impact of bug 1120945, r=jduell
2015-02-23 12:24:35 +01:00
5def7ddcfa
Bug 1132109 - Make CacheEntry::mSortingExpirationTime atomic/relaxed. r=michal
...
CLOSED TREE
--HG--
extra : amend_source : 241fc7e6eafd615ed4f45b0463700ac0eb060327
2015-02-13 07:59:00 -05:00
549f163c2c
Bug 1131092 - Place mFileStatus=NS_OK after CacheFile.Init() call in CacheEntry::Load(). r=michal
2015-02-13 07:58:00 -05:00
12cbefc9b5
Bug 1120631 - CacheEntry::mFileStatus made atomic/rel_acq. r=nfroyd, r=michal
2015-02-13 07:55:00 -05:00
f4adbc2b8a
Bug 1079789 - Don't doom expired entries in the HTTP cache intermediate memory pool. r=michal
...
CLOSED TREE
2015-02-12 14:00:00 -05:00
b0c1bd1269
Bug 1130784 - FAT32 file create limit code is using a bad error number, r=honzab
2015-02-12 11:28:50 +01:00
3e9595aa5b
Bug 1119406 - HTTP cache v2: Doom cache entry when writing of metadata fails, r=honzab
2015-01-27 15:50:18 +01:00
c9459ea8d5
Bug 1120945 - HTTP cache v2: maximum number of entries is limited to 13106 on FAT32, r=honzab
2015-01-27 02:29:02 +01:00
Honza Bambas
Chris Peterson
Michal Novotny
Nathan Froyd
Kyle Huey
Carsten "Tomcat" Book
Nicholas Nethercote
Nicholas Hurley
Honza Bambas
Julian Seward
Jonathan Watt
J. Ryan Stinnett
Bogdan Postelnicu
radu stoica
Wes Kocher
Aidin Gharibnavaz
Ben Kelly
Phil Ringnalda
Patrick McManus
Bogdan Postelnicu
Nathan Froyd
Yoshi Huang
Birunthan Mohanathas
Nikhil Marathe
Arnaud Bienner
Valentin Gosu
Michael Layzell
David Major
Eric Rahm
Neil Rashbrook
Andrea Marchesini
Mike Hommey
Trevor Saunders
Ehsan Akhgari
Daniel Holbert
Ryan VanderMeulen