Граф коммитов

1381 Коммитов

Автор SHA1 Сообщение Дата
Marian-Vasile Laza dfc5ffc7fa Backed out changeset 9bd60f359de2 (bug 1767899) for causing build bustages on EventTargetCapability.h. 2022-05-20 04:58:00 +03:00
Bryce Seager van Dyk 97a8f6862e Bug 1767899 - Guard some members that expect to be accessed on event target in TrackBuffersManager. r=media-playback-reviewers,alwu
Differential Revision: https://phabricator.services.mozilla.com/D145529
2022-05-20 01:27:07 +00:00
Bryce Seager van Dyk 36ec87d3bc Bug 1768409 - Don't log mType everywhere in TrackBuffersManager. r=alwu
Only log mType when we're updating it or using it.

Differential Revision: https://phabricator.services.mozilla.com/D145928
2022-05-11 19:15:22 +00:00
alwu adc699369a Bug 1756260 - part7 : use ExternalEngineStateMachine in MediaSourceDecoder. r=jolin
Now it's just used for testing and development purpose.

In the future, this should only be used for encrypted playback and we would also need a fallback mechanism if the external engine fails.

Differential Revision: https://phabricator.services.mozilla.com/D140592
2022-05-11 17:46:14 +00:00
Cristian Tuns df3db4d641 Backed out 10 changesets (bug 1756260) for causing build bustages on ExternalEngineStateMachine.obj CLOSED TREE
Backed out changeset d2339ec8194e (bug 1756260)
Backed out changeset 391201cf338b (bug 1756260)
Backed out changeset 1a9aa3f175d0 (bug 1756260)
Backed out changeset d624c80ba67f (bug 1756260)
Backed out changeset 46e8a8457044 (bug 1756260)
Backed out changeset 93245b0e2118 (bug 1756260)
Backed out changeset b69ee552b64e (bug 1756260)
Backed out changeset 9fc71b8478d5 (bug 1756260)
Backed out changeset 34b10d427f0f (bug 1756260)
Backed out changeset ed9640359f3a (bug 1756260)
2022-05-10 23:32:51 -04:00
alwu 0f62b3199d Bug 1756260 - part7 : use ExternalEngineStateMachine in MediaSourceDecoder. r=jolin
Now it's just used for testing and development purpose.

In the future, this should only be used for encrypted playback and we would also need a fallback mechanism if the external engine fails.

Differential Revision: https://phabricator.services.mozilla.com/D140592
2022-05-11 02:57:20 +00:00
Nika Layzell 052cba0853 Bug 1738106 - Part 3: Switch to TaskQueue::Create, r=xpcom-reviewers,necko-reviewers,media-playback-reviewers,dragana,alwu,barret
In future parts, TaskQueue will require extra initialization to be performed
which cannot happen in a constructor, as it takes references to the TaskQueue
object itself, which will require the introduction of a helper method. This
patch switches all callers of the TaskQueue constructor to use the new method.

Differential Revision: https://phabricator.services.mozilla.com/D142604
2022-05-02 20:37:34 +00:00
Zaggy1024 48766a7591 Bug 1765769 - Fix compilation errors with --disable-av1 set. r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D144343
2022-04-21 23:21:41 +00:00
Zaggy1024 8e3af9c183 Bug 1757861 - Part 2 - Add AV1 codec string parsing for MediaCapabilities, etc. decoding support checks. r=alwu
This adds both av1C and AV1 sequence header OBU parsing, which is used by MediaChangeMonitor to determine whether a new decoder is needed when the codec configuration changes during playback.

AV1 codec strings from MediaCapabilities, HTMLVideoElement.canPlayType and MediaSource.isTypeSupported will be converted to av1C format with a sequence header attached and passed to decoders to initialize them, allowing better detection of codec support in software or hardware to be implemented.

Differential Revision: https://phabricator.services.mozilla.com/D141720
2022-04-11 02:38:04 +00:00
Zaggy1024 eedf4d7699 Bug 1757861 - Part 1 - Transition VideoColorSpace to use gfx and gfx::CICP color space enums. r=alwu
Additionally, BitReader and BitWriter now support ULEB128 values which are used in AV1 sequence headers.

Differential Revision: https://phabricator.services.mozilla.com/D141072
2022-04-11 02:38:03 +00:00
Bryce Seager van Dyk db5eafd940 Bug 1724106 - Update TrackBuffersManager's get debug path to run on its TaskQueue. r=alwu
TrackBuffersManager doesn't expect access to various members from outside of its
TaskQueue. However, `GetDebugInfo` will violate this depending on the calling
thread. This patch prevents that from happening by moving `GetDebugInfo` from
the public interface and instead providing a method that will call
`GetDebugInfo` on the appropriate thread.

This also updates call sites to appropriately handle the change.

Differential Revision: https://phabricator.services.mozilla.com/D142325
2022-03-29 22:17:58 +00:00
Bryce Seager van Dyk ff03cc04a5 Bug 1724106 - Clarify threading usage when getting media debug info. r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D124104
2022-03-29 22:17:58 +00:00
Matthew Gregan a4922243df Bug 1761851 - Take WebMBufferedParser monitor in NotifyDataAvailable and simplify Append API. r=media-playback-reviewers,bryce
Differential Revision: https://phabricator.services.mozilla.com/D142276
2022-03-28 22:01:09 +00:00
Zaggy1024 0802b7b07f Bug 1569686 - Fixed MediaCapabilities API not returning powerEfficient=true all VP8/VP9 codecs. r=alwu
VPXChangeMonitor never initialized a decoder to test for that hardware support on when requested by MediaCapabilities. To fix this, codec initialization data is created to be processed by VPXChangeMonitor to initialize a dummy decoder.

MediaCapabilities and related APIs will now accept VP9 Profile 3, as the profile is supported by libdav1d.

Depends on D138884

Differential Revision: https://phabricator.services.mozilla.com/D140148
2022-03-17 20:39:51 +00:00
Randell Jesup fcaf70841e Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 18:47:08 +00:00
Noemi Erli 2390d257e6 Backed out changeset 12a59e5a50bf (bug 1207753) for causing build bustage CLOSED TREE 2022-03-16 18:32:51 +02:00
Randell Jesup 4b033a5256 Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 16:16:14 +00:00
Butkovits Atila 927ad62c6a Backed out changeset a68ee4b09f92 (bug 1207753) for causing Hazard bustages. CLOSED TREE 2022-03-16 14:38:14 +02:00
Randell Jesup 7d4b5fae04 Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 12:01:14 +00:00
Bryce Seager van Dyk f938c42021 Bug 1755822 - Add test to ensure MediaTrackBuffersManager is clearing its input buffer. r=media-playback-reviewers,alwu
This adds a modified version of the bipbop video 1 segment used in the
MediaSource tests. This modified segment contains a large trailing 'skip' box.
These trailing boxes can interfere with Gecko's ability to clear memory.

A test case is added to test that Fx is correctly clearing memory after the new
segment is appended several times. Prior to the fix in bug 1697476 this test
would fail, but we should now handle this case better.

Differential Revision: https://phabricator.services.mozilla.com/D139265
2022-02-24 02:04:46 +00:00
Bryce Seager van Dyk b63d9c3455 Bug 1755820 - Improve memory reporter in TrackBuffersManager. r=media-playback-reviewers,alwu
This expands our memory reporting in TrackBuffersManager to cover additional
memory usage. Specifically it now reports several buffers where input data is
stored by the manager. These buffers will not typically take up that much space,
but it doesn't hurt to have them reported against media. Additionally, we've
just fixed a case where one of the buffers reported in this patch was growing
without bound, so it's nice to have some cover on that (bug 1697476 ). Reporting
these metrics will allow for testing of that bug too.

There is still more that could be reported from the TrackBuffersManager, but
that's a big yak to shave, so this patch intentionally does not attempt to do
so.

I've verified this works via about:memory and dmd.py (this also confirms there
are no double counts in my testing).

Differential Revision: https://phabricator.services.mozilla.com/D139246
2022-02-24 02:04:46 +00:00
Bryce Seager van Dyk ad87a43101 Bug 1697476 - Shrink MSE's mInputBuffer during append even if it's not empty. r=media-playback-reviewers,kinetik,alwu
This prevents us eventually overflowing the buffer when getting certain data
appended.

Differential Revision: https://phabricator.services.mozilla.com/D138970
2022-02-18 02:18:49 +00:00
alwu cc71fae01f Bug 1755402 - make MediaSourceDecoder use InitializeStateMachine(). r=media-playback-reviewers,bryce
Differential Revision: https://phabricator.services.mozilla.com/D138733
2022-02-15 00:20:07 +00:00
Randell Jesup 37df566280 Bug 1746905: dom/media misc cleanup r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D134302
2021-12-21 17:49:12 +00:00
Randell Jesup 742ff90d2f Bug 1746322: MediaSource cleanup r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D133986
2021-12-17 15:19:57 +00:00
Chris Peterson f6fdbf028a Bug 1738401 - Remove -Wno-shadow warning suppressions. r=firefox-build-system-reviewers,glandium
-Wshadow warnings are not enabled globally, so these -Wno-shadow suppressions have no effect. I had intended to enable -Wshadow globally along with these suppressions in some directories (in bug 1272513), but that was blocked by other issues.

There are too many -Wshadow warnings (now over 2000) to realistically fix them all. We should remove all these unnecessary -Wno-shadow flags cluttering many moz.build files.

Differential Revision: https://phabricator.services.mozilla.com/D132289
2021-12-01 06:40:04 +00:00
Gerald Squelart 5399574d8b Bug 1738627 - profiler_thread_is_being_profiled_for_markers - r=canaltinova
`profiler_thread_is_being_profiled` is used a lot for markers, so it makes sense to have a specialized version, which is a bit shorter, and lives in ProfilerMarkers.h.

Differential Revision: https://phabricator.services.mozilla.com/D130009
2021-11-08 23:59:35 +00:00
Cristian Tuns 1aeac93d23 Backed out 5 changesets (bug 1738627) for causing xpcshell failures on test_ext_geckoProfiler_schema.js CLOSED TREE
Backed out changeset 42d385d7da97 (bug 1738627)
Backed out changeset edeb3a338954 (bug 1738627)
Backed out changeset 98f02e35134d (bug 1738627)
Backed out changeset 711daa6dd24b (bug 1738627)
Backed out changeset 49e12753a40c (bug 1738627)
2021-11-05 05:12:28 -04:00
Gerald Squelart 7fa084ae7c Bug 1738627 - profiler_thread_is_being_profiled_for_markers - r=canaltinova
`profiler_thread_is_being_profiled` is used a lot for markers, so it makes sense to have a specialized version, which is a bit shorter, and lives in ProfilerMarkers.h.

Differential Revision: https://phabricator.services.mozilla.com/D130009
2021-11-05 05:52:28 +00:00
Paul Adenot 80684c0e5a Bug 1694085 - Add a test that verifies that HE-AAC plays back correctly including higher frequency content both with MSE and HTTP playback. r=bryce
Depends on D128895

Differential Revision: https://phabricator.services.mozilla.com/D128907
2021-10-21 16:18:19 +00:00
Norisz Fay 29bbbf1b43 Backed out 3 changesets (bug 1694085) for causing mda failures on test_HEAAC_extradata.html CLOSED TREE
Backed out changeset 1468166a95c6 (bug 1694085)
Backed out changeset dd1ec2d464cb (bug 1694085)
Backed out changeset f80df57030d8 (bug 1694085)
2021-10-21 16:41:26 +03:00
Paul Adenot c4b44c8a7d Bug 1694085 - Smooth the FFT analysis to make the test more robust.
Differential Revision: https://phabricator.services.mozilla.com/D129145
2021-10-21 11:03:35 +00:00
Paul Adenot ade076bf6e Bug 1694085 - Add a test that verifies that HE-AAC plays back correctly including higher frequency content both with MSE and HTTP playback. r=bryce
Depends on D128895

Differential Revision: https://phabricator.services.mozilla.com/D128907
2021-10-21 09:48:07 +00:00
Gerald Squelart df50ece611 Bug 1735697 - Remove profiler_can_accept_markers(), use profiler_thread_is_being_profiled() instead - r=florian
Differential Revision: https://phabricator.services.mozilla.com/D128577
2021-10-18 23:11:30 +00:00
alwu 50b24cbdcc Bug 1732807 - add profiler labels and markers in TrackBuffersManager. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D126744
2021-09-28 17:54:00 +00:00
alwu f287b980e0 Bug 1605699 - add more assertions to see if sample's attributes are still valid before we return it via `GetSample()`. r=bryce
In D58392 and D58393, we already added some assertions to ensure that (1) sample is valid when it got added (2) sample is valid when we call `GetSample()`.

However, the crash still exists and doesn't hit these two places. So another possible situation is that samples become invalid during modification before we return it via `GetSample()`.

Therefore, add more assertion to see my guess is correct or not.

Differential Revision: https://phabricator.services.mozilla.com/D126722
2021-09-27 18:44:21 +00:00
Alexandru Michis bd2de15f47 Backed out 2 changesets (bug 1724106) for causing Bug 1728715.
CLOSED TREE

Backed out changeset 81d1db229eea (bug 1724106)
Backed out changeset 8ed4675541c6 (bug 1724106)
2021-09-02 21:03:07 +03:00
Bryce Seager van Dyk cfec4e7dfa Bug 1724106 - Clarify threading usage when getting media debug info. r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D124104
2021-09-01 22:29:48 +00:00
alwu 6b5bc91eec Bug 1718709 - part3 : add test. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D119698
2021-07-14 00:59:22 +00:00
Dorel Luca 850b387d69 Backed out 3 changesets (bug 1718709) for Build bustage. CLOSED TREE
Backed out changeset 1b83279868da (bug 1718709)
Backed out changeset 705741f27314 (bug 1718709)
Backed out changeset af0392f23e07 (bug 1718709)
2021-07-14 03:48:26 +03:00
alwu e685d89f2e Bug 1718709 - part3 : add test. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D119698
2021-07-14 00:28:29 +00:00
Paul Adenot 80b6805757 Bug 1703603 - Add a mochitest for bug 1703603. r=bryce
This tests two things: whether `mozCaptureStreamUntilEnded` is handled correctly
when the media element source is a `MediaSource`, and whether all objects have
references to each other as to not garbage collect any part of the system.

Differential Revision: https://phabricator.services.mozilla.com/D116397
2021-06-02 14:20:40 +00:00
Joel Maher 2e841d22cb Bug 1704640 - Move mochitest browser-chrome / media from osx 10.14 to osx 10.15. r=ahal,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D115951
2021-05-27 16:06:03 +00:00
Paul Bone 6191ca4916 Bug 1709526 - Fix all the lint errors for .ini files in dom/ r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D114321
2021-05-06 01:29:31 +00:00
alwu 7dfd8f5884 Bug 1699249 - part1 : add a probe to measure the source buffer usage for different mime types. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D108885
2021-03-29 15:59:03 +00:00
alwu f3f041d6d1 Bug 1700492 - add some new debug log for MSE. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D109563
2021-03-24 16:26:39 +00:00
alwu 5ca51f8b97 Bug 1352050 - re-enable MSE tests on Android. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D109518
2021-03-23 17:17:41 +00:00
alwu 3d61032d37 Bug 1698982 - print the error reason and code in 'MediaSource::SetDuration()'. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D108699
2021-03-17 16:09:34 +00:00
Simon Giesecke eeedc67ff4 Bug 1693002 - Remove redundant nullptr checks of return value of infallible new in dom/media. r=bryce
Depends on D105290

Differential Revision: https://phabricator.services.mozilla.com/D105291
2021-02-24 12:44:08 +00:00
Jon Bauman aade425260 Bug 1689222 - MediaSource.prototype.onsourceclosed event handler attribute typo (trailing d). r=alwu,webidl,smaug
Differential Revision: https://phabricator.services.mozilla.com/D103560
2021-02-02 17:50:38 +00:00