test_expanding_selection_per_page.html creates another window and requires
focus event on each case which creates editing host because
EditorEventListener::Focus() sets ancestor limit of Selection as the editing
host. Therefore, if the window itself does not have focus, focus event won't
be fired on editing hosts. So, the reason why the orange occurs almost all
with opt build is, debug build is enough slow to wait focus of new window
before running test.
Differential Revision: https://phabricator.services.mozilla.com/D9473
--HG--
extra : moz-landing-system : lando
Depends on D8741
This changeset updates some calls to ok() that should actually be calls to is()
and that needed tiny fixes to match the expected value.
Differential Revision: https://phabricator.services.mozilla.com/D8742
--HG--
extra : moz-landing-system : lando
Depends on D8740.
This changeset replaces calls to ok with 3 arguments to calls with 2 arguments
in situations where the switch does not have a significant impact on the assert.
Differential Revision: https://phabricator.services.mozilla.com/D8741
--HG--
extra : moz-landing-system : lando
Depends on D8739.
This changeset updates calls to ok() that were most likely intended
for is(), but are not working as is.
Differential Revision: https://phabricator.services.mozilla.com/D8740
--HG--
extra : moz-landing-system : lando
This changeset updates all the test that were wrongly using ok() and wanted to
use is() AND for which the assert is still passing without any modification
required.
Differential Revision: https://phabricator.services.mozilla.com/D8739
--HG--
extra : moz-landing-system : lando
This patch changed the initialization of records so that we don't call into credit card
AutofillRecords class if it is pref-off.
Differential Revision: https://phabricator.services.mozilla.com/D9158
--HG--
extra : rebase_source : ee9802af34d8ce63dc3569c10e310762e2271301
extra : histedit_source : 443fb496f872d61b68dcae3bba691c4e1089bf3e
In case of loss of OS key store key, we should still allow users to go into the manage credit cards dialog and fill the numbers back in.
This is not the migration strategy, see Part III.
Differential Revision: https://phabricator.services.mozilla.com/D5083
--HG--
extra : rebase_source : dc710a2512b0d9b20e0fa74e641867525098eba2
extra : histedit_source : 4983a480565380ce4da6a0f099a5e4ae0e65797d
For Nightly users who already have credit cards saved in their profile, we will do a one-off upgrade of their encrypted credit card number.
This only applies to users who have NO master password set, to avoid showing them the master password prompt when we migrate.
For those who did, we would quietly delete their credit card record from the store.
Differential Revision: https://phabricator.services.mozilla.com/D8029
--HG--
extra : rebase_source : 2b06e3fc418d5883276850def18966203c16e240
extra : histedit_source : 9fae8d61b747113e8b3f38c2886cf7d1a7c3007f
Given that the new store is always considered enabled, the not-enabled code
is now dead code. This patch removes them.
Differential Revision: https://phabricator.services.mozilla.com/D5717
--HG--
extra : rebase_source : d2940f77e26ba9f5c808eada5083df293d314214
extra : histedit_source : 29741eb6014489fcd179e90ee18ff876227baaf5
This patch morphs MasterPassword.jsm to OSKeyStore.jsm while keeping the same
API, as an adaptor between the API and the native API exposed as nsIOSKeyStore.idl.
Noted that OS Key Store has the concept of "recovery phrase" that we won't
be adopting here. The recovery phrase, together with our label, allow
the user to re-create the same key in OS key store.
Test case changes are needed because we have started asking for login in
places where we'll only do previously when "master password is enabled".
This also made some "when master password is enabled" tests invalid because
it is always considered enabled.
Some more test changes are needed simply because they previously rely on the
stable order of microtask resolutions (and the stable # of promises for a
specific operation). That has certainly changed with OSKeyStore.
The credit card form autofill is only enabled on Nightly.
Differential Revision: https://phabricator.services.mozilla.com/D4498
--HG--
rename : browser/extensions/formautofill/MasterPassword.jsm => browser/extensions/formautofill/OSKeyStore.jsm
rename : browser/extensions/formautofill/test/browser/browser_creditCard_fill_master_password.js => browser/extensions/formautofill/test/browser/browser_creditCard_fill_cancel_login.js
extra : rebase_source : cabbd8cdec86e5b3965cf1c8b6e635b73b6c2095
extra : histedit_source : 65e71057104465553fefa1d0b293580efed53075
This should symptomless since the extra op should always be a JSOP_GOTO
which will be skipped over anyways. Fix for our sanity.
Differential Revision: https://phabricator.services.mozilla.com/D9422
--HG--
extra : moz-landing-system : lando
Currently it is relative to JSScript::main(), but it is the only part of
the engine that uses this definition to describe a "pcOffset". This is
unnecessarily confusing, and fixing it is easy.
Differential Revision: https://phabricator.services.mozilla.com/D9358
--HG--
extra : moz-landing-system : lando
This also includes implementation of nsNativeThemeCocoa::GetWidgetAutoColor
which should have been done in bug 1464722 actually.
Differential Revision: https://phabricator.services.mozilla.com/D8629
--HG--
extra : moz-landing-system : lando
This refactor does a few things:
1. Unifies the composition of the GeckoBundle, so that some tricky edge
cases don't need to be implemented twice.
2. Allows us to be more frugal with round trip sync ipc calls. Instead
of retrieving everything from the start, only progressivley retrieve
what we need.
3. Sets the groundwork for the next patch that will return from this
function earlier with a smaller bundle.
Differential Revision: https://phabricator.services.mozilla.com/D8778
--HG--
extra : moz-landing-system : lando
Jan de Mooij
Masayuki Nakano
Julian Descottes
Xidorn Quan
Timothy Guan-tin Chien
Matthew Noorenberghe
Sean Stangl
Iain Ireland
Dorel Luca
Panos Astithas
James Lee
Ted Campbell
fvsch
Simon Fraser
Patrick Brosset
Brad Werth
Collin Wing
Eitan Isaacson
Sebastian Hengst