Our counters are super low because we report lots of empty entries for
these. It seems just opening a new tab is enough to trigger this.
While at it I found that we also report about:preferences / about:config
since they use the system principal. Also block those.
Differential Revision: https://phabricator.services.mozilla.com/D184834
When we AsyncOpen the HttpChannelChild, we might exit early, possibly because
we're already shutting down. But if we've already added the channel to the
loadgroup when the loadgroup gets cleaned up we try to cancel the channel.
Because we didn't get to that point where we call SetEventTarget,
we would trigger the neckoTarget assertion in HttpChannelChild::AsyncCallImpl.
This patch makes sure we add the channel to the loadgroup when we are certain
it will actually be opened.
Differential Revision: https://phabricator.services.mozilla.com/D186123
This patch moves from a model where every received RTCP packet goes through all
MediaPipelines for a given transport, being duplicated along the way to the same
webrtc::PacketReceiver instance; to a model where every received RTCP packet
goes through PeerConnectionImpl to webrtc::PacketReceiver.
With this patch, no duplications occur.
The PacketDumper API expects received RTCP/SRTCP packet to be tied to a level so
this patch maintains the old behavior by dumping received RTCP/SRTCP on all
levels that have dumping enabled.
Differential Revision: https://phabricator.services.mozilla.com/D186227
We need to do things a bit differently than for other pseudo elements as
`InspectorUtil.getCSSStyleRules` expects the highlight function + the highlight
name (e.g. `::highlight(myHighlight)`.
We loop through all registered Highlights via `CSS.highlights` and only consider
the ones that are currently used in the page (i.e. their `size` is > 0).
A test is added to ensure everything works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D184551
This will be used by DevTools to retrieve the name of registered, active, highlights,
in order to display the CSS rules for the `::highlight` pseudo element rules.
Differential Revision: https://phabricator.services.mozilla.com/D186006
Don't display the arrow on the root node, and remove the ability to collapse it.
Add a border at the bottom of the root node so it looks like a header
Add a new `HEADER` Rep mode that will be used for the root node, so we're
showing relevant information in this context (e.g. the object type/class name)
but not the preview when it would be redundant with the content of the tooltip.
For example, we don't want to show the preview for simple objects, arrays, maps, …
but we still have a "longer" description for objects where the properties in
the preview are handpicked (e.g. elements, window, document, …)
Differential Revision: https://phabricator.services.mozilla.com/D185770
CSS rules were storing absolute rather than relative line numbers (this
was done to match the old style system).
So when we hit the cached inline stylesheet code-path, for which we
share the CSS rules of the stylesheet, for the cache hit the line
numbers were completely off.
This particular page was probably regressed by bug 1834081, but the
issue could happen before with Shadow DOM.
Always store relative numbers and convert to absolute when asked by the
inspector, rather than the other way around.
This is simpler and makes the cache work.
Differential Revision: https://phabricator.services.mozilla.com/D185916
This patch deals with this case:
```
<span contenteditable><div>foo</div>[]</span>
```
In this case only one `<br>` should be added since one
line break is already added because of the `<div>` block.
Differential Revision: https://phabricator.services.mozilla.com/D185935
The logic behind this patch is similar to that of part 1, only that this covers the case where a user triggers a line break instead of a new paragraph (i.e. by pressing [Shift/cmd]+[Enter]).
If the inserted BR element is followed by a block boundary, another BR element is added.
Depends on D182339
Differential Revision: https://phabricator.services.mozilla.com/D182485
If a user presses <Enter> to add a new paragraph at the end of a contenteditable, a second (invisible) line break has to be added:
`<span contenteditable>foo[]</span>` --> `<span contenteditable>foo<br><br></span>`
This patch deals with contenteditables which do not preformat whitespaces
(i.e. should insert linebreaks, not linefeeds).
The linefeed cases are handled in Bug 1840856.
Also this patch only deals with a code path that uses `insertParagraph`.
The code path that uses `InsertLineBreak` is handled in part 2 of this Bug.
The patch implements a lambda function that inserts a second `<br>` element,
which is called in two situations:
1. The editing host is empty:
`<span contenteditable>[]</span>`--> `<span contenteditable><br><br></span>`
2. The caret is at a block boundary:
`<span contenteditable>abc[]</span>` --> `<span contenteditable>abc<br><br></span>`
Differential Revision: https://phabricator.services.mozilla.com/D182339
If our line numbers etc are wrong, then we might throw and retry later.
Given the empty string already represents failure, make
getAuthoredCssText not throw and just return the empty string on
failure.
This avoids retrying over and over just to fail. It doesn't fix the
initial hang, but makes it more manageable.
Will still try to find a proper fix / root cause of course, but this
seems harmless enough either way.
Differential Revision: https://phabricator.services.mozilla.com/D185906
After bug 1847177, the only remaining tests in layout/mathml/tests are
for testing the effect of mathml.disabled=true.
test_disabled.html is a plain mochitest, rename it
dynamic-math-tree-001.html and move it into
testing/web-platform/mozilla/tests/mathml/disabled. The iframe added in
bug 1470163 is no longer necessary since the preference is enabled in
the __dir__ini manifest.
test_disabled_chrome.html is a chrome mochitest checking that MathML
is still laid out in Chrome document when mathml.disabled is true. It
is a bit complex and non-obvious so try to rewrite it in a more
straightforward way. Also use test_disabled_chrome_iframe.html as
a file name for the the iframe content to make clear it's associated
to this test. Probably this test could be rewritten as a browser
mochitest (see bug 1847206).
math-parse01.html is copied from the the upstream WPT repo but runs
with mathml.disabled=true. Move it into the same directory as other
WPT tests testing support when MathML is disabled.
Finally, also enable linting for layout/mathml/tests.
Differential Revision: https://phabricator.services.mozilla.com/D185426
MP4 now routinely contains royalty-free codecs such as VP9 and Opus, I don't
think it makes too much sense to couple it with an option for the inclusion of a
decoder that is in the contrary used to decode patented codecs. It also doesn't
make much sense to allow disabling it either in this day and age.
Differential Revision: https://phabricator.services.mozilla.com/D185918
This could cause the event tooltip to not be displayed for some jQuery events.
A test is added to ensure we don't regress this.
Differential Revision: https://phabricator.services.mozilla.com/D185976
By adding another tree for arena lookups we can access the new tree without
taking a lock. This makes main-thread-only arenas completely lock-free.
Differential Revision: https://phabricator.services.mozilla.com/D184548
After this patch, we'll fail four tests due to reference files written in grid
layout, and we've had bug 1609403 for grid baseline alignment.
Differential Revision: https://phabricator.services.mozilla.com/D185872