3fe818ed43
Bug 1186794 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in embedding/ with iterators. r=bz.
...
--HG--
extra : rebase_source : a8a42a93324936c089ce9b1e9167dcef6fe14b2c
2015-11-01 18:41:57 -08:00
20693def2e
Bug 1186794 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in embedding/ with iterators. r=bz.
...
Also make mGroupNames const to avoid a cast.
--HG--
extra : rebase_source : 09b2341b3a18265cfb8fddd70b008a8daa5dc272
2015-11-01 18:41:40 -08:00
c7d3c4e21a
Bug 1216401: Eviscerate nsIDOMWindow, move still needed methods to nsPIDOMWindow. r=bz
2015-10-26 14:37:32 -07:00
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
110f12e7ca
Bug 1072150 - Use the opt-out for various sloppy consumers. r=bz
2015-09-24 14:02:41 -07:00
71920a9550
Bug 1207030 - Enable -Wshadow flag in more directories that have no -Wshadow warnings. r=glandium
2015-09-22 21:39:03 -07:00
647b520991
Bug 1201135 - Rename pldhash.{h,cpp} to PLDHashTable.{h,cpp}. r=mccr8.
...
--HG--
rename : xpcom/glue/pldhash.cpp => xpcom/glue/PLDHashTable.cpp
rename : xpcom/glue/pldhash.h => xpcom/glue/PLDHashTable.h
extra : rebase_source : 06b9d30db96ed78500fd44d9c0b51609103508a3
2015-09-15 20:49:53 -07:00
59683492e5
Bug 1121760 (part 3) - Remove PL_DHashTableRemove(). r=poiru.
...
--HG--
extra : rebase_source : c34d693de4aca45f2ea05c2767c8b1007c89df29
2015-09-14 14:23:24 -07:00
479244f7c9
Bug 1121760 (part 2) - Remove PL_DHashTableAdd(). r=poiru.
...
--HG--
extra : rebase_source : 41eb939bfb5c925cba58b1af57abce9a4e5fdb30
2015-09-14 14:23:12 -07:00
fcfdd8f54b
Bug 1121760 (part 1) - Remove PL_DHashTableSearch(). r=poiru.
...
--HG--
extra : rebase_source : 770e1f49a451ecbadd778e071b204611e27cf701
2015-05-21 00:34:25 -07:00
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
e849e6588b
Bug 1170416 (part 3) - Remove the PLDHashTable2 typedef. r=froydnj.
...
--HG--
extra : rebase_source : 9510ea47204fffa163cac43aeaaac6ae1ad80419
2015-05-19 16:46:17 -07:00
bf1839cd7a
Bug 1166598 (part 3) - Use PLDHashTable2 in nsCommandParams. r=froydnj.
...
--HG--
extra : rebase_source : 8e7e616c93cae653440a6ea2e11cd1c6da2e8821
2015-05-05 18:23:39 -07:00
2512f8de5d
Bug 1164049 - Fix some mode lines in embedding/. r=smaug
...
embedding/browser, embedding/components/commandhandler/, embedding/components/find/, embedding/components/windowwatcher/
2015-05-12 08:30:00 +02:00
916fc10422
Bug 1130096 - Convert embedding/components/commandhandler/ to Gecko style. r=mccr8
2015-05-11 12:35:14 -07:00
924c9eb636
Bug 1134923 - Remove NS_Alloc/NS_Realloc/NS_Free. r=nfroyd
...
They are kept around for the sake of the standalone glue, which is used
for e.g. webapprt, which doesn't have direct access to jemalloc, and thus
still needs a wrapper to go through the xpcom function list and get to
jemalloc from there.
2015-05-01 09:40:30 +09:00
d5851ef31c
bug 1146027 - more final r=froydnj
2015-03-24 17:51:43 -04:00
b252a27930
Bug 1142503 - don't use QueryInterface when the compiler can do the cast for us; r=ehsan
...
Calling QueryInterface with a statically known IID should typically not
be necessary. In those cases where it's not, the compiler can do the
cast for us, though we have to supply the reference-counting that
QueryInterface would do.
In passing, several redundant null-checks for the result of |new T| have
been deleted.
2015-03-12 09:43:50 -04:00
3a7b0a9f57
Bug 1131901 (part 1) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative. r=froydnj.
...
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.
--HG--
extra : rebase_source : 526d96ab65e4d7d71197b90d086d19fbdd79b7b5
2015-02-02 14:48:58 -08:00
63e3218e4c
Back out changesets 2fcef6b54be7, 2be07829fefc, 66dfe37b8532, df3fcd2be8fd, 0a436bce77a6 (bug 1050035) for causing intermittent crashes and assertion failures.
...
--HG--
extra : rebase_source : eb30be83c3143c6c203585a80a18f180025efaba
2015-02-10 14:39:49 -08:00
b5913e0b3d
Bug 1050035 (part 4) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative. r=froydnj.
...
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.
--HG--
extra : rebase_source : eeba14d732077ef2e412f4caca852de6b6b85f55
2015-02-02 14:48:58 -08:00
3163cfc2c1
Bug 1124973 (part 2) - Introduce PL_DHashTableSearch(), and replace most PL_DHashTableLookup() calls with it. r=froydnj.
...
It feels safer to use a function with a new name, rather than just changing the
behaviour of the existing function.
For most of these cases the PL_DHashTableLookup() result was checked with
PL_DHASH_ENTRY_IS_{FREE,BUSY} so the conversion was easy. A few of them
preceded that check with a useless null check, but the intent of these was
still easy to determine.
I'll do the trickier ones in subsequent patches.
--HG--
extra : rebase_source : ab37a7a30be563861ded8631771181aacf054fd4
2015-01-22 21:06:55 -08:00
48710afc66
Bug 1124920 - Remove PLDHashTable::Operate(). r=froydnj.
...
--HG--
extra : rebase_source : f029d3ca8835232b3c1d4188aa63a0004c1aad4b
2015-01-22 15:43:18 -08:00
69fe655b04
Bug 1121304 (part 2, attempt 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj.
...
--HG--
extra : rebase_source : bc119bd0d3b6944e8c5a000950e0c4052cb70aef
2015-01-14 14:35:56 -08:00
e39f0adeca
Backed out 2 changesets (bug 1121304) for consistent b2g hangs in webgl-color-test.html?frame=1&__&preserve&premult&_____
...
Backed out changeset 20651ac19549 (bug 1121304)
Backed out changeset 758afec77c95 (bug 1121304)
2015-01-14 22:02:23 -08:00
e9735966fa
Bug 1121304 (part 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj.
2015-01-14 14:35:56 -08:00
47221bc7f9
Bug 1120476 (part 4) - Remove PLDHashTableOps::finalize. r=froydnj.
...
--HG--
extra : rebase_source : b14dda8cdd5cd896d1e32950e38b2a9f7da4d99e
2015-01-13 19:02:35 -08:00
c7538c9776
Bug 1120476 (part 3) - Remove PLDHashTable::data. r=froydnj.
...
--HG--
extra : rebase_source : 24d10af3dbce3ada5252503bc80bb1a4e31bc1c9
2015-01-13 16:42:13 -08:00
699e7b5b3e
Bug 1120476 (part 2) - Avoid using PLDHashTable::data in nsCommandParams. r=froydnj.
...
--HG--
extra : rebase_source : 892170937a41229301be81236d2517f09e20138d
2015-01-13 16:40:47 -08:00
411a94b05a
Bug 1118024 - Use new PL_DHashTable{Add,Lookup,Remove} functions. r=nfroyd
2015-01-05 20:27:28 -06:00
b0a6a33837
Bug 1060529, send the enabled state of child process commands to the parent on update, without the test, r=smaug,ehsan
2014-12-09 10:48:27 -05:00
280a38ff20
Backed out 2 changesets (bug 1060529) for introducing a new intermittent bc1 orange
...
Backed out changeset 5ddd9eb25925 (bug 1060529)
Backed out changeset d4f962fb38be (bug 1060529)
2014-12-08 16:40:55 -08:00
2e2109d0f9
Bug 1060529, send the enabled state of child process commands to the parent on update, now with improved test, r=smaug,ehsan
2014-12-08 08:12:22 -05:00
17b1ef89ea
Bug 1061059 - Fix more bad implicit constructors in embedding; r=bsmedberg
2014-09-02 18:22:57 -04:00
423528a175
Bug 1057914 (part 2) - Fix the style of nsCommandParams.{h,cpp}. r=ehsan.
...
--HG--
extra : rebase_source : 7d0dbdde81fb3f308fee47cb5c6d881cc5174ae0
2014-08-25 16:20:01 -07:00
f47c6d907e
Bug 1057914 (part 1) - Remove enumeration methods from nsICommandParams. r=ehsan.
...
--HG--
extra : rebase_source : 313bf18bd88f1fbdb9a308aecbab666b8ff87adf
2014-08-17 21:58:10 -07:00
720dc9a6c4
Bug 1054703 - Part 3: Flatten embedding/components/commandhandler/{public,src}/ into parent directory. r=bsmedberg
...
--HG--
rename : embedding/components/commandhandler/src/nsBaseCommandController.cpp => embedding/components/commandhandler/nsBaseCommandController.cpp
rename : embedding/components/commandhandler/src/nsBaseCommandController.h => embedding/components/commandhandler/nsBaseCommandController.h
rename : embedding/components/commandhandler/src/nsCommandGroup.cpp => embedding/components/commandhandler/nsCommandGroup.cpp
rename : embedding/components/commandhandler/src/nsCommandGroup.h => embedding/components/commandhandler/nsCommandGroup.h
rename : embedding/components/commandhandler/src/nsCommandManager.cpp => embedding/components/commandhandler/nsCommandManager.cpp
rename : embedding/components/commandhandler/src/nsCommandManager.h => embedding/components/commandhandler/nsCommandManager.h
rename : embedding/components/commandhandler/src/nsCommandParams.cpp => embedding/components/commandhandler/nsCommandParams.cpp
rename : embedding/components/commandhandler/src/nsCommandParams.h => embedding/components/commandhandler/nsCommandParams.h
rename : embedding/components/commandhandler/src/nsControllerCommandTable.cpp => embedding/components/commandhandler/nsControllerCommandTable.cpp
rename : embedding/components/commandhandler/src/nsControllerCommandTable.h => embedding/components/commandhandler/nsControllerCommandTable.h
rename : embedding/components/commandhandler/public/nsICommandManager.idl => embedding/components/commandhandler/nsICommandManager.idl
rename : embedding/components/commandhandler/public/nsICommandParams.idl => embedding/components/commandhandler/nsICommandParams.idl
rename : embedding/components/commandhandler/public/nsIControllerCommand.idl => embedding/components/commandhandler/nsIControllerCommand.idl
rename : embedding/components/commandhandler/public/nsIControllerCommandTable.idl => embedding/components/commandhandler/nsIControllerCommandTable.idl
rename : embedding/components/commandhandler/public/nsIControllerContext.idl => embedding/components/commandhandler/nsIControllerContext.idl
rename : embedding/components/commandhandler/public/nsPICommandUpdater.idl => embedding/components/commandhandler/nsPICommandUpdater.idl
2014-08-20 10:27:16 -07:00
8a1cc6180e
Bug 1050036 (part 2) - Fix leaks in nsCommandParams cause by a bad moveEntry() function for the pldhash. r=roc.
...
--HG--
extra : rebase_source : 9165c8eea9c81b8eb1ed88ebf04088b40222ad5a
2014-08-17 15:42:20 -07:00
a7cf4142b4
Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc.
...
* * *
imported patch rm-dummy-params
--HG--
extra : rebase_source : c25987eb11bae197218d5fc53b77def19afa36ac
2014-08-06 06:31:21 -07:00
bc5d6801bb
Bug 1041860 - Avoid setting FINAL_LIBRARY to libraries that further use a FINAL_LIBRARY. r=mshal
2014-07-23 08:37:51 +09:00
d2275113b1
Bug 1028588 - Fix dangerous public destructors in embedding/ - r=bsmedberg
2014-06-30 18:11:52 -04:00
03da42e8b1
Backed out 4 changesets (bug 1028588) for build bustage
...
Backed out changeset 13a8bae671ca (bug 1028588)
Backed out changeset 19a19833f1d6 (bug 1028588)
Backed out changeset d5fae80054de (bug 1028588)
Backed out changeset 5942ad3859b8 (bug 1028588)
2014-06-30 15:50:19 -07:00
a545b282f5
Bug 1028588 - Fix dangerous public destructors in embedding/ - r=bsmedberg
2014-06-30 18:11:52 -04:00
adbca85446
Bug 984123, part 2 - Converted nsTArray<char*> to nsTArray<nsCString>. r=ehsan
2014-05-13 09:46:37 -07:00
019dac0cff
Backed out changeset 22994a1e0af4 for having the wrong author.
2014-05-13 09:45:41 -07:00
0ecdc47c59
Bug 984123, part 2 - Convert nsTArray<char*> to nsTArray<nsCString>. r=ehsan
2014-05-13 09:42:41 -07:00
5fabe16c55
Bug 984123, part 1 - Convert nsControllerCommandGroup::mGroupsHash and nsGroupsEnumerator::mHashtable to nsClassHashtable. r=ehsan
2014-05-13 09:42:41 -07:00
8ba3be8772
Bug 997987 - Cache the system principal on nsContentUtils and remove nsIScriptSecurityManager::SubjectPrincipalIsSystem. r=Ms2ger,sr=bz
2014-05-06 15:43:03 -07:00
5f1fde8824
Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj
2014-04-27 03:06:00 -04:00
4136c664aa
Bug 474369 - remove nsVoidArray includes; r=ehsan
...
--HG--
extra : rebase_source : dd3abeb623fd8b784fd6ba639c88def84a4daf58
2014-04-26 16:12:45 +02:00
Nicholas Nethercote
Kyle Huey
Nathan Froyd
Bobby Holley
Chris Peterson
Andrew McCreight
Birunthan Mohanathas
Mike Hommey
Trevor Saunders
Phil Ringnalda
Michael Pruett
Neil Deakin
Wes Kocher
Ehsan Akhgari
Benoit Jacob
Anuj Agarwal
Andrew McCreight
Arpad Borsos