This patch does a couple of things:
* I added a new class, |WindowsError| to WinHeaderOnlyUtils. The idea here is
to encapsulate as much of the Windows error gamut as possible into one class.
Since Win32 errors and NTSTATUS codes may both be encoded as HRESULTs, I
used the latter type to store the error. It also contains functions for
converting between the various error code formats, as well as stringification
via FormatMessage.
* I added |LauncherError| which also includes file and line number information,
which I believe will be important for launcher process failure diagnostics.
(Instantiation of LauncherErrors obviously must be done via macros to capture
__FILE__ and __LINE__).
* I then converted all of the launcher process code (and its few depenencies) to
utilize this new functionality via the new |LauncherResult| type.
* If we detect an error in one of the top-level launcher process functions, we
pass it to |HandleLauncherError| for processing. This function currently just
throws up a |MessageBox| like the previous code did, with the intention of
enhancing that further in the future.
Differential Revision: https://phabricator.services.mozilla.com/D12365
--HG--
extra : moz-landing-system : lando
This removes the wrapping box inside the anonymous content, and replaces
the anonymous label with an ::after CSS rule that sets text based on
the [title] attribute.
Because it doesn't replicate the anonymous wrapping box with light DOM:
- Calling JS don't need to be updated (the child added via appendChild
is still a direct descendant of the element).
- Many CSS selectors don't need to be updated (if they were targeting the
slotted children as direct descendants. However, CSS selectors that were
targeting the anonymous content directly do need to be updated, since those
nodes are removed.
Differential Revision: https://phabricator.services.mozilla.com/D12172
--HG--
extra : moz-landing-system : lando
Removed comment about Firefox 27 and below since it is no longer relevant after the LZMA watershed
Changed a couple of comments for clarity
Differential Revision: https://phabricator.services.mozilla.com/D12424
--HG--
extra : moz-landing-system : lando
Still not sure what is the root issue here, but none of the regular connect tests are failing so I think the issue occurs when we remove tabs in the second step.
Differential Revision: https://phabricator.services.mozilla.com/D12332
--HG--
extra : moz-landing-system : lando
Move JSON dump loading and CanonicalJSON serialization to a worker to reduce impact on main thread
Differential Revision: https://phabricator.services.mozilla.com/D10064
--HG--
extra : moz-landing-system : lando
This one's a little trickier than the others because it has an implicit
default value of 0 for initial calls to AddValue and SetMaximum.
Depends on D12129
Differential Revision: https://phabricator.services.mozilla.com/D12130
--HG--
extra : moz-landing-system : lando
ScalarBase needs to transform from store names to indices and provide
storage and logic for which stores have values.
Depends on D12128
Differential Revision: https://phabricator.services.mozilla.com/D12129
--HG--
extra : moz-landing-system : lando
This patch does a couple of things:
* I added a new class, |WindowsError| to WinHeaderOnlyUtils. The idea here is
to encapsulate as much of the Windows error gamut as possible into one class.
Since Win32 errors and NTSTATUS codes may both be encoded as HRESULTs, I
used the latter type to store the error. It also contains functions for
converting between the various error code formats, as well as stringification
via FormatMessage.
* I added |LauncherError| which also includes file and line number information,
which I believe will be important for launcher process failure diagnostics.
(Instantiation of LauncherErrors obviously must be done via macros to capture
__FILE__ and __LINE__).
* I then converted all of the launcher process code (and its few depenencies) to
utilize this new functionality via the new |LauncherResult| type.
* If we detect an error in one of the top-level launcher process functions, we
pass it to |HandleLauncherError| for processing. This function currently just
throws up a |MessageBox| like the previous code did, with the intention of
enhancing that further in the future.
Differential Revision: https://phabricator.services.mozilla.com/D12365
--HG--
extra : moz-landing-system : lando
This one's a little trickier than the others because it has an implicit
default value of 0 for initial calls to AddValue and SetMaximum.
Depends on D12129
Differential Revision: https://phabricator.services.mozilla.com/D12130
--HG--
extra : moz-landing-system : lando
ScalarBase needs to transform from store names to indices and provide
storage and logic for which stores have values.
Depends on D12128
Differential Revision: https://phabricator.services.mozilla.com/D12129
--HG--
extra : moz-landing-system : lando
Ehsan Akhgari
shindli
Brindusan Cristian
Aaron Klotz
Razvan Caliman
Dão Gottwald
Tom Schuster
Brian Grinstead
Drew Willcoxon
arthur.iakab
Martin Stransky
Robert Strong
Patrick Brosset
Julian Descottes
Mathieu Leplatre
Tooru Fujisawa
Wes Kocher
Chris H-C
WR Updater Bot
Narcis Beleuzu
Jonathan Kingston
Andrew McCreight