Still not sure what is the root issue here, but none of the regular connect tests are failing so I think the issue occurs when we remove tabs in the second step.
Differential Revision: https://phabricator.services.mozilla.com/D12332
--HG--
extra : moz-landing-system : lando
The patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1467076 discards previous TextProperty instances for the element's inline style when the inline style is updated.
On start, the Shape Path Editor kept a reference to the original TextProperty instance. This outdated instance caused the update mechanism of the Shape Path Editor to fail.
This patch fixes the issue by keeping metadata (index and property name) about the TextProperty to re-identify the correct one when needed instead of relying on a potentially outdated reference.
Differential Revision: https://phabricator.services.mozilla.com/D12157
--HG--
extra : moz-landing-system : lando
- Add a new 12px round icon for Console errors.
- Update the warning (triangle) icon to use the same 12px size.
- Update the info icon to use the same 12px size,
and differentiate its design from the error icon.
- Tweak the Console's input and return icons to be a tiny bit
bigger (for better overall visual balance) and crisper @1x.
Differential Revision: https://phabricator.services.mozilla.com/D12250
--HG--
rename : devtools/client/themes/images/devtools-components/checkbox.svg => devtools/client/themes/images/checkbox.svg
extra : moz-landing-system : lando
As we were using the browserWindow to start the
parser worker, this was causing an exception
when evaluation from the browser toolbox.
Using chromUtilsWindow fixes the issue.
There is no tests yet as I'm not sure there's
an easy way to test things in the browser toolbox.
Differential Revision: https://phabricator.services.mozilla.com/D12101
--HG--
extra : moz-landing-system : lando
This pleases clang-format and makes many of these behave better when
auto formatted. Special cases may still be marked |clang-format off| in
later commits.
Differential Revision: https://phabricator.services.mozilla.com/D12231
--HG--
extra : moz-landing-system : lando
String.fromCharCode(...charCodes) is limited by the maximum number of arguments that SpiderMonkey
can pass on the stack, if the screenshot gets to large this can easily fail.
Differential Revision: https://phabricator.services.mozilla.com/D12218
--HG--
extra : moz-landing-system : lando
Depends on D11506
Removes the `fonts` field from the Redux slice previously used by the FontOverview component
in the Font Inspector version of the Fonts panel. This field is duplicated with the `fonts`
used by the Font Editor. The telemetry can use that one instead.
Refactors the update() method which updates the Redux slice for the FontOverview component.
In time, the update() and refreshFontEditor() method will merge. So will the Redux slices:
`fontEditor` and `fonts` in order to save a duplicate call to the server for `allFonts`.
Differential Revision: https://phabricator.services.mozilla.com/D11507
--HG--
extra : moz-landing-system : lando
Depends on D11505
The `otherFonts` field in the Redux store slice for Fonts was used by the old Font Inspector to differentiate
between fonts on the element and fonts elsewhere on the page. This is no longer used with the Font Editor.
Differential Revision: https://phabricator.services.mozilla.com/D11506
--HG--
extra : moz-landing-system : lando
This patch removes the `devtools.inspector.fonteditor.enabled` pref and all its uses in the Fonts panel.
Obsolete actions for the case when the pref was off are also removed. This is mostly old Font Inspector code.
One test is temporarily disabled because it tests the old Font Inspector. It will be removed along with other
pieces on the next part of this commit series.
Differential Revision: https://phabricator.services.mozilla.com/D11505
--HG--
extra : moz-landing-system : lando
shindli
Razvan Caliman
Tom Schuster
Patrick Brosset
Julian Descottes
Csoregi Natalia
Gabriel Luong
arthur.iakab
Andrew Osmond
Florens Verschelde
Nicolas Chevobbe
Andreea Pavel
Razvan Maries
Micah Tigley
Logan Smyth
Michael Ratcliffe
Ted Campbell
Brian Hackett
Cosmin Sabou
Gurzau Raul
Jason Laster
Bogdan Tara
Yura Zenevich
Noemi Erli
Margareta Eliza Balazs