Alexandru Michis
bf70c93173
Backed out changeset 92b9d5110599 (bug 1728843) for causing bc failures in browser_urlbar_telemetry_quicksuggest.js
...
CLOSED TREE
2021-09-09 04:23:16 +03:00
Kate Hudson
7ce670b735
Bug 1728843 - Add once option to NimbusFeatures.recordExposureEvent r=andreio
...
Depends on D123763
Differential Revision: https://phabricator.services.mozilla.com/D124381
2021-09-09 00:20:56 +00:00
Harry Twyford
35a9338ef1
Bug 1727321 - Part 4 - Stop using color variables elsewhere in newtab. r=thecount
...
Differential Revision: https://phabricator.services.mozilla.com/D124401
2021-09-08 22:06:27 +00:00
Harry Twyford
f2159ae4bb
Bug 1727321 - Part 3 - Stop using color variables in box-shadows. r=thecount
...
Differential Revision: https://phabricator.services.mozilla.com/D124399
2021-09-08 22:06:27 +00:00
Harry Twyford
76660d9a3a
Bug 1727321 - Part 2 - Stop using color variables in buttons. r=thecount
...
Differential Revision: https://phabricator.services.mozilla.com/D124398
2021-09-08 22:06:26 +00:00
Harry Twyford
f459f79ac1
Bug 1727321 - Part 1 - Stop using color variables in links. r=thecount
...
The purpose of this stack of patches is to stop using color variables directly in newtab CSS in favour of the semantic variables defined in _theme.scss. That way, we can later refactor _theme.scss to use theme variables instead of hardcoded colors.
There's a lot of dead CSS/components in new tab. This stack of patches refactors dead code as well, mostly because it's not clear what is dead and what is not. I tried to keep things generally looking the same on visible surfaces, but there are some minor style differences in dead components and in asrouter devtools. I spoke to Mardak on Slack and he confirmed it would be okay to slightly change the look of dead components. Scott, I tagged you for review since you know what is dead and what is not.
Differential Revision: https://phabricator.services.mozilla.com/D124397
2021-09-08 22:06:26 +00:00
Harry Twyford
b5240599b1
Bug 1726432 - Part 4 - Remove unused variables. r=amy
...
Differential Revision: https://phabricator.services.mozilla.com/D123387
2021-09-08 22:06:26 +00:00
Harry Twyford
515214b4b2
Bug 1726432 - Part 3 - Consolidate variables with their '-nte' equivalents. r=amy
...
Differential Revision: https://phabricator.services.mozilla.com/D123386
2021-09-08 22:06:25 +00:00
Harry Twyford
c078dc6309
Bug 1726432 - Part 2 - Consolidate newtab-background-secondary variable. r=amy
...
This is the variable we will eventually replace with ntp_secondary or equivalent.
Differential Revision: https://phabricator.services.mozilla.com/D123385
2021-09-08 22:06:25 +00:00
Harry Twyford
6412750cc1
Bug 1726432 - Part 1 - Remove newtab-experience class. r=amy
...
Differential Revision: https://phabricator.services.mozilla.com/D123384
2021-09-08 22:06:24 +00:00
Harry Twyford
0dead9fc50
Bug 1710937
- Part 6 - Remove code related to showing fallback screenshots in Top Sites. r=amy
...
I confirmed with Julian Gaibler that we don't want to show screenshots as fallbacks in Top Sites. We still want to support custom icons and screenshots in the "Recent activity" section, both of which are unchanged.
Differential Revision: https://phabricator.services.mozilla.com/D123253
2021-09-08 22:06:24 +00:00
Harry Twyford
5cf6fcb5d3
Bug 1710937
- Part 5 - Remove tests related to context menu icons and clicking section headers. r=amy
...
Differential Revision: https://phabricator.services.mozilla.com/D123252
2021-09-08 22:06:23 +00:00
Harry Twyford
4bd0072837
Bug 1710937
- Part 4 - Remove SectionMenus and section header icons. r=amy
...
Differential Revision: https://phabricator.services.mozilla.com/D123251
2021-09-08 22:06:23 +00:00
Harry Twyford
8ea982bd9e
Bug 1710937
- Part 3 - Remove tests concerning the differences between old-new-tab and new-new-tab. r=amy
...
Differential Revision: https://phabricator.services.mozilla.com/D123250
2021-09-08 22:06:23 +00:00
Harry Twyford
5cc7c537db
Bug 1710937
- Part 2 - Remove showCustomizationMenu pref and associated code. r=amy
...
Differential Revision: https://phabricator.services.mozilla.com/D123249
2021-09-08 22:06:22 +00:00
Harry Twyford
b507dc7cac
Bug 1710937
- Part 1 - Remove newNewTabExperienceEnabled pref and associated code. r=amy,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D123248
2021-09-08 22:06:22 +00:00
Marian-Vasile Laza
e0469a2db1
Backed out changeset 47b9c109e74c (bug 1728843) for causing bc failures on browser_urlbar_telemetry_quicksuggest.js. CLOSED TREE
2021-09-07 18:45:09 +03:00
Kate Hudson
a2367c38e3
Bug 1728843 - Add once option to NimbusFeatures.recordExposureEvent r=andreio
...
Depends on D123763
Differential Revision: https://phabricator.services.mozilla.com/D124381
2021-09-07 13:49:51 +00:00
Dan Mosedale
8965d0c0ca
Bug 1728238 - Implement VPN promo UI look, r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D124285
2021-09-04 01:25:34 +00:00
Andrei Oprea
681df612a2
Bug 1728420 - New messaging surface Spotlight r=Mardak,dmose,nanj
...
Differential Revision: https://phabricator.services.mozilla.com/D121913
2021-09-03 13:41:21 +00:00
Andrei Oprea
c87975af29
Bug 1723758 - Ensure all Nimbus features explicitly call method to send exposure r=k88hudson
...
Differential Revision: https://phabricator.services.mozilla.com/D123422
2021-09-03 13:04:51 +00:00
Emily McMinn
7572eaf3fd
Bug 1724979 - Remove Osfile.jsm from AboutWelcomeParent r=emalysz
...
Differential Revision: https://phabricator.services.mozilla.com/D124085
2021-08-31 18:50:13 +00:00
Scott
410f203dfc
Bug 1725160 - Fixing newtab Pocket context menu position. r=gvn,zbraniecki
...
Differential Revision: https://phabricator.services.mozilla.com/D123152
2021-08-26 07:06:55 +00:00
Butkovits Atila
01fae6d8b0
Backed out changeset 51400ee7a844 (bug 1725160) for causing failures at browser_newtab_last_LinkMenu.js.
2021-08-25 21:15:57 +03:00
Scott
64f1a75c50
Bug 1725160 - Fixing newtab Pocket context menu position. r=gvn,zbraniecki
...
Differential Revision: https://phabricator.services.mozilla.com/D123152
2021-08-25 15:41:26 +00:00
Tom Ritter
f492e82a10
Bug 1723204: Update tests to prevent crashes r=ckerschb,jdescottes,robwu
...
This is most commonly as a result of CU.evalInSandbox which
allows an arbitrary filename but when omitted will default
to the filename of the test, which is a filesystem path
and thus is disallowed.
Differential Revision: https://phabricator.services.mozilla.com/D122246
2021-08-24 14:57:44 +00:00
Brindusan Cristian
dfcfe1d342
Backed out 4 changesets (bug 1724220, bug 1723204) for causing cpp non-unified bustages in TestSmartCrashTrimmer.cpp.
...
CLOSED TREE
Backed out changeset 0dab9553a2a8 (bug 1724220)
Backed out changeset df236c937895 (bug 1723204)
Backed out changeset 4a20d1832cf4 (bug 1723204)
Backed out changeset d7e4042af76c (bug 1723204)
2021-08-24 15:33:32 +03:00
Tom Ritter
2dd9a03c60
Bug 1723204: Update tests to prevent crashes r=ckerschb,jdescottes,robwu
...
This is most commonly as a result of CU.evalInSandbox which
allows an arbitrary filename but when omitted will default
to the filename of the test, which is a filesystem path
and thus is disallowed.
Differential Revision: https://phabricator.services.mozilla.com/D122246
2021-08-24 11:20:44 +00:00
Emily McMinn
5c13a00393
Bug 1720762 - Remove unused onboarding strings and images r=dmose
...
Differential Revision: https://phabricator.services.mozilla.com/D120997
2021-08-24 00:46:29 +00:00
Andrei Oprea
0a4ffe90a7
Bug 1726739 - Adjust profile activity related targeting to 28 day time interval r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D123212
2021-08-23 17:51:26 +00:00
Andrei Oprea
d68559b9bd
Bug 1726401 - Remove about_newtab_with_snippets perf test r=perftest-reviewers,AlexandruIonescu
...
Differential Revision: https://phabricator.services.mozilla.com/D123105
2021-08-23 15:15:10 +00:00
Michelle Goossens
c7d34da2f9
Bug 1723574 - Enable mochitest-browser-chrome tests that no longer fail r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D123247
2021-08-23 12:45:31 +00:00
Dan Mosedale
70e89e9be7
Bug 1721516 - land npm audit fixes for newtab, r=emcminn
...
Differential Revision: https://phabricator.services.mozilla.com/D120422
2021-08-23 04:54:25 +00:00
Dan Mosedale
b241042f6c
Bug 1703566 - update many old newtab dependencies, r=emcminn
...
Differential Revision: https://phabricator.services.mozilla.com/D120396
2021-08-23 04:54:25 +00:00
Butkovits Atila
f0d3689c30
Backed out 3 changesets (bug 1724108) as requested by Dan. CLOSED TREE
...
Backed out changeset 0bdbea37f84f (bug 1724108)
Backed out changeset 91aa3dd65624 (bug 1724108)
Backed out changeset 5e57386eae33 (bug 1724108)
2021-08-21 01:06:14 +03:00
Michelle Goossens
d192833f8d
Bug 1723574 - Migrate Windows 10 mochitest-browser-chrome suite from AWS to Azure r=jmaher,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D122511
2021-08-20 20:55:02 +00:00
Andrei Oprea
dae1779589
Bug 1725131 - Remove messaging system code related to the Bookmark panel r=pdahiya,Mardak,webdriver-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D122342
2021-08-19 13:17:13 +00:00
Mark Banner
6d6d74aa14
Bug 1724249 - Don't add interactions if they are part of the adult filter list. r=amy
...
Differential Revision: https://phabricator.services.mozilla.com/D121892
2021-08-13 19:24:20 +00:00
Dan Mosedale
2575056f16
Bug 1724108 - switched browser_trigger_listeners to new vpn promo event, r=andreio
...
Differential Revision: https://phabricator.services.mozilla.com/D122064
2021-08-11 22:27:38 +00:00
Andrei Oprea
962fb81710
Bug 1724966 - Fix newtab test setup to be independent of timezones r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D122286
2021-08-11 09:14:28 +00:00
Nan Jiang
00f5f2fce4
Bug 1721525 - Replace Cu.reportError with log warnings for Contile r=mythmon
...
Differential Revision: https://phabricator.services.mozilla.com/D122285
2021-08-10 20:07:24 +00:00
Andrei Oprea
9ac6da2477
Bug 1724688 - Fix browser_asrouter_cfr.js mochitest that references non existent icon r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D122100
2021-08-10 11:17:18 +00:00
Ben Hearsum
aecb82dbfc
Bug 1714200: skip failing mochitest-browser-chrome tests on M1 machines r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D121221
2021-08-06 19:16:54 +00:00
Punam Dahiya
8f8983a975
Bug 1721614 - Handle blank onboarding screen on navigating back from about:home r=andreio
...
Differential Revision: https://phabricator.services.mozilla.com/D121037
2021-08-04 23:04:22 +00:00
Andrei Oprea
aa77a57273
Bug 1721178 - Add targeting trigger for successful captive portal login r=dmose
...
Differential Revision: https://phabricator.services.mozilla.com/D120730
2021-08-04 20:22:05 +00:00
Zibi Braniecki
cf6ed1b3fc
Bug 1613705 - [localization] part14: Fix browser_topsites_contextMenu_options test to not be racy. r=Mardak
...
Depends on D116739
Differential Revision: https://phabricator.services.mozilla.com/D116753
2021-08-03 16:25:15 +00:00
Zibi Braniecki
73e2cbd0aa
Bug 1613705 - [localization] part13: Fix newtab asrouter RemoteL10n test. r=Mardak
...
Depends on D116738
Differential Revision: https://phabricator.services.mozilla.com/D116739
2021-08-03 16:25:15 +00:00
Zibi Braniecki
879ddf9634
Bug 1613705 - [localization] part3: Introduce passing Registry to Localization to replace BundleGenerator argument. r=emilio,nika
...
Depends on D104789
Differential Revision: https://phabricator.services.mozilla.com/D111178
2021-08-03 16:25:11 +00:00
Nika Layzell
29295703f8
Bug 1715773 - Remove preloaded newtab process selection logic, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D121423
2021-08-03 15:17:07 +00:00
Butkovits Atila
949da905e7
Backed out 19 changesets (bug 1613705) for causing build bustages complaining about Document.cpp. CLOSED TREE
...
Backed out changeset 2ee1091dd20d (bug 1613705)
Backed out changeset d377afc0b09f (bug 1613705)
Backed out changeset de9d4378f0ac (bug 1613705)
Backed out changeset 9843372abb6e (bug 1613705)
Backed out changeset 5fc5918e5905 (bug 1613705)
Backed out changeset a7aeae7afd49 (bug 1613705)
Backed out changeset 5d61617a5402 (bug 1613705)
Backed out changeset 85bf98573899 (bug 1613705)
Backed out changeset 175af8a1b8c2 (bug 1613705)
Backed out changeset 93fcb23d7898 (bug 1613705)
Backed out changeset 595529cd906f (bug 1613705)
Backed out changeset 9f3e2963d925 (bug 1613705)
Backed out changeset 442289058933 (bug 1613705)
Backed out changeset fc3b9acb0e81 (bug 1613705)
Backed out changeset 408983c64f7f (bug 1613705)
Backed out changeset 08b637fc3fcd (bug 1613705)
Backed out changeset 6ef0aafd2db0 (bug 1613705)
Backed out changeset d88b294e0a5e (bug 1613705)
Backed out changeset e6bebff87544 (bug 1613705)
2021-08-03 12:36:01 +03:00