Andreas Pehrson
60f3567035
Bug 1440040 - Don't round up to next block unless necessary. r=padenot
...
With block size 128, rounding `128` to end of next block gives `256`, which is
not what we want when running MSG iterations. That could mean over-iterating and
buffering unnecessary amounts of silence.
MozReview-Commit-ID: vW14l2ygRy
--HG--
extra : rebase_source : 8aeedc8958e646f9730c9163447e3355a73fd42e
2018-02-28 22:37:02 +01:00
Alex Chronopoulos
c8882611dc
Bug 1410456 - use jni methods in place of removed cubeb methods. r=padenot
...
MozReview-Commit-ID: 18fQVZeYAgk
--HG--
extra : rebase_source : 67b9df3bdfb22d2baa05a15f6535af8d3d5c12d9
2018-02-20 15:37:07 +02:00
Narcis Beleuzu
5968b0947f
Backed out 10 changesets (bug 1410456) for Android mochitest crashes, e.g. in test_postMessages.html. CLOSED TREE
...
Backed out changeset 7ec175446efd (bug 1410456)
Backed out changeset 94457911bb24 (bug 1410456)
Backed out changeset 5248a21216ae (bug 1410456)
Backed out changeset f182ab7885db (bug 1410456)
Backed out changeset e482347bdae3 (bug 1410456)
Backed out changeset f7b646045e06 (bug 1410456)
Backed out changeset 6a8ed4bf5d2f (bug 1410456)
Backed out changeset 1a9c687ec277 (bug 1410456)
Backed out changeset 82f6667c6758 (bug 1410456)
Backed out changeset 7bf358e3e01b (bug 1410456)
2018-02-26 15:58:20 +02:00
Alex Chronopoulos
816b44e1a0
Bug 1410456 - use jni methods in place of removed cubeb methods. r=padenot
...
MozReview-Commit-ID: 18fQVZeYAgk
--HG--
extra : rebase_source : 67b9df3bdfb22d2baa05a15f6535af8d3d5c12d9
2018-02-20 15:37:07 +02:00
Dorel Luca
037478c033
Backed out 9 changesets (bug 1410456) for Mochitest failure on mobile/android/tests/browser/chrome/test_media_playback.html
...
Backed out changeset 36f6b40dfa88 (bug 1410456)
Backed out changeset 19f3248502d9 (bug 1410456)
Backed out changeset 18ef18999175 (bug 1410456)
Backed out changeset 0ec75a56b4c7 (bug 1410456)
Backed out changeset f7eae1545d5e (bug 1410456)
Backed out changeset d59060ecd24c (bug 1410456)
Backed out changeset f996b9dce4a6 (bug 1410456)
Backed out changeset 1f75636b5bce (bug 1410456)
Backed out changeset c170d37b1a04 (bug 1410456)
2018-02-19 21:45:10 +02:00
Alex Chronopoulos
33dc85d377
Bug 1410456 - use jni methods in place of removed cubeb methods. r=padenot
...
MozReview-Commit-ID: 7DqORSl0Sm2
--HG--
extra : rebase_source : 4559b6a65297bf3b2c70f33b6ab27e612a0fced2
2018-02-19 18:28:10 +02:00
Karl Tomlinson
df12c01556
bug 1436267 fallback from audio callback to system clock driver on error only once r=padenot
...
Usually, mShouldFallbackIfError has been reset to false in DataCallback()
before Stop() is called. However, if fallback to a system clock driver due to
cubeb error had already occurred, then mShouldFallbackIfError would not have
been reset, and Stop() is still called. With mShouldFallbackIfError still
true, a cubeb error in stop would have created another fallback thread.
I expect that resetting mShouldFallbackIfError in Stop() would also be an
effective alternative solution, but resetting on StateCallback() happens
earlier, which would be an advantage if any additional errors could possibly
be reported to StateCallback().
MozReview-Commit-ID: E9j7PQmS3O4
--HG--
extra : rebase_source : 200993c9e99475101c429005cfadb7260df29067
2018-02-07 20:16:01 +13:00
Andreas Pehrson
c09c157cde
Bug 1408294 - Assert that we don't underrun globally. r=padenot
...
MozReview-Commit-ID: 1vEN1K1TK5n
--HG--
extra : rebase_source : e2bcc28d52b28e741e8a114db4cee9880abf6562
2017-12-01 15:37:54 +01:00
Andreas Pehrson
0ac2875a3d
Bug 1408294 - Set iteration state before calling NotifyInputData. r=padenot
...
In the MediaEngine for microphone capture we want to fall back on feeding
silence when the device is stopped. To ensure this doesn't go haywire we check
that the invariant that at most one of NotifyInputData and NotifyPull get
called in the same iteration.
For them to be aligned on which iteration they're in however, the graph needs
to report a consistent IterationEnd() to both. This patch fixes this by only
calling into NotifyInputData() *after* setting iteration state, which will then
be consistent also across OneIteration (which calls into NotifyPull).
MozReview-Commit-ID: 4lD4OcdGtM6
--HG--
extra : rebase_source : 397ee320b83b23ac21961b67341b774f18e8b51b
2017-11-28 13:32:21 +01:00
Bryce Van Dyk
37dd875199
Bug 1432869 - Update usage of cubeb_stream_params to set newly exposed prefs member. r=achronop
...
The changes to the cubeb API mean that the new prefs member on
cubeb_stream_params should be explicitly set. This changeset does so.
MozReview-Commit-ID: 1hwjLTriaBP
--HG--
extra : rebase_source : f32c4a0a945ed7a048ca40c7286024da1fb93473
2018-01-22 13:20:29 -05:00
Paul Adenot
b73774d1b2
Bug 1370598 - Don't cap latency at 512 frames on Macs that are not Macbooks or Macbook Air. r=achronop
...
MozReview-Commit-ID: LEquEPECH9P
--HG--
extra : rebase_source : a0cb2a435b6b211ebb432b1f13cf8bf5878906be
2018-01-16 16:44:34 +01:00
Karl Tomlinson
a848c67de0
bug 1418820 add diagnostic asserts to check for multiple concurrent drivers r=padenot
...
MozReview-Commit-ID: 5nRELgRkjQY
--HG--
extra : rebase_source : cc08e88c88e7997a2808aa6c1f59f8a70cd7f191
2017-12-21 20:08:21 +13:00
Alex Chronopoulos
53b3d41122
Bug 1426174 - New reentrant get layout method to solve synchronization issues. r=jesup
...
MozReview-Commit-ID: JwOAjuO22bd
--HG--
extra : rebase_source : 953c4ee8df470968a7ba4da4962c7b0631781309
2017-12-20 20:52:06 +02:00
Alex Chronopoulos
ada70b6339
Bug 1418694 - Use channel layout to avoid failures when default layout is not set. r=padenot
...
MozReview-Commit-ID: FzdJQYi35yQ
--HG--
extra : rebase_source : b8460d156ea933d2f87982e38d23502bba7226e1
2017-12-15 18:02:39 -06:00
Narcis Beleuzu
a8f33facb2
Backed out changeset db713228c8e3 (bug 1425150) for wpt failures on core/platform.cpp r=abackout on a CLOSED TREE
2017-12-14 23:23:20 +02:00
Paul Adenot
17ca0b45f8
Bug 1425150 - Register AudioCallbackDriver to the Gecko Profiler. r=jya
...
MozReview-Commit-ID: 3rJbF8Kq0zx
--HG--
extra : rebase_source : 49719ea92da9c1c556b1c3d10a06d3f2cdc3b08f
2017-12-13 17:10:14 -06:00
Alex Chronopoulos
758db182f3
Bug 1419378 - Fail before stream init when output number of channels is zero. r=padenot
...
MozReview-Commit-ID: G2bjXhAXiqz
--HG--
extra : rebase_source : 21cf22e4afd4065835a5323ed0ab44a55035f0db
2017-11-28 12:57:02 +02:00
Karl Tomlinson
2f98789374
bug 1382366 disable AudioCallback -> SystemClockDriver fallback before disowning graph f=pehrsons r=padenot
...
MozReview-Commit-ID: ESr6yxjPVWf
--HG--
extra : histedit_source : eb60aa28970548a65b31e79ba0c7efaaf27268cc
2017-11-04 19:00:46 +13:00
Karl Tomlinson
ef7235b44f
bug 1382366 move declaration of mWaitState to SystemClockDriver f=pehrsons r=padenot
...
MozReview-Commit-ID: IBqJRjL2Ruk
--HG--
extra : histedit_source : bf467862aa715292c446fa037958338993096441
2017-11-04 11:02:52 +13:00
Karl Tomlinson
7c98745089
bug 1408276 move to LIFECYCLE_WAITING_FOR_MAIN_THREAD_CLEANUP at end of iteration f=pehrsons r=padenot
...
MozReview-Commit-ID: GbfIOPZPuGu
--HG--
extra : rebase_source : 8a7abbe8a96a90f20dbb0465b6a5f69f05140d4f
extra : amend_source : 41079a2a825b53ed6d4e8cc31fc4c8de2f041e8b
extra : histedit_source : df5b962ac253df34ace8ebc22cdd98b608b6ddfb
2017-10-17 18:14:43 +13:00
Karl Tomlinson
9aec4911f8
bug 1408276 remove unused GraphDriver::Destroy() r=padenot
...
MozReview-Commit-ID: 1eonMAWKubq
--HG--
extra : amend_source : bc4193e7041b25407422d49e4e12c81d24c66e72
2017-10-09 22:09:00 +13:00
Karl Tomlinson
a7bb0b6a26
bug 1406830 store the AsyncCubeTask SharedThreadPool reference on the AudioCallbackDriver r=jesup,padenot
...
The first AsyncCubebTask dispatch from AudioCallbackDriver::Start() may either
be from MediaStreamGraphImpl::RunInStableState() on the main thread or
ThreadedDriver::RunThread() on a threaded driver thread.
These could potentially occur concurrently when there are multiple
MediaStreamGraphs.
This change removes the race around setting sThreadPool.
SharedThreadPool::Get() would have returned the same pointer, and so
that race was probably mostly benign apart from the potential to add an
extra reference and so hang on shutdown in SharedThreadPool::SpinUntilEmpty().
Storing the reference to the SharedThreadPool on the object using it is the
typical way to use SharedThreadPool. It lets the thread pool be released when
not in use, and lets SharedThreadPool deal with multi-thread access and
shutdown.
MozReview-Commit-ID: 8WutVsAMfJo
--HG--
extra : rebase_source : a3d0ce75d65889fff47389ccd80640c3f1150244
2017-09-26 17:28:17 +13:00
Karl Tomlinson
7299e56b0b
bug 1406830 reimplement Shutdown() as virtual separately on each driver r=padenot
...
moving Stop() to AudioCallbackDriver only.
MozReview-Commit-ID: 9atG8R4wAsY
--HG--
extra : rebase_source : 0addeae733c001f4e5c6cd2d55cbb0b069863864
2017-09-28 15:05:36 +13:00
Karl Tomlinson
4f358ada69
bug 1406830 remove unused GraphDriver::Resume() r=padenot
...
MozReview-Commit-ID: IPpyxOHESLW
--HG--
extra : rebase_source : 404e86e6db9c42df64d306697e13b6da1f0c793c
2017-09-28 14:55:20 +13:00
Paul Adenot
6e6f676da0
Bug 1403041 - Don't re-enter libcubeb from the audio thread. r=kinetik
...
This delays initializing the channel count until actually initializing the
cubeb stream for an AudioCallbackDriver.
The constructor of an AudioCallbackDriver is usually called from the previous
driver's thread (be it a system thread or the audio callback, the exception
being when it's the first time a GraphDriver is being created), while the
AudioCallbackDriver::Init method is always called from a special thread that is
specially created to run potentially long and blocking operations, such as
creating an audio stream.
MozReview-Commit-ID: GFx85N8PlKX
2017-09-28 16:57:46 +02:00
Paul Adenot
ec46b8ffb1
Bug 1403041 - Fix typo in AudioCallbackDriver member. r=kinetik
...
s/mOuputChannelCount/mOutputChannelCount/
MozReview-Commit-ID: Kv03aSKnfQa
2017-09-26 12:05:01 +02:00
Andreas Pehrson
3e7a54981e
Bug 1360334 - Improve error handling. r=padenot
...
MozReview-Commit-ID: 5tIXzzisg0V
--HG--
extra : source : 0dc85355af3d166038ccf6e0fd161bd614b0ead2
2017-09-08 16:41:36 +02:00
Sebastian Hengst
3a76476175
Backed out changeset a3eabb355005 (bug 1360334) for build bustaget at dom/media/GraphDriver.cpp:200: cannot pass non-trivial object of type 'RefPtr<mozilla::GraphDriver>' to variadic function. r=backout on a CLOSED TREE
2017-09-09 18:00:49 +02:00
Andreas Pehrson
0bdbb7d2aa
Bug 1360334 - Improve error handling. r=padenot
2017-09-08 16:41:36 +02:00
Alex Chronopoulos
087f9c1689
Bug 1392837 - Support multichannel audio input on gUM. r=padenot
...
MozReview-Commit-ID: FKCIAo4a8jy
--HG--
extra : rebase_source : 2f72331514909f418580e3c7c8bcc445e74167c8
2017-09-04 17:26:03 +03:00
Alex Chronopoulos
eb4205d7a8
Bug 1395195 - Restrict min number of channels on AudioCallbackDriver's helper buffers. r=padenot
...
MozReview-Commit-ID: 5eAhN4x6U4q
--HG--
extra : rebase_source : 0445dc820222ae51b74e277995baf423190cff7e
2017-08-31 16:43:01 +03:00
Chun-Min Chang
b0e140e2a2
Bug 1392930 - part 3: Make AudioCallbackDriver inherit from DeviceChangeListener; r=padenot
...
--HG--
extra : rebase_source : a6d87257004fe4954044c0ccd70ca4b4f597099a
2017-08-29 17:45:44 +08:00
Alex Chronopoulos
c9d4805a3f
Bug 1378070 - Implement multichannel WebAudio. r=padenot
...
* * *
[mq]: rebase
MozReview-Commit-ID: KJwH3ZeJn55
--HG--
extra : rebase_source : 0e9866c8dc5ccb98a9654c1e18b0bcef1ef5afa8
2017-08-28 17:16:20 +03:00
Paul Adenot
a202254933
Bug 1388243 - r=jesup
...
MozReview-Commit-ID: Jexghw0QFrB
--HG--
extra : amend_source : 624073ea6dc7c13728945a0feebf10f891c33174
2017-08-21 11:56:13 +01:00
Matthew Gregan
2f8cc7804c
Bug 1388236 - Remove B2G-only AudioChannel code from MSG. r=padenot
2017-08-10 13:00:08 +12:00
Matthew Gregan
f4d992a821
Bug 1388229 - Remove B2G-only audio stream type handling. r=kamidphish
2017-08-10 13:00:07 +12:00
Eric Rahm
01f545fea7
Bug 1386825 - Part 1: Remove MOZ_B2G from dom. r=bkelly
...
MozReview-Commit-ID: 1zzP2r01B7U
2017-08-08 14:41:05 -07:00
Paul Adenot
4029e408c3
Bug 1378067 - Label more runnables in dom/media (GraphDriver.cpp, CubebUtils.cpp, DOMMediaStream.cpp). r=jesup
...
MozReview-Commit-ID: EQzR1AfzvzE
--HG--
extra : rebase_source : 9950d07eb1e8e9b1d07f94c10d7c5cf0008a8141
2017-07-18 11:26:58 +02:00
Sebastian Hengst
cb2227a5c7
Backed out changeset 6dc016256eba (bug 1378067) for bustage at dom/media/webaudio/WebAudioUtils.cpp:107. r=backout on a CLOSED TREE
2017-07-18 11:51:22 +02:00
Paul Adenot
ac12821115
Bug 1378067 - Label more runnables in dom/media (GraphDriver.cpp, CubebUtils.cpp, DOMMediaStream.cpp). r=jesup
...
MozReview-Commit-ID: EQzR1AfzvzE
2017-07-18 11:26:58 +02:00
Paul Adenot
67c95cdcdf
Bug 1312623 - Don't attempt to shutdown a thread in the dtor of a GraphDriver, since it might be called during stable state. r=smaug
...
MozReview-Commit-ID: HA67HQQrfow
--HG--
extra : rebase_source : d9301c6f5687eb1e1c3a7c4049e48ceaf74fa529
2017-07-04 09:21:23 +02:00
Alex Chronopoulos
48c9b10048
Bug 1380233 - New signature for cubeb_get_min_latency. r=kinetik
...
MozReview-Commit-ID: 4vh6atnnRpS
--HG--
extra : rebase_source : bee0a7d0a10b0eaf9cedb6286a1b1aa492457a94
2017-07-13 13:06:02 +03:00
Carsten "Tomcat" Book
daa67cc9e3
merge mozilla-inbound to mozilla-central a=merge
2017-06-30 12:59:45 +02:00
Paul Adenot
e55c008768
Bug 1372247 - Make the AudioOutputObserver a member of the MediaEngineWebRTCMicrophoneSource so it's not a global singleton anymore. r=jesup
...
MozReview-Commit-ID: 3yC1PvG3sW7
--HG--
extra : rebase_source : 950c1633d127ee0b6670b112bb31637a8851a583
2017-06-12 17:14:26 +02:00
Alex Chronopoulos
41737dc1af
Bug 1213414 - Implement channelCount audio constraint. r=jib,padenot
...
MozReview-Commit-ID: K95iBYOE1nR
--HG--
extra : rebase_source : 5c73eea4902933faec75e37d90e42a2f38c51b81
2017-06-29 21:01:17 -07:00
Bill McCloskey
f115503a0b
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
8a1350b5a6
Backed out changeset 4f6302a98ae4 (bug 1372405
)
...
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
ea1b86680c
Backed out changeset 9846de3bd954 (bug 1372405
)
...
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey
4592152411
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00