Bug 1339695 part 8 accidentally disabled native stack walking on Android by
using GP_arm_android instead of GP_PLAT_arm_android in a #if. This patch fixes
that. It also fixes a couple of compile errors that crept into the relevant
code while it was disabled.
--HG--
extra : rebase_source : a7a94b018b8de7a7ca3c621a2b662859a65e69c1
If the SurfaceCache discards our frames on another thread, the runnable that notifies us of that discard could race with a decode complete notification. So we can't rely on any ordering of SetDiscarded and NotifyDecodeComplete. Thus we must derive our state purely from the SurfaceCache (and mAnimationFinished from RasterImage).
We also update the image state in RequestRefresh (the main place where we use the state that is updated).
The other main place we use the state is GetCompositedFrame, but we don't update the state there. It should be fine because the only time this might lag behind reality is if the frames are discarded, and it should be fine to continue drawing the composited frame until the discard notification arrives.
The way that we tell that an animated image has all of its frames complete in the surface cache is less than ideal.
It should be checking the value of the 'writing-mode' property, not the value of
the "writing mode" concept. The latter is influenced by other properties like
'direction' and whatnot. That was causing this code to convert inlines to
inline-blocks if they just had a different direction from their parent, which is
not correct
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because there are tons of tests on the Gecko side.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: d93151e8a3c6309205f46335128dea9b936f15ad
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6ce98c3e1ff881b649f30ccde249eef10b4bd139
- Added POST to create post data conditional;
- Added test to check "--data" on curl generated command.
--HG--
extra : rebase_source : 04c3519fa8788a7d196161fea719e363734cb25a
Originally, the patch for Bug 1298722 was not going to label these functions as
MOZ_MUST_USE, and it added a brief code-comment to explain that. But then it
did end up labeling them as MOZ_MUST_USE after all, in response to some review
feedback. And it kept the now-incorrect comment around by accident, it
seems. This followup just removes that incorrect comment.
MozReview-Commit-ID: 2c35wQPzXRN
Nicholas Nethercote
Ehsan Akhgari
Sebastian Hengst
Timothy Nikkel
Till Schneidereit
Phil Ringnalda
Nazım Can Altınova
Stanford Lockhart
Wes Kocher
Boris Zbarsky
Ben Kelly
Nevin Chen
sole
Stefan Yohansson
Jason Laster
Ryan VanderMeulen
emilio+bugs@crisal.io
Michael Layzell
Daniel Holbert
Robert Longson
Kris Maglione
Joel Maher
Aki Sasaki
Hrishikesh Barman
Dão Gottwald
Olli Pettay