8c151cc707
Bug 1535880 - Always check ReadValueFromPowerFile() return value. r=glandium
...
This makes RAPL abort with more informative error messages if certain
kernel-provided files aren't present.
Differential Revision: https://phabricator.services.mozilla.com/D23974
--HG--
extra : moz-landing-system : lando
2019-03-19 11:20:11 +00:00
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
0819f35e51
Backed out 4 changesets (bug 525063) on request from Andi. a=backout
...
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
a3a77c0312
Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan
2018-04-10 21:11:02 +02:00
b5f9522581
Bug 1438839 - Finish the flake8 fixes on tools/ r=ahal
...
MozReview-Commit-ID: F9c4laxe8Pt
--HG--
extra : rebase_source : ed304bcf485a448e863b9bbc82427ae5a88ea2c2
extra : histedit_source : 2c8e0beefee259fe7a31e0436e7a94519a3e05ae
2018-03-15 11:31:12 +01:00
a0ab39f145
Bug 1438839 - Fix the remaining flake8 issues by hand r=ahal
...
MozReview-Commit-ID: Fv1MZIpCL8Z
--HG--
extra : rebase_source : 804567a78a5696997e2aa511814a4f8ff22d9c31
extra : histedit_source : 88401e831d81708b6ed6122666ba9fa8c1de23d5
2018-03-15 11:34:03 +01:00
ef5ad1811f
Bug 1438839 - autopep8 -i --max-line-length 99 on the tools/ r=ahal
...
MozReview-Commit-ID: KSKbctxjxl0
--HG--
extra : rebase_source : feebd58ff005750face884035f85a55e0ff638c8
extra : histedit_source : 5d7464caeb41bad25bc99d3b2e32ea5285464499
2018-03-15 11:32:42 +01:00
c0a229d4c3
Bug 1386876 - Replace all uses of DISABLE_STL_WRAPPING with a template, remove DISABLE_STL_WRAPPING. r=glandium
...
MozReview-Commit-ID: FMEtb5PY7iP
--HG--
extra : rebase_source : 3cdee7528846462c758e623d6bcd2e6e17dbabff
2017-09-11 11:33:26 -07:00
5941aa8f13
Bug 1337358 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in tools/ r=froydnj
...
MozReview-Commit-ID: GdeCzDXjzzg
--HG--
extra : rebase_source : b00971238ff78d23d9bcec31f905ec268a614527
2017-02-08 12:04:50 +01:00
bd74c7db4a
Bug 1301627 - Change the name of commented variables when calling perf_event_open. r=erahm
2016-10-23 10:10:00 -07:00
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
e75c590407
Revert "Bug 1114647 - Rename "plugin-container" to "firefox-webcontent" and create a new executable target for Win32 called "firefox-plugin-container" r=ted,jhamer" because of widespread breakage due to whitelisted executable names in third parties
...
This reverts commit a94b5f861bd0d25043a3bb7a0c3128acf8c0b93a.
--HG--
rename : ipc/contentproc/firefox-webcontent.cpp => ipc/contentproc/plugin-container.cpp
2016-04-08 13:34:40 -04:00
5c454494ce
Bug 1114647 - Rename "plugin-container" to "firefox-webcontent" and create a new executable target for Win32 called "firefox-plugin-container" r=ted,jhamer
...
--HG--
rename : ipc/app/module.ver => ipc/app/plugin-container/module.ver
rename : ipc/contentproc/plugin-container.cpp => ipc/contentproc/firefox-webcontent.cpp
2016-04-01 02:12:59 -04:00
150add3f29
Bug 1236393 - Annotate intentional switch fallthrough to suppress -Wimplicit-fallthrough warning in tools/power/rapl.cpp. r=njn
...
tools/power/rapl.cpp:331:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
2015-11-23 22:41:07 -08:00
3193160487
Bug 1222887 - Suppress -Wunreachable-code warning in tools/power. r=njn
...
tools/power/rapl.cpp:844:5 [-Wunreachable-code] code will never be executed
clang reports a -Wunreachable-code warning for sigemptyset() because Darwin's sigemptyset() is a macro that always returns 0. Thus `if (sigemptyset(&sa.sa_mask) < 0)` is always false and `Abort("sigemptyset() failed")` is never called. Linux's sigemptyset() can return 0 or -1. The extra parens around (0) suppress the clang warning.
2015-11-09 01:03:54 -08:00
557e2db669
Bug 1214924 - Add "WindowServer" and "kernel" processes to |mach power|'s output. r=BenWa.
...
--HG--
extra : rebase_source : c85d0c6b92c82c32b5e194143358956479a477b9
2015-10-16 14:01:22 +11:00
de59a42fb1
Bug 1204787 - Add |mach power|. r=glandium.
...
This extracts the most useful browser-related measurements from rapl and
powermetrics.
--HG--
extra : rebase_source : 81ce14acc6c6e1bc7ac6c34bf119d8e619956dd1
2015-09-15 16:23:45 +10:00
a919a2d114
Bug 1203811 - Clarify two error messages in tools/power/rapl. r=heycam.
2015-09-10 23:12:31 -07:00
c93125fd60
Bug 1203834 - Fix's rapl's handling of unsupported power domains. r=glandium.
...
The "gpu" and "ram" domains aren't supported by all platforms. rapl has a
special constant |kUnsupported_j| to represent this on Linux, but I
accidentally have a minus sign in front of it in several places, which means
that instead of printing "n/a" for unsupported planes we always print "1.0".
I think this happened because I used to hardwire -1 in there and then I later
changed it to a constant but forgot to remove the minus signs.
It sure would be nice to have automated testing for this stuff, but I don't see
how to do it.
2015-09-10 23:12:20 -07:00
51b5ca14d4
Bug 1201811 (part 2) - Don't print distribution stats if there was only 1 sample. r=erahm.
...
--HG--
extra : rebase_source : aa6b26441c5ca285a15d58d97a62f064e891d09b
2015-09-04 01:45:13 -07:00
21be35d70a
Bug 1201811 (part 1) - Don't use integer arithmetic when summing totals in rapl. r=erahm.
...
--HG--
extra : rebase_source : 2c800587f4bc49a492fb85be1e7d6c0c7885052e
2015-09-04 01:04:46 -07:00
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
4e53819fec
Bug 1198334 (part 0) - Tighten up warnings-as-errors usage in tools/power/. r=glandium.
...
--HG--
extra : rebase_source : a8239fd2911e57820eba3c1759365627f669b9d2
2015-08-27 20:40:44 -07:00
33d3e011d3
Bug 1198137 (follow-up) - Add a missing #include to unbreak Mac OS builds on a CLOSED TREE. r=me
...
--HG--
extra : rebase_source : 9704e746704ef614b48b9ebcdb0afd3e729258ad
2015-08-26 11:48:08 +10:00
cdcc41338a
Bug 1198137 - Add some summary stats to tool/power/rapl's output. r=erahm.
...
"mean" is most useful, then "min" and "max". The rest are moderately useful.
--HG--
extra : rebase_source : 03fda0e0d32081024abd5cdf859f16dac60bbc19
2015-08-25 18:11:03 -07:00
b7f77af473
Bug 1197694 - fflush() rapl output so it always appears immediately. r=erahm.
...
--HG--
extra : rebase_source : 2de1c517202616e6daad6e578cfbe89b65cdce0f
2015-08-24 15:59:37 -07:00
b83cd56ff9
Bug 1194560 (follow-up) - Only build rapl on Linux if the arch is x86 or x86-64. r=glandium.
...
--HG--
extra : rebase_source : c115f898cb1ce8129657e3435881e4f220eca566
2015-08-20 17:02:18 -07:00
68c09ac436
Bug 1194560 - Add tools/power/rapl, a RAPL-reading program for power profiling. r=erahm,glandium.
...
--HG--
extra : rebase_source : 7303d7209f6c9ae8bbd911a379078343b7cb5a7b
2015-08-19 22:25:30 -07:00
Nicholas Nethercote
Ehsan Akhgari
Sylvestre Ledru
Sebastian Hengst
Tristan Bourvon
Chris Manchester
Kirti Singla
Tom Tromey
George Wright
Chris Peterson