The by-project and by-build-platform are collapsed by resolve_keyed_by(), and in turn by keymatch() in
utils/attributes.py. That needs a regexp to look for matches (if a simple match isn't possible). Rev
39eed777c0c4 missed that when it landed. The trailing hypens are to distringuish between the two linux
platforms.
MozReview-Commit-ID: LiAJpfV71Ws
--HG--
extra : rebase_source : 6952e4b6be4b05cc7917efba8a346211d1e5c7e0
The existing code only passed strings around to identify PaymentRequest
objects. That meant that we were constantly having to do hashtable lookups to
find the corresponding object. This patch just uses the single map that IPDL
maintains for us and passes objects around, obviating the need for more
hashtable lookups.
MozReview-Commit-ID: 6BBonrc6q4x
--HG--
extra : rebase_source : 041c6ce742d60a2c9e954a58582d09cd9ef7f2b1
There isn't any need to create an actor per call to the parent. This patch
lines up PaymentRequest with PPaymentRequestChild objects and links them
together. It also simplifies the maps and arrays we use to keep track of these
objects.
There's one tricky bit to note in this patch: in the case that a promise is
passed to paymentRequest.show(), we don't notify the parent process until the
promise resolves (when we call either UpdatePayment or AbortUpdate). In that
case, I needed to distinguish between an "update" because of the promise
resolving or a call to updateWith on an shippingaddresschange event in order
to get the bookkeeping right with the mActivePayments hashtable. In that case,
the PaymentRequest is kept alive by mShowingRequest alone. In all other cases,
mActivePayments keeps the PaymentRequest alive until we resolve or reject the
correct promise.
MozReview-Commit-ID: HoHjn8eqC4T
--HG--
extra : rebase_source : 4da1d65d1f791f4a5c18871ab3a3dcf94e833b90
This removes some hard tabs that crept in and combines two if branches into a
single statement in order to avoid a bit of duplication.
The existing code here seems to treat any sort of upcast as needing a QI. That
is needlessly wasteful and causes a bunch of unneeded virtual calls.
MozReview-Commit-ID: 7WshYm9C4Xb
--HG--
extra : rebase_source : bc7b1b5157324158f627efd8dff54f078488f4fc
The existing code assumed that the only reason that there could be a
PaymentRequestChild was due to an active show() call. That is not the case. We
already know whether there's an "interactive" PaymentRequest through
mShowingRequest, so we should just use that instead.
MozReview-Commit-ID: IA9bXn7hS63
--HG--
extra : rebase_source : 0d65a6e05d224a5fddfdbb953ad28f2eecd80533
We used to do that before bug 1455767. Taking a step back, what we want
(and what this change implements) is to:
- allow to specify a linker to use explicitly
- check that using the corresponding linker flags makes us use that
linker
- if no linker is specified, and developer options are enabled, we want
to try to use gold if it's available, otherwise, we want to detect
what kind of linker the default linker is
- if --disable-gold is explicitly given, we don't want to automatically
use it.
--HG--
extra : rebase_source : 8d89c54bd5e555984d815beb8fdd3f5f75dae31e
Because --enable-stdcxx-compat blows up when gold is enabled, so prevent
it from being automatically enabled.
--HG--
extra : rebase_source : ea91dd6f5eeaf1a8664179b503c3ecf06dccea26
This should make it work for both remote and non-remote pages.
MozReview-Commit-ID: CpnGd0PoTGn
--HG--
extra : rebase_source : 5aec372dfcc4e7ba22cd16fa7eee15ed897a6fb7
Make it so that directionality of the ShadowRoot descendants is computed based
on the host and it's ancestors, but don't touch the dir=auto code, since I don't
think anybody agrees with what needs to happen there, and I think in general
it shouldn't be accounted for.
MozReview-Commit-ID: AZMBZ5m1SQf
std::move'ing the string here enables us to avoid a useless copy of the
string. Normally this would be just a refcounting increment/decrement,
but since we've Adopt'd the string a couple of lines earlier and the
incoming string is therefore just an owned character buffer, rather than
a refcounted character buffer, the copy here is a "real" copy.
What would be ideal here is to pass the (un-JSON'd) GCDescription out to
the notification, so we don't even have to render and parse JSON, but
that can be left for a later day.
We relied already in DestroyContent not fiddling with child lists, so added
assertions to that effect.
The GetChildCount comment in UnbindSubtree looks outdated (there's no
GetChildCount impl which does anything like creating children).
MozReview-Commit-ID: 6UXVbT6Urgt
This is done by passing "--setpref apz.subtest=<subtest-name>" on the
mochitest command line, where <subtest-name> is the name of the subtest file
(including the extension).
MozReview-Commit-ID: EscFekIeOxr
--HG--
extra : rebase_source : a969553edfd0bd46b9ff0be695af621cf3e10bff
Those changesets which are related to animations introduced in bug 1462497
seems to cause new crashes. I think the first two changesets for the bug fixed
the original crash cases but the last two (i.e. these changesets) introduced
other crashes unfortunately.
MozReview-Commit-ID: 9LD2hIIXA2y
--HG--
extra : rebase_source : 102c5532128039dcf8274c214e17d58d9a1aa483
In file included from objdir/js/xpconnect/src/Unified_cpp_js_xpconnect_src1.cpp:110:
js/xpconnect/src/nsXPConnect.cpp:76:37: error: use of undeclared identifier
'profiler_register_thread'
JS::SetProfilingThreadCallbacks(profiler_register_thread, profiler_unregister_thread);
^
js/xpconnect/src/nsXPConnect.cpp:76:63: error: use of undeclared identifier
'profiler_unregister_thread'
JS::SetProfilingThreadCallbacks(profiler_register_thread, profiler_unregister_thread);
^
MozReview-Commit-ID: HrBGEkByEum
--HG--
extra : rebase_source : b588e8f04d44d07c348120efc6008e6c24b8949e
Summary: Looks like I missed this in bug 1464834.
Test Plan: Not part of the build, so no tests.
Reviewers: jwatt
Subscribers: heycam, xidorn
Bug #: 1469244
Differential Revision: https://phabricator.services.mozilla.com/D1679
MozReview-Commit-ID: Bx14lTv6GDD
Mathieu Leplatre
Yusuf Sermet
Nick Thomas
Blake Kaplan
Mike Hommey
Felipe Gomes
shindli
ffxbld
ffxbld
Brindusan Cristian
Emilio Cobos Álvarez
Cosmin Sabou
Nathan Froyd
David Major
Andrea Marchesini
Noemi Erli
Coroiu Cristina
Jeremy Lempereur
Botond Ballo
Hiroyuki Ikezoe
Andi-Bogdan Postelnicu
Mark Banner
Jan Beich
Mats Palmgren
Issei Horie