There are three test cases which are actually wrong, for example:
* offsetContainer=use&mask=userSpace-at100
This test case is actually wrong one. All the content of <use> element should
be masked out by the selected mask. We should use <mask id="userSpace-atZero">
instead.
MozReview-Commit-ID: B3D2gTWmwXC
--HG--
extra : source : fcb3c9a6426e9a54a28abd5acf4448bbfac5cf0c
extra : histedit_source : 8d6c685c4d051f0e20bc286d2ab829e47d22efef
For nsSVGUtils::FrameSpaceInCSSPxToUserSpace:
If we give a nsSVGUseFrame to this function, it will return <use>'s x/y as
translation vector, which is not necessary. A point (a, b) in frame's
coordinate space should keep (a, b) in <use>'s coordinate space with no change.
Since we remove extra translation in nsSVGUtils::FrameSpaceInCSSPxToUserSpace,
aslo update nsSVGUtils::GetBBox accordingly.
MozReview-Commit-ID: BMjSonjoWd2
--HG--
extra : source : e32814fc5ab6fdb9e723b8109aa8f398b1c883f6
extra : histedit_source : 564968d47a3d95fde8e5b83c55148b63c1feb085
There are three test cases which are actually wrong, for example:
* offsetContainer=use&mask=userSpace-at100
This test case is actually wrong one. All the content of <use> element should
be masked out by the selected mask. We should use <mask id="userSpace-atZero">
instead.
MozReview-Commit-ID: B3D2gTWmwXC
--HG--
extra : rebase_source : 09390a59d6bcd187e0e8b99ca6a78da84af49805
For nsSVGUtils::FrameSpaceInCSSPxToUserSpace:
If we give a nsSVGUseFrame to this function, it will return <use>'s x/y as
translation vector, which is not necessary. A point (a, b) in frame's
coordinate space should keep (a, b) in <use>'s coordinate space with no change.
Since we remove extra translation in nsSVGUtils::FrameSpaceInCSSPxToUserSpace,
aslo update nsSVGUtils::GetBBox accordingly.
MozReview-Commit-ID: BMjSonjoWd2
--HG--
extra : rebase_source : da629ba4464534a89718db1cd5b9705261ae4a4d
Convert the "Tab:*" observers in browser.js, which go through the observer
service, to events that go through GlobalEventDispatcher.
FindHelper.js uses "Tab:Selected" through a lazy loader, but I don't
think FindHelper should listen to "Tab:Selected" at all until it is
being used. THerefore, this patch adds "Tab:Selected" registration to
FindHelper.js itself.
Convert events used in Tabs to GeckoBundle/BundleEventListener events.
All of the events are converted to UI thread events, because a lot of
the listeners modify states in Tab (e.g. through
`Tab.handleLocationChange()`), and those states are later accessed on
the UI thread. We used to modify the states on the Gecko thread, and
then access them on the UI thread, which introduces potential race
conditions. Therefore, I think it's best to convert these events
wholesale to UI thread events to avoid races.
Tabs.notifyListeners now calls the listeners directly if it's already on
the UI thread, instead of posting to the UI thread again. This is meant
as an optimization because the events are now coming in on the UI thread
already.
The "Tab:SelectAndForeground" and "Tab:Select" events are merged into
one "Tab:Select" event, and a "foreground" option is added.
The "Tab:StreamStart" and "Tab:StreamStop" events are merged into one
"Tab:RecordingChange" event, and a "recording" option is added to
indicate starting or stopping.
Make SiteIdentity.update use GeckoBundle, and also simplify the enums
in SiteIdentity, by using Enum.valueOf to get enum values from names,
instead of custom code.
Convert events used in ZoomedView to GeckoBundle/BundleEventListener
events.
"Window:Resize", "Browser:ZoomToPageWidth", and
"Browser:ZoomToRect" listeners are removed because they are not sent
anywhere.
The "Content:LocationChange" listener is merged into the
"Gesture:CloseZoomedView" listener, so that we can leave
"Content:LocationChange" alone for now. Otherwise we would have to
convert the "Content:LocationChange" listener in Tabs as well.
The listeners are changed from global listeners to per-GeckoApp
listeners, because two of the events, "FormAssist:AutoCompleteResult" and
"FormAssist:Hide", are per-GeckoApp events also used by FormAssistPopup.
Because the events are now per-GeckoApp events, they are now registered
from onAttachedToWindow and onDetachedFromWindow.
Convert "FormAssist:*" events in FormAssistPopup to
GeckoBundle/BundleEventListener events. UI thread events are used
because the listener performs operations on the UI thread.
Also convert the "FormAssist:*" observers in browser.js to use
WindowEventDispatcher.
The "FormAssist:AutoComplete" event that goes from Gecko to Java is
renamed to "FormAssist:AutoCompleteResult" to prevent conflict with the
event with the same name that goes from Java to Gecko.
For all the NS_DispatchToCurrentThread() cases I wasn't sure if we are
guaranteed to be on the main thread, but nsGlobalWindow::Dispatch() has a
MOZ_RELEASE_ASSERT(NS_IsMainThread()) and a try push showed up no problems
there.
For all the NS_DispatchToCurrentThread() cases I wasn't sure if we are
guaranteed to be on the main thread, so I added
MOZ_RELEASE_ASSERT(NS_IsMainThread()) to all of them. A try push showed up no
problems there.
Chris Peterson
Shu-yu Guo
cku
Iris Hsiao
David Anderson
David Anderson
Randall Barker
Jorg K
Boris Zbarsky
vincentliu
Mihai Tabara
Ehsan Akhgari
Wes Kocher
Jeff Gilbert
John Lin
Jim Chen
Ben Kelly
Daniel Holbert
Nicholas Nethercote
André Bargull