Cameron McCormack
23bf7c8332
Bug 1382964 - Part 3: Add assertion to help heap write analysis. r=xidorn
...
MozReview-Commit-ID: Lfa5Cijgqzp
--HG--
extra : rebase_source : 0af1079a7129a396baced1c0c1ed488165fba1df
2017-07-23 09:11:37 +08:00
Cameron McCormack
dcfb190586
Bug 1382964 - Part 2: Assert we're on the main thread in nsCSSValueTokenStream::operator==. r=xidorn
...
This helps the heap write analysis believe that the nsCSSValue comparison
that nsStyleUIReset::CalcDifference does (for mSpecifiedWindowTransform,
which won't have nsCSSValueTokenStream values in it) is safe.
MozReview-Commit-ID: 4JvPC735D7i
--HG--
extra : rebase_source : 728f698a97a03b0259d82ea9e418117deda488a4
2017-07-22 10:11:06 +08:00
Cameron McCormack
d20edaf0df
Bug 1382964 - Part 1: Don't cache URLValueData::mMightHaveRef when in a traversal. r=xidorn
...
MozReview-Commit-ID: 2ucnu4vuaVg
--HG--
extra : rebase_source : 5f4f51d302f5d6ba03ecf7ea2ee938acdb36d0c8
2017-07-21 16:34:20 +08:00
Emilio Cobos Álvarez
ed9d1ad184
Bug 1382017: followup: fix alignment of macro definitions. r=whitespace-only
...
MozReview-Commit-ID: KdgQaPukU5z
2017-07-23 04:39:00 +02:00
Emilio Cobos Álvarez
2b7de51623
Bug 1381844: Be more explicit about the kind of style context we handle all the time. r=bholley
...
MozReview-Commit-ID: E0mdkhU3XBz
2017-07-22 18:02:57 +02:00
Emilio Cobos Álvarez
b7a2398983
Bug 1381844: Remove a few redundant casts. r=bholley
...
MozReview-Commit-ID: 2dr72PMGKwN
2017-07-22 18:02:56 +02:00
Sebastian Hengst
f16a7f8371
merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: 4EWdTlEncz7
2017-07-22 11:38:42 +02:00
Wes Kocher
d45eb771f0
Merge m-c to inbound, a=merge
...
MozReview-Commit-ID: Ah48RzFU8Mt
2017-07-21 18:20:46 -07:00
Sylvestre Ledru
7c0ae251cd
Bug 1381253 - Remove redundant control flow declarations rs=ehsan
...
MozReview-Commit-ID: FFxP4aMCbOL
--HG--
extra : amend_source : 3aec108430b11048f47ffe19d5da7ac5034770a9
2017-07-15 19:03:04 +02:00
Boris Zbarsky
9fed8c4314
Bug 1382786 part 5. Add some tests for which properties are properties are allowed on ::first-letter, ::first-line, and ::placeholder. r=emilio
...
MozReview-Commit-ID: 6FO6QAECPHW
--HG--
extra : rebase_source : fa9d6e9f4197360c6f5143928de8319bac733843
2017-07-21 14:20:12 -04:00
Manish Goregaokar
08c6de8178
Bug 1382017 part 4 Gecko piece - Rename ServoComputedValues -> ServoComputedData; r=heycam
...
ServoComputedValues is confusing because ComputedValues is actually
ServoStyleContext on the C++ side.
MozReview-Commit-ID: IQNVdfREAMt
2017-07-20 21:44:02 -07:00
Manish Goregaokar
26f3a98f78
Bug 1382017 part 4 Gecko piece - Remove usage of ServoComputedValues from most Gecko code; r=xidorn
...
MozReview-Commit-ID: 2NB4DgxMrL3
2017-07-20 17:27:05 -07:00
Manish Goregaokar
9e805b0538
Bug 1382017 part 2 Gecko piece - Remove usage of ServoComputedValues from binding functions; r=xidorn
...
MozReview-Commit-ID: 3KygTIIMVvF
2017-07-18 23:17:34 -07:00
Manish Goregaokar
b185f906f6
Bug 1382017 part 1 Gecko side - Replace stylearc with servo_arc; r=xidorn
...
MozReview-Commit-ID: FUZgybUUMF3
2017-07-18 11:51:56 -07:00
Emilio Cobos Álvarez
c02bd43974
Bug 1382372: Add a fast-path for matching attr selectors with the empty namespace. r=bz
...
MozReview-Commit-ID: GSr0oGJJZRM
2017-07-20 19:13:32 +02:00
Emilio Cobos Álvarez
b7fa6f3b50
Bug 1377469: Update reftest expectations. r=jryans
...
MozReview-Commit-ID: Cp8Fc5emACU
--HG--
extra : rebase_source : e6b9b027e3f1a09ebf61df19bb766d2223c94a92
2017-07-20 13:33:00 +02:00
Nazım Can Altınova
0fb0b9cec5
Bug 1341802 - Enable disabled grid tests after servo/servo#17776 r=me
...
MozReview-Commit-ID: 21080kMgKdk
--HG--
extra : rebase_source : 69cc7cf2d63662d157db1969b70e0cb25760681a
2017-07-20 09:35:13 -07:00
Simon Sapin
4485b191aa
Bug 1382713
- Bench stylo setProperty with both "10px" and " 10px". r=emilio
...
MozReview-Commit-ID: E6LiJPQ0IJ3
--HG--
extra : rebase_source : 643bbbadf1136a019336c78d69882bea834ebc65
2017-07-19 11:16:38 +02:00
Sebastian Hengst
b289637574
Backed out changeset 454d7232178d (bug 1380133) for bustage at mozilla/KeyframeUtils.h: no 'object' file generated. r=backout on a CLOSED TREE
2017-07-20 15:41:12 +02:00
Sebastian Hengst
515a615505
Backed out changeset 6f89b4ceda12 (bug 1380133)
2017-07-20 15:40:16 +02:00
Sebastian Hengst
42d11fca28
Backed out changeset 22dabf04e560 (bug 1380133)
2017-07-20 15:40:12 +02:00
Sebastian Hengst
8400ef0636
Backed out changeset cc720d72d024 (bug 1380133)
2017-07-20 15:40:06 +02:00
Sebastian Hengst
d67d0384af
Backed out changeset 9a84b6988af9 (bug 1380133)
2017-07-20 15:39:58 +02:00
Sebastian Hengst
6b93a5693c
Backed out changeset cf561cad85f1 (bug 1380133)
2017-07-20 15:39:53 +02:00
Sebastian Hengst
4e48589974
Backed out changeset 1f1175528301 (bug 1380133)
2017-07-20 15:39:48 +02:00
Sebastian Hengst
234f850b1c
Backed out changeset f835a60a13a3 (bug 1380133)
2017-07-20 15:39:38 +02:00
Emilio Cobos Álvarez
babe22878e
Bug 1366721: Update reftest expectations. r=heycam
...
MozReview-Commit-ID: JugvULOAtvJ
--HG--
extra : rebase_source : 633ca5d4244441cd06bf9cd469b57cf42616b73e
2017-07-20 22:04:22 +02:00
Emilio Cobos Álvarez
2e66317b01
Bug 1366721: Switch all the APIs in ServoStyleSet to use ServoStyleContext. r=heycam
...
MozReview-Commit-ID: 8oMwu45tlaJ
--HG--
extra : rebase_source : e246ef3aba9d18b9e415909ae46b26c3aa98f244
2017-07-20 18:36:20 +02:00
Xidorn Quan
19dc9432eb
Bug 1382080 - Fix remaining failures in test_system_font_serialization.html. r=heycam
...
MozReview-Commit-ID: 5PGjaTKLQqR
--HG--
extra : rebase_source : 5c51dacc9329514136c8bbcc7c846cf1416c0810
extra : source : e40607ec7fb28825d9e7c14f571794e2e9dc0081
2017-07-21 16:53:39 +10:00
Brian Birtles
c372a33920
Bug 1380133 - Part 9: Automated test for inheriting the start value of a transition. r=heycam
...
MozReview-Commit-ID: 6uue8qUePUh
---
layout/style/test/mochitest.ini | 1 +
layout/style/test/test_transitions_at_start.html | 38 +++++++++++++++++++++++
3 files changed, 43 insertions(+)
create mode 100644 layout/style/test/test_transitions_at_start.html
--HG--
extra : rebase_source : 3e6da1f13dbd2767787d6d9b7f2553949e3d0ad2
2017-07-21 11:51:04 +08:00
Cameron McCormack
aa95f86b98
Bug 1380133 - Part 7: De-templatize CalcStyleDifference(Internal). r=emilio
...
MozReview-Commit-ID: 8c1E1gbwaHz
---
layout/style/nsStyleContext.cpp | 23 +++++------------------
layout/style/nsStyleContext.h | 7 -------
2 files changed, 5 insertions(+), 25 deletions(-)
--HG--
extra : rebase_source : 0280187becf0f35bc7c5ceb272babd6e0adbb3ff
2017-07-21 11:42:44 +08:00
Cameron McCormack
336a333bf0
Bug 1380133 - Part 6: Remove FakeStyleContext. r=emilio
...
MozReview-Commit-ID: EDPXdzmE37Y
---
layout/style/nsStyleContext.cpp | 31 -------------------------------
1 file changed, 31 deletions(-)
--HG--
extra : rebase_source : 55e3be75bb4325de6431e636ef815bc870bcad94
2017-07-21 11:42:44 +08:00
Cameron McCormack
962f773bc4
Bug 1380133 - Part 5: Call CalcStyleDifference with ServoStyleContexts instead of a FakeStyleContext wrapping a ServoComputedValues. r=emilio
...
MozReview-Commit-ID: 6JhMas1EiM7
---
layout/style/ServoBindings.cpp | 21 ++++++++++-----
layout/style/ServoBindings.h | 3 ++-
layout/style/nsStyleContext.cpp | 58 +++++++++++++++++++++--------------------
layout/style/nsStyleContext.h | 29 ++++++++++++++-------
4 files changed, 65 insertions(+), 46 deletions(-)
--HG--
extra : rebase_source : 88576e17cd3867acdf8862dab42fd4b1e73bc755
2017-07-21 11:42:44 +08:00
Cameron McCormack
350253019b
Bug 1380133 - Part 4: Make CalcStyleDifferenceInternal not cache any new structs on ServoStyleContexts when in a traversal. r=emilio
...
MozReview-Commit-ID: Eu4MvdQUBor
---
layout/generic/nsFrame.cpp | 8 ++++++++
layout/style/nsStyleContext.cpp | 11 +++++++----
layout/tables/nsTableFrame.cpp | 8 ++++++++
3 files changed, 23 insertions(+), 4 deletions(-)
--HG--
extra : rebase_source : b77d33b5823eca4a57e568881c00959ddecf9089
2017-07-21 11:42:43 +08:00
Cameron McCormack
d77c5d77d8
Bug 1380133 - Part 3: Remove nsPresContext argument to ServoStyleContext::ResolveSameStructsAs. r=emilio
...
We have it in mPresContext already.
MozReview-Commit-ID: G1kKHGFOXTp
---
layout/base/ServoRestyleManager.cpp | 2 +-
layout/generic/ViewportFrame.cpp | 2 +-
layout/style/ServoStyleContext.h | 3 +--
layout/style/ServoStyleContextInlines.h | 6 +++---
4 files changed, 6 insertions(+), 7 deletions(-)
--HG--
extra : rebase_source : 63e1e4fba69c587f7eb403efd7d8dd98214c86ac
2017-07-21 11:42:43 +08:00
Cameron McCormack
1580e4a025
Bug 1380133 - Part 2: Take a ServoStyleContext* in Gecko_CalcStyleDifference. r=emilio
...
MozReview-Commit-ID: DJnuUAmm1Fh
---
layout/style/ServoBindings.cpp | 14 +++++++-------
layout/style/ServoBindings.h | 4 ++--
2 files changed, 9 insertions(+), 9 deletions(-)
--HG--
extra : rebase_source : c4df8f13546511b504aefb0fa481d5f4171955ee
2017-07-21 11:42:42 +08:00
Cameron McCormack
9654eabe7f
Bug 1380133 - Part 1: Minor reformatting and encapsulation. r=emilio
...
MozReview-Commit-ID: 3hmptLbxxok
---
dom/animation/KeyframeUtils.h | 2 +-
layout/style/ServoBindings.cpp | 24 +++++++++++++++---------
layout/style/ServoStyleContext.cpp | 21 ++++++++++++---------
layout/style/ServoStyleContext.h | 33 ++++++++++++++-------------------
layout/style/ServoTypes.h | 24 ++++++++++++++----------
layout/style/nsAnimationManager.h | 7 +++----
6 files changed, 59 insertions(+), 52 deletions(-)
--HG--
extra : rebase_source : 150278b5f7429986e79976ec9faf290db6de86c0
2017-07-21 11:42:42 +08:00
Xidorn Quan
f9743a6579
Bug 1377115 - Enable test_variables.html. r=heycam
...
The external sheet isn't meant to test the order of items. It is just
for testing handling of relative url in CSS variable, so it doesn't make
sense to have it affect the test for checking return value from item().
MozReview-Commit-ID: APTauRXfe1H
--HG--
extra : source : 9f7096a54992120170b4ab8ac8e922609387f68a
2017-07-21 13:40:46 +10:00
Xidorn Quan
35db44a32e
Bug 1381233 - Add test for this bug. r=heycam
...
MozReview-Commit-ID: 6A99LrHU2Li
--HG--
extra : source : 03ccb6d8bbafcd585b55fc9da6ff71dc7612cadd
2017-07-21 13:40:09 +10:00
Manish Goregaokar
60f0b17b9d
Bug 1382672 - Add crashtest for discrete animation between system fonts on stylo; r=emilio
...
MozReview-Commit-ID: 2nI3jgkZ0R7
--HG--
extra : rebase_source : 2c62ce6a3d7d19a96785803e255ffebfc9decfa7
2017-07-20 17:22:48 -07:00
Wes Kocher
4d3b4a7b1a
Bug 1341102 - Update expectation data a=bustage CLOSED TREE
...
MozReview-Commit-ID: 603WKr3HLo0
2017-07-20 15:47:48 -07:00
Manish Goregaokar
f4917a7611
Bug 1382190: Make fields public to avoid assertions; r=bustage
...
MozReview-Commit-ID: 4t4RfnlmFy0
2017-07-20 14:15:00 -07:00
Manish Goregaokar
19e8dfd20b
Bug 1382190 - servo: Move FontComputationData to the end of ServoComputedValues to make size check easier, make it NonZero. r=emilio
...
MozReview-Commit-ID: B2gVj5bQRBT
2017-07-20 13:36:22 -07:00
Wes Kocher
1a00a870d7
Bug 1341102 - Update expectation data a=bustage
...
MozReview-Commit-ID: 1ZKJWNnaP4u
2017-07-21 11:45:25 -07:00
Brian Birtles
265df913a0
Bug 1380133 - Part 9: Automated test for inheriting the start value of a transition. r=heycam
...
MozReview-Commit-ID: 6uue8qUePUh
--HG--
extra : rebase_source : 3b1338356c2f6f21e497a588939c34ba0edb93ef
2017-07-17 10:35:31 +08:00
Cameron McCormack
6026a97b45
Bug 1380133 - Part 7: De-templatize CalcStyleDifference(Internal). r=emilio
...
MozReview-Commit-ID: 8c1E1gbwaHz
--HG--
extra : rebase_source : f29c1d2168d1b0cec2f34a05f6f392cd76dde9e6
2017-07-19 17:52:43 +08:00
Cameron McCormack
810528b92c
Bug 1380133 - Part 6: Remove FakeStyleContext. r=emilio
...
MozReview-Commit-ID: EDPXdzmE37Y
--HG--
extra : rebase_source : 56c2651a2e961e2555452008b59bb50037625bd7
2017-07-19 17:51:12 +08:00
Cameron McCormack
7ac8c49b89
Bug 1380133 - Part 5: Call CalcStyleDifference with ServoStyleContexts instead of a FakeStyleContext wrapping a ServoComputedValues. r=emilio
...
MozReview-Commit-ID: 6JhMas1EiM7
--HG--
extra : rebase_source : 22d94de05a300bd3d696db94b6999821c0af0b11
2017-07-19 17:50:35 +08:00
Cameron McCormack
a5c91255ab
Bug 1380133 - Part 4: Make CalcStyleDifferenceInternal not cache any new structs on ServoStyleContexts when in a traversal. r=emilio
...
MozReview-Commit-ID: Eu4MvdQUBor
--HG--
extra : rebase_source : c98706cec1788662a09cb1d99bcd3893658261a9
2017-07-19 15:11:09 +08:00
Cameron McCormack
4b22db7890
Bug 1380133 - Part 3: Remove nsPresContext argument to ServoStyleContext::ResolveSameStructsAs. r=emilio
...
We have it in mPresContext already.
MozReview-Commit-ID: G1kKHGFOXTp
--HG--
extra : rebase_source : fc3de196bd0bd1a78d5bdaca3078e89edd4f014f
2017-07-19 14:39:40 +08:00
Cameron McCormack
befeb6585d
Bug 1380133 - Part 2: Take a ServoStyleContext* in Gecko_CalcStyleDifference. r=emilio
...
MozReview-Commit-ID: DJnuUAmm1Fh
--HG--
extra : rebase_source : 7f2447038eee1aa94d603a83409c88747203a411
2017-07-19 14:15:45 +08:00
Cameron McCormack
c1be90be48
Bug 1380133 - Part 1: Minor reformatting and encapsulation. r=emilio
...
MozReview-Commit-ID: 3hmptLbxxok
--HG--
extra : rebase_source : 50044c27fbf6915a36f6a52d3cec7f226dc89460
2017-07-19 13:14:53 +08:00
Xidorn Quan
6bd73cdf47
Bug 1364260 - Don't require whitespace between keywords and parens in supports rule condition. r=dbaron
...
MozReview-Commit-ID: B7GsrDQ6NuO
--HG--
extra : rebase_source : 1e768a6d9baeae290d35221520a28487f705f50a
2017-07-20 15:33:09 +10:00
Brian Birtles
267881f1f1
Bug 1381389 - Append PropertyValuePair objects on Gecko side so they are initialized correctly; r=hiro
...
Without this mValue may end up looking like a valid nsCSSValue object and bad
things will happen when we try to clone it.
We could just assign mem::zeroed() to mValue but this array hacking on the Servo
side is already pretty nasty and mSimulateComputeValuesFailure would still
remain unassigned (and if we did try to assign it on the Servo side we'd need to
only assign it in debug builds). Unless this proves performance-critical, it's
probably best to just do this on the Gecko side.
MozReview-Commit-ID: 75nFsflhZUM
--HG--
extra : rebase_source : 0e5d94a7f6fdb6768983ba440a3ea69d65cbffbf
2017-07-20 14:38:54 +09:00
Mike Taylor
9a537f511f
Bug 1330146. Remove windows-xp and windows-vista as values for -moz-os-version from tests. r=dholbert
...
The functionality was removed in Bug 1325503. The reason these tests didn't start failing is because
they just test the parsability of the media feature and its' value, not that it does anything useful.
MozReview-Commit-ID: 6a0nlKhUZTQ
--HG--
extra : rebase_source : bddafd6cba332368d05b75ca44b58ad1575b8f12
2017-07-19 11:44:24 -05:00
Wes Kocher
b5bcc4905e
Merge inbound to central, a=merge CLOSED TREE
...
MozReview-Commit-ID: CBL7SUEUGKV
2017-07-19 17:29:56 -07:00
Andrew Osmond
02e515fc18
Bug 1359833 - Part 5. Callers pass the loading document to imgRequestProxy::SyncClone and GetStaticRequest. r=tnikkel
2017-07-19 14:15:11 -04:00
Dão Gottwald
4b7389da4e
Bug 1379938 - Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it. r=jimm
...
MozReview-Commit-ID: 9zMr9JwkloF
--HG--
extra : rebase_source : 25e9cfa11dc0c3ff09e4e3aac18a53535cbcc27b
2017-07-19 16:38:49 +02:00
Wes Kocher
0fbb3c91c2
Bug 1341102 - Update expectations a=bustage CLOSED TREE
...
MozReview-Commit-ID: KKVZ2nUGvdO
2017-07-18 21:04:25 -07:00
Xidorn Quan
202b3a121a
No bug - Update bug numbers in stylo-failures.md.
...
MozReview-Commit-ID: 1S5Y3PGrVV
--HG--
extra : rebase_source : dd5e95bf0d9b35d27c7136abe92e56bce51bdbe7
2017-07-19 11:53:43 +10:00
Emilio Cobos Álvarez
bc043d6e4c
Bug 1381682: Crashtest. r=heycam
...
MozReview-Commit-ID: yg3Kv0MREp
--HG--
extra : rebase_source : 3aafb10820d59afa8424058dbcacfb98095125d9
2017-07-19 12:57:53 +02:00
Emilio Cobos Álvarez
dde6942936
Bug 1381764 - style: More ComputedValuesInner cleanup. r=Manishearth on a CLOSED TREE
...
MozReview-Commit-ID: 8rkAP3pMEpD
2017-07-18 16:22:33 -07:00
Emilio Cobos Álvarez
9a6ef770c1
Bug 1381764: Cleanup the Gecko bits. r=manishearth
...
MozReview-Commit-ID: dbVDy1u4vp
2017-07-18 16:22:00 -07:00
Emilio Cobos Álvarez
2eaa179077
Bug 1381764 - stylo: remove unused Servo_StyleContext_NewContext ; r=manishearth
...
MozReview-Commit-ID: A9BSuTw0GR8
2017-07-18 16:21:31 -07:00
Ryan VanderMeulen
84f63b9d2f
Merge m-c to autoland. a=merge
2017-07-18 12:52:05 -04:00
Ryan VanderMeulen
366f48ad7e
Merge inbound to m-c. a=merge
2017-07-18 12:14:50 -04:00
Christoph Kerschbaumer
87798d9abf
Bug 1337270 - Convert tests within layout/ to not rely on principal inheritance for data: URIs. r=smaug
2017-07-18 07:50:07 +02:00
Manish Goregaokar
853e9c4ad3
Bug 1341102 -Fix forward declaration in nsStyleContext.h; r=bustage
...
MozReview-Commit-ID: 9RBzxkc9wnA
2017-07-18 08:19:14 -07:00
Simon Sapin
84190843a9
Bug 1344131 - Add a gtest bench for Servo_DeclarationBlock_SetPropertyById. r=emilio
...
MozReview-Commit-ID: 83Ryi6CKTLV
--HG--
extra : rebase_source : 58072db21d12bb77f7a994e3873914e79c8ecc0a
2017-07-18 08:58:11 +02:00
Manish Goregaokar
7e4c368898
Bug 1341102 - Make stylo tests pass again; r=bustage
...
MozReview-Commit-ID: 9RBzxkc9wnA
2017-07-18 07:44:55 -07:00
Manish Goregaokar
555536eb67
Bug 1367904 - Part 18: stylo: Move binding functions to ServoBindingList.h; r=bustage
...
We generate stubs in nonstylo mode if these are in this file
MozReview-Commit-ID: 4gCGtlTSvg2
2017-07-18 00:20:05 -07:00
Manish Goregaokar
d60a2ee956
Bug 1367904 - Part 18: stylo: Mark visited failures as expected; r=jryans
...
MozReview-Commit-ID: 7NPypw2ldSJ
2017-07-17 21:01:40 -07:00
Manish Goregaokar
27f49a8a16
Bug 1367904 - Part 17: stylo: Clean up GetContext, call it UpdateWithElementState; r=bholley
...
MozReview-Commit-ID: I23w5hFatk8
2017-07-17 21:01:33 -07:00
Manish Goregaokar
2508f1fac9
Bug 1367904 - Part 16: stylo: Stop using mStyleIfVisited in Servo; r=bholley
...
MozReview-Commit-ID: JxoMr6fz7lh
2017-07-17 21:01:23 -07:00
Manish Goregaokar
cdb73416fd
Bug 1367904 - Part 14: stylo: Remove FFI calls for fetching style structs from ServoComputedValues; r=bholley
...
MozReview-Commit-ID: 2HrVZl9HZu1
2017-07-17 21:01:10 -07:00
Manish Goregaokar
3597e8df2e
Bug 1367904 - Part 13: stylo: Flatten ServoComputedValues into ServoStyleContext; r=bholley
...
This patch also removes the duplication of style contexts during the
restyle, because otherwise pointer equality of ServoComputedValues stops
holding (and we assert on that in a few places)
MozReview-Commit-ID: 7Evc1p8ZfM2
2017-07-17 21:01:02 -07:00
Manish Goregaokar
d909c5cea0
Bug 1367904 - Part 11: stylo: Use ServoStyleContext in ServoStyleSet/ServoRestyleManager; r=bholley
...
MozReview-Commit-ID: JJOBixTSCZq
2017-07-17 21:00:54 -07:00
Manish Goregaokar
f33beecc59
Bug 1367904 - Part 10: stylo: Switch Gecko over to ServoStyleContext; r=bholley
...
MozReview-Commit-ID: EmopKVjEzlz
2017-07-17 21:00:46 -07:00
Manish Goregaokar
ead2d89220
Bug 1367904 - Part 6: stylo: Introduce ComputedValuesInner; r=bholley
...
MozReview-Commit-ID: 7BU0Pzhuul3
2017-07-17 21:00:39 -07:00
Manish Goregaokar
c2b070c584
Bug 1367904 - Part 5: stylo: Make GetBaseComputedValuesForElement return a style context; r=bholley
...
MozReview-Commit-ID: K5WpWc26xNZ
2017-07-17 21:00:32 -07:00
Manish Goregaokar
387babf22c
Bug 1367904 - Part 4: stylo: Replace real ComputedValues with bindgenned ComputedValues2; r=bholley
...
MozReview-Commit-ID: GRkycXueUVr
2017-07-17 21:00:25 -07:00
Manish Goregaokar
25536ab88d
Bug 1367904 - Part 3: stylo: Use RawOffsetArc in ComputedValues; r=bholley
...
MozReview-Commit-ID: 1zexSgkcQv0
2017-07-17 21:00:14 -07:00
Manish Goregaokar
ab2615effa
Bug 1367904 - Part 1: stylo: Create C++-side ServoComputedValues; r=bholley
...
MozReview-Commit-ID: 1k7KFShSHAY
2017-07-17 21:00:07 -07:00
Hiroyuki Ikezoe
e18f89a758
Bug 1381431 - Crashtest that takes snapshots. r=emilio
...
This test case takes snapshots so that the snapshots were handled during
animation-only restyle without prior patches in this patch series. That means
this test crashed without those prior patches.
To be clear, below assertions were hit respectively.
debug_assert!(!shared_context.traversal_flags.for_animation_only()) in
invalidate_style_if_needed()
debug_assert!(element.has_current_styles(&*data) in Servo_ResolveStyle()
MozReview-Commit-ID: AfwQiNcVWji
--HG--
extra : rebase_source : b744bbe0b91ac2bc8c714a5161f3c29bfa5a9cd8
2017-07-18 20:56:15 +09:00
Hiroyuki Ikezoe
607348ba52
Bug 1381431 - Allow that restyle hints other than animation hints remain for flushing throttle animations. r=emilio
...
MozReview-Commit-ID: GMkgvaK0mAu
--HG--
extra : rebase_source : 76b9cc6ab1b49b8e3b59c96915f9b72ccbe19970
2017-07-18 20:56:15 +09:00
Emilio Cobos Álvarez
8ea66df98c
Bug 1381276: Reftest. r=jryans
...
MozReview-Commit-ID: IJUFMtWNETe
--HG--
extra : rebase_source : 33939817156e422138ddd510814b90ecb9363c41
2017-07-16 16:20:38 +02:00
Brad Werth
cda3222945
Bug 1359834 Part 3: Force changes to shape-outside to trigger reflow and overflow recalculation. r=dholbert
...
MozReview-Commit-ID: 7EgYZIu7aZ9
--HG--
extra : rebase_source : ab56ff5a7c6be8972e6a3a8fd4afc84c0fe390c8
2017-07-14 17:26:30 -07:00
Brad Werth
dce3ff515e
Bug 1359834 Part 2: Define a new nsChangeHint_ReflowHintsForFloatAreaChange hint and use it for float changes. r=dholbert
...
MozReview-Commit-ID: 692GBiRUTab
--HG--
extra : rebase_source : 4b3413bb0468037ab5eb25101b7c2a54cdc63d9e
2017-07-14 17:20:35 -07:00
Brad Werth
5e7b4d5092
Bug 1359834 Part 1: Change nsStyleDisplay::CalcDifference to early exit when hinting nsChangeHint_ReconstructFrame. r=dholbert
...
If we'll be reconstructing frames for the subtree in question, then we'll also
be reflowing and repainting that whole subtree. So all of this function's
other changehints become unnecessary and redundant.
MozReview-Commit-ID: 7R9lARBU7vZ
--HG--
extra : rebase_source : 69904e5920b01c54ffee2698518448bed800994a
2017-07-14 17:16:47 -07:00
Emilio Cobos Álvarez
cb320a6d5d
Bug 1380918: Update expectations. r=me
...
MozReview-Commit-ID: 70Z2xx8RjQ9
2017-07-17 12:20:49 +02:00
Emilio Cobos Álvarez
75746a851c
Bug 1380789: followup: Fixup alignment in macro definitions. r=whitespace-only
...
MozReview-Commit-ID: qNrmZMdKTE
2017-07-15 16:19:40 +02:00
Emilio Cobos Álvarez
d18cca3dc7
Bug 1380789: Uplift the type assertions to nightly. r=heycam
...
I don't think there has been going any type confusion so far, but worth catching
them sooner than later.
MozReview-Commit-ID: CBzSFDnUokh
2017-07-15 16:10:21 +02:00
Wes Kocher
70f22fba79
Bug 1381045 - Remove CSS source text from parsing errors. r=bholley a=bustage
...
MozReview-Commit-ID: EJGdEc50Gpl
2017-07-15 01:10:13 -07:00
Hiroyuki Ikezoe
a4f183c102
Bug 1371450 - Crash test. r=emilio
...
The crash test causes a panic in Servo_ResolveStyle on debug build without this
patch series. The reason why we send mouse move event twice is that one for
E10S and the other one is for non-E10S. It seems to be caused by being
requestIdleCallback processed on different timing.
MozReview-Commit-ID: 7cBmwhE9HDk
--HG--
extra : rebase_source : a74aa277e2b161b1e4f8da27293cf89ddc3821e1
2017-07-15 13:16:15 +09:00
Hiroyuki Ikezoe
439420deeb
Bug 1371450 - Recreate style context only if the element was restyled during the traversal. r=emilio
...
MozReview-Commit-ID: CBYTB5FeikP
--HG--
extra : rebase_source : e40d357ae70f9852e5b90eb6f3c41565bf1570a6
2017-07-15 13:16:11 +09:00
Hiroyuki Ikezoe
654bcef113
Bug 1371450 - Preserve restyle hints after ForThrottledAnimationFlush restyle. r=emilio
...
Those remaining restyle hints are needed for normal traversal later.
MozReview-Commit-ID: DswGYGQwgfw
--HG--
extra : rebase_source : e493d964454315e1c9d1dcf7a028976eef1e60a9
2017-07-15 13:09:35 +09:00
Hiroyuki Ikezoe
c040adf510
Bug 1371450 - Rename TraversalRestyleBehavior::ForAnimationOnly to TraversalRestyleBehavior::ForThrottledAnimationFlush. r=birtles,emilio
...
ForAnimationOnly is somewhat misleading, it means actually we process
*only* animation-only restyle without normal restyle. The purpose of
ForAnimationOnly is for updating throttled animations to get correct position
of the animations when we need to handle events. Currently we do also update
unthrottled animations though.
MozReview-Commit-ID: HBCCluKrZs9
--HG--
extra : rebase_source : bb37080e44b161b8b0210e3ba3c055604cf43a72
2017-07-15 13:08:47 +09:00
Jonathan Chan
4a6248b9a6
Bug 1355380 - Part 2: Make Servo's rounding of image-orientation values agree with Gecko's, and pass orientations directly as an enum instead of as angles. r=manishearth
...
Both Servo and Gecko store the specified value of the image-orientation
property as a single-precision float, but Gecko does the conversion to radians
and the computation to identify which quarter-turn the angle is closest to
using doubles.
We add Angle::radians64 to perform the conversion to radians using doubles,
just as Gecko does, and then update image_orientation to perform the
computation the same exact way Gecko does in
nsStyleImageOrientation::CreateAsAngleAndFlip. This lets the previously failing
reftests pass.
We also update Gecko_SetImageOrientation to take an orientation directly
instead of an angle (otherwise we'd be doing the which-quarter-turn-is-closest
computation twice).
Finally this lets us re-enable the reftests for image-orientation previously
marked as fails-if(styloVsGecko||stylo).
MozReview-Commit-ID: 2zMMzQlsYEC
--HG--
extra : rebase_source : 99ed023e940193d4ad735a9ee27e45929a1efda1
2017-07-10 11:32:08 -07:00
Jonathan Chan
016ee566a7
Bug 1355380 - Part 1: Have nsStyleImageOrientation::CreateAsAngleAndFlip handle negative angles correctly. r=manishearth
...
Previously we just took the input angle mod 2π, which will leave negative input
angles as negative. By checking if the input mod 2π is negative and if so
adding 2π and then taking that mod 2π again we can ensure that we end up with a
an angle in the range [0, 2π].
We only do this if the result of the initial mod is negative because this adds
rounding error that is enough to mess up whether 135 is determined to be closer
to 90 or 180, for example.
We add a test for this as well.
Also fix property_database.js to account for this (we assert that -90deg should
compute to the same value as the initial value, but it should actually compute
to 270deg).
MozReview-Commit-ID: Faf0f7wIEg3
--HG--
extra : rebase_source : 6b2d15f90e541fcb8b6083e15772eee514603e57
2017-07-07 16:03:37 -07:00
Nazım Can Altınova
53247946bc
Bug 1341802 - Update test expectations after servo/servo#17737 r=me
2017-07-14 18:10:12 -07:00
Wes Kocher
ee45f814bb
Merge m-c to autoland, a=merge
...
MozReview-Commit-ID: GOb2bgdUd36
2017-07-14 17:27:36 -07:00
Wes Kocher
e9fa5c772a
Merge inbound to central, a=merge
...
MozReview-Commit-ID: 8nlqm5dHCUQ
2017-07-14 17:14:43 -07:00
Josh Matthews
4d369649f6
Bug 1380488 - Share CSS source line between all same-line errors. r=heycam
2017-07-14 10:53:11 -04:00
Andrew McCreight
bf7fff95f0
Bug 1379786, part 4 - Use GetIsSystemPrincipal() method instead of going through secman in CHECK_PRINCIPAL_AND_DATA. r=mrbkap
...
MozReview-Commit-ID: INBsjjxbXZz
--HG--
extra : rebase_source : fd6d491d01acc70be1bf51e25ec31bbcde81344a
2017-07-10 15:00:03 -07:00
J. Ryan Stinnett
835cab2d73
Bug 1380082 - Don't Stylo check pref directly in tests. r=xidorn
...
Stylo might be enabled by either env var or pref. Use the existing
DOMWindowUtils method to test for Stylo instead of the pref to get an accurate
value.
MozReview-Commit-ID: 8p22xCBjHjo
--HG--
extra : rebase_source : 1a5524e22be07a712838ac5a2ac0bec0cc65dfa7
2017-07-12 13:03:15 -05:00
Ryan VanderMeulen
019bd042fc
Merge autoland to m-c. a=merge
2017-07-14 09:16:03 -04:00
Andrea Marchesini
50f9ea47a3
Bug 1350958 - Finish labeling ProxyReleaseEvent, r=billm
2017-07-14 08:49:22 +02:00
Sebastian Hengst
e501c9c454
Backed out changeset ed0d72af39b8 (bug 1359834) for failing mochitest test_inherit_computation.html. r=backout
2017-07-14 10:26:50 +02:00
Cameron McCormack
2a1c9069d0
Bug 1380224 - Part 1: Check custom properties for differences in Servo-backed style contexts. r=emilio
...
MozReview-Commit-ID: IVyiTNxPDT9
--HG--
extra : rebase_source : 3047eb79f4602510251b3453362ffb683f9b818c
2017-07-13 16:49:14 +08:00
Brad Werth
12c3fd32a2
Bug 1359834 Part 1: Force changes to shape-outside to trigger float reflow, similar to other float changes. r=dholbert
...
MozReview-Commit-ID: 7EgYZIu7aZ9
--HG--
extra : rebase_source : a611fcd77d926f1076dfa38b9b7ebf732021aa46
2017-07-12 12:28:29 -07:00
Xidorn Quan
61344f3471
Bug 1355715 - Use empty atom rather than 'empty' atom for none namespace. r=bholley
...
MozReview-Commit-ID: Kqqs198wLUw
--HG--
extra : rebase_source : da6ba0587de2dc6b12769a2d80080e9b60526ebd
2017-07-14 15:31:15 +10:00
Xidorn Quan
b5363842c5
Bug 1363349 followup - Update test expectations for stylo.
...
MozReview-Commit-ID: 3RGl1AWR1jd
2017-07-14 14:14:50 +10:00
Xidorn Quan
2b1d414ed0
Bug 1364274 part 3 - Adjust test expectation. r=heycam
...
MozReview-Commit-ID: GagkRtB8PGv
--HG--
extra : rebase_source : beb99889b8f8c10dda6a95bd9ae45d0bbe789d86
2017-07-05 14:08:45 +10:00
Xidorn Quan
d8a0bd5c97
Bug 1364274 part 2 - Move HAS_TEXT_DECORATION_LINES bit computation back to ApplyStyleFixups. r=heycam
...
MozReview-Commit-ID: vsLnXvJ9UI
--HG--
extra : rebase_source : 37923ac7ab91c75245d14dafa7bef623ce92603b
2017-07-04 16:54:11 +10:00
Xidorn Quan
180940d947
Bug 1364274 part 1 - Propagate style bits from Servo ComputedValues to ServoStyleContext. r=heycam
...
MozReview-Commit-ID: KewMPDdX8iy
--HG--
extra : rebase_source : 7e38904b7c5f229e5527b02008cac6459a8bcdc8
2017-07-04 16:49:50 +10:00
Xidorn Quan
a0d0686267
Bug 1378287 - Skip parent-display-based display type fixup for all anonymous boxes. r=bz
...
MozReview-Commit-ID: C4R3sVl83jJ
--HG--
extra : rebase_source : 60eda1019d5aeab0d4faa51a098c2e684fdcbb79
2017-07-05 16:21:10 +10:00
Xidorn Quan
8b68a498ad
Bug 1380800 - Correct index check in ServoStyleSheet.deleteRule. r=heycam
...
MozReview-Commit-ID: GZz0g9x4WdS
--HG--
extra : rebase_source : 8afed2ae8feee82d4636f34d196e8ac40b6ab68b
2017-07-14 13:24:47 +10:00
Kevin Hsieh
35eb1b48d9
bug 1363349 (part 2) - accept calc expressions in webkit gradient r=dholbert
...
MozReview-Commit-ID: IhXyWoJI9Nb
--HG--
extra : rebase_source : 7cbd0018efd49f15e5ab3b45f4af3ff32e0c0de1
2017-07-12 21:42:02 -07:00
Kevin Hsieh
60a08a4706
bug 1363349 (part 1) - refactor CSSCalc.h to share code better, via a templated ReduceCalcOps class r=dholbert
...
MozReview-Commit-ID: IvU2StpKHLm
--HG--
extra : rebase_source : 28eded78186364632c9429e0aff2950945249fe1
2017-07-12 18:13:07 -07:00
Wes Kocher
4c5920f4e7
Merge autoland to central, a=merge CLOSED TREE
...
MozReview-Commit-ID: 4B0VujwK8WG
2017-07-13 15:51:26 -07:00
Dão Gottwald
8f5c440b72
Backed out changeset 5a5d8de65b70 (bug 1379938) on CLOSED TREE
2017-07-13 23:16:12 +02:00
Carsten "Tomcat" Book
260b5f956f
merge mozilla-inbound to mozilla-central a=merge
2017-07-13 16:35:22 +02:00
Dão Gottwald
0f2337c0c7
Bug 1379938 - Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it. r=jimm
...
MozReview-Commit-ID: BkDrm6KtiP3
--HG--
extra : rebase_source : 1c0deb5b77e1ce83a8f157c100606c563d61577c
2017-07-13 11:08:27 +02:00
Emilio Cobos Álvarez
1f95192fbe
Bug 1380492: Test. r=bholley
...
MozReview-Commit-ID: 8oNoEQ6H5K3
2017-07-13 10:20:10 +02:00
Cameron McCormack
0b0b5836f7
Bug 1376964 - Part 9: Use gfxFontSrcPrincipal in the user font set and cache. r=jfkthame
...
MozReview-Commit-ID: LRRFbkhbgts
--HG--
extra : rebase_source : 19164df382db8a4e5e868c4725a0f7c0968ddaa5
2017-07-08 18:00:24 +08:00
Cameron McCormack
9a03f16595
Bug 1376964 - Part 6: Use gfxFontSrcURI in the user font set and cache. r=jfkthame
...
MozReview-Commit-ID: 7eWOTs4kF4v
--HG--
extra : rebase_source : 88ee203da88f3ec5419db7dee87337802d6212ae
2017-07-08 14:10:05 +08:00
Cameron McCormack
5d2c03ca7b
Bug 1376964 - Part 4: Call FontLoadAllowed ahead of time and cache the results for style worker threads. r=jfkthame
...
Handling a document's node principal changing is done in part 9.
MozReview-Commit-ID: 1gPtRpddys5
--HG--
extra : rebase_source : f0b4d07481ae7215117b86c474f14658b61d6f06
2017-07-07 13:35:28 +08:00
Cameron McCormack
ddde8c491b
Bug 1376964 - Part 2: Record the docshell's "private browsing" flag on FontFaceSet. r=jfkthame
...
MozReview-Commit-ID: 3j0RISufybF
--HG--
extra : rebase_source : 1760c11c3f25fc04c0fc6516d8e23d283d567831
2017-07-05 17:41:01 +08:00
Cameron McCormack
e0895d8727
Bug 1376964 - Part 1: Record the docshell's "bypass cache" flag on FontFaceSet. r=jfkthame
...
MozReview-Commit-ID: FW19nms4ZEB
--HG--
extra : rebase_source : d09bfd4fc64cd7c9d9c46b926f8a7d939f98c5c7
2017-07-05 17:33:46 +08:00
Carsten "Tomcat" Book
23670f34ad
Merge mozilla-central to autoland
2017-07-13 16:39:36 +02:00
Fernando Jimenez Moreno
5196e276c8
Bug 1367274 - Update test expectations for test_computed_style.html. r=xidorn
...
MozReview-Commit-ID: 75fCumq4KrT
--HG--
extra : rebase_source : 9ad049456356f0214579b2016a10e26604ed4923
2017-07-13 14:34:43 +02:00
Nazım Can Altınova
115d62bf0a
Bug 1341802 - Update test expectations for servo/servo#17692 r=me
...
MozReview-Commit-ID: GDrzV9W2pXj
2017-07-12 15:54:00 -07:00
Jonathan Chan
9a920e6268
Bug 1375153 - Move nsStyleContext::mComputingStruct and AutoCheckDependency to GeckoStyleContext. r=manishearth
...
These are only used in Gecko mode.
MozReview-Commit-ID: DKQBwatbu62
--HG--
extra : rebase_source : 32fb108832e973bef04ef9c18d8ccc22059b58e4
2017-06-21 11:46:11 -07:00
Xidorn Quan
faff62bad1
Bug 1348488 part 2 - Update mochitest expectations. r=heycam
...
MozReview-Commit-ID: HQ0krmMVhnP
--HG--
extra : rebase_source : 3961d7d976afc76c80832e660f33dcf6f2be8f12
2017-07-10 20:11:24 +10:00
Xidorn Quan
2325d06b36
Bug 1348488 part 1 - Capitalize name of tree pseudo-elements to match other anonboxes. r=heycam
...
MozReview-Commit-ID: 5TRHwTwkY0O
--HG--
extra : rebase_source : 714b7ecb7c817a14e1f3649d74b5f339dd5e570d
2017-07-10 10:26:25 +10:00
Carsten "Tomcat" Book
18f3dbf742
Backed out changeset aaacb772bada (bug 1376964) for bustage - error C2143: syntax error
2017-07-12 12:41:57 +02:00
Carsten "Tomcat" Book
12b87e384a
Backed out changeset c0e5f138b42a (bug 1376964)
2017-07-12 12:41:39 +02:00
Carsten "Tomcat" Book
23de9ec977
Backed out changeset 6bfb66a2c03e (bug 1376964)
2017-07-12 12:41:35 +02:00
Carsten "Tomcat" Book
614a232c25
Backed out changeset d9a88d8324ff (bug 1376964)
2017-07-12 12:41:31 +02:00
Carsten "Tomcat" Book
4177255107
Backed out changeset 041b34959d76 (bug 1376964)
2017-07-12 12:41:25 +02:00
Wei-Cheng Pan
ef1ad5c8c6
Bug 1366964 - Update style context generation after style resolved. r=heycam
...
Adds another restyle generation which represents the dirty state of raw
style changes, so that getComputedStyle() wont be confused by optimizations
made by style engines.
MozReview-Commit-ID: 7RYeNCzFygO
--HG--
extra : rebase_source : e2a6bd73f4b2b71115abe68b5cce95be57cbd9b2
2017-05-23 14:13:47 +08:00
Cameron McCormack
82079904e6
Bug 1376964 - Part 9: Use gfxFontSrcPrincipal in the user font set and cache. r=jfkthame
...
MozReview-Commit-ID: LRRFbkhbgts
--HG--
extra : rebase_source : 1dac8a8e9a817edb086bb75f9f842c1d4df37a1a
2017-07-12 16:36:42 +08:00
Cameron McCormack
47621aa57e
Bug 1376964 - Part 6: Use gfxFontSrcURI in the user font set and cache. r=jfkthame
...
MozReview-Commit-ID: 7eWOTs4kF4v
--HG--
extra : rebase_source : 9cb5a0f71ad756b224ebc01d13437a8113e53bb1
2017-07-12 16:36:14 +08:00
Cameron McCormack
a6f94afca7
Bug 1376964 - Part 4: Call FontLoadAllowed ahead of time and cache the results for style worker threads. r=jfkthame
...
Handling a document's node principal changing is done in part 9.
MozReview-Commit-ID: 1gPtRpddys5
--HG--
extra : rebase_source : def889e9ae4a428ccc02f9b5ac18f2ce640dc652
2017-07-12 16:35:46 +08:00
Cameron McCormack
bb7733edcd
Bug 1376964 - Part 2: Record the docshell's "private browsing" flag on FontFaceSet. r=jfkthame
...
MozReview-Commit-ID: 3j0RISufybF
--HG--
extra : rebase_source : 265a46c59b14af4d9e66688942408533c1cb94e1
2017-07-12 16:35:44 +08:00
Cameron McCormack
1f2b492e8c
Bug 1376964 - Part 1: Record the docshell's "bypass cache" flag on FontFaceSet. r=jfkthame
...
MozReview-Commit-ID: FW19nms4ZEB
--HG--
extra : rebase_source : c6407c336cd3187ed66781f717bff079616c97ba
2017-07-12 16:35:44 +08:00
Emilio Cobos Álvarez
dc33155ad6
Bug 1379505: Allow calling GetBaseComputedStylesForElement for an unstyled element. r=boris
...
Before this refactoring, getComputedStyle could have side effects, and left the
style data in the element, so we could never arrive there without data.
There are a few crashtests that caught this, but this was already broken if you
called animate() on an element deep in a display: none subtree.
MozReview-Commit-ID: 1AvOvhAyOP3
--HG--
extra : rebase_source : 0a920df8809961f784026a14a624d8eafb4cc79f
2017-07-10 13:33:21 +02:00
Carsten "Tomcat" Book
e011fd3d19
Backed out changeset 99c0d338a5f3 (bug 1376964) for bustage
2017-07-12 10:33:05 +02:00
Carsten "Tomcat" Book
071507c082
Backed out changeset 04e9846700ae (bug 1376964)
2017-07-12 10:32:24 +02:00
Carsten "Tomcat" Book
532a99b12a
Backed out changeset 20866468f52d (bug 1376964)
2017-07-12 10:32:20 +02:00
Carsten "Tomcat" Book
625eb4c653
Backed out changeset 292d20d46d1f (bug 1376964)
2017-07-12 10:32:16 +02:00
Carsten "Tomcat" Book
c897b5dc70
Backed out changeset b7424dfa039c (bug 1376964)
2017-07-12 10:32:11 +02:00
Cameron McCormack
2fe9111db4
Bug 1376964 - Part 9: Use gfxFontSrcPrincipal in the user font set and cache. r=jfkthame
...
MozReview-Commit-ID: LRRFbkhbgts
--HG--
extra : rebase_source : 0fa11b180383795272e7a5daf87a41a5c51ec221
2017-07-12 13:03:35 +08:00
Cameron McCormack
0732a234be
Bug 1376964 - Part 6: Use gfxFontSrcURI in the user font set and cache. r=jfkthame
...
MozReview-Commit-ID: 7eWOTs4kF4v
--HG--
extra : rebase_source : eba5d82be3cbbeaa64a7e5f677ba365ac8aeac29
2017-07-12 13:03:35 +08:00
Cameron McCormack
b2cd9f4a51
Bug 1376964 - Part 4: Call FontLoadAllowed ahead of time and cache the results for style worker threads. r=jfkthame
...
Handling a document's node principal changing is done in part 9.
MozReview-Commit-ID: 1gPtRpddys5
--HG--
extra : rebase_source : 5b1d40af5ad0484440075e7229dc9ae3d5a13764
2017-07-12 13:03:35 +08:00
Cameron McCormack
4f22849692
Bug 1376964 - Part 2: Record the docshell's "private browsing" flag on FontFaceSet. r=jfkthame
...
MozReview-Commit-ID: 3j0RISufybF
--HG--
extra : rebase_source : a4d3ebbed3e0bd8fd9416e44704340dbfbb16dc8
2017-07-12 13:03:35 +08:00
Cameron McCormack
e90c1651ea
Bug 1376964 - Part 1: Record the docshell's "bypass cache" flag on FontFaceSet. r=jfkthame
...
MozReview-Commit-ID: FW19nms4ZEB
--HG--
extra : rebase_source : 882032102cc8096556e7607759c0297430ed04cd
2017-07-12 13:03:35 +08:00
Brian Birtles
ca33c400b5
Bug 1370123 - Make aContent parameter to nsComputedDOMStyle::GetPresShellForContent const; r=xidorn
...
MozReview-Commit-ID: 8eZ7JmgE1XY
--HG--
extra : rebase_source : 75137336edaab18b1b6a8d321fafc954e9c44f9c
2017-06-19 12:21:17 +09:00
Brian Birtles
1fe4c641fc
Bug 1379582 - Disable frames() timing function using a pref on release/beta channels; r=hiro
...
MozReview-Commit-ID: 4B8NwMAfyrS
--HG--
extra : rebase_source : 08becf963a57eda8e335b1c43672b25a25dbd81d
2017-07-12 08:41:58 +09:00
Sebastian Hengst
534b714ff2
Backed out changeset a5f2d33a9de3 (bug 1355380) for failing mochitest layout/style/test/test_value_computation.html. r=backout
2017-07-12 00:10:32 +02:00
Sebastian Hengst
313b7a8917
Backed out changeset f2836ff575eb (bug 1355380)
2017-07-12 00:09:56 +02:00
Nicholas Nethercote
c86dc10505
Bug 1380227 - Avoid many UTF16toUTF8 and UTF8toUTF16 conversions in nsStringBundle. r=emk.
...
Most of the names passed to nsIStringBundle::{Get,Format}StringFromUTF8Name
have one of the two following forms:
- a 16-bit C string literal, which is then converted to an 8-bit string in
order for the lookup to occur;
- an 8-bit C string literal converted to a 16-bit string, which is then
converted back to an 8-bit string in order for the lookup to occur.
This patch introduces and uses alternative methods that can take an 8-bit C
string literal, which requires changing some signatures in other methods and
functions. It replaces all C++ uses of the old methods.
The patch also changes the existing {Get,Format}StringFromName() methods so
they take an AUTF8String argument for the name instead of a wstring, because
that's nicer for JS code.
Even though there is a method for C++ code and a different one for JS code,
|binaryname| is used so that the existing method names can be used for the
common case in both languages.
The change reduces the number of NS_ConvertUTF8toUTF16 and
NS_ConvertUTF16toUTF8 conversions while running Speedometer v2 from ~270,000 to
~160,000. (Most of these conversions involved the string
"deprecatedReferrerDirective" in nsCSPParser.cpp.)
--HG--
extra : rebase_source : 3bee57a501035f76a81230d95186f8c3f460ff8e
2017-07-12 15:13:37 +10:00
Jonathan Chan
f49acecfb4
Bug 1355380 - Part 2: Make Servo's rounding of image-orientation values agree with Gecko's, and pass orientations directly as an enum instead of as angles. r=manishearth
...
Both Servo and Gecko store the specified value of the image-orientation
property as a single-precision float, but Gecko does the conversion to radians
and the computation to identify which quarter-turn the angle is closest to
using doubles.
We add Angle::radians64 to perform the conversion to radians using doubles,
just as Gecko does, and then update image_orientation to perform the
computation the same exact way Gecko does in
nsStyleImageOrientation::CreateAsAngleAndFlip. This lets the previously failing
reftests pass.
We also update Gecko_SetImageOrientation to take an orientation directly
instead of an angle (otherwise we'd be doing the which-quarter-turn-is-closest
computation twice).
Finally this lets us re-enable the reftests for image-orientation previously
marked as fails-if(styloVsGecko||stylo).
MozReview-Commit-ID: 2zMMzQlsYEC
--HG--
extra : rebase_source : c6ead4358a2b4fb052f6144959cea0ba79b985e2
2017-07-10 11:32:08 -07:00
Jonathan Chan
3b1150a8cb
Bug 1355380 - Part 1: Have nsStyleImageOrientation::CreateAsAngleAndFlip handle negative angles correctly. r=manishearth
...
Previously we just took the input angle mod 2π, which will leave negative input
angles as negative. By checking if the input mod 2π is negative and if so
adding 2π and then taking that mod 2π again we can ensure that we end up with a
an angle in the range [0, 2π].
We only do this if the result of the initial mod is negative because this adds
rounding error that is enough to mess up whether 135 is determined to be closer
to 90 or 180, for example.
We add a test for this as well.
MozReview-Commit-ID: Faf0f7wIEg3
--HG--
extra : rebase_source : 6a83824bdc8104f0d58d6e2b11cf6bfd6bfef7f0
2017-07-07 16:03:37 -07:00
Bobby Holley
509fba7d22
Bug 1379893 - Null-check the presshell in Gecko_GetStyleContext. r=emilio
...
MozReview-Commit-ID: EWTmhXnl64P
2017-07-11 10:42:57 -07:00
Xidorn Quan
02a9b7a416
Bug 1364289 - Update mochitest expectation. r=manishearth
...
MozReview-Commit-ID: jgwZ7zStZM
--HG--
extra : rebase_source : f891b99c14c49abd89a249f91005d8df9630bd40
2017-07-11 13:53:33 +10:00
Cameron McCormack
81de43d854
Bug 1376406 - Make ::before and ::after the only pseudos that do parent display-based style fixup. r=dbaron
...
MozReview-Commit-ID: Hxq8v1NSYvc
--HG--
extra : rebase_source : c5998f82446f078dcead1c6aa49d6b38296929ce
2017-07-11 10:38:23 +08:00
Josh Matthews
5e234de828
Bug 1352669 - Address failing CSS parser error tests. r=emilio
...
MozReview-Commit-ID: KfcpLYLIIve
2017-07-10 16:24:00 -04:00
Josh Matthews
e0c37f0ed3
Bug 1352669 - Hook up Stylo CSS parser to Gecko error reporter. r=emilio
...
MozReview-Commit-ID: 3r5Z6KiPgRM
2017-07-10 17:52:00 -04:00
Hiroyuki Ikezoe
ff401a20cf
Bug 1379529 - drop AllowResolveStaleStyles flag. r=emilio
...
It's no longer used since bug 1357142.
MozReview-Commit-ID: LqNQTux2OZl
--HG--
extra : rebase_source : 6022601c76b5cec8cab2ac1039e489c624044329
2017-07-11 07:51:34 +09:00
J. Ryan Stinnett
987e7462ad
Bug 1377975 - Test cascading pseudos during link transitions. r=hiro
...
MozReview-Commit-ID: LLNhhfIvPuy
2017-07-10 16:24:00 -05:00
Hiroyuki Ikezoe
247abcf7b1
Bug 1360398 - Do not fill computed values in missing keyframes for CSS animations during generating Keyframes. r=birtles
...
MozReview-Commit-ID: C2dYneoB09g
--HG--
extra : rebase_source : 13e31e0eb370086cef45cde79783dfee8192a7f1
2017-07-10 17:19:23 +09:00
Xidorn Quan
aa1f5767c8
Bug 1372464 - Use ComputedValues rather than element to get style rule list. r=heycam
...
MozReview-Commit-ID: JPBbhrxG0Lh
--HG--
extra : rebase_source : 5bec19320bd8fa04efc37bd9301f6f9ecb95ca19
2017-07-10 09:38:58 +10:00
Emilio Cobos Álvarez
4358a07aad
Bug 1379433: Test. r=heycam
...
MozReview-Commit-ID: EsDTzjLkqVk
--HG--
extra : rebase_source : 9dd98c3d058fafa993b60d7f15012c1ffedcc0ad
2017-07-09 04:16:20 +02:00
Sebastian Hengst
d00887532b
merge mozilla-inbound to mozilla-central. r=merge a=merge
...
MozReview-Commit-ID: IZdWUL0ee1b
2017-07-09 11:19:35 +02:00
Ralph Giles
2108ee3e4e
Bug 1368083 - Pass -isysroot to bindgen. r=gps
...
When cross-compiling, rust-bindgen needs the -isysroot
flag we pass to the C++ compiler to find the correct
headers. Add a new BINDGEN_CFLAGS environment variable
for passing this and other relevant options, and reformat
its contents in toolchain.configure so we can use autoconf-
style template substitution to poke it into a bindgen.toml
file to be read by build scripts like build_gecko.rs.
Set this variable from the macosx/cross-mozconfig.common
to the same extra flags we pass to CXX so automation
builds work correctly with --enable-stylo.
MozReview-Commit-ID: 7wabObiFtVb
--HG--
extra : rebase_source : eeba30e3d64112da65e2e6830ef5fc1b54965529
2017-07-06 11:34:03 -07:00
Ehsan Akhgari
4390e804ca
Bug 1379308 - Improve the hash key generation for two of the hashtables in nsCSSRuleProcessor.cpp; r=mats
2017-07-07 20:34:46 -04:00
Tom Tromey
28e8f458a9
Bug 1306887 - keep SourceMap response header on CSS style sheets; r=bz,heycam
...
When loading a style sheet, if the SourceMap (or legacy X-SourceMap)
response header was seen, record it and make it available to chrome
scripts.
MozReview-Commit-ID: 3wtUADzgrI3
--HG--
extra : rebase_source : 25ed09e264d4b3a679ae970c709dedd4d50e2324
2017-06-28 16:51:46 -07:00
Nazım Can Altınova
b7a6fecc24
Bug 1341802 - Update test expectations for servo/servo#17630 r=me
...
MozReview-Commit-ID: 12z0j9IayGd
2017-07-07 00:09:12 -07:00
Hiroyuki Ikezoe
f0c746144f
Bug 1374175 - Return no damage if there is no display property changes. r=heycam
...
MozReview-Commit-ID: 8VUu7UcnMmb
--HG--
extra : rebase_source : 5f56cf1a17a5aabcd5d7fcf4d25ac2fa09fe1b8c
2017-06-29 13:22:42 -07:00
Sylvestre Ledru
4e9cf83ee8
Bug 1378712 - Remove all trailing whitespaces r=Ehsan
...
MozReview-Commit-ID: Kdz2xtTF9EG
--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Wes Kocher
a9eb08898f
Backed out changeset f220d8060c14 (bug 1352669) for build bustage CLOSED TREE a=bustage
...
MozReview-Commit-ID: INYGT4WT1pO
2017-07-06 14:56:06 -07:00
Wes Kocher
a394cec826
Backed out changeset 40ac529f9ea0 (bug 1352669) for build bustage CLOSED TREE
...
MozReview-Commit-ID: GvzTtvlt4qi
2017-07-06 14:55:26 -07:00
Josh Matthews
decbe41e0b
Bug 1352669 - Address failing CSS parser error tests.
...
MozReview-Commit-ID: KfcpLYLIIve
2017-07-06 13:20:59 -07:00
Josh Matthews
723b20d420
Bug 1352669 - Hook up Stylo CSS parser to Gecko error reporter.
...
MozReview-Commit-ID: 3r5Z6KiPgRM
2017-07-06 13:15:08 -07:00
J. Ryan Stinnett
0338ac2a6a
Bug 1371457 - Update animation restyle tests. r=hiro
...
Update the various animation restyle tests to check the new animation only data
inside the restyle marker.
MozReview-Commit-ID: HEe8x45IhHj
--HG--
extra : rebase_source : fdaa5855e94d68ce2a70d00fde11582c9a538f45
2017-06-29 10:14:31 -07:00
J. Ryan Stinnett
ba1293b3ca
Bug 1371457 - Add restyle markers for Stylo. r=bholley,gregtatum
...
Add restyle markers to `PrepareAndTraverseSubtree` to cover both initial styling
and part of the work of restyling. Also add restyle markers around the post
traversal work in `DoProcessPendingRestyles`.
A new marker is also added around the change hint processing after the post
traversal.
MozReview-Commit-ID: 43PSyCJLikR
--HG--
extra : rebase_source : 923dd3d5526a7d68ab08f86e6dc233c9c61fa97f
2017-06-28 12:03:18 -07:00
Carsten "Tomcat" Book
2178a22de4
Merge mozilla-central to autoland
2017-07-06 11:24:24 +02:00
Carsten "Tomcat" Book
7857fa0a5e
merge mozilla-inbound to mozilla-central a=merge
2017-07-06 11:18:05 +02:00
Xidorn Quan
d5f6047810
Bug 1372790 - Change uint8_t to back some enum and reorder some fields in StyleSheet to make it more compact. r=heycam
...
MozReview-Commit-ID: DddIzhJqmcZ
--HG--
extra : rebase_source : da357c220cea45fcc5af3b8a7421a0b699a01026
2017-06-14 14:26:48 +10:00
Brian Birtles
462794f6fe
Bug 1377053 - Crash test for interpolating zero-length lists in add_weighted; r=hiro
...
MozReview-Commit-ID: DJJlKNZ4GKD
--HG--
extra : rebase_source : a62c269e93ad9840eb50f3acea06c9764658385d
2017-07-06 06:28:11 +09:00
Kartikaya Gupta
4826f32d87
Bug 1377169 - Turn gfxRect into a typedef. r=jrmuizel
...
One thing to note here is that the Scale function on gfxRect has a
different implementation than that in gfx::Rect which is replacing it.
The former just scales the width/height directly whereas the latter
scales the XMost/YMost and recomputes the width/height.
MozReview-Commit-ID: 5FImdIaNfC3
--HG--
extra : rebase_source : 98662d2a52ff9652ec60b066641a07c6d5ee8e08
2017-07-05 11:22:00 -04:00
Carsten "Tomcat" Book
b72c4833d5
merge mozilla-inbound to mozilla-central a=merge
2017-07-05 13:01:22 +02:00
Daisuke Akatsuka
d455bb09bd
Bug 1371115 - Part 12: implements nsStyleImage type properties animatable. r=birtles,hiro
...
In this patch, implements following properties:
* background-image
* border-image-source
* mask-image
MozReview-Commit-ID: 30RdO0fMNr8
--HG--
extra : rebase_source : d4490b4d64e22a3bc1f022c37edc20363f7c0269
2017-07-05 13:53:47 +09:00
Daisuke Akatsuka
c91507eebc
Bug 1371115 - Part 7: implements nsStyleBorder type properties animatable. r=hiro
...
In this patch, implements following properties:
* -moz-border-bottom-colors
* -moz-border-left-colors
* -moz-border-right-colors
* -moz-border-top-colors
To realize, we introduced a binding method Gecko_GetMozBorderColors.
MozReview-Commit-ID: JeseSyl8rMG
--HG--
extra : rebase_source : 118b6659a7be58f7b84e6024bfeea0a13dad66c0
2017-07-05 13:53:07 +09:00
Phil Ringnalda
22cb9f77bb
Merge m-c to m-i
...
MozReview-Commit-ID: H6zGgEm7oOM
2017-07-04 20:32:07 -07:00
Emilio Cobos Álvarez
7ae63d2e3b
Bug 1378190: Try to make ServoRestyleManager easier to follow. r=heycam
...
MozReview-Commit-ID: B9bw23n2jUe
--HG--
extra : rebase_source : 2fbd43cee1c3b0efafaa51ef6755adcfe6f31598
2017-07-04 19:16:04 +02:00
Bobby Holley
88c42c5965
Bug 1378005 - Stop synchronously clearing serving data on style set teardown. r=emilio
...
MozReview-Commit-ID: 3B2qV84peCv
2017-07-04 15:02:18 -07:00
Cameron McCormack
a43aba7200
Bug 1377256 - Part 2: Crashtest. r=m_kato
...
MozReview-Commit-ID: HRP49wF2Ibe
--HG--
extra : rebase_source : 3e9f922f9613d07d8e594dc806f04c2fa5fcb14e
2017-07-05 07:16:22 +08:00
Mats Palmgren
977a9e5f89
Bug 1376498 part 4 - Make all nsClassHashtable::RemoveAndForget() consumers use Remove() instead. r=froydnj
...
MozReview-Commit-ID: G64YQLlgm6r
2017-07-05 02:01:45 +02:00